Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2443
---
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202684941
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
Nice finding. Will fix it and also will attach source
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202683106
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
The second diagram on the page also mentions Trident. I don't
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202682665
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
Thanks, looks great. I think the dotted line box is missing the
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202678116
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
Just finished it.
---
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202674112
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
Yeah right. I didn't think about that. Drawing a new one.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202653817
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
It would probably be pretty quick to duplicate with e.g.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202650814
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202650588
--- Diff:
sql/storm-sql-external/storm-sql-mongodb/src/jvm/org/apache/storm/sql/mongodb/MongoDataSourcesProvider.java
---
@@ -47,54 +45,60 @@
* The
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202650461
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/StreamsStormRuleSets.java
---
@@ -72,13 +72,13 @@
// merge and push
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202644352
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
We could even do some photo editing but not sure it is
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202639091
--- Diff:
sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java
---
@@ -88,46 +75,12 @@ public void
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202635190
--- Diff:
sql/storm-sql-external/storm-sql-mongodb/src/jvm/org/apache/storm/sql/mongodb/MongoDataSourcesProvider.java
---
@@ -47,54 +45,60 @@
*
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202631700
--- Diff: sql/README.md ---
@@ -1,187 +1,8 @@
# Storm SQL
-Compile SQL queries to Storm topologies.
+Compile SQL queries to Storm
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202632910
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/StreamsStormRuleSets.java
---
@@ -72,13 +72,13 @@
// merge
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202638476
--- Diff:
sql/storm-sql-runtime/src/test/org/apache/storm/sql/TestUtils.java ---
@@ -41,7 +26,46 @@
import java.util.Map;
import
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202638239
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,108 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202633872
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/rel/StreamsStreamInsertRel.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202631939
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -118,16 +138,32 @@ public RelDataType getRowType(
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202638350
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,108 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202631502
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
@srdo
Agreed. Regarding updating the doc, I guess
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202345310
--- Diff: sql/README.md ---
@@ -1,187 +1,8 @@
# Storm SQL
-Compile SQL queries to Storm topologies.
+Compile SQL queries to Storm topologies
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202356815
--- Diff:
sql/storm-sql-external/storm-sql-mongodb/src/jvm/org/apache/storm/sql/mongodb/MongoDataSourcesProvider.java
---
@@ -47,54 +45,60 @@
* The
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202355372
--- Diff:
sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java
---
@@ -88,46 +75,12 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202341073
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
I'm wondering if it would be worth updating this rather than
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202347946
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -118,16 +138,32 @@ public RelDataType getRowType(
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202359820
--- Diff:
sql/storm-sql-runtime/src/test/org/apache/storm/sql/TestUtils.java ---
@@ -41,7 +26,46 @@
import java.util.Map;
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202358383
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202349103
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/StreamsStormRuleSets.java
---
@@ -72,13 +72,13 @@
// merge and push
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202350280
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/planner/streams/rel/StreamsStreamInsertRel.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202344785
--- Diff: docs/storm-sql.md ---
@@ -6,14 +6,14 @@ documentation: true
The Storm SQL integration allows users to run SQL queries over streaming
data
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202357967
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r202282820
--- Diff: docs/storm-sql-internal.md ---
@@ -1,59 +0,0 @@
--- End diff --
I removed the document since it is documented based on
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155672497
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/spout/SocketSpout.java
---
@@ -26,59 +27,61 @@
import
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155661686
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -117,9 +138,21 @@ public TableBuilderInfo
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155656225
--- Diff:
sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java
---
@@ -88,46 +90,13 @@ public void
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155655708
--- Diff:
sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java
---
@@ -88,46 +90,13 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155654493
--- Diff:
sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java
---
@@ -88,46 +90,13 @@ public void
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155653625
--- Diff:
sql/storm-sql-runtime/src/test/org/apache/storm/sql/TestUtils.java ---
@@ -190,363 +191,213 @@ public void open(ChannelContext ctx) {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155651046
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/calcite/ParallelTable.java ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155650878
--- Diff:
sql/storm-sql-external/storm-sql-kafka/src/test/org/apache/storm/sql/kafka/TestKafkaDataSourcesProvider.java
---
@@ -68,62 +70,13 @@
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155650836
--- Diff:
sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java
---
@@ -88,46 +90,13 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155647898
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -117,9 +138,21 @@ public TableBuilderInfo parallelismHint(int
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155647861
--- Diff: sql/storm-sql-core/pom.xml ---
@@ -66,10 +66,34 @@
calcite-core
--- End diff --
Good. Thanks for the reminder. :)
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155647803
--- Diff: sql/storm-sql-core/pom.xml ---
@@ -66,10 +66,34 @@
calcite-core
${calcite.version}
+
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155646360
--- Diff: sql/storm-sql-core/pom.xml ---
@@ -66,10 +66,34 @@
calcite-core
--- End diff --
Sure. I didn't mean to say that you
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155646317
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/spout/SocketSpout.java
---
@@ -26,59 +27,61 @@
import
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155645948
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,107 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155644582
--- Diff:
sql/storm-sql-external/storm-sql-mongodb/src/jvm/org/apache/storm/sql/mongodb/MongoDataSourcesProvider.java
---
@@ -49,53 +46,56 @@
*/
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155644012
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -117,9 +138,21 @@ public TableBuilderInfo
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155643727
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -89,16 +95,31 @@ public TableBuilderInfo field(String name,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155643640
--- Diff: sql/storm-sql-core/pom.xml ---
@@ -66,10 +66,34 @@
calcite-core
${calcite.version}
+
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155643000
--- Diff: sql/storm-sql-core/pom.xml ---
@@ -66,10 +66,34 @@
calcite-core
--- End diff --
I'll see how the number is
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r154738635
--- Diff: sql/storm-sql-core/pom.xml ---
@@ -66,10 +66,34 @@
calcite-core
${calcite.version}
+
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155320443
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/calcite/ParallelTable.java ---
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155515549
--- Diff:
sql/storm-sql-external/storm-sql-mongodb/src/jvm/org/apache/storm/sql/mongodb/MongoDataSourcesProvider.java
---
@@ -49,53 +46,56 @@
*/
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155320991
--- Diff: sql/storm-sql-core/pom.xml ---
@@ -66,10 +66,34 @@
calcite-core
--- End diff --
You might want to reduce the allowed
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155516637
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/bolt/SocketBolt.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155520270
--- Diff:
sql/storm-sql-runtime/src/test/org/apache/storm/sql/TestUtils.java ---
@@ -190,363 +191,213 @@ public void open(ChannelContext ctx) {
}
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155321227
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -117,9 +138,21 @@ public TableBuilderInfo parallelismHint(int
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155321576
--- Diff:
sql/storm-sql-core/src/jvm/org/apache/storm/sql/compiler/CompilerUtil.java ---
@@ -89,16 +95,31 @@ public TableBuilderInfo field(String name,
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155514626
--- Diff:
sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java
---
@@ -88,46 +90,13 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155517029
--- Diff:
sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/spout/SocketSpout.java
---
@@ -26,59 +27,61 @@
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2443#discussion_r155515253
--- Diff:
sql/storm-sql-external/storm-sql-kafka/src/test/org/apache/storm/sql/kafka/TestKafkaDataSourcesProvider.java
---
@@ -68,62 +70,13 @@
64 matches
Mail list logo
