Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2480
---
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159413588
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -144,10 +147,37 @@ public void open(Map conf, Topol
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159407800
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -144,10 +147,37 @@ public void open(Map conf, TopologyC
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159149753
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118 @@
+/**
+ * Lice
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159149749
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118 @@
+/**
+ * Lice
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159120385
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118 @@
+/**
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119938
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118 @@
+/**
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119896
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118 @@
+/**
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119878
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118 @@
+/**
+ * Licensed
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159119706
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -739,4 +764,9 @@ public boolean shouldPoll() {
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159080037
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118 @@
+/**
+ * Lice
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159078123
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,118 @@
+/**
+ * Licensed
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159076756
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -31,77 +32,75 @@
public class Kafka
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159075727
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -739,4 +764,9 @@ public boolean shouldPoll() {
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159075538
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -739,4 +764,9 @@ public boolean shouldPoll() {
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159075477
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -31,77 +32,75 @@
public class K
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159063226
--- Diff:
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutSingleTopicTest.java
---
@@ -343,4 +344,48 @@ public void
testSpout
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159061893
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -31,77 +32,75 @@
public class Kafka
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159062211
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -31,77 +32,75 @@
public class Kafka
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159063661
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -739,4 +764,9 @@ public boolean shouldPoll() {
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159056636
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,114 @@
+/**
+ * Lice
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158960041
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158959415
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158958894
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158958224
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/metrics/KafkaOffsetMetric.java
---
@@ -0,0 +1,114 @@
+/**
+ * Licensed
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r158899496
--- Diff: pom.xml ---
@@ -278,7 +278,7 @@
kafka_2.10
-0.10.0.0
+0.11.0.2
--- End diff --
26 matches
Mail list logo
