[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862257#comment-15862257
]
ASF GitHub Bot commented on THRIFT-4064:
Github user bgould commented on the issu
Github user bgould commented on the issue:
https://github.com/apache/thrift/pull/1175
@zertosh can you elaborate on
> Alternatively, how do you feel about making the require call for this
module
configurable?(https://github.com/apache/thrift/blob/e1832c354391deb0e0ce94a62ff32
[
https://issues.apache.org/jira/browse/THRIFT-4025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4025:
---
Summary: Use the cmake generated config.h on windows (was: As a developer,
I would l
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-2504:
--
Assignee: (was: James E. King, III)
> I want a server-side upgrade to Mult
[
https://issues.apache.org/jira/browse/THRIFT-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862250#comment-15862250
]
ASF GitHub Bot commented on THRIFT-4075:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4075.
Resolution: Fixed
Fix Version/s: 0.11.0
> Better MinGW support for headers-o
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
[
https://issues.apache.org/jira/browse/THRIFT-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III closed THRIFT-4083.
--
> maven-thrift-plugin doesn't work with thrift 0.10.0
> ---
[
https://issues.apache.org/jira/browse/THRIFT-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862247#comment-15862247
]
James E. King, III commented on THRIFT-4083:
If you have further issues after
[
https://issues.apache.org/jira/browse/THRIFT-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-4083.
Resolution: Information Provided
> maven-thrift-plugin doesn't work with thrift 0.1
[
https://issues.apache.org/jira/browse/THRIFT-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862244#comment-15862244
]
Manasi Vartak commented on THRIFT-4083:
---
I see. We were using the maven plugin from
[
https://issues.apache.org/jira/browse/THRIFT-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862235#comment-15862235
]
Benjamin Gould commented on THRIFT-4083:
You're using an old version of the maven
[
https://issues.apache.org/jira/browse/THRIFT-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862218#comment-15862218
]
Benjamin Gould commented on THRIFT-4082:
I used a Java server with browser Javasc
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1185
Interesting failure now. The non-ssl testing against java and cpp work
properly but the ssl variant seems to be skewed / off by one. When testVoid()
is sent, testString() is returned. Everything
Manasi Vartak created THRIFT-4083:
-
Summary: maven-thrift-plugin doesn't work with thrift 0.10.0
Key: THRIFT-4083
URL: https://issues.apache.org/jira/browse/THRIFT-4083
Project: Thrift
Issue
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1185
I forgot to say that also the code was rebased. A curious thing is that
everytime I do a rebase the system says that my code diverged... I don't know
why since always rebasing the upstream master b
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1185
Okay. I revamped a little bit the system to allow it to run the cross
tests. Since you are not using specific functions provided by the API it was
causing to not initialize the instance properly.
[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862140#comment-15862140
]
ASF GitHub Bot commented on THRIFT-4064:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1175
I know very little about node.js in practice. It would be up to other
committers/members/contributors who know node.js to weigh in on that. My
biggest concern is the hang in build job 8. Can't me
Github user zertosh commented on the issue:
https://github.com/apache/thrift/pull/1175
@jeking3 pretty sure that the "SyntaxError: Parse error" error is
phanthomjs (via run-browser) choking on the new syntax. The tests are running
phantomjs@1.9.20 (https://travis-ci.org/apache/thrift/
[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862134#comment-15862134
]
ASF GitHub Bot commented on THRIFT-4064:
Github user zertosh commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862110#comment-15862110
]
Jens Geyer commented on THRIFT-4037:
I am the last one arguing against user stories,
[
https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861847#comment-15861847
]
ASF GitHub Bot commented on THRIFT-1805:
Github user ctubbsii commented on a diff
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100623293
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator {
reuse_ob
[
https://issues.apache.org/jira/browse/THRIFT-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861725#comment-15861725
]
Christopher Wright edited comment on THRIFT-4082 at 2/10/17 7:29 PM:
--
[
https://issues.apache.org/jira/browse/THRIFT-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861725#comment-15861725
]
Christopher Wright commented on THRIFT-4082:
Right now, I'm seeing this on a
[
https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861701#comment-15861701
]
James E. King, III commented on THRIFT-4060:
One use case of this is if you s
[
https://issues.apache.org/jira/browse/THRIFT-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christopher Wright updated THRIFT-4082:
---
Component/s: (was: Java - Library)
Java - Compiler
> Java librar
[
https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4037:
---
Description:
h1. Background
The thrift project currently carries two build systems.
[
https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4037:
---
Summary: [CMake] Use a single build system for thrift to make development
easier (wa
[
https://issues.apache.org/jira/browse/THRIFT-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861671#comment-15861671
]
James E. King, III commented on THRIFT-4082:
I wonder if the "make cross" tes
[
https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861674#comment-15861674
]
James E. King, III commented on THRIFT-4037:
I can tell you really are into t
[
https://issues.apache.org/jira/browse/THRIFT-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861647#comment-15861647
]
Christopher Wright commented on THRIFT-4082:
Stacktrace, since those tend to
[
https://issues.apache.org/jira/browse/THRIFT-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861645#comment-15861645
]
Christopher Wright commented on THRIFT-4082:
Looks like readStructEnd isn't b
[
https://issues.apache.org/jira/browse/THRIFT-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861615#comment-15861615
]
ASF GitHub Bot commented on THRIFT-4075:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1184
Build job #2 failed in a weird way, in c_glib. Doesn't appear related.
See: https://travis-ci.org/apache/thrift/jobs/200237365
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-3622.
Resolution: Fixed
Fix Version/s: 0.11.0
> Fix deprecated uses of std::auto_p
[
https://issues.apache.org/jira/browse/THRIFT-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861607#comment-15861607
]
ASF GitHub Bot commented on THRIFT-3622:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1185
@gadLinux I submitted a pull request against your branch
(https://github.com/gadLinux/thrift/pull/1) to put the cross testing code in
place; it is seg faulting so hopefully you can figure out why in
[
https://issues.apache.org/jira/browse/THRIFT-4082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4082:
---
Priority: Critical (was: Major)
> Java library can't parse JSON generated by javascript TJSONProtoco
[
https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861598#comment-15861598
]
Jens Geyer commented on THRIFT-4037:
As a developer, I think that the acceptance crit
[
https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861593#comment-15861593
]
Jens Geyer commented on THRIFT-1805:
> why not simply `return handle_runtime_exceptio
[
https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861586#comment-15861586
]
ASF GitHub Bot commented on THRIFT-1805:
Github user Jens-G commented on a diff i
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100586606
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator {
reuse_obje
[
https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861584#comment-15861584
]
ASF GitHub Bot commented on THRIFT-1805:
Github user Jens-G commented on a diff i
[
https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861577#comment-15861577
]
Konrad Grochowski edited comment on THRIFT-4060 at 2/10/17 5:45 PM:
---
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100586356
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -3527,6 +3531,11 @@ void
t_java_generator::generate_process_function(t_service* tservic
[
https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861577#comment-15861577
]
Konrad Grochowski commented on THRIFT-4060:
---
I do not completely follow your ex
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1185
We are in middle of the transition process from automake to cmake. Until we
completed this task, both are relevant.
---
If your project is set up for it, you can reply to this email and have your
re
[
https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861564#comment-15861564
]
ASF GitHub Bot commented on THRIFT-4060:
Github user hcorg commented on a diff in
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1172#discussion_r100583307
--- Diff: lib/cpp/test/AnnotationTest.cpp ---
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contr
[
https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861460#comment-15861460
]
ASF GitHub Bot commented on THRIFT-1805:
Github user jeking3 commented on a diff
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100565597
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator {
reuse_obj
[
https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861445#comment-15861445
]
ASF GitHub Bot commented on THRIFT-1805:
Github user keith-turner commented on a
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1186#discussion_r100562753
--- Diff: compiler/cpp/src/thrift/generate/t_java_generator.cc ---
@@ -91,6 +92,8 @@ class t_java_generator : public t_oop_generator {
reus
[
https://issues.apache.org/jira/browse/THRIFT-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861413#comment-15861413
]
James E. King, III commented on THRIFT-3973:
In this approach I took a “build
[
https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861392#comment-15861392
]
James E. King, III commented on THRIFT-4037:
There are many reasons to switch
[
https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861329#comment-15861329
]
Gonzalo Aguilar edited comment on THRIFT-4037 at 2/10/17 2:42 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861329#comment-15861329
]
Gonzalo Aguilar edited comment on THRIFT-4037 at 2/10/17 2:23 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861329#comment-15861329
]
Gonzalo Aguilar commented on THRIFT-4037:
-
I understand that all move is to suppo
[
https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861327#comment-15861327
]
Gonzalo Aguilar commented on THRIFT-4037:
-
If I can comment on this. I must say t
[
https://issues.apache.org/jira/browse/THRIFT-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4081:
---
Description: We currently build in Visual Studio 2015 on Appveyor. We do
not use the
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1185
autoconf is deprecated and there is an epic in the Jira backlog to remove
it in favor of cmake. I agree maintaining two build systems is a bit painful.
I believe it is possible to have "make cross
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1185
Just a question. Why all CMake stuff. Having two compilation environments
seems to me somewhat overloaded... Does it worth it?
---
If your project is set up for it, you can reply to this email and
Github user gadLinux commented on the issue:
https://github.com/apache/thrift/pull/1185
Hi Jeking3,
Yes there's only the client at this time. Cause I had no time to implement
server. The tests can be run against Java or any other server. I will add after
this commit is approved.
66 matches
Mail list logo
