+1
On Fri, Oct 22, 2021 at 6:52 AM Randy Abernethy
wrote:
> +1
>
> On Thu, Oct 21, 2021 at 6:48 PM Allen George
> wrote:
>
> > +1 deprecate it
> >
> > Allen
> >
> >
> > On Thu, Oct 21, 2021 at 4:53 PM Jens Geyer wrote:
> >
> > > @all,
> > >
> > > THRIFT-5410 “CL build broken: Component :NET.DI
+1
I'm pretty sure I'm one of the people that was opposed to this a few years
ago. It's been long enough now... it's time to upgrade to 11. I recommend
you pick a minimum GCC, MSVC, and Clang, and advertise support for those,
rather than just say "C++11".
On Sun, Dec 30, 2018 at 8:47 AM James E
The main source of work on the Thrift side will be porting the tests. Many
of them are based on boost test right now.
I'm generally fine with the idea, just be aware that this is a breaking
change, though the break will often be easily dealt with by users
(replacing std with boost).
If you want
Find the person that did the initial work and ask them directly. That
person is likely the main user.
On Dec 1, 2017 5:58 PM, "Chet Murthy" wrote:
> In another email thread about unions, I've noted that the current Thrift
> union implementation isn't actually a union. It's just a struct with
>
I don't currently use it, but I wasn't aware of it until recently.
The issue that we run into at my company is that the exception types
generated by Thrift aren't the types that we want to use in our code. As a
result, after code generation, we end up writing lots of boilerplate to
convert from o
I don't know about references... but you shouldn't modify git history in a
public location. rebase and amend operations are the main culprits for
that.
On Thu, Mar 23, 2017 at 3:12 PM, Jens Geyer wrote:
>
> Is there any reference where we can actually read that? Citation needed ;-)
>
>
>
>
> --
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r87931050
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -18,6 +18,16 @@
#
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/src/thrift/version.h.in
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r87931893
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -60,7 +60,7 @@
#endif // _WIN32
#endif
-#if defined(_WIN32
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r87931714
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h ---
@@ -135,8 +141,9 @@ class THeaderTransport : public
TVirtualTransport::size_type trans
Github user ben-craig commented on the issue:
https://github.com/apache/thrift/pull/1103
I'm fine with you adding back setDetached and marking it deprecated. If
you really want, you could even put in some logic so that you assert or throw
an error if someone calls setDetached
Github user ben-craig commented on the issue:
https://github.com/apache/thrift/pull/1103
PlatformThreadFactory f;
f.setDetached(false);
Prior to this change, that was the only way to portably change the detached
state. The PosixThreadFactory didn't have a ctor that
Github user ben-craig commented on the issue:
https://github.com/apache/thrift/pull/1103
Removing setDetached and the old thread factory ctors breaks client code
loudly. It doesn't fix the underlying problem, and it exchanges one problem
(don't forget to set the detached
Github user ben-craig commented on the issue:
https://github.com/apache/thrift/pull/981
Your latest revision look fine, I was mainly trying to address nsuke's post.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ben-craig commented on the issue:
https://github.com/apache/thrift/pull/981
The default op=, and even the default conversion operators from atomic
to T are fine.
@nsuke I would prefer we keep the access to TThreadPoolServer timeout
variables as seq_cst. The
Github user ben-craig commented on the issue:
https://github.com/apache/thrift/pull/981
Unless you have extremely compelling profiling results, the only atomic
memory order you should be using is memory_order_seq_cst. Even better, you get
seq_cst for free as the default parameter of
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226689#comment-15226689
]
Ben Craig commented on THRIFT-3768:
---
ThreadManager is a mess. When the C
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220756#comment-15220756
]
Ben Craig commented on THRIFT-3768:
---
You probably will need two vectors. You
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220595#comment-15220595
]
Ben Craig commented on THRIFT-3768:
---
Not sure how this will get reflected in code,
[
https://issues.apache.org/jira/browse/THRIFT-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213225#comment-15213225
]
Ben Craig commented on THRIFT-3238:
---
ugh, makes sense. The remainder of the atta
[
https://issues.apache.org/jira/browse/THRIFT-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211083#comment-15211083
]
Ben Craig commented on THRIFT-3238:
---
The provided patches touch a lot more code
Github user ben-craig commented on the pull request:
https://github.com/apache/thrift/pull/798#issuecomment-173401300
@szenker It's probably not what you are looking for, but the concurrent
client in C++ can allow multiple threads to have outstanding requests at once
(though onl
I don't like the idea of adding a new utf-16 string type to the wire
protocol, but I think it would be fine to add a utf-16 string type to the
language bindings. UTF-8 would be sent over the wire, and then converted
from the network buffer into the user's desired string type. A lot of the
cost an
[
https://issues.apache.org/jira/browse/THRIFT-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951302#comment-14951302
]
Ben Craig commented on THRIFT-3371:
---
+1
> Abstract namespace Unix domain
+1 to what Jens said.
I've dealt with a number of code generators, and I can't say I really like
any of them. With that in mind though, I've found it easier to embed
strings into code (the Thrift way) than to embed code into strings
(typically, the template way).
I do think a template based appr
[
https://issues.apache.org/jira/browse/THRIFT-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944140#comment-14944140
]
Ben Craig commented on THRIFT-3237:
---
+1
> Fix TNamedPipeServer::createNa
[
https://issues.apache.org/jira/browse/THRIFT-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934471#comment-14934471
]
Ben Craig commented on THRIFT-3228:
---
There are basically two major options...
1. B
[
https://issues.apache.org/jira/browse/THRIFT-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3270.
---
Resolution: Fixed
Thanks for the patch Jesse!
> reusing TNonblockingServer::TConnection cause di
[
https://issues.apache.org/jira/browse/THRIFT-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3252.
---
Resolution: Fixed
Assignee: Adam Beberg
Fix Version/s: 0.9.3
> Miss
[
https://issues.apache.org/jira/browse/THRIFT-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637987#comment-14637987
]
Ben Craig commented on THRIFT-3252:
---
Committed. Thanks!
>
[
https://issues.apache.org/jira/browse/THRIFT-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3247.
---
Resolution: Fixed
Fix Version/s: 0.9.3
> Generate a C++ thread-safe cli
Github user ben-craig closed the pull request at:
https://github.com/apache/thrift/pull/554
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/THRIFT-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3224.
---
Resolution: Fixed
> Fix TNamedPipeServer unpredictable behavior on acc
[
https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3225.
---
Resolution: Fixed
> Fix TPipeServer unpredictable behavior on interr
[
https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629697#comment-14629697
]
Ben Craig commented on THRIFT-3225:
---
Resolved in the same patch as THRIFT-3224
&
GitHub user ben-craig opened a pull request:
https://github.com/apache/thrift/pull/554
THRIFT-3247 Generate a C++ thread-safe client
This adds a new client class to the generated code ConcurrentClient.
This class handles out-of-order replies, and will allow sends and recvs on
Ben Craig created THRIFT-3247:
-
Summary: Generate a C++ thread-safe client
Key: THRIFT-3247
URL: https://issues.apache.org/jira/browse/THRIFT-3247
Project: Thrift
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/THRIFT-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-3231.
-
> CPP: Limit recursion depth to 64
>
>
> Key:
[
https://issues.apache.org/jira/browse/THRIFT-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628511#comment-14628511
]
Ben Craig commented on THRIFT-3246:
---
This was mostly on the test side, and I d
[
https://issues.apache.org/jira/browse/THRIFT-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3246.
---
Resolution: Fixed
> Reduce the number of trivial warnings in Windows C++ CMake bui
[
https://issues.apache.org/jira/browse/THRIFT-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2858.
---
Resolution: Fixed
> Enable header field case insensitive match in THttpSer
GitHub user ben-craig opened a pull request:
https://github.com/apache/thrift/pull/553
THRIFT-3246 Reduce the number of trivial warnings in Windows C++ CMake
builds
Warnings still exist, but I'm down to 18 in a debug build instead of the
145 that are present in debug bui
GitHub user ben-craig opened a pull request:
https://github.com/apache/thrift/pull/552
THRIFT-2858 making HTTP case insensitivity build on Windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ben-craig/thrift HTTPCase
[
https://issues.apache.org/jira/browse/THRIFT-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reopened THRIFT-2858:
---
This breaks the windows build. Windows doesn't have a strncasecmp or
strcasestr.
Pull request wi
Ben Craig created THRIFT-3246:
-
Summary: Reduce the number of trivial warnings in Windows C++
CMake builds
Key: THRIFT-3246
URL: https://issues.apache.org/jira/browse/THRIFT-3246
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-3245.
-
> Tutorials can't be disabled when usi
[
https://issues.apache.org/jira/browse/THRIFT-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3245.
---
Resolution: Fixed
Assignee: Pascal Bach
Fix Version/s: 0.9.2
> Tutorials can&#
[
https://issues.apache.org/jira/browse/THRIFT-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628038#comment-14628038
]
Ben Craig commented on THRIFT-3245:
---
Thanks for the pull request Pascal. Once Tr
[
https://issues.apache.org/jira/browse/THRIFT-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627073#comment-14627073
]
Ben Craig commented on THRIFT-3224:
---
[~pjanicki] I have updated my pull request.
[
https://issues.apache.org/jira/browse/THRIFT-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626544#comment-14626544
]
Ben Craig commented on THRIFT-3206:
---
This is only an issue with older versions of
[
https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621624#comment-14621624
]
Ben Craig commented on THRIFT-3225:
---
This might be right. I'm going to try
[
https://issues.apache.org/jira/browse/THRIFT-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621618#comment-14621618
]
Ben Craig commented on THRIFT-3221:
---
should be fixed now.
> Create a tool t
Moved readme.txt. Python test rewrite is going to need to wait though
(unless you want to take it on). Sorry about that :(
On Thu, Jul 9, 2015 at 8:22 AM, Ben Craig wrote:
> I would prefer python as well. I didn't author the patch though :) I
> will see about getting the test por
[
https://issues.apache.org/jira/browse/THRIFT-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621612#comment-14621612
]
Ben Craig commented on THRIFT-3224:
---
updated my pull request. Take a look at
[
https://issues.apache.org/jira/browse/THRIFT-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621100#comment-14621100
]
Ben Craig commented on THRIFT-3221:
---
Did this break the cmake build, the autot
[
https://issues.apache.org/jira/browse/THRIFT-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620524#comment-14620524
]
Ben Craig commented on THRIFT-3224:
---
I agree that TAutoHandle references can make
[
https://issues.apache.org/jira/browse/THRIFT-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3231.
---
Resolution: Fixed
> CPP: Limit recursion depth to
[
https://issues.apache.org/jira/browse/THRIFT-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620491#comment-14620491
]
Ben Craig commented on THRIFT-3228:
---
A lot of my uses of Thrift involve multiple u
oger
>
>
> Quoting bencr...@apache.org:
>
> THRIFT-3221 Create a tool to audit network compatibility between two
>> .thrift files
>> Client: Compiler (general)
>> Patch: Sanjay Poojary , Ben Craig
>> , and Zach Hindes
>>
>> This closes #541
>&
[
https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-3217.
-
> Provide a little endian variant of the binary protocol i
[
https://issues.apache.org/jira/browse/THRIFT-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3221.
---
Resolution: Fixed
> Create a tool to audit network compatibility between two .thrift fi
[
https://issues.apache.org/jira/browse/THRIFT-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-3221.
-
> Create a tool to audit network compatibility between two .thrift fi
[
https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3217.
---
Resolution: Fixed
Fix Version/s: 0.9.3
> Provide a little endian variant of the bin
GitHub user ben-craig opened a pull request:
https://github.com/apache/thrift/pull/546
THRIFT-3231 CPP: Limit recursion depth to 64
Client: cpp
Patch: Ben Craig
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ben-craig
Ben Craig created THRIFT-3231:
-
Summary: CPP: Limit recursion depth to 64
Key: THRIFT-3231
URL: https://issues.apache.org/jira/browse/THRIFT-3231
Project: Thrift
Issue Type: Bug
[
https://issues.apache.org/jira/browse/THRIFT-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618801#comment-14618801
]
Ben Craig commented on THRIFT-3228:
---
Function level statics are not thread saf
[
https://issues.apache.org/jira/browse/THRIFT-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618636#comment-14618636
]
Ben Craig commented on THRIFT-3228:
---
This is a documented limitation. From TPi
GitHub user ben-craig opened a pull request:
https://github.com/apache/thrift/pull/544
THRIFT-3224 Fix TNamedPipeServer unpredictable behavior on accept
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ben-craig/thrift THRIFT
[
https://issues.apache.org/jira/browse/THRIFT-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617351#comment-14617351
]
Ben Craig commented on THRIFT-3226:
---
Don't try to use closed transports.
[
https://issues.apache.org/jira/browse/THRIFT-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617344#comment-14617344
]
Ben Craig commented on THRIFT-3224:
---
This patch leaks pipes if the TPipe ctor th
[
https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617329#comment-14617329
]
Ben Craig commented on THRIFT-3225:
---
doh! please back this out. I'm revie
[
https://issues.apache.org/jira/browse/THRIFT-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617321#comment-14617321
]
Ben Craig commented on THRIFT-3225:
---
-1
close() doesn't need to be / sho
[
https://issues.apache.org/jira/browse/THRIFT-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614374#comment-14614374
]
Ben Craig edited comment on THRIFT-3221 at 7/5/15 8:1
[
https://issues.apache.org/jira/browse/THRIFT-3221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614374#comment-14614374
]
Ben Craig commented on THRIFT-3221:
---
The compiler help says how to use it, but r
GitHub user ben-craig opened a pull request:
https://github.com/apache/thrift/pull/541
THRIFT-3221: Adding network compat auditing tool to Thrift compiler
Authored by Sanjay Poojary
Reviewed by Ben Craig and Zach Hindes
You can merge this pull request into a Git repository
[
https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-3219.
-
> Provide a C++ tutorial on server-side IP logging and per-connection st
[
https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-3219.
---
Resolution: Fixed
Assignee: Ben Craig
> Provide a C++ tutorial on server-side IP logging
Ben Craig created THRIFT-3221:
-
Summary: Create a tool to audit network compatibility between two
.thrift files
Key: THRIFT-3221
URL: https://issues.apache.org/jira/browse/THRIFT-3221
Project: Thrift
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/538#discussion_r33888179
--- Diff: tutorial/cpp/CppLogIPServer.cpp ---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
[
https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613505#comment-14613505
]
Ben Craig commented on THRIFT-3217:
---
Beefed up the performance test a bit. Here&
[
https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613180#comment-14613180
]
Ben Craig commented on THRIFT-3217:
---
I'll see if I can rustle up some AR
GitHub user ben-craig opened a pull request:
https://github.com/apache/thrift/pull/538
THRIFT-3219: Provide a C++ tutorial on server-side IP logging and
per-connection state
This also adds the C++ tutorial builds to the cmake build by default.
The tutorial demonstrates per
[
https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig reassigned THRIFT-3217:
-
Assignee: Ben Craig
> Provide a little endian variant of the binary protocol i
[
https://issues.apache.org/jira/browse/THRIFT-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-3217:
--
Component/s: C++ - Library
> Provide a little endian variant of the binary protocol i
Ben Craig created THRIFT-3219:
-
Summary: Provide a C++ tutorial on server-side IP logging and
per-connection state
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
GitHub user ben-craig opened a pull request:
https://github.com/apache/thrift/pull/537
THRIFT-3217: Added little endian binary protocol
Benchmark results from my laptop:
Write big endian: 524.562 kHz
Read big endian: 328.188 kHz
Write little endian: 688.137 kHz
Ben Craig created THRIFT-3217:
-
Summary: Provide a little endian variant of the binary protocol in
C++
Key: THRIFT-3217
URL: https://issues.apache.org/jira/browse/THRIFT-3217
Project: Thrift
GitHub user ben-craig reopened a pull request:
https://github.com/apache/thrift/pull/534
THRIFT-2850: Fix some Windows CMake issues
Some issues that are fixed here:
* Removed some files from the build that do nothing except for cause
warnings on Windows (VirtualProfiling.cpp
Github user ben-craig closed the pull request at:
https://github.com/apache/thrift/pull/534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user ben-craig opened a pull request:
https://github.com/apache/thrift/pull/534
Thrift 2850: Fix some Windows CMake issues
Some issues that are fixed here:
* Removed some files from the build that do nothing except for cause
warnings on Windows (VirtualProfiling.cpp and
[
https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562856#comment-14562856
]
Ben Craig commented on THRIFT-3038:
---
You could take that path that the threading
[
https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561769#comment-14561769
]
Ben Craig commented on THRIFT-3038:
---
The Thrift Cpp library does not currently req
+0
I don't have strong opinions on autoconf vs. cmake. +1 for getting rid of
one of the build systems though. Many thanks for those that took the
effort to develop and try out the new build system.
Jake Farrell wrote on 05/12/2015 11:21:41 PM:
> From: Jake Farrell
> To: "dev@thrift.apache.
[
https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532578#comment-14532578
]
Ben Craig commented on THRIFT-1944:
---
To recap from earlier in the thread...
&q
[
https://issues.apache.org/jira/browse/THRIFT-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2150.
-
Resolution: Won't Fix
This is a Microsoft build infrastructure issue that is external to the pr
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig updated THRIFT-2441:
--
Assignee: James E. King, III (was: Ben Craig)
> Cannot shutdown TThreadedServer when clients
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig resolved THRIFT-2441.
---
Resolution: Fixed
> Cannot shutdown TThreadedServer when clients are still connec
[
https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511098#comment-14511098
]
Ben Craig commented on THRIFT-2441:
---
committed. Thanks jeking3!
> Cannot s
[
https://issues.apache.org/jira/browse/THRIFT-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2119.
-
Resolution: Won't Fix
See other comments. VS2005 is old enough that we don't feel t
[
https://issues.apache.org/jira/browse/THRIFT-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503602#comment-14503602
]
Ben Craig commented on THRIFT-2119:
---
I am fine dropping this as well. I will c
David,
If you method ordinals today, without changing the generator, and without
even changing Apache Thrift source, you can hack it at the protocol level.
Inherit from your protocol of choice, and then override readMessageBegin
and writeMessageBegin, and you can translate from the code generat
1 - 100 of 514 matches
Mail list logo
