Quality check mod_jk 1.2.25-dev

Hi all, unfortunately we had to withdraw mod_jk 1.2.24. It had a serious regression bug. To ensure the quality of the new 1.2.25 we invite you to actively participate in testing. A code snapshot (revision 562250) is available at: http://people.apache.org/~rjung/mod_jk-dev/ It is in the same

Re: Juli/Logging

Stacks are always special. It's usually unfeasible to push them into one line. My argument was about usual log messages. Of course in a fully fledged new formatter, one would wish things like configuring the depth of the stack printed. Len Popp wrote: On 7/31/07, Rainer Jung <[EMAIL PROTECTED

DO NOT REPLY [Bug 43019] - valid absolute request uris + mod_jk 1.2.23 return 400 Invalid URI

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Juli/Logging

On 8/3/07, Costin Manolache <[EMAIL PROTECTED]> wrote: > On 8/2/07, Len Popp <[EMAIL PROTECTED]> wrote: > > > > On 7/31/07, Rainer Jung <[EMAIL PROTECTED]> wrote: > > > My personal opinion: java.util.logging very much lacks a good formatter. > > > The default 2 line formatting of messages, splittin

Re: Juli/Logging

On 8/2/07, Len Popp <[EMAIL PROTECTED]> wrote: > > On 7/31/07, Rainer Jung <[EMAIL PROTECTED]> wrote: > > My personal opinion: java.util.logging very much lacks a good formatter. > > The default 2 line formatting of messages, splitting timestamps and > > message in separate lines, is not really use

Re: Juli/Logging

On 7/31/07, Rainer Jung <[EMAIL PROTECTED]> wrote: > My personal opinion: java.util.logging very much lacks a good formatter. > The default 2 line formatting of messages, splitting timestamps and > message in separate lines, is not really useful in production. Many ad > hoc log analysis practices w

DO NOT REPLY [Bug 43019] New: - valid absolute request uris + mod_jk 1.2.23 return 400 Invalid URI

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 43003] - Separate dependent component download and build targets

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 43002] - NIO connector performance issue in 6.0.13

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: svn commit: r562194 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp13.h native/common/jk_ajp_common.c native/common/jk_lb_worker.c xdocs/miscellaneous/changelog.xml xdocs/reference/workers

And in fact it doesn't matter. I found it more logical, to have JK_STATUS_ERROR and JK_STATUS_FATAL_ERROR closer together (for those reading the code). The constants are not used outside JK, so there is no compatibility problem. It looks like your are closely following todays JK changes. I rea

svn commit: r562250 - in /tomcat/connectors/trunk/jk/xdocs: miscellaneous/changelog.xml webserver_howto/nes.xml

Author: rjung Date: Thu Aug 2 13:44:23 2007 New Revision: 562250 URL: http://svn.apache.org/viewvc?view=rev&rev=562250 Log: Improve nsapi build description for Unix. Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml tomcat/connectors/trunk/jk/xdocs/webserver_howto/ne

Re: Juli/Logging

Costin Manolache wrote: Can be changed to include a better date format. I used this to look at execution times and start time - so millis was quite nice. Also more efficient to generate. Ideally, it would use a pattern property to configure it, like: logger_prefix.org.apache.juli.PatternFormat

svn commit: r562242 - in /tomcat/connectors/trunk/jk/native/netscape: Makefile.linux Makefile.solaris

Author: rjung Date: Thu Aug 2 13:27:03 2007 New Revision: 562242 URL: http://svn.apache.org/viewvc?view=rev&rev=562242 Log: Another round of Makefile changes for nsapi (Linux/Solaris). Modified: tomcat/connectors/trunk/jk/native/netscape/Makefile.linux tomcat/connectors/trunk/jk/native/n

Re: svn commit: r562194 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp13.h native/common/jk_ajp_common.c native/common/jk_lb_worker.c xdocs/miscellaneous/changelog.xml xdocs/reference/workers.

On Aug 2, 2007, at 1:42 PM, [EMAIL PROTECTED] wrote: == --- tomcat/connectors/trunk/jk/native/common/jk_ajp13.h (original) +++ tomcat/connectors/trunk/jk/native/common/jk_ajp13.h Thu Aug 2 10:42:23 2007 @@ -45,7 +

DO NOT REPLY [Bug 43002] - NIO connector performance issue in 6.0.13

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 43002] - NIO connector performance issue in 6.0.13

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 43002] - NIO connector performance issue in 6.0.13

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 43002] - NIO connector performance issue in 6.0.13

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Juli/Logging

Can be changed to include a better date format. I used this to look at execution times and start time - so millis was quite nice. Also more efficient to generate. Costin On 8/2/07, Rainer Jung <[EMAIL PROTECTED]> wrote: > > Hi Costin (and Remy), > > I had a quick look at the JdkLoggerFormatter (

DO NOT REPLY [Bug 29936] - XML parser loading problems by container

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r562201 - in /tomcat/connectors/trunk/jk/native/netscape: Makefile.linux Makefile.solaris

Author: rjung Date: Thu Aug 2 10:54:15 2007 New Revision: 562201 URL: http://svn.apache.org/viewvc?view=rev&rev=562201 Log: Fix comments about 64Bit building nsapi plugin in Makefiles. Modified: tomcat/connectors/trunk/jk/native/netscape/Makefile.linux tomcat/connectors/trunk/jk/native/n

svn commit: r562198 - in /tomcat/connectors/trunk/jk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

Author: rjung Date: Thu Aug 2 10:44:25 2007 New Revision: 562198 URL: http://svn.apache.org/viewvc?view=rev&rev=562198 Log: Fix shm shutdown behaviour for IIS. Modified: tomcat/connectors/trunk/jk/native/iis/jk_isapi_plugin.c tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

svn commit: r562194 - in /tomcat/connectors/trunk/jk: native/common/jk_ajp13.h native/common/jk_ajp_common.c native/common/jk_lb_worker.c xdocs/miscellaneous/changelog.xml xdocs/reference/workers.xml

Author: rjung Date: Thu Aug 2 10:42:23 2007 New Revision: 562194 URL: http://svn.apache.org/viewvc?view=rev&rev=562194 Log: Make fail_on_status more useful in combination with an LB. We can now optionally only fail over, without putting the failed worker in an error state. Modified: tomcat/c

svn commit: r562190 - /tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

Author: rjung Date: Thu Aug 2 10:32:56 2007 New Revision: 562190 URL: http://svn.apache.org/viewvc?view=rev&rev=562190 Log: Update changelog for JK. Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

svn commit: r562187 - /tomcat/tc6.0.x/trunk/java/org/apache/juli/JdkLoggerFormatter.java

Author: costin Date: Thu Aug 2 10:25:21 2007 New Revision: 562187 URL: http://svn.apache.org/viewvc?view=rev&rev=562187 Log: Add a simple one-line formatter. Added: tomcat/tc6.0.x/trunk/java/org/apache/juli/JdkLoggerFormatter.java - copied, changed from r415842, tomcat/sandbox/java/

Re: Juli/Logging

Hi Costin (and Remy), I had a quick look at the JdkLoggerFormatter (found in an old revision of the sandbox, it's not there any more): this formatter uses a *very* compact format. E.g. the timestamp is just the milliseconds and the log level is abbreviated with a single character. Although t

svn commit: r562186 - /tomcat/connectors/trunk/jk/xdocs/reference/workers.xml

Author: rjung Date: Thu Aug 2 10:20:07 2007 New Revision: 562186 URL: http://svn.apache.org/viewvc?view=rev&rev=562186 Log: Clarify fail_on-Status behaviour in docs. Modified: tomcat/connectors/trunk/jk/xdocs/reference/workers.xml Modified: tomcat/connectors/trunk/jk/xdocs/reference/workers

svn commit: r562184 - /tomcat/connectors/trunk/jk/native/netscape/Makefile.linux

Author: rjung Date: Thu Aug 2 10:09:15 2007 New Revision: 562184 URL: http://svn.apache.org/viewvc?view=rev&rev=562184 Log: Fix linux Makefile error for nsapi from previous commit. Modified: tomcat/connectors/trunk/jk/native/netscape/Makefile.linux Modified: tomcat/connectors/trunk/jk/nativ

svn commit: r562182 - in /tomcat/connectors/trunk/jk/native/netscape: Makefile.linux Makefile.solaris

Author: rjung Date: Thu Aug 2 09:54:20 2007 New Revision: 562182 URL: http://svn.apache.org/viewvc?view=rev&rev=562182 Log: Improve nsapi Makefiles a bit: - remove unnecessary differences between Solaris and Linux - Use CC and CFLAGS Next step will be configure based generation of the makefile. N

svn commit: r562175 - /tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c

Author: rjung Date: Thu Aug 2 09:30:45 2007 New Revision: 562175 URL: http://svn.apache.org/viewvc?view=rev&rev=562175 Log: Add usual info log message containing version during nsapi startup. Modified: tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c Modified: tomcat/connectors/

svn commit: r562174 - in /tomcat/connectors/trunk/jk/native/common: jk_status.c jk_uri_worker_map.c

Author: jim Date: Thu Aug 2 09:28:29 2007 New Revision: 562174 URL: http://svn.apache.org/viewvc?view=rev&rev=562174 Log: These are local functions; ensure we don't clobber things and handle compiler warnings about prototypes. Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c

Re: Juli/Logging

Costin Manolache wrote: I think something is missing - DirectJDKLog is looking for a JdkLoggerFormatter that would do the trick. I may have forgot to add it, I have it on my machine ( I hate too the default format ). There's also a config override allowing default properties to be loaded from a d

Re: Juli/Logging

I think something is missing - DirectJDKLog is looking for a JdkLoggerFormatter that would do the trick. I may have forgot to add it, I have it on my machine ( I hate too the default format ). There's also a config override allowing default properties to be loaded from a different location. Costin

svn commit: r562131 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

Author: rjung Date: Thu Aug 2 07:47:00 2007 New Revision: 562131 URL: http://svn.apache.org/viewvc?view=rev&rev=562131 Log: Move fail on status a little down the protocol stack, so that we haven't yet returned the headers. Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c M

svn commit: r562130 - /tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c

Author: rjung Date: Thu Aug 2 07:45:24 2007 New Revision: 562130 URL: http://svn.apache.org/viewvc?view=rev&rev=562130 Log: Fix shm shutdown behaviour of nsapi plugin. Modified: tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c Modified: tomcat/connectors/trunk/jk/native/netscape

svn commit: r562129 - /tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c

Author: rjung Date: Thu Aug 2 07:43:08 2007 New Revision: 562129 URL: http://svn.apache.org/viewvc?view=rev&rev=562129 Log: Add correct plugin return when service ends with an error. Modified: tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c Modified: tomcat/connectors/trunk/jk/

svn commit: r562127 - /tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c

Author: rjung Date: Thu Aug 2 07:39:04 2007 New Revision: 562127 URL: http://svn.apache.org/viewvc?view=rev&rev=562127 Log: Allow missing shm_file attribute for nsapi plugin on WIN32 and Netware platforms. Modified: tomcat/connectors/trunk/jk/native/netscape/jk_nsapi_plugin.c Modified: tomc

[ANN] Withdrawal of Apache Tomcat JK 1.2.24 Web Server Connectors

The Apache Tomcat team needs to withdraw release 1.2.24 of the Apache Tomcat Connectors. The release contains a bug that prevents the correct flushing of parts of responses from the web server to the client. This might result in unpredicted communication behaviour. We therefore have removed th

Re: mod_jk 1.2.24 withdrawal?

I withdrew the release from the server: - removed 1.2.24 source and binaries from www.apache.org/dist/... - put back 1.2.23 source and binaries from archive - reverted the download page and added a warning - added a withdrawal note to the index and news page in the live online docs. It will ta

svn commit: r562109 - in /tomcat/site/trunk: docs/download-connectors.html xdocs/download-connectors.xml

Author: rjung Date: Thu Aug 2 06:43:54 2007 New Revision: 562109 URL: http://svn.apache.org/viewvc?view=rev&rev=562109 Log: Withdraw JK 1.2.24 relase. Revert download page to 1.2.23 and add a warning concerning the withdrawal. Modified: tomcat/site/trunk/docs/download-connectors.html tom

Re: mod_jk 1.2.24 withdrawal?

I agree. Remove 1.2.24 and include all the patches. Let's roll that ASAP. Regards, Mladen. Rainer Jung wrote: I think the problem with JK 1.2.24 is big enough to release soon. I would also suggest to officially withdraw 1.2.24 from the download and web site (with a comment indicating the pro

mod_jk 1.2.24 withdrawal?

I think the problem with JK 1.2.24 is big enough to release soon. I would also suggest to officially withdraw 1.2.24 from the download and web site (with a comment indicating the problem) so that people will not run into more complex problems related to the missing flush. Although we've got no

Re: svn commit: r562090 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c

[EMAIL PROTECTED] wrote: Author: rjung Date: Thu Aug 2 05:10:48 2007 New Revision: 562090 URL: http://svn.apache.org/viewvc?view=rev&rev=562090 Log: Revert the quickfix r562022. It looks like we found the real problem with r562085. Perfect. The fix makes login working once again. Regards, M

Re: svn commit: r562022 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c xdocs/miscellaneous/changelog.xml

Update: The problem seems to be coming from a global change of AS400 defines, which unintentionally also hit two ifndefs, which were transformed into ifdefs. As a result, we didn't flush any more, so small responses were not flushed before we came to the line checking sent_bodyct. That way the

Re: Juli/Logging

Rainer Jung wrote: That's why it would be nice if someone took the burden of writing a better log formatter for j.u.l. Got it. Yea, that format is certainly grep unfriendly. Looks like Harmony has a formatter we could copy from and fix to not add the new line. http://svn.apache.org/repos/a

svn commit: r562090 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c

Author: rjung Date: Thu Aug 2 05:10:48 2007 New Revision: 562090 URL: http://svn.apache.org/viewvc?view=rev&rev=562090 Log: Revert the quickfix r562022. It looks like we found the real problem with r562085. Modified: tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c tomcat/connectors

Re: [VOTE] Release build 6.0.14

Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.14/ According to the release process, the 6.0.14 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Ok, so far this build seems stable. Any other votes ? Rémy

svn commit: r562085 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

Author: rjung Date: Thu Aug 2 04:57:29 2007 New Revision: 562085 URL: http://svn.apache.org/viewvc?view=rev&rev=562085 Log: Partially undo r530674: Chanhing the AS400 ifdefs also hit two ifndefs instead of only ifdefs. As a consequence, we didn't flush any more. Modified: tomcat/connectors/t

DO NOT REPLY [Bug 43013] - No mention of limitation regarding deployment with multi-level context paths (e.g. /123/456)

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 43014] - Enable manager to deploy apps with multi-level paths, e.g. /123/456

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 43014] New: - Enable manager to deploy apps with multi-level paths, e.g. /123/456

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: svn commit: r562022 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c xdocs/miscellaneous/changelog.xml

Rainer Jung wrote: OK, I'll go into it. I think I would propose a slightly different patch, but I'll investigate, why 23 and 24 are different. The reason why I started to pose querstions is, that I found it a little strange to make an exception for exactly one status code. My impression is:

Re: svn commit: r562022 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c xdocs/miscellaneous/changelog.xml

OK, I'll go into it. I think I would propose a slightly different patch, but I'll investigate, why 23 and 24 are different. The reason why I started to pose querstions is, that I found it a little strange to make an exception for exactly one status code. My impression is: the code was suppose

Re: svn commit: r562022 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c xdocs/miscellaneous/changelog.xml

Rainer Jung wrote: Hi Mladen, I don't full yunderstand this fix. From your other mail i though it's a regression, but the code in this region is the same at least since 1.2.18 (more than a year). So I have the impression, that this is not a regression. You can try 1.2.23 (it works). 1.2.24

DO NOT REPLY [Bug 43013] New: - No mention of limitation regarding deployment with multi-level context paths (e.g. /123/456)

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: svn commit: r562022 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c xdocs/miscellaneous/changelog.xml

Hi Mladen, I don't full yunderstand this fix. From your other mail i though it's a regression, but the code in this region is the same at least since 1.2.18 (more than a year). So I have the impression, that this is not a regression. If so, I would prefer to not push 1.2.25 through with very

DO NOT REPLY [Bug 43009] - Reported exception is not original cause of problem

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Serious regression in JK 1.2.24

Hi, OK with me. I've one outstanding patch related to fail on status. I think Ben short is testing today. I wrote mails about it to the user list and the patch is not committed yet. It's http://people.apache.org/~rjung/mod_jk-dev/patches/fail-on-status.patch (in short: fail on status has to