Re: svn commit: r762374 - in /tomcat/trunk: build.xml java/org/apache/catalina/cluster/ java/org/apache/catalina/cluster/CollectedInfo.java java/org/apache/catalina/cluster/HeartbeatListener.java

2009-04-06 Thread Rainer Jung
A few comments inline. On 06.04.2009 17:09, jfcl...@apache.org wrote: Author: jfclere Date: Mon Apr 6 15:09:19 2009 New Revision: 762374 URL: http://svn.apache.org/viewvc?rev=762374view=rev Log: First support for httpd-trunk heartbeat logic. Added:

Re: New sandbox project -- Apache Commons (Portable) Runtime

2009-04-06 Thread Rainer Jung
On 06.04.2009 21:32, Niall Pemberton wrote: Sounds good. Who currently works on the Tomcat code and are they happy for it to come here as well. Very basic commit statistics on repos/asf/tomcat/connectors/trunk/jni, not including data about how big each of the commits was: Count id 391 mturk

Re: svn commit: r762374 - in /tomcat/trunk: build.xml java/org/apache/catalina/cluster/ java/org/apache/catalina/cluster/CollectedInfo.java java/org/apache/catalina/cluster/HeartbeatListener.java

2009-04-06 Thread Rainer Jung
Hi Jean-Frederic, On 06.04.2009 18:40, jean-frederic clere wrote: Rainer Jung wrote: On 06.04.2009 17:09, jfcl...@apache.org wrote: Author: jfclere +package org.apache.catalina.cluster; Should we really reuse this package name? Until TC 5.5 that was the old cluster, and the package name

Re: [PATCH]: configurable session cookie domain (subdomain session support)

2009-04-06 Thread Rainer Jung
On 07.04.2009 00:46, Brane F. Gračnar wrote: On Monday 06 April 2009 18:19:26 Mark Thomas wrote: It would also be a good idea to include an update to the documentation in your patch. I know that this is a stupid question, but i don't have any idea which files to update :)

Re: [ANN] New committer: Konstantin Kolinko

2009-05-06 Thread Rainer Jung
On 06.05.2009 09:52, Mark Thomas wrote: On behalf of the Tomcat committers I am pleased to announce that Konstantin Kolinko has been voted in as a new Tomcat committer. Please join me in welcoming him. Hello Konstantin, congratulations for comittership! Great to have you in the team!

Re: Proposed mod_jk logging patch

2009-05-11 Thread Rainer Jung
Hi Jess, On 11.05.2009 18:43, Jess Holle wrote: I have noticed that mod_jk logging about a dead server is overtly verbose in some circumstances. If you use it to load balance over a number of servers and one is dead you'll get several lines of error logging every time it retries the server

Re: mod_jk 1.2.28 on i5/OS

2009-05-12 Thread Rainer Jung
Hi Henri, can you try the below patch? It replaces the global pool by a function local one, which is OK, because the resolver calls are not in the performance critical path (mostly startup initialization and reconfiguration). Why do you think, is it possible, that multiple threads will enter

Re: mod_jk 1.2.28 on i5/OS

2009-05-12 Thread Rainer Jung
On 12.05.2009 15:31, Henri Gomez wrote: I see you take a similar approach :) Yes, but based on your analysis. Could you attach the patch file ? Attached. 2009/5/12 Rainer Jung rainer.j...@kippdata.de: Hi Henri, can you try the below patch? It replaces the global pool by a function local

Re: mod_jk 1.2.28 on i5/OS

2009-05-12 Thread Rainer Jung
On 12.05.2009 15:57, Henri Gomez wrote: On 12.05.2009 15:31, Henri Gomez wrote: I see you take a similar approach :) Yes, but based on your analysis. I works :) If nobody object, you should commit it, static variable, apr_pool on a multi-threaded application, it's evil ;-( I will. But

Re: mod_jk 1.2.28 on i5/OS

2009-05-12 Thread Rainer Jung
Before committing I gave it a second thought. My theory is motivated by the crash around main_log we fixed in 2007. There we learned, that on i5 the two initialization passes of httpd are done in the same process. We also saw, that the pool pconf got invalidated after the first pass. That was a

Re: mod_jk 1.2.28 on i5/OS

2009-05-12 Thread Rainer Jung
Here's the patch keeping the original structure but using a cleanup to destroy the pool reference. If it works, I would like that better. Regards, Rainer Index: jk_connect.c === --- jk_connect.c(revision 763986) +++

Re: mod_jk 1.2.28 on i5/OS

2009-05-13 Thread Rainer Jung
On 13.05.2009 14:56, Henri Gomez wrote: Some comments on your latest provided patch : if (!jk_resolv_pool) { if (apr_pool_create(jk_resolv_pool, (apr_pool_t *)pool) != APR_SUCCESS) { JK_TRACE_EXIT(l); return JK_FALSE; }

Re: mod_jk 1.2.28 on i5/OS

2009-05-13 Thread Rainer Jung
Gimme a few minutes, there's something non i5-specific wrong with the patch ... On 13.05.2009 14:56, Henri Gomez wrote: Some comments on your latest provided patch : if (!jk_resolv_pool) { if (apr_pool_create(jk_resolv_pool, (apr_pool_t *)pool) != APR_SUCCESS) {

Re: mod_jk 1.2.28 on i5/OS

2009-05-13 Thread Rainer Jung
Sorry for the broken patch. Besides the not so nice multiple registation of the cleanup, the real problem for the crash after the patch is, that clear() on a pool already calls the cleanup. So I had to register the cleanup for the parent pool (pconf) and not for the pool itself. I'll think about

Re: [VOTE] Release build 6.0.20

2009-05-20 Thread Rainer Jung
On 14.05.2009 01:33, Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.20/ According to the release process, the 6.0.20 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Please stay tuned, I can test and vote tomorrow. Thanks

Re: svn commit: r776940 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-21 Thread Rainer Jung
Hi Kontantin, On 21.05.2009 05:22, kkoli...@apache.org wrote: Author: kkolinko Date: Thu May 21 03:21:58 2009 New Revision: 776940 URL: http://svn.apache.org/viewvc?rev=776940view=rev Log: proposals Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified:

Re: [VOTE] Release build 6.0.20

2009-05-21 Thread Rainer Jung
On 14.05.2009 01:33, Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.20/ According to the release process, the 6.0.20 tag is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Rainer Jung
On 21.05.2009 23:29, sebb wrote: Here are a few more missing properties: svn ps svn:eol-style native java/javax/el/LocalStrings_es.properties svn ps svn:eol-style native java/javax/servlet/LocalStrings_es.properties svn ps svn:eol-style native

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Rainer Jung
On 22.05.2009 00:48, sebb wrote: Some more fixes for trunk: svn ps svn:eol-style native java/org/apache/catalina/ha/backend/CollectedInfo.java svn ps svn:eol-style native java/org/apache/catalina/ha/backend/HeartbeatListener.java svn ps svn:eol-style native

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Rainer Jung
On 22.05.2009 01:07, Filip Hanik - Dev Lists wrote: rj...@apache.org wrote: Guys fix your svn configuration. ;) This happens to me all the time, as I move between machines very often. Why is the ~/.subversion/config a client setting? isn't there a way to setup properties on the server

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-22 Thread Rainer Jung
On 22.05.2009 03:59, William A. Rowe, Jr. wrote: Filip Hanik - Dev Lists wrote: sebb wrote: There's also a suggested set on the Apache site, see: http://www.apache.org/dev/version-control.html#https-svn-config that's exactly my point, everytime I just onto a new machine, and I forget,

Re: [VOTE] Release build 6.0.20

2009-05-22 Thread Rainer Jung
On 22.05.2009 15:45, Mark Thomas wrote: 2. i18n resources are still corrupted. There is a patch already in the STATUS file to fix this. Was an issue in 6.0.18 so this is a bug that has not been fixed rather than a regression. But only for the tarball source distribution, right? I checked some

Re: 5.5 release time frame

2009-06-30 Thread Rainer Jung
On 24.06.2009 18:28, Filip Hanik - Dev Lists wrote: what do you guys wanna do? Get through STATUS as it is today, then issue a release? I went through STATUS and voted. There are now a couple of proposals having the needed +1s. I plan to also vote on the two access log patches, but need to

Re: svn commit: r789714 - in /tomcat: container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java container/tc5.5.x/webapps/docs/changelog.xml current/tc5.5

2009-06-30 Thread Rainer Jung
On 30.06.2009 15:29, sebb wrote: On 30/06/2009, rj...@apache.org rj...@apache.org wrote: Author: rjung Date: Tue Jun 30 13:26:10 2009 New Revision: 789714 URL: http://svn.apache.org/viewvc?rev=789714view=rev Log: Separate statistics counter lock in FastAsyncSocketSender from

Re: svn commit: r790296 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-01 Thread Rainer Jung
On 01.07.2009 20:14, ma...@apache.org wrote: * Fix small memory leak found by find bugs. Backport of http://svn.apache.org/viewvc?view=revrevision=717906 from tc6 resp. http://svn.apache.org/viewvc?view=revrevision=735645 from OACC. +1: rjung, kkolinko + +1: markt - patch does much

Re: svn commit: r790296 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-01 Thread Rainer Jung
On 01.07.2009 22:03, Mark Thomas wrote: Rainer Jung wrote: On 01.07.2009 20:14, ma...@apache.org wrote: * Fix small memory leak found by find bugs. Backport of http://svn.apache.org/viewvc?view=revrevision=717906 from tc6 resp. http://svn.apache.org/viewvc?view=revrevision=735645

Re: svn commit: r790809 - /tomcat/trunk/webapps/docs/developers.xml

2009-07-06 Thread Rainer Jung
On 03.07.2009 08:55, ma...@apache.org wrote: Modified: tomcat/trunk/webapps/docs/developers.xml + liRainer Jung (rjung): Catalina, Clustering, Connectors/li Thanks Mark! - To unsubscribe, e-mail:

Re: [PROPOSAL] Remove SVN keywords from JavaDoc

2009-07-06 Thread Rainer Jung
On 07.07.2009 02:01, Konstantin Kolinko wrote: As was written early in this my thread: http://www.nabble.com/Coding-Guidelines%2C-encodings%2C-keywords-td23662661.html (http://markmail.org/thread/d6dsgrsfvnuzclt7) there are problems with Subversion $Date$ keyword: 1. It uses localized names

Re: [PROPOSAL] Remove SVN keywords from JavaDoc

2009-07-07 Thread Rainer Jung
On 07.07.2009 04:34, William A. Rowe, Jr. wrote: Rainer Jung wrote: So I like the idea of using Id, but I am open to arguments for dropping it. In httpd, we use; !-- $LastChangedRevision: 654723 $ -- in the reference file, and the tag !-- English Revision: 421100:654723 (outdated) -- which

Re: Immediately persist sessions to database

2009-07-07 Thread Rainer Jung
On 07.07.2009 18:21, Mitch Claborn wrote: I'm experimenting with writing some code to persist a session to the database, similar to org.apache.catalina.session.PersistentManager and org.apache.catalina.session.JDBCStore, but to store it immediately after the end of a user request, when the

Re: 5.5.28 tag on Monday July 13th

2009-07-08 Thread Rainer Jung
On 08.07.2009 18:32, Filip Hanik - Dev Lists wrote: Unless anyone objects, we can clear out the status for 5.5 and do a tag on Monday. I second Mark's and Mladen's remarks, but I think we all agree that there were lots of changes to 5.5 and a release is somehow overdue. So we should try to not

Re: 5.5.28 tag on Monday July 13th

2009-07-08 Thread Rainer Jung
On 08.07.2009 22:53, Filip Hanik - Dev Lists wrote: On 07/08/2009 01:43 PM, Rainer Jung wrote: On 08.07.2009 18:32, Filip Hanik - Dev Lists wrote: Unless anyone objects, we can clear out the status for 5.5 and do a tag on Monday. ... Filip: how tight is your time budget. Can you easily

Re: Question about CVE-2009-0033 DOS vulnerability

2009-07-09 Thread Rainer Jung
On 09.07.2009 22:40, Swapan Gupta wrote: I have a question about the applicability of the CVE-2009-0033http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0033DoS vulnerability in Tomcat 5.5.x. I have come across the description of the vulnerability at multiple places, but at most of the

Re: Question about CVE-2009-0033 DOS vulnerability

2009-07-13 Thread Rainer Jung
On 09.07.2009 23:06, Swapan Gupta wrote: ok, so that means if I have a single worker operating, I will not reach to a situation wherein because of exploitation of this vulnerability my single worker-AJP Connector combination runs out of connections to operate. Is that a fair statement? Yes.

Re: svn commit: r795010 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-17 Thread Rainer Jung
Hi Konstantin, On 17.07.2009 12:01, Konstantin Kolinko wrote: 2009/7/17 rj...@apache.org: Modified: tomcat/current/tc5.5.x/STATUS.txt Ported from 6.0 (mainly from Mladen's rev.791699) http://people.apache.org/~kkolinko/patches/2009-07-17_tc55_native_install_791699.patch - +1:

Re: svn commit: r795010 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-17 Thread Rainer Jung
All references to TC 6 in my reply should have been to TC 5.5. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Correct location of STATUS.txt for tcnative?

2009-07-20 Thread Rainer Jung
Hi, at the moment there are 2 STATUS.txt files for tcnative, one in the top level connectors directory of the tcnative 1.1.x branch, one in the sub directory named jni. I added the jni/STATUS.txt on January 1st, and Mladen the top level one on February 2nd. So we have time until August 8th to

Re: svn commit: r797151 - /tomcat/trunk/build.xml

2009-07-24 Thread Rainer Jung
On 23.07.2009 20:43, sebb wrote: On 23/07/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Thu Jul 23 17:15:55 2009 New Revision: 797151 URL: http://svn.apache.org/viewvc?rev=797151view=rev Log: Correct the file name Modified: tomcat/trunk/build.xml

Re: 5.5.28 release candidate

2009-07-25 Thread Rainer Jung
On 25.07.2009 01:44, sebb wrote: On 24/07/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Likewise, the file tomcat-users.xml looks wrong - it says that there is no user with the manager role, yet it contains the following entry: user name=admin password= roles=admin,manager / IMHO

Re: 5.5.28 release candidate

2009-07-25 Thread Rainer Jung
On 25.07.2009 16:47, Konstantin Kolinko wrote: 2009/7/25 Rainer Jung rainer.j...@kippdata.de: On 25.07.2009 01:44, sebb wrote: On 24/07/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: The server.xml file in the EXE is different from the one in the bin file and appears to be an old

Adding thumbs.db to svn:ignore?

2009-07-25 Thread Rainer Jung
I intend to add thumbs.db Thumbs.db to svn:ignore in any images folder we have in the webapps to prevent having it appearing again unintentionally. I would set the property for trunk and all release branches we maintain. Any objections? Regards, Rainer

Re: Correct location of STATUS.txt for tcnative?

2009-07-26 Thread Rainer Jung
On 20.07.2009 10:39, Rainer Jung wrote: Hi, at the moment there are 2 STATUS.txt files for tcnative, one in the top level connectors directory of the tcnative 1.1.x branch, one in the sub directory named jni. I added the jni/STATUS.txt on January 1st, and Mladen the top level one

Re: Notice : No more IBM support JK/Tomcat on i5/OS V6R1

2009-07-29 Thread Rainer Jung
Hello Henri, On 29.07.2009 16:15, Henri Gomez wrote: Hi to all, The new i5/OS V6R1 use Apache 2.2 and APR 1.x. The official IBM notice inform V6R1 admins that third party modules for Apache 2.2.x should be updated. They mention the Tomcat connector (mod_jk), the only Apache 2.2.x third

Re: ISAPI Redirect and uriworkers.properties

2009-07-31 Thread Rainer Jung
On 30.07.2009 19:10, RichKi wrote: Does anyone know if it's possible to filter by port number? I have an application running on port 3030 in Apache that also runs securely on port 8443. Incoming connections come to IIS on ports 80 and 443 respectively and are picked up by the ISAPI

Re: ISAPI Redirect and uriworkers.properties

2009-07-31 Thread Rainer Jung
What I forgot: The question belongs on the users list us...@tomcat.apache.org. Please continue the discussion there. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

Re: mod_jk 1.2.28 on i5/OS

2009-08-12 Thread Rainer Jung
Am 05.08.2009 12:37, schrieb Henri Gomez: Hi Rainer. With your latest patch, it seems to works. May be the problem wasn't in thread collision but just with pool problem with double inits. I'll do more tests and so stress load Same patches needed to make it works on i5/OS V6R1. When did a

Re: Making AJP secret attribute consistent

2009-08-13 Thread Rainer Jung
On 13.08.2009 20:31, Mladen Turk wrote: On 13/08/09 19:43, Konstantin Kolinko wrote: Other option is to use required.secret instead requiredSecret Much easier because requiredSecret isn't document, so one can only find it browsing the source code. However dunno how to make it using current

Re: [proposal] remove worker based connector thread pools in trunk

2009-08-17 Thread Rainer Jung
On 13.08.2009 22:07, Filip Hanik - Dev Lists wrote: Here is why I think its good 1. Current pools can't shrink, so when peak has been hit, that's where were at 2. Current pools are unfair, synchronized (workers) { workers.wait() }, executors are a bit more fair since they only hold a lock

Sporadically broken Download for 2.2.13 windows binaries?

2009-08-25 Thread Rainer Jung
Hi, I observed strange behaviour for the Windows 2.2.13 binary download. Retrieving it with Firefox and with MSIE 8 directly form http://archive.apache.org/dist/httpd/binaries/win32/apache_2.2.13-win32-x86-openssl-0.9.8k.msi stopped downloading after 4.923.392 Bytes instead of 6.034.944 Bytes.

Re: Sporadically broken Download for 2.2.13 windows binaries?

2009-08-25 Thread Rainer Jung
Sorry for the noise, wrong list, address auto-completion :( On 25.08.2009 16:50, Rainer Jung wrote: Hi, I observed strange behaviour for the Windows 2.2.13 binary download. Retrieving it with Firefox and with MSIE 8 directly form http://archive.apache.org/dist/httpd/binaries/win32

Re: svn commit: r810132 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-09-01 Thread Rainer Jung
Amtsgericht Bonn / USt.-IdNr. DE 196 457 417 Geschäftsführer: Dr. Thomas Höfer, Rainer Jung, Sven Maurmann === kippdata informationstechnologie GmbH Tel: +49 228 98549 -0 Bornheimer Str. 33aFax: +49 228 98549 -50 D-53111 Bonn

Re: Testing new website sync process

2009-09-03 Thread Rainer Jung
Go for it. Some remarks on the web site: 1) Tomcat connectors (JK) the docs are fully in svn, but only the xml/xslt part and the ant build support. The generated docs are at the moment not part of svn. Even if we put them in, we would need a way to decide, which version (tag) gets pushed.

Re: svn commit: r810161 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-09-07 Thread Rainer Jung
On 07.09.2009 18:45, Mark Thomas wrote: rj...@apache.org wrote: URL: http://svn.apache.org/viewvc?rev=810161view=rev + rjung: The docs page contains a typo: rmiRegsitryPortPlatform - rmiRegistryPortPlatform Fixed. + There are also some hidden defaults (password and access file)

Re: No localhost logging in solaris

2009-09-09 Thread Rainer Jung
Shot in the dark: Is it left over from a previous test with another user (permission problem)? On 09.09.2009 21:43, Martin L wrote: The file is created, but it is empty. The file catalina.date.log is also created and Tomcat writes to it. /Martin JoshInWV wrote: Isn't Solaris based on

tcnative 1.1.x CTR or RTC

2009-09-16 Thread Rainer Jung
Is tcnative 1.1.x CTR or RTC? We once had a status file, which was lost during the svn reorg. I recovered it. There are a couple of simple fixes sitting in there and waiting for a vote, but if we are still RTC, I would like to apply them before 1.1.17. I was just wondering because of Marks

Re: tcnative 1.1.x CTR or RTC

2009-09-16 Thread Rainer Jung
On 16.09.2009 13:49, Mark Thomas wrote: Rainer Jung wrote: Is tcnative 1.1.x CTR or RTC? I thought CTR - if that was wrong then I apologise. No need. We once had a status file, which was lost during the svn reorg. I recovered it. Thanks. Sorry for that. Thanks for doing the reorg work

Re: svn commit: r815768 - in /tomcat/native/branches/1.1.x: ./ java/org/apache/tomcat/jni/

2009-09-16 Thread Rainer Jung
On 16.09.2009 16:18, Mark Thomas wrote: rj...@apache.org wrote: Author: rjung Date: Wed Sep 16 13:24:54 2009 New Revision: 815768 URL: http://svn.apache.org/viewvc?rev=815768view=rev Log: Sync java parts of tcnative with C part. Do we need the java part here any more? 5.5.x, 6.0.x and

Re: mod_jk shm and locking questions

2009-09-16 Thread Rainer Jung
On 16.09.2009 17:38, Michael Durket wrote: In working on a private copy of the mod_jk module, I notice that mod_jk doesn't seem to use either the EAPI shared memory management routines (in Apache 1.3) and in Apache 2.2 doesn't appear to use the APR routines for either shared memory or

How should we handle the Java files for native?

2009-09-16 Thread Rainer Jung
On 16.09.2009 17:24, Mladen Turk wrote: On 16/09/09 16:18, Mark Thomas wrote: rj...@apache.org wrote: Author: rjung Date: Wed Sep 16 13:24:54 2009 New Revision: 815768 URL: http://svn.apache.org/viewvc?rev=815768view=rev Log: Sync java parts of tcnative with C part. Do we need the java

Re: svn commit: r818040 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-09-23 Thread Rainer Jung
On 23.09.2009 13:12, Mark Thomas wrote: rj...@apache.org wrote: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47267 http://svn.apache.org/viewvc?rev=817822view=rev +1: markt -1: + rjung: Our dreaded multi platform build system is a bit fragile + w.r.t. fixcrlf. If you

Port r818062 to BackupManager?

2009-09-23 Thread Rainer Jung
Hi Filip, I think the below needs some kind of port to the BackupManager. Ideas? Regards, Rainer On 23.09.2009 13:28, rj...@apache.org wrote: Author: rjung Date: Wed Sep 23 11:28:14 2009 New Revision: 818062 URL: http://svn.apache.org/viewvc?rev=818062view=rev Log: DeltaManager needs

Re: Port r818062 to BackupManager?

2009-09-23 Thread Rainer Jung
On 23.09.2009 16:17, Filip Hanik - Dev Lists wrote: hi Rainer, DeltaManager needs to replicate changed attributes even if session gets invalidated. Otherwise session listeners will not see the right data on the secondary nodes. This is an interesting use case indeed. The fact that we

tcnative in TC5.5: version properties

2009-10-04 Thread Rainer Jung
Hi, while cleaning up the connectors/jni build.xml in TC 5.5 I stumbled over the following: There are two ways to build the Java classes for tcnative in TC 5.5. One way is using the build.xml of TC 5.5. It uses the Java files from the jni source as is, as well as the file apr.properties,

Re: Taglibs website migration

2009-10-06 Thread Rainer Jung
On 05.10.2009 22:11, Henri Yandell wrote: This is now live. The Jakarta side of things has been retired and some redirects exist. It's ready to be linked to from tomcat.apache.org. What do people think is best? a) A Taglibs entry under the Home link. +1 b) Individual entries per

Re: response.encodeURL(http://localhost:8080) produces an invalid URL?

2011-07-05 Thread Rainer Jung
On 29.06.2011 13:55, Konstantin Kolinko wrote: 2011/6/29 Rainer Jung rainer.j...@kippdata.de: Motivated by https://issues.apache.org/jira/browse/WICKET-3841 I tested response.encodeURL(http://localhost:8080;) and I get http://localhost:8080;jsessionid=... (cookies off). Note

Re: svn commit: r1135088 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2011-07-06 Thread Rainer Jung
Hi Konstantin, On 06.07.2011 08:03, Konstantin Kolinko wrote: 1. JavaDoc for the method has to be updated. It still says that the name is quoted. Will fix. 2. If I understand correctly, the name _is_ used directly, in AbstractConnectionHandler.register(): ... ,worker= +

Re: Blank extra access log entries with AJP connector in 7.0.18

2011-07-08 Thread Rainer Jung
wild-guess Could it be the cping/cpong? /wild-guess On 08.07.2011 05:41, Konstantin Kolinko wrote: Running 7.0.18 behind Apache HTTPD, using Ajp connector (Bio), for every actual request there are two records in the access log, one true record, followed by a blank one. E.g.: ipaddress -

Re: Blank extra access log entries with AJP connector in 7.0.18

2011-07-08 Thread Rainer Jung
On 08.07.2011 09:18, Rainer Jung wrote: wild-guess Could it be the cping/cpong? /wild-guess Hmmm, doesn't make much sense, the additional line seems to be after the original request. Rainer On 08.07.2011 05:41, Konstantin Kolinko wrote: Running 7.0.18 behind Apache HTTPD, using Ajp

Re: Blank extra access log entries with AJP connector in 7.0.18

2011-07-08 Thread Rainer Jung
No without wild guessing: AjpProcessor.recycle() now nulls input. On the next loop through processing the connection, trying to read from the nulled input will lead to an NPE, producing the 400 log entry. In 7.0.16 recycle was implemented in AbstractAjpProcessor.java and did not null input.

Re: Blank extra access log entries with AJP connector in 7.0.18

2011-07-08 Thread Rainer Jung
On 08.07.2011 10:50, Mark Thomas wrote: On 08/07/2011 09:47, Rainer Jung wrote: No without wild guessing: AjpProcessor.recycle() now nulls input. On the next loop through processing the connection, trying to read from the nulled input will lead to an NPE, producing the 400 log entry

Re: [VOTE] Release Apache Tomcat 7.0.18

2011-07-10 Thread Rainer Jung
On 07.07.2011 12:10, Mark Thomas wrote: The proposed Apache Tomcat 7.0.18 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.18/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_18/ The proposed

Re: svn commit: r1135088 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2011-07-10 Thread Rainer Jung
On 06.07.2011 10:07, Konstantin Kolinko wrote: 2011/7/6 Rainer Jung rainer.j...@kippdata.de: Hi Konstantin, On 06.07.2011 08:03, Konstantin Kolinko wrote: 1. JavaDoc for the method has to be updated. It still says that the name is quoted. Will fix. 2. If I understand correctly, the name

Sporadic failures in TestCometProcessor

2011-07-10 Thread Rainer Jung
I get sporadic failures in TestCometProcessor for NIO. They are due to the Servlet reading two or more of the PING tokens during a single read event call. The loop while (is.available() 0) { is.read(); count ++; } then e.g.

Re: Sporadic failures in TestCometProcessor

2011-07-10 Thread Rainer Jung
On 10.07.2011 12:13, Mark Thomas wrote: On 10/07/2011 10:28, Rainer Jung wrote: I get sporadic failures in TestCometProcessor for NIO. They are due to the Servlet reading two or more of the PING tokens during a single read event call. The loop while (is.available() 0

Re: Preparing for a 7.0.19 tag

2011-07-10 Thread Rainer Jung
On 10.07.2011 12:56, Mark Thomas wrote: Just a quick summary of the regressions reported against 7.0.18 and other issues that need to be fixed before 7.0.19 is tagged. 7.0.17 / 7.0.18 regressions - IPv6 broken - fixed - no test case (nice to have but not essential for 7.0.19) - AJP

Re: Preparing for a 7.0.19 tag

2011-07-10 Thread Rainer Jung
On 10.07.2011 13:58, Rainer Jung wrote: - TestAsyncContextImpl fails for BIO, NIO and APR: Testcase: testTimeoutListenerCompleteDispatch took 6.074 sec FAILED expected:1 but was:0 junit.framework.AssertionFailedError: expected:1 but was:0

Re: svn commit: r1144061 - in /tomcat/trunk: build.xml modules/jdbc-pool/build.xml res/maven/mvn-pub.xml res/maven/tomcat-jdbc.pom webapps/docs/project.xml

2011-07-10 Thread Rainer Jung
Hi Filip, On 07.07.2011 23:40, fha...@apache.org wrote: Author: fhanik Date: Thu Jul 7 21:40:05 2011 New Revision: 1144061 URL: http://svn.apache.org/viewvc?rev=1144061view=rev Log: Include jdbc-pool into tomcat release. Added: tomcat/trunk/res/maven/tomcat-jdbc.pom Modified:

Missing thread name in requestProcessor when handling Async

2011-07-10 Thread Rainer Jung
Using an AccessLogValve during the unit tests reveals, that the thread name in the request processor is often not set when handliung async requests. To reproduce run TestAsyncContextImpl for trunk with test.accesslog=true and have a look at the access log in output/build/logs. The only requests

Re: Missing thread name in requestProcessor when handling Async

2011-07-10 Thread Rainer Jung
On 10.07.2011 16:07, Mark Thomas wrote: On 10/07/2011 14:53, Rainer Jung wrote: Using an AccessLogValve during the unit tests reveals, that the thread name in the request processor is often not set when handliung async requests. To reproduce run TestAsyncContextImpl for trunk

Re: svn commit: r1141392 - in /tomcat/native/branches/1.1.x: native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2011-07-10 Thread Rainer Jung
Hi Mladen, On 30.06.2011 06:26, mt...@apache.org wrote: Author: mturk Date: Thu Jun 30 04:26:36 2011 New Revision: 1141392 URL: http://svn.apache.org/viewvc?rev=1141392view=rev Log: Fix BZ51437 by trying to load the DER cerificate if pem load error was PEM_R_NO_START_LINE Modified:

Re: svn commit: r1141392 - in /tomcat/native/branches/1.1.x: native/src/sslcontext.c xdocs/miscellaneous/changelog.xml

2011-07-10 Thread Rainer Jung
I was checking trunk and 1.1.x for differences and I think this backport of 1141388 is wrong. In trunk you patched the function load_pem_cert(), in 1.1.x the function load_pem_key(), therefore replacing key with cert etc. I guess you want to revert the change to load_pem_key() and instead

Distributable contexts and non-serializable session attributes

2011-07-10 Thread Rainer Jung
I implemented an addition to DeltaManager which allows to filter which session attributes actually get replicated (not yet committed). This is useful, because many applications - use non-serializable session attributes, so it is not possible to simply replicate everything - do not actually

Re: svn commit: r1144061 - in /tomcat/trunk: build.xml modules/jdbc-pool/build.xml res/maven/mvn-pub.xml res/maven/tomcat-jdbc.pom webapps/docs/project.xml

2011-07-10 Thread Rainer Jung
On 10.07.2011 21:05, Filip Hanik - Dev Lists wrote: On 7/10/2011 6:59 AM, Rainer Jung wrote: Wouldn't it suffice to remove the copied docs file and to clean jdbc-pool during the clean target? Something along the lines of: http://people.apache.org/~rjung/patches/tomcat-jdbc-pool-build

[jdbc-pool] AT sign in manifest (filtered version strings)

2011-07-10 Thread Rainer Jung
I tested the jdbc-pool building, which is part of the release right now. The manifest contains patterns of the form @@VERSION@@, e.g. org.apache.tomcat.jdbc.pool;version=@@VERSION@@; org.apache.tomcat.jdbc.pool.interceptor;version=@@VERSION@@; org.apache.tomcat.jdbc.pool.jmx;version=@@VERSION@@;

Re: svn commit: r1144833 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-07-11 Thread Rainer Jung
On 11.07.2011 01:24, Konstantin Kolinko wrote: 2011/7/10 rj...@apache.org: Author: rjung Date: Sun Jul 10 11:22:40 2011 New Revision: 1144833 URL: http://svn.apache.org/viewvc?rev=1144833view=rev Log: Another regression in 7.0.18: year number formatting in AccessLogValve is broken due to

Re: svn commit: r1144833 - in /tomcat/trunk: java/org/apache/catalina/valves/AccessLogValve.java webapps/docs/changelog.xml

2011-07-11 Thread Rainer Jung
On 11.07.2011 12:35, Konstantin Kolinko wrote: 2011/7/11 Rainer Jung rainer.j...@kippdata.de: On 11.07.2011 01:24, Konstantin Kolinko wrote: I suggest we at least make the behaviour consistent: - Change the defaults to en_US I think it has to be en_US. Right. CLF will now always use

Re: Using juli DateFormatCache in AccessLogValve?

2011-07-11 Thread Rainer Jung
On 11.07.2011 13:19, Konstantin Kolinko wrote: 2011/6/23 Rainer Jung rainer.j...@kippdata.de: Since OneLineFormatter now uses the DateFormatCache util class, and to prevent any dependency of juli form other packages that util class sits in juli, what do we think about using it also

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Rainer Jung
On 10.07.2011 23:11, Filip Hanik - Dev Lists wrote: go ahead add it in, if you add in a flag to toggle the behavior, and the flag is defaulted to today's behavior. you're safe, and you give users an option Thanks for the feedback. I will go with Konstantin's suggestion of making it

Re: Distributable contexts and non-serializable session attributes

2011-07-11 Thread Rainer Jung
On 11.07.2011 13:41, Konstantin Kolinko wrote: 2011/7/10 Rainer Jung rainer.j...@kippdata.de: I think checking for serializability in StandardSession isn't good, because AFAIK StandardSession isn't used by any mechanism Tomcat supports to implement distributable. And in DeltaSession I would

Locale and SimpleDateFormat: creationdate in WebdavServlet

2011-07-11 Thread Rainer Jung
WebdavServlet uses -MM-dd'T'HH:mm:ss'Z' witout setting Locale.US. The format is specified in http://www.ietf.org/rfc/rfc2518.txt, 23.2 Appendix 2 - ISO 8601 Date and Time Profile, and I would say it should also be en_US. I don't know much about Webdav though ... Agreed? It is the last SDF

Re: Tagging 7.0.19

2011-07-13 Thread Rainer Jung
On 13.07.2011 15:32, Mark Thomas wrote: On 13/07/2011 14:28, ma...@apache.org wrote: Author: markt Date: Wed Jul 13 13:28:24 2011 New Revision: 1146005 With this commit I am going to start the process of running the unit and TCK tests prior to tagging 7.0.19. Assuming everything passes,

Re: [VOTE] Release Apache Tomcat 7.0.19

2011-07-15 Thread Rainer Jung
On 14.07.2011 11:21, Mark Thomas wrote: The proposed Apache Tomcat 7.0.19 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.19/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_19/ The proposed

Re: Tomcat 7 under Java 7

2011-07-15 Thread Rainer Jung
On 15.07.2011 02:22, Henri Gomez wrote: Hi guys, I conducted some tests with Tomcat 7 (7.0.19) and I noticed a slower startup time under Java 7 (OpenJDK) than under Java 1.6. I also see a serious boost in startup between TC 6.0.32 and TC 7.0.19, Jetty is not too far behind. I blogged

Re: [VOTE] Release Apache Tomcat 7.0.19

2011-07-15 Thread Rainer Jung
On 15.07.2011 12:14, Mark Thomas wrote: On 15/07/2011 11:10, Rainer Jung wrote: AJP connection persistance is fine for BIO and APR. The experimental NIO seems to still not use persistent AJP connections, but is IMHO no show stopper, because it is new and marked as experimental in the docs

Re: [VOTE] Release Apache Tomcat 7.0.19

2011-07-15 Thread Rainer Jung
Value of DEFAULT_CONNECTION_TIMEOUT in java/org/apache/coyote/http11/Constants.java public static final int DEFAULT_CONNECTION_TIMEOUT = 6; java/org/apache/coyote/ajp/Constants.java public static final int DEFAULT_CONNECTION_TIMEOUT = -1; Anf for BIO AJP this -1 lead to infinite

Re: svn commit: r1146623 - in /tomcat/trunk: conf/catalina.properties webapps/docs/changelog.xml

2011-07-19 Thread Rainer Jung
On 14.07.2011 12:08, Konstantin Kolinko wrote: 2011/7/14 kkoli...@apache.org: Author: kkolinko Date: Thu Jul 14 09:58:31 2011 New Revision: 1146623 URL: http://svn.apache.org/viewvc?rev=1146623view=rev Log: Corrected typo in the value of tomcat.util.scan.DefaultJarScanner.jarsToSkip

Re: svn commit: r1148814 - /tomcat/native/branches/1.1.x/native/src/network.c

2011-07-20 Thread Rainer Jung
JFC: please don't forget to update trunk of tcnative too. I recently forward ported a lot of changes because the 1.1 branch was ahead of trunk. Regards, Rainer On 20.07.2011 17:25, jfcl...@apache.org wrote: Author: jfclere Date: Wed Jul 20 15:25:02 2011 New Revision: 1148814 URL:

Re: svn commit: r1148815 - /tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java

2011-07-20 Thread Rainer Jung
On 20.07.2011 17:28, jfcl...@apache.org wrote: Author: jfclere Date: Wed Jul 20 15:28:05 2011 New Revision: 1148815 URL: http://svn.apache.org/viewvc?rev=1148815view=rev Log: Improve fix for PR50394 Requires native 1.1.21 Does it require it unconditionally, or does it work with 1.1.20 and

Re: svn commit: r1149093 - /tomcat/native/branches/1.1.x/native/src/sslcontext.c

2011-07-21 Thread Rainer Jung
Why is this change needed? Look around current line 139, which already handles that case. All the options are set there and the code before your change mimics the code in httpd. I tested it recently and thought it's correct for all protocol settings. Regards, Rainer On 21.07.2011 11:56,

Re: Servlet 3.1, Tomcat 8 etc.

2011-07-26 Thread Rainer Jung
On 26.07.2011 19:30, Mark Thomas wrote: The Servlet EG is starting to discuss changes to the Servlet API for 3.1. It would be useful if the option existed to implement some of these changes in Tomcat trunk. The benefits of this are: - we can see how feasible the API changes are to implement -

<    1   2   3   4   5   6   7   8   9   10   >