Andreas Neumann created TWILL-209:
-
Summary: Location test should validate permissions
Key: TWILL-209
URL: https://issues.apache.org/jira/browse/TWILL-209
Project: Apache Twill
Issue Type:
[
https://issues.apache.org/jira/browse/TWILL-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837002#comment-15837002
]
ASF GitHub Bot commented on TWILL-181:
--
Github user serranom commented on the issue:
Github user serranom commented on the issue:
https://github.com/apache/twill/pull/23
Thanks Henry! No rush on my account, I was just checking in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836976#comment-15836976
]
ASF GitHub Bot commented on TWILL-208:
--
Github user anew commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836970#comment-15836970
]
ASF GitHub Bot commented on TWILL-208:
--
Github user anew commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836971#comment-15836971
]
ASF GitHub Bot commented on TWILL-208:
--
Github user anew commented on a diff in the pull request:
Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97689959
--- Diff:
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -251,6 +251,34 @@ public boolean mkdirs() throws IOException {
Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97689935
--- Diff:
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -98,8 +98,8 @@ public OutputStream getOutputStream() throws IOException
[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836965#comment-15836965
]
ASF GitHub Bot commented on TWILL-208:
--
Github user anew commented on a diff in the pull request:
Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97689666
--- Diff:
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
boolean mkdirs() throws IOException;
[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836910#comment-15836910
]
ASF GitHub Bot commented on TWILL-208:
--
Github user poornachandra commented on a diff in the pull
[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836911#comment-15836911
]
ASF GitHub Bot commented on TWILL-208:
--
Github user poornachandra commented on a diff in the pull
[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836912#comment-15836912
]
ASF GitHub Bot commented on TWILL-208:
--
Github user poornachandra commented on a diff in the pull
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97682185
--- Diff:
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
boolean mkdirs() throws IOException;
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97683616
--- Diff:
twill-common/src/main/java/org/apache/twill/filesystem/LocalLocation.java ---
@@ -251,6 +251,34 @@ public boolean mkdirs() throws IOException {
[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836890#comment-15836890
]
ASF GitHub Bot commented on TWILL-208:
--
Github user albertshau commented on a diff in the pull
Github user albertshau commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r97681685
--- Diff:
twill-common/src/main/java/org/apache/twill/filesystem/Location.java ---
@@ -207,6 +207,21 @@
boolean mkdirs() throws IOException;
[
https://issues.apache.org/jira/browse/TWILL-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836876#comment-15836876
]
ASF GitHub Bot commented on TWILL-181:
--
Github user hsaputra commented on the issue:
Github user hsaputra commented on the issue:
https://github.com/apache/twill/pull/23
Let's trigger new build, @serranom could you close and reopen this PR
please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/TWILL-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836868#comment-15836868
]
ASF GitHub Bot commented on TWILL-205:
--
Github user hsaputra commented on the issue:
Github user hsaputra commented on the issue:
https://github.com/apache/twill/pull/25
@anew feel free to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user hsaputra commented on the issue:
https://github.com/apache/twill/pull/23
Hi @serranom , usually in about week you should get review. I apologize for
the delay, but sometimes there is delay just due to volunteer time.
As for CI failures, it depends, sometime ZK is flaky
[
https://issues.apache.org/jira/browse/TWILL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836859#comment-15836859
]
ASF GitHub Bot commented on TWILL-208:
--
GitHub user anew opened a pull request:
GitHub user anew opened a pull request:
https://github.com/apache/twill/pull/26
(TWILL-208) add Location.mkdirs(String permissions)
- adds mkdirs() that takes permissions
- makes sure getOutputStream(permisssions) also uses that when creating the
directories
- add test
Github user serranom commented on the issue:
https://github.com/apache/twill/pull/23
A couple of questions. Note, I'm not irritated or anything like that...
just want to have my expectations in line for planning purposes.
* What should I generally expect for feedback on the
Andreas Neumann created TWILL-208:
-
Summary: Location should have a way to set permissions when
creating directories
Key: TWILL-208
URL: https://issues.apache.org/jira/browse/TWILL-208
Project:
26 matches
Mail list logo