Re: [Dev] WSO2 Committers += Madhawa Perera

2017-06-20 Thread Heshitha Hettihewa
Congratz Madhawa! :) On Wed, Jun 21, 2017 at 11:23 AM, Imesh Chandrasiri wrote: > Congratulations madhawa.. :) > > On Tue, Jun 20, 2017 at 2:19 PM, Pasindu Jayaweera > wrote: > >> Congratulations Madhawa...!! >> >> On Tue, Jun 20, 2017 at 11:38 AM,

Re: [Dev] WSO2 Committers += Madhawa Perera

2017-06-20 Thread Imesh Chandrasiri
Congratulations madhawa.. :) On Tue, Jun 20, 2017 at 2:19 PM, Pasindu Jayaweera wrote: > Congratulations Madhawa...!! > > On Tue, Jun 20, 2017 at 11:38 AM, Milinda Wickramasinghe < > milin...@wso2.com> wrote: > >> Congratulations Madhawa...! >> >> On Tue, Jun 20, 2017 at

Re: [Dev] Custom UserStore works on 5.1.0, 5.2.0 not working in 5.3.0 and 5.4.0-M1

2017-06-20 Thread Sagara Gunathunga
On Wed, Jun 21, 2017 at 11:06 AM, Farasath Ahamed wrote: > > > > > On Wed, Jun 21, 2017 at 11:03 AM, Isura Karunaratne > wrote: > >> >> >> On Tue, Jun 20, 2017 at 11:29 PM, Johann Nallathamby >> wrote: >> >>> If these two handlers are

Re: [Dev] Custom UserStore works on 5.1.0, 5.2.0 not working in 5.3.0 and 5.4.0-M1

2017-06-20 Thread Farasath Ahamed
On Wed, Jun 21, 2017 at 11:03 AM, Isura Karunaratne wrote: > > > On Tue, Jun 20, 2017 at 11:29 PM, Johann Nallathamby > wrote: > >> If these two handlers are disabled by default there shouldn't be any >> problem. According to default identity-event.properties

Re: [Dev] Custom UserStore works on 5.1.0, 5.2.0 not working in 5.3.0 and 5.4.0-M1

2017-06-20 Thread Isura Karunaratne
On Tue, Jun 20, 2017 at 11:29 PM, Johann Nallathamby wrote: > If these two handlers are disabled by default there shouldn't be any > problem. According to default identity-event.properties file they are > disabled. How come they get triggered then? > Yes. By default the account

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Nuwan Dias
Yes, that's what I was suggesting. From the UI it looks like its a single operation, but behind the scenes we need to be doing 2 (or more) REST calls to get this working. On Wed, Jun 21, 2017 at 9:45 AM, Bhathiya Jayasekara wrote: > > On Wed, Jun 21, 2017 at 8:01 AM, Malintha

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Bhathiya Jayasekara
On Wed, Jun 21, 2017 at 8:01 AM, Malintha Amarasinghe wrote: > Hi, > > If we are generating keys and creating an app at the same time (from the > UI with 2 REST calls), I guess we will need to have a separate option at > the app creation page itself for "Providing keys".

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Malintha Amarasinghe
Hi, If we are generating keys and creating an app at the same time (from the UI with 2 REST calls), I guess we will need to have a separate option at the app creation page itself for "Providing keys". Maybe a checkbox "Provide keys" which enables two text boxes to specify consumer key and secret

Re: [Dev] [APIM][C5] - Handling API's gateway label updates

2017-06-20 Thread Isuru Haththotuwa
On Tue, Jun 20, 2017 at 8:29 PM, Nuwan Dias wrote: > I'm not in favor of using special headers or anything like that. What if > we just send all API updates to all Gateways? Each Gateway upon receiving > this event will request for the particular API from the Core. The Core will

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Nuwan Dias
We need to have two resources for generating keys and generating a token. The user experience (UI) should be such that when you create an application you automatically create the consumer key and consumer secret too. So the UI will have to make two calls, POST /application and POST /generate-keys

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Malintha Amarasinghe
Hi Chamila, I guess we do not need to rename the REST resource "generate-keys" since it is inline with "Create OAuth application". So basically user will Create an application -> Generate Keys -> Generate tokens. So I guess he will not notice (using REST operations) that he is creating multiple

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Bhathiya Jayasekara
Hi Nuwan, On Tue, Jun 20, 2017 at 11:29 PM, Nuwan Dias wrote: > I am suggesting the user experience be as such that when you create the > Application it automatically creates the keys too (except the token). > I had thought about this too. But the problem with this is we have

Re: [Dev] Custom UserStore works on 5.1.0, 5.2.0 not working in 5.3.0 and 5.4.0-M1

2017-06-20 Thread Johann Nallathamby
If these two handlers are disabled by default there shouldn't be any problem. According to default identity-event.properties file they are disabled. How come they get triggered then? On Tue, Jun 20, 2017 at 7:25 PM, Farasath Ahamed wrote: > Hi, > > The minimum requirement to

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Nuwan Dias
I am suggesting the user experience be as such that when you create the Application it automatically creates the keys too (except the token). There should be a separate resource/action for generating the keys however, so that one can separate that part if needed. On Tue, Jun 20, 2017 at 11:02 PM,

Re: [Dev] [APIM][C5] - Handling API's gateway label updates

2017-06-20 Thread Harsha Kumara
On Tue, Jun 20, 2017 at 8:29 PM, Nuwan Dias wrote: > I'm not in favor of using special headers or anything like that. What if > we just send all API updates to all Gateways? Each Gateway upon receiving > this event will request for the particular API from the Core. The Core will

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Chamila Adhikarinayake
Hi Bhathiya, I have a small concern regarding this. Previously user only has to create application then create tokens, Now he has to create Application, then create Oauth application and then generate tokens. I think user might get confuced why he is creating two applications. On Tue, Jun 20,

[Dev] Custom UserStore works on 5.1.0, 5.2.0 not working in 5.3.0 and 5.4.0-M1

2017-06-20 Thread Farasath Ahamed
Hi, The minimum requirement to write a custom JDBC user store manager so far (before IS 5.3.0) was to simply override the doAuthenticate() method. So a custom user store that was written for 5.0.0 worked without any modifications (may be dependency changes). But when we use the same code on IS

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Shani Ranasinghe
+1 would be easier to handle error scenarios, such as when step 1 succeeds but step 2 fails etc. On Tue, Jun 20, 2017 at 2:57 PM, Chamin Dias wrote: > Suggested method looks good. +1. > > On Tue, Jun 20, 2017 at 2:50 PM, Uvindra Dias Jayasinha > wrote: > >>

Re: [Dev] [APIM][C5] - Handling API's gateway label updates

2017-06-20 Thread Nuwan Dias
I'm not in favor of using special headers or anything like that. What if we just send all API updates to all Gateways? Each Gateway upon receiving this event will request for the particular API from the Core. The Core will only give that API to the Gateway if the Gateway's labels matches that of

Re: [Dev] Custom UserStore works on 5.1.0, 5.2.0 not working in 5.3.0 and 5.4.0-M1

2017-06-20 Thread Sagara Gunathunga
On Tue, Jun 20, 2017 at 7:25 PM, Farasath Ahamed wrote: > Hi, > > The minimum requirement to write a custom JDBC user store manager so far > (before IS 5.3.0) was to simply override the doAuthenticate() method. So a > custom user store that was written for 5.0.0 worked

[Dev] IS 5.3.0 - How to change the OpenId Connect issuer value

2017-06-20 Thread Vazquez-Hidalgo, Javier
Hi, I'm trying to change the issuer value returned by the id token but it always returns the IP address ... "iss": https://:9443/oauth2/token ... I would like to have ... "iss": https://:9443/oauth2/token

Re: [Dev] Invitation: [GSoC][APIM] Environment Support for API Manager weekly s... @ Tue Jun 20, 2017 10am - 11am (Ravindu Perera)

2017-06-20 Thread Ravindu Perera
Hi Meeting notes - Discussed on adding a environment variable authenticate service , in order to switch the environments - Discussed on an format for the deployment.yaml to keep the details of the environments . - Created mild stones to finish within the week. Thanks . On Mon,

Re: [Dev] [APIM][C5] - Handling API's gateway label updates

2017-06-20 Thread Harsha Kumara
On Tue, Jun 20, 2017 at 11:39 AM, Thilini Shanika wrote: > Hi All, > > As per the APIM C5 architecture, the gateways can be registered in APIM > Core, specifying it's label and accessURLs. When creating/updating APIs, > the API can be moved to a gateway by assigning the label

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Chamin Dias
Suggested method looks good. +1. On Tue, Jun 20, 2017 at 2:50 PM, Uvindra Dias Jayasinha wrote: > +1 > > On 20 June 2017 at 14:47, Bhathiya Jayasekara wrote: > >> Hi all, >> >> In the current implementation of store REST API, we have a single >> operation

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Harsha Kumara
+1 for separating the key generation and access token generation. We will need to handle this in UI level appropriately. On Tue, Jun 20, 2017 at 2:50 PM, Uvindra Dias Jayasinha wrote: > +1 > > On 20 June 2017 at 14:47, Bhathiya Jayasekara wrote: > >> Hi

Re: [Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Uvindra Dias Jayasinha
+1 On 20 June 2017 at 14:47, Bhathiya Jayasekara wrote: > Hi all, > > In the current implementation of store REST API, we have a single > operation (aka. Generate Keys) to create OAuth application and generate > access tokens, which requires 2 calls to key manager. IMO, if we

[Dev] [APIM][C5] Splitting "Generate Keys" operation in Store REST API

2017-06-20 Thread Bhathiya Jayasekara
Hi all, In the current implementation of store REST API, we have a single operation (aka. Generate Keys) to create OAuth application and generate access tokens, which requires 2 calls to key manager. IMO, if we split this operation into 2, the code becomes cleaner. On the other hand, the current

Re: [Dev] [APIM][C5] - Handling API's gateway label updates

2017-06-20 Thread Fazlan Nazeem
On Tue, Jun 20, 2017 at 11:39 AM, Thilini Shanika wrote: > Hi All, > > As per the APIM C5 architecture, the gateways can be registered in APIM > Core, specifying it's label and accessURLs. When creating/updating APIs, > the API can be moved to a gateway by assigning the label

Re: [Dev] WSO2 Committers += Madhawa Perera

2017-06-20 Thread Pasindu Jayaweera
Congratulations Madhawa...!! On Tue, Jun 20, 2017 at 11:38 AM, Milinda Wickramasinghe wrote: > Congratulations Madhawa...! > > On Tue, Jun 20, 2017 at 11:33 AM, Rasika Perera wrote: > >> Congratulations Madhawa !!! >> >> On Mon, Jun 19, 2017 at 4:45 PM,

Re: [Dev] Problem in authentication

2017-06-20 Thread Vinod Kavinda
Hi Lipsa, Your client is sending HTTP requests while the proxy service is configured to only accept HTTPS requests. Either enable http also with proxy header something like this, or send HTTPS requests from the client. Regards, Vinod On Mon, Jun 19, 2017 at 5:04 PM, Lipsa Pradhan <

Re: [Dev] Issue in Proxy service

2017-06-20 Thread Nuwan Wimalasekara
Hi Lipsa, In your service configuration, You have enabled only https transport as the transport of the service. You have to either enable to http transport for the service or send the https request instead of http request from the client. Thanks, Nuwanw On Tue, Jun 20, 2017 at 10:56 AM, Lipsa

Re: [Dev] WSO2 Committers += Madhawa Perera

2017-06-20 Thread Milinda Wickramasinghe
Congratulations Madhawa...! On Tue, Jun 20, 2017 at 11:33 AM, Rasika Perera wrote: > Congratulations Madhawa !!! > > On Mon, Jun 19, 2017 at 4:45 PM, Chathura Dilan > wrote: > >> Hi All, >> >> It's my pleasure to welcome Madhawa Perera as a WSO2 Committer.

[Dev] [APIM][C5] - Handling API's gateway label updates

2017-06-20 Thread Thilini Shanika
Hi All, As per the APIM C5 architecture, the gateways can be registered in APIM Core, specifying it's label and accessURLs. When creating/updating APIs, the API can be moved to a gateway by assigning the label of the gateway which registered under APIM Core. Once a label is assigned to an API,

Re: [Dev] WSO2 Committers += Madhawa Perera

2017-06-20 Thread Rasika Perera
Congratulations Madhawa !!! On Mon, Jun 19, 2017 at 4:45 PM, Chathura Dilan wrote: > Hi All, > > It's my pleasure to welcome Madhawa Perera as a WSO2 Committer. > > Madhawa has been a valuable contributor to the IoT team. In recognition > of his contribution, dedication, and