Re: PSA: new helper class for MozPromise in DOM code

2018-04-27 Thread Ben Kelly
On Fri, Apr 27, 2018, 3:13 AM Jean-Yves Avenard wrote: > > The class is called DOMMozPromiseRequestHolder. Here is an example using > > it: > > is that just a refcounted version of MozPromiseRequestHolder? > No. It binds to the global and calls DisconnectIfExists() when

PSA: new CopyableErrorResult class

2018-04-26 Thread Ben Kelly
around this you do this: DoFoo(const CopyableErrorResult& aRv) { ConsumeResult(CopyableErrorResult(aRv)); } This is often needed in MozPromise reaction handlers. Please let me know if you run into any problems. Thanks. Ben ___ dev-plat

PSA: new helper class for MozPromise in DOM code

2018-04-26 Thread Ben Kelly
rectly disconnects the Thenable during worker shutdown without any additional runnable dispatch. This is landing in: https://bugzilla.mozilla.org/show_bug.cgi?id=1457187 Please let me know if you run into any problems with it. Thanks. Ben ___ dev-pla

Re: testing event targets for memory leaks

2018-04-16 Thread Ben Kelly
PSA, I am landing additional leak tests for AudioContext IDB WebSocket As part of: https://bugzilla.mozilla.org/show_bug.cgi?id=1451913 On Thu, Apr 5, 2018 at 12:18 PM, Ben Kelly <bke...@mozilla.com> wrote: > Hi all, > > I recently landed some test infrastructure fo

Re: testing event targets for memory leaks

2018-04-09 Thread Ben Kelly
mber of objects) defined for > WebRTC as part of dom/media/PeerConnection.js > Having test coverage would be prudent, I think. I'm not sure what can break in the js event target world. Thanks. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: testing event targets for memory leaks

2018-04-09 Thread Ben Kelly
On Mon, Apr 9, 2018 at 12:32 PM, Ben Kelly <bke...@mozilla.com> wrote: > On Mon, Apr 9, 2018 at 12:06 PM, Boris Zbarsky <bzbar...@mit.edu> wrote: > >> On 4/5/18 1:11 PM, Ben Kelly wrote: >> >>> 1. Make sure you set the nsIGlobalObject owner by passing it to

Re: testing event targets for memory leaks

2018-04-09 Thread Ben Kelly
On Mon, Apr 9, 2018 at 12:06 PM, Boris Zbarsky <bzbar...@mit.edu> wrote: > On 4/5/18 1:11 PM, Ben Kelly wrote: > >> 1. Make sure you set the nsIGlobalObject owner by passing it to the DETH >> constructor or by calling BindToOwner(). >> > > Can we just enforce

Re: testing event targets for memory leaks

2018-04-09 Thread Ben Kelly
On Thu, Apr 5, 2018 at 12:18 PM, Ben Kelly <bke...@mozilla.com> wrote: > If one of these targets falls in your area, please try to find the time to > write a small test as described above. Also, please link it against the > meta bug here: > > https://bugzilla.mozilla.org/sh

testing event targets for memory leaks

2018-04-09 Thread Ben Kelly
a, please try to find the time to write a small test as described above. Also, please link it against the meta bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=1451787 Thanks! Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Phabricator and Bugzilla

2018-04-05 Thread Ben Kelly
lla.mozilla.org/show_bug.cgi?id=1440828). > What about comment mirroring? On my mobile so I haven't read all the past threads, but my recollection is that your team did not want to implement that feature. Personally, this is a huge concern for me. Thanks. Ben > As for interdiffs, feel

Re: CPU core count game!

2018-03-31 Thread Ben Kelly
That page says "physical cores", so its not taking into account hyper threading, right? So even a high end macbook pro falls in that category? On Tue, Mar 27, 2018 at 5:02 PM, Mike Conley wrote: > Thanks for drawing attention to this, sfink. > > This is likely to become

Re: PSA: nsIURI implementations are now threadsafe

2018-03-27 Thread Ben Kelly
ry threadsafe parsing first and only fall back to a main thread bounce if its an oddball URL. Right now we hardcode a bunch of http/https/nsStandardURL things in various places to accomplish this. > > > On 26 March 2018 at 15:24, Ben Kelly <bke...@mozilla.com> wrote: > >> Do

Re: PSA: nsIURI implementations are now threadsafe

2018-03-27 Thread Ben Kelly
This is so great. Thank you! One question that comes to mind, though, is there any chance this could be uplifted to 60? As we start doing more OMT nsIURI stuff its going to become difficult to uplift code to 60ESR. On Fri, Mar 23, 2018 at 8:25 AM, Valentin Gosu wrote:

Re: PSA: nsIURI implementations are now threadsafe

2018-03-27 Thread Ben Kelly
Do we have any plan to be able to use NS_NewURI() off-main-thread? I thought that was included here, but I see now that it is not. The initial URL parse OMT is important for truly being able to remove all our "bounce to the main thread for URL stuff" legacy code. On Fri, Mar 23, 2018 at 8:25

Re: FYI: Short Nightly Shield Study involving DNS over HTTPs (DoH)

2018-03-20 Thread Ben Kelly
Note, this effort is already being reported in the tech press based on this thread. For example: https://www.theregister.co.uk/AMP/2018/03/20/mozilla_firefox_test_of_privacy_mechanism_prompts_privacy_worries/ A blog post does sound like a good idea. On Mon, Mar 19, 2018, 11:33 PM Dave Townsend

Re: Intent to implement and ship: spec compliance Promise microtask behavior

2018-02-28 Thread Ben Kelly
I just want to give a huge thank you to everyone who worked on this. Its such a monumental task to change such a core feature, especially with new tests that might depend on the old behavior being added all the time. Thank you! Ben On Wed, Feb 28, 2018 at 6:58 AM, Hiroyuki Ikezoe <h

Re: PSA: C++ virtual function declarations should specify only one of virtual, final, or override

2018-02-16 Thread Ben Kelly
Are we supposed to just use override or final on methods that are overriden when the class itself is marked final? Personally writing final again seems redundant with the class level final and the override keyword seems more informative. On Fri, Feb 16, 2018 at 3:36 PM, Chris Peterson

PSA: service worker code has moved

2018-01-26 Thread Ben Kelly
intermittent bug title matching. Let me know if there are problems. Thanks. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to Unship: Application Cache over Insecure Contexts

2018-01-19 Thread Ben Kelly
On Fri, Jan 19, 2018 at 12:26 PM, Mike Taylor wrote: > > When the pref is set to false the API will be removed: > > > > - > > > > window.applicationCache will be removed > > - > > > > The cache service Firefox implements for AppCache will be disabled over > >

Re: Requiring secure contexts for new features

2018-01-16 Thread Ben Kelly
his should only be permitted going forward if it meets one of our exception criteria. Thanks. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Refactoring proposal for the observer service

2018-01-04 Thread Ben Kelly
On Thu, Jan 4, 2018 at 4:35 PM, Gabriele Svelto <gsve...@mozilla.com> wrote: > On 03/01/18 23:30, Ben Kelly wrote: > > Could we use our existing idl/webidl/ipdl for this? It would be nice > > not to have to maintain another code generator in the tree if possible. > &

Re: Refactoring proposal for the observer service

2018-01-04 Thread Ben Kelly
On Thu, Jan 4, 2018 at 10:00 AM, Nathan Froyd <nfr...@mozilla.com> wrote: > On Wed, Jan 3, 2018 at 5:30 PM, Ben Kelly <bke...@mozilla.com> wrote: > > On Wed, Jan 3, 2018 at 5:09 PM, Gabriele Svelto <gsve...@mozilla.com> > wrote: > >> So after validating m

Re: Refactoring proposal for the observer service

2018-01-03 Thread Ben Kelly
've picked YAML for > the list but it could be anything that fits the bill): > Could we use our existing idl/webidl/ipdl for this? It would be nice not to have to maintain another code generator in the tree if possible. Otherwise seems like a goo

overly strict eslint rules

2017-12-24 Thread Ben Kelly
that provide code safety value. Thanks. Have a great holiday. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Next year in web-platform-tests

2017-12-16 Thread Ben Kelly
I know you aware, but just mentioning for the list: We need WPT coverage on Android to fully rely on it as our primary test suite. Particularly while Android's config deviates so far from desktop. On Dec 15, 2017 10:40 AM, "James Graham" wrote: > Following the summary

Re: new code to help with cross-process windows/workers (and Clients API)

2017-12-09 Thread Ben Kelly
On Dec 9, 2017 8:25 AM, "Gijs Kruitbosch" <gijskruitbo...@gmail.com> wrote: On 08/12/2017 20:23, Ben Kelly wrote: > Please let me know if you have any question or if you think you have a > feature that could integrate with the clients infrastructure. While the &g

Re: new code to help with cross-process windows/workers (and Clients API)

2017-12-08 Thread Ben Kelly
Alright. I'll work on a blog post next week. (I'm not going to be in Austin for the work week.) Thanks. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

new code to help with cross-process windows/workers (and Clients API)

2017-12-08 Thread Ben Kelly
it to support other internal uses. I'd be very happy to help get new features added to support browser chrome or native code. Thanks! Ben P.S. I was also thinking of doing a blog post with diagrams of how it works if people think that would be useful.

Re: PSA: increased chance of new leaks due to delayed shutdown issue

2017-12-04 Thread Ben Kelly
Actually this was backed out from m-c for a single failing android test this morning. So please be aware we are at risk of introducing leaks again. On Sat, Dec 2, 2017 at 9:27 PM, Ben Kelly <bke...@mozilla.com> wrote: > Both fixes have stuck and are in the latest nightl

Re: PSA: increased chance of new leaks due to delayed shutdown issue

2017-12-02 Thread Ben Kelly
Both fixes have stuck and are in the latest nightly. Sorry for the headaches here. On Dec 1, 2017 1:15 PM, "Ben Kelly" <bke...@mozilla.com> wrote: > FYI, we have a fix identified for the late shutdown leak as well. I will > push them to inbound once the trees re-open. &g

Re: PSA: increased chance of new leaks due to delayed shutdown issue

2017-12-01 Thread Ben Kelly
FYI, we have a fix identified for the late shutdown leak as well. I will push them to inbound once the trees re-open. On Thu, Nov 30, 2017 at 11:18 PM, Ben Kelly <bke...@mozilla.com> wrote: > Hi all, > > I just wanted to send a note about a bug in nightly which is leading to >

PSA: increased chance of new leaks due to delayed shutdown issue

2017-11-30 Thread Ben Kelly
. If you are touching anything that might live until shutdown, please include the patches from bug 1420594 to avoid the delayed shutdown issue. I'll send another mail once the fix lands and sticks. Thanks for your help. Sorry for the trouble. Ben ___ dev

service workers at risk for FF59 ESR

2017-11-17 Thread Ben Kelly
given the holiday/all-hands cycle. Realistically we should plan on service workers being disabled in FF59 ESR. Please let me know if you have any questions or concerns. Thanks. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https

Re: mozilla-central now compiles with C++14

2017-11-16 Thread Ben Kelly
; nsCOMPtr r = NS_NewRunnableFunction([uniqueThing = Move(uniqueThing)] () { uniqueThing->Stuff(); }); thread->Dispatch(r.forget()); Thanks. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to ship: Retained Display Lists

2017-11-01 Thread Ben Kelly
On Tue, Oct 31, 2017 at 11:44 PM, Ben Kelly <bke...@mozilla.com> wrote: > Anecdotely this pref seems to make twitter much less janky on fennec on my > Nexus 5x. > Actually, at least some retained display list code is disabled in non-e10s because of a process type check. I

Re: Intent to ship: Retained Display Lists

2017-10-31 Thread Ben Kelly
htly, and looks to be working really well. We'd really appreciate some early feedback, so feel free to set layout.display-list.retain=true and give it a try! Anecdotely this pref seems to make twitter much less janky on fennec on my Nexus 5x. What's the plan for enabling by default

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Ben Kelly
Would it be possible to have our profiling tools warn if about:compiler optimization flags are not in about:buildconfig? On Tue, Oct 31, 2017 at 3:39 PM, Jeff Muizelaar wrote: > On Tue, Oct 31, 2017 at 3:21 PM, Gregory Szorc wrote: > > On Tue, Oct 31,

Intent to implement and ship PerformanceResourceTiming.workerStart

2017-10-05 Thread Ben Kelly
/resource-timing.https.html Please let me know if there are questions or concerns. Thanks. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Containers graduation from Test Pilot - we still care about 57+

2017-09-27 Thread Ben Kelly
It disables multi-e10s. Forced to one content process. On Sep 27, 2017 12:58 PM, "Andrew McKay" <amc...@mozilla.com> wrote: Sorry, it disables e10s even though it has true in the install.rdf? That shouldn't be the case. On 27 September 2017 at 07:14, Ben Kelly <bke...

Re: Containers graduation from Test Pilot - we still care about 57+

2017-09-27 Thread Ben Kelly
On Mon, Sep 25, 2017 at 9:28 AM, Ben Kelly <bke...@mozilla.com> wrote: > Thanks Jonathan. > > Also, it seems the link to the web extension version of the container > addon is broken above. This one works for me: > > https://github.com/mozilla/multi-account-containers/rel

Re: Containers graduation from Test Pilot - we still care about 57+

2017-09-25 Thread Ben Kelly
Thanks Jonathan. Also, it seems the link to the web extension version of the container addon is broken above. This one works for me: https://github.com/mozilla/multi-account-containers/releases/latest On Sat, Sep 23, 2017 at 9:52 AM, Jonathan Kingston wrote: > Hi All, > >

Re: TabChild visibility

2017-09-20 Thread Ben Kelly
FWIW, our nsIDocument::VisibilityState() is updated when the docshell goes active: http://searchfox.org/mozilla-central/source/dom/base/nsIDocument.h#2855 http://searchfox.org/mozilla-central/source/dom/base/nsDocument.cpp#12504

PSA: nsPipe3.cpp is now using diagnostic assertions

2017-09-13 Thread Ben Kelly
of the increased nightly/dev-edition crashes. The diagnostic assertions were pushed in: https://bugzilla.mozilla.org/show_bug.cgi?id=1398942 Please let me know if you have any questions or concerns. Thanks. Ben ___ dev-platform mailing list dev-platform

Re: Re-visiting the DOM tree depth limit in layout

2017-09-13 Thread Ben Kelly
ep > display: table-cell doesn't overflow the stack. > Is it possible to have automated tests to verify these tunings remain valid as the tree is changed over time? Or maybe we already have those? Thanks. Ben ___ dev-platform mailing list dev-platform

Re: indexedDB.open failing silently?

2017-09-12 Thread Ben Kelly
Can you have the user try in a fresh profile? I think this behavior might occur if they used a profile in a newer version of firefox (like nightly 57) and then try to take it back to an older version (like release 55). Database schemas can be updated in various storage APIs on disk which prevent

Re: disabled non-e10s tests on trunk

2017-09-08 Thread Ben Kelly
want to use windows because it builds/runs much slower than linux. Thanks. Ben On Fri, Aug 18, 2017 at 4:15 PM, <jma...@mozilla.com> wrote: > Yesterday I landed bug 1391371 which enabled non-e10s unittests on windows > 7 debug. A few tests had to be disabled in order to do this.

Re: Re: Firefox and clang-cl

2017-09-07 Thread Ben Kelly
On Thu, Sep 7, 2017 at 10:09 AM, Nathan Froyd <nfr...@mozilla.com> wrote: > On Thu, Sep 7, 2017 at 10:04 AM, Ben Kelly <bke...@mozilla.com> wrote: > > On Mon, Aug 14, 2017 at 10:44 AM, Tristan Bourvon <tbour...@mozilla.com> > > wrote: > > > >> He

Re: Re: Firefox and clang-cl

2017-09-07 Thread Ben Kelly
estigate these overflow builtins? Should we file one? Even if we can't use them on all platforms yet, it might be a nice win on mac where we lack other optimizations like PGO right now. Thanks. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to ship: Abort API

2017-09-06 Thread Ben Kelly
nbound. Thanks for implementing this Andrea! Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Quantum Flow Engineering Newsletter #22

2017-09-01 Thread Ben Kelly
On Fri, Sep 1, 2017 at 10:06 AM, Ben Kelly <bke...@mozilla.com> wrote: > On Fri, Sep 1, 2017 at 1:59 AM, Ehsan Akhgari <ehsan.akhg...@gmail.com> > wrote: > >>- Mike Conley made it so that background tabs are “warmed up” when >>hovering the mo

Re: Quantum Flow Engineering Newsletter #22

2017-09-01 Thread Ben Kelly
On Fri, Sep 1, 2017 at 1:59 AM, Ehsan Akhgari wrote: >- Mike Conley made it so that background tabs are “warmed up” when >hovering the mouse cursor over them >. This should >improve tab switching

Re: Intent to ship: Abort API

2017-08-29 Thread Ben Kelly
On Tue, Aug 29, 2017 at 9:39 AM, Ben Kelly <bke...@mozilla.com> wrote: > On Tue, Aug 29, 2017 at 2:05 AM, Andrea Marchesini < > amarches...@mozilla.com> wrote: > >> Abort API is already part of the DOM spec and I would like to enable it by >> d

Re: Intent to ship: Abort API

2017-08-29 Thread Ben Kelly
On Tue, Aug 29, 2017 at 2:05 AM, Andrea Marchesini wrote: > Abort API is already part of the DOM spec and I would like to enable it by > default everywhere in our codebase (dom.abortController.enabled). Abort + > Fetch integration is not part of the spec yet. There is a

Re: New string types: nsAutoStringN<> and nsAutoCStringN<>

2017-08-21 Thread Ben Kelly
On Mon, Aug 21, 2017 at 10:00 AM, Ben Kelly <bke...@mozilla.com> wrote: > Should that be `mStorage[N + 1]`? > Maybe not since things like NSID_LENGTH include the null pointer on their end. Sorry for my confusion. ___ dev-platform mail

Re: New string types: nsAutoStringN<> and nsAutoCStringN<>

2017-08-21 Thread Ben Kelly
s\n", someValue.get()); Does nAutoCStringN also store its value null-terminated? Is that null somehow accounted for in the storage? I don't see where that is done: http://searchfox.org/mozilla-central/source/xpcom/string/nsTString.h#664 Should that be `mStorage[N + 1]`? Thanks. Ben _

Re: disabled non-e10s tests on trunk

2017-08-16 Thread Ben Kelly
android is a variant of linux. Running a linux platform might be closer to android behavior. But I don't have a known specific difference in mind. It would also be nice to opt and debug since things do differ between them, but I'll take what I can get. Thanks. Ben _

Re: disabled non-e10s tests on trunk

2017-08-15 Thread Ben Kelly
On Tue, Aug 15, 2017 at 4:43 PM, Joel Maher wrote: > This is a discussion about tests in e10s mode, not WPT on Android. > Yes. And android is our last tier 1 platform that requires non-e10s. I think that makes it relevant to the discussion. > > What specific coverage are

Re: disabled non-e10s tests on trunk

2017-08-15 Thread Ben Kelly
On Tue, Aug 15, 2017 at 4:37 PM, Joel Maher wrote: > All of the above mentioned tests are not run on Android (well > mochitest-media is to some degree). Is 4 months unreasonable to fix the > related tests that do not run in e10s? Is there another time frame that > seems

Re: disabled non-e10s tests on trunk

2017-08-15 Thread Ben Kelly
On Tue, Aug 15, 2017 at 4:29 PM, wrote: > While there are many tests which individually are disabled or lacking > coverage, these test suites have no non-e10s coverage: > * web-platform-tests > * browser-chrome > * devtools > * jsreftests > * mochitest-webgl, mochitest-gpu,

Re: 64-bit Firefox progress report: 2017-07-18

2017-08-14 Thread Ben Kelly
sorry to be pedantic, but misleading charts are kind of a pet peeve. Thanks. Ben On Wed, Jul 19, 2017 at 2:38 AM, Chris Peterson <cpeter...@mozilla.com> wrote: > We are on track to make 64-bit Firefox the default build for Win64 OS, > bringing improved ASLR and fewer OOM crashes to the 70% of

Re: Linking with lld instead of ld/gold

2017-08-14 Thread Ben Kelly
y gcc since version 6). Clang will > look for the same version of LLD available on the system. > The clang installed by ./mach bootstrap in .mozbuild is 3.9.0. Is there any plan to update that to >= 4.0? Thanks. Ben ___ dev-plat

Re: Response.body streams landing on trunk, default off

2017-08-14 Thread Ben Kelly
FYI, the Fetch API side of streams has landed and is now in nightly. Please test and file bugs. Thanks! Ben On Thu, Aug 10, 2017 at 11:29 PM, Ben Kelly <bke...@mozilla.com> wrote: > Hi all, > > As some of you may know :till and :baku have been working hard to > implement Read

Re: Firefox and clang-cl

2017-08-14 Thread Ben Kelly
due to this same set of code or not. The bisects were run from this issue: https://bugs.chromium.org/p/chromium/issues/detail?id=750672#c12 Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Response.body streams landing on trunk, default off

2017-08-10 Thread Ben Kelly
not found any functional problems. Many thanks to Till and Andrea for their hard work on streams! Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: disabled non-e10s tests on trunk

2017-08-10 Thread Ben Kelly
On Tue, Aug 8, 2017 at 5:18 PM, Ben Kelly <bke...@mozilla.com> wrote: > On Tue, Aug 8, 2017 at 5:12 PM, <jma...@mozilla.com> wrote: > >> In bug 1386689, we have turned them off. There was some surprise in >> doing this and some valid concerns expressed in comments

Re: disabled non-e10s tests on trunk

2017-08-08 Thread Ben Kelly
On Tue, Aug 8, 2017 at 5:18 PM, Ben Kelly <bke...@mozilla.com> wrote: > On Tue, Aug 8, 2017 at 5:12 PM, <jma...@mozilla.com> wrote: > >> While we get some advantages to not running duplicated tests (faster try >> results, less backlogs, fewer intermittent failures

Re: disabled non-e10s tests on trunk

2017-08-08 Thread Ben Kelly
ontinuing to run the test in non-e10s on desktop linux. Having more real devices to run android tests on would probably reduce the number of tests that are disabled. The emulator is extremely slow and not representative of real hardware. Ben ___ dev-plat

Re: sccache as ccache

2017-08-02 Thread Ben Kelly
On Wed, Aug 2, 2017 at 12:26 PM, Ben Kelly <bke...@mozilla.com> wrote: > On Wed, Jul 26, 2017 at 9:05 AM, Ted Mielczarek <t...@mielczarek.org> > wrote: > >> Yesterday I published sccache 0.2 to crates.io, so you can now `cargo >> install sccache` and get

Re: sccache as ccache

2017-08-02 Thread Ben Kelly
On Wed, Jul 26, 2017 at 9:05 AM, Ted Mielczarek wrote: > Yesterday I published sccache 0.2 to crates.io, so you can now `cargo > install sccache` and get the latest version (it'll install to > ~/.cargo/bin). > I tried this on my linux build machine today and got: error:

Re: Intent to remove: sensor APIs

2017-07-24 Thread Ben Kelly
On Mon, Jul 24, 2017 at 5:10 AM, Anne van Kesteren wrote: > * Device orientation > Isn't this one required to build a decent web experience on mobile for some sites? It seems pretty common on mobile to adjust the UX based on whether the device is in portrait/landscape

Re: Keyboard APZ has landed on Inbound

2017-07-23 Thread Ben Kelly
On Sat, Jul 22, 2017 at 2:05 AM, Ryan Hunt wrote: > Keyboard APZ can't be used in every case. Currently it's disabled in the > presense of key event listeners, as they can preventDefault scrolling and > that > is a non-negotiable part of the web. > Do we do keyboard APZ if the

Re: 64-bit Firefox progress report: 2017-07-18

2017-07-19 Thread Ben Kelly
On Jul 19, 2017 8:57 PM, "Mike Hommey" <m...@glandium.org> wrote: On Wed, Jul 19, 2017 at 08:48:45PM -0400, Ben Kelly wrote: > On Jul 19, 2017 6:20 PM, "Mike Hommey" <m...@glandium.org> wrote: > > > What would be the rationale behind this choice? >

Re: 64-bit Firefox progress report: 2017-07-18

2017-07-19 Thread Ben Kelly
M (small) due to VM fragmentation still outweighed OOM (large) on these machines. If that is the case 64-bit is strictly better. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Phabricator Update, July 2017

2017-07-17 Thread Ben Kelly
On Mon, Jul 17, 2017 at 12:27 PM, Gregory Szorc wrote: > If the bug is only serving as an anchor to track code review, then the > question we should be asking is "do we even need a bug." > In my experience the answer to this is "yes, we need a bug". I very rarely have a

Re: Phabricator Update, July 2017

2017-07-14 Thread Ben Kelly
On Jul 14, 2017 6:27 PM, "Mike Hommey" <m...@glandium.org> wrote: On Fri, Jul 14, 2017 at 01:00:51PM -0400, Ben Kelly wrote: > I know feedback was collected, but maybe not from this group. Feedback was collected from a selected set of the people who do the most reviews. I'm o

Re: Phabricator Update, July 2017

2017-07-14 Thread Ben Kelly
. Ben On Jul 14, 2017 11:34 AM, "Milan Sreckovic" <msrecko...@mozilla.com> wrote: > Replying in general, to a random message :) > > I don't have the numbers, but I imagine reviews are happening in the > hundreds every day (if we land almost 300 patches.) So, I wouldn

Re: Phabricator Update, July 2017

2017-07-12 Thread Ben Kelly
aybe phabricator will be great, but I'll believe it when I see it. Please don't force future data and workflow into an as-yet unproven tool. Thanks. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Phabricator Update, July 2017

2017-07-12 Thread Ben Kelly
On Tue, Jul 11, 2017 at 11:49 PM, Martin Thomson wrote: > On Wed, Jul 12, 2017 at 1:34 PM, Byron Jones wrote: > > instead of disabling splinter for phabricator backed products, we could > make > > it a read-only patch viewer. > > Given the number of bugs that

Re: W3C Charter Advance Notice: Web Platform (recharter) & Service Workers WGs

2017-07-11 Thread Ben Kelly
We have implementation close to review for one-shot sync. I don't know of any browser that has implemented and shipped periodic sync yet. On Tue, Jul 11, 2017 at 2:49 PM, L. David Baron wrote: > On Tuesday 2017-07-11 11:38 -0700, L. David Baron wrote: > > On Wednesday

Re: More Rust code

2017-07-11 Thread Ben Kelly
ackground parent actors already cannot interface with xpcom since they are OMT and would be a good candidate here. Anyway, I think fixing these kinds of integration pain points would accelerate our ability to use rust in gecko. I would hesitate to make any kind of mandates until these issues are addressed. Thanks. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Switching to per-channel profiles

2017-06-26 Thread Ben Hearsum
we're enabling similar logic across all channels, we should probably fix this or get rid of the button (since it will serve no function AFAICT). - Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Shipping Headless Firefox on Linux

2017-06-15 Thread Ben Kelly
On Thu, Jun 15, 2017 at 4:37 PM, Nathan Froyd wrote: > On Thu, Jun 15, 2017 at 2:02 PM, Brendan Dahl wrote: > > Headless will run less of the platform specific widget code and I don't > > recommend using it for platform specific testing. It is targeted

Re: Shipping Headless Firefox on Linux

2017-06-15 Thread Ben Kelly
I typically use xvfb-run when executing tests locally. How does headless mode differ? Does it just run faster, but at the cost not testing some widget code? On Wed, Jun 14, 2017 at 7:51 PM, Brendan Dahl wrote: > Hello All, > > > As of Firefox 55 I intend to ship headless

Re: JSBC: JavaScript Start-up Bytecode Cache

2017-06-13 Thread Ben Kelly
lowing along at home: 1. We don't support this when loading worker scripts yet. 2. If a page script load is intercepted by a service worker then this optimization is effectively disabled. There are a number of follow-up bugs filed to fix those things, but its a non-trivial amount of work. Ben

Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread Ben Kelly
On Tue, Jun 6, 2017 at 3:07 PM, Chris Peterson wrote: > On 6/6/17 10:33 AM, Boris Zbarsky wrote: > >> On 6/1/17 9:04 PM, Mike Hommey wrote: >> >>> Ah, forgot to mention that. No, it doesn't affect *our* shipped builds >>> (because PGO uses a different set of optimization

Re: more setTimeout() changes incoming

2017-05-30 Thread Ben Kelly
precision should be approximately the same as behavior. The main benefit of this landing will be reduced allocation and locking overhead when setTimeout()/setInterval() is used. On Thu, May 25, 2017 at 11:00 AM, Ben Kelly <bke...@mozilla.com> wrote: > Hi all, > > I want to give ever

more setTimeout() changes incoming

2017-05-25 Thread Ben Kelly
, feel free to NI me to help investigate. Again, I've worked hard to squash the intermittents I've seen in try, so I don't believe there will be any super frequent failures from this bug. (Or I wouldn't be landing, etc...) Please let me know if there are any questions or concerns. Thanks! Ben

Re: Intent to ship: NetworkInformation

2017-05-19 Thread Ben Kelly
: https://wicg.github.io/netinfo/#privacy-considerations Thanks. Ben On Fri, Dec 23, 2016 at 10:43 AM, Eric Rescorla <e...@rtfm.com> wrote: > On Thu, Dec 22, 2016 at 10:31 PM, <mcace...@mozilla.com> wrote: > > > On Wednesday, December 21, 2016 at 12:51:10 AM UTC+11, Eric Res

Re: Avoiding jank in async functions/promises?

2017-05-17 Thread Ben Kelly
On Wed, May 17, 2017 at 10:19 PM, Ben Kelly <bke...@mozilla.com> wrote: > FWIW, we have a similar problem in the native TimeoutManager::RunTImeout() > method. I'm using a time budget approach to make it adapt to different > hardware better. > I meant to include the bug n

Re: Avoiding jank in async functions/promises?

2017-05-17 Thread Ben Kelly
On Wed, May 17, 2017 at 10:03 PM, Boris Zbarsky wrote: > On 5/17/17 9:22 PM, Mark Hammond wrote: > >> I'm wondering if there are any ideas about how to solve this optimally? >> > > I assume https://w3c.github.io/requestidlecallback/#the-requestidleca > llback-method doesn't

Re: Ambient Light Sensor API

2017-04-24 Thread Ben Kelly
The post suggests that limiting precision would mitigate the issue. We could do that immediately while we wait for telemetry to roll in. The post says reducing the frequency of the readings would not be very effective, but maybe we should reduce the frequency anyway? Possibly firing an event

Re: A reminder about commit messages: they should be useful

2017-04-17 Thread Ben Kelly
Just my two cents. (I wasn't going to chime in here, but felt compelled since Olli's view was being cast as rare.) Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Better download security through browsers

2017-03-24 Thread Ben Kelly
We now have SRI and support integrity attributes on elements like

Re: e10s-multi update and tests

2017-03-22 Thread Ben Kelly
ybe you are asking which processes count against the limit of 4. > FWIW, the intention is that the worker process would not count against the limit. It would not contain any windows and would be significantly smaller in size. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: unowned module: Firefox::New Tab Page, help me find an owner

2017-03-22 Thread Ben Kelly
On Wed, Mar 22, 2017 at 10:00 AM, David Burns <dbu...@mozilla.com> wrote: > On 22 March 2017 at 13:49, Ben Kelly <bke...@mozilla.com> wrote: > >> Finding someone to own the feature and investigate intermittents is >> important too, but that doesn't mean the tests hav

Re: unowned module: Firefox::New Tab Page, help me find an owner

2017-03-22 Thread Ben Kelly
On Wed, Mar 22, 2017 at 9:39 AM, <jma...@mozilla.com> wrote: > On Wednesday, March 22, 2017 at 9:35:35 AM UTC-4, Ben Kelly wrote: > > You plan to delete all the tests? This seems somewhat extreme for a > > shipped feature. Why not disable just the tests that are inte

Re: unowned module: Firefox::New Tab Page, help me find an owner

2017-03-22 Thread Ben Kelly
On Wed, Mar 22, 2017 at 9:22 AM, wrote: > I have not been able to find an owner for the Firefox::New Tab Page > bugzilla component (bug 1346908). There are 35 tests in the tree and > without anyone to assume responsibility for them when they are intermittent > (bug 1338848),

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ben Kelly
seems to be serialized with building other libraries. Ben ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ben Kelly
On Fri, Mar 17, 2017 at 2:52 PM, Ben Kelly <bke...@mozilla.com> wrote: > On Fri, Mar 17, 2017 at 2:43 PM, Ted Mielczarek <t...@mielczarek.org> > wrote: > > Yeah, I specifically meant "CPU-bound during the compile tier", where we >> compile all the C++

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Ben Kelly
On Fri, Mar 17, 2017 at 2:43 PM, Ted Mielczarek wrote: > > The 14min measurement must have been for a partial build. With defender > > disabled the best I can get is 18min. This is on one of the new lenovo > > p710 machines with 16 xeon cores. > > Nope, full clobber

  1   2   3   >