Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-25 Thread Andreas Pehrson
I think the gonk parts always use the provided AOSP toolchain for building, while gecko uses the compiler provided by the system when building for the host. In any case I had a keon (ICS) build fail to compile libmar with gcc 4.6 due to the new requirement. Using gcc 4.8 on the system instead work

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-25 Thread Mike Hommey
On Wed, Mar 11, 2015 at 02:56:27PM -0700, Juan Gómez wrote: > AFAIK, in B2G we are tied to the same host compiler version that our > Android base platform needs. This is gcc-4.6 for ICS and JB devices > (not really sure if KK/LL works with newer ones, but I'll bet they > do). I overlooked this whe

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-20 Thread bowen
I have now updated the two MDN pages (that I know of) to reflect that gcc-4.7 or later is now required. This has made the

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-19 Thread bobowencode
I've just landed patches to change our minimum supported target GCC version to 4.7. This does not affect the host compiler as mentioned earlier in this thread. That check is being added in bug 1142352. Once the blocking issue there has been sorted, it looks like the minimum version for the host

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-12 Thread Ehsan Akhgari
On 2015-03-11 8:34 AM, bo...@mozilla.com wrote: Given that we (and probably Chromium) would be unlikely to drop MSVC 2013 before our next ESR anyway That is not true. The compiler that we use to build ESR has nothing to do with the minimum compiler requirements on mozilla-central. It's of

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-12 Thread bowen
On Tuesday, March 10, 2015 at 2:38:43 PM UTC, Ehsan Akhgari wrote: > Have you tested bumping the gcc min version here > > > to see if there are any builders that still use gcc 4.6? I haven't, no. I assume you mean b

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Ehsan Akhgari
On 2015-03-11 8:19 PM, Gregory Szorc wrote: On Wed, Mar 11, 2015 at 11:50 AM, Joshua Cranmer 🐧 wrote: On 3/11/2015 1:13 PM, Gregory Szorc wrote: So I guess we trend towards supporting 2 build modes: Mozilla's official build environment via containers/chroots (preferred) or "host native" (for

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Ehsan Akhgari
On 2015-03-11 8:36 PM, Gregory Szorc wrote: On Wed, Mar 11, 2015 at 2:30 PM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: On 2015-03-11 2:13 PM, Gregory Szorc wrote: On Wed, Mar 11, 2015 at 10:21 AM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Ehsan Akhgari
On 2015-03-11 6:05 PM, Chris Peterson wrote: On 3/11/15 2:56 PM, Juan Gómez wrote: AFAIK, in B2G we are tied to the same host compiler version that our Android base platform needs. This is gcc-4.6 for ICS and JB devices (not really sure if KK/LL works with newer ones, but I'll bet they do). Of c

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Gregory Szorc
On Wed, Mar 11, 2015 at 2:30 PM, Ehsan Akhgari wrote: > On 2015-03-11 2:13 PM, Gregory Szorc wrote: > >> On Wed, Mar 11, 2015 at 10:21 AM, Ehsan Akhgari > > wrote: >> >> On 2015-03-11 7:35 AM, Brian Smith wrote: >> >> Mike Hommey mailto:m...@glandium.or

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Gregory Szorc
On Wed, Mar 11, 2015 at 12:57 PM, Nicolas B. Pierron < nicolas.b.pier...@mozilla.com> wrote: > On 03/11/2015 07:13 PM, Gregory Szorc wrote: > >> This build environment would be defined inside >> mozilla-central in such a way that it is reproducible over time. e.g. >> update your source repo to a c

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Gregory Szorc
On Wed, Mar 11, 2015 at 11:50 AM, Joshua Cranmer 🐧 wrote: > On 3/11/2015 1:13 PM, Gregory Szorc wrote: > >> So I guess we trend towards supporting 2 build modes: Mozilla's official >> build environment via containers/chroots (preferred) or "host native" (for >> the people who insist on using it).

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Chris Peterson
On 3/11/15 2:56 PM, Juan Gómez wrote: AFAIK, in B2G we are tied to the same host compiler version that our Android base platform needs. This is gcc-4.6 for ICS and JB devices (not really sure if KK/LL works with newer ones, but I'll bet they do). Of course, we could fix any incompatibilty and c

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Juan Gómez
On Wednesday, March 11, 2015 at 9:10:43 PM UTC+1, bobow...@gmail.com wrote: > On Wednesday, 11 March 2015 10:54:59 UTC, bo...@mozilla.com wrote: > > On Tuesday, March 10, 2015 at 5:06:31 PM UTC, Ehsan Akhgari wrote: > > > > > >> Here's a push in case the bugs don't exist in certain builds: > > >

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Ehsan Akhgari
On 2015-03-11 2:13 PM, Gregory Szorc wrote: On Wed, Mar 11, 2015 at 10:21 AM, Ehsan Akhgari mailto:ehsan.akhg...@gmail.com>> wrote: On 2015-03-11 7:35 AM, Brian Smith wrote: Mike Hommey mailto:m...@glandium.org>> wrote: Brian Smith wrote: It is very inc

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread bobowencode
On Wednesday, 11 March 2015 10:54:59 UTC, bo...@mozilla.com wrote: > On Tuesday, March 10, 2015 at 5:06:31 PM UTC, Ehsan Akhgari wrote: > > > >> Here's a push in case the bugs don't exist in certain builds: > > >> https://treeherder.mozilla.org/#/jobs?repo=try&revision=044e896fc6fa > > > > > > I

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Nicolas B. Pierron
On 03/11/2015 07:13 PM, Gregory Szorc wrote: This build environment would be defined inside mozilla-central in such a way that it is reproducible over time. e.g. update your source repo to a commit from March 2015 and you automatically get the build environment that was used in March 2015. Anoth

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Joshua Cranmer 🐧
On 3/11/2015 1:13 PM, Gregory Szorc wrote: So I guess we trend towards supporting 2 build modes: Mozilla's official build environment via containers/chroots (preferred) or "host native" (for the people who insist on using it). Only "host native" exists today and it is a PITA. Using docker conta

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Gregory Szorc
On Wed, Mar 11, 2015 at 10:21 AM, Ehsan Akhgari wrote: On 2015-03-11 7:35 AM, Brian Smith wrote: > >> Mike Hommey wrote: >> >>> Brian Smith wrote: >>> It is very inconvenient to have a minimum supported compiler version that we cannot even do test builds with using tryserver. >>>

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread bowen
On Wednesday, March 11, 2015 at 5:14:39 PM UTC, Ehsan Akhgari wrote: > On 2015-03-11 8:34 AM, bo...@mozilla.com wrote: > > Given that we (and probably Chromium) would be unlikely to drop MSVC 2013 > > before our next ESR anyway > > That is not true. The compiler that we use to build ESR has noth

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Ehsan Akhgari
On 2015-03-11 7:35 AM, Brian Smith wrote: Mike Hommey wrote: Brian Smith wrote: It is very inconvenient to have a minimum supported compiler version that we cannot even do test builds with using tryserver. Why this sudden requirement when our *current* minimum "supported" version is 4.6 and

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread bowen
On Wednesday, March 11, 2015 at 11:53:11 AM UTC, Brian Smith wrote: > wrote: > > Also, from what I can tell of the C++ features that gcc-4.8 enables (from > > [1]), none of them are available until MSVC 2015. > > It seems likely that we'll be supporting MSVC 2013 until the next ESR, so I > > don

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Brian Smith
wrote: > Also, from what I can tell of the C++ features that gcc-4.8 enables (from > [1]), none of them are available until MSVC 2015. > It seems likely that we'll be supporting MSVC 2013 until the next ESR, so I > don't see that moving to 4.8 gives us any immediate benefits. > > [1] https://dev

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Brian Smith
Ryan VanderMeulen wrote: >> (2) The trychooser tool should be extended to make it possible to >> build with GCC 4.7 on any platforms where it is supported, and >> bootstrap.py be updated to install GCC 4.7 alongside the >> currently-installed compiler. > > All Android and B2G JB/KK emulator builds

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread bowen
On Wednesday, March 11, 2015 at 8:40:46 AM UTC, Mike Hommey wrote: > On Tue, Mar 10, 2015 at 07:23:36PM -0700, Brian Smith wrote: > > wrote: > > > In summary: Officially make gcc-4.7 our minimum supported version. Fx38 > > > and 39 don't compile with 4.6 and none of the GNU/Linux package > > > m

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Brian Smith
Mike Hommey wrote: > Brian Smith wrote: >> It is very inconvenient to have a minimum supported compiler version >> that we cannot even do test builds with using tryserver. > > Why this sudden requirement when our *current* minimum "supported" > version is 4.6 and 4.6 is nowhere close to that on tr

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread bowen
On Tuesday, March 10, 2015 at 5:06:31 PM UTC, Ehsan Akhgari wrote: > >> Here's a push in case the bugs don't exist in certain builds: > >> https://treeherder.mozilla.org/#/jobs?repo=try&revision=044e896fc6fa > > > > I was looking at the log for a B2G Device Image build (I think it > > was the one

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-11 Thread Mike Hommey
On Tue, Mar 10, 2015 at 07:23:36PM -0700, Brian Smith wrote: > wrote: > > In summary: Officially make gcc-4.7 our minimum supported version. Fx38 and > > 39 don't compile with 4.6 and none of the GNU/Linux package maintainers I > > have contacted have any major concerns over dropping it. > > I

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-10 Thread Ryan VanderMeulen
On 3/10/2015 10:23 PM, Brian Smith wrote: (2) The trychooser tool should be extended to make it possible to build with GCC 4.7 on any platforms where it is supported, and bootstrap.py be updated to install GCC 4.7 alongside the currently-installed compiler. All Android and B2G JB/KK emulator bu

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-10 Thread Brian Smith
wrote: > In summary: Officially make gcc-4.7 our minimum supported version. Fx38 and > 39 don't compile with 4.6 and none of the GNU/Linux package maintainers I > have contacted have any major concerns over dropping it. I propose that either: (1) GCC 4.8 be made the minimum supported version i

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-10 Thread Ehsan Akhgari
On 2015-03-10 12:50 PM, L. David Baron wrote: On Tuesday 2015-03-10 08:49 -0700, bo...@mozilla.com wrote: On Tuesday, March 10, 2015 at 2:38:43 PM UTC, Ehsan Akhgari wrote: Have you tested bumping the gcc min version here

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-10 Thread L. David Baron
On Tuesday 2015-03-10 08:49 -0700, bo...@mozilla.com wrote: > On Tuesday, March 10, 2015 at 2:38:43 PM UTC, Ehsan Akhgari wrote: > > Have you tested bumping the gcc min version here > > > > > > to see if there are an

Re: Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-10 Thread Ehsan Akhgari
Have you tested bumping the gcc min version here to see if there are any builders that still use gcc 4.6? On 2015-03-10 6:24 AM, bo...@mozilla.com wrote: Hi, In summary: Officially make gcc-4.7 our minimum support

Intent to not fix: Building with gcc-4.6 for Fx38+

2015-03-10 Thread bowen
Hi, In summary: Officially make gcc-4.7 our minimum supported version. Fx38 and 39 don't compile with 4.6 and none of the GNU/Linux package maintainers I have contacted have any major concerns over dropping it. There are three outstanding bugs open over Fx38+ not compiling with gcc-4.6. One of