> -Original Message-
> From: Jeff Brasen
> Sent: Friday, June 30, 2023 11:21 AM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Wu, Hao A
> Subject: RE: [PATCH] MdeModulePkg/PciHostBridge: Add support for driver
> binding
>
> Not sure why the patch failed to
[AMD Official Use Only - General]
> -Original Message-
> From: Aaron Pop
> Sent: Friday, June 30, 2023 4:17 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; michael.d.kin...@intel.com
> Subject: Subject: [PATCH] Modify IPMI_GET_SYSTEM_UUID_RESPONSE to use
> IPMI_GUID.
>
> Caution: This
[AMD Official Use Only - General]
Yes, edk2 Redfish does support BMC exposed USB NIC, as RedfishPkg relies on
RestEx protocol for discovering Redfish service. The current RestEx
implementation is network based, which means USB NIC would be used as the
transport interface for Redfish
Not sure why the patch failed to apply I'll see if there is something wrong
with my gitconfig tomorrow. The path you suggested below is exactly what our
current implementation does. However, I am trying to make our pcie controller
driver do async initialization so that using a depex is less
Hi,
The communication between BIOS and BMC usually is IPMI over LPC interface.
The communication also supports with IPMI over IP.
BMC chip has ability to emulate itself as a usb network card, and connected
with motherboard's usb physical port.
So, current redfishpkg supports BMC chip's lan over
From: Michael Kubacki
During a review of this driver a number of improvements were noted
such as strengthening function input validation, checking return
values, making debug print error levels consistent in certain code
blocks, etc.
These type of changes are made with no explicit change to
I failed to apply the patch in my local tree.
It seems you invented a new EdkiiRootBridgeIo protocol and a certain
proprietary driver would produce this protocol instance.
Then the open source PciHostBridge driver starts on that.
Then, why not implement your own PciHostBridgeLib and let it
[AMD Official Use Only - General]
Hi Mike,
I see there are CI errors for this PR, could you please check it? Thanks!
Abner
> -Original Message-
> From: Mike Maslenkin
> Sent: Friday, June 30, 2023 6:44 AM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; nick...@nvidia.com; ig...@ami.com
Sean and Joey:
Thanks for your detail information. Now, I understand the rule that require
explicit opt-in for all the stuart based validation tools. I have no more
comments for this patch set.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Sean
> 发送时间: 2023年6月30日 2:01
> 收件人:
Jeff:
Performance has been stored as FPDT table. It can be directly mapped to
the configuration table. So, this solution is good to me. Reviewed-by:
Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: Jeff Brasen
> 发送时间: 2023年6月30日 5:09
> 收件人: devel@edk2.groups.io
> 抄送: jian.j.w...@intel.com;
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4491
This patch series is a follow-up of previous submission:
https://edk2.groups.io/g/devel/message/91995
The main changes between v1 and v2 patches are:
- Removed a fix which is a duplicate effort of
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4491
mAvailableAlgoArray is currently allocated for "RNG_AVAILABLE_ALGO_MAX"
number of bytes, whereas it was dereferenced as "EFI_RNG_ALGORITHM".
This change fixed the buffer allocation logic by allocating a proper size
of
Hi Sami,
Your suggestion in https://edk2.groups.io/g/devel/message/106511 works
properly during my test.
But I think we still need to keep the `+ , ` change below
as a bug fix?
Thanks,
Kun
On 6/29/2023 3:28 AM, Sami Mujawar wrote:
Hi Pierre,
I think this patch would not be required
Add API to add a String to a package created with NamedPackage API.
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 17
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 82
Add API to generate a Name that contains a Unicode string buffer.
Change-Id: I0116b2921cbbbecc3420ff7a42a7ab6e01852534
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 31 +++
.../Common/AmlLib/CodeGen/AmlCodeGen.c
Add support to add Return objects via AML that pass a single integer
argument to the named method.
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 54 +
Add APIs needed to create thermal zones dynamically.
Does not add a generator for this as creating the TMP method generically may
be difficult.
Jeff Brasen (4):
DynamicTablesPkg: Add ThermalZone CodeGen function
DynamicTablesPkg: Add support for simple method invocation.
DynamicTablesPkg:
Add API to generate a ThermalZone object to AmlLib.
Signed-off-by: Jeff Brasen
Reviewed-by: Swatisri Kantamsetti
Reviewed-by: Ashish Singhal
---
.../Include/Library/AmlLib/AmlLib.h | 28 +
.../Common/AmlLib/CodeGen/AmlCodeGen.c| 116 ++
2 files
Sure!
https://github.com/tianocore/edk2-redfish-client/pull/43
Thanks,
Mike
On Tue, Jun 27, 2023 at 3:05 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Hi Mike, could you please create a PR for this change? Then I can merge it
> once the change passed CI.
>
> Thanks
> Abner
Hi Nickle,
That makes sense. Thanks for the clarification.
Reviewed-by: Saloni Kasbekar
Thanks,
Saloni
-Original Message-
From: Nickle Wang
Sent: Wednesday, June 28, 2023 3:30 PM
To: Kasbekar, Saloni ; devel@edk2.groups.io
Cc: Maciej Rabeda ; Siyuan Fu
; Abner Chang ; Igor
Add the new section for Secure Boot.
Signed-off-by: Alexander Goncharov
---
OvmfPkg/README | 40
1 file changed, 40 insertions(+)
diff --git a/OvmfPkg/README b/OvmfPkg/README
index 0a408abf01..a5b447dae3 100644
--- a/OvmfPkg/README
+++ b/OvmfPkg/README
Systems that do not boot with ACPI (system that use device tree for example)
can not use the shell dp command. This patch adds this to the configuration
table so that dp command can get this without the FPDT table.
I am open to other ways for this to be passed if desired (Installed protocol,
Install the performance table into the UEFI configuration table.
This will allow the shell application to get this if the system
is not using ACPI.
Signed-off-by: Jeff Brasen
---
.../Library/DxeCorePerformanceLib/DxeCorePerformanceLib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
If the system does not have ACPI setup use the configuration table
to get the performance info.
Signed-off-by: Jeff Brasen
---
ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 11 ---
ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf| 1 +
If the platform does not support any PCIe devices using the library
method allow devices to connect to host bridge via driver binding.
Signed-off-by: Jeff Brasen
---
.../Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 649 ++
.../Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf | 1
Add EFI_NOT_READY return if the CPU can not be enabled if the
processor is already on.
This can occur in normal use if the CPU is still being turned off from
a previous call when this is called again.
Signed-off-by: Jeff Brasen
---
ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c | 4
This patch seems to have some discrepancy between the title and content :)
Can you please break this patch into 2, so that MdePkg change and
SecurityPkg can be their
own commit?
Thanks,
Kun
On 5/9/2023 12:40 AM, PierreGondois wrote:
From: Pierre Gondois
In order to use
Hi Pierre,
Do we really need this removal of ASSERT? I tried to use the real
ArmTrngLib with this patch
and it seems to work fine with a TFA that does not support TRNG interfaces.
I think it would be valuable to keep the ASSERT to indicate there might
be an integration error?
Please let me
Hi Pierre/Sami,
Thanks for the information. I tried the patch set you referred, it seems
to have resolved
the zero GUID handling issue! So I am okay to drop the commit here:
https://edk2.groups.io/g/devel/message/106484
I also have a few questions on the patch set beyond functionality, we
Liming,
In general, due to feedback on this list we have tried to require
explicit opt-in for all the stuart based validation tools. So could
that be done yes, but it goes against our current consistent approach of
requiring opt-in and then would put the burden on a platform/package
owner
Store Smmu base address in variable in case it would be needed
in more than one place.
Signed-off-by: Marcin Juszkiewicz
---
Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 1 +
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
2 files changed, 2 insertions(+)
diff --git a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec
SBSA Reference Platform can have GIC ITS present. And when it has then
we can have complex PCI Express setup (and some other things).
First patch adds support for GIC ITS. Address is read from TF-A via SMC
call. IORT is generated, MADT has ITS information. Linux boots and sees
GIC ITS as
From: Shashi Mallela
SBSA Reference Platform has GIC ITS support. Let make use of it.
Base address is read from TF-A via SMC call.
GIC ITS allows us to have complex PCI Express setups.
Co-authored-by: Marcin Juszkiewicz
Signed-off-by: Shashi Mallela
Signed-off-by: Marcin Juszkiewicz
---
If firmware is used with QEMU 8.0 or older then there will be no GIC ITS
support.
In such case we would not add information about it into MADT and IORT
tables.
Signed-off-by: Marcin Juszkiewicz
---
.../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 -
.../SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
From: Taylor Beebe
Much of the MMU logic was written without function headers. This patch
adds function headers where absent and updates function headers which
do not match the EDK2 standard.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Taylor Beebe
---
From: Taylor Beebe
There are ASSERTs present in the MMU logic to ensure various
functions return successfully, but these ASSERTs may be ignored
on release builds causing unsafe behavior. This patch updates
the logic to handle unexpected return values and branch safely.
Cc: Leif Lindholm
Cc:
From: Taylor Beebe
This patch updates the GetMemoryRegion() function to handle the case
where there is no mapping for the requested address.
The original logic for the ARM would hit an ASSERT after
GetMemoryRegionPage() returned EFI_SUCCESS but did not update The
RegionLength parameter.
The
From: Taylor Beebe
This patch applies Uncrustify to the following files:
ArmPkg/Drivers/MmCommunicationPei/MmCommunicationPei.c
ArmPkg/Include/IndustryStandard/ArmStdSmc.h
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Taylor Beebe
---
This patch series:
1. Updates applies uncrustify to noncompliant files
2. Updates GetMemoryRegion() to handle the case where
BaseAddress is an unmapped page, and update some other
return values to be more consistent.
3. Adds some branching paths to what were previously only
ASSERT
Hi,
OpenSSL 1.1.1 series reach End of Life (EOL) on 11th September 2023.
For Next Edk2 Release, it is possible to update openssl to 3.0?
or When Openssl_3.0 will be updated in edk2.
Kindly provide your comments.
Thanks,
Sountharya
-The information contained in this message may be confidential
Hi Kun,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 28/06/2023 09:33 pm, Kun Qin wrote:
From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4491
mAvailableAlgoArray is currently allocated for "RNG_AVAILABLE_ALGO_MAX"
number of bytes, whereas
Hi Kun,
Can you look at Pierre's series and see if this issue is resolved, please?
I have also made further suggestions at
https://edk2.groups.io/g/devel/message/106511.
Regards,
Sami Mujawar
On 28/06/2023 09:33 pm, Kun Qin wrote:
From: Kun Qin
REF:
Hi Pierre,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The first element of mAvailableAlgoArray is defined as the default
Rng algorithm to use. Don't
Hi Pierre,
I think this patch would not be required if my suggestions for patch 6/8
are adopted.
Regards,
Sami Mujawar
On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The first element of mAvailableAlgoArray should be the default
algorithm to avoid going
Hi Pierre,
Thank you for this patch.
I think we should treat algorithms that have a zero GUID as unsafe. I
have made some suggestions on those lines marked inline as [SAMI].
Regards,
Sami Mujawar
On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Hi Pierre,
Thank you for this patch.
Please find my response inline marked [SAMI].
With that addressed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The EFI_RNG_PROTOCOL can use the RngLib. The RngLib has
Hi Pierre,
Thank you for this patch.
Please find my response inline marked [SAMI].
Other than the concern mentioned below, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois
BZ:
Hi Pierre,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The DxeRngLib tries to generate a random number using the 3 NIST
SP 800-90 compliant DRBG
Hi Pierre,
Please see my response inline marked [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois
In order to use PcdCpuRngSupportedAlgorithm in the MdePkg in a
following patch and to avoid
Hi Pierre,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Remove ASSERTs to allow RngDxe probing the Null implementation
of the TrngLib.
Signed-off-by:
Tom,
Thanks for the comments. In V8 patch, I've refined the commit message and added
comments in the code around the areas being changed to explain this code change.
Thanks,
Dun
-Original Message-
From: devel@edk2.groups.io On Behalf Of Lendacky, Thomas
via groups.io
Sent: Tuesday,
Remove code that sets AddressEncMask for non-leaf entries when
modifing smm page table by MemEncryptSevLib. In FvbServicesSmm
driver, it calls MemEncryptSevClearMmioPageEncMask to clear
AddressEncMask bit in page table for a specific range. In AMD
SEV feature, this AddressEncMask bit in page table
In the V8 patch set:
In 'OvmfPkg:Remove code that apply AddressEncMask to non-leaf entry', I refined
the commit message and added comments in the code around the areas being
changed to explain this code change.
Only resend the changed patch in OvmfPkg. The patch set has been reviewed-by
Dun
Thanks for the update.
+} HDM_DECODER_N_INFO;
I think this need add CXL_ prefix.
Other looks good to me.
Thank you
Yao, Jiewen
> -Original Message-
> From: Chris Li OS
> Sent: Wednesday, June 28, 2023 1:28 PM
> To: devel@edk2.groups.io; Yao, Jiewen
> Subject: [PATCH 1/1] MdePkg:
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, June 29, 2023 11:35 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Gao, Liming ;
Feng, Bob C
Subject: [Patch V2 4/4] BaseTools: FMMT replace new free space fixing in replace
In FMMT replace function, when
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, June 29, 2023 11:35 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Feng, Bob C ; Gao,
Liming
Subject: [Patch V2 3/4] BaseTools: FMMT support ELF UPLD parser
FMMT add new function to support the .elf file
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, June 29, 2023 11:35 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Feng, Bob C ; Gao,
Liming
Subject: [Patch V2 2/4] BaseTools: FMMT replace output file is not generated
successfully
For replace
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Thursday, June 29, 2023 11:34 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Gao, Liming ;
Feng, Bob C
Subject: [Patch V2 1/4] BaseTools: fixing FMMT ShrinkFv issue
1. FvLength not change issue;
2. FileSystemGuid
Hello Kun,
Thanks for the patch-set, there is another patch-set that also aims to fix the
logic at:
https://edk2.groups.io/g/devel/message/104341
but I haven't got feedback so far. Would it be possible to try it out to see if
it also solves your issue ?
Regards,
Pierre
On 6/28/23 22:33, Kun
59 matches
Mail list logo
