Em qua 30 abr 2014, às 18:49:25, John Layt escreveu:
> This is a common pattern in Qt to indicate the last valid value, so is
> OK afaik, it's just weird the same issue reports with different
> severity.
For future reference: don't add those to the same enum.
--
Thiago Macieira - thiago.macieira
On 30 April 2014 16:28, Andrey Ponomarenko wrote:
>
>
> ABI report for 5.3.0-rc:
> http://upstream-tracker.org/compat_reports/qt/5.2.1_to_5.3.0-rc/abi_compat_report.html
Hi,
Interesting that it reports a Medium severity problem for:
qpagedpaintdevice.h
enum QPagedPaintDevice::PageSize
Thiago Macieira wrote:
> Em qua 23 abr 2014, às 16:50:45, Andrey Ponomarenko escreveu:
>> I've created the ABI compatibility report between 5.2.1 and 5.3.0-beta
>> versions:
>> http://upstream-tracker.org/compat_reports/qt/5.2.1_to_5.3.0-beta/abi_compat
>> _report.html
> Thanks Andrey! I'll take a
Sune Vuorela wrote:
> On 2014-04-23, Andrey Ponomarenko wrote:
>> I've created the ABI compatibility report between 5.2.1 and 5.3.0-beta
>> versions:
>> http://upstream-tracker.org/compat_reports/qt/5.2.1_to_5.3.0-beta/abi_compat_report.html
>>
>> Hope it may be helpful to analyse changes in head
On 2014-04-23, Andrey Ponomarenko wrote:
> I've created the ABI compatibility report between 5.2.1 and 5.3.0-beta
> versions:
> http://upstream-tracker.org/compat_reports/qt/5.2.1_to_5.3.0-beta/abi_compat_report.html
>
> Hope it may be helpful to analyse changes in headers.
that abi tool is btw
Thiago Macieira wrote:
> Em qua 23 abr 2014, às 16:50:45, Andrey Ponomarenko escreveu:
>> I've created the ABI compatibility report between 5.2.1 and 5.3.0-beta
>> versions:
>> http://upstream-tracker.org/compat_reports/qt/5.2.1_to_5.3.0-beta/abi_compat
>> _report.html
> Thanks Andrey! I'll take a
On Wed, Apr 23, 2014 at 3:56 AM, Simon Hausmann
wrote:
> On Tuesday 22. April 2014 16.37.50 Thiago Macieira wrote:
>> Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
>> > http://macieira.org/~thiago/qt-5.3/QtQuick.diff
>>
>> Looks fine from the C++ side. I have no clue what those Q_REVI
On Tue, 22 Apr 2014 14:12:46 Thiago Macieira wrote:
> diff --git a/src/bluetooth/qbluetoothuuid.h b/src/bluetooth/qbluetoothuuid.h
> index ef69e98..014b975 100644
> --- a/src/bluetooth/qbluetoothuuid.h
> +++ b/src/bluetooth/qbluetoothuuid.h
> @@ -112,6 +112,7 @@ public:
> GN = 0x1117,
>
, 2014 01:34
To: development@qt-project.org
Subject: Re: [Development] Qt 5.3 header diff: QtCore
No major issues. All cosmetic.
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> --- a/src/corelib/kernel/qmetatype.h
> +++ b/src/corelib/kernel/qmetatype.h
> @@ -771,9 +771,13
Em qua 23 abr 2014, às 16:50:45, Andrey Ponomarenko escreveu:
> I've created the ABI compatibility report between 5.2.1 and 5.3.0-beta
> versions:
> http://upstream-tracker.org/compat_reports/qt/5.2.1_to_5.3.0-beta/abi_compat
> _report.html
Thanks Andrey! I'll take a look at the report soon.
Ca
Em qua 23 abr 2014, às 09:40:34, Giuseppe D'Angelo escreveu:
> I'm fine with them as they're simple forwarders to for the corresponding
> QTextDocument functionality. On the other hand, QTextDocument is missing
> QRegularExpression search...
I see. I withdraw my request then, since this is more th
On Wednesday 23 April 2014 11:30:16 Knoll Lars wrote:
> On 23/04/14 09:34, "Olivier Goffart" wrote:
>
>
> >On Wednesday 23 April 2014 00:28:46 Thiago Macieira wrote:
> >
> >> Em qua 23 abr 2014, às 09:17:37, Olivier Goffart escreveu:
> >>
> >> > Just a little problem.
> >> >
> >> > +#if QT_DEP
Hello,
I've created the ABI compatibility report between 5.2.1 and 5.3.0-beta
versions:
http://upstream-tracker.org/compat_reports/qt/5.2.1_to_5.3.0-beta/abi_compat_report.html
Hope it may be helpful to analyse changes in headers.
Here also a visual headers diff generated by the rfcdiff utilit
Look ok to me.
Lars
On 23/04/14 12:55, "Simon Hausmann" wrote:
>On Tuesday 22. April 2014 14.12.46 Thiago Macieira wrote:
>> http://macieira.org/~thiago/qt-5.3/QtQml.diff
>
>I think those changes look okay.
>
>The bulk of the work going into Qml right now is all focused on the
>internals
>firs
On 23/04/14 09:34, "Olivier Goffart" wrote:
>On Wednesday 23 April 2014 00:28:46 Thiago Macieira wrote:
>> Em qua 23 abr 2014, às 09:17:37, Olivier Goffart escreveu:
>> > Just a little problem.
>> >
>> > +#if QT_DEPRECATED_SINCE(5, 3)
>> > QSqlError( const QString& driverText = QString(),
>
Also ok.
Lars
On 22/04/14 23:12, "Thiago Macieira" wrote:
>http://macieira.org/~thiago/qt-5.3/QtPrintSupport.diff
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
On Tuesday 22. April 2014 16.37.50 Thiago Macieira wrote:
> Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> > http://macieira.org/~thiago/qt-5.3/QtQuick.diff
>
> Looks fine from the C++ side. I have no clue what those Q_REVISION changes
> do to QML.
I don't think we need them actuall
On Tuesday 22. April 2014 14.12.46 Thiago Macieira wrote:
> http://macieira.org/~thiago/qt-5.3/QtQml.diff
I think those changes look okay.
The bulk of the work going into Qml right now is all focused on the internals
first.
Simon
___
Development maili
On Tuesday 22. April 2014 16.37.06 Thiago Macieira wrote:
> Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> > diff --git a/src/qml/qml/qqmlprivate.h b/src/qml/qml/qqmlprivate.h
>
> Why do we have a public header with "private" in the name?
It part of the "private" interface into the
On 04/22/2014 11:57 PM, Sune Vuorela wrote:
> On 2014-04-22, Thiago Macieira wrote:
>> --- a/src/network/ssl/qsslconfiguration.h
>> +++ b/src/network/ssl/qsslconfiguration.h
>> @@ -131,6 +132,21 @@ public:
>> +static const char NextProtocolSpdy3_0[];
>> +static const char NextProtocolHttp1
> -Original Message-
> [...]
> From: development-bounces+kai.koehne=digia@qt-project.org
> These two change combined trigger QTBUG-37283: it's now not possible to
> use qCDebug(cat) on a compiler w/o variadic macros, where cat is a function
> that returns a QLoggingCategory subclass.
-project.org] On Behalf Of
Giuseppe D'Angelo
Sent: 23. april 2014 09:35
To: development@qt-project.org
Subject: Re: [Development] Qt 5.3 header diff: QtGui
Il 23/04/2014 01:15, Thiago Macieira ha scritto:
>> >+enum OpenGLModuleType {
>> >+Deskto
Il 23/04/2014 01:44, Thiago Macieira ha scritto:
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
--- a/src/widgets/widgets/qplaintextedit.h
+++ b/src/widgets/widgets/qplaintextedit.h
@@ -141,6 +145,9 @@ public:
bool centerOnScroll() const;
bool find(const QString &exp, QT
On Tuesday 22 April 2014 17:49:17 Thiago Macieira wrote:
> Em qua 23 abr 2014, às 10:28:51, Aaron McCarthy escreveu:
> > On Tue, 22 Apr 2014 14:12:46 Thiago Macieira wrote:
> > > http://macieira.org/~thiago/qt-5.3/QtLocation.diff
> >
> > This is fine. Qt Location is not part of the 5.3 release.
>
On Wednesday 23 April 2014 00:28:46 Thiago Macieira wrote:
> Em qua 23 abr 2014, às 09:17:37, Olivier Goffart escreveu:
> > Just a little problem.
> >
> > +#if QT_DEPRECATED_SINCE(5, 3)
> > QSqlError( const QString& driverText = QString(),
> > const QString& databaseText = QS
Il 23/04/2014 01:15, Thiago Macieira ha scritto:
>+enum OpenGLModuleType {
>+DesktopGL,
>+GLES2
>+};
Suggestion: OpenGL & OpenGLES2. Some non-desktop devices may have non-ES GL.
The fact that we constantly refer to "desktop GL" erroneously should not
influence the API.
Em qua 23 abr 2014, às 09:17:37, Olivier Goffart escreveu:
> Just a little problem.
>
> +#if QT_DEPRECATED_SINCE(5, 3)
> QSqlError( const QString& driverText = QString(),
> const QString& databaseText = QString(),
> ErrorType type = NoError,
>
Il 22/04/2014 23:12, Thiago Macieira ha scritto:
http://macieira.org/~thiago/qt-5.3/QtCore.diff
QtCore.diff
+void warning(const char *msg, ...) const Q_ATTRIBUTE_FORMAT_PRINTF(2, 3);
+void critical(const char *msg, ...) const Q_ATTRIBUTE_FORMAT_PRINTF(2, 3);
+
+typedef const QLoggi
On Tuesday 22 April 2014 16:43:00 Thiago Macieira wrote:
> Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> > http://macieira.org/~thiago/qt-5.3/QtSql.diff
>
> Looks fine, if scary.
Just a little problem.
+#if QT_DEPRECATED_SINCE(5, 3)
QSqlError( const QString& driverText = QSt
>
>Sent: Wednesday, April 23, 2014 01:35
>To: development@qt-project.org
>Subject: Re: [Development] Qt 5.3 header diff: QtPositioning
>Why do we need two sets of macros?
Excellent question.
https://codereview.qt-project.org/#change
Em qua 23 abr 2014, às 10:28:51, Aaron McCarthy escreveu:
> On Tue, 22 Apr 2014 14:12:46 Thiago Macieira wrote:
> > http://macieira.org/~thiago/qt-5.3/QtLocation.diff
>
> This is fine. Qt Location is not part of the 5.3 release.
Indeed.
However, Ubuntu did ship it in previous releases.
http://p
On Tue, 22 Apr 2014 14:12:46 Thiago Macieira wrote:
> http://macieira.org/~thiago/qt-5.3/QtLocation.diff
This is fine. Qt Location is not part of the 5.3 release.
Cheers,
--
Aaron McCarthy
___
Development mailing list
Development@qt-project.org
http:/
On Tue, 22 Apr 2014 14:12:46 Thiago Macieira wrote:
> http://macieira.org/~thiago/qt-5.3/QtBluetooth.diff
Looks fine.
Cheers,
--
Aaron McCarthy
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/develo
Em ter 22 abr 2014, às 16:34:09, Thiago Macieira escreveu:
> > --- a/src/corelib/kernel/qobject.h
> > +++ b/src/corelib/kernel/qobject.h
> > @@ -549,6 +549,83 @@ template inline const char *
> > qobject_interface_iid()>
> >
> > Q_CORE_EXPORT QDebug operator<<(QDebug, const QObject *);
> > #endi
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> --- a/src/widgets/widgets/qplaintextedit.h
> +++ b/src/widgets/widgets/qplaintextedit.h
> @@ -141,6 +145,9 @@ public:
> bool centerOnScroll() const;
>
> bool find(const QString &exp, QTextDocument::FindFlags options = 0);
> +#
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> http://macieira.org/~thiago/qt-5.3/QtTest.diff
Looks fine, not including the ugly exception verification macros. I didn't even
read those.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Tec
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> http://macieira.org/~thiago/qt-5.3/QtSql.diff
Looks fine, if scary.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
___
Developm
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> http://macieira.org/~thiago/qt-5.3/QtSensors.diff
Looks fine.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
___
Development ma
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> http://macieira.org/~thiago/qt-5.3/QtQuick.diff
Looks fine from the C++ side. I have no clue what those Q_REVISION changes do
to QML.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technolo
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> diff --git a/src/qml/qml/qqmlprivate.h b/src/qml/qml/qqmlprivate.h
Why do we have a public header with "private" in the name?
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> --- a/src/positioning/qpositioningglobal.h
> +++ b/src/positioning/qpositioningglobal.h
> @@ -48,13 +48,17 @@ QT_BEGIN_NAMESPACE
> #ifndef QT_STATIC
> #if defined(QT_BUILD_POSITIONING_LIB)
> # define Q_POSITIONING_EXPORT
No major issues. All cosmetic.
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> --- a/src/corelib/kernel/qmetatype.h
> +++ b/src/corelib/kernel/qmetatype.h
> @@ -771,9 +771,13 @@ struct VariantData
>, flags(flags_)
> {
> }
> +VariantData(const VariantData &other)
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> http://macieira.org/~thiago/qt-5.3/QtDBus.diff
Looks fine.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
___
Development maili
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu:
> diff --git a/src/gui/kernel/qopenglcontext.h
> b/src/gui/kernel/qopenglcontext.h index ce34a2d..fce983f 100644
> --- a/src/gui/kernel/qopenglcontext.h
> +++ b/src/gui/kernel/qopenglcontext.h
> @@ -192,6 +192,17 @@ public:
> QSet exte
ela
> Sent: Dienstag, 22. April 2014 23:56
> To: development@qt-project.org
> Subject: Re: [Development] Qt 5.3 header diff: QtLocation
>
>
> On 2014-04-22, Thiago Macieira wrote:
>> -QGeoCodingManagerEngine(const QMap ¶meters,
>> QObject *parent = 0);
>>
On 2014-04-22, Thiago Macieira wrote:
> --- a/src/widgets/widgets/qlcdnumber.h
> +++ b/src/widgets/widgets/qlcdnumber.h
> @@ -43,7 +43,6 @@
> #define QLCDNUMBER_H
>
> #include
> -#include
>
> QT_BEGIN_NAMESPACE
>
I guess this is theoretically a SiC change, but one that could also be
ig
On 2014-04-22, Thiago Macieira wrote:
> --- a/src/serialport/qserialport.h
> +++ b/src/serialport/qserialport.h
> @@ -64,11 +64,11 @@ class Q_SERIALPORT_EXPORT QSerialPort : public QIODevice
> Q_PROPERTY(FlowControl flowControl READ flowControl WRITE setFlowControl
> NOTIFY flowControlChange
Qt Location is not officially part of Qt 5.3.0 .. is it?
Sent from my BlackBerry 10 smartphone.
Original Message
From: Sune Vuorela
Sent: Dienstag, 22. April 2014 23:56
To: development@qt-project.org
Subject: Re: [Development] Qt 5.3 header diff: QtLocation
On 2014-04-22, Thiago Macieira
On 2014-04-22, Thiago Macieira wrote:
> --- a/src/network/ssl/qsslconfiguration.h
> +++ b/src/network/ssl/qsslconfiguration.h
> @@ -131,6 +132,21 @@ public:
> +static const char NextProtocolSpdy3_0[];
> +static const char NextProtocolHttp1_1[];
These static const char[] kind of triggers m
On 2014-04-22, Thiago Macieira wrote:
> -QGeoCodingManagerEngine(const QMap ¶meters,
> QObject *parent = 0);
> +QGeoCodingManagerEngine(const QVariantMap ¶meters, QObject *parent =
> 0);
Given it is just changes to typedefs, it should be okay. There are quite
many of those across this d
http://macieira.org/~thiago/qt-5.3/QtOpenGL.diff
diff --git a/src/opengl/qglframebufferobject.h b/src/opengl/qglframebufferobject.h
index 9312a23..affa47c 100644
--- a/src/opengl/qglframebufferobject.h
+++ b/src/opengl/qglframebufferobject.h
@@ -63,17 +63,11 @@ public:
QGLFramebufferObject(c
http://macieira.org/~thiago/qt-5.3/QtTest.diff
diff --git a/src/testlib/qtest.h b/src/testlib/qtest.h
index ac1d6cc..7c9a7b2 100644
--- a/src/testlib/qtest.h
+++ b/src/testlib/qtest.h
@@ -66,14 +66,14 @@ QT_BEGIN_NAMESPACE
namespace QTest
{
-template<> inline char *toString(const QLatin1String
http://macieira.org/~thiago/qt-5.3/QtWidgets.diff
diff --git a/src/widgets/dialogs/qmessagebox.h b/src/widgets/dialogs/qmessagebox.h
index c5598a8..5fae174 100644
--- a/src/widgets/dialogs/qmessagebox.h
+++ b/src/widgets/dialogs/qmessagebox.h
@@ -72,6 +72,7 @@ class Q_WIDGETS_EXPORT QMessageBox : p
http://macieira.org/~thiago/qt-5.3/QtQml.diff
diff --git a/src/qml/qml/qqml.h b/src/qml/qml/qqml.h
index b6c6fe8..721f2cc 100644
--- a/src/qml/qml/qqml.h
+++ b/src/qml/qml/qqml.h
@@ -91,13 +91,13 @@ class QQmlPropertyValueInterceptor;
const char *className = T::staticMetaObject.className(); \
http://macieira.org/~thiago/qt-5.3/QtSerialPort.diff
diff --git a/src/serialport/qserialport.h b/src/serialport/qserialport.h
index 6e16463..6ca5af4 100644
--- a/src/serialport/qserialport.h
+++ b/src/serialport/qserialport.h
@@ -64,11 +64,11 @@ class Q_SERIALPORT_EXPORT QSerialPort : public QIODev
http://macieira.org/~thiago/qt-5.3/QtSensors.diff
diff --git a/src/sensors/qcompass.h b/src/sensors/qcompass.h
index 75b6869..5351062 100644
--- a/src/sensors/qcompass.h
+++ b/src/sensors/qcompass.h
@@ -67,7 +67,7 @@ class Q_SENSORS_EXPORT QCompassFilter : public QSensorFilter
public:
virtual
http://macieira.org/~thiago/qt-5.3/QtQuick.diff
diff --git a/src/quick/items/qquickitem.h b/src/quick/items/qquickitem.h
index 2500a2d..2b08cc2 100644
--- a/src/quick/items/qquickitem.h
+++ b/src/quick/items/qquickitem.h
@@ -56,7 +56,7 @@ QT_BEGIN_NAMESPACE
class QQuickItem;
class QQuickTransfo
http://macieira.org/~thiago/qt-5.3/QtSql.diff
diff --git a/src/sql/kernel/qsqldriver.h b/src/sql/kernel/qsqldriver.h
index 017ffd4..f93a030 100644
--- a/src/sql/kernel/qsqldriver.h
+++ b/src/sql/kernel/qsqldriver.h
@@ -62,6 +62,7 @@ class QVariant;
class Q_SQL_EXPORT QSqlDriver : public QObject
{
http://macieira.org/~thiago/qt-5.3/QtPrintSupport.diff
diff --git a/src/printsupport/dialogs/qprintdialog.h b/src/printsupport/dialogs/qprintdialog.h
index c822aa0..886cd1e 100644
--- a/src/printsupport/dialogs/qprintdialog.h
+++ b/src/printsupport/dialogs/qprintdialog.h
@@ -106,7 +106,6 @@ Q_SIGNA
http://macieira.org/~thiago/qt-5.3/QtMultimedia.diff
diff --git a/src/multimedia/camera/qcamera.h b/src/multimedia/camera/qcamera.h
index 6a29b2c..9c413c3 100644
--- a/src/multimedia/camera/qcamera.h
+++ b/src/multimedia/camera/qcamera.h
@@ -64,6 +64,7 @@ QT_BEGIN_NAMESPACE
class QAbstractVideoSur
http://macieira.org/~thiago/qt-5.3/QtNetwork.diff
diff --git a/src/network/access/qnetworkreply.h b/src/network/access/qnetworkreply.h
index a7db2d1..f11a5e8 100644
--- a/src/network/access/qnetworkreply.h
+++ b/src/network/access/qnetworkreply.h
@@ -93,12 +93,20 @@ public:
ContentNotFound
http://macieira.org/~thiago/qt-5.3/QtPositioning.diff
diff --git a/src/positioning/qgeorectangle.h b/src/positioning/qgeorectangle.h
index cd91c1d..babbe62 100644
--- a/src/positioning/qgeorectangle.h
+++ b/src/positioning/qgeorectangle.h
@@ -55,6 +55,7 @@ public:
QGeoRectangle();
QGeoRec
http://macieira.org/~thiago/qt-5.3/QtLocation.diff
diff --git a/src/location/maps/qgeocodingmanagerengine.h b/src/location/maps/qgeocodingmanagerengine.h
index aa2839a..11862db 100644
--- a/src/location/maps/qgeocodingmanagerengine.h
+++ b/src/location/maps/qgeocodingmanagerengine.h
@@ -56,7 +56,7
http://macieira.org/~thiago/qt-5.3/QtConcurrent.diff
diff --git a/src/concurrent/qtconcurrentiteratekernel.h b/src/concurrent/qtconcurrentiteratekernel.h
index b47c30a..0969029 100644
--- a/src/concurrent/qtconcurrentiteratekernel.h
+++ b/src/concurrent/qtconcurrentiteratekernel.h
@@ -86,6 +86,8 @@
http://macieira.org/~thiago/qt-5.3/QtBluetooth.diff
diff --git a/src/bluetooth/qbluetoothdevicediscoveryagent.h b/src/bluetooth/qbluetoothdevicediscoveryagent.h
index a311d14..4ac1685 100644
--- a/src/bluetooth/qbluetoothdevicediscoveryagent.h
+++ b/src/bluetooth/qbluetoothdevicediscoveryagent.h
@@
http://macieira.org/~thiago/qt-5.3/QtDBus.diff
diff --git a/src/dbus/qdbusserver.h b/src/dbus/qdbusserver.h
index d455f8e..7a7f54b 100644
--- a/src/dbus/qdbusserver.h
+++ b/src/dbus/qdbusserver.h
@@ -66,6 +66,9 @@ public:
QDBusError lastError() const;
QString address() const;
+void
Results
Modules with no public headers:
Enginio
QtAndroidExtras
QtCompositor
QtFtp
QtHttp
QtMacExtras
QtOrganizer
QtPlatformSupport
QtPlatformSupport
QtQmlDevTools
QtQuickParticles
QtVersit
QtVer
67 matches
Mail list logo