edk2-stable201811 tag.
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Julien Grall
Cc: Philippe Mathieu-Daudé
Cc: yuchenlin
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1319
Signed-off-by: Laszlo Ersek
---
OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 1 +
1 file chang
edk2-stable201811 tag.
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Julien Grall
Cc: Philippe Mathieu-Daudé
Cc: yuchenlin
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1319
Signed-off-by: Laszlo Ersek
---
OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf | 6 ++
Ov
On 11/09/18 20:08, Phil Dennis-Jordan wrote:
> Hi Laszlo,
>
> On Fri, Nov 9, 2018 at 5:47 PM Laszlo Ersek wrote:
>>
>> + Yuchenlin, + Gerd, + both Phils
>>
>> On 11/07/18 20:13, Laszlo Ersek wrote:
>>
>>>>> For example, I reviewed and pushed
On 11/09/18 18:14, Kinney, Michael D wrote:
> Hi Laszlo,
>
> There is already a "Documentation" component under
> EDK2 in BZ. Can we use that and identify the target
> of the documentation change is in a Wiki page?
Absolutely.
> When you select "Documentation" there is a drop down
> for "Tianoc
On 11/09/18 18:07, Kinney, Michael D wrote:
> Perhaps we should update Maintainers.txt with some lines
> that identify the developers that are currently assigned
> to the release/release planning role. That way, the Wiki
> can reference Maintainters.txt and we can update
> Maintainers.txt as the a
+ Yuchenlin, + Gerd, + both Phils
On 11/07/18 20:13, Laszlo Ersek wrote:
>>> For example, I reviewed and pushed 4 patches yesterday (on 2018-Nov-06):
>>>
>>> 1 e038bde2679b Revert "OvmfPkg/QemuVideoDxe: list
>>> "UnalignedIoInternal.h" in
On 11/09/18 17:01, Leif Lindholm wrote:
> On Fri, Nov 09, 2018 at 03:32:03PM +, Gao, Liming wrote:
>> Laszlo and Leif:
>> I suggest to continue to update wiki page with more
>> information. If so, we can avoid such case again.
>
> Agreed, we need to be able to interpret what the process sa
ao"
?
Thanks!
Laszlo
>
> Thanks
> Liming
>> -Original Message-
>> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
>> Sent: Friday, November 9, 2018 6:05 PM
>> To: Laszlo Ersek
>> Cc: edk2-devel@lists.01.org; Andrew Fish ; Richards
meta:
On 11/09/18 16:55, Leif Lindholm wrote:
> On Fri, Nov 09, 2018 at 02:46:40PM +, Zhang, Chao B wrote:
>> Hi Leif:
>>The NTC1310 can work well with previous EDK2 stable version
>>(UDK2018). Interface Cache is a new feature introduced after
>>UDK2018.
>> So far as we see, it cau
8", not in a last minute rush before
"edk2-stable201811".
I'd like to hear Mike's and Andrew's opinion too.
Thanks,
Laszlo
>
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leif
> Lindholm
> Sent: Friday, November 9, 2018 7:13 PM
On 11/09/18 11:49, Leif Lindholm wrote:
> On Fri, Nov 09, 2018 at 07:56:07AM +0100, Ard Biesheuvel wrote:
>> On 9 November 2018 at 01:19, Gao, Liming wrote:
>>> Ard:
>>> This is a small fix. And, this patch is sent before the hard
>>> freeze. It is the low risk for this release. So, I push it.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Zhang, Chao B
> Cc: Andrew Fish
> Cc: Laszlo Ersek
> Cc: Leif Lindholm
> Cc: Michael D Kinney
> Cc: Yao Jiewen
> ---
> SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 23 +
On 11/09/18 04:34, Bi, Dandan wrote:
> Hi Stewards and package maintainers:
>
> Since this is a clear bug. And the risk for this release is small.
> So I plan to push this patch before edk2-stable201811 tag is created.
I agree, this is a bugfix, not a feature patch.
Thanks,
Laszlo
> If you hav
; From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Friday, November 09, 2018 1:45 AM
>> To: Leif Lindholm ; Gao, Liming
>>
>> Cc: Kinney, Michael D ; edk2-
>> de...@lists.01.org
>> Subject: Re: [edk2] [
On 11/08/18 14:33, Laszlo Ersek wrote:
> On 11/08/18 03:58, Eric Dong wrote:
>> In current implementation, core level semaphore use same container
>> with package level semaphore. This design will let the core level
>> semaphore not works as expected in below case
On 11/08/18 18:09, Jeff Brasen wrote:
> This function is exposed by the MemoryAllocationLib header.
> An AllocateZeroPool() function has been added to fix modules depending on
> this library and this function.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jeff Brasen
t
>> +++ b/Maintainers.txt
>> @@ -51,9 +51,7 @@ W:
>> https://github.com/tianocore/tianocore.github.io/wiki/Security
>>
>> EDK II Releases:
>>
>> -UDK2014
>> -W: http://www.tianocore.org/udk2014/
>> -S: Supported
>> +W:
>&
1.1
Signed-off-by: Laszlo Ersek
---
Notes:
Check out the rendered pages in my clone of the wiki:
https://github.com/lersek/edk2/wiki/SoftFeatureFreeze
https://github.com/lersek/edk2/wiki/HardFeatureFreeze
HardFeatureFreeze.md | 8
SoftFeatureFreeze.md | 8
2
Thanks!
Laszlo
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Thursday, November 8, 2018 9:10 PM
>> To: Gao, Liming ; Zeng, Star ;
>> Leif Lindholm
>> Cc: edk2-devel@lists.01.org; Cetola, Stephano ;
>> Richardson, Brian ;
On 11/08/18 00:00, Sean Brogan via edk2-devel wrote:
> Future question: Can we make rule for all other standard file types (c, h,
> dec, dsc, fdf, inf,)?
My suggestion: 7-bit ASCII.
Thanks,
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
h
a core semaphore, i will
> found WaitForSemaph(4(2)) is met because Thread 1 has execute a package
> semaphore and ReleaseSemaph(4) for it before. This is not an expect
> behavior. Thread 4 should wait for thread 3 to do this.
>
> Fix this issue by separate the semaphore containe
On 11/08/18 06:39, Gao, Liming wrote:
> Laszlo: Thanks for your feedback. We will send the separate announce
> mail ahead of the feature freeze date for next release cycle. And, I
> suggest to update SoftFeatureFreeze and HardFeatureFreeze wiki page
> with the announce mail requirement. For this r
the assumption that the assembler code consumes its inputs before
> producing outputs. This assumption may be false if the assembler
> code actually consists of more than one instruction."
>
> "=&a" should be used to tell GCC not use EAX before the assembly.
>
>> - ldrd r0, r1, [r0]
>>> + ldr r1, [r0, #4]
>>> + ldr r0, [r0]
>
> Ard remembered me UEFI is little-endian only :)
> Thus this code is safe.
>
> With the hunk appended:
> Reviewed-by: Philippe Mathieu-Daudé
So, this is for 32-bit
On 11/07/18 16:38, Leif Lindholm wrote:
> Hi Laszlo,
>
> Can I inject an alternative interpretation? (feel free to shoot it down)
>
> On Wed, Nov 07, 2018 at 04:14:01PM +0100, Laszlo Ersek wrote:
>> Hi,
>>
>> On 11/07/18 02:12, Gao, Liming wrote:
>>> H
On 11/07/18 16:27, Ni, Ruiyu wrote:
>
>
>> -Original Message-
>> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>> Sent: Wednesday, November 7, 2018 10:46 PM
>> To: Laszlo Ersek
>> Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; Kinney, Michael
&
U_VIDEO_CIRRUS_5446,
>QEMU_VIDEO_BOCHS,
>QEMU_VIDEO_BOCHS_MMIO,
> + QEMU_VIDEO_VMWARE_SVGA,
> } QEMU_VIDEO_VARIANT;
>
> typedef struct {
> @@ -120,6 +121,7 @@ typedef struct {
>QEMU_VIDEO_VARIANTVariant;
>FRAME_BUFFER_CONFIGURE*Fra
Hi,
On 11/07/18 02:12, Gao, Liming wrote:
> Hi, all
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
> lists edk2-stable201811 tag planning. Now, we enter into Soft Feature
> Freeze phase. In this phase, the feature under review will not be
> allowed to be pushed. T
tion Agreement 1.1
> Signed-off-by: Jiewen Yao
> Signed-off-by: Ruiyu Ni
> Cc: Eric Dong
> Cc: Jiewen Yao
> Acked-by: Laszlo Ersek
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, this has improved a lot
On 11/07/18 15:31, Laszlo Ersek wrote:
> (+Andrew)
>
> Hi Ray,
>
> On 11/07/18 05:03, Ruiyu Ni wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1303
>>
>> XCODE disassembly code of InternalSyncDecrement with today's code is:
>>
>>
f how we fill the AX register up-front, an
XADD instruction generated like this *cannot* be right.
> The patch uses the clobber list to tell GCC that EAX is used in ASM.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni
> Cc: Liming Gao
> C
position for
> CPU features which has dependence relationship.
>
> Change-Id: I86171cb1dbf44a2f6fd8d5d2209cafee9451b866
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
> ---
> .../RegisterCpuFeaturesLib.c
On 11/07/18 09:27, Yao, Jiewen wrote:
> If Static paging is not used, then the SMM uses dynamic paging.
>
> Here dynamic paging means the page fault request on-demand.
>
> 2 special examples here:
> 1) above 4G MMIO. By default, SMM only setup paging table for 4G memory. If
> MMIO above 4G, then
On 11/06/18 14:44, Philippe Mathieu-Daudé wrote:
> On 6/11/18 14:36, Laszlo Ersek wrote:
>> On 11/06/18 12:47, Laszlo Ersek wrote:
>>
>>> ... While we discuss this, I'll go ahead and push the first four
>>> patches. The code being reverted is dead anyway.
er: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni
> Cc: Eric Dong
> Cc: Laszlo Ersek
> ---
> UefiCpuPkg/Library/CpuCommonFeaturesLib/FeatureControl.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/Library/Cpu
g.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jiewen Yao
> Signed-off-by: Ruiyu Ni
> Cc: Eric Dong
> Cc: Jiewen Yao
> Cc: Laszlo Ersek
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 4 ++--
> 1 file changed, 2 insertions(+)
MdeModulePkg are not being actively
>> maintained and will be removed from edk2 master soon.
>>
>> Cc: Laszlo Ersek
>> Cc: Ard Biesheuvel
>> Cc: Julien Grall
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Fu Siyuan
>> --
he MdeModulePkg TCP, PXE and iSCSI driver with those
> ones in NetworkPkg. These 3 drivers in MdeModulePkg are not being actively
> maintained and will be removed from edk2 master soon.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Julien Grall
> Contributed-under: TianoCo
On 11/06/18 01:54, Fu, Siyuan wrote:
> Hi, Laszlo
>
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> I'm not asking for additional documentation regarding this fact, given
>> commi
On 11/06/18 12:26, Ard Biesheuvel wrote:
> On 5 November 2018 at 23:46, Laszlo Ersek wrote:
>> Assuming we consider "NetworkPkg/IScsiDxe/IScsiDxe.inf" an integral part
>> of the edk2 networking stack, without which (and its OpenSSL dependency)
>> noone would ever
On 11/06/18 01:59, Fu, Siyuan wrote:
> Hi, Leif and Laszlo
>
>
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Tuesday, November 6, 2018 6:12 AM
>> To: Leif Lindholm ; Fu, Siyuan
>>
>> Cc: edk2-devel@list
On 11/06/18 12:02, Leif Lindholm wrote:
> On Mon, Nov 05, 2018 at 11:12:20PM +0100, Laszlo Ersek wrote:
>>> Ming Huang (cc) has also had issues with this in his latest set (but
>>> not before). Can you guys work together to try to figure out what is
>>> going w
On 11/06/18 03:13, Wu, Jiaxin wrote:
> Already share the info @ https://bugzilla.tianocore.org/show_bug.cgi?id=1290
Awesome, thanks!
Laszlo
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Tuesday, November 6, 2018 2:33 AM
>>
On 11/06/18 12:47, Laszlo Ersek wrote:
> ... While we discuss this, I'll go ahead and push the first four
> patches. The code being reverted is dead anyway. I'll report back about
> the commit hashes.
Before pushing the first four patches, I regression-tested them as well.
Us
I suggest the following:
On 11/02/18 04:24, yuchenlin via edk2-devel wrote:
> From: yuchenlin
>
> BAR |std vga | vmsvga
> -
> 0| Framebuffer | I/O space
> 1| Reserved | Framebuffer
> 2| MMIO | FIFO
>
> Because of the PCI BAR
> Signed-off-by: yuchenlin
> ---
> OvmfPkg/Include/IndustryStandard/VmwareSvga.h | 104 --
> 1 file changed, 104 deletions(-)
> delete mode 100644 OvmfPkg/Include/IndustryStandard/VmwareSvga.h
Verified similarly to the last two patches
oIcc.c
> delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoInternal.h
> delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoMsc.c
> delete mode 100644 OvmfPkg/QemuVideoDxe/UnalignedIoUnsupported.c
Checked this the same way as patch v2 2/5.
Reviewed-by: Laszlo Ersek
___
valid revert.
In addition, the patch itself looks good, plus OVMF continues to build
fine after this patch (for bisectability's sake).
Reviewed-by: Laszlo Ersek
Thanks
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
nf
> +++ b/OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf
> @@ -39,7 +39,6 @@
>Gop.c
>Initialize.c
>Qemu.h
> - UnalignedIoInternal.h
>
> [Sources.Ia32, Sources.X64]
>UnalignedIoGcc.c| GCC
>
Reviewed-by: Laszlo Ersek
_
(+PhilMD)
On 11/02/18 04:23, yuchenlin via edk2-devel wrote:
> From: yuchenlin
>
> In this series, replace the original vmsvga driver to Bochs
> interface.
>
> Simply revert vmsvga driver implementation. After it, use Bochs
> interface for initializing vmsvga.
>
> Because of the PCI BARs diffe
ll be removed from edk2 master soon.
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Anthony Perard
> Cc: Julien Grall
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Fu Siyuan
> ---
> OvmfPkg/OvmfPkgIa32.dsc| 14 +
ll be removed from edk2 master soon.
>
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Cc: Julien Grall
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Fu Siyuan
> ---
> ArmVirtPkg/ArmVirtQemu.dsc | 13 ++---
&g
Hi Leif,
On 10/31/18 11:59, Leif Lindholm wrote:
> Hi Fu Siyuan,
>
> Hmm, strange.
>
> Ming Huang (cc) has also had issues with this in his latest set (but
> not before). Can you guys work together to try to figure out what is
> going wrong?
>
> Can you start by testing with an older version of
On 11/05/18 22:50, Laszlo Ersek wrote:
> On 11/05/18 04:08, Shenglei Zhang wrote:
>> From: shenglei
>>
>> Remove EdkShellBinPkg in OvmfPkgIa32.fdf,
>> OvmfPkg/OvmfPkgIa32X64.fdf amd OvmfPkg/OvmfPkgX64.fdf.
>> https://bugzilla.tianocore.org/show_bug.cgi?id=1108
; unnecessary to use it.
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> Change-Id: I4db7068a3a1f68a1f6303079b73dc548c9feb2e3
(1) Please remove the Change-Id line from the commit message.
(2) In order to be consistent with the other subject lines in the patc
On 10/31/18 06:42, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1290.
>
> Current implementation failed to parse the multiple TLS record
> messages due to the incorrect pointer of TLS record header. This
> patch is to resolve that problem.
>
> Cc: Ye Ting
> Cc: Fu Siyua
On 10/31/18 13:54, Hristo Mihaylov wrote:
> Hello,
>
> I'm building a custom x86_64 platform. It gets to BDS, where I select an USB
> with Debian as a boot device.
>
> ```
> [Bds]Booting UEFI USB Flash Memory C412F52D6C89C0210002C15B
> error: no suitable video mode found.
> error: no video mode
On 11/01/18 12:31, Leif Lindholm wrote:
> On Thu, Nov 01, 2018 at 06:03:22AM +, Zhang, Shenglei wrote:
>> Hi Leif,
>>
>> Thanks for your comments. Actually there is a cover letter.
>> https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html
>
> Ah, I missed that one since I was on c
On 10/31/18 20:55, Marvin Häuser wrote:
> Hey Eric,
>
> I discovered it by accident, no tool was involved.
[...]
Please always post a 0/nnn cover letter, and manually CC the sum of all
individual patch CC's on it. Otherwise the series quite falls apart in a
threaded view.
Thanks
Laszlo
On 11/05/18 11:49, Fu Siyuan wrote:
> V2 Update:
> [...]
My preliminary (meta) comments:
https://lists.01.org/pipermail/edk2-devel/2018-November/031914.html
Will follow up later.
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists
On 11/05/18 04:08, Shenglei Zhang wrote:
> Remove EdkShellBinPkg in CorebootPayloadPkg, EmulatorPkg, Nt32Pkg
> and OvmfPkg. Replace EdkShellBinPkg with EdkShellPkg in
> Vlv2TbltDevicePkg.
>
> v2: Remove 'USE_OLD_SHELL' in dsc files.
>
> v3: Remove FULL_BIN and change SHELL_TYPE from FULL_BIN
> to
On 10/24/18 15:22, Long Qin wrote:
> The LookupFreeMemRegion() in RuntimeMemAllocate.c is used to look-up
> free memory region for runtime resource allocation, which was designed
> to support runtime authenticated variable service.
> The direct offset subtractions in this function may bring possibl
allocate, when all memory space have been allocated once. This is
> called memory promotion. The promoted pages are always from the eldest
> pages which haven been freed.
>
> Cc: Star Zeng
> Cc: Michael D Kinney
> Cc: Jiewen Yao
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
&
ePoolPagesI()
> => CoreAllocatePoolPages()
> => FindFreePages()
> => PromoteMemoryResource()
> => CoreAcquireGcdMemoryLock() **
>
> Cc: Star Zeng
> Cc: Michael D Kinney
> Cc: Jiewen Yao
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement
> Cc: Star Zeng
> Cc: Michael D Kinney
> Cc: Jiewen Yao
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 2 +-
> MdeModulePkg/C
also *why* we don't do that, should be mentioned
explicitly in the commit message of the patch that modifies
HEAP_GUARD_NONSTOP_MODE in "UefiCpuPkg/CpuDxe/CpuDxe.h":
UefiCpuPkg/CpuDxe: consider Use After Free guard in non-stop mode
(65 characters)
> Cc: Laszlo Ersek
> Cc:
ard feature.
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask
>
> Please note this feature cannot be enabled with heap guard at the same
> time.
>
> Cc: Star Zeng
> Cc: Michael D Kinney
> Cc: Jiewen Yao
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
> Contribu
On 10/23/18 15:42, Gerd Hoffmann wrote:
> Hi,
>
>> Please help me see the situation better. Here's my current
>> understanding.
>>
>> (1) QemuVideoDxe doesn't set up the VMW SVGA FIFO, and does not store 1
>> to the SVGA_REG_CONFIG_DONE register. And this is not a "small
>> missing step"
On 10/23/18 13:12, yuchenlin wrote:
> Hi, Laszlo
>
> On 2018-10-23 18:18, Laszlo Ersek wrote:
>> (1) Adding Gerd (because he maintains video in QEMU), and Phil
>> Dennis-Jordan (for authoring commit c137d9508169,
>> "OvmfPkg/QemuVideoDxe: VMWare SVGA device support&
. I'm ACKing the set to confirm that. Thanks for the commit
message updates.
Acked-by: Laszlo Ersek
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
(1) Adding Gerd (because he maintains video in QEMU), and Phil
Dennis-Jordan (for authoring commit c137d9508169, "OvmfPkg/QemuVideoDxe:
VMWare SVGA device support", 2017-04-07).
On 10/23/18 04:40, yuchen...@synology.com wrote:
> From: yuchenlin
>
> When driver doesn't set fifo config, the vmsvg
On 10/23/18 11:36, Ni, Ruiyu wrote:
> On 10/23/2018 11:12 AM, Lohr, Paul A wrote:
>> Hello,
>>
>> Code to remove SMRAM = UC (line 650-ish) looks good. I would suggest
>> adding some debug comments in the area it was removed. Thanks.
>
> debug message or comments?
> I guess you'd like to have som
On 10/22/18 11:03, Ruiyu Ni wrote:
> Today's PiSmmIpl implementation initially sets SMRAM to WB to speed
> up the SMM core/modules loading before SMM CPU driver runs.
> When SMM CPU driver runs, PiSmmIpl resets the SMRAM to UC. It's done
> in SmmIplDxeDispatchEventNotify(). COMM_BUFFER_SMM_DISPATCH
Hello Jeremiah,
On 10/19/18 18:09, Jeremiah Cox wrote:
> I'd like to better understand assertions of GitHub "lock in". GitHub
> provides a comprehensive REST API that you can easily drive via Python
> ("pip install PyGithub").
> I recall one assertion that GitHub holds PR comments hostage, but i
On 10/19/18 16:40, Gao, Liming wrote:
>
> I don't find the detail information for each CVE. BZ 686 attaches one
> doc to list all issues. So, I fix them together. I think one patch is
> allowed to include more than one CVEs. Even if with single CVE, patch
> subject may be longer than 80 character
On 10/19/18 04:06, Eric Dong wrote:
> AcpiCpuData add new fields, keep these fields if old data already existed.
>
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
> Reviewed-by: Ruiyu Ni
> ---
&g
t; phase.
>
> Detail see below change for RegisterCpuFeaturesLib:
> UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to support semaphore type.
>
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Er
driver supports DXE instance and PEI instance. But
> semaphore logic
>requires Aps execute in async mode which is not supported by PEI driver.
> So CpuFeature
>PEI instance not works after this change. We plan to support async mode
> for PEI in phase
>2 for this task.
&
driver supports DXE instance and PEI instance. But
> semaphore logic
>requires Aps execute in async mode which is not supported by PEI driver.
> So CpuFeature
>PEI instance not works after this change. We plan to support async mode
> for PEI in phase
>2 for this task.
&
On 10/19/18 09:09, Zeng, Star wrote:
> Hi Laszlo,
>
> Cc Qin also. Qin and Chao are secure boot experts, I also had some talk
> with them.
>
> On 2018/10/19 5:45, Laszlo Ersek wrote:
>> Hi All,
>>
>> On 10/16/18 04:41, Star Zeng wrote:
>>> REF: https
eGuid.PcdHeapGuardPropertyMask.
>
> Cc: Star Zeng
> Cc: Michael D Kinney
> Cc: Jiewen Yao
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> MdeModulePkg/Core/Dxe/DxeMain.h
tectionPolicy).
// Since this driver will always protect memory used as page table by itself,
// there's no need to apply protection policy requested from memory service.
// So it's safe to just return EFI_SUCCESS if this time of calling is caused
// by page table memory allocation.
//
PropertyMask.
>
> Cc: Star Zeng
> Cc: Michael D Kinney
> Cc: Jiewen Yao
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> MdeModulePkg/MdeModulePkg.dec | 6 ++
> 1 file changed,
On 10/19/18 08:40, Gao, Liming wrote:
> Laszlo:
> I try to answer your question. I also include the BZ submitter
> brent.holtsc...@intel.com. Holtsclaw, please add your comments if my
> info is not enough.
>
> Thanks
> Liming
>> -Original Message-
>&g
Hi All,
On 10/16/18 04:41, Star Zeng wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=415
>
> When SetVariable() to a time based auth variable with APPEND_WRITE
> attribute, and if the EFI_VARIABLE_AUTHENTICATION_2.TimeStamp in
> the input Data is earlier than current value, it will ca
set MSRs saved in normal boot phase, sync
> semaphore logic from RegisterCpuFeaturesLib code which used for normal boot
> phase.
>
> Detail see below change for RegisterCpuFeaturesLib:
> UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to support semaphore type.
>
> Cc: Ruiy
Hi Eric,
On 10/18/18 09:34, Eric Dong wrote:
> AcpiCpuData add new fields, keep these fields if old data already existed.
>
> Cc: Ruiyu Ni
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Eric Dong
> Reviewed-by: Ruiyu Ni
driver supports DXE instance and PEI instance. But
> semaphore logic
>requires Aps execute in async mode which is not supported by PEI driver.
> So CpuFeature
>PEI instance not works after this change. We plan to support async mode
> for PEI in phase
>2 for this task.
&g
On 10/18/18 15:43, Zeng, Star wrote:
> Hi Laszlo,
>
> On 2018/10/18 21:09, Laszlo Ersek wrote:
>> On a tangent:
>>
>> On 10/18/18 04:45, Zeng, Star wrote:
>>> On 2018/10/18 2:27, Laszlo Ersek wrote:
>>
>>>>>> e62f7104-e341-6c7f-1af5-2
On 10/18/18 15:36, Gao, Liming wrote:
> Laszlo and Star:
> Thank your notes. I will add CVE number in patch subject although it
> will make subject long than 80 characters.
I agree the subject will be overlong, but I also think that including
the CVE numbers is important enough for that.
> He
On a tangent:
On 10/18/18 04:45, Zeng, Star wrote:
> On 2018/10/18 2:27, Laszlo Ersek wrote:
>>>> e62f7104-e341-6c7f-1af5-2130f161f111@redhat.com">http://mid.mail-archive.com/e62f7104-e341-6c7f-1af5-2130f161f111@redhat.com
>>> Sorry, I could not access it.
>&
On 10/18/18 05:04, Zeng, Star wrote:
> On 2018/10/16 10:06, Liming Gao wrote:
>> https://bugzilla.tianocore.org/show_bug.cgi?id=686
>>
>> Liming Gao (3):
>> MdePkg: Add more checker in UefiDecompressLib to access the valid
>> buffer only
>> IntelFrameworkModulePkg: Add more checker in Ue
Hi,
On 10/17/18 13:08, Zhaozh1x wrote:
> For the same one VOID* pcd, if the default value type of one sku is
> "unicode string", the other skus are "OtherVOID*"(ascii string or
> byte array),Then covert "unicode string" to "byte array".
>
> Contributed-under: TianoCore Contribution Agreement 1.1
+Stephano
On 10/17/18 16:58, Zeng, Star wrote:
> On 2018/10/17 21:10, Laszlo Ersek wrote:
>> I have requested earlier [1], and now I'm doing so again, that CVE fixes
>> please all mention the CVE number in the *subject line*. When people
>> look at the commit log, or
This patch add code to clear data structure
> used for stack switch to prevent such problem from happening.
>
> Cc: Eric Dong
> Cc: Laszlo Ersek
> Cc: Ruiyu Ni
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang
> ---
> Uefi
Hi Eric,
On 10/17/18 04:16, Eric Dong wrote:
> V2 changes include:
> 1. Include the change for CpuCommonFeaturesLib which used to set MSR base on
> its scope info.
> 2. Include the change for CpuS3DataDxe driver which also handle the
> AcpiCpuData data.
> 3. Update code base on feedback for V1 c
On 10/16/18 03:32, Gao, Liming wrote:
> Laszlo:
> Sorry for the delay. Your change is good.
>
> Reviewed-by: Liming Gao
>
> Thanks
> Liming
>> -Original Message-
>> From: Kinney, Michael D
>> Sent: Tuesday, October 16, 2018 3:29 AM
>&g
Hi Star,
On 10/16/18 04:41, Star Zeng wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=415
>
> When SetVariable() to a time based auth variable with APPEND_WRITE
> attribute, and if the EFI_VARIABLE_AUTHENTICATION_2.TimeStamp in
> the input Data is earlier than current value, it will
Hi Leif,
On 10/16/18 04:28, Leif Lindholm wrote:
> Laszlo: a few years ago, you also posted a _really_ useful email about
> the process of being a maintainer, and helpful workflows (like "sort
> emails to review immediately on reception, even if you don't have time
> to review now"). I have since
On 10/16/18 03:39, Dong, Eric wrote:
> Hi Laszlo,
>
> [...]
Thanks for your answers, it's all much clearer now.
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
601 - 700 of 6352 matches
Mail list logo