Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

i removed casting at r71412 thanks guys. On Fri, May 25, 2012 at 10:28 AM, Daniel Juyung Seo wrote: > 1. do not cast in this case > 2. no space for casting > yes we have some wrong formatted codes, just fix them when we find them. > On May 25, 2012 12:21 AM, "Carsten Haitzler" wrote: > >> On Thu

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

1. do not cast in this case 2. no space for casting yes we have some wrong formatted codes, just fix them when we find them. On May 25, 2012 12:21 AM, "Carsten Haitzler" wrote: > On Thu, 24 May 2012 11:12:31 -0300 Gustavo Sverzut Barbieri > said: > > > On Thu, May 24, 2012 at 11:09 AM, Carsten H

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Thu, 24 May 2012 11:12:31 -0300 Gustavo Sverzut Barbieri said: > On Thu, May 24, 2012 at 11:09 AM, Carsten Haitzler > wrote: > > On Thu, 24 May 2012 16:51:07 +0300 Tom Hacohen > > said: > > > >> On 24/05/12 16:46, Gustavo Sverzut Barbieri wrote: > >> > On Wed, May 23, 2012 at 11:38 PM, Enlig

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Thu, 24 May 2012 17:14:58 +0300 Tom Hacohen said: > On 24/05/12 17:09, Carsten Haitzler (The Rasterman) wrote: > > we've never added spaces after casts before... historically. > > > > > > I guess that depends on where in the EFL you look. :) well since most of efl comes from my formatting..

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On 24/05/12 17:09, Carsten Haitzler (The Rasterman) wrote: > we've never added spaces after casts before... historically. > > I guess that depends on where in the EFL you look. :) -- Tom. -- Live Security Virtual Confere

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Thu, May 24, 2012 at 11:09 AM, Carsten Haitzler wrote: > On Thu, 24 May 2012 16:51:07 +0300 Tom Hacohen said: > >> On 24/05/12 16:46, Gustavo Sverzut Barbieri wrote: >> > On Wed, May 23, 2012 at 11:38 PM, Enlightenment SVN >> >  wrote: >> >> >> >> Log: >> >> elementary/hoversel: fix indent >>

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Thu, 24 May 2012 16:51:07 +0300 Tom Hacohen said: > On 24/05/12 16:46, Gustavo Sverzut Barbieri wrote: > > On Wed, May 23, 2012 at 11:38 PM, Enlightenment SVN > > wrote: > >> > >> Log: > >> elementary/hoversel: fix indent > >> > >> > >> Author: hyoyoung > >> Date: 2012-05-23 19

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On 24/05/12 16:46, Gustavo Sverzut Barbieri wrote: > On Wed, May 23, 2012 at 11:38 PM, Enlightenment SVN > wrote: >> >> Log: >> elementary/hoversel: fix indent >> >> >> Author: hyoyoung >> Date: 2012-05-23 19:38:59 -0700 (Wed, 23 May 2012) >> New Revision: 71377 >> Trac: htt

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Wed, May 23, 2012 at 11:38 PM, Enlightenment SVN wrote: > > Log: > elementary/hoversel: fix indent > > > Author:       hyoyoung > Date:         2012-05-23 19:38:59 -0700 (Wed, 23 May 2012) > New Revision: 71377 > Trac:         http://trac.enlightenment.org/e/changeset/71377 > > Modified: >  tru

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Wed, 23 May 2012 18:59:34 +0900 Daniel Juyung Seo said: in this case its cleaner to do without a goto. gotos are not the best thing ever - sometimes we use them for things like try/catch exception handling and some specific cases where not using a goto would make the code much harder to read/m

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

longer are limited to 1 and 0? Should we start taking that case into account all over our code? > > -Regards, Hermet- > > -Original Message- > From: "Hyoyoung Chang" > To: "Enlightenment developer list"; > Cc: &g

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Wed, May 23, 2012 at 3:31 PM, Cedric BAIL wrote: > On Tue, May 22, 2012 at 6:02 PM, Leandro Pereira > wrote: >> On Mon, May 21, 2012 at 10:35 PM, Enlightenment SVN >> wrote: >>>    cnp_debug("Got some HTML: Checking encoding is useful\n"); >>>    data = notify->data; >>> +   char *stripstr =

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Tue, May 22, 2012 at 6:02 PM, Leandro Pereira wrote: > On Mon, May 21, 2012 at 10:35 PM, Enlightenment SVN > wrote: >>    cnp_debug("Got some HTML: Checking encoding is useful\n"); >>    data = notify->data; >> +   char *stripstr = malloc(sizeof(char) * (data->length + 1)); > > sizeof(char) is

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

6:55 Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib It's a good information thread but off topic :P raster said, in e coding style, do not need to check sizeof(char). thanks guys. On Wed, May 23, 2012 at 7:57 PM, Vincent Torri @gmail.com> wrote: > On Wed, May 23, 2012 a

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Wed, May 23, 2012 at 1:09 PM, Bluezery wrote: > 2012/5/23 Vincent Torri : >> On Wed, May 23, 2012 at 12:50 PM, Bluezery wrote: >>> 2012/5/23 Joerg Sonnenberger : On Wed, May 23, 2012 at 05:56:10PM +0900, Bluezery wrote: > 2012/5/23 Hyoyoung Chang : > > Maybe it's best time to talk

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012/5/23 Vincent Torri : > On Wed, May 23, 2012 at 12:50 PM, Bluezery wrote: >> 2012/5/23 Joerg Sonnenberger : >>> On Wed, May 23, 2012 at 05:56:10PM +0900, Bluezery wrote: 2012/5/23 Hyoyoung Chang : > Maybe it's best time to talk about sizeof(char) > > Do we need to sizeof(ch

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

It's a good information thread but off topic :P raster said, in e coding style, do not need to check sizeof(char). thanks guys. On Wed, May 23, 2012 at 7:57 PM, Vincent Torri wrote: > On Wed, May 23, 2012 at 12:50 PM, Bluezery wrote: >> 2012/5/23 Joerg Sonnenberger : >>> On Wed, May 23, 2012 at

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Wed, May 23, 2012 at 12:50 PM, Bluezery wrote: > 2012/5/23 Joerg Sonnenberger : >> On Wed, May 23, 2012 at 05:56:10PM +0900, Bluezery wrote: >>> 2012/5/23 Hyoyoung Chang : >>> > Maybe it's best time to talk about sizeof(char) >>> > >>> > Do we need to sizeof(char)? I just that is problem of cod

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012/5/23 Joerg Sonnenberger : > On Wed, May 23, 2012 at 05:56:10PM +0900, Bluezery wrote: >> 2012/5/23 Hyoyoung Chang : >> > Maybe it's best time to talk about sizeof(char) >> > >> > Do we need to sizeof(char)? I just that is problem of coding convention. >> > such as (a == 0) and (!a). >> > Is th

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Wed, May 23, 2012 at 6:59 PM, Daniel Juyung Seo wrote: > Do we really need go to here? > It looks clean but I want to avoid using goto too many places without > necessity. In this case, i think so. I don't like to use jump either. But if jump makes clear code, there's no need to avoid > > Da

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Wed, May 23, 2012 at 05:56:10PM +0900, Bluezery wrote: > 2012/5/23 Hyoyoung Chang : > > Maybe it's best time to talk about sizeof(char) > > > > Do we need to sizeof(char)? I just that is problem of coding convention. > > such as (a == 0) and (!a). > > Is there any predefined convention about thi

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

Do we really need go to here? It looks clean but I want to avoid using goto too many places without necessity. Daniel Juyung Seo (SeoZ) On Wed, May 23, 2012 at 4:31 PM, Enlightenment SVN wrote: > Log: > elementary/genlist: add short cut in item bring in calc. >  fix compress_mode documentation.

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

ot;<her...@naver.com> >> To: <enlightenment-devel@lists.sourceforge.net>; >> <enlightenment-...@lists.sourceforge.net>; >> Cc: >> Sent: 2012-05-23 (수) 10:49:24 >> Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib >> >> >&

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

d at the compile time. > > > -Original Message- > From: "ChunEon Park"<her...@naver.com> > To: <enlightenment-devel@lists.sourceforge.net>; > <enlightenment-...@lists.sourceforge.net>; > Cc: > Sent: 2012-05-23 (수) 10:49:24 > Subject: Re: [E

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

FYI, sizeof will be computed at the compile time. -Original Message- From: "ChunEon Park"<her...@naver.com> To: <enlightenment-devel@lists.sourceforge.net>; <enlightenment-...@lists.sourceforge.net>; Cc: Sent: 2012-05-23 (수) 10:49:24 Subject: Re: [E-

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

The most I prefer is to use sizeof( variable ); No harmful for performance and would be better if the buffer type is changed. -Original Message- From: "Enlightenment SVN" To: ; Cc: Sent: 2012-05-23 (수) 09:53:08 Subject: E SVN: hyoyoung trunk/elementary/src/lib Log: elementary/cnp: do

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Wed, May 23, 2012 at 1:02 AM, Leandro Pereira wrote: > On Mon, May 21, 2012 at 10:35 PM, Enlightenment SVN > wrote: >>    cnp_debug("Got some HTML: Checking encoding is useful\n"); >>    data = notify->data; >> +   char *stripstr = malloc(sizeof(char) * (data->length + 1)); > > sizeof(char) is

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

On Mon, May 21, 2012 at 10:35 PM, Enlightenment SVN wrote: >    cnp_debug("Got some HTML: Checking encoding is useful\n"); >    data = notify->data; > +   char *stripstr = malloc(sizeof(char) * (data->length + 1)); sizeof(char) is 1 by definition. Just malloc(data->length + 1). >         ddata.f

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

Yeah. u'r right. I added some checking routines. thanks PS: could you change your default mail mode to txt? or just set to not convert ">" as ">"? On Tue, May 22, 2012 at 1:22 PM, ChunEon Park wrote: > It missed simple null checking after malloc. > > > + char *stripstr = malloc(sizeof(char) * (d

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

It missed simple null checking after malloc. + char *stripstr = malloc(sizeof(char) * (data->length + 1));+ strncpy(stripstr, (char *)data->data, data->length); -Regards, Hermet- -Original Message- From: "Enlightenment SVN"

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

>>>> >>>> ------------ >>>> -Regards, Hermet- >>>> >>>> >>>> -Original Message- >>>> From: "Hyoyoung Chang"<hyoyo...@gmail.com> >>>> To: <en

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

gt;> >>> >>> -Regards, Hermet- >>> >>> >>> -----Original Message- >>> From: "Hyoyoung Chang"<hyoyo...@gmail.com> >>> To: <enlightenment-devel@lists.sourceforge.net>; >>> Cc: >

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

gt; I think we need to prevent to not go that function in advance, if the st was >> invalid. >> >> >> >> -Regards, Hermet- >> >> >> -Original Message- >> From: "Hyoyoung Chang"<hyoyo...@gma

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

orge.net>; > Cc: > Sent: 2012-05-17 (목) 13:44:26 > Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib > > Thanks, in svn - r71187 > > On Thu, May 17, 2012 at 1:39 PM, Enlightenment SVN > <no-reply>@enlightenment.org> wrote: > > Log: > > el

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

ds, Hermet- -Original Message- From: "Hyoyoung Chang"<hyoyo...@gmail.com> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2012-05-17 (목) 16:30:56 Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib On

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

com> > To: <enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2012-05-17 (목) 13:44:26 > Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib > > Thanks, in svn - r71187 > > On Thu, May 17, 2012 at 1:39 PM, Enlightenment SVN > <no-reply>@en

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

urceforge.net>; Cc: Sent: 2012-05-17 (목) 13:44:26 Subject: Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib Thanks, in svn - r71187 On Thu, May 17, 2012 at 1:39 PM, Enlightenment SVN <no-reply>@enlightenment.org> wrote: > Log: > elementary/gesture_layer: add to nu

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

Thanks, in svn - r71187 On Thu, May 17, 2012 at 1:39 PM, Enlightenment SVN wrote: > Log: > elementary/gesture_layer: add to null check at _tap_gesture_check_finish > >  Signed-off-by: Kim Shinwoo > > > Author:       hyoyoung > Date:         2012-05-16 21:39:40 -0700 (Wed, 16 May 2012) > New Revi