Re: FOP Style Guide (update)

Michael Gratton wrote: Surely: return isEnabled(); is far, far better - it more clearly expresses your intent. Err, unless you don't want to return if isEnabled() returns false.. I think I might go get that coffee now.. :( Anyway, I don't think if (isEnabled()) { r

Re: FOP Style Guide (update)

Jeremias Maerki wrote: if (isEnabled()) return true; Surely: return isEnabled(); is far, far better - it more clearly expresses your intent. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t

Re: avalon-framework lib in distribution

n't have access to the logger you give to Driver. In these cases the code logs via the static methods on MessageHandler. Note that because MessageHandler is completely (IIRC) static, you only have to set it once. Also, the logger you give it could be used concurrently. > Anyway, thanks

Re: avalon-framework lib in distribution

mpiling the Framework codebase. The solution would be to pull the Framework source code, make sure Log4J is on your CLASSPATH, and build it. Use the resulting jar instead of both avalon-framework-cvs-20020315.jar and avalon-framwork-4.1.2.jar and you should be fine. HTH, /mike -- Mich

Re: Image Source with FOPServlet

mponent as part of the transformation. I don't know how lax the JRE on Windows is WRT strict parsing of file URLs, but if you fix up all of the above, at least you'll know you're referencing your image correctly. :) HTH, /mike -- Michael Gratton <[EMAIL PROTECTED]> Re

Re: Image Cache issue - Latest Release after 0.20.3

fix if there is one out there in the wild) sometime real soon now, then this will still be a problem in the next release. Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8

[patch] fix for background image tiling

comitter please have a look at the patch and commit if happy. Cheers, Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 ? FopImageFactory.patch ? background-imag

Re: background-image patch v0.03 in CVS

rom CVS and recompiling recently? -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 smime.p7s Description: S/MIME Cryptographic Signature

Re: inital background-image patch

ound-color, background-image and background-repeat with various combinations of transparent and non-transparent images, that would be cool. Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61

Re: inital background-image patch

binaries: <http://web.vee.net/fop/background-image_0.03.patch> <http://web.vee.net/fop/fop-background-image-0.03-bin.tar.gz> <http://web.vee.net/fop/fop-background-image-0.03-bin.zip> /mike -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.co

Re: inital background-image patch

ven the spec lists the Common border, padding, and background properties as being allowed, and doesn't forbid use of the background properties in the text of the region areas. Anyway, the next version of the background-image patch should have backgrounds for the region areas working. Mike.

Re: inital background-image patch

ee.net/fop/fop-background-image-0.02-bin.zip> Cheers. Mike, -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 smime.p7s Description: S/MIME Cryptographic Signature

inital background-image patch

se *do not* use this binary in a production system. Thanks (especially for reading this far ;), Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 smime.p7s Description: S/MIME Cryptographic Signature

bugzilla usage

(as I just did for bug 5180)? Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 smime.p7s Description: S/MIME Cryptographic Signature

Logging work: patch for the trunk

copy exists in the maintanence branch) and lib/logkit-1.0.LICENSE.txt and lib/logkit-1.0.jar must be removed. Can someone please review the patch and commit when they are happy? Thanks, Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s:

implementing background-image (bug 5180)

mplementing properties in FOP, or this one in general, that I wouldn't pick up from looking at the existing code? Thanks, Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8

Re: CVS branches

ion arose from the fact that ViewCVS (which is used by cvs.apache.org) lists "MAIN" as a FOP branch. I looked at another ViewCVS installation, and that also lists "MAIN" as a branch. So I guess it's just a facet of ViewCVS. Apologies for the static. Michael. -- Michae

Re: CVS branches

ly called "the trunk", and is a special case branch. It has the symbolic name "HEAD", although you don't want to use that when checking it out. FOP actually has a branch called "MAIN", separate to the trunk (HEAD). Mike. -- Michael Gratton <[EMAIL PROT

CVS branches

nch. Further releases in the v0.20.x series (and others?) are made from this branch. Thanks, Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 smime.p7s Description: S/MIME Cryptographic Signature

Re: Logging work: MessageHandler patch

Michael Gratton wrote: > > Attached is a patch (for the 'fop-0_20_2-maintain' branch) for > MessageHandler There was a problem with MessageHandler.error() in that patch. The attached patch fixes that and makes MessageHandler.log() a bit more readable. It also inc

Logging work: examples compilation fixes

The attached patch fixes the embedding examples so they compile again. Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 Index: docs/exampl

Logging work: MessageHandler patch

ly way to fix this is AFAICT is to refactor MessageHandler's design - so that it becomes a singleton object instead of a bunch of static methods and properties. I think this is a much better design pattern, but will be a bit of work, so I'll get it done if people think it is worthwhile.

Re: Using Avalon/Logkit

ed to port it to the two other branches, and deal with both MessageHandler and ToBeImplementedProperty, then it is ready to land. I'll fix these things up sometime in the next few days.. Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/>

Re: Using Avalon/Logkit

LogEnabled and drop Loggable. Given that (according to the javadocs on the Avalon web site) LogEnabled exposes enableLogging(), not setLogger(), and does not provide an analog for getLogger(), I'd suggest leaving any classes which implement {get|set}Loggable() alone for now. Sound oka

Re: Using Avalon/Logkit

, then. Jeremias mentioned LogEnabled is replacing Loggable, is there any concensus about moving Driver over to the new interface, making it implement both, or just leaving it as-is for now? I'd suggest moving it over, if not, then implementing both. -- Michael Gratton <[EMAIL PROTEC

Re: Using Avalon/Logkit

Logger, will that patch get comitted? Or is someone already working on it? Is there a schedule for this? Thanks for sorting this out, Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217

Re: Using Avalon/Logkit

in most cases, they didn't. FOP is in the same boat. If FOP is going to be widely embedded, it needs to expose a core framework-independent and architecture-independent interface. Look, does anyone else out there agree or disagree with me? Am I flogging a dead horse? Barking up the wrong tree? Committers, am I wasting my time here? Thanks, Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 smime.p7s Description: S/MIME Cryptographic Signature

Re: Using Avalon/Logkit

g a LoggingHandler, which works *precisely* in the same way. It's the *exact* same mechanism, but for logging. If it still works with Avalon and Logkit, and works for embedders, how can you lose from such a win-win situation? Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recal

LoggingHandler patch [was: Using Avalon/Logkit]

few days and post a new patch. Provided it all works well, would anyone mind having these changes committed to the tree? Thanks, Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61

Re: Using Avalon/Logkit

thwhile as well. Again, with this sort of mechansim, you get flexibility and control, and it is very much embedding-friendly. Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 smime.p7s Description: S/MIME Cryptographic Signature

Re: Using Avalon/Logkit

iver or similar. In those cases, it would be a small change to get it working again. If no one has any other objections, I'll whip up a patch for review on the list. Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street

Re: Using Avalon/Logkit

ith this approach, I'll gladly implement it over the next few days. I hope this conveys how important I think this issue is. What does everyone say? Mike. -- Michael Gratton <[EMAIL PROTECTED]> Recall Design <http://www.recalldesign.com/> s: 53 Gilbert Street Adelaide SA 5000 Australia t: +61 8 8217 0500 f: +61 8 8217 0555 smime.p7s Description: S/MIME Cryptographic Signature