[Freeciv-Dev] [bug #25252] Qt client: Map drawing very slow when unit is focused

2016-11-01 Thread Louis Moureaux
Follow-up Comment #2, bug #25252 (project freeciv): > That was experimental ruleset, right ? No, Civ2Civ3. > Have u tried gtk3 with experimental too ? Actually I continued playing the very same game for hours using the Gtk3 client, without problem. __

[Freeciv-Dev] [bug #25252] Qt client: Map drawing very slow when unit is focused

2016-11-01 Thread Louis Moureaux
URL: Summary: Qt client: Map drawing very slow when unit is focused Project: Freeciv Submitted by: louis94 Submitted on: mar. 01 nov. 2016 18:14:37 UTC Category: client-qt Sever

[Freeciv-Dev] [bug #25169] Qt client: "QColor::setAlpha": invalid value -14

2016-10-11 Thread Louis Moureaux
URL: Summary: Qt client: "QColor::setAlpha": invalid value -14 Project: Freeciv Submitted by: louis94 Submitted on: mar. 11 oct. 2016 13:40:21 UTC Category: client-qt Severity:

[Freeciv-Dev] [bug #25168] Qt client : Crash in QAbstractButton::click() when closing hud_message_box with ESC

2016-10-11 Thread Louis Moureaux
URL: Summary: Qt client : Crash in QAbstractButton::click() when closing hud_message_box with ESC Project: Freeciv Submitted by: louis94 Submitted on: mar. 11 oct. 2016 13:37:55 UTC Category: c

[Freeciv-Dev] [patch #7731] Tilespec: darkness_layer vs layer_order

2016-10-07 Thread Louis Moureaux
Follow-up Comment #5, patch #7731 (project freeciv): > Is this intentional? If yes: why? Were I a teacher, I would say I was testing your reviewing capabilities... Since I'm not, let me say I'm impressed by them. > Maybe mention what value of darkness_layer makes the defaults handle it? *darkness

[Freeciv-Dev] [patch #7731] Tilespec: darkness_layer vs layer_order

2016-10-06 Thread Louis Moureaux
Follow-up Comment #3, patch #7731 (project freeciv): Ready Set Nitpick ! Proposed wording for Wikia: *darkness_layer* was merged into the new *layer_order* tag. See the bundled tilesets for how to use it. (file #28926) ___ Additional Item

[Freeciv-Dev] [patch #7731] Tilespec: darkness_layer vs layer_order

2016-09-26 Thread Louis Moureaux
Follow-up Comment #1, patch #7731 (project freeciv): I think the most consistent way is to go for a standard layer. In the end, darkness_layer is a hack to allow for some customization of the drawing order. layer_order is more flexible and scales better. Is backwards compatibility needed/preferre

[Freeciv-Dev] [bug #25125] Qt client: City dialog is closed when applying font options changes

2016-09-25 Thread Louis Moureaux
URL: Summary: Qt client: City dialog is closed when applying font options changes Project: Freeciv Submitted by: louis94 Submitted on: dim. 25 sept. 2016 19:21:42 UTC Category: client-qt

[Freeciv-Dev] [bug #25023] Qt client: Not all fonts are updated when changed in the settings

2016-09-25 Thread Louis Moureaux
Follow-up Comment #1, bug #25023 (project freeciv): Situation in 2.6 and trunk after patch #33883 (only listing changes I found by reading the patch): Newly updated: * notify_dialog (Demographics Report and such) * tech tree Not updated anymore: * QLabel *tb in help_widget::add_extras_of_act_for_

[Freeciv-Dev] [bug #25098] Qt cli3nt - fix font mess

2016-09-21 Thread Louis Moureaux
Follow-up Comment #3, bug #25098 (project freeciv): Two patches: *trunk* (qt-fix-default-font.patch) fixes default_font and a memory leak accidentally introduced in cazfi's cleanup *S2_6* (qt-fix-default-font-and-chat-s26.patch) font_updater wasn't working at all, I don't know how I managed to sen

[Freeciv-Dev] [bug #25098] Qt cli3nt - fix font mess

2016-09-21 Thread Louis Moureaux
Follow-up Comment #2, bug #25098 (project freeciv): Weirdly, the chat font is updated in trunk but not in S2_6. Will investigate, the fix will most probably be easy. (file #28710) ___ Additional Item Attachment: File name: qt-fix-default-f

[Freeciv-Dev] [bug #25098] Qt cli3nt - fix font mess

2016-09-21 Thread Louis Moureaux
Follow-up Comment #1, bug #25098 (project freeciv): Please give me a chance to fix my code before just removing it :'( It took me 3 weeks to get there and I fixed quite a few bugs along the way... Had a quick look before leaving for work: default_font: it's just misnamed at fonts.h:37 - const c

[Freeciv-Dev] [patch #7704] Don't use deprecated QAbstractItemDelegateV2 and QAbstractItemDelegateV3

2016-09-19 Thread Louis Moureaux
URL: Summary: Don't use deprecated QAbstractItemDelegateV2 and QAbstractItemDelegateV3 Project: Freeciv Submitted by: louis94 Submitted on: lun. 19 sept. 2016 22:04:50 UTC Category: client-qt

[Freeciv-Dev] [patch #7696] Qt client - add themes support

2016-09-18 Thread Louis Moureaux
Follow-up Comment #10, patch #7696 (project freeciv): > Hey, there are *.png blobs in source. I think its also violation. I think this may indeed be true, but PNGs are editable in just any graphics editor, and nobody can prove there is a layered file somewhere (while at least the C code from file

[Freeciv-Dev] [patch #7696] Qt client - add themes support

2016-09-18 Thread Louis Moureaux
Follow-up Comment #8, patch #7696 (project freeciv): > Not going to happen, This makes me feel really sad. Free software is based on collaboration, and sharing the source is required to achieve that. > I'll put gzipped C source to data/graphics if it makes u happy. As that source code (1) can't b

[Freeciv-Dev] [patch #7696] Qt client - add themes support

2016-09-17 Thread Louis Moureaux
Follow-up Comment #4, patch #7696 (project freeciv): Sorry if my post sounded rude, it was not my intention. I was writing under time constraint. > If u have compiled resource u dont need source. U can decompile if u need anyway. I didn't find a way to disassemble compiled resource files (won't o

[Freeciv-Dev] [patch #7696] Qt client - add themes support

2016-09-17 Thread Louis Moureaux
Follow-up Comment #1, patch #7696 (project freeciv): The resource.rcc file looks like a binary blob. Did I miss the source? Else: - The help text is hard to read (white on light background) - Some colors still come from the system palette (selection text and background). What about a custom QPale

[Freeciv-Dev] [patch #7667] Add ability to configure the order layers are drawn in

2016-09-15 Thread Louis Moureaux
Follow-up Comment #16, patch #7667 (project freeciv): >> Out of curiosity: which ones? MSVC? Older GCC? > GCC 6.1.1 (Debian testing). Probably a warning that becomes an error because debug is enabled. Still here with GCC 6.2 (Arch), should have noticed it. > Nitpick: A lovely newline is missing a

[Freeciv-Dev] [patch #7667] Add ability to configure the order layers are drawn in

2016-09-15 Thread Louis Moureaux
Follow-up Comment #14, patch #7667 (project freeciv): > this is quite performance critical code The code path you're talking about is the rendering of the selected tile in the editor dialog (3 calls). I don't think it's critical enough to deserve the additional complexity. >> log_error("%s ", map

[Freeciv-Dev] [patch #7667] Add ability to configure the order layers are drawn in

2016-09-14 Thread Louis Moureaux
Follow-up Comment #11, patch #7667 (project freeciv): > "int j" [...] FALSE Fixed > I think the CATEGORY_ prefix is taken. Yes, in options stuff. Changed to LAYER_CATEGORY_. Good catch for a first look :-) (file #28622) ___ Additional Item

[Freeciv-Dev] [patch #7667] Add ability to configure the order layers are drawn in

2016-09-14 Thread Louis Moureaux
Follow-up Comment #9, patch #7667 (project freeciv): Removed the lovely newline, fixed all three Gtk clients, applied patch #7688 (file #28619) ___ Additional Item Attachment: File name: client-configure-layer-order-1.patch.bz2 Size:3 KB

[Freeciv-Dev] [patch #7688] doc/CodingStyle clarification: on top of scope

2016-09-14 Thread Louis Moureaux
Follow-up Comment #1, patch #7688 (project freeciv): Don't forget to update Wikia too. ___ Reply to this item at: ___ Message posté via/par Gna! http://gna.org

[Freeciv-Dev] [patch #7667] Add ability to configure the order layers are drawn in

2016-09-13 Thread Louis Moureaux
Follow-up Comment #5, patch #7667 (project freeciv): Thanks for the review. > Will the Gtk client's editprop.c draw the layers in the correct order? No, as I said create_tile_pixbuf will need an update. I wasn't sure I was supposed do it in the same patch, because this is "client" category (and n

[Freeciv-Dev] [patch #7667] Add ability to configure the order layers are drawn in

2016-09-12 Thread Louis Moureaux
Follow-up Comment #1, patch #7667 (project freeciv): Up -- anybody ? ___ Reply to this item at: ___ Message posté via/par Gna! http://gna.org/ __

[Freeciv-Dev] [bug #25022] Qt client: Unused font options

2016-09-05 Thread Louis Moureaux
Follow-up Comment #2, bug #25022 (project freeciv): If we change that much, let's go the other way around and define what we keep. *General fonts* * Default * Mono -- for text formatted in ASCII-art, excluding help content * Title -- a bigger, bold font *Map fonts* * City name * City production

[Freeciv-Dev] [patch #7670] Qt client: Update the font database for all fonts

2016-09-04 Thread Louis Moureaux
URL: Summary: Qt client: Update the font database for all fonts Project: Freeciv Submitted by: louis94 Submitted on: dim. 04 sept. 2016 21:29:38 UTC Category: client-qt Priority

[Freeciv-Dev] [patch #7667] Add ability to configure the order layers are drawn in

2016-09-02 Thread Louis Moureaux
URL: Summary: Add ability to configure the order layers are drawn in Project: Freeciv Submitted by: louis94 Submitted on: sam. 03 sept. 2016 00:02:32 UTC Category: client Priori

[Freeciv-Dev] [patch #7664] Qt client - added configurable shortcuts

2016-08-30 Thread Louis Moureaux
Follow-up Comment #1, patch #7664 (project freeciv): Great to see some move on this old (I think) feature request :-) Tested it quickly, mostly because I was interested by how you implemented it (I though it would be more difficult). Noticed the following: * It's not fully localized: Germans use

[Freeciv-Dev] [bug #25023] Qt client: Not all fonts are updated when changed in the settings

2016-08-29 Thread Louis Moureaux
URL: Summary: Qt client: Not all fonts are updated when changed in the settings Project: Freeciv Submitted by: louis94 Submitted on: mar. 30 août 2016 00:00:33 UTC Category: client-qt

[Freeciv-Dev] [bug #25022] Qt client: Unused font options

2016-08-29 Thread Louis Moureaux
URL: Summary: Qt client: Unused font options Project: Freeciv Submitted by: louis94 Submitted on: lun. 29 août 2016 23:38:11 UTC Category: client-qt Severity: 3 - Normal

[Freeciv-Dev] [patch #7663] Qt client: Remove old font system

2016-08-29 Thread Louis Moureaux
URL: Summary: Qt client: Remove old font system Project: Freeciv Submitted by: louis94 Submitted on: lun. 29 août 2016 23:31:10 UTC Category: client-qt Priority: 5 - Normal

[Freeciv-Dev] [patch #7662] Qt client: Use new font system in self-drawing classes

2016-08-29 Thread Louis Moureaux
URL: Summary: Qt client: Use new font system in self-drawing classes Project: Freeciv Submitted by: louis94 Submitted on: lun. 29 août 2016 23:20:19 UTC Category: client-qt Prio

[Freeciv-Dev] [patch #7661] Qt client: Use font_updater wherever possible

2016-08-29 Thread Louis Moureaux
URL: Summary: Qt client: Use font_updater wherever possible Project: Freeciv Submitted by: louis94 Submitted on: lun. 29 août 2016 22:22:43 UTC Category: client-qt Priority: 5 -

[Freeciv-Dev] [patch #7660] Qt client: Use new font system in canvas-related classes.

2016-08-29 Thread Louis Moureaux
URL: Summary: Qt client: Use new font system in canvas-related classes. Project: Freeciv Submitted by: louis94 Submitted on: lun. 29 août 2016 21:54:12 UTC Category: client-qt P

[Freeciv-Dev] [patch #7659] Add listener for fonts

2016-08-28 Thread Louis Moureaux
URL: Summary: Add listener for fonts Project: Freeciv Submitted by: louis94 Submitted on: dim. 28 août 2016 23:11:40 UTC Category: client-qt Priority: 5 - Normal

[Freeciv-Dev] [patch #7617] Qt client - added sidebar

2016-08-25 Thread Louis Moureaux
Follow-up Comment #3, patch #7617 (project freeciv): Please include the .kra files somewhere in the tree. They should be considered as the source "code" (as per the GPL) because they are easier to modify than bare PNGs. The source kra for nations.png contains hidden unneeded material that could (

[Freeciv-Dev] [bug #25017] Qt client - menu in pregame page doesnt work

2016-08-25 Thread Louis Moureaux
Follow-up Comment #1, bug #25017 (project freeciv): Fixed. Was an unwanted side-effect of migration to chat_listener. (file #28530) ___ Additional Item Attachment: File name: fix-pregame-menu-trunk.patch Size:1 KB _

[Freeciv-Dev] [patch #7647] Qt client: Factor chat input out of fc_client

2016-08-22 Thread Louis Moureaux
Additional Item Attachment, patch #7647 (project freeciv): File name: qt-cleanup-chat-input.patch.bz2 Size:4 KB ___ Reply to this item at: ___ Message posté via

[Freeciv-Dev] [patch #7647] Qt client: Factor chat input out of fc_client

2016-08-22 Thread Louis Moureaux
URL: Summary: Qt client: Factor chat input out of fc_client Project: Freeciv Submitted by: louis94 Submitted on: lun. 22 août 2016 16:34:13 UTC Category: client-qt Priority: 5 -

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

2016-08-21 Thread Louis Moureaux
Follow-up Comment #9, patch #7491 (project freeciv): Oops, I realize my last post lacked the patch... Here it is, along with the 2.6 version. (file #28475, file #28476) ___ Additional Item Attachment: File name: qt-cleanup-chatline-helper-

[Freeciv-Dev] [patch #7617] Qt client - added sidebar

2016-08-20 Thread Louis Moureaux
Follow-up Comment #1, patch #7617 (project freeciv): Wanna give it a try, but… mapview.cpp:49:21: fatal error: sidebar.h : No such file or directory #include "sidebar.h" ie sidebar.h/.cpp are not in the patch. ___ Reply to this item at:

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-13 Thread Louis Moureaux
Follow-up Comment #10, bug #24935 (project freeciv): Thank you Gtk for giving us a well-tested client :-) Fixed Maybe the SDL client has the same problem (file #28287, file #28288) ___ Additional Item Attachment: File name: qt-metaserver-

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-13 Thread Louis Moureaux
Follow-up Comment #8, bug #24935 (project freeciv): > Is that still server_scan_finish() call Yes Using gdb to watch meta_scan, I could see the metaserver thread nulling it just before the crash. I think what happens is: - [metaserver thread] server_scan_error() is called - [meta] server_scan_err

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

2016-08-13 Thread Louis Moureaux
Follow-up Comment #7, patch #7491 (project freeciv): Going forward here because the client isn't heavily multithreaded. I let qtg_version_message to bug #24935, and handle the single-threaded part of the chat. The patch is for trunk only, I'll make one for 2.6 once you deem it ready. ___

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-13 Thread Louis Moureaux
Follow-up Comment #6, bug #24935 (project freeciv): > Its only visible when metaserver is up but returning errors. Also fixed this one. To test, I modified default_server_host in client config file to some random URL not allowing POST. The error appears in the status bar. It won't appear in chat,

[Freeciv-Dev] [bug #24831] WARNING **: invalid source position for vertical gradient

2016-08-12 Thread Louis Moureaux
Follow-up Comment #3, bug #24831 (project freeciv): This looks like a warning from the Gtk pixbuf theme engine. So my bet is QGtkStyle. ___ Reply to this item at:

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-12 Thread Louis Moureaux
Follow-up Comment #4, bug #24935 (project freeciv): The patch is still not thread-safe because the main thread accesses the status bar QLabel without locking mut_ex. Attached patch is thread-safe *unless* the version message can be received after either gui() or the QApplication are destroyed (ne

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

2016-08-12 Thread Louis Moureaux
Follow-up Comment #6, patch #7491 (project freeciv): > I don't know the threading model well enough After investigation, it looks like the client is a single-threaded application, except for the metaserver queries. ___ Reply to this item at

[Freeciv-Dev] [bug #24965] Tooltips in Remote Server Options Control Dialog may flicker

2016-08-12 Thread Louis Moureaux
Follow-up Comment #2, bug #24965 (project freeciv): If the tooltip is very big, it may pop up below the mouse. Then the widget gets a "mouse leaved" event and hides the tooltip. Thus it gets a "mouse entered" event... I can get a similar behavior with the Qt client and very big fonts. Possible so

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

2016-08-11 Thread Louis Moureaux
Follow-up Comment #5, patch #7491 (project freeciv): > And u put that in chat, which gets messages from other threads. I don't know the threading model well enough. I added this FIXME because: * The current client code isn't at all thread-safe (!) * There's a mutex in the common chat code, which

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-11 Thread Louis Moureaux
Follow-up Comment #2, bug #24935 (project freeciv): The proposed fix isn't thread-safe, because the underlying Qt classes (QStringList, QLabel) are not. You need a synchronization primitive (a mutex or some kind of atomic variable). Thread-safety is easier to get right when using Qt signals togeth

[Freeciv-Dev] [bug #24961] Client freezes when connecting to local server

2016-08-11 Thread Louis Moureaux
Follow-up Comment #5, bug #24961 (project freeciv): > U need to wait some time. Indeed, connection happens after >1min. That's a long delay for a local server... but technically it works. I'm quite sure Windows will ask you to kill an app remaining unresponsive for such a long time. ___

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

2016-08-11 Thread Louis Moureaux
Follow-up Comment #3, patch #7491 (project freeciv): Version (hopefully) without C++11. (file #28268) ___ Additional Item Attachment: File name: qt-cleanup-chatline-helper-v3.patch.bz2 Size:3 KB __

[Freeciv-Dev] [patch #7490] Qt client: Add class to ease wrapping the C API

2016-08-11 Thread Louis Moureaux
Follow-up Comment #6, patch #7490 (project freeciv): Now not only one can #include it, but actually use it too. I missed a few *... (file #28267) ___ Additional Item Attachment: File name: listener.h-3.bz2 Size:1 KB ___

[Freeciv-Dev] [patch #7490] Qt client: Add class to ease wrapping the C API

2016-08-11 Thread Louis Moureaux
Follow-up Comment #5, patch #7490 (project freeciv): > Pls use gcc-config to switch to gcc 5.x I need C++11 for Qt 5.7 anyway, else I would do --std=c++98. I checked this one to be valid C++ 98. I didn't find all uses of C++ 11 in my previous code, sorry about it. I'll write C++ 98 directly for

[Freeciv-Dev] [bug #24961] Client freezes when connecting to local server

2016-08-11 Thread Louis Moureaux
Follow-up Comment #3, bug #24961 (project freeciv): Pinging myself works when using localhost, fails with "Destination unreachable: Port unreachable" when using (no freeze). Using traceroute reveals localhost is 127.0.0.1 as usual, and is 192.168.1.x (ie LAN address). Entering either IP address

[Freeciv-Dev] [bug #24961] Client freezes when connecting to local server

2016-08-10 Thread Louis Moureaux
URL: Summary: Client freezes when connecting to local server Project: Freeciv Submitted by: louis94 Submitted on: jeu. 11 août 2016 01:26:10 UTC Category: client Severity: 3 - N

[Freeciv-Dev] [patch #7490] Qt client: Add class to ease wrapping the C API

2016-08-10 Thread Louis Moureaux
Follow-up Comment #3, patch #7490 (project freeciv): Same class without C++11, and renamed to "listener", which is more specific. The API has changed a bit and now requires the listener to register once it's ready. Please reopen. (file #28256)

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Louis Moureaux
Follow-up Comment #10, bug #24942 (project freeciv): (In the code below, #0x050700 should read 0x050700. Habit from CSS: every hex number begins with #... Sorry) ___ Reply to this item at: __

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Louis Moureaux
Follow-up Comment #9, bug #24942 (project freeciv): > For the C++11 problem, would something as simple as attached patch work? Such a patch would work. On the other hand, one would need Debian Wheezy or Ubuntu 12.04 to compile Freeciv without C++11 support. This would make it more difficult to che

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Louis Moureaux
Follow-up Comment #7, bug #24942 (project freeciv): I checked Kde Neon Developer Edition, which ships Qt 5.7 on a Ubuntu 14.04-based system. The default compiler there is GCC 5.4, which defaults to C++98. With my patch, freeciv configures fine but build fails (in Qt) as if std::nullptr_t == int. I

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Louis Moureaux
Follow-up Comment #5, bug #24942 (project freeciv): Devil is in the details. Really works now... (file #28240) ___ Additional Item Attachment: File name: qt-use-pkg-config-2.patch.bz2 Size:1 KB __

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-10 Thread Louis Moureaux
Follow-up Comment #3, bug #24942 (project freeciv): Attached patch uses pkg-config to discover Qt and sets --std=c++11 if needed. Besides MSVC, I don't know of compilers using other flags. I didn't use --std=c++0x because it enabled *experimental* C++11 support and is deprecated in recent GCC. Th

[Freeciv-Dev] [bug #24942] Configure fails with clang 3.8 and Qt 5.7

2016-08-08 Thread Louis Moureaux
Follow-up Comment #2, bug #24942 (project freeciv): Would Freeciv need such "system consistency", it should check for it and provide a helpful error message, just like for regular dependencies. So it's not that easy to implement. As Qt needs C++11 for all versions >= 5.7.0, the version alone is e

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

2016-07-21 Thread Louis Moureaux
Follow-up Comment #1, patch #7491 (project freeciv): New patch with: * Most chat handling done in chat_helper * Renamed listener function to match wording of Qt slots and Java listeners * Private inheritance (has-a relationship) instead of public inheritance (is-a relationship) * Still some to-be-

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

2016-07-20 Thread Louis Moureaux
URL: Summary: Qt client: Use helper<> to propagate output_window_append Project: Freeciv Submitted by: louis94 Submitted on: jeu. 21 juil. 2016 02:35:58 UTC Category: client-qt

[Freeciv-Dev] [patch #7490] Qt client: Add class to ease wrapping the C API

2016-07-20 Thread Louis Moureaux
URL: Summary: Qt client: Add class to ease wrapping the C API Project: Freeciv Submitted by: louis94 Submitted on: jeu. 21 juil. 2016 01:46:45 UTC Category: client-qt Priority:

[Freeciv-Dev] [patch #7489] Qt client: New layout for pregame_options, button to pick nation

2016-07-19 Thread Louis Moureaux
URL: Summary: Qt client: New layout for pregame_options, button to pick nation Project: Freeciv Submitted by: louis94 Submitted on: mer. 20 juil. 2016 00:22:31 UTC Category: client-qt

[Freeciv-Dev] [patch #7487] Client: Function to get nation shields

2016-07-19 Thread Louis Moureaux
URL: Summary: Client: Function to get nation shields Project: Freeciv Submitted by: louis94 Submitted on: mar. 19 juil. 2016 18:51:43 UTC Category: client Priority: 5 - Normal

[Freeciv-Dev] [patch #7486] Qt client: Use encapsulation in class pregame_options

2016-07-19 Thread Louis Moureaux
URL: Summary: Qt client: Use encapsulation in class pregame_options Project: Freeciv Submitted by: louis94 Submitted on: mar. 19 juil. 2016 14:43:41 UTC Category: client-qt Prio

[Freeciv-Dev] [patch #7485] Qt client: Use QFormLayout instead of QGridLayout in PAGE_START

2016-07-19 Thread Louis Moureaux
URL: Summary: Qt client: Use QFormLayout instead of QGridLayout in PAGE_START Project: Freeciv Submitted by: louis94 Submitted on: mar. 19 juil. 2016 14:36:31 UTC Category: client-qt

[Freeciv-Dev] [patch #7484] Qt client: Remove unused object from fc_client

2016-07-19 Thread Louis Moureaux
URL: Summary: Qt client: Remove unused object from fc_client Project: Freeciv Submitted by: louis94 Submitted on: mar. 19 juil. 2016 14:21:49 UTC Category: client-qt Priority: 5

[Freeciv-Dev] [bug #24810] Compilation warning with GCC 6.1

2016-06-28 Thread Louis Moureaux
Follow-up Comment #2, bug #24810 (project freeciv): Sorry. It's current trunk, with the following configure options: --enable-client=qt --enable-fcmp=qt --with-qt5-includes=/usr/include/qt --no-create --no-recursion I'm on Arch Linux. ___

[Freeciv-Dev] [bug #15132] Civilopedia display matching image terrain, not just words

2016-06-27 Thread Louis Moureaux
Follow-up Comment #5, bug #15132 (project freeciv): Btw, the Qt client already has this feature. The logic is around line 800 of client/gui-qt/helpdlg.cpp, in static function terrain_canvas. Only two lines depend on Qt, so generalizing it should be straightforward. If given one, the code can also

[Freeciv-Dev] [bug #24810] Compilation warning with GCC 6.1

2016-06-27 Thread Louis Moureaux
URL: Summary: Compilation warning with GCC 6.1 Project: Freeciv Submitted by: louis94 Submitted on: mar. 28 juin 2016 00:24:56 UTC Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #24668] "Username is null" after having closed the "Welcome" popup

2016-05-13 Thread Louis Moureaux
URL: Summary: "Username is null" after having closed the "Welcome" popup Project: Freeciv Submitted by: louis94 Submitted on: ven. 13 mai 2016 17:26:45 UTC Category: freeciv-web

[Freeciv-Dev] [bug #24373] Goto turn number is not always legible with Trident tileset

2016-01-31 Thread Louis Moureaux
URL: Summary: Goto turn number is not always legible with Trident tileset Project: Freeciv Submitted by: louis94 Submitted on: dim. 31 janv. 2016 18:30:31 UTC Category: None Sev

[Freeciv-Dev] [bug #24007] Layout problem on right/bottom corner

2015-11-02 Thread Louis Moureaux
Follow-up Comment #3, bug #24007 (project freeciv): This issue was revealed by patch for bug #23963. The attached patch shows how to fix it (at least in trunk), but exposes another problem due to manual widget layout. Apply with -p1. (file #25564) _

[Freeciv-Dev] [bug #24007] Layout problem on right/bottom corner

2015-11-02 Thread Louis Moureaux
Follow-up Comment #2, bug #24007 (project freeciv): The layout issue is caused by gui()->game_info_label being too small. I don't know why yet, but will investigate. ___ Reply to this item at: __

[Freeciv-Dev] [bug #23993] Clang 3.7 warnings in trunk

2015-10-27 Thread Louis Moureaux
URL: Summary: Clang 3.7 warnings in trunk Project: Freeciv Submitted by: louis94 Submitted on: mar. 27 oct. 2015 21:31:48 UTC Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #23986] Compiling with clang spawns a lot of warnings

2015-10-26 Thread Louis Moureaux
URL: Summary: Compiling with clang spawns a lot of warnings Project: Freeciv Submitted by: louis94 Submitted on: mar. 27 oct. 2015 00:24:12 UTC Category: None Severity: 3 - Norm

[Freeciv-Dev] [bug #23363] Qt-client help wrong in respect to extras (>= S2_6)

2015-05-10 Thread Louis Moureaux
Follow-up Comment #1, bug #23363 (project freeciv): Updated dialog. I'm not sure the wording will make sense with every ruleset, but otherwise it should work -- if I got it right. (file #24477, file #24478) ___ Additional Item Attachment:

[Freeciv-Dev] [bug #23385] Qt: City Production Status Bar Causes Eyestrain

2015-05-10 Thread Louis Moureaux
Follow-up Comment #1, bug #23385 (project freeciv): This is most likely a problem with Qt and/or the widget style used, and has nothing to do with the Freeciv code. ___ Reply to this item at: ___

Re: [Freeciv-Dev] Raw Data from The Battle of 100 Freeciv AIs

2015-05-03 Thread Louis Moureaux
Le dimanche 3 mai 2015, 21:07:33 Andreas Røsdal a écrit : > > I enjoyed your blog about the 100 Freeciv AIs - really cool stuff! > > Thanks! > > > Would it be possible for you to send me the data you used to make the > > awesome line graphs? If I managed to get any nice visualisations done I'd >

[Freeciv-Dev] [bug #23413] After some runtime, drawing of windows and menues gets broken

2015-03-27 Thread Louis Moureaux
Follow-up Comment #5, bug #23413 (project freeciv): Does this happen when using a theme other than 'Freeciv’ ? Change it in the client settings dialog. ___ Reply to this item at:

[Freeciv-Dev] [patch #5071] [Metaticket] Help updates for gen-extras

2015-03-07 Thread Louis Moureaux
Follow-up Comment #2, patch #5071 (project freeciv): The Qt client has "Irrigation: Grassland in 15 turns" or "Irrigation: +1 food in 15 turns". An easy way to go would be using "Irrigation: Depends, see text". We could also list possible extras (adding links and updating the related help accordin

[Freeciv-Dev] [bug #23341] Cannot center the map while in click-and-drag goto mode

2015-03-01 Thread Louis Moureaux
URL: Summary: Cannot center the map while in click-and-drag goto mode Project: Freeciv Submitted by: louis94 Submitted on: lun. 02 mars 2015 00:12:07 UTC Category: client Severi

[Freeciv-Dev] [bug #23274] C++-style TRANS comments not picked up in po-files

2015-02-27 Thread Louis Moureaux
Follow-up Comment #12, bug #23274 (project freeciv): I tried giving two --add-comments parameters to xgettext 0.18.1 from Debian Wheezy (stable, my reference for old-but-still-in-use packages), and (only) the second one was used. So adding them to XGETTEXT_OPTIONS should't be a problem if we don't

[Freeciv-Dev] [bug #23328] Gtk and SDL clients do not refresh (all) indicators when the tileset changes

2015-02-26 Thread Louis Moureaux
URL: Summary: Gtk and SDL clients do not refresh (all) indicators when the tileset changes Project: Freeciv Submitted by: louis94 Submitted on: jeu. 26 févr. 2015 23:47:57 UTC Category: None

[Freeciv-Dev] [bug #23327] [Qt client] Won't update the unit and tile icons when tileset changes

2015-02-26 Thread Louis Moureaux
URL: Summary: [Qt client] Won't update the unit and tile icons when tileset changes Project: Freeciv Submitted by: louis94 Submitted on: jeu. 26 févr. 2015 23:25:50 UTC Category: client-qt

[Freeciv-Dev] [bug #23326] [Qt client] Dangling pointers when switching tileset

2015-02-26 Thread Louis Moureaux
URL: Summary: [Qt client] Dangling pointers when switching tileset Project: Freeciv Submitted by: louis94 Submitted on: jeu. 26 févr. 2015 23:17:48 UTC Category: None Severity:

[Freeciv-Dev] [bug #23325] Qt black-on-black tooltip

2015-02-26 Thread Louis Moureaux
URL: Summary: Qt black-on-black tooltip Project: Freeciv Submitted by: louis94 Submitted on: jeu. 26 févr. 2015 22:35:38 UTC Category: client-qt Severity: 3 - Normal

[Freeciv-Dev] [bug #23274] C++-style TRANS comments not picked up in po-files

2015-02-26 Thread Louis Moureaux
Follow-up Comment #9, bug #23274 (project freeciv): > I can't reproduce. > I have TRANS: comments. Hadn't run configure since the patch, hence my problem. > The translations/freeciv/Makefile has "--add-comment=TRANS:", > as set by configure command "fc_default-4". > sed-magic to do that last tou

[Freeciv-Dev] [patch #5704] Meta ticket: Improve client user friendliness.

2015-02-23 Thread Louis Moureaux
Follow-up Comment #10, patch #5704 (project freeciv): For the posterity, the forum thread is at http://forum.freeciv.org/f/viewtopic.php?f=14&t=516 There weren't many answers, I think my post was too long. I'd wait a few days and go ahead here. Maybe we should split this ticket into several, mayb

[Freeciv-Dev] [bug #23274] C++-style TRANS comments not picked up in po-files

2015-02-17 Thread Louis Moureaux
Follow-up Comment #3, bug #23274 (project freeciv): >> My fault, I turned them to C-style comments. > This will obviously fix the problem, but since // comments are allowed and natural > in C++ code, I wondered if there was something wrong with our string-gathering, or > something that could be d

[Freeciv-Dev] [bug #23274] C++-style TRANS comments not picked up in po-files

2015-02-16 Thread Louis Moureaux
Follow-up Comment #1, bug #23274 (project freeciv): My fault, I turned them to C-style comments. To avoid this in the future, how can I generate the .pot file ? These two patches will conflict with those of bug #23284. (file #23839, file #23840) __

[Freeciv-Dev] [bug #23282] Qt-client having string "Load" meaning both loading to a ferry and loading a game

2015-02-16 Thread Louis Moureaux
Follow-up Comment #1, bug #23282 (project freeciv): Added patches changing the string used on the scenario loading button. (file #23837, file #23838) ___ Additional Item Attachment: File name: qt-load-string.patch Size:0 KB File

[Freeciv-Dev] [bug #23284] Qt-client help claims that mines produce food instead of shields

2015-02-16 Thread Louis Moureaux
Follow-up Comment #1, bug #23284 (project freeciv): Patches for S2_5, S2_6 and trunk. (file #23835, file #23836) ___ Additional Item Attachment: File name: qt-help-dialog-strings.patch Size:0 KB File name: qt-help-dialog-strings-s25.patc

Re: [Freeciv-Dev] Touch stylus optimized version???

2015-02-11 Thread Louis Moureaux
Le jeudi 12 février 2015, 01:32:42 Andrey Kazurov a écrit : > Hey > > I was trying to play latest beta of freeciv and I found that it's > absolutely not suitable for windows tablet with a stylus! > > When I put a stylus close to the edges of the screen (but not touching the > screen though) I nee

[Freeciv-Dev] [bug #21851] Possible memory leak in S2_5 (in X server?)

2015-02-01 Thread Louis Moureaux
Follow-up Comment #15, bug #21851 (project freeciv): I can reproduce the leak in the X server (1.16.3, Arch version) with Freeciv 2.4.4 (Gtk 2 client). As far as I remember, this problem has been around for a long time (all I can say is it was likely not present before Amplio became the default).

  1   2   >