Re: [gem5-dev] Review Request 3784: sim,kvm,arm: fix typos

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3784/#review9255 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m

Re: [gem5-dev] Review Request 3783: mem: Update DRAM configuration names

2017-01-18 Thread Jason Lowe-Power
timing definitions to new files in the config/ directory? - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m., Curtis Dunham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

[gem5-dev] Ideas for sprint projects

2017-01-17 Thread Jason Lowe-Power
Hi gem5 Developers! As you're probably aware, I'm going to be running a gem5 coding sprint in the afternoon after the Learning gem5 tutorial at HPCA on Sunday Feb 5. I'm looking for ideas for small projects that could be started (or even better, completed) in a few hours. Do you have any small

Re: [gem5-dev] Vector register file

2017-01-16 Thread Jason Lowe-Power
Hi Rekai, I too would love to see someone knowledgeable in other architectures, especially x86, take a look at these patches. Unfortunately, I'm not sure who we have around that either has the knowledge to do this, or has the time. I'll take a stab at it soon, though I don't know much about the

Re: [gem5-dev] Review Request 3779: proto: Fix warnings for protoc v3

2017-01-15 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3779/#review9247 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 10, 2017, 11:01 a.m

Re: [gem5-dev] Review Request 3770: python: Move native wrappers to the _m5 namespace

2016-12-20 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3770/#review9219 --- Ship it! - Jason Lowe-Power On Dec. 20, 2016, 8:10 a.m., Andreas

Re: [gem5-dev] Review Request 3722: cpu: change comments in tournament branch predictor to reflect what the code does

2016-12-19 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3722/#review9217 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 18, 2016, 1:01 p.m

[gem5-dev] gem5 Governance

2016-12-16 Thread Jason Lowe-Power
Hello gem5 community, First, I would like to thank all of our users. You are "the most important members of the community and without them the project would have no purpose." A while ago (June 2015), I started the process of codifying the governance of our community (

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-12-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3743/#review9215 --- Ship it! Ship It! - Jason Lowe-Power On Dec. 16, 2016, 3:17 p.m

Re: [gem5-dev] Review Request 3763: dist, dev: fix etherswitch upgrade script

2016-12-15 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3763/#review9213 --- Ship it! Ship It! - Jason Lowe-Power On Dec. 15, 2016, 4:50 p.m

Re: [gem5-dev] Review Request 3764: sim: add support for checkpoint downgrading

2016-12-15 Thread Jason Lowe-Power
. - Jason Lowe-Power On Dec. 15, 2016, 4:51 p.m., Curtis Dunham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-12-15 Thread Jason Lowe-Power
743/#comment7915> Why not use a vector? This is what it's actually representing, correct? I would argue for using the datatype that makes it most clear to future people reading this code. - Jason Lowe-Power On Nov. 23, 2016, 2:52 p.m., Arthur Perais

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-12-15 Thread Jason Lowe-Power
> On Nov. 23, 2016, 3:17 p.m., Jason Lowe-Power wrote: > > src/cpu/pred/BranchPredictor.py, line 100 > > <http://reviews.gem5.org/r/3743/diff/2/?file=63759#file63759line100> > > > > Comment is now wrong. > > > > Also, does it m

Re: [gem5-dev] Review Request 3752: ruby: Add occupancy stats to MessageBuffers

2016-12-13 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3752/#review9207 --- Ship it! Ship It! - Jason Lowe-Power On Dec. 8, 2016, 11:33 p.m

Re: [gem5-dev] x86 MinorCPU Branch Prediction

2016-12-09 Thread Jason Lowe-Power
< bzeeb-li...@lists.zabbadoz.net> wrote: > On 9 Dec 2016, at 16:56, Jason Lowe-Power wrote: > > > Hi Bjoern, > > > > It's not fully tested, and I don't think everything works perfectly. > > Well, that’s true for more gem5 X86 things ;-) > > > > Ho

Re: [gem5-dev] x86 MinorCPU Branch Prediction

2016-12-09 Thread Jason Lowe-Power
Hi Bjoern, It's not fully tested, and I don't think everything works perfectly. However, I've had pretty good luck running simple benchmarks with it. Cheers, Jason On Fri, Dec 9, 2016 at 10:53 AM Bjoern A. Zeeb < bzeeb-li...@lists.zabbadoz.net> wrote: > On 9 Dec 2016, at 16:43, J

Re: [gem5-dev] x86 MinorCPU Branch Prediction

2016-12-09 Thread Jason Lowe-Power
Hi Bjoern, Just add MinorCPU on the command line when compiling with scons: > scons build/X86/gem5.opt CPU_MODELS=AtomicSimpleCPU,O3CPU,TimingSimpleCPU,MinorCPU Or, you could modify the default build options in build_opts/X86. Cheers, Jason On Fri, Dec 9, 2016 at 10:40 AM Bjoern A. Zeeb <

Re: [gem5-dev] Review Request 3751: ruby: Check all VNETs for injection in garnet NetworkInterface

2016-12-09 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3751/#review9198 --- Ship it! Ship It! - Jason Lowe-Power On Dec. 8, 2016, 11:32 p.m

Re: [gem5-dev] Review Request 3750: am, config: Add dist-gem5 support to the big.LITTLE(tm) config

2016-12-07 Thread Jason Lowe-Power
/example/arm/dist_bigLITTLE.py (line 53) <http://reviews.gem5.org/r/3750/#comment7892> incorrect indentation. - Jason Lowe-Power On Dec. 6, 2016, 5:47 p.m., Gabor Dozsa wrote: > > --- > This is an automatically generated e

Re: [gem5-dev] Review Request 3748: arm, config: Refactor the example big.LITTLE(tm) configuration

2016-12-07 Thread Jason Lowe-Power
to the functions you've added? E.g., """This function does... Parameters are... returns...""" after the function declarations. - Jason Lowe-Power On Dec. 6, 2016, 5:45 p.m., Gabor Dozsa wrote: > > --- > Th

Re: [gem5-dev] Review Request 3749: config: Refactor the network switch configuration file

2016-12-07 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3749/#review9185 --- Ship it! Ship It! - Jason Lowe-Power On Dec. 6, 2016, 5:46 p.m

Re: [gem5-dev] Review Request 3747: ruby: Remove RubyMemoryControl and associated files

2016-11-30 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3747/#review9177 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 30, 2016, 4:48 p.m

[gem5-dev] changeset in gem5: cpu: Remove branch predictor function predict...

2016-11-30 Thread Jason Lowe-Power
changeset b0853929e223 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=b0853929e223 description: cpu: Remove branch predictor function predictInOrder This function was used by the now-defunct InOrderCPU model. Since this model is no longer in gem5,

[gem5-dev] Learning gem5 Tutorial in conjunction with HPCA 2017

2016-11-29 Thread Jason Lowe-Power
e. More information can be found on the website for Learning gem5 ( http://learning.gem5.org). Feel free to email me any questions ( ja...@lowepower.com). Hope to see you in Austin! Cheers, Jason -- Jason Lowe-Power PhD Student University of Wisconsin-Madison, Department of Computer Science

[gem5-dev] Questions about updating regressions

2016-11-28 Thread Jason Lowe-Power
Hello, I'm about to push a bunch of recent patches from reviewboard to the main gem5 repo. Some of these changes make regression stats updates, and I don't know what the right protocol to update the regressions are. Here are my questions: 1. For the new RISC-V regressions, should I make 2

Re: [gem5-dev] Does each directory controller account for a range of memory address in Ruby?

2016-11-26 Thread Jason Lowe-Power
Hi Tingyuan, There should be no overlap in the memory ranges of the directory controllers. There is a function "DirectoryMemory::mapAddressToDirectoryVersion" which takes an address and returns the directory controller that the address should be routed to. This function basically picks a few bits

[gem5-dev] Review Request 3744: cpu: Remove branch predictor function predictInOrder

2016-11-23 Thread Jason Lowe-Power
Diff: http://reviews.gem5.org/r/3744/diff/ Testing --- Compiles and se mode tests run. Thanks, Jason Lowe-Power ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3710: cpu: Resolve targets of predicted 'taken' conditional direct branches at decode (o3)

2016-11-23 Thread Jason Lowe-Power
> On Nov. 22, 2016, 5:51 p.m., Jason Lowe-Power wrote: > > The error you're seeing is because you don't have Google's protobuf library > > installed. Though it has no affect on what you're seeing. > > > > Can you run the full system linux boot regression with O3 to

Re: [gem5-dev] Review Request 3743: cpu: implement L-TAGE branch predictor

2016-11-22 Thread Jason Lowe-Power
count that defaults to 2**27. Is this really a MemorySize? - Jason Lowe-Power On Nov. 22, 2016, 2:31 p.m., Arthur Perais wrote: > > --- > This is an automatically generated e-ma

Re: [gem5-dev] Review Request 3722: cpu: change comments in tournament branch predictor to reflect what the code does

2016-11-22 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3722/#review9153 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 18, 2016, 1:01 p.m

Re: [gem5-dev] Review Request 3710: cpu: Resolve targets of predicted 'taken' conditional direct branches at decode (o3)

2016-11-22 Thread Jason Lowe-Power
protobuf library installed. Though it has no affect on what you're seeing. Can you run the full system linux boot regression with O3 to be sure that it still works correctly? This is a more rigorous test than any SE mode tests. - Jason Lowe-Power On Nov. 18, 2016, 3:21 p.m., Arthur Perais wrote

Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.

2016-11-21 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9145 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 21, 2016, 10:32 p.m

Re: [gem5-dev] Review Request 3718: syscall_emul: extend sysinfo system call to include mem_unit

2016-11-21 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3718/#review9136 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 17, 2016, 8:27 p.m

Re: [gem5-dev] Review Request 3727: cpu: disallow speculative update of the conditional branch predictor tables (o3)

2016-11-21 Thread Jason Lowe-Power
. - Jason Lowe-Power On Nov. 18, 2016, 3:14 p.m., Arthur Perais wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

[gem5-dev] ReviewBoard full text search

2016-11-21 Thread Jason Lowe-Power
Hi all, Is there any reason we don't have full text search enabled on reviewboard? Did we accidentally overlook it, or does it strain our server too much? Something else? https://www.reviewboard.org/docs/manual/dev/users/searching/full-text-search/ I've been bitten many time by knowing

Re: [gem5-dev] RISC-V Patches

2016-11-21 Thread Jason Lowe-Power
Hi Alec, These are ready according to me. Unless someone has an objection, I'll push them on Friday (assuming I can get up after all the food on Thursday). Note: All of the tests are passing for me with minor changes in the instruction rates, etc. Thanks again for these patches. I think that

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-21 Thread Jason Lowe-Power
Hi Fernando, I don't know what he original use of predictInOrder was, but you're right, it doesn't look like it's in use now. You may be able to figure out what it was used for by inferring its function from the code. Jason On Sun, Nov 13, 2016 at 2:37 PM Jason Lowe-Power <ja...@lowepower.

Re: [gem5-dev] Status of RISC-V patches

2016-11-21 Thread Jason Lowe-Power
other than > >00.hello, > >because either they're multithreaded or pieces of them are missing. I'm > >going to try to put my instruction tests into 02.insttest. > > > >On Fri, Oct 28, 2016 at 11:01 AM, Jason Lowe-Power <ja...@lowepower.com> > >wrote: > >

Re: [gem5-dev] Review Request 3707: syscall_emul: return -errno on a failed close call

2016-11-16 Thread Jason Lowe-Power
suite you're running which exercises all of these syscalls? - Jason Lowe-Power On Nov. 16, 2016, 4:25 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3704: style: change NULL to nullptr in syscall files

2016-11-14 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3704/#review9067 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 14, 2016, 9:02 p.m

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

2016-11-14 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3681/#review9065 --- Ship it! Thanks for the change! - Jason Lowe-Power On Nov. 14, 2016

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

2016-11-14 Thread Jason Lowe-Power
> On Nov. 8, 2016, 4:56 p.m., Jason Lowe-Power wrote: > > src/sim/system.hh, line 543 > > <http://reviews.gem5.org/r/3681/diff/1/?file=63244#file63244line543> > > > > Can this just be an std::set? This is only used to make sure there > > are no dupli

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-13 Thread Jason Lowe-Power
nks, > > -- > Fernando A. Endo, Post-doc > > INRIA Rennes-Bretagne Atlantique > France > > > 2016-11-06 21:38 GMT+01:00 Jason Lowe-Power <ja...@lowepower.com>: > > > Hi Fernando, > > > > Yes, it seems like a good idea to include a TAGE

Re: [gem5-dev] Review Request 3697: style: [PATCH 16/22] correct some style issues

2016-11-08 Thread Jason Lowe-Power
to cleaned up at some point. Thanks! - Jason Lowe-Power On Nov. 7, 2016, 10:05 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3681: syscall_emul: [patch 14/22] adds identifier system calls

2016-11-08 Thread Jason Lowe-Power
to make sure there are no duplicates, right? - Jason Lowe-Power On Nov. 7, 2016, 9:56 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:/

Re: [gem5-dev] How does one generalize VectorPort in srhc/python/m5/params.py beyond vector?

2016-11-06 Thread Jason Lowe-Power
Hi Eric, It should be as simple as using a "VectorParam" of whatever type you want. Instead of using "Param.TLB", use "VectorParam.TLB" in the SimObject definition file. Then, in the config script, you can assign this variable with a Python list. Jason On Sat, Nov 5, 2016 at 5:35 PM eric van

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-06 Thread Jason Lowe-Power
Hi Fernando, Yes, it seems like a good idea to include a TAGE predictor in gem5. Please make patches and post them to the reviewboard. We welcome the contribution. Additionally, I believe there was a recent email about a possible bug when updating the branch predictor state on a mis-speculation.

Re: [gem5-dev] RISC-V RV64A Implementation (Review Request #3629)

2016-11-02 Thread Jason Lowe-Power
Hi Alec, This seems reasonable to me. Since RISC-V support is in its infancy, having every feature working perfectly to begin with would be shocking :). I'm glad the regressions you're making are robust enough to find bugs, too! I believe you can "review" your own patch on reviewboard in order

Re: [gem5-dev] Review Request 3668: riscv: [Patch 6/5] Improve Linux emulation for RISC-V

2016-11-01 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3668/#review9012 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 21, 2016, 6:33 p.m

Re: [gem5-dev] Review Request 3630: riscv: [Patch 5/5] Added missing support for timing CPU models

2016-11-01 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3630/#review9011 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 21, 2016, 6:32 p.m

Re: [gem5-dev] Review Request 3629: riscv: [Patch 4/5] Added RISC-V atomic memory extension RV64A

2016-11-01 Thread Jason Lowe-Power
Lowe-Power On Nov. 1, 2016, 1:33 a.m., Alec Roelke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3629/ > --- &g

Re: [gem5-dev] Review Request 3691: hsail: fix unsigned offset bug in address calculation

2016-11-01 Thread Jason Lowe-Power
, then offset.hi is 0 and offset.low is -3 in two's complement? I.e., if the instruction is 32-bits, the offset is NOT sign extended in BRIG? - Jason Lowe-Power On Oct. 31, 2016, 11:13 p.m., Tony Gutierrez wrote: > > --- > This is an auto

Re: [gem5-dev] Status of RISC-V patches

2016-10-28 Thread Jason Lowe-Power
yet, is there a way for me to figure out > what the configuration I should be using is, since I imagine I'll run into > this problem for the other CPU models? > > On Thu, Oct 27, 2016 at 6:38 PM, Jason Lowe-Power <ja...@lowepower.com> > wrote: > > Hi Alec, > > Than

Re: [gem5-dev] Status of RISC-V patches

2016-10-27 Thread Jason Lowe-Power
is it sufficient to see that each > instruction is represented at least once by them? I could write some tests > that check corner cases, but at least some would use assembly calls and > thus be incompatible with anything other than RISC-V. > > On Thu, Oct 27, 2016 at 5:55 PM, Jason

[gem5-dev] Status of RISC-V patches

2016-10-27 Thread Jason Lowe-Power
Hi Alec, Thanks again for implementing RISC-V in gem5. It's an incredibly important and timely addition! As far as I can tell, the patches look good. Hopefully some other will review them soon as well. The only thing that's missing that I would really like to have before pushing the patches is

Re: [gem5-dev] Review Request 3627: riscv: [Patch 2/5] Added RISC-V multiply extension RV64M

2016-10-27 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3627/#review8998 --- Ship it! Seems reasonable to me. - Jason Lowe-Power On Sept. 29

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-27 Thread Jason Lowe-Power
and it looks good to me! I'll start testing the other patches in the series soon. - Jason Lowe-Power On Oct. 21, 2016, 6:12 p.m., Alec Roelke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://review

Re: [gem5-dev] Review Request 3689: tests, ruby: Move rubytests from ALPHA (linux) to NULL (none)

2016-10-27 Thread Jason Lowe-Power
hecks". You could do it now (line 72 of rubytest-ruby.py). I tested 10 which took ~20 seconds on my Skylake machine. Or, I can submit a patch after this is checked in. It's up to you. Thanks for doing this! - Jason Lowe-Power On Oct. 27, 2016, 7:50 a.m., Andreas Han

Re: [gem5-dev] Base cpu modification

2016-10-26 Thread Jason Lowe-Power
as an optional device I think it would be good to have in gem5! Cheers, Jason On Wed, Oct 26, 2016 at 8:09 AM Pierre-Yves Péneau < pierre-yves.pen...@lirmm.fr> wrote: > Hi Jason, > > On 10/26/2016 12:27 AM, Jason Lowe-Power wrote: > > Hello, > > > > Could you give us

Re: [gem5-dev] Review Request 3684: alpha: Remove ALPHA support and supplemental files

2016-10-25 Thread Jason Lowe-Power
> On Oct. 25, 2016, 10:13 p.m., Jason Lowe-Power wrote: > > util/regress, line 45 > > <http://reviews.gem5.org/r/3684/diff/1/?file=62482#file62482line45> > > > > I think this has been pointed out by Brad in the past, but we need to > > keep these t

Re: [gem5-dev] Base cpu modification

2016-10-25 Thread Jason Lowe-Power
Hello, Could you give us some more details on what you're proposing. What is this "component"? Do you expect that many people in the community will need/want to use this component? If so, then it may make sense to incorporate some changes to the BaseCPU object. The way I see it is you have three

Re: [gem5-dev] Review Request 3684: alpha: Remove ALPHA support and supplemental files

2016-10-25 Thread Jason Lowe-Power
> On Oct. 25, 2016, 10:13 p.m., Jason Lowe-Power wrote: > > util/regress, line 45 > > <http://reviews.gem5.org/r/3684/diff/1/?file=62482#file62482line45> > > > > I think this has been pointed out by Brad in the past, but we need to > > keep these t

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-21 Thread Jason Lowe-Power
> On Oct. 20, 2016, 2:35 p.m., Jason Lowe-Power wrote: > > Sorry for the slow reviewing. I have a few minor changes. > > > > First, when I apply the patch, I get a number of errors from the style > > checker. Make sure you're using the most up-to-date version of gem

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-21 Thread Jason Lowe-Power
> On Oct. 20, 2016, 2:35 p.m., Jason Lowe-Power wrote: > > Sorry for the slow reviewing. I have a few minor changes. > > > > First, when I apply the patch, I get a number of errors from the style > > checker. Make sure you're using the most up-to-date version of gem

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-21 Thread Jason Lowe-Power
> On Oct. 20, 2016, 2:35 p.m., Jason Lowe-Power wrote: > > Sorry for the slow reviewing. I have a few minor changes. > > > > First, when I apply the patch, I get a number of errors from the style > > checker. Make sure you're using the most up-to-date version of gem

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-21 Thread Jason Lowe-Power
> On Oct. 20, 2016, 2:35 p.m., Jason Lowe-Power wrote: > > Sorry for the slow reviewing. I have a few minor changes. > > > > First, when I apply the patch, I get a number of errors from the style > > checker. Make sure you're using the most up-to-date version of gem

Re: [gem5-dev] Review Request 3502: mem: Split the hit_latency into tag_latency and data_latency

2016-10-21 Thread Jason Lowe-Power
> On Oct. 21, 2016, 1:29 p.m., Pierre-Yves Péneau wrote: > > Hi, > > > > Someone can commit this patch ? I don't have right access on the > > repository, either Sophiane. > > Thank you. Sorry we've been so slow on this patch. A couple of questions before I commit. 1. Are all of Andreas H.'s

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-20 Thread Jason Lowe-Power
m not sure if the problem is that you've based this on an older version of gem5, or maybe we're just using different compilers (I'm use gcc-4.8). - Jason Lowe-Power On Oct. 13, 2016, 4:48 p.m., Alec Roelke wrote: > > --- > This is an automa

Re: [gem5-dev] Review Request 3683: config: Break out base options for usage with NULL ISA

2016-10-20 Thread Jason Lowe-Power
rating errors for our users in the short term. configs/common/Options.py (line 46) <http://reviews.gem5.org/r/3683/#comment7689> Weird. I guess I understand why this is needed, but it's super strange to have to import from the package this file is part of. Something else that should be

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

2016-10-20 Thread Jason Lowe-Power
others disagree it would be good to remove it (no need to repost, though). - Jason Lowe-Power On Oct. 20, 2016, 4:45 a.m., Anastasiia Butko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

2016-10-19 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8937 --- Ship it! Thanks for the change! - Jason Lowe-Power On Oct. 19, 2016

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

2016-10-19 Thread Jason Lowe-Power
> On Oct. 18, 2016, 1:55 p.m., Jason Lowe-Power wrote: > > configs/example/arm/fs_bigLITTLE.py, line 66 > > <http://reviews.gem5.org/r/3666/diff/3/?file=61784#file61784line66> > > > > Rather than having an extra parameter, could you make a subclass of t

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

2016-10-18 Thread Jason Lowe-Power
> On Oct. 17, 2016, 10:25 p.m., Jason Lowe-Power wrote: > > src/sim/process.cc, line 593 > > <http://reviews.gem5.org/r/3671/diff/1/?file=61630#file61630line593> > > > > Any reason not to move this code into ProcessParams::create(), and > > elimi

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

2016-10-18 Thread Jason Lowe-Power
> On Oct. 17, 2016, 10:25 p.m., Jason Lowe-Power wrote: > > src/sim/process.cc, line 593 > > <http://reviews.gem5.org/r/3671/diff/1/?file=61630#file61630line593> > > > > Any reason not to move this code into ProcessParams::create(), and > > elimi

Re: [gem5-dev] Review Request 3673: syscall_emul: [patch 7/22] remove numCpus method

2016-10-18 Thread Jason Lowe-Power
if we're removing ALPHA support. - Jason Lowe-Power On Oct. 17, 2016, 3:20 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

2016-10-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3672/#review8892 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 17, 2016, 3:19 p.m

Re: [gem5-dev] Review Request 3650: style: remove err.h to prevent a name collision

2016-10-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3650/#review8891 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 10, 2016, 5:16 p.m

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

2016-10-18 Thread Jason Lowe-Power
think it would make things cleaner. configs/example/arm/fs_bigLITTLE.py (line 69) <http://reviews.gem5.org/r/3666/#comment7649> Why use CpuConfig here? Why not just use ex5_LITTLE.ex5_LITTLE? I guess this applies to the "arm_detailed" too. - Jason Lowe-Power On O

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

2016-10-17 Thread Jason Lowe-Power
eate(), and eliminate this static function? - Jason Lowe-Power On Oct. 17, 2016, 3:17 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8884 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 17, 2016, 3:08 p.m

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3660/#review8883 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 17, 2016, 3:07 p.m

Re: [gem5-dev] Review Request 3682: syscall_emul: remove TGT_MMAP_* flags that break OSX build

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3682/#review8882 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 17, 2016, 7:47 p.m

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

2016-10-17 Thread Jason Lowe-Power
...@gem5.org on behalf of anthony.gutier...@amd.com> wrote: > > >I would like to see this clarified before we ask Brandon to go work on > >fixing ALPHA. If it is going to be phased out in a matter of months, I > >don't think we should be asking him to waste his time on fixin

Re: [gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

2016-10-17 Thread Jason Lowe-Power
> On Oct. 17, 2016, 2:15 p.m., Jason Lowe-Power wrote: > > With this patch, if you run multiple processes in SE mode they all have the > > same PID (100) by default. Will this cause issues? I haven't tested a > > pthreads application, but that seems like it might cause pro

Re: [gem5-dev] FW: [gem5-users] scons build error for Garnet 2.0

2016-10-17 Thread Jason Lowe-Power
Hi Brandon, We've had this discussion before. See this thread: http://www.mail-archive.com/gem5-dev@gem5.org/msg19380.html In summary... I think we're planning on phasing out ALPHA, but that won't happen in the very short term (weeks), but may happen in the medium term (months). Cheers, Jason

Re: [gem5-dev] Review Request 3670: syscall_emul: remove redundant M5_pid field from process class

2016-10-17 Thread Jason Lowe-Power
? If so, we should have a fatal if there are multiple Processes with the same PID. - Jason Lowe-Power On Oct. 17, 2016, 1:06 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: [gem5-dev] Review Request 3669: arm, config: [2/2] added support for ex5 model of big.LITTLE

2016-10-17 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3669/#review8857 --- No diff uploaded? - Jason Lowe-Power On Oct. 17, 2016, 3:32 a.m

Re: [gem5-dev] Review Request 3666: arm, config: [1/2] added support for ex5 model of big.LITTLE

2016-10-17 Thread Jason Lowe-Power
Lowe-Power On Oct. 17, 2016, 2:21 a.m., Anastasiia Butko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3665: arm, config: Enabled MemConfig usage for the example big.LITTLE

2016-10-17 Thread Jason Lowe-Power
lution to this right now, but we need to think about a fix for this in the future. configs/example/arm/fs_bigLITTLE.py (line 157) <http://reviews.gem5.org/r/3665/#comment7623> Triple quotes aren't necessary here. - Jason Lowe-Power On Oct. 17, 2016, 2:19 a.m., Anastasiia

Re: [gem5-dev] Review Request 3547: cpu, arm: Separate Float* from SimdFloat*, add FloatMem* opClass

2016-10-15 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3547/#review8849 --- Please mark this as submitted. Thanks. - Jason Lowe-Power On Aug. 1

Re: [gem5-dev] Review Request 3582: syscall_emul: Corrected a bug on the syscall "read()" when reading EOF

2016-10-15 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3582/#review8848 --- Please mark this as submitted. Thanks. - Jason Lowe-Power On Aug. 7

Re: [gem5-dev] Review Request 3623: arm, dev: pl011 console interactivity

2016-10-15 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3623/#review8847 --- Can you mark this as submitted? Thanks. - Jason Lowe-Power On Sept

Re: [gem5-dev] Review Request 3543: dev, dist: Fixed a scheduling bug in the etherswitch

2016-10-15 Thread Jason Lowe-Power
if I'm wrong. - Jason Lowe-Power On July 5, 2016, 11:44 p.m., Mohammad Alian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

[gem5-dev] Patches ready to push?

2016-10-14 Thread Jason Lowe-Power
Hi all, It's been awhile since I've gone through and pushed patches that are ready on reviewboard. This weekend I'm going to try to clear out some backlog. If you don't have commit access and have a patch that's marked as "Ship It", let me know and I'll push it this weekend. Patches I'm planning

Re: [gem5-dev] Stable release

2016-10-14 Thread Jason Lowe-Power
.fr> wrote: > I am glad to see that my email leads to quick response and action :-) > > Thank you all. > > > > On 10/07/2016 04:04 PM, Jason Lowe-Power wrote: > > > Thanks for getting back to me everyone. I'm going to send out a message > to > > > gem5-

[gem5-dev] changeset in gem5: stats: Add more information to uninitialized ...

2016-10-14 Thread Jason Lowe-Power
changeset 074694750c5d in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=074694750c5d description: stats: Add more information to uninitialized error ClockedObject was changed to require its regStats() to be called from every child class. If you forget

Re: [gem5-dev] Review Request 3664: ruby: make a RequestDesc class instead of std::pair

2016-10-13 Thread Jason Lowe-Power
u want to change it. This assumes that we have C++11 support, which I think all of our supported compilers have. - Jason Lowe-Power On Oct. 13, 2016, 9:24 p.m., Tony Gutierrez wrote: > > --- > This is an automatically g

Re: [gem5-dev] Review Request 3663: config: Make configs/common a Python package

2016-10-13 Thread Jason Lowe-Power
be much more modular / follow object-oriented design patterns. I'll put this on the list of things that we could do at the sprint at HPCA :). configs/learning_gem5/part1/two_level.py (line 49) <http://reviews.gem5.org/r/3663/#comment7616> Should this be `../../`? - Jason Lowe-Power On O

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-10-12 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3591/#review8828 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 30, 2016, 3:54 p.m

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/#review8826 --- Ship it! Thanks again for doing this! - Jason Lowe-Power On Oct. 12

<    5   6   7   8   9   10   11   12   >