Re: [gem5-dev] Review Request: Ruby: Add support for functional accesses

2011-06-12 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-06-12 14:55:53.667339) Review request for Default. Summary (updated

Re: [gem5-dev] Review Request: [mq]: FunctionalAccess.9.patch

2011-06-12 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-06-12 14:55:00.907885) Review request for Default. Summary (updated

[gem5-dev] Ruby: Token Coherence and Functional Access

2011-06-10 Thread Nilay Vaish
Brad, in the token coherence protocol, the l2 cache controller moves from state O to I and sends data to the memory. I think this particular transition is may pose a problem in enabling functional accesses for the protocol. The problem, I think, is that both the directory and the cache controll

Re: [gem5-dev] Cron /z/m5/regression/do-regression quick

2011-06-09 Thread Nilay Vaish
Korey, try 'hg status'. It would list the set of files that are not being tracked. May be there is some file that should be committed and has not been. -- Nilay On Thu, 9 Jun 2011, Korey Sewell wrote: My local repo has this at the tip: hg tip changeset: 8342:77d12d8f7971 tag: tip

[gem5-dev] changeset in gem5: Ruby: Correctly set access permissions for di...

2011-06-08 Thread Nilay Vaish
changeset 30daf1dd5c91 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=30daf1dd5c91 description: Ruby: Correctly set access permissions for directory entries The access permissions for the directory entries are not being set correctly. This is because

Re: [gem5-dev] Review Request: Ruby: Correctly set access permissions for directory entries

2011-06-08 Thread Nilay Vaish
not been implemented. - Nilay --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/684/#review1301 --- On 2011-06-06 14:45:22, Nilay Vaish wrote: > > ---

Re: [gem5-dev] Query on inheritance and virtual functions

2011-06-08 Thread Nilay Vaish
On Wed, 8 Jun 2011, Jack Harvard wrote: On 8 Jun 2011, at 23:28, Nilay Vaish wrote: On Wed, 8 Jun 2011, Jack Harvard wrote: On 8 Jun 2011, at 19:09, Nilay Vaish wrote: On Wed, 8 Jun 2011, Jack Harvard wrote: When you declare your function private, you can't use instance.function

Re: [gem5-dev] Query on inheritance and virtual functions

2011-06-08 Thread Nilay Vaish
On Wed, 8 Jun 2011, Jack Harvard wrote: On 8 Jun 2011, at 19:09, Nilay Vaish wrote: On Wed, 8 Jun 2011, Jack Harvard wrote: When you declare your function private, you can't use instance.function() to access it. Is it generating a compile time error? On 8 Jun 2011, at 00:31, Nilay

Re: [gem5-dev] Query on inheritance and virtual functions

2011-06-08 Thread Nilay Vaish
On Wed, 8 Jun 2011, Jack Harvard wrote: When you declare your function private, you can't use instance.function() to access it. Is it generating a compile time error? On 8 Jun 2011, at 00:31, Nilay Vaish wrote: Consider the following class declarations -- class A { public: virtual

[gem5-dev] Query on inheritance and virtual functions

2011-06-07 Thread Nilay Vaish
Consider the following class declarations -- class A { public: virtual void function() = 0; }; class B : public A { private: void function(); } int main() { B b; b.function(); } Will this code compile correctly? -- Nilay ___ gem5-dev

Re: [gem5-dev] Review Request: Ruby: Correctly set access permissions for directory entries

2011-06-06 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/684/ --- (Updated 2011-06-06 14:45:22.384167) Review request for Default. Summary ---

Re: [gem5-dev] Review Request: Ruby: Correctly set access permissions for directory entries

2011-06-06 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/684/ --- (Updated 2011-06-06 14:44:19.791924) Review request for Default. Summary (updated

Re: [gem5-dev] /z/m5/regression/do-regression --scratch all

2011-06-05 Thread Nilay Vaish
We again had the same problem as yesterday, though it seems that all the regression tests run up to completion. Any suggestions on resolving this? scons: *** Found dependency cycle(s): Internal Error: no cycle found for node build/ALPHA_SE_MOESI_CMP_directory/params/DMA_Controller.hh () in s

Re: [gem5-dev] Cron /z/m5/regression/do-regression quick

2011-06-04 Thread Nilay Vaish
one. I've never seen this myself; I wonder if it's a bug in the version of scons on zizzer (v0.98), as the machine I use has v.1.2.0. It is a little strange that we're building params structs for Ruby objects in ALPHA_SE though. Steve On Sat, Jun 4, 2011 at 6:41 AM, Nilay Vaish wro

Re: [gem5-dev] Cron /z/m5/regression/do-regression quick

2011-06-04 Thread Nilay Vaish
Does any one has any idea what a dependency cycles is? This is what zizzer's log has. scons: *** Found dependency cycle(s): Internal Error: no cycle found for node build/ALPHA_SE/params/L1Cache_Controller.hh (at 0x412a680>) in state up_to_date Internal Error: no cycle found for node build/AL

[gem5-dev] changeset in m5: SLICC: Remove machine name as prefix to functions

2011-06-03 Thread Nilay Vaish
changeset b9ba22cb23f2 in /z/repo/m5 details: http://repo.gem5.org/m5?cmd=changeset;node=b9ba22cb23f2 description: SLICC: Remove machine name as prefix to functions Currently, the machine name is appended before any of the functions defined with in the sm files. This is not

Re: [gem5-dev] Review Request: Ruby: Add support for functionalaccesses

2011-06-01 Thread Nilay Vaish
fact, we advise users to move to gem5. -- Nilay On Thu, 2 Jun 2011, huangyongbing wrote: Hi. I am currently using GEMS and Simics. So I care about whether the corresponding codes are also updated in GEMS. -Yongbing Huang 发件人: Nilay Vaish 发送时间: 2011-06-02 09:57:40 收件人: Nilay Vaish

[gem5-dev] Review Request: SLICC: Add a check function for State Machine

2011-06-01 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/723/ --- Review request for Default. Summary --- SLICC: Add a check function for State

Re: [gem5-dev] Review Request: Ruby: Add support for functional accesses

2011-06-01 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-06-01 18:59:39.117342) Review request for Default. Summary ---

Re: [gem5-dev] Review Request: Ruby: Add support for functional accesses

2011-06-01 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-06-01 18:59:16.473427) Review request for Default. Summary (updated

Re: [gem5-dev] Functional Memory Accesses in Ruby

2011-05-31 Thread Nilay Vaish
On Sat, 28 May 2011, Nilay Vaish wrote: Hi Brad I am trying to complete the patch on functional accesses in Ruby. I came across this problem while testing the patch for higher number of processors. I am working with MESI CMP directory protocol right now. So I will describe the problem in

[gem5-dev] Functional Memory Accesses in Ruby

2011-05-28 Thread Nilay Vaish
Hi Brad I am trying to complete the patch on functional accesses in Ruby. I came across this problem while testing the patch for higher number of processors. I am working with MESI CMP directory protocol right now. So I will describe the problem in its context. Assume we are trying to functi

Re: [gem5-dev] Review Request: Ruby: Correctly set access permissions for directory entries

2011-05-27 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/684/ --- (Updated 2011-05-27 11:41:44.345753) Review request for Default. Summary (updated

Re: [gem5-dev] [m5-dev] Review Request: Ruby: Correctly set access permissions for directory entries

2011-05-26 Thread Nilay Vaish
On Fri, 6 May 2011, Beckmann, Brad wrote: Hi Nilay, Yeah, pulling the State into the Machine makes sense to me. If I recall, my previous patch made it necessary that each machine included a state_declaration (previously the state enum). More tightly integrating the state to the machine see

Re: [gem5-dev] Review Request: slicc: add a protocol statement and an include statement

2011-05-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/717/#review1261 --- Ship it! Looks fine to me. - Nilay On 2011-05-24 10:15:40, Nathan Bin

Re: [m5-dev] Adding m5 debug statements to SLICC

2011-05-07 Thread Nilay Vaish
Koreay, DPRINTF already works in sm files. Use RubySlicc as the flag. You can also use error() and assert() functions which have the following prototypes -- void error(std::string msg); void assert(bool condition); -- Nilay On Fri, 6 May 2011, Korey Sewell wrote: I guess I should rephrase t

Re: [m5-dev] Review Request: Ruby: Correctly set access permissions for directory entries

2011-05-07 Thread Nilay Vaish
Korey, I don't think there will be any change in the simulation performance. I am not sure about stats. Brad, were the stats updated after you made the change? -- Nilay On Fri, 6 May 2011, Korey Sewell wrote: Nilay, can you explain the impact of that bug in terms of simulation performance?

Re: [m5-dev] [m5-users] Tracing does not work

2011-05-07 Thread Nilay Vaish
Joel, I have pushed in the patch the removes the options trace-help and trace-flags. But trace-start and trace-file work as before. You can use them in conjunction with debug-flags. -- Nilay On Fri, 6 May 2011, Nilay Vaish wrote: I was thinking og doing it since Nate is not around. I'

[m5-dev] changeset in m5: Trace: Remove the options trace-help and trace-...

2011-05-07 Thread Nilay Vaish
changeset a6363c870af6 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=a6363c870af6 description: Trace: Remove the options trace-help and trace-flags The options trace-help and trace-flags are no longer required. In there place, the options debug-help and

[m5-dev] Review Request: Ruby: Correctly set access permissions for directory entries

2011-05-06 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/684/ --- Review request for Default. Summary --- Ruby: Correctly set access permissions

Re: [m5-dev] [m5-users] Tracing does not work

2011-05-06 Thread Nilay Vaish
I was thinking og doing it since Nate is not around. I'll do it soon. -- Nilay On Fri, 6 May 2011, Joel Hestness wrote: Hey Nilay, It looks like the tracing ("debug") functionality is now working again, but the M5 help message is still incorrect (and extremely misleading). For instance, "tra

Re: [m5-dev] Trace not working

2011-04-27 Thread Nilay Vaish
seems that all the previous flags are still specified using the "TraceFlag()" function, but I can't seem to be able to specify a new one.Also to be consistent, should we change the name of the TraceFlag function to DebugFlag? Brad -Original Message- From: m5-dev

[m5-dev] Trace not working

2011-04-25 Thread Nilay Vaish
On Mon, 25 Apr 2011, Nilay Vaish wrote: The option trace-help is not working currently. When I execute the following ./build/ALPHA_SE_MESI_CMP_directory/m5.debug --trace-help I get a list of all the m5 options. Can some one confirm this? Thanks Nilay Seems like trace facility is not

[m5-dev] Trace Help

2011-04-25 Thread Nilay Vaish
The option trace-help is not working currently. When I execute the following ./build/ALPHA_SE_MESI_CMP_directory/m5.debug --trace-help I get a list of all the m5 options. Can some one confirm this? Thanks Nilay ___ m5-dev mailing list m5-dev@m5sim.or

[m5-dev] changeset in m5: base: include types.hh in base/stats/mysql.hh

2011-04-25 Thread Nilay Vaish
changeset ea37585785ab in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=ea37585785ab description: base: include types.hh in base/stats/mysql.hh Due to certain changes made via changeset 8229, the compilation was failing in certain cases. The compiler point

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-25 Thread Nilay Vaish
ilar > > function: getPermission(). > > > > Overall, I hope/think we can add functional access support without > > requiring any more changes to the protocol specific .sm files beyond the > > changeset: 8086:bf0335d98250 that I checked in a couple months ago. &g

Re: [m5-dev] Error while compiling (changeset 8229)

2011-04-21 Thread Nilay Vaish
On Wed, 20 Apr 2011, nathan binkert wrote: Because that file is being included regardless. ?I'm actively trying to squash all of these bugs and I'll be committing some changes soon. This one is trivial to fix. I can't reproduce this bug on my machine, even with USE_MYSQL=False. Can you try the

Re: [m5-dev] Error while compiling (changeset 8229)

2011-04-20 Thread Nilay Vaish
Nate, since I have provided the option USE_MYSQL=False, why should mysql.hh even come in to picture? -- Nilay On Wed, 20 Apr 2011, nathan binkert wrote: The solution is to #include "base/types.hh" in mysql.hh, but to be honest, I'm not sure how this is even happening. Perhaps you need to bl

Re: [m5-dev] Error while compiling (changeset 8229)

2011-04-20 Thread Nilay Vaish
I started compilation with 8241, and that has this problem. So I tried to bisect it and 8229 is the first changeset that has this problem. -- Nilay On Wed, 20 Apr 2011, nathan binkert wrote: You need changeset 8230. You need the sort includes changeset and the one following it that fixes bug

[m5-dev] Error while compiling (changeset 8229)

2011-04-20 Thread Nilay Vaish
I am trying to compile m5 and the scons exits with errors. Following is the compilation command -- scons -j 12 CXX=g++44 CC=gcc44 USE_MYSQL=False RUBY=True build/ALPHA_SE_MESI_CMP_directory/m5.fast and errors In file included from build/ALPHA_SE_MESI_CMP_directory/python/swig/stats_wrap.cc:3

Re: [m5-dev] Bug in changeset 8225 or 8227

2011-04-16 Thread Nilay Vaish
On Sat, 16 Apr 2011, nathan binkert wrote: What version of python are you using? It could be that that syntax wasn't available until 2.5 and you're using something older. I can't do anything about it right now because I'm about to leave on a hike. Nate Nate, it seems one of your checkins f

[m5-dev] Bug in changeset 8225 or 8227

2011-04-16 Thread Nilay Vaish
Nate, it seems one of your checkins from yesterday has a bug. I receive the following message on executing any merculrial command. *** failed to import extension style from ./util/style.py: invalid syntax (file_types.py, line 143) -- Nilay ___ m5-d

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-16 Thread Nilay Vaish
gt; } > > } > > Will make the required changes. - Nilay --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/#review1130 ---

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-16 Thread Nilay Vaish
ilar > > function: getPermission(). > > > > Overall, I hope/think we can add functional access support without > > requiring any more changes to the protocol specific .sm files beyond the > > changeset: 8086:bf0335d98250 that I checked in a couple months ago. &g

[m5-dev] Testing Ruby Memory Controller

2011-04-16 Thread Nilay Vaish
Is there a tester for testing the functionality of Ruby's memory controller? Thanks Nilay ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-15 Thread Nilay Vaish
ilar > > function: getPermission(). > > > > Overall, I hope/think we can add functional access support without > > requiring any more changes to the protocol specific .sm files beyond the > > changeset: 8086:bf0335d98250 that I checked in a couple months ago. &g

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-14 Thread Nilay Vaish
ilar > > function: getPermission(). > > > > Overall, I hope/think we can add functional access support without > > requiring any more changes to the protocol specific .sm files beyond the > > changeset: 8086:bf0335d98250 that I checked in a couple months ago. &g

[m5-dev] Ruby patch touching classic memory system

2011-04-14 Thread Nilay Vaish
Ali, Nate, Steve Can you go through this patch? I have made some changes to src/mem/packet.hh and src/mem/packet.cc files. http://reviews.m5sim.org/r/611/ Thanks Nilay On Thu, 14 Apr 2011, Nilay Vaish wrote: On 2011-04-13 13:43:26, Gabe Black wrote: Please fix these style issues

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-14 Thread Nilay Vaish
s is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/#review1113 --- On 2011-04-13 14:29:01, Nilay Vaish wrote: > > --- > This is an automati

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-14 Thread Nilay Vaish
...@m5sim.org] On Behalf Of Nilay Vaish Sent: Tuesday, April 12, 2011 4:39 PM To: Default Subject: Re: [m5-dev] Review Request: Ruby: Add support for functional accesses Brad, can you take a look at the patch? I think we are now in position to implement functional accesses for the PioPort. -- Nilay

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-13 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-04-13 14:29:01.423144) Review request for Default. Summary ---

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-13 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-04-13 11:17:53.272247) Review request for Default. Summary (updated

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-13 Thread Nilay Vaish
minor correction: change "Any copy" to "Any valid copy" Done! > On 2011-04-13 10:28:08, Brad Beckmann wrote: > > src/mem/ruby/system/DirectoryMemory.cc, line 246 > > <http://reviews.m5sim.org/r/611/diff/6/?file=11565#file11565line246> > > > > Please align this statement. I am remov

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-12 Thread Nilay Vaish
Brad, can you take a look at the patch? I think we are now in position to implement functional accesses for the PioPort. -- Nilay On Tue, 12 Apr 2011, Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-12 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-04-12 16:35:34.866577) Review request for Default. Summary (updated

Re: [m5-dev] Review Request: * * *

2011-04-12 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-04-12 16:32:36.416633) Review request for Default. Summary (updated

Re: [m5-dev] AccessPermission in AbstractEntry

2011-04-11 Thread Nilay Vaish
we have a protocol in which different directory controllers may behave differently? -- Nilay -Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Nilay Vaish Sent: Sunday, April 10, 2011 2:12 AM To: m5-dev@m5sim.org Subject: [m5-dev] Access

[m5-dev] AccessPermission in AbstractEntry

2011-04-10 Thread Nilay Vaish
Brad, it seems like the m_Permission variable in AbstractEntry is not being used at all. In order to get AccessPermission for a state, the state_To_AccessPermission function needs to be called. Then, why have that variable? And this would mean that CacheMemory has no idea about the access permi

Re: [m5-dev] Testing Functional Access

2011-04-09 Thread Nilay Vaish
Brad, I figured out the error, so no need to respond to my previous mail. -- Nilay On Sat, 9 Apr 2011, Nilay Vaish wrote: Brad, functional accesses work for the case when the only functional accesses are allowed in the system. Currently I am working when the ratio is 1:1 for functional and

Re: [m5-dev] Testing Functional Access

2011-04-09 Thread Nilay Vaish
Brad, functional accesses work for the case when the only functional accesses are allowed in the system. Currently I am working when the ratio is 1:1 for functional and timing accesses. I am facing some problem with the timing access right now, which should work perfectly fine. Actually the va

Re: [m5-dev] Review Request: ruby: dbg: use system ticks instead of cycles

2011-04-07 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/#review1102 --- src/mem/ruby/network/simple/PerfectSwitch.cc

Re: [m5-dev] Running Ruby w/32 Cores

2011-04-07 Thread Nilay Vaish
On Thu, 7 Apr 2011, Gabriel Michael Black wrote: Quoting Nilay Vaish : On Thu, 7 Apr 2011, Gabriel Michael Black wrote: When you say this is portable, what do you mean? Portable between compilers? We usually use gcc, but we have at least partial support for other compilers. I think this is

Re: [m5-dev] Running Ruby w/32 Cores

2011-04-07 Thread Nilay Vaish
The problem is that LONG_BITS is 31, ie std::numeric_limits::digits returns 31 and not 32 which is what the writer expected. -- Nilay From: koreylsew...@gmail.com [mailto:koreylsew...@gmail.com] On Behalf Of Korey Sewell Sent: Tuesday, April 05, 2011 7:14 AM To: Beckmann, Brad Subject: Re: [

Re: [m5-dev] Running Ruby w/32 Cores

2011-04-07 Thread Nilay Vaish
On Thu, 7 Apr 2011, Gabriel Michael Black wrote: When you say this is portable, what do you mean? Portable between compilers? We usually use gcc, but we have at least partial support for other compilers. I think this is necessary on some platforms. Gabe I would still root for using popcoun

Re: [m5-dev] Running Ruby w/32 Cores

2011-04-06 Thread Nilay Vaish
On Wed, 6 Apr 2011, Korey Sewell wrote: A few comments: (1) Using uint64_t seems like a quick, interim solution. But I still haven't grasped why we have the "31st" bit problem, but we don't have the "63rd" bit problem as well? I think if you use unsigned long, in place of long, the code would

Re: [m5-dev] Running Ruby w/32 Cores

2011-04-06 Thread Nilay Vaish
(CDT), Nilay Vaish wrote: I would prefer we make use of GCC builtin __builtin_popcount() for counting the number of 1's in an int or related data type. Nilay On Wed, 6 Apr 2011, Ali Saidi wrote: And actually, couldn't you use an stl bitset for this? Thanks, Ali On Wed, 06 Apr 2011

Re: [m5-dev] Running Ruby w/32 Cores

2011-04-06 Thread Nilay Vaish
I would prefer we make use of GCC builtin __builtin_popcount() for counting the number of 1's in an int or related data type. Nilay On Wed, 6 Apr 2011, Ali Saidi wrote: And actually, couldn't you use an stl bitset for this? Thanks, Ali On Wed, 06 Apr 2011 15:34:01 -0500, Ali Saidi wrote:

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-04 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-04-04 06:22:20.346203) Review request for Default. Summary ---

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-04 Thread Nilay Vaish
ctionality? My bad! I had forgotten to add AbstractMemory.py file. - Nilay --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/#review1090 ----

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-04 Thread Nilay Vaish
> On 2011-03-31 22:08:21, Brad Beckmann wrote: > > This looks great, I just have a few minor suggestions below. > > > > It seems like the next step is to figure out how to deal with functional > > accesses not succeeding in the CPUs and devices. > > Nilay Vais

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-03 Thread Nilay Vaish
> On 2011-03-31 22:08:21, Brad Beckmann wrote: > > This looks great, I just have a few minor suggestions below. > > > > It seems like the next step is to figure out how to deal with functional > > accesses not succeeding in the CPUs and devices. > > Nilay Vais

Re: [m5-dev] Ruby Optimization Opportunity?

2011-04-03 Thread Nilay Vaish
On Fri, 1 Apr 2011, Korey Sewell wrote: That's a good point. I'll coordinate with Nilay offline to get him the right image. Nilay, from your previous optimizations trials, where did you see most of the simulation time being sent at? On Fri, Apr 1, 2011 at 4:48 PM, Ali Saidi wrote: None of

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-02 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-04-02 11:42:47.195024) Review request for Default. Summary ---

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-02 Thread Nilay Vaish
et. I will remove this code. - Nilay --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/#review1082 ------- On

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-02 Thread Nilay Vaish
- Nilay --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/#review1085 --- On 2011-03-31 20:44:17, Nilay Va

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-01 Thread Nilay Vaish
ted e-mail. To reply, visit: http://reviews.m5sim.org/r/611/#review1082 --- On 2011-03-31 20:44:17, Nilay Vaish wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-03-31 Thread Nilay Vaish
write should succeed. However, writes should fail > > if either no Read_Only or ReadWrite copies are found, or if a Busy copy is > > found and no ReadWrite copy is found. The latter situation will likely > > indicate the functional write is racing with a timing write. There is

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-03-31 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-03-31 20:44:17.499794) Review request for Default. Summary ---

Re: [m5-dev] Review Request: Ruby: enable multiple sequencers in one controller.

2011-03-31 Thread Nilay Vaish
> On 2011-03-31 14:22:16, Nilay Vaish wrote: > > I hope you have tested the existing protocols with these changes. > > Lisa Hsu wrote: > Yes - MOESI_[CMP_[directory|token]|hammer] all compile and run -l 1000 -n > 4 on the Ruby Tester. Since no logic has changed (fo

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-03-31 Thread Nilay Vaish
in the protocol? - Nilay --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/#review1054 --- On 2011-03-30 16:19:26, Nilay

Re: [m5-dev] Review Request: Ruby: Simplify SLICC and Entry/TBE handling.

2011-03-31 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/630/#review1066 --- Ship it! Lisa, the changes look fine to me. Just make sure that all the

Re: [m5-dev] Review Request: Ruby: enable multiple sequencers in one controller.

2011-03-31 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/624/#review1065 --- Ship it! I hope you have tested the existing protocols with these change

Re: [m5-dev] Review Request: Ruby: have the rubytester pass contextId to Ruby.

2011-03-31 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/625/#review1064 --- Ship it! - Nilay On 2011-03-31 12:20:59, Lisa Hsu wrote: > >

Re: [m5-dev] Review Request: Ruby: Add new object called WireBuffer to mimic a Wire.

2011-03-31 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/627/#review1063 --- src/mem/ruby/system/WireBuffer.hh

Re: [m5-dev] Review Request: CacheMemory: add allocateVoid() that is == allocate() but no return value.

2011-03-31 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/629/#review1062 --- Ship it! - Nilay On 2011-03-31 12:21:22, Lisa Hsu wrote: > >

Re: [m5-dev] Review Request: Ruby: pass Packet->Req->contextId() to Ruby.

2011-03-31 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/623/#review1060 --- Ship it! Is context Id being used any where? - Nilay On 2011-03-31 12

[m5-dev] Ruby: Protocol.hh

2011-03-31 Thread Nilay Vaish
I am wondering what's the need of the file Protocol.hh, I removed it from different in the protocol independent part of Ruby. I also removed the file standard_1level_CMP-protocol.sm from the MOESI_hammer.slicc. Everything compiles perfectly. I am not sure what the requirement is. -- Nilay

Re: [m5-dev] Ruby Optimization Opportunity?

2011-03-30 Thread Nilay Vaish
Korey, I do not have the FftBase32 benchmark. Is it possible for you to run the simulation with one of the following benchmarks -- IScsiInitiator, IScsiTarget, MutexTest, NetperfMaerts, NetperfStream, NetperfStreamNT, NetperfStreamUdp, NetperfUdpLocal, Nfs, NfsTcp, Nhfsstone, Ping, PovrayAutum

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-03-30 Thread Nilay Vaish
On Tue, 29 Mar 2011, Nilay Vaish wrote: Brad, I have posted on the review board my current implementation for supporting functional accesses in Ruby. This is untested and is mainly meant for furthering the discussions. I have some questions for you -- 1. How do we inform the other end of

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-03-30 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- (Updated 2011-03-30 16:19:26.551926) Review request for Default. Summary ---

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-03-29 Thread Nilay Vaish
memory as well. How can physical memory be accessed from RubyPort? -- Nilay On Tue, 29 Mar 2011, Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim

[m5-dev] Review Request: Ruby: Add support for functional accesses

2011-03-29 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/611/ --- Review request for Default. Summary --- Ruby: Add support for functional acces

Re: [m5-dev] Cron /z/m5/regression/do-regression quick

2011-03-28 Thread Nilay Vaish
I pushed in patch that imports math in MI_example.py -- Nilay On Mon, 28 Mar 2011, Cron Daemon wrote: * build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby FAILED! * build/ALPHA_SE/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby FAILED! * build/ALPHA_SE/t

[m5-dev] changeset in m5: Config: Import math in MI_example.py

2011-03-28 Thread Nilay Vaish
changeset 1333bd6cc2eb in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=1333bd6cc2eb description: Config: Import math in MI_example.py diffstat: configs/ruby/MI_example.py | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diffs (11 lines): diff -r 832ae3727c2b

Re: [m5-dev] Ruby random tester failing with MESI_CMP_directory?

2011-03-23 Thread Nilay Vaish
here Exiting @ tick 14536941 because Ruby Tester completed On Wed, 23 Mar 2011, Nilay Vaish wrote: I will try to bisect this. -- Nilay On Wed, 23 Mar 2011, Arkaprava Basu wrote: Hi Lisa and Nilay, Thanks for the response. Following is the tip of my repo changeset: 8174:e21f6e70169e

Re: [m5-dev] Ruby random tester failing with MESI_CMP_directory?

2011-03-23 Thread Nilay Vaish
I will try to bisect this. -- Nilay On Wed, 23 Mar 2011, Arkaprava Basu wrote: Hi Lisa and Nilay, Thanks for the response. Following is the tip of my repo changeset: 8174:e21f6e70169e tag: tip user:Nilay Vaish date:Tue Mar 22 06:41:54 2011 -0500 summary

Re: [m5-dev] Cron /z/m5/regression/do-regression quick

2011-03-22 Thread Nilay Vaish
On Tue, 22 Mar 2011, nathan binkert wrote: The warnings related to networktest.cc got added yesterday. Tushar should take care of the warnings related to networktest.cc. These I think have been around for quite a while. Either way, we should be eliminating warnings. I will commi

Re: [m5-dev] Cron /z/m5/regression/do-regression quick

2011-03-22 Thread Nilay Vaish
On Tue, 22 Mar 2011, Gabriel Michael Black wrote: The two issues below are copied from ARM_FS, but other targets had the same problems. These errors are making the build fail. build/ARM_FS/cpu/testers/networktest/networktest.cc: In member function 'void NetworkTest::completeRequest(Packet*)'

[m5-dev] changeset in m5: Ruby: Remove CacheMsg class from SLICC

2011-03-22 Thread Nilay Vaish
changeset e21f6e70169e in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=e21f6e70169e description: Ruby: Remove CacheMsg class from SLICC The goal of the patch is to do away with the CacheMsg class currently in use in coherence protocols. In place of CacheM

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

2011-03-20 Thread Nilay Vaish
On Sat, 19 Mar 2011, Nilay Vaish wrote: On Fri, 18 Mar 2011, Lisa Hsu wrote: What's going on with this patch? I don't believe it's been committed but it seems like it should. I've also got some patches waiting behind this because they used to touch CacheMsg and I don&

  1   2   3   4   5   >