Re: questions on Login Security FAQ

2008-09-18 Thread alex.d
What about easy-hashing on the client side like for example md5? Sure, lately there were several reports about possibilities to crack it quicker than expected(a few hours or even minutes) but i haven't seen any working tool to make it work yet. So hasing with md5 on the client side, and than with

Re: GWT on Windows Mobile

2008-09-18 Thread alex.d
Jap. Install Opera and the world is round again ;-) On 17 Sep., 22:30, MaMa [EMAIL PROTECTED] wrote: Hi there I am developing an application that should run on handheld computers. I'm considering to use an application that embedds a browser that shoulds a GWT application. Actually it would

Can't serialize return result containing inner class??

2008-09-18 Thread Barry
Hi, all ... I have a GWT service that is trying to return a class GetDeviceListResult. This class contains an inner class Device. When the client tries to call the service, the GWT serializer is invoked, and it fails to serialize the GetDeviceListResult class, saying that the inner class cannot

Re: Question on parsing JSON string

2008-09-18 Thread Amit Dhingra
Look at this... http://code.google.com/p/derjanandhisblog/wiki/GWTGrailsTutorial Look at the addChildren function. Cheers, Amit On Thu, Sep 18, 2008 at 2:49 AM, ceeed [EMAIL PROTECTED] wrote: Hi, I am gettiing a hash/dictionary from the server as a JSON string. This looks some thing like:

Re: GWT popup query, a generic one

2008-09-18 Thread Thomas Broyer
On 18 sep, 06:54, Ajay Garg [EMAIL PROTECTED] wrote: Hi all. I have been going through PopupPanel docs, and there does exist ways to set the popup-position, eg. through the PopupPanel.PositionCallback and setPopupPosition() methods. But it seems that the position parameters, correspond to

Re: Debugging GWT with Eclipse

2008-09-18 Thread Pierre Mage
Good Morning Amit, I need more precisions to answer your question. Does your application works in running mode (in eclipse) ? Your Debug Configuration should look like this: Java Application Main Project: your Java project Main class: com.google.gwt.dev.GWTShell Arguments

Re: questions on Login Security FAQ

2008-09-18 Thread alex.d
Hi Alex, alex.d schrieb: What about easy-hashing on the client side like for example md5? Sure, lately there were several reports about possibilities to crack it quicker than expected(a few hours or even minutes) but i haven't seen any working tool to make it work yet. You can't

Re: questions on Login Security FAQ

2008-09-18 Thread Lothar Kimmeringer
alex.d schrieb: And if somebody is ready to go the hard way, well, then there is probably not that much you can do about it - if somebody want's to hack you - they will succeed. NPI: Strange point of view. I hope you're not working for a website where I place orders using my credit-cards.

Re: Severe performance problem after upgrading to GWT 1.5.2 (final)

2008-09-18 Thread hbatista
Thanks for the suggestion, but changing data types didn't help. I did not profile my code, but the observed behavior is: 1. RPC call is made 2. server side method runs and returns (quickly!) 3. ... huge delay with no CPU activity ... 4. finally client side onSuccess() RPC callback runs What

Re: questions on Login Security FAQ

2008-09-18 Thread al0
I dare to say that SHA1-weakness is mostly of theoretical value. It is secure enough for any practicaly purpose (save probably digital signing of documents with multiyear lifespan, and protecting of extremely sensitive information that may attract attackers that have in their disposision

mapwidget checkresize() is not working with complicated layout structure

2008-09-18 Thread neversaydie
Hello, I have one question regarding google maps display using MapWidget class. When mapwidget instance in populated with simple Layout like one in the faqs, everything seems to working fine. But when the same instance is set on a following layout say VerticalSplitPanel mainPanel = new

Re: Debugging GWT with Eclipse

2008-09-18 Thread Paul Robinson
Arguments Program arguments: -out www eu.future.earth.gwt.MainDemoApp/MainDemoApp.html VM arguments: -Xmx256m Classpath: Following are the contents of my .classpath file ** ?xml version=1.0 encoding=UTF-8? classpath classpathentry kind=con

Re: Debugging GWT with Eclipse

2008-09-18 Thread Amit Dhingra
Hi Paul, I actually have imported the ftr-gwt-demo project in eclipse and have provided the ftr-gwt-library-date-0.9.5.jar file as external jars. And moreover I am able to run the application with the cmd files. Regards, Amit On Thu, Sep 18, 2008 at 3:23 PM, Paul Robinson [EMAIL PROTECTED]

Re: gwt-widgets with 1.5.2

2008-09-18 Thread [EMAIL PROTECTED]
Hi I am having a similar problem using the same versions of GWT and gwtwidgets, trying to show() a Lightbox object : [ERROR] Uncaught exception escaped java.lang.AssertionError: Element may only be set once at com.google.gwt.user.client.ui.UIObject.setElement(UIObject.java: 802)

Re: Does the server side language matter?

2008-09-18 Thread walden
Hi Thomas, Thanks for spelling that out. I do agree that GWT RPC might be less cache-friendly out of the box. As far as the folder templates story, while I understand that the ACL list is cacheable for hours at a time, it seems to me that if folder content is allowed to change in realtime, or

TabBar / DecoratedTabBar CSS Style needed

2008-09-18 Thread [EMAIL PROTECTED]
Hi everybody, Can someone share with CSS Styles for TabBar / DecoratedTabBar. I am new to CSS and don't know how define the properties. Also if you have code for a comprehensive TabBar with close button, change tab name, please post it. Thanks, yf

RFE: Allow constants in non-client-packages to be refereced

2008-09-18 Thread Lothar Kimmeringer
Hello, I'm not sure if this is the right list but I've got a request for enhancement after stumbling over that more and more: Can the GWT-compiler changed in that way that it allows constants defined in classes that don't reside in the client-package to be referenced. I've got here a couple of

Re: Debugging GWT with Eclipse

2008-09-18 Thread Thomas Broyer
On 18 sep, 11:35, Amit Dhingra [EMAIL PROTECTED] wrote: Hi, Well, I wasn't providing the arguments to the debugger, and hence it was not opening the hosted browser. Thanks a lot for the tips!!! But even after providing the arguments, I am facing problems. I have done the following... Java

Re: Can't get my result in plain text :(

2008-09-18 Thread Marcelo Emanoel
Hi again guys I've managed to solve the problem with more search this is what I've done: String results = event.getResults(); HTML htmlResult = new HTML(results); Window.alert(htmlResult.getText()); The result was the number I've sent on the

OnFailure getting executed even though server code does not return any errors

2008-09-18 Thread Ryan
Hi everyone, I am facing a peculiar problem. I have a server class which returns me an EntityList object. The EntityList class is defined as follows public class EntityList extends ArrayListEntity Here Entity is a class which extends serializable public interface Entity extends Serializable

Re: OnFailure getting executed even though server code does not return any errors

2008-09-18 Thread Lothar Kimmeringer
Ryan schrieb: But on the client side instead of returning to onSuccess function the applications runs the onFailure function with the error http code of 500. HTTP-Code 500 means something went wrong on the server-side. Inside the log of the server there should be an error-message with a

Re: Does the server side language matter?

2008-09-18 Thread Thomas Broyer
On 18 sep, 14:06, walden [EMAIL PROTECTED] wrote: Hi Thomas, Thanks for spelling that out. I do agree that GWT RPC might be less cache-friendly out of the box. And that was my main point (if you're a pragmatic developer ;-) ) (along with conditional GETs which you'd have to emulate with

NullPointerException compiling Gadget

2008-09-18 Thread joseanquiles
I have followed the GWT Gadget tutorial. When I try to compile it, I get the following error: Compiling module es.tid.keops.gadget.SimpleGadget Exception in thread main java.lang.NullPointerException at

Re: Reporting tool and GWT

2008-09-18 Thread Arthur Kalmenson
If you're looking for charting, you can also check out Google Visualization API: http://code.google.com/apis/visualization/. The Google Library API for GWT (GALGWT) project is currently working on integrating Google Visualization API. On Sep 16, 7:10 am, Manik [EMAIL PROTECTED] wrote: Hi, I

Re: OnFailure getting executed even though server code does not return any errors

2008-09-18 Thread Ryan
Is this something to do with the Serializable class??? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to Google-Web-Toolkit@googlegroups.com To

Re: Debugging GWT with Eclipse

2008-09-18 Thread Amit Dhingra
Thanks !!! That did the job. Cheers, Amit On Thu, Sep 18, 2008 at 5:53 PM, Thomas Broyer [EMAIL PROTECTED] wrote: On 18 sep, 11:35, Amit Dhingra [EMAIL PROTECTED] wrote: Hi, Well, I wasn't providing the arguments to the debugger, and hence it was not opening the hosted browser. Thanks

Re: GWT on Windows Mobile

2008-09-18 Thread John
On Sep 17, 4:30 pm, MaMa [EMAIL PROTECTED] wrote: I think IExplorer on Windows Mobile does not support JavaScript. Well, depending on which version of Windows Mobile and which phone you have, there seem to be varying levels of support for Javascript. I've had similar experiene when trying GWT

Breaking up is hard to do

2008-09-18 Thread ben
So I'm starting to get fancy with my organization with our could. We actually have several GWT efforts going on, so we want common code sets. We were able to break up our Client side code into seperate .jar files, and include them into our overall applications just fine. Well now, I've gone and

Re: questions on Login Security FAQ

2008-09-18 Thread Reinier Zwitserloot
JasonG: Thanks for being a nice example of the cluelessness of your average programmer. You've got it all, totally, 100% backwards. Don't feel too insulted, you're like almost everyone else out there. However, you should most definitely stop handing out security advice. Seriously. A) J2EE

Re: wrong behaviour in tab panel

2008-09-18 Thread pepinfor
Searching into the forum I found that the cause is the split panel: see http://groups.google.com/group/Google-Web-Toolkit/browse_thread/thread/7ca416b698acf0c8/07f120fa24f5dc8b?lnk=gstq=splitpanel#07f120fa24f5dc8b --~--~-~--~~~---~--~~ You received this message

Re: Ant Junit GwtTest

2008-09-18 Thread Charlie Collins
GWTTestCase based tests (and GWTTestSuite, which is a great time saver) can be run by ant, yes. Ant, after all, can run the test runner the same way the junitcreator generated shell script does. Your issue is probably related to the source path or classpath. Make sure you either put your test

Re: Can't serialize return result containing inner class??

2008-09-18 Thread Charlie Collins
I am not sure of the status of this, but yes, there is an issue related to that still open: http://code.google.com/p/google-web-toolkit/issues/detail?id=811q=inner%20class. A non static inner class is probably a bit tricky (not impossible though) for a source code analyzer/compiler to deal

Re: Annoucement. PureMVC4GWT RC is available

2008-09-18 Thread Luciano Broussal
Hope this help eggsy84. PureMVC userguide is very well documented i think and explain also so obvious design errors. Thanks. Luciano On 17 sep, 16:27, eggsy84 [EMAIL PROTECTED] wrote: Hi there I have never encountered PureMVC but have been developing using GWT for around 10 months now.

Re: questions on Login Security FAQ

2008-09-18 Thread Rob Coops
Always fun to read a Reinier comment to pretty much anyone. Seriously Reinier though you usualy are quite correct with your facts and knowledge you might try to leave the baseball bat on the filed and not bash someonce head in for a change. I would not be surprized if people are scared to post

Re: mapwidget checkresize() is not working with complicated layout structure

2008-09-18 Thread Eric Ayers
I don't understand. You set your map widget to a fixed 200 x 200 pixel size. What do you expect checkResize() to do? Maybe you need to set the size using relative values (100%,100%)? On Thu, Sep 18, 2008 at 5:46 AM, neversaydie [EMAIL PROTECTED] wrote: Hello, I have one question regarding

Re: GWT And HTTPServlet

2008-09-18 Thread sim123
I have done that, but class is not found :( On Sep 18, 2:23 am, Pierre Mage [EMAIL PROTECTED] wrote: Hi sim123, If you are working with GWTShell, you should specify your servlet in your GWT module (*.gwt.xml file) just like RPC servlets. -- Pierre On Sep 18, 2:26 am, sim123 [EMAIL

Re: mapwidget checkresize() is not working with complicated layout structure

2008-09-18 Thread neversaydie
if i set it 100% 100% then the map gets too small. it is not getting resized to its outer panel. so i dont know what to do to resize it .. when the page refresh is cliked. On Sep 18, 5:15 pm, Eric Ayers [EMAIL PROTECTED] wrote: I don't understand. You set your map widget to a fixed 200 x 200

Re: Breaking up is hard to do

2008-09-18 Thread ben
I seemed to have it working now, by putting in the servlet register code into the core.gwt.xml and not in the main app location. But the weird thing is that when it loads I get all those errors still (the items not supported by GWT -- BufferedReader, java.net etc). But everything still seems to

Re: mapwidget checkresize() is not working with complicated layout structure

2008-09-18 Thread Eric Ayers
Look at the FAQ for making a widget fill a browser window. http://code.google.com/docreader/#p=google-web-toolkit-doc-1-5s=google-web-toolkit-doc-1-5t=FAQ_UIVerticalFillApp Unfortunately, I believe that SplitPanel is missing the requisite callback for a resize event to make the same trick work

RE: Warning about using float fields with RPC (shocking bug)

2008-09-18 Thread Perelman Nathan (Nathan)
I doubt that this will be resolved since all numbers in JavaScript are treated as doubles. I'm not really sure what the correct translation of floats in client side Java code should be, but just treating them as doubles seems like a reasonable solution. Also, the serializer has no way of knowing

Re: questions on Login Security FAQ

2008-09-18 Thread Reinier Zwitserloot
We need to invent a TCP/IP compatible cluestick on the double! On Sep 18, 6:36 pm, Ian Petersen [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 11:31 AM, Rob Coops [EMAIL PROTECTED] wrote: Always fun to read a Reinier comment to pretty much anyone. Seriously Reinier though you usualy are

Re: Does the server side language matter?

2008-09-18 Thread Jim Freeze
On Tue, Sep 16, 2008 at 1:41 PM, John [EMAIL PROTECTED] wrote: Thanks for the suggestions everyone. Definitely some things to think about in them. I probably should have explained that I am looking at things more from an architecture design view. I am not likely going to do very much

Re: Does the server side language matter?

2008-09-18 Thread Jim Freeze
Hi Lothar On Tue, Sep 16, 2008 at 2:27 PM, Lothar Kimmeringer [EMAIL PROTECTED] wrote: Oh boy, you lost me. I'm not sure your point, but dynamic languages have the ability to test the server side in a runtime environment. Maybe we should talk about the word test here. Do you mean trying

Re: Does the server side language matter?

2008-09-18 Thread Jim Freeze
Hi gregor On Tue, Sep 16, 2008 at 3:16 PM, gregor [EMAIL PROTECTED] wrote: I have to ask on what basis you presume to venture such forthright views on this post given that by your own admission you don't have either the knowledge or the experience to back them up. I understand that you like

Re: NullPointerException compiling Gadget

2008-09-18 Thread Eric Ayers
My guess it the the problem is releated to this issue: http://code.google.com/p/gwt-google-apis/issues/detail?id=164 -Eric. On Thu, Sep 18, 2008 at 9:16 AM, joseanquiles [EMAIL PROTECTED] wrote: I have followed the GWT Gadget tutorial. When I try to compile it, I get the following error:

Re: Can't serialize return result containing inner class??

2008-09-18 Thread Barry
Indeed, turning the inner class to static was just the thing. The inner class was acting only as a bean anyway. And the more I think about it, the more I realize that I should be creating inner classes as static by default anyway ... perhaps this is how Java should have been spec'd in the first

About RPC

2008-09-18 Thread sunny_zhou
When server has to send a complicated POJO to client,it cost about ten seconds. However,when it compiled to js,it won't take a second. Is there anything we can do to accelerate when such RPC has to run in GWT's hosted web? --~--~-~--~~~---~--~~ You received this

RichTextToolbar

2008-09-18 Thread Michael Neale
Is there any reason why RichTextToolbar is not including as part of GWT but is only as a sample ? (in the Showcase project)? Shouldn't this really be part of GWT itself, I mean the text area is not terribly helpful without it, and it seems a bit odd to create it each time (it is a bit tedious).

Re: Google Maps - Problems when viewing the map

2008-09-18 Thread Micky
Bingo Guillem! Thanks. On Aug 28, 2:35 pm, Einstein0970 [EMAIL PROTECTED] wrote: Thanks Guys, the map.checkResize(); solved my poblem too. - Erick On Jul 24, 11:59 am, Guillem [EMAIL PROTECTED] wrote: I don't know if you already fixed this, but I'll share what I've found. In my app,

[gwt-contrib] Re: DateBox not working in Chrome

2008-09-18 Thread Emily Crutcher
Thanks! Can you add an issue report about this problem? As that will help us track it. http://code.google.com/p/google-web-toolkit-incubator/issues/entry On Thu, Sep 18, 2008 at 7:36 AM, rockster [EMAIL PROTECTED] wrote: Hi, in hosted mode I see the DateBox working as expected. In Chrome I

[gwt-contrib] Re: Code Review: gwt-google-apis Maps issue 170 - InfoWindow should be Overlay subclass

2008-09-18 Thread Miguel Méndez
Should InfoWindow be included in this patch? Shouldn't the Overlay.createPeer method perform the tests on the JavaScriptObject and return the correct concrete wrapper class? On Tue, Sep 16, 2008 at 2:19 PM, Eric Ayers [EMAIL PROTECTED] wrote: Hello Miguel, I would like you to review the

[gwt-contrib] Re: Code Review Request - Issue 2667 - Style should assert that property names do not contain hyphens

2008-09-18 Thread John LaBanca
I meant to reply to this yesterday and comment about this. This falls into a similar category as the assertions on event properties that we removed, BUT I do not know of a single case where a hyphen is okay, so its a little different. If anyone does know of such a case, we should probably not

[gwt-contrib] Re: Code Review Request - Issue 2667 - Style should assert that property names do not contain hyphens

2008-09-18 Thread Fred Sauer
I think this is a very valuable assertion, which has the potential to save many new comers (and even veterans) a lot of grief. If somehow a couple of valid hyphen use cases came up, I'd probably try to special case them and keep the assertion if at all possible. Fred Sauer [EMAIL PROTECTED] On

[gwt-contrib] Re: Code Review: gwt-google-apis Maps issue 170 - InfoWindow should be Overlay subclass

2008-09-18 Thread Eric Ayers
Hi Miguel, These are all good suggestions, especially the one about including all of the source code. I've updated the patch. On Thu, Sep 18, 2008 at 9:48 AM, Miguel Méndez [EMAIL PROTECTED] wrote: Should InfoWindow be included in this patch? Shouldn't the Overlay.createPeer method perform

[gwt-contrib] Re: Code Review: gwt-google-apis Search LocalSearch.getCenterPoint() accepts Maps LatLng

2008-09-18 Thread Eric Ayers
Thanks for the review. Committed as r800 to the 1.0 release branch. On Thu, Sep 18, 2008 at 10:07 AM, Miguel Méndez [EMAIL PROTECTED] wrote: LGTM On Wed, Sep 17, 2008 at 3:22 PM, Eric Ayers [EMAIL PROTECTED] wrote: Hello Miguel, This patch adds an overload to

[gwt-contrib] Code Review Request - Issue 32 - form.reset method

2008-09-18 Thread John LaBanca
Alex - Issue 32! Why haven't we addressed this simple fix yet? Description: We need a FormPanel.reset() method to programatically reset a form. Fix: === Added it. All browsers support form.reset() natively, so this is a trivial addition. Testing: == Manually tested on all main

[gwt-contrib] Re: Code Review: gwt-google-apis add Google Earth map type

2008-09-18 Thread Eric Ayers
Hello Miguel, Attached is a modified version of the patch was originally put forth by Jesse Crossley to address issue 128 133. http://code.google.com/p/gwt-google-apis/issues/detail?id=128 http://code.google.com/p/gwt-google-apis/issues/detail?id=133 I've modified it to use the Handler pattern

[gwt-contrib] Re: Code Review Request - Issue 1385 - TextBoxBase.selectAll/getSelectedText throws exception

2008-09-18 Thread John LaBanca
The problem is, we can't assert that the element isn't visible because that isn't an efficient or reliable thing to check, and we don't really want to throw an exception at runtime in FF if somebody is developing in IE and may not test FF thoroughly. So, I think its better to fail cleanly. If

[gwt-contrib] Re: Code Review: gwt-google-apis add Google Earth map type

2008-09-18 Thread Miguel Méndez
A maps/maps/src/com/google/gwt/maps/client/event/EarthInstanceHandler.java LG M maps/maps/src/com/google/gwt/maps/client/impl/MapImpl.java LG M maps/maps/src/com/google/gwt/maps/client/MapWidget.java 1408 - Javadoc? M

[gwt-contrib] Re: RR:JS collections

2008-09-18 Thread John Tamplin
This is not a complete review, but some initial feedback: - Shouldn't the selenium changes be part of a separate patch? Regardless, Freeland or Eric would be better to review that portion. - Did you read the

[gwt-contrib] Re: Code Review Request - Issue 1385 - TextBoxBase.selectAll/getSelectedText throws exception

2008-09-18 Thread Emily Crutcher
I'm not entirely sure I understand why you can't use the slightly more efficient check in getSelectedText(), but as that is only a speed optimization , LGTM. On Thu, Sep 18, 2008 at 3:40 PM, John LaBanca [EMAIL PROTECTED] wrote: IE throws an exception if the cursorPos is negative, whereas the

[gwt-contrib] Re: Code Review: gwt-google-apis add Google Earth map type

2008-09-18 Thread Eric Ayers
Updated patch attached. On Thu, Sep 18, 2008 at 3:08 PM, Miguel Méndez [EMAIL PROTECTED] wrote: A maps/maps/src/com/google/gwt/maps/client/event/EarthInstanceHandler.java LG M maps/maps/src/com/google/gwt/maps/client/impl/MapImpl.java LG Removed hideControls() and showControls()

[gwt-contrib] [google-web-toolkit commit] r3666 - in trunk/user: src/com/google/gwt/user/client/ui src/com/google/gwt/user/client/ui/impl t...

2008-09-18 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Sep 18 13:12:44 2008 New Revision: 3666 Modified: trunk/user/src/com/google/gwt/user/client/ui/TextBoxBase.java trunk/user/src/com/google/gwt/user/client/ui/impl/TextBoxImpl.java

[gwt-contrib] Re: Code Review: gwt-google-apis add Google Earth map type

2008-09-18 Thread Miguel Méndez
LGTM! On Thu, Sep 18, 2008 at 3:49 PM, Eric Ayers [EMAIL PROTECTED] wrote: Updated patch attached. On Thu, Sep 18, 2008 at 3:08 PM, Miguel Méndez [EMAIL PROTECTED] wrote: A maps/maps/src/com/google/gwt/maps/client/event/EarthInstanceHandler.java LG M

[gwt-contrib] Re: RR:JS collections

2008-09-18 Thread John Tamplin
On Thu, Sep 18, 2008 at 3:44 PM, Emily Crutcher [EMAIL PROTECTED] wrote: Yep, that was already committed to gwt-incubator trunk, the patch is older then the commit. Ok, so I should ignore that, right? - Did you read the

[gwt-contrib] Re: Code Review: gwt-google-apis add Google Earth map type

2008-09-18 Thread Eric Ayers
Thanks. committed as r803. That was the last issue marked for RC1! On Thu, Sep 18, 2008 at 4:17 PM, Miguel Méndez [EMAIL PROTECTED] wrote: LGTM! On Thu, Sep 18, 2008 at 3:49 PM, Eric Ayers [EMAIL PROTECTED] wrote: Updated patch attached. On Thu, Sep 18, 2008 at 3:08 PM, Miguel Méndez

[gwt-contrib] Re: Code Review: gwt-google-apis add Google Earth map type

2008-09-18 Thread Miguel Méndez
Sweet!!! On Thu, Sep 18, 2008 at 4:32 PM, Eric Ayers [EMAIL PROTECTED] wrote: Thanks. committed as r803. That was the last issue marked for RC1! On Thu, Sep 18, 2008 at 4:17 PM, Miguel Méndez [EMAIL PROTECTED] wrote: LGTM! On Thu, Sep 18, 2008 at 3:49 PM, Eric Ayers [EMAIL PROTECTED]

[gwt-contrib] Re: Code Review Request - Issue 1385 - TextBoxBase.selectAll/getSelectedText throws exception

2008-09-18 Thread Emily Crutcher
Thanks! On Thu, Sep 18, 2008 at 4:13 PM, John LaBanca [EMAIL PROTECTED] wrote: committed as r3666 I see what you are saying about the more efficient version, so I changed it to the following where we don't get the length unless we need to: public String getSelectedText() { int

[gwt-contrib] Re: Code Review Request - Issue 2667 - Style should assert that property names do not contain hyphens

2008-09-18 Thread Joel Webber
I think we're all in agreement, then. We can back out if absolutely necessary, but this will definitely clear up a lot of confusion. LGTM++. On Thu, Sep 18, 2008 at 10:10 AM, Fred Sauer [EMAIL PROTECTED] wrote: I think this is a very valuable assertion, which has the potential to save many new

[gwt-contrib] Re: Code Review Request - Issue 2667 - Style should assert that property names do not contain hyphens

2008-09-18 Thread John LaBanca
committed as r3667 Thanks, John LaBanca [EMAIL PROTECTED] On Thu, Sep 18, 2008 at 6:19 PM, Joel Webber [EMAIL PROTECTED] wrote: I think we're all in agreement, then. We can back out if absolutely necessary, but this will definitely clear up a lot of confusion. LGTM++. On Thu, Sep 18, 2008

[gwt-contrib] [google-web-toolkit commit] r3667 - in trunk/user: src/com/google/gwt/dom/client test/com/google/gwt/dom/client

2008-09-18 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Sep 18 17:16:14 2008 New Revision: 3667 Modified: trunk/user/src/com/google/gwt/dom/client/Style.java trunk/user/test/com/google/gwt/dom/client/ElementTest.java Log: Added an assertion that style attribute names do not contain a hyphen. Users

[gwt-contrib] Proposed API Addition - TabBar.setTabEnabled(int, boolean)

2008-09-18 Thread John LaBanca
Contributors - I propose adding the following method to TabBar: public void setTabEnabled(int index, boolean enabled) When disabled, a tab will be assigned the additional style gwt-TabBarItem-disabled, and the user will not be able to select the tab using the mouse or keyboard. The style