Reviewers: jlabanca,
Description:
http://code.google.com/p/google-web-toolkit-incubator/issues/detail?id=232
Please review this at http://gwt-code-reviews.appspot.com/14802
Affected files:
client/FastTree.java
Index: client/FastTree.java
On 26 mar, 19:18, John Tamplin j...@google.com wrote:
On Thu, Mar 26, 2009 at 1:40 PM, Scott Blum sco...@google.com wrote:
That's not good it looks like Nicolas found an object for which trying
to evaluate (!!o.nodeType) throws an exception.
If my atrophied high-school French is
Thanks, John! It's in at r5094 and r5095. Comments inline:
On Thu, Mar 26, 2009 at 4:31 PM, John Tamplin j...@google.com wrote:
Passing the parameter all the way down this way is ugly, but I don't know of
any better ways to do it.
Agreed.
I would prefer the new ArgHandler to be a
Author: sp...@google.com
Date: Fri Mar 27 07:58:53 2009
New Revision: 5094
Added:
trunk/user/src/com/google/gwt/junit/RunStyleNoServerHosted.java
(contents, props changed)
Modified:
trunk/user/build.xml
trunk/user/src/com/google/gwt/junit/JUnitShell.java
The attached patch re-adds image de-duplication to ClientBundle's
ImageBundleBuilder. (It was there at some point, but disappeared along
the way). The patch also ensures that the ImageResource test is run
in a no-inlining permutation, which would have allowed me to see this
error on my mac.
Author: sp...@google.com
Date: Fri Mar 27 08:09:11 2009
New Revision: 5095
Modified:
trunk/dev/core/src/com/google/gwt/dev/GWTShell.java
trunk/dev/core/src/com/google/gwt/dev/shell/GWTShellServlet.java
trunk/dev/core/src/com/google/gwt/dev/shell/tomcat/EmbeddedTomcatServer.java
Kindly enable my tooling dependency:
http://gwt-code-reviews.appspot.com/new
rjrjr
On Fri, Mar 27, 2009 at 8:21 AM, BobV b...@google.com wrote:
The attached patch re-adds image de-duplication to ClientBundle's
ImageBundleBuilder. (It was there at some point, but disappeared along
the way).
Do you know what event this was? What do you do with the popup to get it to
trigger? Or does it just happen with no user interaction?
On Fri, Mar 27, 2009 at 11:46 AM, nicolas de loof
nicolas.del...@gmail.comwrote:
Some more infos :
We got this exception running in hosted mode browser (with
[java] Compiling module com.google.gwt.benchmarks.viewer.ReportViewer
[java] #
[java] # An unexpected error has been detected by Java Runtime
Environment:
[java] #
[java] # SIGSEGV (0xb) at pc=0x0625665c, pid=17105, tid=3762477968
[java] #
[java] # Java VM: Java
Misused rietveld and dropped my comments:
http://gwt-code-reviews.appspot.com/15802/diff/1/6
File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java
(right):
http://gwt-code-reviews.appspot.com/15802/diff/1/6#newcode434
Line 434: gwt.imageResource.maxBundleSize, 256);
Please mention
http://gwt-code-reviews.appspot.com/15802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Scott, we already talked about this, but here's the patch for public review.
The basic goal is to surface the native length, sort, push, and shift
operators for JsArrays... I know you mentioned that IE6's push may be slower
than indexed extension, and thus a candidate for deferred binding, but I
Let's not add this extra type JsArrayBase into the hierarchy. Why can't we
just push the various methods down? We can always factor upward in the
future. If we need shared implementation, we can factor that out into a
package-private JsArrayImpl class.
On Fri, Mar 27, 2009 at 1:28 PM, Freeland
I tried to use my own custom class that extends AsyncCallback in the async
interface, the compiler told me that the async version didn't match the
sync version.
For instance: public interface NoResultCallback extends
AsyncCallbackVoid. It's not really an issue, but I prefer to use the more
I can has hs_err_pid17105.log?
On Fri, Mar 27, 2009 at 12:36 PM, Vitali Lovich vlov...@gmail.com wrote:
[java] Compiling module com.google.gwt.benchmarks.viewer.ReportViewer
[java] #
[java] # An unexpected error has been detected by Java Runtime
Environment:
[java] #
FWIW, in another little project I used a pattern for this that avoids
implementation inheritance that I call self-delegation.
Here's an example:
/** Not put API, but it includes the impl for al getters and setters for all
types. **/
final class JsArray extends JavaScriptObject {
...
public int
I'm going to punt this review to Bruce Kelly, 'cause I have no idea why
having JsArrayBase would be bad. :)
On Fri, Mar 27, 2009 at 1:28 PM, Freeland Abbott gwt.team.fabb...@gmail.com
wrote:
Scott, we already talked about this, but here's the patch for public
review.
The basic goal is to
I think the argument is more for unnecessary rather than bad...
although without JsArrayBase (we can make it package-protected, and call it
JsArrayImpl if anyone cares), we duplicate the JSNI implementation for a
couple trivial methods. I thought refactoring them into one place was nice,
Ugggh... you want me to do all the work don't you :D
On a separate note 5094 compilation is broken (JUnitShell fails to
compile). In 5096 the problem is resolved.
On Fri, Mar 27, 2009 at 2:03 PM, Scott Blum sco...@google.com wrote:
I can has hs_err_pid17105.log?
On Fri, Mar 27, 2009 at
Author: sp...@google.com
Date: Fri Mar 27 11:15:17 2009
New Revision: 5096
Modified:
trunk/tools/api-checker/config/gwt15_16userApi.conf
Log:
Adds an entry to the API checker's config files to reflect
the newly added class RunStyleNoServerHosted.
Patch by: spoon,amitmanjhi
Review by:
hmm... i looked and there appears to be a simple fix.
private static String computeInternalSignature(JMethod method) {
StringBuffer sb = new StringBuffer();
sb.setLength(0);
sb.append(method.getName());
JParameter[] params = method.getParameters();
int i = 0;
for
You can also has the hs_err for the 32-bit vm
On Fri, Mar 27, 2009 at 2:26 PM, Vitali Lovich vlov...@gmail.com wrote:
Ugggh... you want me to do all the work don't you :D
On a separate note 5094 compilation is broken (JUnitShell fails to
compile). In 5096 the problem is resolved.
On Fri,
Sorry - forgot to mention that this happened when I tried to load the
hosted mode browser.
On Fri, Mar 27, 2009 at 3:57 PM, Vitali Lovich vlov...@gmail.com wrote:
Might be related. Just set up my project to run under the regular
hosted mode w/ 32-bit JVM:
LoadPlugin: failed to initialize
Ok - i'm almost positive it is the same problem. I think the
loadplugin thing is a misdirection. The project appears to crash
compiling the code.
On Fri, Mar 27, 2009 at 3:59 PM, Vitali Lovich vlov...@gmail.com wrote:
Sorry - forgot to mention that this happened when I tried to load the
With my stupid question about the test answered offline, LGTM
http://gwt-code-reviews.appspot.com/15802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Kelly, since you have experience with this, I'd like you to be the decider
(i.e. Freeland is now waiting on your LGTM).
On Fri, Mar 27, 2009 at 2:16 PM, Freeland Abbott gwt.team.fabb...@gmail.com
wrote:
I think the argument is more for unnecessary rather than bad...
although without
Is there by any chance a public git repository (preferably one that
tracks trunk fairly closely)? git svn clone takes forever.
Thanks
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Author: sco...@google.com
Date: Fri Mar 27 15:01:35 2009
New Revision: 5098
Modified:
releases/1.6/distro-source/core/src/COPYING
releases/1.6/distro-source/core/src/COPYING.html
releases/1.6/distro-source/core/src/about.html
releases/1.6/distro-source/core/src/about.txt
Log:
We don't have a public one... but I do have a repo with the whole svn
history in it that would git you started. You can grab a copy from a
personal webpage of mine...
http://www.shaftnet.org/~sinth/gwt-repo.tgz
Just download, unpack, checkout, and you should be g2g. git svn fetch isn't
so
Thx. The initial checkout's a pain because Google code also limits
you to like 50 kbs/s
On Fri, Mar 27, 2009 at 6:34 PM, Scott Blum sco...@google.com wrote:
We don't have a public one... but I do have a repo with the whole svn
history in it that would git you started. You can grab a copy
30 matches
Mail list logo
