Reviewers: hermes_google.com,
Message:
Okay, Hermes, you asked for it. This is the second half of the monster
you reviewed for me on Monday. Again, if you won't be able to take it
soon, please let me know. Either way, thanks a bunch.
Description:
Completes the move of AttributeParsers from
On 2009/11/04 03:58:02, Ray Ryan wrote:
Review, please.
LGTM.
http://gwt-code-reviews.appspot.com/89821
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: bobv,
Please review this at http://gwt-code-reviews.appspot.com/93801
Affected files:
M samples/mail/src/com/google/gwt/sample/mail/client/MailDetail.java
M samples/mail/src/com/google/gwt/sample/mail/client/MailList.java
M
Revision: 6637
Author: r...@google.com
Date: Wed Nov 4 07:16:01 2009
Log: Merge tr...@6520 into this branch
Fix javadoc tag errors
svn merge --ignore-ancestry -c 6520
http://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=6637
LGTM
http://gwt-code-reviews.appspot.com/93801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6638
Author: j...@google.com
Date: Wed Nov 4 07:24:16 2009
Log: Combined merge of /trunk c6624, c6631, c6635 (the latter two to avoid
checkstyle errors).
http://code.google.com/p/google-web-toolkit/source/detail?r=6638
Added:
Most of these don't really apply to GWTShell either -- they should be
on
Compiler (etc) and JUnitShell (since it can run the compiler for
web-mode
tests).
New patch uploaded that moves all of the compiler-eqsue flags over to
JUnitShell.
http://gwt-code-reviews.appspot.com/92804
Revision: 6639
Author: r...@google.com
Date: Wed Nov 4 07:30:47 2009
Log: Merge tr...@6609 into this branch
Avoid calling overridable methods from constructors to avoid subclassing
glitches
svn merge --ignore-ancestry -c 6609
http://google-web-toolkit.googlecode.com/svn/trunk/ .
On 2009/11/04 15:25:37, bobv wrote:
LGTM
Thanks, committed at r6640.
http://gwt-code-reviews.appspot.com/93801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6640
Author: j...@google.com
Date: Wed Nov 4 07:47:35 2009
Log: Renaming LayoutComposite to ResizeComposite (name drift). This is a new
API so the change shouldn't affect anyone.
http://code.google.com/p/google-web-toolkit/source/detail?r=6640
Added:
LGTM assuming ant test still works.
http://gwt-code-reviews.appspot.com/92804
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6641
Author: j...@google.com
Date: Wed Nov 4 07:51:58 2009
Log: Merge of /trunk c6640.
http://code.google.com/p/google-web-toolkit/source/detail?r=6641
Added:
/releases/2.0/user/src/com/google/gwt/user/client/ui/ResizeComposite.java
Deleted:
Are we never going to re-enable compilation from the Swing UI?
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On Wed, Nov 4, 2009 at 11:18 AM, Scott Blum sco...@google.com wrote:
Are we never going to re-enable compilation from the Swing UI?
I didn't think that was on the table for 2.0, so in the interest of
minimizing confusion, the options should be removed.
--
Bob Vawter
Google Web Toolkit Team
On Wed, Nov 4, 2009 at 12:18 PM, Scott Blum sco...@google.com wrote:
Are we never going to re-enable compilation from the Swing UI?
Not in 2.0, and even then it would probably be better to expose those
options graphically rather than requiring them to restart DevMode if they
want to change to
I believe I already fixed these?
On Wed, Nov 4, 2009 at 6:55 AM, Joel Webber j...@google.com wrote:
Fixes checkstyle errors in LayoutCommand:
http://code.google.com/p/google-web-toolkit/source/detail?r=6635
--~--~-~--~~~---~--~~
I got a bit confused while catching up on reviews this morning. Either way,
though, there was a missing period that checkstyle was bitching about.
On Wed, Nov 4, 2009 at 11:29 AM, Ray Ryan rj...@google.com wrote:
I believe I already fixed these?
On Wed, Nov 4, 2009 at 6:55 AM, Joel Webber
Sold.
On Wed, Nov 4, 2009 at 11:27 AM, John Tamplin j...@google.com wrote:
On Wed, Nov 4, 2009 at 12:18 PM, Scott Blum sco...@google.com wrote:
Are we never going to re-enable compilation from the Swing UI?
Not in 2.0, and even then it would probably be better to expose those
options
Revision: 6642
Author: b...@google.com
Date: Wed Nov 4 08:32:00 2009
Log: Shuffle startup ArgHandlers around so that options irrelevant to
DevMode don't show up in its help page.
Patch by: bobv
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6642
Modified:
Revision: 6643
Author: br...@google.com
Date: Wed Nov 4 08:40:20 2009
Log: Forgetting a namespace prefix on a child elem of DockLayoutPanel causes
an NPE, for example:
g:DockLayoutPanel unit=PCT
westg:HTMLPanelfoo/g:HTMLPanel/west
east/east
/g:DockLayoutPanel
Unfortunately, even after the
Thanks for the patch, Bruce. It's is a bit more complicated than it needs to
be, though (if parent doesn't have a prefix it will never get parsed), and
still doesn't fix the confusing error message. How does the attached look?
rjrjr
On Wed, Nov 4, 2009 at 7:05 AM, j...@google.com wrote:
On
I just committed to trunk but haven't merged to 2.0. Feel free to roll
mine back and do something better.
On Wednesday, November 4, 2009, Ray Ryan rj...@google.com wrote:
Thanks for the patch, Bruce. It's is a bit more complicated than it needs to
be, though (if parent doesn't have a prefix
Will do.
On Wed, Nov 4, 2009 at 8:51 AM, Bruce Johnson br...@google.com wrote:
I just committed to trunk but haven't merged to 2.0. Feel free to roll
mine back and do something better.
On Wednesday, November 4, 2009, Ray Ryan rj...@google.com wrote:
Thanks for the patch, Bruce. It's is a
Bob V has graciously taken custody.
http://gwt-code-reviews.appspot.com/92805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6645
Author: rj...@google.com
Date: Wed Nov 4 09:18:51 2009
Log: HasHTML extends HasText, so there is no need for these widgets to
declare both
interfaces. And the fact that they do makes UiBinder treat their content as
text
rather than HTML. The UiBinder fix would be hard, maybe
Reviewers: Ray Ryan, bruce, Dan Rice,
Description:
SwingWorker uses a pool of threads to run background tasks, and we
weren't actually using the background portion of this. Having multiple
threads processing SwingWorker calls made ordering a problem (which
resulted in some nodes being added to
Okay, now it's a JUnitShell argument. I got a desk LGTM from Amit, but
would like broader buy-in before I add a new publicly visible argument.
Scott? Freeland?
http://gwt-code-reviews.appspot.com/89819
--~--~-~--~~~---~--~~
ping
Thanks,
John LaBanca
jlaba...@google.com
On Tue, Nov 3, 2009 at 4:22 PM, John LaBanca jlaba...@google.com wrote:
+fabbott
Used the wrong screen name.
Thanks,
John LaBanca
jlaba...@google.com
On Tue, Nov 3, 2009 at 4:21 PM, jlaba...@google.com wrote:
Reviewers:
LGTM. The comments that I have are general in nature.
http://gwt-code-reviews.appspot.com/92805/diff/28/1042
File user/src/com/google/gwt/uibinder/rebind/XMLElement.java (right):
http://gwt-code-reviews.appspot.com/92805/diff/28/1042#newcode149
Line 149: // type matches the given type
LGTM
http://gwt-code-reviews.appspot.com/93802/diff/1/4
File dev/core/src/com/google/gwt/dev/shell/log/SwingTreeLogger.java
(right):
http://gwt-code-reviews.appspot.com/93802/diff/1/4#newcode332
Line 332: * @param queuedEvent
name mismatch
LGTM, with one whitespace nit. Pity ant doesn't have a built-in
$ant.target property, though.
http://gwt-code-reviews.appspot.com/91810/diff/1/3
File user/build.xml (right):
http://gwt-code-reviews.appspot.com/91810/diff/1/3#newcode380
Line 380: test.cases=test.dev.htmlunit.tests
I don't
committed as r6646 with whitespace fix.
http://gwt-code-reviews.appspot.com/91810
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6646
Author: jlaba...@google.com
Date: Wed Nov 4 09:47:36 2009
Log: Adds a name to all gwt.junit test targets so we can easily tell which
one failed.
Patch by: jlabanca
Review by: fabbott
http://code.google.com/p/google-web-toolkit/source/detail?r=6646
Modified:
Revision: 6647
Author: jlaba...@google.com
Date: Wed Nov 4 09:50:34 2009
Log: tr...@6646 was merged into this branch
Add names to test targets so we know which one failed.
svn merge --ignore-ancestry -c 6646
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch by: jlabanca
Certainly having done the work I wouldn't suggest you go back, no.
I think command-line flags are only marginally self-documenting, though,
without an actual command line... now, if we got the Eclipse plugin to have
a nice UI on it
On Wed, Nov 4, 2009 at 1:01 PM, rj...@google.com wrote:
Responded to the feedback, will commit soon. Trunk has shifted in the
course of the review and Rietveld and git are confusing each other as a
result, I'll keep an eye on that before submitting.
http://gwt-code-reviews.appspot.com/92805/diff/28/1042
File
releases/2...@6649
http://gwt-code-reviews.appspot.com/89821
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
All,
The code in FocusImplOld has been a great source of consternation for some
time now. It's probably never going to be possible to fix every bug that
crops up as a result of the ugly hidden input it creates, and I'm starting
to believe it causes more problems than it solves.
What problems
Revision: 6649
Author: rj...@google.com
Date: Wed Nov 4 10:24:42 2009
Log: Merged tr...@6645 to releases/2.0
Redundant HasText decls. confuse UiBinder
svn merge --ignore-ancestry -c 6645
https://google-web-toolkit.googlecode.com/svn/trunk .
SGTM
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On 2009/11/04 15:51:54, jlabanca wrote:
LGTM
Committed at r6650.
http://gwt-code-reviews.appspot.com/94801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6650
Author: j...@google.com
Date: Wed Nov 4 10:50:50 2009
Log: Fix for CustomButton getting stuck hovering if removed during onlick.
Review: http://gwt-code-reviews.appspot.com/94801
http://code.google.com/p/google-web-toolkit/source/detail?r=6650
Modified:
On 2009/11/04 18:51:00, jgw wrote:
On 2009/11/04 15:51:54, jlabanca wrote:
LGTM
Committed at r6650.
And in /releases/2.0 at r6651.
http://gwt-code-reviews.appspot.com/94801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6651
Author: j...@google.com
Date: Wed Nov 4 10:52:58 2009
Log: Merge of /trunk c6650.
http://code.google.com/p/google-web-toolkit/source/detail?r=6651
Modified:
/releases/2.0/user/src/com/google/gwt/user/client/ui/CustomButton.java
Revision: 6652
Author: sco...@google.com
Date: Wed Nov 4 11:05:23 2009
Log: CompiledClasses now compute local class status from JDT.
Review by: amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=6652
Modified:
Committed tr...@r6653
http://gwt-code-reviews.appspot.com/92805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM, just nits.
http://gwt-code-reviews.appspot.com/90802/diff/1004/2001
File user/super/com/google/gwt/emul/java/util/Date.java (right):
http://gwt-code-reviews.appspot.com/90802/diff/1004/2001#newcode110
Line 110: * A private copy of the hour within the day.
@see #fixDaylightSavings
Revision: 6644
Author: b...@google.com
Date: Wed Nov 4 08:46:30 2009
Log: Merge r6642 from trunk to clean up command-line arguments.
$ svn merge --ignore-ancestry -c 6642
http://google-web-toolkit.googlecode.com/svn/trunk/ .
http://code.google.com/p/google-web-toolkit/source/detail?r=6644
LGTM
http://gwt-code-reviews.appspot.com/92801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
What is an SSW?
Dan
On Wed, Nov 4, 2009 at 2:24 PM, b...@google.com wrote:
LGTM, just nits.
http://gwt-code-reviews.appspot.com/90802/diff/1004/2001
File user/super/com/google/gwt/emul/java/util/Date.java (right):
http://gwt-code-reviews.appspot.com/90802/diff/1004/2001#newcode110
Revision: 6655
Author: rj...@google.com
Date: Wed Nov 4 11:43:21 2009
Log: Introduces JUnitShell argument -testMethodTimeout
Reviewed by amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=6655
Modified:
/trunk/user/src/com/google/gwt/junit/JUnitShell.java
And releases/2...@6654
http://gwt-code-reviews.appspot.com/92805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
And releases/2...@6654
http://gwt-code-reviews.appspot.com/92805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On Wed, Nov 4, 2009 at 3:42 PM, Daniel Rice (דניאל רייס) r...@google.comwrote:
What is an SSW?
Slow script warning. Basically if JS executes a lot (defined differently on
the different browsers) without yielding you will get one.
--
John A. Tamplin
Software Engineer (GWT), Google
tr...@6655
http://gwt-code-reviews.appspot.com/89819
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6656
Author: jlaba...@google.com
Date: Wed Nov 4 11:45:20 2009
Log: Disabling another image test because of the synchronous onload issue
863.
Patch by: jlabanca
Review by: jgw (desk)
http://code.google.com/p/google-web-toolkit/source/detail?r=6656
Modified:
LGTM.
Going forward, this comment makes me nervous:
/*
* Handle virtual overrides by finding the method that we
would
* normally invoke and using its declaring class as the
dispatch
* target.
*/
In general, there are *multiple*
Revision: 6658
Author: sco...@google.com
Date: Wed Nov 4 11:56:16 2009
Log: Better failure messages for UnitTestTreeLogger on collections.
Patch by: jat
Review by: me
http://code.google.com/p/google-web-toolkit/source/detail?r=6658
Modified:
Revision: 6657
Author: sco...@google.com
Date: Wed Nov 4 11:56:05 2009
Log: Extracts CompilationStateTestBase from CompilationStateTest to reuse.
Patch by: jat
Review by: me
http://code.google.com/p/google-web-toolkit/source/detail?r=6657
Added:
releases/2...@6661
http://gwt-code-reviews.appspot.com/89819
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6659
Author: sco...@google.com
Date: Wed Nov 4 11:56:27 2009
Log: Adds a Throwable unit to JavaResourceBase.
Patch by: jat
Review by: me
http://code.google.com/p/google-web-toolkit/source/detail?r=6659
Modified:
Revision: 6660
Author: sco...@google.com
Date: Wed Nov 4 11:56:48 2009
Log: Renames CompiledClass.getBinaryName() -
CompiledClass.getInternalName().
Patch by: jat
Review by: me
http://code.google.com/p/google-web-toolkit/source/detail?r=6660
Modified:
Revision: 6661
Author: rj...@google.com
Date: Wed Nov 4 12:01:23 2009
Log: Merges tr...@6655 into releases/2.0
Introduces JUnitShell argument -testMethodTimeout
svn merge --ignore-ancestry -c 6655
https://google-web-toolkit.googlecode.com/svn/trunk .
LGTM
On Wed, Nov 4, 2009 at 12:22 PM, j...@google.com wrote:
Reviewers: Ray Ryan, bruce, Dan Rice,
Description:
SwingWorker uses a pool of threads to run background tasks, and we
weren't actually using the background portion of this. Having multiple
threads processing SwingWorker calls
Reviewers: fabbott,
Description:
Description:
=
RPC tests often timeout because of slow server responses while the
server is busy compiling other GWT modules.
Fix:
===
I added an RpcTestBase class that has a static RPC_TIMEOUT value. We
can increase or decrease it if needed.
I
Revision: 6662
Author: sco...@google.com
Date: Wed Nov 4 12:23:52 2009
Log: Merges tr...@6652 into this branch
CompiledClasses now compute local class status from JDT.
svn merge --ignore-ancestry -c6652
https://google-web-toolkit.googlecode.com/svn/trunk .
Thanks for the review.
Because of generics plus multiple (interface) inheritance, there isn't a
single erased method signature by which each method is reached. There
can be more than one.
I'm tempted to add a check (at least for 2.0) to disallow the use of
generic interfaces for the
Revision: 6664
Author: sco...@google.com
Date: Wed Nov 4 12:27:13 2009
Log: Merges trunk c6657-c6660 into this branch
Extracts CompilationStateTestBase from CompilationStateTest to reuse.
Better failure messages for UnitTestTreeLogger on collections.
Adds a Throwable unit to
On Wed, Nov 4, 2009 at 4:21 PM, Daniel Rice (דניאל רייס) r...@google.comwrote:
LGTM
Thanks. Committed to trunk at r6663, and releases/2.0 at r6665.
--
John A. Tamplin
Software Engineer (GWT), Google
--~--~-~--~~~---~--~~
Reviewers: jgw,
Message:
Joel, I think you'll like this a lot.
Description:
Mock type oracle allows XMLElementTest to be restored. Also replace
DummyMortalLogger with MortalLogger.NULL
Please review this at http://gwt-code-reviews.appspot.com/94803
Affected files:
M
On 2009/11/04 20:49:05, Ray Ryan wrote:
Joel, I think you'll like this a lot.
LGTM. Yay error testing!
http://gwt-code-reviews.appspot.com/94803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6667
Author: jlaba...@google.com
Date: Wed Nov 4 13:11:32 2009
Log: tr...@6656 and 6566 was merged into this branch
Disabling another image test associated with issue 862.
Increasing timeouts of RPC tests.
svn merge --ignore-ancestry -c 6656
Revision: 6668
Author: j...@google.com
Date: Wed Nov 4 13:15:07 2009
Log: Update plugins to hopefully final name.
http://code.google.com/p/google-web-toolkit/source/detail?r=6668
Added:
/changes/jat/single-xpi/plugins/xpcom/prebuilt/extension/lib/Linux_x86-gcc3/ff3/libgwt_dev_ff3.so
Revision: 6669
Author: b...@google.com
Date: Wed Nov 4 13:19:11 2009
Log: Method overloads fix for SingleJsoImpl.
Patch by: bobv
Review by: spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=6669
Modified:
/trunk/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
Revision: 6670
Author: b...@google.com
Date: Wed Nov 4 13:19:43 2009
Log: Fix generic parameters for SingleJsoImpl types.
Patch by: bobv
Review by: spoon
http://code.google.com/p/google-web-toolkit/source/detail?r=6670
Modified:
Revision: 6671
Author: rj...@google.com
Date: Wed Nov 4 13:42:26 2009
Log: Mock TypeOracle allows XMLElementTest to be restored. Also replace
DummyMortalLogger with MortalLogger.NULL
reviewed by jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6671
Deleted:
Revision: 6672
Author: b...@google.com
Date: Wed Nov 4 13:43:21 2009
Log: Merge tr...@6669,6670 to fix hosted mode problems with SingleJsoImpl
$ svn merge --ignore-ancestry -c6669,6670
https://google-web-toolkit.googlecode.com/svn/trunk/ .
-This line, and those below, will be ignored--
M
Revision: 6673
Author: j...@google.com
Date: Wed Nov 4 13:44:11 2009
Log: Add prebuilt libraries for Mac.
http://code.google.com/p/google-web-toolkit/source/detail?r=6673
Added:
/changes/jat/single-xpi/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff3/libgwt_dev_ff3.dylib
Revision: 6674
Author: r...@google.com
Date: Wed Nov 4 13:53:54 2009
Log: Calling new Date(...) with a time that falls in the 'missing hour' of
a daylight savings time transition currently behaves differently in
(Sun's JDK) Java versus (some browsers') Javascript. In Java, the time
is moved
Reviewers: fabbott,
Description:
HttpSuite tests have the same timeout problem as RpcSuite tests. I'm
increasing the timeout of these from 10s to 15s and adding a base class
to make it easier to increase them all at once.
Testing:
=
HttpSuite passes. Running all tests as we speak.
Revision: 6676
Author: r...@google.com
Date: Wed Nov 4 14:08:43 2009
Log: Merge tr...@6674 into the branch
Fix dates that fall into non-existent time ranges due to daylight savings
svn merge --ignore-ancestry -c 6674
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Revision: 6675
Author: j...@google.com
Date: Wed Nov 4 14:08:41 2009
Log: Windows changes for the name change fixing the release project build.
http://code.google.com/p/google-web-toolkit/source/detail?r=6675
Added:
Revision: 6677
Author: rj...@google.com
Date: Wed Nov 4 14:13:39 2009
Log: Merges tr...@6643, 6671 into releases/2.0
Better error handling in DockLayoutPanelParser, restore XMLElemTest
svn merge --ignore-ancestry -c 6643
https://google-web-toolkit.googlecode.com/svn/trunk .
svn merge
Revision: 6678
Author: j...@google.com
Date: Wed Nov 4 14:30:05 2009
Log: More name changes.
http://code.google.com/p/google-web-toolkit/source/detail?r=6678
Modified:
/changes/jat/single-xpi/plugins/xpcom/ExternalWrapper.cpp
/changes/jat/single-xpi/plugins/xpcom/FFSessionHandler.cpp
Revision: 6680
Author: j...@google.com
Date: Wed Nov 4 14:35:07 2009
Log: Update Win FF3 binary.
http://code.google.com/p/google-web-toolkit/source/detail?r=6680
Modified:
/changes/jat/single-xpi/plugins/xpcom/prebuilt/extension/lib/WINNT_x86-msvc/ff3/xpGwtDevPlugin.dll
Revision: 6681
Author: sp...@google.com
Date: Wed Nov 4 14:41:14 2009
Log: SameParameterValue optimization.
This optimization detects cases when the same value literal is used
as parameter value across the whole program.
Patch by: mike.aizatsky
Review by: spoon
Revision: 6682
Author: j...@google.com
Date: Wed Nov 4 14:56:38 2009
Log: Checkin Win FF35 binary, and project file changes.
http://code.google.com/p/google-web-toolkit/source/detail?r=6682
Added:
Revision: 6683
Author: j...@google.com
Date: Wed Nov 4 15:00:42 2009
Log: A few last (?) name changes, bringing the FF35 project file in line
with FF3,
checkin XPI with all phase 1 platforms included.
http://code.google.com/p/google-web-toolkit/source/detail?r=6683
Added:
Revision: 6684
Author: rj...@google.com
Date: Wed Nov 4 16:14:18 2009
Log: Fix UiBinderTest.testCustomButtonParser to be IE friendly,
build break
tbr jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6684
Modified:
Thanks for the review.
http://gwt-code-reviews.appspot.com/92802/diff/1/5
File dev/core/src/com/google/gwt/dev/util/BrowserLauncher.java (right):
http://gwt-code-reviews.appspot.com/92802/diff/1/5#newcode110
Line 110: + in your browser);
On 2009/11/05 00:18:55, Ray Ryan wrote:
This might be
On Wed, Nov 4, 2009 at 4:25 PM, j...@google.com wrote:
Thanks for the review.
http://gwt-code-reviews.appspot.com/92802/diff/1/5
File dev/core/src/com/google/gwt/dev/util/BrowserLauncher.java (right):
http://gwt-code-reviews.appspot.com/92802/diff/1/5#newcode110
Line 110: + in your
Reviewers: fabbott,
Description:
JUnitShell currently prints the remote browser info only if there are
multiple remote browsers being tested.
Also, its hard to know which arguments were used on a failed test target
in the build file.
Fix:
I removed the check to see how many clients we
lgtm
http://gwt-code-reviews.appspot.com/93805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6686
Author: rj...@google.com
Date: Wed Nov 4 17:20:05 2009
Log: Revert tr...@6681 SameParameterValue optimization,
due to build break.
http://code.google.com/p/google-web-toolkit/source/detail?r=6686
Deleted:
Revision: 6687
Author: amitman...@google.com
Date: Wed Nov 4 17:38:43 2009
Log: Patch adds the infrastructure to re-run a test. Useful for htmlUnit
which can
be flaky sometimes.
Patch by: amitmanjhi
Review by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6687
Revision: 6688
Author: amitman...@google.com
Date: Wed Nov 4 17:44:00 2009
Log: Merged tr...@6687 into this branch
Patch by: amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=6688
Modified:
/releases/2.0/branch-info.txt
96 matches
Mail list logo
