Reviewers: jgw,
Message:
Hey, Joel.
As discussed, StackLayoutPanel now does the right thing WRT g:header and
g:customHeader. (The grotesque amount of copy/paste between
StackLayoutPanelParser, TabLayoutPanelParser and DisclosurePanel seems
like a massive clue that these three widgets--not the po
Revision: 6786
Author: br...@google.com
Date: Mon Nov 9 21:01:39 2009
Log: Initial commit of MissingPlugin functionality.
Change by: bruce
Review by: robertvawter, jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6786
Added:
/releases/2.0/plugins/MissingPlugin
/releases/2.0
Revision: 6785
Author: sco...@google.com
Date: Mon Nov 9 20:51:09 2009
Log: Simplify resolution of annotations in TypeOracle.
Annotaions must always use the context classloader, which contains all user
data, because that's the same classloader that Generators run in. There is
also no need t
Revision: 6782
Author: sco...@google.com
Date: Mon Nov 9 19:35:59 2009
Log: Format ApiCompatibilityChecker
http://code.google.com/p/google-web-toolkit/source/detail?r=6782
Modified:
/trunk/tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java
===
Hey all,
We're using GWT in a lot of places that aren't traditional webpages
(currently a Firefox extension and a Chrome plugin). We've rolled our
support for OOPHM in Firefox chrome code, but Chrome content scripts
are going to be a different story. For now, our code is simple enough
t
Actually, re: building the mocks out of class literals: No. I had it
working with literals originally and then I took them away. The test ran
twice as fast (!), presumably because of all the class init code that
didn't run.
Note also that the mock resources are very low fidelity, not even
matchin
Comment by rj...@google.com:
@jchimene Fixed, thanks.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/UiBinder
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~---
Revision: 6781
Author: rj...@google.com
Date: Mon Nov 9 16:28:35 2009
Log: Fix typo in "different templates" section
http://code.google.com/p/google-web-toolkit/source/detail?r=6781
Modified:
/wiki/UiBinder.wiki
===
--- /wiki/UiBinder.wiki Wed Oct 21 12:06:
Revision: 6780
Author: j...@google.com
Date: Mon Nov 9 16:04:54 2009
Log: Build plugin DLL after name changes.
http://code.google.com/p/google-web-toolkit/source/detail?r=6780
Added:
/trunk/plugins/npapi/prebuilt/gwt-dev-plugin/WINNT_x86-msvc/npGwtDevPlugin.dll
Revision: 6779
Author: j...@google.com
Date: Mon Nov 9 16:00:39 2009
Log: Update Chrome plugin naming, cleanup leftover garbage, commit object
freeing code that was never committed.
This was originally committed to the changes/jat/single-xpi branch by
mistake.
Patch by: jat
Review by: rice (TBR)
Comment by jchimene:
I may be missing something but shouldn't the argument to the initWidget
call in _Apply different xml templates to the same widget_
be
{{{
protected FooPickerDisplay(UiBinder binder) {
initWidget(binder.createAndBindUi(this));
}
}}}
For more information:
http:/
LGTM other than minor comments below.
ApiContainerTest and ApiCompatibilityTest throw console errors, even
though the tests pass.
Validating newly compiled units
[ERROR] No JavaScript body found for native method 'protected
native int protectedMethod();' in type 'java.lang.Object'
Refres
Revision: 6778
Author: rj...@google.com
Date: Mon Nov 9 13:24:23 2009
Log: Merges tr...@6774 into releases/2.0
Comment tweaks on xhtml.ent
svn merge --ignore-ancestry -c 6776
https://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit/source/detail?
Revision: 6776
Author: rj...@google.com
Date: Mon Nov 9 13:13:58 2009
Log: Comment tweak
http://code.google.com/p/google-web-toolkit/source/detail?r=6776
Modified:
/trunk/user/src/com/google/gwt/uibinder/resources/xhtml.ent
===
--- /trunk/user/src/com/goog
Revision: 6775
Author: j...@google.com
Date: Mon Nov 9 13:01:13 2009
Log: Update Chrome plugin naming, cleanup leftover garbage, commit object
freeing
code that was never committed.
Patch by: jat
Review by: rice (TBR)
http://code.google.com/p/google-web-toolkit/source/detail?r=6775
Added:
/
http://gwt-code-reviews.appspot.com/97806/diff/1001/56
File user/src/com/google/gwt/uibinder/rebind/XMLElement.java (right):
http://gwt-code-reviews.appspot.com/97806/diff/1001/56#newcode50
Line 50: @SuppressWarnings("deprecation")
On 2009/11/09 18:33:27, bobv wrote:
> This is a big class.
Done
Reviewers: bobv,
Message:
Nits addressed, committed tr...@6774, 2.0 soon.
Description:
DialogBox is weird--it implements both HasHTML and HasWidgets. This
confuses the bejeebers out of UiBinder and leads it to generate bad
code, so a custom parser is required. I took this excuse to generalize
th
Perhaps i would extrapolate on my proposal. The compiler could have an extra
feature that went thru and found all log statements and added a String with
the classname + method name on your behalf so...
Class X
void method(){
log( "Hello"); //
}
the log above would get modified to
log( "ClassX
Revision: 6773
Author: r...@google.com
Date: Mon Nov 9 11:52:36 2009
Log: Merge tr...@6772 into this branch
Remove an outdated reference to the compile/browse button
svn merge --ignore-ancestry -c 6772
https://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-t
And just to be clear, we recognize that it's a real problem, but I think
it's going to take some time to work out how to shove the iframe shim in, in
such a way that it doesn't break existing code (the IE6/7 implementation
takes advantage of CSS expressions to keep the iframe positioned correctly).
Revision: 6772
Author: r...@google.com
Date: Mon Nov 9 11:49:26 2009
Log: Remove an outdated reference to the compile/browse button
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6772
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionSc
Reviewers: jgw, t.broyer,
Message:
Okay, we'll back off from this one.
Please review this at http://gwt-code-reviews.appspot.com/97807
Affected files:
M user/src/com/google/gwt/user/client/ui/impl/PopupImplIE6.java
Index: user/src/com/google/gwt/user/client/ui/impl/PopupImplIE6.java
diff
Reviewers: bobv,
Description:
External issue 4171 points out that:
NumberFormat.getFormat("#,##0.##").format(30.555)
should yield 30.56 but yields 30.55 instead.
This is due to the fact that the fractional part of 30.555 (computed as
x - Math.floor(x)) formats as 0.554999... and adding 0.5 sti
UiBinder changes LGTM
http://gwt-code-reviews.appspot.com/97810
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On Mon, Nov 9, 2009 at 2:05 PM, eighty wrote:
>
> It seems that the ToolBase.processArgs() method receives the "-style"
> argument but the argHandlers map doesn't contain a mapping for it.
> This results in a null handler.
>
> Is the "-style" flag no longer supported?
Not on DevMode/HostedMode/
It seems that the ToolBase.processArgs() method receives the "-style"
argument but the argHandlers map doesn't contain a mapping for it.
This results in a null handler.
Is the "-style" flag no longer supported?
--~--~-~--~~~---~--~~
http://groups.google.com/group/G
Revision: 6771
Author: j...@google.com
Date: Mon Nov 9 11:00:52 2009
Log: Merging /trunk c6770.
http://code.google.com/p/google-web-toolkit/source/detail?r=6771
Added:
/releases/2.0/samples/mail/src/com/google/gwt/sample/mail/client/MailList.ui.xml
/releases/2.0/samples/mail/src/com/goog
Committed to /trunk @r6770.
Committed to /releases/2.0 @r6771.
http://gwt-code-reviews.appspot.com/97805/diff/1/4
File
samples/mail/src/com/google/gwt/sample/mail/client/AboutDialog.ui.xml
(right):
http://gwt-code-reviews.appspot.com/97805/diff/1/4#newcode13
Line 13:
On 2009/11/09 17:58:49, Ra
Revision: 6770
Author: j...@google.com
Date: Mon Nov 9 10:52:41 2009
Log: Cleaning up the mail sample, adding new styles, and moving most images
into @sprite CssResource.
Review: http://gwt-code-reviews.appspot.com/97805
http://code.google.com/p/google-web-toolkit/source/detail?r=6770
Added:
/t
LGTM, with nits.
http://gwt-code-reviews.appspot.com/97806/diff/1001/56
File user/src/com/google/gwt/uibinder/rebind/XMLElement.java (right):
http://gwt-code-reviews.appspot.com/97806/diff/1001/56#newcode50
Line 50: @SuppressWarnings("deprecation")
This is a big class.
http://gwt-code-reviews.
Henry, thanks very much for the offer. However, we're in the process of
phasing out Incubator. It's intentions are noble but the mechanism has
proven unwieldy. We're instead encouraging people to create independent
project sites on Google Code, or offer things as direct contributions to GWT
proper.
LGTM with the above feedback.
http://gwt-code-reviews.appspot.com/97805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
I think that NavBar.java should be introduced rather than making it a
static nested classs. Many indentation and style nits, do with them what
you will.
http://gwt-code-reviews.appspot.com/97805/diff/1/4
File
samples/mail/src/com/google/gwt/sample/mail/client/AboutDialog.ui.xml
(right):
http://
I'm seeing something strange when I create a new web application
project and run it with the development server. Basically it fails
with a console message "Unknown argument: -style". Here's my setup:
- GWT r6765
- GAE 1.2.6
- Eclipse 3.5 on OS X 10.5.8
- Google Plugin for Eclipse 1.1.2.v200910131
Revision: 6769
Author: rda...@google.com
Date: Mon Nov 9 09:40:14 2009
Log: Update branch-info.txt to reflect merge of tr...@r6767 into
releases/2.0.
http://code.google.com/p/google-web-toolkit/source/detail?r=6769
Modified:
/releases/2.0/branch-info.txt
===
Committed as tr...@r6767. Cherry-picked into releases/2...@r6768.
http://gwt-code-reviews.appspot.com/98801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6768
Author: rda...@google.com
Date: Mon Nov 9 09:38:13 2009
Log: Merges tr...@r6767 into releases/2.0. Merge performed with the
following command:
svn merge --ignore-ancestry -c 6762
https://google-web-toolkit.googlecode.com/svn/trunk .
http://code.google.com/p/google-web-toolkit
Revision: 6767
Author: rda...@google.com
Date: Mon Nov 9 09:33:19 2009
Log: When using the -remoteUI switch, the Main and Server loggers now log
their
output using a Console-Based TreeLogger (instead of sending these messages
over
the wire). Also made a change to OOPHMSessionHandler to allow
Committed as tr...@r6762 and cherry-picked as releases/2...@r6763
http://gwt-code-reviews.appspot.com/96807
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Thanks for the review!
http://gwt-code-reviews.appspot.com/98801/diff/1/3
File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
(right):
http://gwt-code-reviews.appspot.com/98801/diff/1/3#newcode119
Line 119: throw new IllegalStateException(
On 2009/11/09 17:07:10, mmendez wrote:
>
Revision: 6766
Author: rj...@google.com
Date: Mon Nov 9 09:16:02 2009
Log: Fix bad prefix in "Message containing widgets with text bodies" section
http://code.google.com/p/google-web-toolkit/source/detail?r=6766
Modified:
/wiki/UiBinderI18n.wiki
===
--- /wi
LGTM - Just double check what state the system is in if you throw the
IllegalStateExceptions.
http://gwt-code-reviews.appspot.com/98801/diff/1/3
File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java
(right):
http://gwt-code-reviews.appspot.com/98801/diff/1/3#newcode119
Line 119: thr
LGTM
http://gwt-code-reviews.appspot.com/98801
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: mmendez, jat,
Description:
When using the -remoteUI switch, the Main and Server loggers now log
their output using a Console-Based TreeLogger (instead of sending these
messages over the wire). Also made a change to OOPHMSessionHandler to
allow the module logger to be used to log any er
Reviewers: mmendez, jat,
Description:
When using the -remoteUI switch, the Main and Server loggers now log
their output using a Console-Based TreeLogger (instead of sending these
messages over the wire). Also made a change to OOPHMSessionHandler to
allow the module logger to be used to log any er
Created Wiki Page:
http://code.google.com/p/google-web-toolkit/wiki/RemoteTesting
Thanks,
John LaBanca
jlaba...@google.com
On Mon, Nov 9, 2009 at 6:21 AM, Bart Guijt wrote:
>
> I found a bug related to opening Safari on Mac OS X in
> BrowserManagerServer - it opens the URL prefixed with the cu
Revision: 6764
Author: rda...@google.com
Date: Mon Nov 9 08:08:33 2009
Log: Updated to reflect the merge of tr...@r6762 into this branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=6764
Modified:
/releases/2.0/branch-info.txt
===
--- /rele
Agreed -- we're going to do precisely that. I think we'll probably end up
sticking isIE6() in the image bundle code for the moment, as Bob has a
better general solution in the pipeline (which he calls soft permutations).
But yes, the image bundle insanity on IE6 is the more important of the two
tha
I'm not a code reviewer... but just a useful comment:
You might want to move the isIE6 method somewhere else so that you
could avoid the memory leak on ie7/ie8 when using ImageBundles as
well.
For ie7 and ie8 this workaround to get transparent PNGs working is no
longer needed and it's leaking a l
Hi all,
We're starting using UiBinder quite intensively and one thing we
haven't been able to do is to declare some constants in a CssResource
and reuse them in our ui.xml (I believe this is unrelated to UiBinder
actually, as I don't know how it could be made to work with plain old
CssResources o
On 2009/11/09 14:49:12, jgw wrote:
> On 2009/11/09 14:34:54, t.broyer wrote:
> > Sorry to jump in without having been invited but, given
> > http://code.google.com/p/google-web-toolkit/issues/detail?id=805
(among
> others),
> > shouldn't the iframe shim be extended to all browsers instead?
> >
> >
Revision: 6761
Author: b...@google.com
Date: Mon Nov 9 07:00:31 2009
Log: Edited wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=6761
Modified:
/wiki/CssResource.wiki
===
--- /wiki/CssResource.wiki Wed
Comment by natros:
I was about to ask the same thing.
For more information:
http://code.google.com/p/google-web-toolkit/wiki/StyleInjector
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~---
On 2009/11/09 14:34:54, t.broyer wrote:
> Sorry to jump in without having been invited but, given
> http://code.google.com/p/google-web-toolkit/issues/detail?id=805
(among others),
> shouldn't the iframe shim be extended to all browsers instead?
> (Closure-library seems to be doing just this; or
Sorry to jump in without having been invited but, given
http://code.google.com/p/google-web-toolkit/issues/detail?id=805 (among
others), shouldn't the iframe shim be extended to all browsers instead?
(Closure-library seems to be doing just this; or actually, it moves the
responsibility to the dev
Revision: 6760
Author: kpro...@google.com
Date: Mon Nov 9 06:28:57 2009
Log: Merges tr...@6759 into releases/2.0
Fixes two bugs in SOYC dashboard:
1. Initial download size and total download size were flipped
2. When there was one single split point, it wasn't displayed.
Patch by:
Sami Jaber (s
On Nov 9, 12:30 pm, Ray Cromwell wrote:
> Safari2 is so broken anyway, it's just not worth it. :)
The issue actually here is with Safari 3 (history, xmlhttprequest
being limited to GET and POST, and probably a few other small things
were Safari 2 only, but focus is different); only Safari 4 ma
LGTM. Thanks.
http://gwt-code-reviews.appspot.com/97807/diff/3/1002
File user/src/com/google/gwt/user/client/ui/impl/PopupImplIE6.java
(right):
http://gwt-code-reviews.appspot.com/97807/diff/3/1002#newcode71
Line 71: private native void do_onHide(Element popup) /*-{
I know these are private, bu
Revision: 6759
Author: kpro...@google.com
Date: Mon Nov 9 06:20:12 2009
Log: Fixes two bugs in SOYC dashboard:
1. Initial download size and total download size were flipped
2. When there was one single split point, it wasn't displayed.
Patch by:
Sami Jaber (sami.ja...@gmail.com)
Review by:
kprob
Revision: 6758
Author: j...@google.com
Date: Mon Nov 9 06:14:18 2009
Log: Add OS/ABI params to update URL, fixed a few names that were missed,
checkin alt-library .so's built on Fedora (will have to figure out later why
the ones built on Ubuntu didn't work).
Patch by: jat
Review by: rice (TBR)
Because I also want to include the linenumbers. I hope you are not
proposing that I type these in as parameters as well ? ;-)
David
On Nov 6, 11:22 am, Miroslav Pokorny
wrote:
> Why not just include the class.method name at the start of each and every
> message String sent to your logging metho
Joel,
I'll take a look at it.
The overhead is acceptable since I make sure that we only pay the
price if tracing is actually enabled.
I'm hoping that the log API in incubator or the one from Fred will end
up in the main GWT someday ? In that case it would be a very useful if
it could auto-deduc
Safari2 is so broken anyway, it's just not worth it. :)
On Mon, Nov 9, 2009 at 3:24 AM, Thomas Broyer wrote:
>
>
>
> On Nov 4, 7:28 pm, Joel Webber wrote:
> > All,
> >
> > The code in FocusImplOld has been a great source of consternation for
> some
> > time now. It's probably never going to be
On Nov 4, 7:28 pm, Joel Webber wrote:
> All,
>
> The code in FocusImplOld has been a great source of consternation for some
> time now. It's probably never going to be possible to fix every bug that
> crops up as a result of the ugly hidden input it creates, and I'm starting
> to believe it cau
I found a bug related to opening Safari on Mac OS X in
BrowserManagerServer - it opens the URL prefixed with the current path
of my shell.
Anyway, found a way to fix that (see patch at Issue #4209).
Q: Is the Selenium route 'just another way' to run the tests on a
browser? I found some com
Revision: 6757
Author: b...@google.com
Date: Mon Nov 9 03:00:34 2009
Log: Edited wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=6757
Modified:
/wiki/StyleInjector.wiki
===
--- /wiki/StyleInjector.wikiTh
66 matches
Mail list logo
