The 3rd patch set adds tests, UiBinder element parsers for DateLabel and
NumberLabel, and the ToggleButton (issue 5571) which I forgot in
previous patches.
I found some issues with generics in UiBinder and had to relax a check
in UiBinderParser (but I believe this is taken care of later on, see t
committed as r9220
http://gwt-code-reviews.appspot.com/1102801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1082801/diff/1/10
File user/src/com/google/gwt/html5/canvas/client/CssColor.java (right):
http://gwt-code-reviews.appspot.com/1082801/diff/1/10#newcode23
user/src/com/google/gwt/html5/canvas/client/CssColor.java:23: public
class CssColor implements IsFillStyle
You have line length issues in various places.
http://gwt-code-reviews.appspot.com/1107801/diff/1/7
File
user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java
(right):
http://gwt-code-reviews.appspot.com/1107801/diff/1/7#newcode52
user/src/com/google/gwt/user/client/rpc/
Ted, this is the right list for this sort of thing.
I can't speak to the specifics of your project at the moment--though
you'd probably get a better response if you included a design doc
and/or code.
On Sun, Nov 14, 2010 at 9:08 PM, TedM wrote:
>
> Thanks,
>
> I wasn't thinking in the line of GW
Can you explain the problem this is fixing?
http://gwt-code-reviews.appspot.com/1105801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
>
> 3. They think it doesn't have value.
I would change this to either
1- It's out of the scope of GWT at the moment or
2- They have other priorities and can't get it in the roadmap yet.
Do you know how I can get in contact with someone from GWT?
I think you're at the right place, just be patie
http://gwt-code-reviews.appspot.com/1107801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The current implementation has the following functionality
1. dynamic forms
2. dynamic workflow
3. submission of form data
4. submission of attachments
5. client and server validation
And UI editor on the way.
But the current implementation is a project that I'm the architect
for. The prototype
Thanks Christian,
I just started a dialog with Chris Conroy. Hopefully it will be
fruitful. Based on the feed back I'm getting this is a very common
problem.
I'm hopeful, I get to do this and get to do it in alignment with the
GWT vision.
--
http://groups.google.com/group/Google-Web-Toolkit-C
On Mon, Nov 15, 2010 at 11:42 AM, TedM wrote:
> The current implementation has the following functionality
>
> 1. dynamic forms
> 2. dynamic workflow
> 3. submission of form data
> 4. submission of attachments
> 5. client and server validation
>
> And UI editor on the way.
>
> But the current impl
Revision: 9223
Author: b...@google.com
Date: Mon Nov 15 09:22:36 2010
Log: Edited wiki page RequestFactory_2_1_1 through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9223
Modified:
/wiki/RequestFactory_2_1_1.wiki
===
--- /wi
On 15 November 2010 08:27, wrote:
> Can you explain the problem this is fixing?
See
http://ant.1045680.n5.nabble.com/warning-includeantruntime-was-not-set-td2639463.html
for more details.
In short, by default Ant includes its own JARs on 's classpath.
This means the effective classpath depends
Revision: 9224
Author: j...@google.com
Date: Mon Nov 15 09:34:58 2010
Log: Created wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9224
Added:
/wiki/UnderstandingMemoryLeaks.wiki
===
--- /dev/null
+++ /wiki/Un
On Mon, Nov 15, 2010 at 12:30 PM, Hilco Wijbenga
wrote:
> See
> http://ant.1045680.n5.nabble.com/warning-includeantruntime-was-not-set-td2639463.html
> for more details.
>
> In short, by default Ant includes its own JARs on 's classpath.
> This means the effective classpath depends on where the b
sounds reasonable, thanks.
But it seems like the Widget is indeed capable of firing "anonymous"
events, because of the public fireEvent() method defined in the
HasHandlers interface - so its a little confusing if I can fire any
event from external code on a Widget but can only add handlers for
cus
Revision: 9225
Author: j...@google.com
Date: Mon Nov 15 09:37:23 2010
Log: Edited wiki page DomEventsAndMemoryLeaks through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9225
Modified:
/wiki/DomEventsAndMemoryLeaks.wiki
===
-
Revision: 9226
Author: j...@google.com
Date: Mon Nov 15 09:38:43 2010
Log: Edited wiki page UnderstandingMemoryLeaks through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9226
Modified:
/wiki/UnderstandingMemoryLeaks.wiki
===
On 15 November 2010 09:37, John Tamplin wrote:
> On Mon, Nov 15, 2010 at 12:30 PM, Hilco Wijbenga
> wrote:
>> See
>> http://ant.1045680.n5.nabble.com/warning-includeantruntime-was-not-set-td2639463.html
>> for more details.
>>
>> In short, by default Ant includes its own JARs on 's classpath.
>>
The contributing code doc lists Ant 1.7.0 as a minimum to build.
http://code.google.com/webtoolkit/makinggwtbetter.html#contributingcode
On Nov 15, 12:08 pm, Hilco Wijbenga wrote:
> On 15 November 2010 09:37, John Tamplin wrote:
>
>
>
> > On Mon, Nov 15, 2010 at 12:30 PM, Hilco Wijbenga
> >
On Mon, Nov 15, 2010 at 1:08 PM, Hilco Wijbenga
wrote:
> In 1.8.0, it doesn't seem to affect older Ants (I just ran the build
> with 1.7.0).
>
> On a side note, I'm not clear why we can't mandate a particular Ant
> version. Ant 1.8.1 still works with JDK1.4 so no issues there. It's a
> best practi
Revision: 9227
Author: gwt.mirror...@gmail.com
Date: Mon Nov 15 10:31:51 2010
Log: A few small changes to BidiFormatter. Mainly, it now uses
DirectionEstimator that can be modified instead of the constant estimating
function of BidiUtils.
http://code.google.com/p/google-web-toolkit/source/de
Revision: 9228
Author: jlaba...@google.com
Date: Mon Nov 15 02:38:06 2010
Log: Adding a new CommonResources class that provides access to commonly
used styles in GWT. For now, the only style defined is a cross browser
implementation of inline block, but we can expand to include more common
s
Revision: 9229
Author: jlaba...@google.com
Date: Mon Nov 15 04:05:13 2010
Log: Adding a new widget CellWidget that can wrap any Cell and turn it into
a Widget. CellWidget can be used on its own (it isn't abstract) to wrap a
widget. It can also be used inside a Composite to create a formal ve
http://gwt-code-reviews.appspot.com/1085801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ted,
Are you familiar with the XForms specification? I think the original goal
was to get browser vendors to implement it to replace HTML forms, which
doesn't seem to be happening, but it's a very solid in dealing with a lot of
the use cases of form creation pretty gracefully. EMC even has a GWT
i
http://gwt-code-reviews.appspot.com/1085801/diff/40002/42001
File samples/build.xml (right):
http://gwt-code-reviews.appspot.com/1085801/diff/40002/42001#newcode59
samples/build.xml:59:
On 2010/11/11 22:05:51, rchandia wrote:
Remove this to prevent validationtck from being built and copied int
Revision: 9230
Author: jlaba...@google.com
Date: Mon Nov 15 02:27:58 2010
Log: Cherry picking r9216 and r9220 into release branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=9230
Added:
/releases/2.1/tools/api-checker/config/gwt21_22userApi.conf
Deleted:
/releases/2.1/user/src
On 15 November 2010 10:25, John Tamplin wrote:
> On Mon, Nov 15, 2010 at 1:08 PM, Hilco Wijbenga
> wrote:
>> On a side note, I'm not clear why we can't mandate a particular Ant
>> version. Ant 1.8.1 still works with JDK1.4 so no issues there. It's a
>> best practice to provide the tools with the
Thank you, John for your post. Let me see if I can summarize your
concerns and then I’ll show you how my solution takes your concerns
into account.
Adding dynamic functionality may come at a global cost:
The example you used is reflection, which I think is a perfect
example of a dynamic functi
Yeah I'm not a big fan of XForms. I don't have my thought summarized
at the moment. Over all it's an outdated, unsupported standard that
doesn't have much momentum.
On Nov 15, 1:44 pm, Amir Kashani wrote:
> Ted,
>
> Are you familiar with the XForms specification? I think the original goal
> was
This looks very interesting, indeed. Quick question though, how would one go
about hooking up event handlers to the views that are bound on the fly? Say
I wanted to do something trivial like validating user input in a cell?
-- Chris
On Fri, Nov 12, 2010 at 8:09 AM, TedM wrote:
> Hi,
>
> I made
http://gwt-code-reviews.appspot.com/1098801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Can you take one more look? I had broken non-entity types, e.g.
collections.
Only changes from patch set 4 are in
RequestFactoryInterfaceValidator.java
On 2010/11/15 19:33:16, rjrjr wrote:
http://gwt-code-reviews.appspot.com/1098801/show
--
http://groups.google.com/group/Google-Web-Toolkit-
committed as r9229
http://gwt-code-reviews.appspot.com/1103801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
committed as r9228
http://gwt-code-reviews.appspot.com/1106801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1084801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM except for a problematic comment in samples/build.xml
http://gwt-code-reviews.appspot.com/1085801/diff/54001/55001
File samples/build.xml (right):
http://gwt-code-reviews.appspot.com/1085801/diff/54001/55001#newcode59
samples/build.xml:59: '
http://gwt-code-reviews.appspot.com/1085801/sho
Good good, you guys are so on top of things. I don’t know if I can
explain everything in text, I much prefer a white board, but I will
try.
Here is the high level process that I take to generate the dynamic
content.
1. Compile time I define what dynamic widget are available
2. Runtime -
http://gwt-code-reviews.appspot.com/1085801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2010/11/15 20:20:20, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1085801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: conroy,
Description:
Adds some StringInterner references to reduce overall memory usage
under compile report (soyc). On A large code base, I witnessed a
reduction from 369M to 301M of heap when running the compileReport.
Please review this at http://gwt-code-reviews.appspot.com/1108
Reviewers: jgw,
Description:
Issue 5518 Fix: Panel Alignment Attributes Have No Effect
Please review this at http://gwt-code-reviews.appspot.com/1109801/show
Affected files:
A user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
A
user/src/com/google/gwt/uibinder/eleme
Revision: 9231
Author: b...@google.com
Date: Mon Nov 15 13:42:53 2010
Log: Edited wiki page RequestFactory_2_1_1 through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9231
Modified:
/wiki/RequestFactory_2_1_1.wiki
===
--- /wi
Reviewers: rchandia, rjrjr,
Message:
Review requested.
Rodrigo, since Ray is otherwise occupied this week, please consider
yourself the sole reviewer for this patch.
Description:
First pass at implementing ValueProxy support.
Resolve issue 5522, issue 5373, issue 5559.
http://code.google.com/p/
http://gwt-code-reviews.appspot.com/1109801/diff/1/2
File
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
(right):
http://gwt-code-reviews.appspot.com/1109801/diff/1/2#newcode2
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:2:
* Copyright 2008 Goo
Revision: 9232
Author: b...@google.com
Date: Mon Nov 15 13:43:22 2010
Log: Edited wiki page RequestFactory_2_1_1 through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9232
Modified:
/wiki/RequestFactory_2_1_1.wiki
===
--- /wi
Revision: 9233
Author: ncha...@google.com
Date: Mon Nov 15 10:52:58 2010
Log: Public: GWT version of the JSR 303 Bean Validation TCK
So far only one test is wrapped, One test passses and one fails,
but this shows the patern to use to get the tests going.
The test failure is expected, and represe
http://gwt-code-reviews.appspot.com/1109801/diff/1/2
File
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
(right):
http://gwt-code-reviews.appspot.com/1109801/diff/1/2#newcode24
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:24:
* Parses widgets t
NumberLabel/DateLabel parts look good to me with minor issues.
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27005
File
user/src/com/google/gwt/uibinder/elementparsers/NumberLabelParser.java
(right):
http://gwt-code-reviews.appspot.com/1099801/diff/26001/27005#newcode70
user/src/com/go
Reviewers: rchandia,
Description:
Public: Handle constraints on Primitive fields.
Add TCK test to excercise primitives.
Please review this at http://gwt-code-reviews.appspot.com/1110801/show
Affected files:
M
samples/validation/src/com/google/gwt/sample/validation/shared/Person.java
M
http://gwt-code-reviews.appspot.com/1108801/diff/1/7
File dev/core/src/com/google/gwt/dev/js/ast/JsName.java (right):
http://gwt-code-reviews.appspot.com/1108801/diff/1/7#newcode78
dev/core/src/com/google/gwt/dev/js/ast/JsName.java:78: this.shortIdent =
StringInterner.get().intern(shortIdent);
a
Responding to some offline questions:
In order to have these parsers executed before CellPanelParser, I had to
> create a parser for HasAlignment. I see your point about classes that only
> use HasHorizontalAlignment or HasVerticalAlignment. I could register those
> 2 parsers as well, but that
Reviewers: conroy,
Description:
Check for null as well as undefined in isBodyLoaded()
Please review this at http://gwt-code-reviews.appspot.com/801/show
Affected files:
M dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js
Index: dev/core/src/com/google/gwt/core/linker/C
Reviewers: conroy,
Description:
Update some references to document to be $doc
Please review this at http://gwt-code-reviews.appspot.com/1112801/show
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/installLocationIframe.js
M
dev/core/src/com/google/gwt/core/ext/linker
I think I read your question wrong.
I was thinking you meant an event handler between widgets. Like one
widget reacting to events from another widget.
Now I see you are talking about injecting listeners to do custom
validation. Hmm while I’m sure there are many ways of going about
it. I don’t
http://gwt-code-reviews.appspot.com/1107801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1107801/diff/1/7
File
user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java
(right):
http://gwt-code-reviews.appspot.com/1107801/diff/1/7#newcode52
user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java:52:
public
http://gwt-code-reviews.appspot.com/801/diff/1/2
File dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js
(right):
http://gwt-code-reviews.appspot.com/801/diff/1/2#newcode30
dev/core/src/com/google/gwt/core/linker/CrossSiteIframeTemplate.js:30:
return (typeof $doc.body !=
http://gwt-code-reviews.appspot.com/1108801/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):
http://gwt-code-reviews.appspot.com/1108801/diff/1/4#newcode314
dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java:314:
JavaToJavaScriptMap jjsmap =
When we are waiting for the body to load, we do look for that event.
https://s/?fileprint=//depot/google3/third_party/java_src/gwt/svn/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/waitForBodyLoaded.js
The problem is that late loaded apps will never see that event (as I
understand it) sin
Revision: 9234
Author: knor...@google.com
Date: Mon Nov 15 15:07:03 2010
Log: Adds overflow-x and overflow-y to Style since they have at least
partial support on all browsers.
Review at: http://gwt-code-reviews.appspot.com/1100801
Review by: jgw
http://code.google.com/p/google-web-toolkit/sour
http://gwt-code-reviews.appspot.com/1109801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Has anyone looked at applying this to RequestFactory? Would it be
sufficient for the RequestTransport to maintain the token state?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
See updated patch set.
http://gwt-code-reviews.appspot.com/1109801/diff/1/2
File
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
(right):
http://gwt-code-reviews.appspot.com/1109801/diff/1/2#newcode2
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
Reviewers: zundel,
Description:
Refactors TypeOracle into a set of interfaces rather than concrete
types. Moves implementation into a new package. Functionally, should
be essentially the same.
This will allow for alternative implementations of TypeOracle, including
server-side type models and
66 matches
Mail list logo
