LGTM
http://gwt-code-reviews.appspot.com/1112801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hi,
this line from
http://code.google.com/intl/fr/webtoolkit/doc/latest/DevGuideRequestFactory.html
// properties, getters, and setters omitted public static
ListEmployee findAllEmployees() {
must be remplaced by
// properties, getters, and setters omitted
public static ListEmployee
LGTM
http://gwt-code-reviews.appspot.com/1082801/diff/50001/51001
File user/src/com/google/gwt/canvas/Canvas.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1082801/diff/50001/51001#newcode17
user/src/com/google/gwt/canvas/Canvas.gwt.xml:17: inherits
name=com.google.gwt.canvas.dom.DOM/
I
http://gwt-code-reviews.appspot.com/1108801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: pdr,
Description:
Fixing a bug in SingleSelectionModel where deselecting a random value
causes the selected value to be deselected, even if the deselected value
wasn't selected to begin with.
Please review this at http://gwt-code-reviews.appspot.com/1114801/show
Affected files:
M
On 2010/11/16 16:08:56, zundel wrote:
LGTM
http://gwt-code-reviews.appspot.com/1108801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1114801/diff/1/2
File user/src/com/google/gwt/view/client/SelectionModel.java (right):
http://gwt-code-reviews.appspot.com/1114801/diff/1/2#newcode75
user/src/com/google/gwt/view/client/SelectionModel.java:75: :
keyProvider.getKey(item);
Cell Widgets already
Reviewers: jat, knorton, conroy,
Description:
IE devmode plugin: 64 bits support end-to-end, build fixes cleanup,
other polishing items.
Please review this at http://gwt-code-reviews.appspot.com/1115801/show
Affected files:
A plugins/ie/README.txt
A plugins/ie/build.cmd
D
On 15 November 2010 10:08, Hilco Wijbenga hilco.wijbe...@gmail.com wrote:
On 15 November 2010 09:37, John Tamplin j...@google.com wrote:
When was that attribute added? We still have people using ant 1.6.5,
so if older ants will fail we can't add that attribute.
In 1.8.0, it doesn't seem to
Revision: 9236
Author: zun...@google.com
Date: Tue Nov 16 06:16:48 2010
Log: Adds some StringInterner references to reduce overall memory usage
under compile report (soyc). On A large code base, I witnessed a
reduction from 369M to 301M of heap when running the compileReport.
Review at
Please take a look at mondrian as well as the binary changes do not show up
in rietveld.
thx
afbio
On Tue, Nov 16, 2010 at 11:59 AM, fabio...@google.com wrote:
Reviewers: jat, knorton, conroy,
Description:
IE devmode plugin: 64 bits support end-to-end, build fixes cleanup,
other
LGTM.
I took a look at MultiSelectionModel and it doesn't appear to have this
problem. Can you confirm that?
http://gwt-code-reviews.appspot.com/1114801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
MultiSelectionModel shouldn't have this problem because it accrues
changes in a list then resolves them in order.
http://gwt-code-reviews.appspot.com/1114801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1109801/diff/12001/13001
File
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
(right):
http://gwt-code-reviews.appspot.com/1109801/diff/12001/13001#newcode29
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:29:
*
http://gwt-code-reviews.appspot.com/1109801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1109801/diff/12001/13001
File
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java
(right):
http://gwt-code-reviews.appspot.com/1109801/diff/12001/13001#newcode29
user/src/com/google/gwt/uibinder/elementparsers/HasAlignmentParser.java:29:
*
LGTM
http://gwt-code-reviews.appspot.com/1110801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM with one more fix, below
http://gwt-code-reviews.appspot.com/1109801/diff/19001/20003
File
user/test/com/google/gwt/uibinder/elementparsers/HasAlignmentParserTest.java
(right):
http://gwt-code-reviews.appspot.com/1109801/diff/19001/20003#newcode69
Revision: 9237
Author: jlaba...@google.com
Date: Tue Nov 16 08:49:35 2010
Log: Fixing a bug in SingleSelectionModel where deselecting a random value
causes the selected value to be deselected, even if the deselected value
wasn't selected to begin with.
Review at
Hey Scott, before continuing this review, I'd appreciate a patch I can
apply so I can look at this in Eclipse.
http://gwt-code-reviews.appspot.com/1113801/diff/1/4
File dev/core/src/com/google/gwt/core/ext/typeinfo/JAnnotationType.java
(right):
http://gwt-code-reviews.appspot.com/1109801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM.
The only legitimate reason body could be null AFAIK is if the document
itself lacks a body tag. Though, given that this appears to be older
Firefox specific, we could just be hitting a browser bug here. I wasn't
able to find anything in their bugzilla, but this is a safe change
regardless.
Revision: 9238
Author: unn...@google.com
Date: Tue Nov 16 10:12:20 2010
Log: Update some references to document to be $doc
Review at http://gwt-code-reviews.appspot.com/1112801
Review by: con...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9238
Modified:
Revision: 9239
Author: unn...@google.com
Date: Tue Nov 16 10:12:46 2010
Log: Check for null as well as undefined in isBodyLoaded()
Review at http://gwt-code-reviews.appspot.com/801
Review by: con...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9239
Modified:
Revision: 9240
Author: unn...@google.com
Date: Tue Nov 16 10:13:16 2010
Log: Close the readers
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9240
Modified:
/trunk/user/src/com/google/gwt/junit/server/JUnitHostImpl.java
Revision: 9241
Author: sbruba...@google.com
Date: Tue Nov 16 10:15:45 2010
Log: Issue 5518 Fix: Panel Alignment Attributes Have No Effect
Review at http://gwt-code-reviews.appspot.com/1109801
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9241
Added:
committed as r9237
http://gwt-code-reviews.appspot.com/1114801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9242
Author: ncha...@google.com
Date: Tue Nov 16 11:22:38 2010
Log: Public: Handle constraints on Primitive fields.
Add TCK test to excercise primitives.
Review at http://gwt-code-reviews.appspot.com/1110801
Review by: rchan...@google.com
still slogging through, a few more comments
http://gwt-code-reviews.appspot.com/1113801/diff/1/12
File dev/core/src/com/google/gwt/core/ext/typeinfo/JMethod.java (right):
http://gwt-code-reviews.appspot.com/1113801/diff/1/12#newcode36
http://gwt-code-reviews.appspot.com/1113801/diff/1/4
File dev/core/src/com/google/gwt/core/ext/typeinfo/JAnnotationType.java
(right):
http://gwt-code-reviews.appspot.com/1113801/diff/1/4#newcode23
dev/core/src/com/google/gwt/core/ext/typeinfo/JAnnotationType.java:23:
throws NotFoundException;
I haven't look at RequestFactory, but it should be possible to have
RequestFactory propagate the object to RequestContext and include it in the
payload.
On Tue, Nov 16, 2010 at 2:01 PM, BobV b...@google.com wrote:
Has anyone looked at applying this to RequestFactory? Would it be
sufficient
Reviewers: rchandia,
Description:
Public: Improve reporting of TCK failures
Please review this at http://gwt-code-reviews.appspot.com/1117801/show
Affected files:
M samples/validationtck/build.xml
M samples/validationtck/src/com/google/gwt/sample/validationtck/Tck.java
D
Reviewers: conroy,
Description:
In a previous patch, I fixed the doc.findElements... function to be
document.findElements, which uncovered
this bug where we were calling append rather than appendChild, which
hoses on Safari. I'm not sure why
it was ok for Chrome, which is where we tested the
LGTM.
It does trigger an error on Chrome as well.
On Wed, Nov 17, 2010 at 4:25 AM, unn...@google.com wrote:
Reviewers: conroy,
Description:
In a previous patch, I fixed the doc.findElements... function to be
document.findElements, which uncovered
this bug where we were calling append
Revision: 9244
Author: unn...@google.com
Date: Tue Nov 16 19:59:25 2010
Log: In a previous patch, I fixed the doc.findElements... function to be
document.findElements, which uncovered
this bug where we were calling append rather than appendChild, which hoses
on Safari. I'm not sure why
it
35 matches
Mail list logo
