Re: [gwt-contrib] GWT,jsni() implemented as rebinding method

2013-12-16 Thread Goktug Gokdogan
rewriters; one for java and one for javascript and they should do real method replacement. Developer can choose either one. It looks like you are really interested in this. Can you also improve your proposal with real method rewriting? > > - Andrés Testi > > > El lunes, 16 de di

Re: [gwt-contrib] GWT,jsni() implemented as rebinding method

2013-12-16 Thread Goktug Gokdogan
I actually implemented with simple eval for demonstration purposes but probably yours is preferable :) Yes, GWT.jsni is one of the use cases for method rebinding; that was something I was discussing as part of the original discussion. In reality GWT.jsni is better to be implementable without "nat

Re: [gwt-contrib] Re: Unsupported browsers

2013-12-04 Thread Goktug Gokdogan
Filed https://code.google.com/p/google-web-toolkit/issues/detail?id=8478 On Wed, Dec 4, 2013 at 6:11 AM, Jens wrote: > I agree with Jens' points. We need: >> >> 1. Better out of the box experience (give some error message by default) >> 2. (Assuming we'll have a fallback permutation in the futu

Re: [gwt-contrib] Re: 2.6.0-rc2

2013-12-03 Thread Goktug Gokdogan
I sent it for cherry-picking earlier today. There was a few other missing patches as well. Matthew is going to release RC3 soon. On Tue, Dec 3, 2013 at 11:01 AM, Colin Alworth wrote: > What's the current thinking on removing ImageResource.isStandalone from > 2.6.0 final, as in the https://gwt-r

Re: [gwt-contrib] Re: Unsupported browsers

2013-12-02 Thread Goktug Gokdogan
Yes, actually that is my mistake. My recollection was from a server-side script selection logic. I experimented with CrossSiteIframeLinker and the current behavior is: the client side selection script returns 'undefined' and it ends up trying to load undefined.cache.js. As the script load fails, t

Re: [gwt-contrib] Rebinding Methods improvement proposal and working prototype

2013-11-28 Thread Goktug Gokdogan
Good work Andres. The problem is, as I noted in earlier discussions, the semantics of this feature is pretty complex. It is difficult to understand what is going on and how to properly use it. Also in addition to that it adds more responsibility to the compiler and forces a more opinionated style

[gwt-contrib] Unsupported browsers

2013-11-26 Thread Goktug Gokdogan
Hey guys. As we dropped IE6/7 permutation, we started to see more incidents related to unsupported browsers. Currently, when a browser is unsupported (incl IE compatibility modes), GWT falls back to gecko1_8. The problem is Firefox itself has its own bugs and we have workarounds for those that wi

Re: [gwt-contrib] elemental templates

2013-11-23 Thread Goktug Gokdogan
On Fri, Nov 22, 2013 at 11:45 PM, Stephen Haberman wrote: > Hey, > > Just curious, but what's the story around templating for Elemental? > > Googling around seems like it's not supported by UiBinder. Is there > anything coming along/WIP internally? Will Goktug's new widget proposal > be based on

Re: [gwt-contrib] JsArrayList - List implementation for OverlayTypes (wrapping JsArray)

2013-11-22 Thread Goktug Gokdogan
On Thu, Nov 21, 2013 at 6:46 PM, Danilo Reinert wrote: > Hi all, > > Finally I've made an acceptable implementation of List for > JavaScriptObjects. > > Thanks to T. Broyer's suggestion on this > topic > I've > achieved

Re: [gwt-contrib] Officially deprecating Opera permutation

2013-11-20 Thread Goktug Gokdogan
Yes, that's correct. On Wed, Nov 20, 2013 at 12:08 PM, Colin Alworth wrote: > Just to confirm, the plan is to set this in master as well as > releases/2.6, and this will go out in 2.6.0-rc2? > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > --- > You received this messag

[gwt-contrib] Officially deprecating Opera permutation

2013-11-20 Thread Goktug Gokdogan
It looks like Opera 12's market share (the last non-webkit Opera version) is now below 0.5% and newer versions already should use the webkit permutation. The support was already very weak and we don't see any reason to continue it. Similar to IE6/7 deprecation, we will start with disabling the per

Re: [gwt-contrib] Re: Deprecating com.google.gwt.widget?

2013-11-08 Thread Goktug Gokdogan
d the HTML doesn't actually matches the > SafeHtmlTemplates from ButtonCellBase, but it might just be taking > advantage of the Appearances). > > Maybe we should move them to c.g.g.user instead? > > > On Thursday, November 7, 2013 12:08:41 AM UTC+1, Goktug Gokdogan

[gwt-contrib] Deprecating com.google.gwt.widget?

2013-11-06 Thread Goktug Gokdogan
This is another deprecation proposal; this time for com.google.gwt.widget. It looks like this is a leftover from an effort to provide a new set of widgets based on cells + appearance. Unfortunately it never took of and we don't have any plans to pursue that path as part of the roadmap. However rig

[gwt-contrib] Deprecating and moving AsyncProxy out of SDK

2013-11-04 Thread Goktug Gokdogan
Although AsyncProxy looks fancy and might look like a good idea at first, I actually think the due to potential unsafe usages and practicality reasons, it may not be a good idea to include as part of the core SDK. The main reason for that is if the methods include logic then you cannot use it beca

Re: [gwt-contrib] Re: Non-client apis and breaking changes

2013-10-18 Thread Goktug Gokdogan
On Fri, Oct 18, 2013 at 3:21 PM, Thomas Broyer wrote: > > > On Friday, October 18, 2013 1:53:46 PM UTC+2, Goktug Gokdogan wrote: > >> >> >> >> On Fri, Oct 18, 2013 at 12:10 PM, Thomas Broyer wrote: >> >>> >>> >>> On Friday, O

Re: [gwt-contrib] Re: Non-client apis and breaking changes

2013-10-18 Thread Goktug Gokdogan
On Fri, Oct 18, 2013 at 12:10 PM, Thomas Broyer wrote: > > > On Friday, October 18, 2013 7:21:48 AM UTC+2, Colin Alworth wrote: >> >> Just wandered by >> https://gwt-review.**googlesource.com/#/c/1040/and >> noticed that with this change, any downs

Re: [gwt-contrib] IE10 and historic dates

2013-10-18 Thread Goktug Gokdogan
On Thu, Oct 17, 2013 at 8:34 PM, Daniel Kurka wrote: > Hi all, > > IE10 does not handle dates the same way other browser do anymore. This > breaks a test in the EmulSuite. > > // IE10 (Standards mode) > >> new Date(Date.parse("3/31/2000")).toUTCString() > "Fri, 31 Mar 2000 07:00:00 UTC" > > // IE

Re: [gwt-contrib] Re: Implement subpixels to support IE10

2013-10-14 Thread Goktug Gokdogan
Perhaps we can just avoid the trouble and introduce sub-pixel APIs only with the new Elemental(*) - not from old APIs (including 3.0 release). In the mean-time we can improve the internals of current widgets to better utilize subpixel values like the Daniel's patch. * I'm planning to write a doc f

Re: [gwt-contrib] Build failures after deprecated tree/treeitem methods removed

2013-10-07 Thread Goktug Gokdogan
It looks like this sample is also not part of our internal build targets. I'm ok with deleting it or fixing the compile by using the safe alternatives of the deleted methods. On Fri, Oct 4, 2013 at 11:17 PM, Colin Alworth wrote: > It looks like a recent commit that removed some deprecated metho

Re: [gwt-contrib] Re: Making user.agent easier to extend to add new permutations

2013-09-26 Thread Goktug Gokdogan
sure if we are going to save much by not making it little bit easier. I think most important question is; if you guys think that this change adds value and useful in the long run or not. If it is not, I'm ok with dropping it. On Thu, Sep 12, 2013 at 11:50 AM, Goktug Gokdogan wrote: > So

Re: [gwt-contrib] Re: Maven-ization Status

2013-09-26 Thread Goktug Gokdogan
I have been in favor of Buck because that is what most contributors are already familiar with and can bring their expertise. It is already proved to work well with gwt. Also the compiler speed optimizations are done and experimented based on the architecture of Buck; especially new stuff that John

Re: [gwt-contrib] Re: Making user.agent easier to extend to add new permutations

2013-09-12 Thread Goktug Gokdogan
> widgets, so this was a deal-breaker right off the bat. > > > On Wed, Sep 11, 2013 at 4:40 AM, Thomas Broyer wrote: > >> >> On Wednesday, September 11, 2013 3:10:56 AM UTC+2, Goktug Gokdogan wrote: >>> >>> I recently noticed that developers are fork

[gwt-contrib] Making user.agent easier to extend to add new permutations

2013-09-10 Thread Goktug Gokdogan
I recently noticed that developers are forking c.g.gwt.useragent in order to be able to add new browser permutations to existing ones. This is suboptimal and causes code duplication and possibly trying keep it in sync with the original during updates. The root cause of this is the determination of

Re: [gwt-contrib] Re: Nextgen GWT/JS Interop (Public) (google-web-tool...@googlegroups.com)

2013-09-09 Thread Goktug Gokdogan
Interesting idea; though we still need an annotation when the name is not a valid java identifier and also can't find a good name to mark the exception case. Another issue is anyone who is not aware of convention can be surprised by it (e.g. developer renames a method and the method is no longer a

Re: [gwt-contrib] Thoughts on dropwizard framework as a backend for GWT

2013-08-28 Thread Goktug Gokdogan
On Wed, Aug 28, 2013 at 1:58 PM, Thomas Broyer wrote: > > > On Wednesday, August 28, 2013 11:37:15 AM UTC+2, Jens wrote: >> >> Isn't that what Cloud Endpoints do already? The problem with both of them >>> is that you cannot write a client for any existing web API, as there are >>> constraints in

Re: [gwt-contrib] CSS3 support in CssResource: Closure Stylesheets?

2013-08-27 Thread Goktug Gokdogan
What we were planning was to add support for GSS, add the missing features and then migrate existing users and deprecate the older eventually. This would decrease the maintenance cost a lot in the long term. We really want to see GSS support for GWT in the long term. On top of additional features,

Re: [gwt-contrib] Gwt benchmarks without Benchmark

2013-08-26 Thread Goktug Gokdogan
The latest benchmarks (before the removal Benchmarks suite) was done by custom infra: https://gwt.googlesource.com/gwt/+/master/reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark If you would like to collect timing from some previous GWTTestCases you can do that by overriding s

Re: [gwt-contrib] Possible GWT.create() Improvements (link)

2013-08-12 Thread Goktug Gokdogan
John, I put together a quick proposal for "evaluate-with" as a comment to the document. Please take a look. On Sun, Aug 11, 2013 at 11:42 PM, John A. Tamplin wrote: > On Mon, Aug 12, 2013 at 2:29 AM, Goktug Gokdogan wrote: > >> An example use-case would be implementing

Re: [gwt-contrib] Possible GWT.create() Improvements (link)

2013-08-11 Thread Goktug Gokdogan
On Sun, Aug 11, 2013 at 10:16 PM, John A. Tamplin wrote: > On Mon, Aug 12, 2013 at 1:13 AM, Goktug Gokdogan wrote: > >> Even though the current form is pretty flexible and you can mix and match >> the two, it doesn't mean it makes sense to do so. I'm having hard time

Re: [gwt-contrib] Possible GWT.create() Improvements (link)

2013-08-11 Thread Goktug Gokdogan
Today, even GWT generator developers are having trouble debugging generated code with -gen (just think GWTTestCase). It is not very practical for every day usage of end users. I don't know how well APT support of IDEs are today but that's something that IDE's itself can improve upon and we can just

Re: [gwt-contrib] Possible GWT.create() Improvements (link)

2013-08-11 Thread Goktug Gokdogan
On Sat, Aug 10, 2013 at 11:18 AM, Brian Slesinsky wrote: > >>2. IDE support: IDE can trigger codegen (esp. for debugging) >>> >> >> My experience with this has been pretty poor, and running GWT with -gen >> is at least as useful. >> > > Also, Super Dev Mode gives you access to all the generate

Re: [gwt-contrib] Possible GWT.create() Improvements (link)

2013-08-11 Thread Goktug Gokdogan
On Sat, Aug 10, 2013 at 10:28 AM, John A. Tamplin wrote: > On Fri, Aug 9, 2013 at 7:16 PM, Goktug Gokdogan wrote: > >> I think in the long-run we should separate the two concepts that is being >> tackled by GWT.create today. >> >> First purpose is the class r

Re: [gwt-contrib] Possible GWT.create() Improvements (link)

2013-08-11 Thread Goktug Gokdogan
ht work. APT has limitations that make it problematic to > replace generators. Stephen Haberman brought this up at the GWT meetup. > > > > On Fri, Aug 9, 2013 at 4:16 PM, Goktug Gokdogan wrote: > > I think in the long-run we should separate the two concepts that is being > tackled b

Re: [gwt-contrib] Possible GWT.create() Improvements (link)

2013-08-11 Thread Goktug Gokdogan
Even though the current form is pretty flexible and you can mix and match the two, it doesn't mean it makes sense to do so. I'm having hard time thinking about out a good use case that would make a single complex mix and match more appealing than having a separate group of class replacements and a

Re: [gwt-contrib] Possible GWT.create() Improvements (link)

2013-08-09 Thread Goktug Gokdogan
I think in the long-run we should separate the two concepts that is being tackled by GWT.create today. First purpose is the class replacement, especially used by permutations. I think this one should not have anything to do with GWT.create. We can do any class replacement in compiler without requi

Re: [gwt-contrib] Nextgen GWT/JS Interop (Public) (google-web-toolkit-contributors@googlegroups.com)

2013-08-08 Thread Goktug Gokdogan
al code from WebKit IDL files wasn't >> easy. >> >> However, our main use case is to import web components which are new. So >> my question is how likely people are to write .d.ts files for web >> components; I don't know if there is much overlap betwe

Re: [gwt-contrib] Nextgen GWT/JS Interop (Public) (google-web-toolkit-contributors@googlegroups.com)

2013-08-06 Thread Goktug Gokdogan
with any preexisted js. Moreover, already existing .d.ts >> files for many js libraries exist on >> https://github.com/borisyankov/DefinitelyTyped >> No extra wirk to do then :) >> >> Best regards >> Xavier >> >> >> Envoyé de mon iPhone >> >

Re: [gwt-contrib] Re: Nextgen GWT/JS Interop (Public) (google-web-tool...@googlegroups.com)

2013-08-06 Thread Goktug Gokdogan
there be a function/callback interface that > will be autowrapped in $entry and bind to be passed in, or will this simply > access a JSO that will be treated as a function? > > If you are asking specific to Js.Array.foreach; It doesn't need to be a JSO; you can pass a lambda expression. i

Re: [gwt-contrib] Nextgen GWT/JS Interop (Public) (google-web-toolkit-contributors@googlegroups.com)

2013-08-06 Thread Goktug Gokdogan
t; many js libraries exist on > https://github.com/borisyankov/DefinitelyTyped > No extra wirk to do then :) > > Best regards > Xavier > > > Envoyé de mon iPhone > > Le 6 août 2013 à 09:24, "Goktug Gokdogan (Google Drive)" < > gok...@google.com> a écri

[gwt-contrib] Nextgen GWT/JS Interop (Public) (google-web-toolkit-contributors@googlegroups.com)

2013-08-06 Thread Goktug Gokdogan (Google Drive)
I've shared an item with you: Nextgen GWT/JS Interop (Public) https://docs.google.com/document/d/1tir74SB-ZWrs-gQ8w-lOEV3oMY6u6lF2MmNivDEihZ4/edit?usp=sharing It's not an attachment -- it's stored online. To open this item, just click the link above. This is a design doc that describes a pro

[gwt-contrib] Re: Getting rid of autoboxing?

2013-08-03 Thread Goktug Gokdogan
t definitely break DevMode. For interop purposes, just > declaring the right return type is better IMHO. If you were to write a game > using WebGL that had all the interfaces using boxed types, it would be > horrendous performance wise. > > Eliminating autoboxing via a hack like thi

Re: [gwt-contrib] Getting rid of autoboxing?

2013-08-01 Thread Goktug Gokdogan
boxing functionality; i.e., you don't want to make "Object x = 3.0;" > into a compiler error. That's definitely a no-go in my opinion, since > it'll break Java language compatibility. > > > On Thu, Aug 1, 2013 at 6:01 PM, Goktug Gokdogan wrote: > >> I

[gwt-contrib] Getting rid of autoboxing?

2013-08-01 Thread Goktug Gokdogan
I was thinking about autoboxing of numbers when assigned to Object and I started to question if we really need them in Java to JS translation - at least for a subset (i.e. Integer and Double). Object has only a few methods that we can put into Number.prototype (like we do for String) and all metho

Re: [gwt-contrib] Should GWT support WebGL without Elemental ? (or should Elemental be extended to support more browsers ?)

2013-07-29 Thread Goktug Gokdogan
Not specific to WebGL but for anything becomes part of the GWT core, we want it to first evolve and 'be proven' as a 3rd party library first (when it is feasible). On Mon, Jul 29, 2013 at 2:03 AM, Alberto Mancini wrote: > Hi, > hope this is the right list for this discussion. > > WebGL is today

Re: [gwt-contrib] Working on a patch to fix Exception wrapping/unwrapping in compiler

2013-07-09 Thread Goktug Gokdogan
any exception (e.g. IOException), it would still cause the same problems - having just a 'catch' was enough to break native exceptions.) > > On Fri, Jun 14, 2013 at 5:51 PM, Goktug Gokdogan wrote: > >> I just wanted to give you a heads up that Roberto and I are work

[gwt-contrib] Change in gwt[master]: Fix SingleSelectionModel.getSelectedSet()

2013-07-09 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Fix SingleSelectionModel.getSelectedSet() .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3680 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Fix SingleSelectionModel.getSelectedSet()

2013-07-09 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Fix SingleSelectionModel.getSelectedSet() .. Patch Set 1: (2 comments) File user/test/com/google/gwt

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-09 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Utility to store multiple HandlerRegistrations .. Patch Set 6: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/3661 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-09 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Move arrow key functions from Tree to KeyCodes .. Patch Set 8: Code-Review+1 (1 comment) File user/src

[gwt-contrib] Change in gwt[master]: Fixes Exception wrapping/unwrapping in compiler

2013-07-09 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Fixes Exception wrapping/unwrapping in compiler .. Patch Set 3: Actually, I briefly discussed this issue with you before when I asked you putting try/catch

[gwt-contrib] Change in gwt[master]: Move arrow key functions from Tree to KeyCodes

2013-07-08 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Move arrow key functions from Tree to KeyCodes .. Patch Set 4: Code-Review+1 (3 comments) Looks good to me API wise

[gwt-contrib] Change in gwt[master]: Utility to store multiple HandlerRegistrations

2013-07-08 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Utility to store multiple HandlerRegistrations .. Patch Set 3: (3 comments) File user/src/com/google

[gwt-contrib] Change in gwt[master]: Adds support for unwrapping of thrown non-jso objects from J...

2013-07-03 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/3640 Change subject: Adds support for unwrapping of thrown non-jso objects from JavaScriptException. .. Adds support for

[gwt-contrib] Change in gwt[master]: Fixes Exception wrapping/unwrapping in compiler

2013-07-03 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Fixes Exception wrapping/unwrapping in compiler .. Fixes Exception wrapping/unwrapping in compiler Change-Id

[gwt-contrib] Change in gwt[master]: Fixes Exception wrapping/unwrapping in compiler

2013-07-02 Thread Goktug Gokdogan
//gwt-review.googlesource.com/3601 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I419204b3b6f76bd9171c322a87fa164a7c72ab94 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Goktug Gok

[gwt-contrib] Change in gwt[master]: Fixes Exception wrapping/unwrapping in compiler

2013-07-02 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Fixes Exception wrapping/unwrapping in compiler .. Patch Set 1: (2 comments) File dev/core/src/com

[gwt-contrib] Change in gwt[master]: Fixes Exception wrapping/unwrapping in compiler

2013-07-01 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/3601 Change subject: Fixes Exception wrapping/unwrapping in compiler .. Fixes Exception wrapping/unwrapping in compiler Change-Id

[gwt-contrib] Change in gwt[master]: Move StackTraceDeobfuscator from core.server.impl to core.se...

2013-06-27 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Move StackTraceDeobfuscator from core.server.impl to core.server. .. Patch Set 2: Pinging just in case if you have forgot about this patch; otherwise

[gwt-contrib] Change in gwt[master]: Adds a regression test for fragment splitting

2013-06-27 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds a regression test for fragment splitting .. Patch Set 5: (1 comment) File user/src/com/google/gwt

[gwt-contrib] Change in gwt[master]: Adds a regression test for fragment splitting

2013-06-27 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds a regression test for fragment splitting .. Patch Set 6: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3590 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: adds regression testing against future changes that might ac...

2013-06-27 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment .. Patch Set 5: Code-Review+2 (3

[gwt-contrib] Change in gwt[master]: adds regression testing against future changes that might ac...

2013-06-26 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: adds regression testing against future changes that might accidentally push all fragment code into the leftover fragment .. Patch Set 4: (4 comments

[gwt-contrib] Change in gwt[master]: Fixes JRawType#getImplementedMethods to return correct signa...

2013-06-25 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Fixes JRawType#getImplementedMethods to return correct signature for inherited methods .. Fixes JRawType#getImplementedMethods to return correct

[gwt-contrib] Change in gwt[master]: Adds Node#removeAllChildren.

2013-06-20 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds Node#removeAllChildren. .. Patch Set 2: Thanks for the detailed analysis. It is good to know that compiler can optimize the null checks. For the

[gwt-contrib] Change in gwt[master]: Move StackTraceDeobfuscator from core.server.impl to core.se...

2013-06-19 Thread Goktug Gokdogan
https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic84f3b2210e3c40f0f7dc41bdeea9d13bf1a4dc6 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Leeroy Jenkins --

[gwt-contrib] Change in gwt[master]: Fixes GWT.runAsync that was broken in a recent patch.

2013-06-19 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Fixes GWT.runAsync that was broken in a recent patch. .. Fixes GWT.runAsync that was broken in a recent patch. This is a regression to my previous

[gwt-contrib] Change in gwt[master]: Adds Node#removeAllChildren.

2013-06-19 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Adds Node#removeAllChildren. .. Adds Node#removeAllChildren. Change-Id: Ic607bf6523a41c0ee4020a12e8505b1d8b39d916 --- M user/src/com/google/gwt/dom

[gwt-contrib] Change in gwt[master]: Adds an accessor to original throwable from SerializableThro...

2013-06-19 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds an accessor to original throwable from SerializableThrowable. .. Patch Set 3: Code-Review+2 Only made a trivial change to javadoc after +2. -- To

[gwt-contrib] Change in gwt[master]: Adds an accessor to original throwable from SerializableThro...

2013-06-19 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Adds an accessor to original throwable from SerializableThrowable. .. Adds an accessor to original throwable from SerializableThrowable. This

[gwt-contrib] Change in gwt[master]: Adds Element#toggleClassName.

2013-06-19 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Adds Element#toggleClassName. .. Adds Element#toggleClassName. Change-Id: I1b2a507d5ee8482a91aae28c9dc9a6b6826afb2f --- M user/src/com/google/gwt

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

2013-06-19 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Adds Timer#isRunning(). .. Adds Timer#isRunning(). This patch uses Integer instead of int to keep track of the running status. As now, running state

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

2013-06-19 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds Timer#isRunning(). .. Patch Set 2: Thanks for the review. -- To view, visit https://gwt-review.googlesource.com/3321 To unsubscribe, visit https://gwt

[gwt-contrib] Change in gwt[master]: Fixes GWT.runAsync that was broken in a recent patch.

2013-06-19 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Fixes GWT.runAsync that was broken in a recent patch. .. Patch Set 1: Yes, we can do that but better we should be able to catch these with test cases. I

[gwt-contrib] Change in gwt[master]: Adds Node#removeAllChildren.

2013-06-19 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds Node#removeAllChildren. .. Patch Set 1: (1 comment) File user/src/com/google/gwt/dom/client

[gwt-contrib] Change in gwt[master]: Move StackTraceDeobfuscator from core.server.impl to core.se...

2013-06-18 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/3512 Change subject: Move StackTraceDeobfuscator from core.server.impl to core.server. .. Move StackTraceDeobfuscator from

[gwt-contrib] Change in gwt[master]: Adds Node#removeAllChildren.

2013-06-18 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/3511 Change subject: Adds Node#removeAllChildren. .. Adds Node#removeAllChildren. Change-Id

[gwt-contrib] Change in gwt[master]: Adds an accessor to original throwable from SerializableThro...

2013-06-18 Thread Goktug Gokdogan
chset Gerrit-Change-Id: I6856ca06f85af0165eea5ff6ac3015081b579352 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins -- http://groups.google.com/group/Googl

[gwt-contrib] Change in gwt[master]: Adds Element#toggleClassName.

2013-06-18 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/3501 Change subject: Adds Element#toggleClassName. .. Adds Element#toggleClassName. Change-Id

[gwt-contrib] Change in gwt[master]: Adds an accessor to original throwable from SerializableThro...

2013-06-18 Thread Goktug Gokdogan
chset Gerrit-Change-Id: I6856ca06f85af0165eea5ff6ac3015081b579352 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Leeroy Jenkins -- http://groups.google.com/group/Googl

[gwt-contrib] Change in gwt[master]: Adds an accessor to original throwable from SerializableThro...

2013-06-18 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds an accessor to original throwable from SerializableThrowable. .. Patch Set 1: (1 comment) File

[gwt-contrib] Change in gwt[master]: Fixes GWT.runAsync that was broken in a recent patch.

2013-06-18 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/3510 Change subject: Fixes GWT.runAsync that was broken in a recent patch. .. Fixes GWT.runAsync that was broken in a recent patch

[gwt-contrib] Change in gwt[master]: Adds an accessor to original throwable from SerializableThro...

2013-06-18 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/3500 Change subject: Adds an accessor to original throwable from SerializableThrowable. .. Adds an accessor to original throwable

[gwt-contrib] Change in gwt[master]: Fixes UiHandler method matching in generic classes

2013-06-18 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Fixes UiHandler method matching in generic classes .. Fixes UiHandler method matching in generic classes Method matching in UiHandler is completely

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

2013-06-18 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds Timer#isRunning(). .. Patch Set 2: Daniel, do you have any other concerns? -- To view, visit https://gwt-review.googlesource.com/3321 To unsubscribe

[gwt-contrib] Change in gwt[master]: Use "Double.isNaN(d)" instead of "d != d" to test for NaN.

2013-06-18 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Use "Double.isNaN(d)" instead of "d != d" to test for NaN. .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.goog

[gwt-contrib] Change in gwt[master]: Add interfaces for widgets.

2013-06-18 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Add interfaces for widgets. .. Patch Set 8: The part that I'm not comfortable with is, you can exactly have the same effect with the current state.

[gwt-contrib] Change in gwt[master]: Add interfaces for widgets.

2013-06-17 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Add interfaces for widgets. .. Patch Set 8: I thought "IsXXX" just meant "we really wanted to name this interface just 'XXX',

[gwt-contrib] Working on a patch to fix Exception wrapping/unwrapping in compiler

2013-06-14 Thread Goktug Gokdogan
I just wanted to give you a heads up that Roberto and I are working on a compiler patch so that catch statement will not break js originated exceptions. To give you some background, if you put any try/catch statement in Java, js originated exceptions will be converted into JavaScriptException even

Re: [gwt-contrib] Work to do for bug 3042

2013-06-14 Thread Goktug Gokdogan
Agreed. We don't need to provide a complex RichTextArea for GWT out of the box. It makes sense to quickly iterate on it in a different open source project. In the meantime, if you end up having small patches to improve the existing one in GWT, feel free to send them. On Fri, Jun 14, 2013 at 3:34

[gwt-contrib] Change in gwt[master]: Adds Timer#isRunning().

2013-06-13 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds Timer#isRunning(). .. Patch Set 2: (1 comment) File user/src/com/google/gwt/user/client/Timer.java

[gwt-contrib] Change in gwt[master]: Set display to none for table columns that should not be vis...

2013-06-13 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Set display to none for table columns that should not be visible. .. Set display to none for table columns that should not be visible. Change-Id

[gwt-contrib] Change in gwt[master]: Set display to none for table columns that should not be vis...

2013-06-13 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Set display to none for table columns that should not be visible. .. Patch Set 3: Code-Review+2 Ok, I (or him) might have misinterpreted what is going on

[gwt-contrib] Change in gwt[master]: Set display to none for table columns that should not be vis...

2013-06-13 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Set display to none for table columns that should not be visible. .. Patch Set 1: (1 comment) File

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

2013-06-13 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adding a DOM clear method to RootPanel .. Patch Set 6: It is better to just call it "clear" so that people will need to read the javadoc instead

[gwt-contrib] Change in gwt[master]: Set display to none for table columns that should not be vis...

2013-06-13 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Set display to none for table columns that should not be visible. .. Patch Set 3: Aliseya, you very likely responded to my comments but I can't see

[gwt-contrib] Change in gwt[master]: adding compare for several number types

2013-06-13 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: adding compare for several number types .. Patch Set 14: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3180 To unsubscribe, visit https

[gwt-contrib] Change in gwt[master]: adding compare for several number types

2013-06-13 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: adding compare for several number types .. Patch Set 12: (1 comment) The comparison functions are usually used in non linear algorithm like sorting so

[gwt-contrib] Change in gwt[master]: Add support for 'ImageResource' to @url substitution in css....

2013-06-13 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Add support for 'ImageResource' to @url substitution in css. Only 'DataResource' used to be supported. .. Patch Set 2: Code-Review+

[gwt-contrib] Change in gwt[master]: Add support for 'ImageResource' to @url substitution in css....

2013-06-13 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Add support for 'ImageResource' to @url substitution in css. Only 'DataResource' used to be supported. .. Add support for &#x

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

2013-06-12 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 9: A good rule of thumb is; if you can't fix it in 5 min, you should revert. More time the trunk is left b

<    1   2   3   4   5   6   7   8   >