Re: [hackers] [dmenu][PATCH] Remove warning for int comparison as bool

2022-03-01 Thread Prathu Baronia
On 02-03-2022 03:18, Hiltjo Posthuma wrote: On Fri, Feb 25, 2022 at 11:07:49AM +0530, Prathu Baronia wrote: - Compare the result of the macro with 0 instead of treating as bool to remove the following warning. dmenu.c: In function ‘setup’: dmenu.c:24:30: warning: ‘*’ in boolean context,

Re: [hackers] [dmenu][PATCH] Remove warning for int comparison as bool

2022-03-01 Thread Hiltjo Posthuma
On Fri, Feb 25, 2022 at 11:07:49AM +0530, Prathu Baronia wrote: > - Compare the result of the macro with 0 instead of treating as bool to remove > the following warning. > > dmenu.c: In function ‘setup’: > dmenu.c:24:30: warning: ‘*’ in boolean context, suggest ‘&&’ instead >

[hackers] [dmenu] remove false-positive warning for int comparison as bool || Hiltjo Posthuma

2022-03-01 Thread git
commit 3a505cebe8adab204e5619357e0bfe3f9f3a92ff Author: Hiltjo Posthuma AuthorDate: Tue Mar 1 22:45:39 2022 +0100 Commit: Hiltjo Posthuma CommitDate: Tue Mar 1 22:45:39 2022 +0100 remove false-positive warning for int comparison as bool Reported by Prathu Baronia , patch

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread NRK
On Tue, Mar 01, 2022 at 01:52:07PM -0600, Dave Blanchard wrote: > I'll see myself out, and let you get back to your daily circlejerk. Please don't do that. It'll be a massive loss if the only civilized person in here; whos also made some loonix distro, is also a mechanic and an astronut and a

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Quentin Rameau
Hi again Dave, > > Let that be a poor lesson for everybody, to you that coming to > > unfamiliar people with a negative attitude usually draws negative > > attitude in response. > > Nothing was wrong with my comment. You just chose to interpret it poorly--for > selfish reasons. Allright, but

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Dave Blanchard
On Tue, 1 Mar 2022 11:15:45 -0800 Jeremy wrote: > I'm sorry Yes, you are sorry. That's obvious. -- Dave Blanchard

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Dave Blanchard
On Tue, 1 Mar 2022 20:30:01 +0100 Quentin Rameau wrote: > Let that be a poor lesson for everybody, to you that coming to > unfamiliar people with a negative attitude usually draws negative > attitude in response. Nothing was wrong with my comment. You just chose to interpret it poorly--for

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread NRK
On Tue, Mar 01, 2022 at 01:21:51PM -0600, Dave Blanchard wrote: > You could have stopped your comment here, and my response would have > been simply 'Ah, I see; thank you.' But now, given the continuation of > your response below, I'll have to response in kind. There was nothing stopping you from

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Dave Blanchard
On Wed, 2 Mar 2022 01:26:28 +0600 NRK wrote: > On Tue, Mar 01, 2022 at 08:54:15AM -0500, Sebastian LaVine wrote: > > Christ, why do you choose to be so rude to someone you've never talked > > to over a simple email? > > Similar question can be asked towards the initial mail. I'm not aware of >

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Dave Blanchard
On Tue, 01 Mar 2022 08:54:15 -0500 "Sebastian LaVine" wrote: > Christ, why do you choose to be so rude to someone you've never talked > to over a simple email? He wants to write comments for a C program. It's > not the end of the world. I personally will be interested in what he > does; he isn't

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Quentin Rameau
Hi Dave, > It's not the language that's the problem, it's the piss-poor attitude. > > At first, I thought his response might have been a fluke. But then after > reading the other extremely rude comments made in response to mine, it seems > this is a group of extremely toxic people who are

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread NRK
On Tue, Mar 01, 2022 at 08:54:15AM -0500, Sebastian LaVine wrote: > Christ, why do you choose to be so rude to someone you've never talked > to over a simple email? Similar question can be asked towards the initial mail. I'm not aware of any civilized culture where going into a community

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Dave Blanchard
On Tue, 1 Mar 2022 11:18:41 +0100 "Roberto E. Vargas Caballero" wrote: > > 'appkey' and 'appcursor' are modes in the vt100, you only have to search in > the > vt100 documentation [1] for application mode and/or numeric mode. You can also > search for the terminfo sequences rmkx and smkx in

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Jeremy
On 03/01/22 12:54PM, Dave Blanchard wrote: > On Tue, 1 Mar 2022 07:49:21 -0800 > Jeremy wrote: > No, I really don't. I just made an offhand comment regarding my initial > impression of the code. I don't *need* to convince you of anything. After > reading your asshole response, I'm not

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Dave Blanchard
On Tue, 1 Mar 2022 14:15:03 +0100 Hiltjo Posthuma wrote: > Hi David, > It makes sense to me to add \033[1;5H. I'm not sure if \033[J is correct, it > seems duplicate with XK_Home and XK_End also. Please test it properly. I'm not sure if it's correct either; I'm not a terminal expert. It seems

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Dave Blanchard
On Tue, 01 Mar 2022 09:13:15 -0500 "Greg Reagle" wrote: > Dave Blanchard, I am going to give you unsolicited advice on how to provide > *constructive* criticism and/or *useful* feedback: Be specific, and give > examples. Please read on for details. What I *did* provide is constructive

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Dave Blanchard
On Tue, 1 Mar 2022 07:49:21 -0800 Jeremy wrote: > On 02/28/22 09:27PM, Dave Blanchard wrote: > > On that note, regrettably it will be necessary for me to fork this project, > > if for no other reason than to properly comment it, so that its > > functionality can be understood and easily

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Dave Blanchard
On Tue, 1 Mar 2022 19:30:11 +0100 Hiltjo Posthuma wrote: > > But clearly you're too retarded to make a decent critisism like that. ;) > > > > Please don't use language like this here. It's not the language that's the problem, it's the piss-poor attitude. At first, I thought his response

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Hiltjo Posthuma
On Tue, Mar 01, 2022 at 07:49:21AM -0800, Jeremy wrote: > On 02/28/22 09:27PM, Dave Blanchard wrote: > > On that note, regrettably it will be necessary for me to fork this project, > > if for no other reason than to properly comment it, so that its > > functionality can be understood and easily

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Jeremy
On 02/28/22 09:27PM, Dave Blanchard wrote: > On that note, regrettably it will be necessary for me to fork this project, > if for no other reason than to properly comment it, so that its functionality > can be understood and easily modified. It's a shame that such a nice little > program is

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Roberto e. Vargas Caballero
Hi, On Tue, Mar 01, 2022 at 08:54:15AM -0500, Sebastian LaVine wrote: > > Christ, why do you choose to be so rude to someone you've never talked > to over a simple email? He wants to write comments for a C program. It's > not the end of the world. I personally will be interested in what he >

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Greg Reagle
Dave Blanchard, I am going to give you unsolicited advice on how to provide *constructive* criticism and/or *useful* feedback: Be specific, and give examples. Please read on for details. On Mon, Feb 28, 2022, at 10:27 PM, Dave Blanchard wrote: > It's a shame > that such a nice little program

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Sebastian LaVine
On Tue Mar 1, 2022 at 5:18 AM EST, Roberto E. Vargas Caballero wrote: > > On that note, regrettably it will be necessary for me to fork this > > project, if for no other reason than to properly comment it, so that > > its functionality can be understood and easily modified. It's a > > shame that

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Hiltjo Posthuma
On Mon, Feb 28, 2022 at 09:27:22PM -0600, Dave Blanchard wrote: > Hello all, > Hi David, > This patch for 'st' causes CTRL+HOME to send the ANSI sequence \033[J and > \033[1;5H , which signals the user program to scroll to the top of the > document, same as in Xterm. > > I have absolutely

Re: [hackers] st][PATCH - proper escape sequence for CTRL+HOME

2022-03-01 Thread Roberto E. Vargas Caballero
Hi, On Mon, Feb 28, 2022 at 09:27:22PM -0600, Dave Blanchard wrote: > > I have absolutely no idea what the 'appkey' and 'appcursor' fields do, as > there are almost no comments anywhere to be found in the source code, and I > haven't yet reverse engineered the code enough to figure out what

[hackers] [libgrapheme] Properly handle cp == NULL in grapheme_decode_utf8() || Laslo Hunhold

2022-03-01 Thread git
commit 1930624b9a9703c3449d2a877640e33c6d71f190 Author: Laslo Hunhold AuthorDate: Tue Mar 1 09:27:12 2022 +0100 Commit: Laslo Hunhold CommitDate: Tue Mar 1 09:27:12 2022 +0100 Properly handle cp == NULL in grapheme_decode_utf8() During refactoring I totally forgot about it.