Re: svn commit: r472115 - /incubator/harmony/enhanced/classlib/trunk/modules/swing/src/main/java/common/javax/swing/text/GapContent.java

2006-11-16 Thread Ilya Okomin
-- -- Ilya Okomin Intel Enterprise Solutions Software Division

Re: [classlib] Really trivial comment about exception messages

2006-11-02 Thread Ilya Okomin
. at blah(blah.java :101) So, unless anyone objects, can we avoid putting fullstops on the end of exception messages. Thanks, Mark. -- -- Ilya Okomin Intel Enterprise Solutions Software Division

Re: [classlib][tests] Junit best practice

2006-10-27 Thread Ilya Okomin
On 10/27/06, Tony Wu [EMAIL PROTECTED] wrote: Hi llya, I think you can try to config CheckStyle to exclude files not opened in the editor. I believe that will make it faster and avoid oom :) It's helped, thanks!! My Eclipse feels much better now;) Regards, Ilya. On 10/27/06, Ilya Okomin

Re: [vote] Graduate Apache Harmony podling from the Incubator

2006-10-24 Thread Ilya Okomin
, at 3:30 PM eastern, + delta for mail outage. Thanks geir -- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin

Re: HARMONY-1752: patch review

2006-10-20 Thread Ilya Okomin
PROTECTED] Sent: Thursday, October 19, 2006 2:05 PM To: harmony-dev@incubator.apache.org Subject: Re: HARMONY-1752: patch review On 10/19/06, Ilya Okomin [EMAIL PROTECTED] wrote: On 10/19/06, Andrew Zhang [EMAIL PROTECTED] wrote: On 10/19/06, Fedotov, Alexei A [EMAIL PROTECTED] wrote: Hello

Re: [drlvm]Debug Error! dialog window occurs when running junit.awtui.TestRunner.

2006-10-20 Thread Ilya Okomin
On 10/19/06, Dmitry Durnev [EMAIL PROTECTED] wrote: I think issue HARMONY-1483 has the necessary patch attached, but not applied yet. Dmitry, thanks a lot! Suggested patch makes TestRunner work! Committers should also take a look at this patch. Regards, Ilya. On 10/19/06, Ilya Okomin

Re: [classlib] Build failure messages

2006-10-20 Thread Ilya Okomin
: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin Intel Middleware Products Division

Re: HARMONY-1752: patch review

2006-10-19 Thread Ilya Okomin
(vm_args.options); } Should we put here assert(!vm_args.options)? With best regards, Alexei Fedotov, Intel Java XML Engineering -- Best regards, Andrew Zhang -- -- Ilya Okomin Intel Middleware Products Division

Re: [classlib][beans] Failed to build classlib

2006-10-19 Thread Ilya Okomin
] -- -- Ilya Okomin Intel Middleware Products Division

[drlvm]Debug Error! dialog window occurs when running junit.awtui.TestRunner.

2006-10-19 Thread Ilya Okomin
anyone know the reason of these errors? [1] http://issues.apache.org/jira/browse/HARMONY-1916 -- -- Ilya Okomin Intel Middleware Products Division

Re: [classlib][awt] An awt bug? (was Re: [application] [feedback] VM crashed when running Poleposition on Harmony)

2006-10-17 Thread Ilya Okomin
Software Division - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Best regards, Andrew Zhang -- -- Ilya Okomin

Re: [drlvm] Using latest linux snapshot[hdk]...

2006-10-11 Thread Ilya Okomin
On 10/11/06, Gregory Shimansky [EMAIL PROTECTED] wrote: On Tuesday 10 October 2006 13:02 Ilya Okomin wrote: On 10/9/06, Geir Magnusson Jr. [EMAIL PROTECTED] wrote: Yeah, I would have been surprised it that worked. Why not just install v 6? I have libstdc++.so.6 on my system

Re: [jira] Updated: (HARMONY-1317) [classlib][internationalization]Internationalization of the rmi module

2006-10-06 Thread Ilya Okomin
Hi committers! Could someone look into the patch with [rmi] internationalization HARMONY-1317? Patch affects many source files and it would be great to apply it ASAP (if it is OK of course:)) to avoid conflicts with another changes in the Harmony svn. Thanks, Ilya. On 10/4/06, Ilya Okomin

Re: [jira] Updated: (HARMONY-1317) [classlib][internationalization]Internationalization of the rmi module

2006-10-06 Thread Ilya Okomin
. Ilya Okomin wrote: Hi committers! Could someone look into the patch with [rmi] internationalization HARMONY-1317? Patch affects many source files and it would be great to apply it ASAP (if it is OK of course:)) to avoid conflicts with another changes in the Harmony svn. Thanks

Re: [jira] Created: (HARMONY-1538) [classlib][awt] Successor of CubicCurve2D throws NPE in contains() if getBounds2D() returns null

2006-09-26 Thread Ilya Okomin
. In this case we can follow RI esealy as you suggested to add null check. For this case I vote for non-bug status. Suggested CubicCurve2DImpl in the test sample is invalid implementation of the CubicCurve class. Thanks, Ilya. 2006/9/26, Ilya Okomin [EMAIL PROTECTED]: I suggested to return false

Re: [classlib][awt] Fonts with negative size.

2006-09-26 Thread Ilya Okomin
RI will return metrics the same as I provided for negative-sized font in this thread. As I wrote earlier, I don't see any sence in negative height and width values for e.g. getStringBounds() (for both Font and FontMetrics classes) or getMaxCharBounds() results. On 9/25/06, Ilya Okomin [EMAIL

Re: [jira] Created: (HARMONY-1538) [classlib][awt] Successor of CubicCurve2D throws NPE in contains() if getBounds2D() returns null

2006-09-26 Thread Ilya Okomin
On 9/26/06, Ilya Okomin [EMAIL PROTECTED] wrote: On 9/26/06, Denis Kishenko [EMAIL PROTECTED] wrote: Ilya, so do you vote for non-bug status? You are right that Shape doesn't follow spec if getBounds2D returns null - it means Shape implementation is invalid. But Harmony should follow RI

Re: [classlib][awt] Fonts with negative size.

2006-09-26 Thread Ilya Okomin
is negative? On 9/25/06, Ilya Okomin [EMAIL PROTECTED] wrote: On 9/25/06, Oleg Khaschansky [EMAIL PROTECTED] wrote: It was evaluated as not a bug. But it is clear from its evaluation that negative-sized fonts are treated as positive sized but rotated around their origin, say

Re: [jira] Created: (HARMONY-1538) [classlib][awt] Successor of CubicCurve2D throws NPE in contains() if getBounds2D() returns null

2006-09-26 Thread Ilya Okomin
. Regards, Ilya. On 9/26/06, Denis Kishenko [EMAIL PROTECTED] wrote: 2006/9/25, Ilya Okomin [EMAIL PROTECTED]: To follow RI I would suggest to add check (if the bounds2D is null) to the contains() method, in this case just to return false. Yep, to follow RI we can check if the bounds2D is null

Re: [classlib][awt] Fonts with negative size.

2006-09-25 Thread Ilya Okomin
/view_bug.do?bug_id=4803825 2006/9/23, Richard Liang [EMAIL PROTECTED]: On 9/22/06, Ilya Okomin [EMAIL PROTECTED] wrote: Hi, all! I was playing with fonts and found that Font with negative size can be created on RI. Unfortunately spec keep silence about fonts with negative

Re: [classlib][awt] Fonts with negative size.

2006-09-25 Thread Ilya Okomin
an evaluation to this one both for the rendering and for the metrics. This means that we want to have them together. For the rendering part, why not just add a transform if the size of the font is negative? On 9/25/06, Ilya Okomin [EMAIL PROTECTED] wrote: On 9/25/06, Oleg Khaschansky [EMAIL PROTECTED

Re: [VOTE] HARMONY-1217 : JNI-style C header file generator (aka 'javah')

2006-09-25 Thread Ilya Okomin
: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin Intel Middleware Products Division

Re: [jira] Created: (HARMONY-1538) [classlib][awt] Successor of CubicCurve2D throws NPE in contains() if getBounds2D() returns null

2006-09-25 Thread Ilya Okomin
://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin Intel Middleware Products Division

[classlib][awt] Fonts with negative size.

2006-09-22 Thread Ilya Okomin
bug or not? Thanks, Ilya. -- -- Ilya Okomin Intel Middleware Products Division

Re: [jira] Created: (HARMONY-1456) [classlib][awt]java.awt.Font.hasUniformLineMetrics() return true on Harmony while RI returns false

2006-09-19 Thread Ilya Okomin
that it is a non-bug difference from RI. Any thoughts on this issue? Regards, Ilya. On 9/13/06, Ilya Okomin (JIRA) [EMAIL PROTECTED] wrote: [classlib][awt]java.awt.Font.hasUniformLineMetrics() return true on Harmony while RI returns false

Re: [jira] Created: (HARMONY-1456) [classlib][awt]java.awt.Font.hasUniformLineMetrics() return true on Harmony while RI returns false

2006-09-19 Thread Ilya Okomin
. (It is only a guess;) Thanks, Ilya. On 9/19/06, Ilya Okomin [EMAIL PROTECTED] wrote: Hi, community! I found for java.awt.Font.hasUniformLineMetrics() RI returns false for all fonts (physical/logical) while Harmony returns true for physical and false for logical. Spec says: Checks whether

Re: [classlib][internationalization]Are log messages and tools usage text to be internationalized?

2006-09-15 Thread Ilya Okomin
be right to leave empty string instead of renamed keys. Thus in the future it will be easy to see which keys are skipped in the enumeration to add new messages with these ids. Regards, Ilya. Thanks, 2006/9/13, Ilya Okomin [EMAIL PROTECTED]: Agree, we should follow the conventions we've reached

Re: [general] svn:eol-style = native (LF vs CRLF)

2006-09-14 Thread Ilya Okomin
it is a good idea to set this property for all .java files in modules at once. Regards, Ilya. I have no idea wyh some of the .java files have the property but others doesnt in the meanwhile. hope it will do some help. On 9/13/06, Ilya Okomin [EMAIL PROTECTED] wrote: On 8/17/06, Tim Ellison

Re: [classlib][luni][internationalization] where to put the messages?

2006-09-14 Thread Ilya Okomin
- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin Intel Middleware Products Division

Re: [general] svn:eol-style = native (LF vs CRLF)

2006-09-14 Thread Ilya Okomin
this a while ago...? geir Tony Wu wrote: +1 to set *svn:eol-style native* to all text files On 9/14/06, Ilya Okomin [EMAIL PROTECTED] wrote: On 9/13/06, Tony Wu [EMAIL PROTECTED] wrote: After going through this thread, I realize there is another possibility to encounter the problem even you

Re: [jira] Created: (HARMONY-1447) [classlib][awt] RI Polygon.add(int,int) throws exception after Polygon(new int[2], new int[2], 0)

2006-09-13 Thread Ilya Okomin
- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin Intel Middleware Products Division

Re: [classlib][internationalization]Are log messages and tools usage text to be internationalized?

2006-09-13 Thread Ilya Okomin
be more detail. Ilya Okomin wrote: The way to use prefixes in the keys names to separate messages of one type from another looks to me pretty convenient Nice idea guys, +1 from me Regards, 2006/9/11, Ilya Okomin [EMAIL PROTECTED]: Thanks all for useful comments! The way

Re: [JIRA]what is non-bug difference issue?

2006-09-13 Thread Ilya Okomin
] - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin Intel Middleware Products Division

Re: [general] svn:eol-style = native (LF vs CRLF)

2006-09-13 Thread Ilya Okomin
PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin Intel Middleware Products Division

Re: [classlib][i18n] Messages code comments

2006-09-11 Thread Ilya Okomin
located? Take a look at the HARMONY-1041issue, all sources for the i18n classes generator are available there. If you want to improve Messages class code - you just need to modify Messages template file. Regards, Ilya. -Nathan -- -- Ilya Okomin Intel Middleware Products Division

[classlib][internationalization]Are log messages and tools usage text to be internationalized?

2006-09-08 Thread Ilya Okomin
with the list of all messages will be too huge to find appropriate messages for new classes developed later. Any thoughts? -- -- Ilya Okomin Intel Middleware Products Division

Re: [classlib] internationalization and new patches

2006-09-06 Thread Ilya Okomin
On 9/6/06, Paulex Yang [EMAIL PROTECTED] wrote: Ilya Okomin wrote: When I dealt with nio_char module I found that some messages were already marked with non-nls tag. (e.g. java.nio.charset.CharsetDecoder) These messages aren't described in the spec. Is there any reason to left them

Re: [jira] Updated: (HARMONY-1334) [classlib][internationalization]Internationalization of the sound module

2006-09-05 Thread Ilya Okomin
implemented); +// sound.00=not yet implemented +throw new Error(Messages.getString(sound.00)); //$NON-NLS-1$ Thanks, Mikhail 2006/9/4, Ilya Okomin (JIRA) [EMAIL PROTECTED]: [ http://issues.apache.org/jira/browse/HARMONY-1334?page=all ] Ilya Okomin updated HARMONY-1334

Re: [jira] Updated: (HARMONY-1334) [classlib][internationalization]Internationalization of the sound module

2006-09-05 Thread Ilya Okomin
Ooops...I've seen your comments that you've already removed these changes in jira a bit later. I'll take a look at the applied patch results today. Regards, Ilya. On 9/5/06, Ilya Okomin [EMAIL PROTECTED] wrote: Yep, you are right, we can left such messages without internationalization. I

Re: [classlib] internationalization and new patches

2006-09-04 Thread Ilya Okomin
with luni module. Regards, Ilya. Thanks, Mikhail - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin

Re: [classlib]strings externalization

2006-08-30 Thread Ilya Okomin
/incubator-harmony-dev/200607.mbox/[EMAIL PROTECTED] [2] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200607.mbox/[EMAIL PROTECTED] On 8/30/06, Jimmy, Jing Lv [EMAIL PROTECTED] wrote: Ilya Okomin wrote: Tim, great news for me. Everything looks fine with the patch you've applied

Re: [vote] HARMONY-1225 : Assorted fixes and enhancements for AWT and Swing

2006-08-28 Thread Ilya Okomin
Intel Middleware Products Division - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin Intel Middleware

Re: [vm] ArgoUML application crashes IBM VME

2006-08-23 Thread Ilya Okomin
PROTECTED] wrote: ArgoUML application (http://argouml.tigris.org) crashes IBM VME. I've created new issue (H-1257) where the logs are. Could anybody please look at this problem and fix it? Thanks, Vladimir. -- -- Ilya Okomin Intel Middleware Products Division

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-15 Thread Ilya Okomin
have more patches (or free time) for java.beans you are highly welcome. I have already tired from working on this package alone. :) Regards, 2006/8/14, Ilya Okomin [EMAIL PROTECTED]: On 8/14/06, Alexei Zakharov [EMAIL PROTECTED] wrote: Hi Ilya, FYI there is the existing class

Re: [classlib]strings externalization

2006-08-15 Thread Ilya Okomin
now. We have no need to look in that file in general. If you do choose to combine them then I would expect the resulting header to be (c) 1998, 2006. - Minor typo Better make changes in the teamplate file. - template. Ilya Okomin wrote: I would suggest to split this task into a set of jira sub

Re: [jira] Created: (HARMONY-1113) [classlib][beans]Harmony does not throw IllegalArgumentException for java.beans.PropertyEditorSupport.setAsText() while RI does.

2006-08-14 Thread Ilya Okomin
test code This also might be useful [2] Thanks, Mikhail [1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200603.mbox/[EMAIL PROTECTED] [2] http://incubator.apache.org/harmony/subcomponents/classlibrary/agreements.html 2006/8/9, Ilya Okomin (JIRA) [EMAIL PROTECTED]: [classlib

Re: [classlib][luni] Our locale data is incomplete, and Locale(, CD).getDisplayCountry() return different string compared with ISO3166-1

2006-08-10 Thread Ilya Okomin
] For additional commands, e-mail: [EMAIL PROTECTED] -- Spark Shen China Software Development Lab, IBM -- -- Ilya Okomin Intel Middleware Products Division

Re: [classlib]strings externalization

2006-08-10 Thread Ilya Okomin
On 8/10/06, Tim Ellison [EMAIL PROTECTED] wrote: Ilya Okomin wrote: Hi to all! Today I've started the next step of internationalization - to externalize messages using Eclipse externalization tool. Right away I was confronted with some questions to discuss: First of all, what should we

Re: [classlib][luni] Strange serialized form of java.util.TreeMap (re JIRA harmony-1066)

2006-08-07 Thread Ilya Okomin
://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin Intel Middleware Products Division

Re: [classlib]strings externalization

2006-08-03 Thread Ilya Okomin
to make rule to do this routinely after contribution is applied (or even before, people who are going to make contribution should be acquainted with internationalization in Harmony to use it in their development process). Waiting for comments and suggestions! Thanks, Ilya. On 8/2/06, Ilya Okomin

Re: [classlib]strings externalization

2006-08-02 Thread Ilya Okomin
On 7/27/06, Tim Ellison [EMAIL PROTECTED] wrote: Ilya Okomin wrote: I share your point of view about Exceptions without description, it isn't user friendly. But I think it will be another sort of 'manual' scan :) There is a need to waste time to analyze surrounding code to provide

Re: [classlib]strings externalization

2006-08-02 Thread Ilya Okomin
MsgClassGenerator.class.getClassLoader().getResourceAsStream(...). Have you tried this? Suggested sample works, thanks for advice Alexei!! One more issue is resolved :) Thanks, Ilya. Regards, 2006/8/2, Ilya Okomin [EMAIL PROTECTED]: On 7/27/06, Tim Ellison [EMAIL PROTECTED] wrote: Ilya Okomin wrote: I share your point

Re: [classlib]strings externalization

2006-07-31 Thread Ilya Okomin
) is not the best choice. Thus I've stopped on the pure Java implementation. Thanks for your comment, Ilya. Regards, 2006/7/28, Ilya Okomin [EMAIL PROTECTED]: On 7/27/06, Tim Ellison [EMAIL PROTECTED] wrote: Ilya Okomin wrote: I share your point of view about Exceptions without description

Re: [classlib]strings externalization

2006-07-28 Thread Ilya Okomin
On 7/27/06, Tim Ellison [EMAIL PROTECTED] wrote: Ilya Okomin wrote: I share your point of view about Exceptions without description, it isn't user friendly. But I think it will be another sort of 'manual' scan :) There is a need to waste time to analyze surrounding code to provide

Re: [optimization] Algorithmic tricks

2006-07-27 Thread Ilya Okomin
. -- Denis M. Kishenko Intel Middleware Products Division -- -- Ilya Okomin Intel Middleware Products Division

Re: [optimization] Algorithmic tricks

2006-07-27 Thread Ilya Okomin
On 7/27/06, Anton Luht [EMAIL PROTECTED] wrote: On 7/27/06, Ilya Okomin [EMAIL PROTECTED] wrote: Sounds great to have a page with algorithms tricks used in Harmony project! Maybe it's worth to put information about algorithms to Wiki : http://wiki.apache.org/harmony/ ? +1 -- Regards

Re: [classlib]strings externalization

2006-07-27 Thread Ilya Okomin
On 7/27/06, Tim Ellison [EMAIL PROTECTED] wrote: Ilya Okomin wrote: Hi falks! I would like to open discussion about the way to extract messages for internationalization from the source files (as the continuation of the [classlib]internationalization thread [1]). The task is to scan

Re: [classlib] internationalization

2006-07-24 Thread Ilya Okomin
PROTECTED]) IBM Java technology centre, UK. - Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- -- Ilya Okomin Intel

Re: [classlib] internationalization

2006-07-12 Thread Ilya Okomin
On 7/11/06, Geir Magnusson Jr [EMAIL PROTECTED] wrote: Tim Ellison wrote: Ilya Okomin wrote: I'd like to be a volunteer for that. I just started working in this area (for SQL), maybe that is what prompted you...g IMHO it's reasonable to use framework presented in luni module with some

Re: [classlib] internationalization

2006-07-12 Thread Ilya Okomin
often I would vote for the first method, it is simple and clear. Thanks, Ilya. Hmm... It looks like I've found an argument for using traditional method in class library :) SY, Alexey 2006/7/11, Geir Magnusson Jr [EMAIL PROTECTED]: Tim Ellison wrote: Ilya Okomin wrote: I'd like

Re: [classlib] internationalization

2006-07-10 Thread Ilya Okomin
: org.apache.harmony.security.internal.MsgUtils.msg.getString(security.1); And at last, place to keep resources with external messages I suppose to be o.a.h.module.internal. If all these thoughts sounds reasonable, I'd like to implement framework mentioned above and send you a patch. -- Thanks, Ilya Okomin Intel Middleware Products

Re: [classlib] internationalization

2006-07-10 Thread Ilya Okomin
in the similar direction. -- Alexey Varlamov 2006/7/10, Ilya Okomin [EMAIL PROTECTED]: Tim Ellison wrote: Mikhail Loenko wrote: 2006/5/25, Tim Ellison [EMAIL PROTECTED] : Mikhail Loenko wrote: We also agreed to put only internationalized messages and to have a single