Re: [classlib] trying new framework for testing serialization

2006-07-07 Thread Anton Luht
Stepan, I think that there's no need in SerializableAssert interface - just put assertDeserialized(Serializable, Serializable) method to SerializationTest class with default implementation based on current code from defineComparator (if there's equals(), use it, if it's instance of Throwable,

Re: [classlib] trying new framework for testing serialization

2006-07-07 Thread Stepan Mishura
Anton, You suggestion works only if a test extends SerializationTest but we agree avoid this (i.e. a test should invoke only static utility methods of SerializationTest) Thanks, Stepan. On 7/7/06, Anton Luht wrote: Stepan, I think that there's no need in SerializableAssert interface - just

RE: [classlib] trying new framework for testing serialization

2006-07-07 Thread Nathan Beyer
-Original Message- From: Stepan Mishura [mailto:[EMAIL PROTECTED] * When loading the resource, the name is assembled using File.separatorChar as the separator, but you should just be using the character / since that's the normative class path separator. I didn't catch what

Re: [classlib] trying new framework for testing serialization

2006-07-06 Thread Stepan Mishura
-Original Message- From: Stepan Mishura [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 05, 2006 3:08 AM To: harmony-dev@incubator.apache.org Subject: Re: [classlib] trying new framework for testing serialization Hi Andrew, On 7/3/06, Andrew Zhang wrote: Hi Stepan, I tried serialization

Re: [classlib] trying new framework for testing serialization

2006-07-05 Thread Andrew Zhang
Hello Stepan, Thanks for your explanation. It seems I have to wait until NIO test package layout is complete. The test package structure is not the same as SerializationTest framework expects. I'll use merged serialization test framework then. :) btw: Paulex said he'd like to do it in the

RE: [classlib] trying new framework for testing serialization

2006-07-05 Thread Nathan Beyer
for normal test classes. -Nathan -Original Message- From: Stepan Mishura [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 05, 2006 3:08 AM To: harmony-dev@incubator.apache.org Subject: Re: [classlib] trying new framework for testing serialization Hi Andrew, On 7/3/06, Andrew Zhang

Re: [classlib] trying new framework for testing serialization

2006-07-03 Thread Andrew Zhang
Hi Stepan, I tried serialization test framework, and found it's really easy to use. :) Here I have a small question: why TestCase is designed as first parameter? If I understand correctly, it's used to parse exception name. So is it the same if we simply pass the String or Class of the object

[classlib] trying new framework for testing serialization (was:Merging frameworks for testing serialization - first step)

2006-06-30 Thread Jimmy, Jing Lv
Hi Stepan: Seems the new framework for serialization has added to Harmony, I'm trying it and find it interesting. However I have a few questions: 1. It is strange that SerializationTest is an abstract class extends junit.framework.testcase, in this case I can either (a) extends

Re: [classlib] trying new framework for testing serialization

2006-06-30 Thread Jimmy, Jing Lv
Jimmy, Jing Lv wrote: Hi Stepan: Seems the new framework for serialization has added to Harmony, I'm trying it and find it interesting. However I have a few questions: 1. It is strange that SerializationTest is an abstract class extends junit.framework.testcase, in this case I can

Re: [classlib] trying new framework for testing serialization (was:Merging frameworks for testing serialization - first step)

2006-06-30 Thread Stepan Mishura
Hi Jimmy, On 6/30/06, Jimmy, Jing Lv wrote: Hi Stepan: Seems the new framework for serialization has added to Harmony, I'm trying it and find it interesting. However I have a few questions: 1. It is strange that SerializationTest is an abstract class extends junit.framework.testcase, in

Re: [classlib] trying new framework for testing serialization

2006-06-30 Thread Jimmy, Jing Lv
Stepan Mishura wrote: Hi Jimmy, On 6/30/06, Jimmy, Jing Lv wrote: Hi Stepan: Seems the new framework for serialization has added to Harmony, I'm trying it and find it interesting. However I have a few questions: 1. It is strange that SerializationTest is an abstract class extends

Re: [classlib] trying new framework for testing serialization

2006-06-30 Thread Stepan Mishura
On 6/30/06, Jimmy, Jing Lv wrote: Stepan Mishura wrote: Hi Jimmy, SNIP 3. The test needs ser-files, so it may be necessary to add a method to create this file easily just like the old framework. I find a protected method produceGoldenFiles(), is that used for it (why protected?)? This may