[PHP-DEV] Patch inclusions

2012-01-24 Thread Jason Gerfen
I just have a general question regarding patch inclusions. When a patch is submitted is there a formal review and testing of the patch prior to inclusion? From what I have been following from this list is that the process is patches get applied to new/existing bug/feature requests, bug fixes are pr

[PHP-DEV] Re: can I commit fix for Bug #60825?

2012-01-24 Thread Dmitry Stogov
Hi Laruence, I'll try to demonstrate the problem I tried to describe with a script. The following script is still fails on trunk. So your fix is not enough. It make no sense to play with refcounts of zvals allocated on stack. Probably, the temporary zval needs to be allocated on heap. Tahnks.

[PHP-DEV] Re: can I commit fix for Bug #60825?

2012-01-24 Thread Laruence
Hi Dmitry, ah, I see, thanks very much. in this case, the 5.3 branch should failed too since it also use a stack zval. I will make a improved fix soon.. :) thanks. On Tue, Jan 24, 2012 at 8:19 PM, Dmitry Stogov wrote: > Hi Laruence, > > I'll try to demonstrate the problem I tried to d

Re: [PHP-DEV] SQLite3 class missing createCollation()

2012-01-24 Thread b dewar
On Mon, Jan 23, 2012 at 6:44 PM, Damien Tournoud wrote: > Also see https://bugs.php.net/bug.php?id=55226 > > Same idea, but for the PDO_sqlite implementation. > > Damien > Thanks. I submitted my patch, and commented on both, referring each to the other. -- PHP Internals - PHP Runtime Developme

[PHP-DEV] Re: [PHP-WEBMASTER] [git] web/master.git branch master updated. 8181453

2012-01-24 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/24/2012 10:21 AM, Derick Rethans wrote: > Hi, > > could something be done about the commit spam subjects? It was > mightly useful to have the paths and the commit messages in there. The problem here is that you can push multiple changesets at o

Re: [PHP-DEV] Patch inclusions

2012-01-24 Thread Christopher Jones
On 01/24/2012 03:36 AM, Jason Gerfen wrote: I just have a general question regarding patch inclusions. When a patch is submitted is there a formal review and testing of the patch prior to inclusion? From what I have been following from this list is that the process is patches get applied to new

Re: [PHP-DEV] Patch inclusions

2012-01-24 Thread Jason Gerfen
On Tue, Jan 24, 2012 at 1:48 PM, Christopher Jones wrote: > > > On 01/24/2012 03:36 AM, Jason Gerfen wrote: >> >> I just have a general question regarding patch inclusions. When a >> patch is submitted is there a formal review and testing of the patch >> prior to inclusion? From what I have been f

[PHP-DEV] Change bug tracker "bogus" to "not-bug"?

2012-01-24 Thread Justin Martin
Hello, With some frequency, I find bugs which are not "bogus", so much as they are reported based on a misunderstanding. Usually this happens for documentation problems, where someone has misunderstood what the documentation says, or hasn't read the documentation thoroughly enough. I'd like

Re: [PHP-DEV] Change bug tracker "bogus" to "not-bug"?

2012-01-24 Thread Christopher Jones
On 01/24/2012 03:11 PM, Justin Martin wrote: Hello, With some frequency, I find bugs which are not "bogus", so much as they are reported based on a misunderstanding. Usually this happens for documentation problems, where someone has misunderstood what the documentation says, or hasn't read t

Re: [PHP-DEV] Change bug tracker "bogus" to "not-bug"?

2012-01-24 Thread Paul Dragoonis
On Tue, Jan 24, 2012 at 11:12 PM, Christopher Jones wrote: > > > On 01/24/2012 03:11 PM, Justin Martin wrote: >> >> Hello, >> >> With some frequency, I find bugs which are not "bogus", so much as they >> are reported based on a misunderstanding. Usually this happens for >> documentation problems,

Re: [PHP-DEV] Change bug tracker "bogus" to "not-bug"?

2012-01-24 Thread Matthew Fonda
On Tue, Jan 24, 2012 at 3:16 PM, Paul Dragoonis wrote: > On Tue, Jan 24, 2012 at 11:12 PM, Christopher Jones > wrote: >> >> >> On 01/24/2012 03:11 PM, Justin Martin wrote: >>> >>> Hello, >>> >>> With some frequency, I find bugs which are not "bogus", so much as they >>> are reported based on a mi

Re: [PHP-DEV] Change bug tracker "bogus" to "not-bug"?

2012-01-24 Thread Charlie Somerville
It'd also be nice to see a more receptive approach to bug reports. It's concerning that so many legitimate bug reports get labelled as bogus for whatever reason. On Wednesday, 25 January 2012 at 10:20 AM, Matthew Fonda wrote: > On Tue, Jan 24, 2012 at 3:16 PM, Paul Dragoonis (mailto:dragoo...

Re: [PHP-DEV] Change bug tracker "bogus" to "not-bug"?

2012-01-24 Thread Christopher Jones
On 01/24/2012 03:21 PM, Charlie Somerville wrote: It'd also be nice to see a more receptive approach to bug reports. It's concerning that so many legitimate bug reports get labelled as bogus for whatever reason. To be 100% clear, this is just a proposed wording change. The bugs you mention w

Re: [PHP-DEV] Change bug tracker "bogus" to "not-bug"?

2012-01-24 Thread Ferenc Kovacs
On Wed, Jan 25, 2012 at 12:11 AM, Justin Martin wrote: > Hello, > > With some frequency, I find bugs which are not "bogus", so much as they > are reported based on a misunderstanding. Usually this happens for > documentation problems, where someone has misunderstood what the > documentation says,

Re: [PHP-DEV] Change bug tracker "bogus" to "not-bug"?

2012-01-24 Thread Rasmus Lerdorf
On Jan 24, 2012, at 3:47 PM, Ferenc Kovacs wrote: > On Wed, Jan 25, 2012 at 12:11 AM, Justin Martin wrote: > >> Hello, >> >> With some frequency, I find bugs which are not "bogus", so much as they >> are reported based on a misunderstanding. Usually this happens for >> documentation problems,