Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-21 Thread Niels Dossche
Hi Stephen On 20/09/2023 12:02, Stephen Reay wrote: > > >> On 20 Sep 2023, at 03:03, Niels Dossche wrote: >> >> Hi Stephen >> >> On 19/09/2023 09:58, Stephen Reay wrote: >>> >>> >>>> On 19 Sep 2023, at 14:30, Tim Düsterhus

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-19 Thread Niels Dossche
Hi Stephen On 19/09/2023 09:58, Stephen Reay wrote: > > >> On 19 Sep 2023, at 14:30, Tim Düsterhus wrote: >> >> Hi >> >> On 9/19/23 08:35, Stephen Reay wrote: >>> Regarding the private constructor: I understand the issue with the *old* >>> class being confusing - but your new class doesn't

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-19 Thread Niels Dossche
Hi Stephen On 19/09/2023 08:35, Stephen Reay wrote: > >> On 19 Sep 2023, at 01:00, Niels Dossche >> >> Cheers >> Niels >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: https://www.php.net/unsub

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-18 Thread Niels Dossche
Hi Stephen On 18/09/2023 08:46, Stephen Reay wrote: > > >> On 17 Sep 2023, at 18:28, Niels Dossche wrote: >> >> Hi Alexandru >> >> On 9/17/23 11:59, Alexandru Pătrănescu wrote: >>> On Sat, Sep 16, 2023, 02:17 Niels Dossche wrote: >>>

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-17 Thread Niels Dossche
Hi Alexandru On 9/17/23 11:59, Alexandru Pătrănescu wrote: > On Sat, Sep 16, 2023, 02:17 Niels Dossche wrote: > >> >> We'll add a common abstract base class DOM\Document (name taken from the >> DOM spec & Javascript world). >> DOM\Document contains the prop

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-16 Thread Niels Dossche
Hi Larry On 9/17/23 01:04, Larry Garfield wrote: > On Fri, Sep 15, 2023, at 6:17 PM, Niels Dossche wrote: >> On 9/2/23 21:41, Niels Dossche wrote: >>> Hello internals >>> >>> I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization &

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-15 Thread Niels Dossche
On 9/2/23 21:41, Niels Dossche wrote: > Hello internals > > I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization > support". > https://wiki.php.net/rfc/domdocument_html5_parser > > Kind regards > Niels Hi internals I'd like to announc

[PHP-DEV] Bugfix backport for bundled pcre2lib

2023-09-14 Thread Niels Dossche
Hi internals I currently have a PR open to fix bug https://github.com/php/php-src/issues/11956. PR link: https://github.com/php/php-src/pull/12108 To give some context: OP's code worked fine in PHP 8.0 but not in 8.1. That's because pcre2lib got updated in 8.1 and brought a JIT regression with

[PHP-DEV] Proposal: $options argument for SimpleXMLElement::asXML

2023-09-09 Thread Niels Dossche
Hi internals I came across https://bugs.php.net/bug.php?id=67387. Passing the option in via the constructor doesn't work because the constructor only allows parser options. We can implement support for options (such as LIBXML_NOXMLDECL, LIBXML_SAVE_NOEMPTYTAG) by adding an (optional) argument

Re: [PHP-DEV] RFC: Increasing the default BCrypt cost

2023-09-07 Thread Niels Dossche
Hi Tim On 07/09/2023 19:26, Tim Düsterhus wrote: > Hi > > in response to the recent "PASSWORD_DEFAULT value" thread [1], I've created > an RFC to discuss an increase of the default BCrypt costs for > `password_hash()` from the current value of 10. > > https://wiki.php.net/rfc/bcrypt_cost_2023

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-06 Thread Niels Dossche
Hi Dennis On 06/09/2023 22:02, Dennis Snell wrote: > > >> On Sep 4, 2023, at 1:15 PM, Niels Dossche wrote: >> >> On 04/09/2023 21:54, Dennis Snell wrote: >>> Thanks for the proposal Niels, >>> >>> I’ve dealt with my own grief working throug

Re: [PHP-DEV] Breakages with rc1

2023-09-05 Thread Niels Dossche
Hi Hanz On 05/09/2023 11:39, Hanz wrote: > Hello, > > Ran into a couple of issues with RC1 that I haven't seen online. > > With --with-pear: The --with-pear option is deprecated > > With --enable-pear: configure: WARNING: unrecognized options: --enable-pear > > I'm using --disable-all as the

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-05 Thread Niels Dossche
Hi Ben On 05/09/2023 03:31, Ben Ramsey wrote: > On 9/2/23 14:41, Niels Dossche wrote: >> I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization >> support". >> https://wiki.php.net/rfc/domdocument_html5_parser > > > Thanks, Niels. Thi

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-04 Thread Niels Dossche
in an opt-in manner. This would help with security & sanitization problems (HTML5 should help with the encoding). > > Warmly, > Dennis Snell Kind regards Niels > >> On Sep 2, 2023, at 12:41 PM, Niels Dossche > <mailto:dossche.ni...@gmail.com>> wrote: >

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-04 Thread Niels Dossche
Hey Christian Thank you for going through my proposal. On 04/09/2023 09:23, naitsi...@e.mail.de wrote: > Am 02-Sep-2023 21:41:50 +0200 schrieb dossche.ni...@gmail.com: >> Hello internals >> >> I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization >> support". >>

Re: [PHP-DEV] [RFC] [Discussion] Add 4 new rounding modes to round() function

2023-09-02 Thread Niels Dossche
Hey Jorg Thanks for your RFC. On 9/2/23 21:33, Jorg Sowa wrote: > Hello everyone, > > I would like to start the RFC process about adding 4 new rounding modes to > the round() function. > > As the topic was previously discussed and the change is quite small, I > would like to start the voting

[PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-02 Thread Niels Dossche
Hello internals I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization support". https://wiki.php.net/rfc/domdocument_html5_parser Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] Casing of acronyms in class and method names

2023-08-31 Thread Niels Dossche
Hi Tim On 30/08/2023 13:43, Tim Düsterhus wrote: > Hi > > after suggesting the use of ucfirst(strtolower(...)) casing for acronyms > within a classname of a draft RFC, I was made aware of previous class naming > RFC (June 2017) that required the use of PascalCase for class names, with the >

Re: [PHP-DEV] Re: Introducing 2 new modes to round function

2023-08-30 Thread Niels Dossche
On 8/31/23 01:16, Jorg Sowa wrote: > Hello everyone, > As I am not sure what I should next I decided to follow the formal way and > I created the RFC for the change. I will start voting soon. Please let me > know if you have any suggestions. > > RFC under discussion: >

Re: [PHP-DEV] SimpleXML and JSON

2023-08-15 Thread Niels Dossche
On 14/08/2023 23:56, Rowan Tommins wrote: > On 14 August 2023 13:40:40 BST, Niels Dossche wrote: >>And you load it into simpleXML, the result of calling >>json_encode($the_simplexml_object) > > My usual reaction to this is "why would you take an object designed for &

[PHP-DEV] SimpleXML and JSON

2023-08-14 Thread Niels Dossche
Hi internals! While browsing through bugsnet I encountered this SimpleXML issue with 252 votes: https://bugs.php.net/bug.php?id=54632 TLDR: when you have a XML document (modified a bit from the example in the bugtracker): foobar And you load it into simpleXML, the result of calling

Re: [PHP-DEV] Updating the RFC list page

2023-08-07 Thread Niels Dossche
On 06/08/2023 14:58, Juliette Reinders Folmer wrote: > On 6-8-2023 13:13, Juliette Reinders Folmer wrote: >> RFC authors, >> >> I just noticed that the PHP 8.3 "PDO driver specific sub-classes" RFC is >> still listed as "in voting". The "Deprecate functions with overloaded >> signatures" RFC is

Re: [PHP-DEV] Re: [RFC] Migrating to GitHub issues

2023-06-24 Thread Niels Dossche
On 6/24/23 21:39, Nikita Popov wrote: > On Fri, Dec 30, 2022, at 22:39, Christoph M. Becker wrote: >> On 30.12.2022 at 22:12, Nikita Popov wrote: >> >>> On Thu, Nov 10, 2022, at 14:29, Christoph M. Becker wrote: >>> On 09.11.2022 at 23:27, Nikita Popov wrote: > It looks like GitHub

[PHP-DEV] Re: [RFC] [VOTE] mb_str_pad

2023-06-19 Thread Niels Dossche
On 05/06/2023 19:59, Niels Dossche wrote: > Hello internals > > I'm opening the vote now on my proposal to include mb_str_pad() into PHP 8.3. > RFC link: https://wiki.php.net/rfc/mb_str_pad > > The vote will last until 2023-06-19 20:00 GMT+2. > > Kind regards > Niel

Re: [PHP-DEV] [RFC] [VOTE] mb_str_pad

2023-06-06 Thread Niels Dossche
Hi Christian On 06/06/2023 09:12, Christian Schneider wrote: > Am 05.06.2023 um 19:59 schrieb Niels Dossche : >> I'm opening the vote now on my proposal to include mb_str_pad() into PHP 8.3. >> RFC link: https://wiki.php.net/rfc/mb_str_pad > > I voted "No&

[PHP-DEV] [RFC] [VOTE] mb_str_pad

2023-06-05 Thread Niels Dossche
Hello internals I'm opening the vote now on my proposal to include mb_str_pad() into PHP 8.3. RFC link: https://wiki.php.net/rfc/mb_str_pad The vote will last until 2023-06-19 20:00 GMT+2. Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

[PHP-DEV] Re: RFC [Discussion]: mb_str_pad

2023-06-04 Thread Niels Dossche
Hi internals I haven't seen more discussion for some time now. I plan on starting the vote tomorrow evening 20:00 GMT+2, and to end it on June 19 20:00 GMT+2. Any final comments should be raised now. Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] Deprecation of the formats DATE_ISO8601 and DATE_RFC7231

2023-06-02 Thread Niels Dossche
On 6/3/23 00:28, Jorg Sowa wrote: > I would write RFC anyway to check the reception, but I need Karma to do it. > Could I ask someone for it? > You'll need to register on the wiki, and send an email to internals in which you say your wiki name. Kind regards Niels -- PHP Internals - PHP

Re: [PHP-DEV] RFC [Discussion]: Marking overridden methods (#[\Override])

2023-06-02 Thread Niels Dossche
Hi Tim On 5/11/23 18:37, Tim Düsterhus wrote: > Hi > > I'm now opening discussion for the RFC "Marking overridden methods > (#[\Override])": > > > > RFC: Marking overridden methods (#[\Override]) > https://wiki.php.net/rfc/marking_overriden_methods > > Proof of concept implementation is

[PHP-DEV] mb_ucfirst and mb_lcfirst

2023-05-27 Thread Niels Dossche
Hey internals I recently saw a comment on Reddit about the lack of a multibyte version of ucfirst and lcfirst. I was surprised to see this is indeed the case. I also checked the modes of mb_convert_case: the closest supported one is title case, but there's no mode for only handling the first

Re: [PHP-DEV] RFC [Discussion]: mb_str_pad

2023-05-22 Thread Niels Dossche
Hi On 5/22/23 00:08, Jorg Sowa wrote: > Hello, > As this is a new function do you consider any namespace for it? Based on > passed RFC[1] allowing for namespaces in bundled extensions it would be > nice to introduce new functions with namespace. Maybe the namespace could > be voted in the RFC

Re: [PHP-DEV] RFC [Discussion]: mb_str_pad

2023-05-20 Thread Niels Dossche
Hi Rowan On 5/20/23 17:13, Rowan Tommins wrote: > On 20 May 2023 13:53:20 BST, Niels Dossche wrote: >> RFC: https://wiki.php.net/rfc/mb_str_pad > > Hi Niels, > > This seems like a reasonable addition. My only hesitation is that it will > share with other mbstrin

[PHP-DEV] RFC [Discussion]: mb_str_pad

2023-05-20 Thread Niels Dossche
Hello internals I'm opening the discussion for my RFC to implement mb_str_pad. RFC: https://wiki.php.net/rfc/mb_str_pad Implementation pull request: https://github.com/php/php-src/pull/11284 Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] [RFC] [Discussion] nameof

2023-05-13 Thread Niels Dossche
On 13/05/2023 09:27, Robert Landers wrote: > Hello Internals, > > It is with much trepidation and excitement that I'd like to announce > the `nameof` RFC (https://wiki.php.net/rfc/nameof). It has changed > quite a bit in the last couple of days, so if you haven't seen the > latest draft, please

Re: [PHP-DEV] Introduction - SuitespaceRnD

2023-04-23 Thread Niels Dossche
Hi On 4/19/23 17:11, Garet Claborn wrote: > Hello PHP Internals, > > I am Garet Claborn, CTO for Suitespace Inc > , leading > up our R team. Just registered and my PHP Wiki username is: > *suitespacernd* > > We use PHP extensively in our projects. Specifically I

[PHP-DEV] Re: Allowing $a = foo($a) to operate in-place (was Re: [PHP-DEV] Array spread append)

2023-04-10 Thread Niels Dossche
Hi On 10/04/2023 22:11, Tim Düsterhus wrote: > Hi > > On 4/10/23 21:50, Niels Dossche wrote: >>> The suggested optimization of "the input is overwritten with the output" >>> would then also allow to avoid introducing reference parameters just for >>

Re: [PHP-DEV] Array spread append

2023-04-10 Thread Niels Dossche
Hey Tim On 10/04/2023 14:45, Tim Düsterhus wrote: > Hi > > On 4/8/23 22:17, Niels Dossche wrote: >> I think this could be made more generic, and be cleaned up. >> But I don't know if something like this is desired in PHP. > > Yes, please. I believe that “performanc

Re: [PHP-DEV] Array spread append

2023-04-08 Thread Niels Dossche
Hi On 4/6/23 00:12, Vorisek, Michael wrote: > Hello, > > I would like to open a discussion for > https://github.com/php/php-src/issues/10791 . >

Re: [PHP-DEV] [RFC] Define proper semantics for range() function

2023-03-29 Thread Niels Dossche
Hi On 28/03/2023 14:42, G. P. B. wrote: > On Tue, 28 Mar 2023 at 08:19, Christian Schneider > wrote: > >> Am 28.03.2023 um 00:36 schrieb G. P. B. : >>> I therefore propose the "Define proper semantics for range() function" >> RFC >>> to address the unintuitive behaviour that sees no usage

[PHP-DEV] VCS Account Request: nielsdos

2023-03-03 Thread Niels Dossche
Mainly the following two things: - Merging (my) pull requests, after they have been reviewed and approved. - Closing the linked issues to the pull requests which have been merged. Perhaps in the future, when I get more familiar, also approve or request changes for other pull requests in areas I

Re: [PHP-DEV] PHP code refactoring (was: include cleanup)

2023-03-01 Thread Niels Dossche
On 3/1/23 08:42, Dmitry Stogov wrote: > On Wed, Mar 1, 2023 at 8:37 AM Max Kellermann wrote: > >> On 2023/02/28 23:33, Max Kellermann wrote: Include cleanups RFC was rejected. No refactoring RFC was presented. A lot of changes that affect all core contributors are committed into

Re: [PHP-DEV] What's the purpose of zend_result?

2023-02-19 Thread Niels Dossche
On 2/19/23 11:32, Max Kellermann wrote: > On 2023/02/19 09:45, Nikita Popov wrote: >> I expect that there are two main reasons for that: >> - There are probably some places that return a (non-negative) value or >> FAILURE. >> - There are probably some places that check for success/failure

Re: [PHP-DEV] RFC karma request

2023-02-12 Thread Niels Dossche
ed that not every place where PHP is provided for hosting has this functionality available. > >> Ended up with a >> $output = fopen('php://output', 'wb'); + stream_copy_to_stream() >> hack because of fpassthru's shortcomings (Thanks to cmb for that hack, by >> the way) >> >

Re: [PHP-DEV] RFC karma request

2023-02-12 Thread Niels Dossche
t; $output = fopen('php://output', 'wb'); + stream_copy_to_stream() > hack because of fpassthru's shortcomings (Thanks to cmb for that hack, by > the way) > > > On Sat, Feb 11, 2023, 15:26 Niels Dossche wrote: > >> Dear internals >> >> >> I would like to

[PHP-DEV] RFC karma request

2023-02-11 Thread Niels Dossche
Dear internals I would like to gain RFC karma for creating and proposing an RFC: "Implement GH-9673: $length argument for fpassthru". Account name: nielsdos Thanks in advance Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

[PHP-DEV] Proposal to add a $length parameter to fpassthru and friends

2023-01-31 Thread Niels Dossche
Hey everyone! Recently I came across a feature request for PHP on GitHub issues: https://github.com/php/php-src/issues/9673. In short, this user would like to have an additional *optional* `?int $length = null` parameter to the fpassthru function. Currently the fpassthru function will output

<    1   2