Re: [PHP-DEV] Disabling External Entities in libxml By Default

2015-07-30 Thread Rob Richards
On 7/29/15 6:01 PM, Stanislav Malyshev wrote: Hi! Currently, PHP by default is vulnerable to XXE attacks: https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Processing To bypass this, you need to turn off external entity loading: libxml_disable_entity_loader(true); AFAIR right now, du

Re: [PHP-DEV] Disabling External Entities in libxml By Default

2015-07-30 Thread Rob Richards
On 7/30/15 10:30 AM, Rowan Collins wrote: Rob Richards wrote on 30/07/2015 14:12: If you are already working with a trusted document then you should safely be able to disable the entity loader. If you aren't then wouldn't you want to do some sort of checking (especially if you don

Re: [PHP-DEV] Disabling External Entities in libxml By Default

2015-07-30 Thread Rob Richards
On 7/30/15 2:57 PM, Stanislav Malyshev wrote: Hi! The problem here is that imagine the following: I think if we separate the loading the initial file (i.e., staring point of the XML parser) and the loading the entities from that file (which is not happening right now) we'd solve many BC proble

[PHP-DEV] 5.3 status

2012-08-09 Thread Rob Richards
Whats the status of 5.3? I have some changes that need to get into a couple of the xml based extensions in order for them to work with the next libxml2 release next month. Should I be putting these into 5.3 as well? Rob -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, vi

Re: [PHP-DEV] 5.3 status

2012-08-09 Thread Rob Richards
On 8/9/12 12:01 PM, Rasmus Lerdorf wrote: On 08/09/2012 11:31 AM, Lester Caine wrote: Rasmus Lerdorf wrote: On 08/09/2012 11:10 AM, Levi Morrison wrote: On Thu, Aug 9, 2012 at 8:51 AM, Rob Richards wrote: Whats the status of 5.3? I have some changes that need to get into a couple of the

Re: [PHP-DEV] xml ext and & entities

2012-08-10 Thread Rob Richards
The only time I saw this was when PHP was built against libxml 2.7.0-2.7.2 as there were some breaking changes in those versions with entities and SAX. I'll snag a copy of 6.3 and see if I can reproduce. Rob On 8/10/12 7:03 AM, Pierre Joye wrote: Hi Rob, Does that ring a bell? On Mon, Jul 3

Re: [PHP-DEV] DOMNodeList memory eating

2012-11-29 Thread Rob Richards
XPath returns a fully populated list of object based on the expression. getElementsByTagName accesses the nodes within the tree in real time as you iterate so you only have one object at a time unless you are persisting them. Different behavior due to who owns the data and its lifecycle. XPath

Re: [PHP-DEV] libxml returns codes and xmlreader

2011-08-19 Thread Rob Richards
On 8/19/11 7:04 AM, Nicolai Scheer wrote: Hi! On Fri, Aug 19, 2011 at 12:27, Nicolai Scheer wrote: I've noticed, that some of the libxml return codes get "simplified" when used in xmlreader which can be quite problematic. Use libxml_get_errors() So you're suggesting to call another

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Rob Richards
On Aug 31, 2011, at 5:39 AM, Christian Stocker wrote: > > > On 31.08.11 09:47, Stas Malyshev wrote: >> Hi! >> >> For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like >> Ilia reverted the fix for bug #48601 with this: >> >> http://svn.php.net/viewvc/php/php-src/branches/PHP

Re: [PHP-DEV] simplexml inconsistencies in the last few releases (the same issue already discussed)

2011-09-01 Thread Rob Richards
imo new behavior in 5.3 Rob On Sep 1, 2011, at 1:35 AM, Christian Stocker wrote: > Hi > > It's about the two tests in > > http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/simplexml/tests/008.phpt > and > http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/simplexml/tests/bug4

[PHP-DEV] Re: help with php bug #47532

2010-02-14 Thread Rob Richards
Sokolov Evgeniy wrote: Hi, I wont fix this bug: http://bugs.php.net/bug.php?id=47532, but have some questions. Can you help me? There is the test case: http://pastebin.org/91030 First, I careful that when we fix this bug, we have broken BC, because now when we write $attr->value = "foo&bar"; -

[PHP-DEV] Re: help with php bug #47532

2010-02-15 Thread Rob Richards
am thinking about the possibility of a rawValue property on DOMAttr which would conform to the correct setter behavior. Thank you. 2010/2/14 Rob Richards : Sokolov Evgeniy wrote: Hi, I wont fix this bug: http://bugs.php.net/bug.php?id=47532, but have some questions. Can you help me?

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ ext/bz2/bz2.dsp ext/ctype/ctype.dsp ext/curl/curl.dsp ext/dba/dba.dsp ext/dom/dom.dsp ext/exif/exif.dsp ext/ext_skel_win32.php ext/gd/gd.dsp ext/gettex

2010-04-29 Thread Rob Richards
es. I'm also not sure if next php version is going to support VC 6.0 at all. Thanks. Dmitry. Rob Richards wrote: rrichardsWed, 28 Apr 2010 14:41:51 + Revision: http://svn.php.net/viewvc?view=revision&revision=298702 Log: revert change #298288: Remo

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ ext/bz2/bz2.dsp ext/ctype/ctype.dsp ext/curl/curl.dsp ext/dba/dba.dsp ext/dom/dom.dsp ext/exif/exif.dsp ext/ext_skel_win32.php ext/gd/gd.dsp ext/gettex

2010-04-29 Thread Rob Richards
generation much more. Thanks. Dmitry. Rob Richards wrote: Hi Dmitry, The discussion was a while ago (Steph was working on a way to autogenerate them at the time). Unfortunately it failed miserably (buildconf error'd out) when I tried to use it (tried it after the dsps had been removed). Until th

Re: [PHP-DEV] openssl_(en|de)crypt missing IV

2010-05-18 Thread Rob Richards
Sara Golemon wrote: I was just looking through the implementation of openssl_encrypt() (and openssl_decrypt()) today because I need to make some encrypted payloads, but the prototype didn't have anywhere to place an initialization vector. On opening ext/openssl/openssl.c, I noticed line 4620

Re: [PHP-DEV] Why not attach XMLReader / XMLWriter to open php streams?

2010-06-18 Thread Rob Richards
Hans-Peter Oeri wrote: Hi! As documented - and several searches did not lead to a different result - XMLReader and XMLWriter can only work on an URI. That would be a php stream opened and closed by themselves. For several workflows, e.g. with php://temp, it would be nice to be able to "attach"

Re: [PHP-DEV] APC in trunk

2010-06-21 Thread Rob Richards
Ilia Alshanetsky wrote: I for one think it is a really good idea, there is no compelling reason not to include APC, I would even go as far as say we should enable it by default. +1 +1 for including APC -1 for enabling by default It was already agreed to include it into 6 before so why the

Re: [PHP-DEV] Making SimpleXML more useful

2011-04-27 Thread Rob Richards
On 4/27/11 1:59 AM, Tom Samplonius wrote: - Original Message - Looking at this in more detail...I don't think there's a bug here, or a patch required. ... problem for me, as I have an XML schema that specifies that the child elements must not namespace qualified. Is this possible in

Re: [PHP-DEV] Making SimpleXML more useful

2011-04-29 Thread Rob Richards
On 4/29/11 3:44 AM, Tom Samplonius wrote: While I think this would make SimpleXML more stupid, not less, as it seems braindead to me to allow users to create documents ambiguously and/or which essentially violate the XML namespace spec, I think the way to do Allowing child elements to be unqu

Re: [PHP-DEV] Moving COM, Socket & mhash to PECL

2006-12-09 Thread Rob Richards
Ilia Alshanetsky wrote: COM: -1. Its core for windows, has little impact on non-windows users other than a few extra KB to download, and works for the most part. mhash: sockets: +1 for both Rob -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net

Re: [PHP-DEV] Windows build

2007-01-07 Thread Rob Richards
Don't know if any of this will help, but here's what I've been getting while trying to use VS 2005. I'm not sure what the difference is between my debug build and the one Edin released, but when using my own build apache loads everything fine. Using Apache 2.0.59 for testing. When I change the

Re: [PHP-DEV] Windows build

2007-01-08 Thread Rob Richards
able to find a reference to MSVCR8.dll. Rob Wez Furlong wrote: Hmm. I know that, in the past, I've had this kind of issue when trying to distribute modules that use the debug version of the CRT (which is itself not redistributable). I wonder if that is sneaking into the build somehow? --

Re: [PHP-DEV] Re: DOM recover error reporting mode

2007-02-10 Thread Rob Richards
nico wrote: I see, but in my opinion since the recover mode is off by default and E_WARNING is on by default, if recover mode is explicitly activated php should respect the developer's need to keep the interpreter as quiet as possible. A developer with more stringent needs will either keep rec

Re: [PHP-DEV] Build failure

2007-04-05 Thread Rob Richards
I can confirm that it does fail with the single fprintf call without the lock on Win32. Using flock() does fix the problem in my tests. I was able to fix win build using flock() instead of php_flock() and defining HAVE_FLOCK in win32/flock.h Rob Richard Quadling wrote: This test is with the

Re: [PHP-DEV] Build failure

2007-04-05 Thread Rob Richards
doesn't make sense to me. Could you try doing an sprintf() followed by an fwrite() then? Is fprintf() perhaps doing something stupid internally? I'd really like to avoid a lock here. -Rasmus Rob Richards wrote: I can confirm that it does fail with the single fprintf call withou

Re: [PHP-DEV] PHP6 todo list

2007-04-14 Thread Rob Richards
Antony Dovgal wrote: On 04/12/2007 06:37 PM, Lukas Kahwe Smith wrote: 7. ext/soap 1. ext/soap will be turned on by default 2. implement some of the security extensions to ext/soap 3. watch axis2 based implementation development I am guessing the security stuff

Re: [PHP-DEV] Build failure

2007-04-14 Thread Rob Richards
. On 13-Apr-07, at 6:33 AM, Richard Quadling wrote: > On 05/04/07, Rob Richards <[EMAIL PROTECTED]> wrote: >> No difference using sprintf()/fwrite() instead of fprintf(). >> >> I did come across a similar issue from apache: >> http://mail-archives.apache.org/mod

Re: [PHP-DEV] Build failure

2007-04-17 Thread Rob Richards
Unless anyone sees a way to do this without adding the lock, I'd like to commit this patch. It adds a php_flock call only for windows. In doing so I got rid of the win32/flock files and now compile with flock_compat from main. Rob Richard Quadling wrote: The testing I'm using is to launch m

Re: [PHP-DEV] dom strange behaviours

2007-05-16 Thread Rob Richards
kepbepos kepbepos wrote: Hi all, I've some problems with getAttribute* methods. I thing it is a bug, but before send it, I'd like to propose a little test to you all, just to have a confirmation (maybe is my installation only). PHP 5.2.x has correct behavior (see bug 38474) based on W3C spec

Re: [PHP-DEV] Building on Windows

2007-06-14 Thread Rob Richards
Hi Zoe, Zoe Slattery wrote: Has anyone built PHP6 using Visual C++ Express Edition V8? The symptoms I get are pretty well described in http://bugs.php.net/bug.php?id=39130 and I'm just wondering if this was fixed for PHP5 and not PHP6? Other than a slew of warnings, it built fine for me the ot

Re: [PHP-DEV] Building on Windows

2007-06-14 Thread Rob Richards
Stanislav Malyshev wrote: Has anyone built PHP6 using Visual C++ Express Edition V8? The symptoms I get are pretty well described in http://bugs.php.net/bug.php?id=39130 and I'm just wondering if this was fixed for PHP5 and not PHP6? Ah, this is a very familiar issue, you need to set USE_32BI

Re: [PHP-DEV] Ext/OpenSSL patch

2007-08-01 Thread Rob Richards
Hi Dmitry, Dmitry Stogov wrote: Hi, I propose a patch for ext/openssl that extends support for crypto API. - it provides access to openSSL digest functions function openssl_get_md_methods(); function openssl_digest(string $data, string $method [, bool $raw]); - it provides acces

Re: [PHP-DEV] PHP 5.3 Suggested Feature List

2007-09-10 Thread Rob Richards
1) Backport the namespaces patch for PHP 6 0 2) Symlink the intl extension from PECL, but leave it disabled by default as is the case with all extensions dependent on external libs 1 3) Apply the Late Static Binding Patch 1 4) Implement David's Circular Garbage collection patch 0 5) I

[PHP-DEV] Re: VS 2005 Support for 5.3?

2007-10-02 Thread Rob Richards
Hi Pierre, Going forward this might be a good idea, but there needs to be a good amount of testing. I have ran into an issue recently running apps built with VS 2005 using dynamically linked libraries built with older versions due to different runtime linking, which did make me think of this s

[PHP-DEV] Object arithmetic

2007-10-10 Thread Rob Richards
I was wondering why objects are always converted to longs when performing arithmetic. While looking at bug 42780: http://bugs.php.net/bug.php?id=42780 The only way not to lose precision is to explicitly cast the object to float or string, which just doesn't seem right to me. It would be nice if

Re: [PHP-DEV] [PHP DOM] Proposal of boolean property DOMDocument::keepCharacterEntities

2007-10-18 Thread Rob Richards
Not the place for a feature request and not going to happen. It is not supported in libxml2 because it is against the XML specs. Rob Freyjkell wrote: (bool) DOMDocument::keepUnknownCharacterEntities = false; If set to true (before calling DOMDocument::load() or DOMDocument::loadXML()), when

Re: [PHP-DEV] Object arithmetic

2007-10-18 Thread Rob Richards
Stanislav Malyshev wrote: While looking at bug 42780: http://bugs.php.net/bug.php?id=42780 The only way not to lose precision is to explicitly cast the object to float or string, which just doesn't seem right to me. I'm not sure how this can be fixed - there should be some type used and many

Re: [PHP-DEV] quick polls for 5.3

2008-11-12 Thread Rob Richards
1) ext/mhash in 5.3. ext/hash has all the functions, so the entire BC break will be that "if (extension_loaded('mhash'))" will need fixing if mhash is removed (answer both) I) enable ext/hash by default II) remove ext/mhash +1 both 2) deprecate ereg*. ext/ereg is an extension as of PHP 5.3.

Re: [PHP-DEV] Re: Removing basic types from our JSON parser

2008-12-14 Thread Rob Richards
It also says: 5. Generators A JSON generator produces JSON text. The resulting text MUST strictly conform to the JSON grammar. It says "JSON text" not JSON-text. There is no errata about this, so intended or not, PHP follows the spec. Rob Scott MacVicar wrote: The JSON grammar explici

Re: [PHP-DEV] Using an existing extension in a custom extension

2009-01-06 Thread Rob Richards
François Lemaire wrote: Hello all, here's what I'm trying to do: I'm writing a PHP extension in C and I'd like to create a DOMDocument object in my C code that I could send back to my PHP code. I have been trying many things, like: #include "ext/dom/php_dom.h" zval *doc; MAKE_STD_ZVAL(d

Re: [PHP-DEV] towards the next 5.3 release

2009-02-04 Thread Rob Richards
David Zülke wrote: Am 03.02.2009 um 14:41 schrieb Lukas Kahwe Smith: http://bugs.php.net/bug.php?id=47206 - XSLT I looked through the CVS logs, could you confirm I understand it right: The type hint was added in 5.2.6, and will be gone again in 5.2.9, so the only PHP releases with DOMDocume

Re: [PHP-DEV] towards the next 5.3 release

2009-02-04 Thread Rob Richards
Sebastian Bergmann wrote: Rob Richards wrote: The addition in 5.2.6 was a BC break and is fixed in 5.2.9 Removing the type-hint is only a short-term fix, IMHO. A better solution would be to introduce a marker interface that is implemented by the respective classes of the XML

Re: [PHP-DEV] towards the next 5.3 release

2009-02-04 Thread Rob Richards
Paweł Stradomski wrote: W liście Rob Richards z dnia środa 04 lutego 2009: If that's the route this is going to go, I'd rather be able to set an anytype hint where the developer could possibly restrict this further with a more specific type if they extend the class. But

[PHP-DEV] openssl supported algorithms

2009-11-24 Thread Rob Richards
The openssl extension is way to restrictive in the algorithms it supports, i.e. no support for SHA265 which is starting to become the standard algo to use, etc.. Rather than having to always add more constants and additional logic for any new algorithms, I'd like to change the sign and verify f

Re: [PHP-DEV] openssl supported algorithms

2009-11-24 Thread Rob Richards
If I had only checked... Appears its been in trunk (and 5_3) for over 2 years now :) Rob Rasmus Lerdorf wrote: Seems like a no-brainer for 5.3 and trunk. You will have to discuss with Ilia for 5.2. It seems a bit late in the game for that branch to get this. -Rasmus Rob Richards wrote

Re: [PHP-DEV] DOM shortcuts

2007-10-24 Thread Rob Richards
Hi, Keryx Web wrote: 1. When using the shortcut DOMElement::nodeValue on an element node, where the standard says DOMElement::firstChild::nodeValue, is there any difference whatsoever between DOMElement::nodeValue and DOMElement::textContent? None whatsoever. nodeValue on an element was added fo

Re: [PHP-DEV] Providing Visual Studio 2005 builds (again)

2007-11-14 Thread Rob Richards
Not to drag this on any longer, but here's my 2 cents on this... VC 6 builds are not going away any time soon. They work, are well supported and have gone through years of testing. However, eventually the builds are going to have to be upgraded to newer compilers. With the changing run times,

Re: [PHP-DEV] Providing Visual Studio 2005 builds (again)

2007-11-14 Thread Rob Richards
is the best place, but it just needs to be made available. As for anyone's motives for wanting to do this; it really isn't a concern of mine because I agree with making a build available. Rob - Steph ----- Original Message - From: "Rob Richards" <[EMAIL PROTECTED

Re: [PHP-DEV] PHP 5.3 bug or changed feature??

2007-12-09 Thread Rob Richards
Hi Frank, Frank M. Kromann wrote: Hello Everyon, Casting a SimpleXML object to an array gives different results in PHP 5.2.5 and PHP 5.3-dev. This is due to the implementation of the get_debug_info handler merged from HEAD. The same result happens when calling get_object_vars on a SimpleXM

Re: [PHP-DEV] build failure on windows PHP_5_2

2008-02-13 Thread Rob Richards
Edward Z. Yang wrote: Steph Fox wrote: Rob's download page is at http://ctindustries.net/libxml/ if anyone needs to update their libxml copy locally. Just a quick note: the new files don't seem to work properly with 5.2.5 unless you update ext/libxml/config.w32 to the branch version; a

Re: [PHP-DEV] Unresolved external symbol : xmlXPathCompiledEvalToBoolean

2008-04-22 Thread Rob Richards
The zip file hasn't been updated yet. Get the libs from here: http://ctindustries.net/libxml/ Rob Richard Quadling wrote: Hi. Am I getting this fatal link error on Windows when building PHP due to an old version of xml in zip.zip? My configure.js is cscript /nologo configure.js "--with-php-

[PHP-DEV] PHP 5.2.6RC5 windows build available

2008-04-29 Thread Rob Richards
A little late to the party, but the windows build for PHP 5.2.6RC5 is finally available. Please test it as much as possible. http://pecl2.php.net/downloads/php-windows-builds/qa/php-5.2.6RC5-Win32.zip http://pecl2.php.net/downloads/php-windows-builds/qa/php-debug-pack-5.2.6RC5-Win32.zip The non

[PHP-DEV] url encoding rfc 3986 conformance

2008-05-12 Thread Rob Richards
I'd like to update, or at a minimum, add an option for rawurlencode to output rfc3986 conforming data. It basically boils down to just also not encoding the "~" character. Most of the new technologies doing encoding require this and its becoming a pita to write exception code for that one chara

Re: [PHP-DEV] CVS Account Request: indeyets

2008-06-12 Thread Rob Richards
in "spread" extension I am sending patches to Rob Richards, but he is not always there to apply them There is a good chance, that I will be moving my "syck" extension to pecl's cvs, finally I am going to start another extension soon (will announce it on pecl-dev, when I a

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build DSP.README block.template.dsw buildconf.js config.w32 confutils.js projectgen.js template.dsp template.dsw

2008-07-09 Thread Rob Richards
Steph Fox wrote: Read the description in the wiki and in the CMake docs. It generates dsp/dsw, sln/vcproj or makefiles for all VC versions (while working as well for unix). Great, cool, shame it'll take a couple of years from inception before we can rely on it day-in day-out. No idea what

[PHP-DEV] Re: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) /win32/build DSP.README block.template.dsw buildconf.js config.w32 confutils.js projectgen.js template.dsp template.dsw

2008-07-09 Thread Rob Richards
Hey Steph, Steph Fox wrote: Hi Rob, Actually we both did agree to start updating them in order to keep them until the CMake stuff is integrated. Not while I was logging... or in my email archives... so you must've agreed that in some different channel or mailing list. In fact what you act

[PHP-DEV] Re: to be discussed items

2008-07-15 Thread Rob Richards
Hi Lukas, Lukas Kahwe Smith wrote: Hi, I am about to move all "to be discussed items" [1] to the future PHP release section (so after 5.3): 2) XMLWriter: Add writeNode([xmlreader obj]), allow to create a push/pull parser I also don't think I would be able to find the time to get this done

Re: [PHP-DEV] Broken Windows build

2008-07-31 Thread Rob Richards
Derick Rethans wrote: On Thu, 31 Jul 2008, Pierre Joye wrote: On Thu, Jul 31, 2008 at 5:08 PM, Steph Fox <[EMAIL PROTECTED]> wrote: Hi all, Last week PHP_5_3 out of CVS built on my box under VC6; today it does not. I have been told on irc (thanks Liz) It has been like that si

[PHP-DEV] reflection ext

2005-11-17 Thread Rob Richards
Marcus, are you going to be using any module globals in the extension? I had to remove the code for it to get it to build on windows - patached attached. Though it does build fine if you do define some. Rob Index: php_reflection.c ==

Re: [PHP-DEV] PHP 5.1.2 Release Plan

2005-12-01 Thread Rob Richards
Marcus Boerger wrote: Sure, but until that happens I don't think it should be included. Same here. The discussion was on IRC and between Rob & Pierre and i thought they changed back but didn't do so yet. The license is changing. It was actually supposed to have changed yesterday. Pierre

[PHP-DEV] windows build and libxml2/libxslt

2005-12-11 Thread Rob Richards
The windows build has been update to use libxml2 .22 and libxslt .15. New release and debug builds of these can be grabbed from http://ctindustries.net/libxml/ Rob -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] crashing due to get_properties handler

2006-01-27 Thread Rob Richards
Is it required that the get_properties handler be implemented for an object? In the source there are places that it tests if it is implemented and then tests the returned value in the event it is NULL. The problem is that this is not consistent throughout the zend and php source and I'm getting

Re: [PHP-DEV] crashing due to get_properties handler

2006-01-31 Thread Rob Richards
Here's a patch against HEAD for get_object_vars in zend_builtin_functions.c that checks for the return value of the handler. With this change it should at least now be safe to implement the handler and return NULL, as this was the only spot I found in the engine that checked only for the existe

[PHP-DEV] new simplexml functionality

2006-03-05 Thread Rob Richards
I would like to propose adding addChild and addAtribute methods to simplexml. I know these have been shot down in the past, but with Marcus' recent changes to simplexml, they now make sense imo. SimpleXMLElement::addChild(string qName, string value [,string ns]) SimpleXMLElement::addAttribute(s

Re: [PHP-DEV] new simplexml functionality

2006-03-05 Thread Rob Richards
Rob Richards wrote: Rational: It is not possible to add elements to a tree, but new namespaced elements/attributes cannot (although existing ones can be modified). Correction: This should say "It is now possible to add elements " Rob -- PHP Internals - PHP Runtime Developme

Re: [PHP-DEV] GOTO and/or BREAK LABEL

2006-03-07 Thread Rob Richards
Dmitry Stogov wrote: 1) goto and break label +0.5 2) goto only (like C) +1 3) break label only (like Java) -1 Rob -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Problem with ext/libxml RINIT/RSHUTDOWN

2006-03-17 Thread Rob Richards
Dmitry Stogov wrote: Hi Wez, I found a bad code in ext/libxml. On each request startup/shutdown it changing some libxml callbacks. At first this slowdown each request, at second multi-threaded PHP may fail, because different threads may set/clean the same callbacks in the same time. May be it

Re: [PHP-DEV] Problem with ext/libxml RINIT/RSHUTDOWN

2006-03-17 Thread Rob Richards
I don't think I made myself clear on the globals. The only situation there would be a problem is if PHP were built threaded and libxml2 were not (which as of 2.5.8 it is built threaded by default). When running threaded, each thread has its own global state, so when modified at request startup

Re: [PHP-DEV] [PATCH] Compile head on Win32

2006-04-21 Thread Rob Richards
If this patch is used to fix the build, the same change need to be made in: ext/spl/spl_directory.c ext/standard/image.c (php_stream_gets) sapi/cli/php_cli.c (php_stream_gets) Frank M. Kromann wrote: Hello Everyone, Here is a patch that makes it possible to compile HEAD on win32. http://kroman

[PHP-DEV] patch: zend_API.c - compile file

2006-05-10 Thread Rob Richards
The extra semi-colon is causing build to fail here. Rob Index: zend_API.c === RCS file: /repository/ZendEngine2/zend_API.c,v retrieving revision 1.296.2.27.2.1 diff -u -r1.296.2.27.2.1 zend_API.c --- zend_API.c 9 May 2006 23:53:23 -

Re: [PHP-DEV] patch: zend_API.c - compile file

2006-05-10 Thread Rob Richards
Antony Dovgal wrote: On 10.05.2006 17:41, Rob Richards wrote: The extra semi-colon is causing build to fail here. Committed, thanks. Just interesting: what compiler do you use? Was failing on my Windows builds VC 6. Rob -- PHP Internals - PHP Runtime Development Mailing List To

[PHP-DEV] patch: zend.c missing call for cast_object handler

2006-05-10 Thread Rob Richards
In zend_make_printable_zval, it looks like code for an object's cast_object handler was missed when synching. Rob Index: zend.c === RCS file: /repository/ZendEngine2/zend.c,v retrieving revision 1.308.2.12.2.1 diff -u -r1.308.2.12.2

[PHP-DEV] unicode and xml extensions

2006-07-17 Thread Rob Richards
Attached is a patch for my initial cut for unicode and XML (made against the /ext directory). I started with XMLReader since it was the smallest. The code can probably be optimized a bit, but I want to make sure this is how it should be because the changes made here will be the changes needed f

Re: [PHP-DEV] unicode and xml extensions

2006-07-17 Thread Rob Richards
Had some feedback about a problem with the attached file, so here's also link to the diff. http://www.ctindustries.net/patches/xmlunicode.diff.txt Rob -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] unicode and xml extensions

2006-07-19 Thread Rob Richards
Andrei Zmievski wrote: Rob, I have not tested the patch, but it looks good to me on cursory overview. I assume it passes your tests? The only comment I have is regarding the usage of 't' and 'T' specifiers. Since you always have to pass binary UTF-8 strings to libxml, we should always use 's'

[PHP-DEV] run-tests and unicode

2006-07-19 Thread Rob Richards
I was having some problems testing in native mode when my ini file had unicode enabled. It appears that it must be explicitly disabled in the script with the passing -N flag (make ntest). Otherwise it is picking up the ini setting and running the tests in unicode mode. Patch is attached just in

Re: [PHP-DEV] unicode and xml extensions

2006-07-20 Thread Rob Richards
Andrei Zmievski wrote: Hey Rob, Looks good. Have you tested the filesystem (filename) related functions with non-ASCII filenames? Try making a file called "informaçon.xml" for example, set unicode.filesystem_encoding=utf-8 (or whatever encoding your filesystem uses) and see if you can read it

Re: [PHP-DEV] unicode and xml extensions

2006-07-21 Thread Rob Richards
Almost done with DOM (3 more files to go), so hopefully by Monday. This one will need a lot of testing though. Rob Andrei Zmievski wrote: Great! I'll put a slide about this into my talk for OSCON. What're your plans for the rest of the XML extensions? -Andrei -- PHP Internals - PHP Runtim

Re: [PHP-DEV] unicode and xml extensions

2006-07-22 Thread Rob Richards
Andrei Zmievski wrote: Awesome. I am planning to add "s(encoding)" support to parameter parsing, by the way, so getting strings in UTF-8 encoding will be a bit easier. Would probably need to change the relevant portions of your commits. Any idea when this should be ready, or should I just go a

Re: [PHP-DEV] unicode and xml extensions

2006-07-24 Thread Rob Richards
imo, this would probably the easiest and best way to handle the conversions. Rob Andrei Zmievski wrote: Maybe. An alternate way would be to add modifier to 's' that makes it accept a converter to use for conversion. if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s>", &str, &str_len, U

[PHP-DEV] libxml2/threading/win 2003

2006-08-10 Thread Rob Richards
In order to resolve reported crashing on win 2003, I have had to change the static libxml builds to use the flag LIBXML_STATIC_FOR_DLL. This now requires a DllMain to be added within any dll that is building libxml2 in statically. PHP 4.x - domxml (use php_domxml.c.diff.txt patch) PHP 5.x/HEAD

Re: [PHP-DEV] libxml2/threading/win 2003

2006-08-10 Thread Rob Richards
Doesn't really matter where it is. The only reason I added it in libxml.c was since libxml2 was the first/only lib needing a DllMain in teh php5ts_xxx.dll build, I put it there so there was minimal changes to the core code. Evenutally I thought it might make more sense to me moved elsewhere so

Re: [PHP-DEV] libxml2/threading/win 2003

2006-08-21 Thread Rob Richards
Kadribasic wrote: Hi Rob, Since we're adding a DllMain function, shouldn't it be located in main/main.c. We might need to hook up other thread initialization stuff in there in the future. Edin Rob Richards wrote: In order to resolve reported crashing on win 2003, I have had to change

Re: [PHP-DEV] libxml2/threading/win 2003

2006-08-25 Thread Rob Richards
MINIT is definitely not the place for this. The xmlDllMain call is meant to be called from within a dll's DllMain that includes libxml statically. How threads are handled differs between the old static build and the one for inclusion within a dll. When a thread (all except the main thread) termi

Re: [PHP-DEV] libxml2/threading/win 2003

2006-08-26 Thread Rob Richards
Technically no. I forgot all the exact reason for the static linking, but I know one of them was that it was easier to maintain an "official" version that was included with the PHP release. The other reason had to do with easing the installation burden and all the problems people have in that a

Re: [PHP-DEV] libxml2/threading/win 2003

2006-09-02 Thread Rob Richards
I am on the fence one this one. Going the dll route makes my life easier by no longer needing to maintain those builds, but will almost certainly increase the number of bogus bugs to be chased down and cause the windows installation to be more complicated again (Just doing a search you can fin

Re: [PHP-DEV] libxml2/threading/win 2003

2006-09-02 Thread Rob Richards
Andi Gutmans wrote: Yeah but Windows is very friendly and designed for this. As long as the dlls are in the application's directory you will not have problems. This is actually much easier and straightforward than on Linux so it sounds to me that dll clashing problems (which doesn't happen in thi

Re: [PHP-DEV] libxml2/threading/win 2003

2006-09-06 Thread Rob Richards
Uh, yea I have been proposing a change (first made on 8/10, but had been waiting for the 4.4 and 5.1 releases to be finished). .oO(Would have been nice is people mentioned any objections/issues way back then) http://news.php.net/php.internals/25300 So you really think that making registry c

Re: [PHP-DEV] libxml2 build for php 5.2 on windows

2006-09-12 Thread Rob Richards
Stanislav Malyshev wrote: I am trying to build php 5.2 on Windows with Visual. So far I managed to build everything except for libxml2 dependencies, which do not seem to work. So could anyone please clarify the following matters: 1. What libxml2 version is required for 5.2 build? 2.6.26 built

Re: [PHP-DEV] libxml2 build for php 5.2 on windows

2006-09-12 Thread Rob Richards
Stanislav Malyshev wrote: Hi! Thanks for the quick answer! 2.6.26 built using the LIBXML_STATIC_FOR_DLL flag. Ehm, ok. The problem is that it is not possible to define this flag in any way but by hand-editing makefile. Which reinforces my point about keeping working one in win32build z

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/libxml/tests 002.phpt /ext/reflection/tests005.phpt

2006-09-20 Thread Rob Richards
Michael Wallner wrote: Derick Rethans wrote: On Tue, 19 Sep 2006, Antony Dovgal wrote: http://cvs.php.net/viewvc.cgi/php-src/ext/libxml/tests/002.phpt?r1=1.2&r2=1.3&diff_format=u Index: php-src/ext/libxml/tests/002.phpt diff -u php-src/ext/libxml/tests/002.phpt:1.2 php-src/ext/libxml/tests/002

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c zend_globals.h zend_unicode.c

2006-10-04 Thread Rob Richards
eBSD. Does anyone else have this problem? -A On Oct 3, 2006, at 4:56 AM, Rob Richards wrote: I get consistent crashes on windows during shutdown with this change. Access violation in the dtor at: ucol_close(unicode_globals->root_collator); It did open correctly as: unicode_globals-&

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.c zend_globals.h zend_unicode.c

2006-10-04 Thread Rob Richards
That does prevent the crash. I did find that within zend_shutdown, if I comment out the call to u_cleanup(), then ucol_close doesn't crash within unicode_globals_dtor during tsrm_shutdown. If that helps any. Rob Andrei Zmievski wrote: I suppose we can omit the ucol_close() call since we're s

Re: [PHP-DEV] Re: cvs: ZendEngine2(PHP_5_2) / zend_language_scanner.l

2006-11-10 Thread Rob Richards
Due to encoding issues, I made it that binary strings were required for the XML based extensions when loading documents via strings. By adding the binary cast to 5.x it will at least allow developers to prepare for this change when 6 is rolled out, so imo this is a good idea. Rob Ilia Alshan

Re: [PHP-DEV] Re: PHP 5.1 roadmap

2004-10-26 Thread Rob Richards
From: Christian Stocker > - Better error support for xml extension > > I already talked about that with rob. nothing's coded right now, but > would be good to have an easier way to catch xml errors in PHP 5.1 (it's > unsatisfying right now) would really like to see libxml bumped up to a 2.6.x ver

[PHP-DEV] streams file uri under windows

2004-10-26 Thread Rob Richards
It possible to add this patch or something along these lines so that file:/// syntax can be used under windows again? A change on 8/31 was made to allow for file:// but now prevents file:/// (which is valid) Index: streams.c === RCS f

[PHP-DEV] Re: streams file uri under windows

2004-10-26 Thread Rob Richards
After playing around with it some more, is this that check even needed for windows to check for remote host access? What is the different then between doing?: file_get_contents("remotehost\\share\\file.txt"); file_get_contents("file://remotehost\\share\\file.txt"); With the current strea

Re: [PHP-DEV] Re: streams file uri under windows

2004-10-26 Thread Rob Richards
I ended up on this tangent only because file:/// support is needed (and from the looks of things is the prefered method for local files over using file://) and how I got stuck in the remote host issue. The following are some syntaxes which are used in windows (tested these with a few browsers and

Re: [PHP-DEV] Re: streams file uri under windows

2004-10-27 Thread Rob Richards
From: Alan Knowles > you could follow the nautilus standard for this and use > smb://hostname/sharename/file.txt ? Can't do that as this is stemming from an issue with libxml. It uses the file:/// syntax when needed. Currently with the change in streams, it fails the check as it is now deemed to

Re: [PHP-DEV] Re: streams file uri under windows

2004-10-27 Thread Rob Richards
If anyone has a chance can you look at this patch (want to make sure its not breaking anything on other platforms)? http://ctindustries.net/patches/streams.c.diff It adds support for file://localhost/ on all platforms as well as adding the file:/// support back under windows. Other than that it do

  1   2   3   >