Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

2011-01-31 Thread Pierre Joye
On Mon, Jan 31, 2011 at 11:33 PM, Stas Malyshev wrote: >> But I strongly believe in a threaded base solution for windows. That's >> the only way to get anywhere close to the performance we can see on >> other platforms (read: posix). > > My experience is that performance differnces between Window

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

2011-01-31 Thread Daniel Convissor
Hi Pierre: On Mon, Jan 31, 2011 at 08:43:40PM +0100, Pierre Joye wrote: > > It does not matter what is the latest VC version. What matters is that > VC6 is a dead cow and we won't support it anymore, even for the > current stable, 5.3. And to be honest I don't really care about > Apache.org's use

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

2011-02-01 Thread Stas Malyshev
Hi! The filesystem issues are mostly due to what we do in TS mode, way too much pointless operations, even if the real cache helps a little bit here (take this comment with a bit of salt: as in delta with the cache between TS and NTS). What we do in TS mode with filesystem that could explain t

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

2011-02-01 Thread Pierre Joye
On Tue, Feb 1, 2011 at 9:53 AM, Stas Malyshev wrote: > Hi! > >> The filesystem issues are mostly due to what we do in TS mode, way too >> much pointless operations, even if the real cache helps a little bit >> here (take this comment with a bit of salt: as in delta with the cache >> between TS and

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

2011-02-01 Thread Stas Malyshev
Hi! This delta has very little impact on real world apps except those doing exclusively such ops. The benchmarks I did suggest otherwise. Real world apps do huge number of file ops like file_exists(). And while many apps aggressively cache DB calls and such, filesystem calls are still there.

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

2011-02-01 Thread Pierre Joye
On Tue, Feb 1, 2011 at 10:23 AM, Stas Malyshev wrote: > Though, of course, maybe I'm wrong - what would you suggest is the problem > then? I saw similar slowdowns on 1-process benchmarks as on multi-process > server benchmarks - so I have hard time believing it has anything to do with > threading

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.c trunk/ext/date/php_date.c

2011-02-01 Thread Johannes Schlüter
On Tue, 2011-02-01 at 01:04 +0100, Pierre Joye wrote: > On Mon, Jan 31, 2011 at 11:33 PM, Stas Malyshev > wrote: > > >> But I strongly believe in a threaded base solution for windows. That's > >> the only way to get anywhere close to the performance we can see on > >> other platforms (read: posi

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/reflection/php_reflection.c trunk/ext/reflection/php_reflection.c

2011-06-05 Thread Felipe Pena
2011/6/5 Sebastian Bergmann > Am 05.06.2011 10:59, schrieb Stanislav Malyshev: > > stas Sun, 05 Jun 2011 08:59:24 + > > > > Revision: http://svn.php.net/viewvc?view=revision&revision=311824 > > > > Log: > > This method doesn't seem to be very useful without

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/reflection/php_reflection.c trunk/ext/reflection/php_reflection.c

2011-06-05 Thread Stas Malyshev
Hi! It is still useful for array | class/interface name. Or? Not really, since it returned only "array" or "object", while real class is returned by getClass() and isArray() returns if it's an array. We could have method that returns class name or "array" if it's an array, but that'd be d

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Chad Emrys
On 07/19/2011 07:09 PM, Pierre Joye wrote: On Wed, Jul 20, 2011 at 1:50 AM, Scott MacVicar wrote: OpenSSL has been FIPS certified, your change has changed this contract and it's calling back into a Windows API. Has it been reviewed for correctness? And by the way, the CryptoAPI for the window

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-23 Thread Thomas Hruska
On 7/19/2011 5:09 PM, Pierre Joye wrote: On Wed, Jul 20, 2011 at 1:50 AM, Scott MacVicar wrote: OpenSSL has been FIPS certified, your change has changed this contract and it's calling back into a Windows API. Has it been reviewed for correctness? And by the way, the CryptoAPI for the windows

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.hext/json/tests/serialize.phpt

2010-05-12 Thread Sara Golemon
Stanislav Malyshev wrote: Add JSON_Serializable interface Objects implementing JSON_Serializable will have their ->jsonSerialize() method called Similar to serialize() and __sleep() Why should we have special mechanism for JSON? I.e., now we have one for serialize(), separate one for json, th

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS sapi/cgi/cgi_main.c sapi/cgi/fastcgi.c sapi/cgi/fastcgi.h

2010-08-27 Thread Pierre Joye
hi, Great thing :) I wonder if we could not rename then sapi_* and document which SAPI supports them, instead of using apache_* for fastcgi & co. Cheers, On Fri, Aug 27, 2010 at 10:34 AM, Dmitry Stogov wrote: > dmitry                                   Fri, 27 Aug 2010 08:34:44 + > > Revis

[PHP-DEV] REMOVE : [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.ctrunk/ext/date/php_date.c

2011-01-31 Thread ca
REMOVE - Original Message - From: William A. Rowe Jr. [mailto:wr...@rowe-clan.net] To: internals@lists.php.net Sent: Mon, 31 Jan 2011 11:28:19 -0600 Subject: Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/date/php_date.ctrunk/ext/date/php_date.c On 1/30/2011 10:36

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-24 Thread Laruence
Dmitry: you might want to review this fix. let me explain why crash before this fix. when doing parse_parameter, then convert the object to string by calling the ce->cast_object, and passed the same pointer(although there was a separation), to the cast_object.. then if __toStrin

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Dmitry Stogov
Hi Laruence, The attached patch looks wired. The patch on top of it (r323563) makes it better. However, in my opinion it fixes a common problem just in a single place. Each call to __toString() that makes "side effects" may cause the similar problem. It would be great to make a "right" fix in

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Laruence
On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote: > Hi Laruence, > > The attached patch looks wired. The patch on top of it (r323563) makes it > better. However, in my opinion it fixes a common problem just in a single > place. Each call to __toString() that makes "side effects" may cause the

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Laruence
On Mon, Feb 27, 2012 at 4:31 PM, Laruence wrote: > On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote: >> Hi Laruence, >> >> The attached patch looks wired. The patch on top of it (r323563) makes it >> better. However, in my opinion it fixes a common problem just in a single >> place. Each call

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Dmitry Stogov
On 02/27/2012 12:37 PM, Laruence wrote: On Mon, Feb 27, 2012 at 4:31 PM, Laruence wrote: On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote: Hi Laruence, The attached patch looks wired. The patch on top of it (r323563) makes it better. However, in my opinion it fixes a common problem just

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Derick Rethans
On Mon, 27 Feb 2012, Laruence wrote: > On Mon, Feb 27, 2012 at 4:31 PM, Laruence wrote: > > On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov wrote: > >> > >> The attached patch looks wired. The patch on top of it (r323563) makes it > >> better. However, in my opinion it fixes a common problem just

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Pierre Joye
On Mon, Feb 27, 2012 at 11:17 AM, Derick Rethans wrote: > You can't break extension APIs between 5.4.0 and 5.4.1 either, API > changes can only into trunk. And ABI neither. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mai

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-06 Thread Pierre Joye
On Thu, May 6, 2010 at 12:59 PM, Hannes Magnusson wrote: > On Thu, May 6, 2010 at 00:48, Sara Golemon wrote: >> pollita Wed, 05 May 2010 22:48:14 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=299037 >> >> Log: >> Add JSON_Serializable inte

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-12 Thread Stanislav Malyshev
Hi! Add JSON_Serializable interface Objects implementing JSON_Serializable will have their ->jsonSerialize() method called Similar to serialize() and __sleep() Why should we have special mechanism for JSON? I.e., now we have one for serialize(), separate one for json, then we'd have separate

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/tsrm_win32.c

2009-08-19 Thread Stanislav Malyshev
Hi! Initially, this prevents popen_ex from failing when the actual executable doesn't exist, since "cmd.exe /c c:\foo\bar\xxx.exe" will *always* successfully start a process. This can be seen in bug #43327. Second, is that by having the intermediate process, I'm pretty sure there's some extra-b

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 10:45 AM, Stas Malyshev wrote: Hi! On 9/6/11 1:24 AM, Andrey Hristov wrote: no, it's about consistency, which you want. mysqlnd should behave like libmysql, and it is a test that can test it. What libmysql returns in filtered in mysqli, mysqli_num_rows() is a direct wrapper around

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! Have you actually checked what libmysql returns??!? If _you_ just have tried to do it, you might actually find that libmysql does what mysqlnd did long ago, but mysqli was hiding it. Here is output from what libmysql does, after removing the following check from mysqli_api.c: I checked wh

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Stas Malyshev
Hi! so I think, maybe it's okey for a temporary fix :) what I mean temporary is, apply this fix to 5.3 and 5.4 Don't apply anything to 5.4 now, please. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Internals - PHP Runtime Deve

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Laruence
On Mon, Feb 27, 2012 at 4:53 PM, Stas Malyshev wrote: > Hi! > > >>>   so I think,  maybe it's okey for a temporary fix :) >> >> what I mean temporary is, apply this fix to 5.3 and 5.4 > > > Don't apply anything to 5.4 now, please. Sure, won't do it without your permission. :) thanks > > -- > Stan

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Dmitry Stogov
On 02/27/2012 12:53 PM, Stas Malyshev wrote: Hi! so I think, maybe it's okey for a temporary fix :) what I mean temporary is, apply this fix to 5.3 and 5.4 Don't apply anything to 5.4 now, please. No, we are thinking about the trunk, and "temporary" fix for 5.4 is delayed. Thanks. Dmitr

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Richard Lynch
On Mon, February 27, 2012 2:31 am, Laruence wrote: > On Mon, Feb 27, 2012 at 4:00 PM, Dmitry Stogov > wrote: >> Hi Laruence, >> >> The attached patch looks wired. The patch on top of it (r323563) >> makes it >> better. However, in my opinion it fixes a common problem just in a >> single >> place.

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Anthony Ferrara
Out of curiosity, why are you changing it to copy the object for the result of the cast operation? cast_object should init the result zval, so why go through the step of copying the starting object to it? Wouldn't it be easier just to do: if (Z_OBJ_HANDLER_PP(arg, cast_object)) {

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Xinchen Hui
Sent from my iPad 在 2012-2-28,0:10,Anthony Ferrara 写道: > Out of curiosity, why are you changing it to copy the object for the > result of the cast operation? cast_object should init the result > zval, so why go through the step of copying the starting object to plz look at the final fix: r32356

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Anthony Ferrara
I initially looked at the final fix when I discovered the issue. Follow me out on this. This is the current code as-implemented in r323563: 265 zval *obj; 266 MAKE_STD_ZVAL(obj); 267 if (Z_OBJ_HANDLER_P(*arg, cast_object)(*arg, obj, type

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Xinchen Hui
On Tue, Feb 28, 2012 at 1:10 AM, Anthony Ferrara wrote: > I initially looked at the final fix when I discovered the issue. > Follow me out on this.  This is the current code as-implemented in > r323563: > >    265                 zval *obj; >    266                 MAKE_STD_ZVAL(obj); >    267    

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_API.c trunk/NEWS trunk/Zend/zend_API.c

2012-02-27 Thread Xinchen Hui
On Tue, Feb 28, 2012 at 10:38 AM, Xinchen Hui wrote: > On Tue, Feb 28, 2012 at 1:10 AM, Anthony Ferrara wrote: >> I initially looked at the final fix when I discovered the issue. >> Follow me out on this.  This is the current code as-implemented in >> r323563: >> >>    265                 zval *o

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-06 Thread Guilherme Blanco
Hi guys, I'd like to thank you for this implementation. @Pierre: There is a RFC I wrote: http://wiki.php.net/rfc/jsonable I'd suggest to rather be JSONSerializable or be Jsonable. JSON is an acronym, the same as PDO. We don't have interface for Pdo, but for PDO. So we should keep consistency.

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-06 Thread Guilherme Blanco
PS: Argh, sorry... pressed the send button without finishing to write the email. Consistency that matches with Serializable interface when dealing with (un)serialize(). So if we have to vote, I'd go for Jsonable. The method should be renamed to _toJSON (I can even accept __toJson here), using the

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-06 Thread Pierre Joye
hi, I like the feature, it is a nice and useful one. However nobody ever posted anything on internals about it. The differences between the implementation and the RFC as well as the questions raised by this addition show that it would be better to discuss prior to commit. But as it is in trunk,

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-11 Thread Sara Golemon
However nobody ever posted anything on internals about it. The differences between the implementation and the RFC as well as the questions raised by this addition show that it would be better to discuss prior to commit. But as it is in trunk, that's less a problem, that's why trunk exists: a deve

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-11 Thread Sara Golemon
However nobody ever posted anything on internals about it. The differences between the implementation and the RFC as well as the questions raised by this addition show that it would be better to discuss prior to commit. But as it is in trunk, that's less a problem, that's why trunk exists: a deve

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-11 Thread Adam Harvey
On 12 May 2010 06:01, Sara Golemon wrote: > On method naming, I was following the pattern of __*() for "always on" magic > methods (__get(), __set(), etc...) versus interface-induced magic methods > (offsetGet(), offsetSet(), etc...). Agreed. I don't have any real preference on the interface name

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-12 Thread Pierre Joye
hi! On Wed, May 12, 2010 at 4:25 AM, Stanislav Malyshev wrote: > Hi! > >> Add JSON_Serializable interface >> Objects implementing JSON_Serializable will have >> their ->jsonSerialize() method called >> >> Similar to serialize() and __sleep() > > Why should we have special mechanism for JSON? I.e.

RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-13 Thread Jared Williams
> -Original Message- > From: Pierre Joye [mailto:pierre@gmail.com] > Sent: 12 May 2010 11:33 > To: Stanislav Malyshev > Cc: Sara Golemon; PHP Internals > Subject: Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ > NEWS ext/json/json.c ext/json/php_

RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-13 Thread Johannes Schlüter
On Thu, 2010-05-13 at 20:27 +0100, Jared Williams wrote: > Hi, > Keep thinking with what is in php.next that interfaces seem > overkill? > > Doesn't > > trait JSON > { > function toJSONString() > { > return json_encode(get_object_vars($this)); > } > } > clas

RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-13 Thread Jared Williams
> -Original Message- > From: Johannes Schlüter [mailto:johan...@schlueters.de] > Sent: 13 May 2010 20:47 > To: Jared Williams > Cc: 'Pierre Joye'; 'Stanislav Malyshev'; 'Sara Golemon'; 'PHP > Internals' > Subject: RE: [PHP

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-13 Thread Davey Shafik
wrote: > > >> -Original Message- >> From: Johannes Schlüter [mailto:johan...@schlueters.de] >> Sent: 13 May 2010 20:47 >> To: Jared Williams >> Cc: 'Pierre Joye'; 'Stanislav Malyshev'; 'Sara Golemon'; 'PHP >> Internals' >&g

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-13 Thread Pierre Joye
hi, On Fri, May 14, 2010 at 12:54 AM, Davey Shafik wrote: > The point is that json_encode will automatically call and use the return of > jsonSerialize() > no matter WHERE you serialize the object. RIght, however Json is also not about serialize (as in php's serialize), the naming could create

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-15 Thread Hannes Magnusson
2010/5/14 Jared Williams : >        $a = new A(); >        echo $a->toJSONString(), "\n"; >        $b = new B(); >        echo $b->toJSONString(), "\n"; > $array = array(new A,new B,); // Does not use your toJSONString method echo json_encode($array); -Hannes -- PHP Internals - PHP Runtime Dev

RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-15 Thread Jared Williams
> -Original Message- > From: Hannes Magnusson [mailto:hannes.magnus...@gmail.com] > Sent: 15 May 2010 13:25 > To: Jared Williams > Cc: Johannes Schlüter; Pierre Joye; Stanislav Malyshev; Sara > Golemon; PHP Internals > Subject: Re: [PHP-DEV] Re: [PHP-CVS] sv

RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/json/json.c ext/json/php_json.h ext/json/tests/serialize.phpt

2010-05-15 Thread Johannes Schlüter
Hi, On Sat, 2010-05-15 at 15:33 +0100, Jared Williams wrote: > With using traits, don't have to provide an implementation > of jsonSerialize() unless want to customise the behaviour, > but the current implementation will require having to > implement JSONSerializable. No. The default behavior wil

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/tsrm_win32.c

2009-08-20 Thread Richard Quadling
2009/8/19 Stanislav Malyshev : > Hi! > >> Initially, this prevents popen_ex from failing when the actual >> executable doesn't exist, since "cmd.exe /c c:\foo\bar\xxx.exe" will >> *always* successfully start a process. This can be seen in bug >> #43327. >> >> Second, is that by having the intermedi

RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/tsrm_win32.c

2009-08-20 Thread Garrett Serack
G -Original Message- From: Stanislav Malyshev [mailto:s...@zend.com] Sent: Wednesday, August 19, 2009 2:40 PM To: Garrett Serack; Pierre Cc: 'PHP Internals' Subject: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/t

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/tsrm_win32.c

2009-08-20 Thread Pierre Joye
ert that patch, and I'll write a new separate routine > that doesn't use cmd.exe as a gateway. > > My Apologies. > > G > > -Original Message- > From: Stanislav Malyshev [mailto:s...@zend.com] > Sent: Wednesday, August 19, 2009 2:40 PM > To: Garrett Serack; P

RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/tsrm_win32.c

2009-08-20 Thread Andi Gutmans
- > From: Garrett Serack [mailto:garre...@microsoft.com] > Sent: Thursday, August 20, 2009 7:24 AM > To: Stas Malyshev; Pierre > Cc: 'PHP Internals' > Subject: RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS > branches/PHP_5_3/TSRM/tsrm_win32.c trunk/T

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/sapi/cli/php_cli_server.c trunk/NEWS trunk/sapi/cli/php_cli_server.c

2011-08-22 Thread Laruence
Hi: Added SERVER[SERVER_SOFTWARE], http://svn.php.net/viewvc?view=revision&revision=315300 but server_addr is a litte diffcult since there is no a ready value for that, needs a litte more works, I think we'd better not do that much changes for this, at least need the author to review, :) thank

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 11:16 AM, Stas Malyshev wrote: Hi! Have you actually checked what libmysql returns??!? If _you_ just have tried to do it, you might actually find that libmysql does what mysqlnd did long ago, but mysqli was hiding it. Here is output from what libmysql does, after removing the foll

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 2:46 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)->handle&& (r)->handle->status == MYSQL_STATUS_USE_RESULT) || ((r)->data == NULL)) When I step through your code, r->data

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
Stas, On 09/06/2011 06:55 PM, Stas Malyshev wrote: Hi! On 9/6/11 2:46 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)->handle&& (r)->handle->status == MYSQL_STATUS_USE_RESULT) || ((r)->da

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Stas Malyshev
Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)->handle&& (r)->handle->status == MYSQL_STATUS_USE_RESULT) || ((r)->data == NULL)) When I step through your code, r->dat

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 09:08 PM, Stas Malyshev wrote: Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)->handle&& (r)->handle->status == MYSQL_STATUS_USE_RESULT) || ((r)->data ==

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/mysqli/tests/bug55582.phpt trunk/ext/mysqli/tests/bug55582.phpt

2011-09-06 Thread Andrey Hristov
On 09/06/2011 09:54 PM, Andrey Hristov wrote: On 09/06/2011 09:08 PM, Stas Malyshev wrote: Hi! On 9/6/11 11:05 AM, Andrey Hristov wrote: I've looked into mysqli_result_is_unbuffered_and_not_everything_is_fetched() and it looks like for libmysql it checks this: (((r)->handle&& (r)->handle->stat

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/mysqli/mysqli_api.c branches/PHP_5_4/ext/mysqli/mysqli_api.c trunk/ext/mysqli/mysqli_api.c

2011-09-19 Thread Ferenc Kovacs
> > Good point, are you proposing to change code and make libmysql 5.0+ a > requirement? If so, several changes should be made to ext/mysql, ext/mysqli > and PDO_MySQL. > I think that it is your call, but yes, I think it would reasonable, and it would make our/your work much easier if we would hav

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/mysqli/mysqli_api.c branches/PHP_5_4/ext/mysqli/mysqli_api.c trunk/ext/mysqli/mysqli_api.c

2011-09-19 Thread Johannes Schlüter
On Mon, 2011-09-19 at 12:25 +0200, Ferenc Kovacs wrote: > > > > Good point, are you proposing to change code and make libmysql 5.0+ a > > requirement? If so, several changes should be made to ext/mysql, ext/mysqli > > and PDO_MySQL. > > > > I think that it is your call, but yes, I think it would r

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/mysqli/mysqli_api.c branches/PHP_5_4/ext/mysqli/mysqli_api.c trunk/ext/mysqli/mysqli_api.c

2011-10-07 Thread Ferenc Kovacs
2011/9/19 Johannes Schlüter : > On Mon, 2011-09-19 at 12:25 +0200, Ferenc Kovacs wrote: >> > >> > Good point, are you proposing to change code and make libmysql 5.0+ a >> > requirement? If so, several changes should be made to ext/mysql, ext/mysqli >> > and PDO_MySQL. >> > >> >> I think that it is

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/ basic_functions.c basic_functions.h html.c html.h html_tables/ents_basic.txt html_tables/ents_basic_apos.txt html_tables/ents_html401.txt

2010-10-26 Thread Geoffrey Sneddon
On 24/10/10 16:01, Gustavo André dos Santos Lopes wrote: cataphract Sun, 24 Oct 2010 15:01:02 + Revision: http://svn.php.net/viewvc?view=revision&revision=304705 Log: > […] - For html_entity_decode(), only valid numerical and named entities (as defined abo

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ext/standard/ basic_functions.c basic_functions.h html.c html.h html_tables/ents_basic.txt html_tables/ents_basic_apos.txt html_tables/ents_html401.

2010-10-26 Thread Gustavo Lopes
On Tue, 26 Oct 2010 17:34:44 +0100, Geoffrey Sneddon wrote: On 24/10/10 16:01, Gustavo André dos Santos Lopes wrote: cataphract Sun, 24 Oct 2010 15:01:02 + Revision: http://svn.php.net/viewvc?view=revision&revision=304705 Log: > […] - For html_entity_dec

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/standard/tests/strings/htmlentities15.phpt trunk/ext/standard/tests/strings/htmlentities15.phpt

2011-08-31 Thread Gustavo Lopes
On Wed, 31 Aug 2011 07:39:43 +0100, Stas Malyshev wrote: Hi! On 8/30/11 11:32 PM, Gustavo André dos Santos Lopes wrote: cataphract Wed, 31 Aug 2011 06:32:05 + Revision: http://svn.php.net/viewvc?view=revision&revision=315851 Log: - Fixed test htmlentities

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING.INTERNALS ext/standard/basic_functions.c ext/standard/basic_functions.h main/php_streams.h main/streams/memory.c main/streams/streams.c

2010-11-14 Thread Kalle Sommer Nielsen
Hi 2010/11/15 Gustavo André dos Santos Lopes : > cataphract                               Mon, 15 Nov 2010 03:05:32 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=305346 > > Log: > - Added leak_variable() function. Why do we need a leak_variable() function in a regular build

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/calendar/tests/easter_date.phpt branches/PHP_5_4/ext/calendar/tests/easter_date.phpt trunk/ext/calendar/tests/easter_date.phpt

2011-09-22 Thread Ferenc Kovacs
Derick, could you look into this? I think that the easter_days should take the date.timezone account when calculating a timestamp On Thu, Sep 22, 2011 at 10:59 PM, Ferenc Kovacs wrote: > tyrael                                   Thu, 22 Sep 2011 20:59:10 + > > Revision: http://svn.php.net/view

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/calendar/tests/easter_date.phpt branches/PHP_5_4/ext/calendar/tests/easter_date.phpt trunk/ext/calendar/tests/easter_date.phpt

2011-09-22 Thread Ferenc Kovacs
ext/intl/tests/dateformat_parse.phpt seems also affected by this: http://news.php.net/php.cvs/66617 On Thu, Sep 22, 2011 at 11:06 PM, Ferenc Kovacs wrote: > Derick, could you look into this? > I think that the easter_days should take the date.timezone account > when calculating a timestamp > > On

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING.INTERNALS ext/standard/basic_functions.c ext/standard/basic_functions.h main/php_streams.h main/streams/memory.c main/streams/streams.c

2010-11-15 Thread Felipe Pena
Em 15 de novembro de 2010 14:49, Gustavo Lopes escreveu: > On Mon, 15 Nov 2010 08:25:44 +0100, Kalle Sommer Nielsen > wrote: > > Hi > > > > 2010/11/15 Gustavo André dos Santos Lopes : > >> cataphract Mon, 15 Nov 2010 03:05:32 > + > >> > >> Revision: http://svn.ph

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING.INTERNALS ext/standard/basic_functions.c ext/standard/basic_functions.h main/php_streams.h main/streams/memory.c main/streams/streams.c

2010-11-16 Thread Gustavo Lopes
On Mon, 15 Nov 2010 08:25:44 +0100, Kalle Sommer Nielsen wrote: 2010/11/15 Gustavo André dos Santos Lopes : cataphract Mon, 15 Nov 2010 03:05:32 + Revision: http://svn.php.net/viewvc?view=revision&revision=305346 Log: - Added leak_variable() function. Why

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_2/NEWS branches/PHP_5_2/Zend/zend_builtin_functions.c branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_builtin_functions.c trunk/Zend/zend_bui

2009-12-30 Thread Johannes Schlüter
Hi, On Wed, 2009-12-30 at 19:15 +, Ilia Alshanetsky wrote: > iliaaWed, 30 Dec 2009 19:15:11 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=292823 > > Log: > Fixed bug #44827 (define() allows :: in constant names). > > Bug: http://bu

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_2/NEWS branches/PHP_5_2/Zend/zend_builtin_functions.c branches/PHP_5_3/NEWS branches/PHP_5_3/Zend/zend_builtin_functions.c trunk/Zend/zend_bui

2009-12-31 Thread Ilia Alshanetsky
The change is specific to :: since that is used for classes and causes confusion as people may think foo::bar will allow definition or re-definition of a class constant which it does not. On 09-12-30 2:42 PM, Johannes Schlüter wrote: > Hi, > > On Wed, 2009-12-30 at 19:15 +, Ilia Alshanetsky w

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tests/r

2011-09-11 Thread Ferenc Kovacs
On Sat, Sep 10, 2011 at 8:46 PM, Stas Malyshev wrote: > Hi! >> >> care to comment? > > It looks like neither me nor others (inluding gcov machine) are getting that > message. > AFAIK you shoud get it(as I did on my debian machines), as both display_startup_errors and error_reporting is force enab

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tests/r

2011-09-11 Thread Stas Malyshev
Hi! On 9/11/11 8:44 AM, Ferenc Kovacs wrote: AFAIK you shoud get it(as I did on my debian machines), as both display_startup_errors and error_reporting is force enabled for the tests: http://svn.php.net/viewvc/php/php-src/trunk/run-tests.php?view=markup#l232 http://svn.php.net/viewvc/php/php-src

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tests/r

2011-09-11 Thread Ferenc Kovacs
On Sun, Sep 11, 2011 at 11:04 PM, Stas Malyshev wrote: > Hi! > > On 9/11/11 8:44 AM, Ferenc Kovacs wrote: >> >> AFAIK you shoud get it(as I did on my debian machines), as both >> display_startup_errors and error_reporting is force enabled for the >> tests: >> http://svn.php.net/viewvc/php/php-src/

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-12 Thread Alexey Shein
Hello, these tests fail for me too, ubuntu 11.04 x86, both trunk and 5.4 branches. 2011/9/12 Ferenc Kovacs : > On Sun, Sep 11, 2011 at 11:04 PM, Stas Malyshev > wrote: >> Hi! >> >> On 9/11/11 8:44 AM, Ferenc Kovacs wrote: >>> >>> AFAIK you shoud get it(as I did on my debian machines), as both >>

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-12 Thread Ferenc Kovacs
I forget to reply-all to the list :/ On Mon, Sep 12, 2011 at 7:46 PM, Stas Malyshev wrote: > Hi! > > On 9/12/11 3:14 AM, Ferenc Kovacs wrote: >> >> you should pass both -n and -c as the make test pass those to the >> run-tests.php AFAIK, see: > > That's not what I see happening. > >> as I mention

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-13 Thread Alexey Shein
Just wanted to say, that I managed to reproduce your results for ./PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt by adding date.timezone=UTC error_log=file settings into --INI-- section, this way test passes. I.e. logged message should go into the file and do not mess the output which is

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-13 Thread Ferenc Kovacs
After a discussion on irc, I was thinking about something similar: adding my patch back, but adding -error-log to the --INI-- Stas, I still don't know why do have a custom php.ini, and why is it used. The make test should create tmp-php.ini for you (and copy your additional ini files there if you p

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-13 Thread Stas Malyshev
Hi! On 9/13/11 7:49 AM, Ferenc Kovacs wrote: Stas, I still don't know why do have a custom php.ini, and why is it used. The make test should create tmp-php.ini for you (and copy your Everybody has custom php.ini, what do you mean "why"? Nobody uses just defaults. It is used because -n -c is n

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-13 Thread Pierre Joye
hi, On Tue, Sep 13, 2011 at 6:23 PM, Stas Malyshev wrote: > Hi! > > On 9/13/11 7:49 AM, Ferenc Kovacs wrote: >> >> Stas, I still don't know why do have a custom php.ini, and why is it used. >> The make test should create tmp-php.ini for you (and copy your > > Everybody has custom php.ini, what do

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-13 Thread Ferenc Kovacs
On Tue, Sep 13, 2011 at 6:23 PM, Stas Malyshev wrote: > Hi! > > On 9/13/11 7:49 AM, Ferenc Kovacs wrote: >> >> Stas, I still don't know why do have a custom php.ini, and why is it used. >> The make test should create tmp-php.ini for you (and copy your > > Everybody has custom php.ini, what do you

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-13 Thread Stas Malyshev
Hi! On 9/13/11 11:04 AM, Ferenc Kovacs wrote: as I mentioned before, make test (at least it should) passes the -n -c argument to run-tests.php see http://svn.php.net/viewvc/php/php-src/trunk/Makefile.global?view=markup#l104 which means if you run make test that can produce different result, than

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-13 Thread Ferenc Kovacs
On Tue, Sep 13, 2011 at 8:23 PM, Stas Malyshev wrote: > Hi! > > On 9/13/11 11:04 AM, Ferenc Kovacs wrote: >> >> as I mentioned before, make test (at least it should) passes the -n -c >> argument to run-tests.php >> see >> http://svn.php.net/viewvc/php/php-src/trunk/Makefile.global?view=markup#l104

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-13 Thread Ferenc Kovacs
On Tue, Sep 13, 2011 at 8:23 PM, Stas Malyshev wrote: > Hi! > > On 9/13/11 11:04 AM, Ferenc Kovacs wrote: >> >> as I mentioned before, make test (at least it should) passes the -n -c >> argument to run-tests.php >> see >> http://svn.php.net/viewvc/php/php-src/trunk/Makefile.global?view=markup#l104

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-13 Thread Stas Malyshev
Hi! On 9/13/11 1:11 PM, Ferenc Kovacs wrote: Stas, I commited my patch again with the addition --INI-- setting: http://news.php.net/php.cvs/66511 could you test it? Passes for me. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227 -- PHP Intern

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-14 Thread Alexey Shein
2011/9/13 Ferenc Kovacs : > On Tue, Sep 13, 2011 at 6:23 PM, Stas Malyshev wrote: >> Hi! >> >> On 9/13/11 7:49 AM, Ferenc Kovacs wrote: >>> >>> Stas, I still don't know why do have a custom php.ini, and why is it used. >>> The make test should create tmp-php.ini for you (and copy your >> >> Everyb

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-14 Thread Ferenc Kovacs
> > Why do we even have this tmp-php.ini? Why not just make test without > any .ini files, i.e. just with -n option? [20:44:09] Tyrael: tmp-php.ini is built from the system ini [20:44:45] Tyrael: if he builds php with --with-config-file-scan-dir=/where/ever/he/has/another/php.ini, then it will u

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-14 Thread Alexey Shein
2011/9/14 Ferenc Kovacs : >> >> Why do we even have this tmp-php.ini? Why not just make test without >> any .ini files, i.e. just with -n option? > > [20:44:09] Tyrael: tmp-php.ini is built from the system ini > [20:44:45] Tyrael: if he builds php with > --with-config-file-scan-dir=/where/ever/he

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-14 Thread Richard Quadling
On 13 September 2011 17:27, Pierre Joye wrote: > hi, > > On Tue, Sep 13, 2011 at 6:23 PM, Stas Malyshev wrote: >> Hi! >> >> On 9/13/11 7:49 AM, Ferenc Kovacs wrote: >>> >>> Stas, I still don't know why do have a custom php.ini, and why is it used. >>> The make test should create tmp-php.ini for y

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-15 Thread Hannes Magnusson
On Wed, Sep 14, 2011 at 12:36, Alexey Shein wrote: > 2011/9/14 Ferenc Kovacs : >>> >>> Why do we even have this tmp-php.ini? Why not just make test without >>> any .ini files, i.e. just with -n option? >> >> [20:44:09] Tyrael: tmp-php.ini is built from the system ini >> [20:44:45] Tyrael: if he

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-15 Thread Pierre Joye
On Thu, Sep 15, 2011 at 12:07 PM, Hannes Magnusson wrote: > Running tests exclusively in an environment known to work doesn't help us. It indeed does, and much more than random failures in random environments. However it is not about one or the other, it is about both and about having as much t

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-16 Thread Alexey Shein
2011/9/15 Hannes Magnusson : > On Wed, Sep 14, 2011 at 12:36, Alexey Shein wrote: >> 2011/9/14 Ferenc Kovacs : Why do we even have this tmp-php.ini? Why not just make test without any .ini files, i.e. just with -n option? >>> >>> [20:44:09] Tyrael: tmp-php.ini is built from the sys

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings.phpt branches/PHP_5_4/ext/session/tests/rfc1867_invalid_settings_2.phpt trunk/ext/session/tes

2011-09-26 Thread Ferenc Kovacs
I've just noticed that we had a related bugreport, I thought that I should mention it: https://bugs.php.net/bug.php?id=55479 -- Ferenc Kovács @Tyr43l - http://tyrael.hu -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/zlib/php_zlib.h branches/PHP_5_4/ext/zlib/zlib.c trunk/ext/zlib/php_zlib.h trunk/ext/zlib/zlib.c

2011-12-26 Thread Remi Collet
Le 26/12/2011 09:29, Stanislav Malyshev a écrit : > stas Mon, 26 Dec 2011 08:29:11 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=321406 ZTS build is broken (snapshot 201112261030) Please see trivial attached patch Regards, Remi. diff -

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING.INTERNALS ext/standard/basic_functions.c ext/standard/basic_funct ions.h main/php_streams.h main/streams/memory.c m ain/streams/streams.c

2010-11-15 Thread Gustavo Lopes
On Mon, 15 Nov 2010 08:25:44 +0100, Kalle Sommer Nielsen wrote: > Hi > > 2010/11/15 Gustavo André dos Santos Lopes : >> cataphract                               Mon, 15 Nov 2010 03:05:32 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=305346 >> >> Log: >> - Added leak_varia

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWSbranches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32branches/PHP_5_4/ext/session/mod_user.c branches/PHP_5_4/e

2011-09-13 Thread Christian Stocker
Hi I still have this. even after re-running buildconf (and deleting configure before) On OS X and x86_64 Linux chregu On 14.09.11 05:31, Laruence wrote: > Hi: > after I re-run buildconf, error has gone > > sorry for mis-report. > > thanks > > 2011/9/14 Laruence : >> Hi: >>trunk build

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWSbranches/PHP_5_4/ext/session/config.m4 branches/PHP_5_4/ext/session/config.w32branches/PHP_5_4/ext/session/mod_user.c branches/PHP_5_4/e

2011-09-13 Thread Laruence
Hi, FYI, you might should delete the autom4te.cache folder too :-) thanks 2011/9/14 Christian Stocker : > Hi > > I still have this. even after re-running buildconf (and deleting > configure before) > > On OS X and x86_64 Linux > > chregu > > On 14.09.11 05:31, Laruence wrote: >> Hi: >>   after

<    1   2   3   >