Re: [PHP-DEV] [RFC] Throwable Interface

On Tue, Jun 16, 2015 at 1:41 AM, Marcio Almada wrote: > Hi, > > 2015-06-15 19:25 GMT-03:00 Aaron Piotrowski : > > > >> On Jun 15, 2015, at 4:02 PM, Anatol Belski > wrote: > >> I would then suggest Aaron to stick to the minimal voting period > (announcing this as early as possible), if the voting

Re: [PHP-DEV] [RFC] Throwable Interface

Hi, 2015-06-15 19:25 GMT-03:00 Aaron Piotrowski : > >> On Jun 15, 2015, at 4:02 PM, Anatol Belski wrote: >> I would then suggest Aaron to stick to the minimal voting period (announcing >> this as early as possible), if the voting passes - then merge the branch on >> Wednesday. This way we would

Re: [PHP-DEV] [RFC] Throwable Interface

> On Jun 15, 2015, at 4:02 PM, Anatol Belski wrote: > I would then suggest Aaron to stick to the minimal voting period (announcing > this as early as possible), if the voting passes - then merge the branch on > Wednesday. This way we would have nearly one week to test and do fixes in > master.

Re: [PHP-DEV] [RFC] Throwable Interface

I think REGISTER_INTERFACE() macro in zend_interfaces.h is better. Actually, it's not related to ITERATORs at all. Thanks. Dmitry. On Tue, Jun 16, 2015 at 12:48 AM, Aaron Piotrowski wrote: > > On Jun 15, 2015, at 9:53 AM, Dmitry Stogov wrote: > > On Mon, Jun 15, 2015 at 4:55 PM, Aaron Piotrow

Re: [PHP-DEV] [RFC] Throwable Interface

> On Jun 15, 2015, at 9:53 AM, Dmitry Stogov wrote: > > On Mon, Jun 15, 2015 at 4:55 PM, Aaron Piotrowski > wrote: > >> >> On Jun 15, 2015, at 6:56 AM, Anatol Belski > > wrote: >> >> Would you like me to move zend_ce_throwable to zend_exc

RE: [PHP-DEV] [RFC] Throwable Interface

> -Original Message- > From: Nikita Popov [mailto:nikita@gmail.com] > Sent: Monday, June 15, 2015 10:36 PM > To: Dmitry Stogov > Cc: Aaron Piotrowski; Anatol Belski; PHP Internals > Subject: Re: [PHP-DEV] [RFC] Throwable Interface > > On Mon, Jun 15, 2015 a

Re: [PHP-DEV] [RFC] Throwable Interface

mitry Stogov [mailto:dmi...@zend.com ] >> Sent: Monday, June 15, 2015 10:53 AM >> To: Aaron Piotrowski >> Cc: Anatol Belski; PHP Internals >> Subject: Re: [PHP-DEV] [RFC] Throwable Interface >> >> Hi, >> >> I made a quick code review, and I don

Re: [PHP-DEV] [RFC] Throwable Interface

ki > Cc: Anatol Belski; PHP Internals > Subject: Re: [PHP-DEV] [RFC] Throwable Interface > > Hi, > > I made a quick code review, and I don't see any technical problems in > implementation. > > 1) Anyway, I think it's a bad idea to rename "EngineException"

Re: [PHP-DEV] [RFC] Throwable Interface

> On Jun 15, 2015, at 6:56 AM, Anatol Belski wrote: > > Hi Dmitry, > >> -Original Message- >> From: Dmitry Stogov [mailto:dmi...@zend.com] >> Sent: Monday, June 15, 2015 10:53 AM >> To: Aaron Piotrowski >> Cc: Anatol Belski; PHP Internals

RE: [PHP-DEV] [RFC] Throwable Interface

Hi Dmitry, > -Original Message- > From: Dmitry Stogov [mailto:dmi...@zend.com] > Sent: Monday, June 15, 2015 10:53 AM > To: Aaron Piotrowski > Cc: Anatol Belski; PHP Internals > Subject: Re: [PHP-DEV] [RFC] Throwable Interface > > Hi, > > I made a quick co

Re: [PHP-DEV] [RFC] Throwable Interface

Hi, I made a quick code review, and I don't see any technical problems in implementation. 1) Anyway, I think it's a bad idea to rename "EngineException" (and others) into "Error"(s). This will prevent using class "Error" in applications, and may potentially break some of them. I also don't like r

Re: [PHP-DEV] [RFC] Throwable Interface

> On Jun 14, 2015, at 11:31 AM, Anatol Belski wrote: > > Hi Dmitry, > > > > I would go by accepting this. Furthermore – if you feel that the > implementation is stable enough and does not BC, I would suggest to have it > already in the alpha2. > > > > As there seems to be at all no resis

RE: [PHP-DEV] [RFC] Throwable Interface

reverted in the worst case. What do you think? Regards Anatol From: Dmitry Stogov [mailto:dmi...@zend.com] Sent: Wednesday, June 10, 2015 9:37 AM To: Levi Morrison; Aaron Piotrowski; Nikita Popov Cc: internals; Anatol Belski; Kalle Sommer Nielsen Subject: Re: [PHP-DEV] [RFC] Throwable

Re: [PHP-DEV] [RFC] Throwable Interface

>> some non-fatals were converted (TypeException) > > > There was no equivalent to TypeException in previous versions of PHP, so in > what sense has it been "converted"? Maybe I'm being thick and there's a > situation that has been, but the only type-related error I know of was > type-hinting class

Re: [PHP-DEV] [RFC] Throwable Interface

Levi Morrison wrote on 10/06/2015 15:37: We have code that previously triggered error handlers or got caught by exceptions and now will not trigger the handler nor get caught. AFAIK, the only things which are going to not inherit from Exception were things which didn't inherit from Exception i

Re: [PHP-DEV] [RFC] Throwable Interface

> On Jun 10, 2015, at 2:37 AM, Dmitry Stogov wrote: > > I also like EngineException more than Error. > I think EngineException has a couple of problems with it: 1) EngineException doesn’t really accurately represent the reason for the error. For example, passing the wrong type to a function

Re: [PHP-DEV] [RFC] Throwable Interface

>> 3. I think they should all use Exception as the root instead having >> a new root with multiple children (and yes, I am aware of the impact >> of this, and it has already been discussed on this list). > > > This done on purpose. To prevent catching of new exceptions by old PHP code. We have c

Re: [PHP-DEV] [RFC] Throwable Interface

On Tue, Jun 9, 2015 at 9:13 PM, Levi Morrison wrote: > On Tue, Jun 9, 2015 at 11:40 AM, Aaron Piotrowski wrote: > > Does anyone have any questions, comments, or concerns about the > Throwable Interface RFC? > > > > http://wiki.php.net/rfc/throwable-interface > > > > The proposed exception hierar

Re: [PHP-DEV] [RFC] Throwable Interface

Hello :-), At Hoa, we are totally in favor or this RFC. We tried to make our exception hierarchy compatible with PHP7 with success but it was very difficult to make it backward compatible. With this proposal, all our problems are going to be solved, so +1 for us! On 23/05/15 22:12, Aaron Pio

Re: [PHP-DEV] [RFC] Throwable Interface

Hi! On 6/9/15 10:40 AM, Aaron Piotrowski wrote: > Does anyone have any questions, comments, or concerns about the Throwable > Interface RFC? > > http://wiki.php.net/rfc/throwable-interface > > The proposed exception hierarchy: > > interface Throwable > ⊢ Exception implements Throwable >

Re: [PHP-DEV] [RFC] Throwable Interface

Hi all, On Tue, May 26, 2015 at 3:02 AM, Rowan Collins wrote: > On 24/05/2015 22:32, Yasuo Ohgaki wrote: > >> Does this include internal function type errors? >> e.g. >> >> $ php -r 'var_dump(mt_srand("999"));' >> PHP Warning: mt_srand() expects parameter 1 to be

Re: [PHP-DEV] [RFC] Throwable Interface

> On Jun 9, 2015, at 1:13 PM, Levi Morrison wrote: > > My only objections have already been raised, but I'll reiterate them briefly: > > 1. Having both Error and Exception makes little sense, especially > since we have historically used error to refer to an error that wasn't > an exception (so

Re: [PHP-DEV] [RFC] Throwable Interface

On Tue, Jun 9, 2015 at 11:40 AM, Aaron Piotrowski wrote: > Does anyone have any questions, comments, or concerns about the Throwable > Interface RFC? > > http://wiki.php.net/rfc/throwable-interface > > The proposed exception hierarchy: > > interface Throwable > ⊢ Exception implements Thro

Re: [PHP-DEV] [RFC] Throwable Interface

Does anyone have any questions, comments, or concerns about the Throwable Interface RFC? http://wiki.php.net/rfc/throwable-interface The proposed exception hierarchy: interface Throwable ⊢ Exception implements Throwable ∟ Error implements Throwable (replaces EngineException)

Re: [PHP-DEV] [RFC] Throwable Interface

On 24/05/2015 22:32, Yasuo Ohgaki wrote: Does this include internal function type errors? e.g. $ php -r 'var_dump(mt_srand("999"));' PHP Warning: mt_srand() expects parameter 1 to be integer, string given in Command line code on line 1 NULL If not, please make t

Re: [PHP-DEV] [RFC] Throwable Interface

On 05/24/2015 11:32 PM, Yasuo Ohgaki wrote: Hi Aaron, On Sun, May 24, 2015 at 5:12 AM, Aaron Piotrowski wrote: I’ve created an RFC for modifying the exception hierarchy for PHP 7, adding Throwable interface and renaming the exceptions thrown from fatal errors. The RFC is now ready for discu

Re: [PHP-DEV] [RFC] Throwable Interface

On 05/24/2015 10:11 PM, Aaron Piotrowski wrote: On May 24, 2015, at 2:08 PM, Marc Bennewitz wrote: Where are the new classes and the interface located if it's not in the global namespace or do I muss something? Sorry if what I wrote wasn’t clear. Throwable, Error, TypeError, and ParseErro

Re: [PHP-DEV] [RFC] Throwable Interface

Hi Aaron, On Sun, May 24, 2015 at 5:12 AM, Aaron Piotrowski wrote: > I’ve created an RFC for modifying the exception hierarchy for PHP 7, > adding Throwable interface and renaming the exceptions thrown from fatal > errors. The RFC is now ready for discussion. > > RFC: https://wiki.php.net/rfc/th

Re: [PHP-DEV] [RFC] Throwable Interface

> On May 24, 2015, at 2:08 PM, Marc Bennewitz wrote: > > Where are the new classes and the interface located if it's not in the global > namespace or do I muss something? Sorry if what I wrote wasn’t clear. Throwable, Error, TypeError, and ParseError will be built-in interfaces/classes in the

Re: [PHP-DEV] [RFC] Throwable Interface

On 05/23/2015 10:12 PM, Aaron Piotrowski wrote: Hello, I’ve created an RFC for modifying the exception hierarchy for PHP 7, adding Throwable interface and renaming the exceptions thrown from fatal errors. The RFC is now ready for discussion. RFC: https://wiki.php.net/rfc/throwable-interface