Re: [PHP-DEV] Re: [VOTE] array_column() function

2013-01-14 Thread Scott MacVicar
On 14 Jan 2013, at 11:37, Ben Ramsey ram...@php.net wrote: On 1/11/13 6:17 PM, Ben Ramsey wrote: I've opened voting for the array_column() function RFC. You can vote at https://wiki.php.net/rfc/array_column#voting I have updated the pull request by removing the array_pluck() alias. I

Re: [PHP-DEV] Re: [VOTE] array_column() function

2013-01-14 Thread Scott MacVicar
On 14 Jan 2013, at 12:57, Ben Ramsey ram...@php.net wrote: On 1/14/13 11:54 AM, Scott MacVicar wrote: On 14 Jan 2013, at 11:37, Ben Ramsey ram...@php.net wrote: On 1/11/13 6:17 PM, Ben Ramsey wrote: I've opened voting for the array_column() function RFC. You can vote at https

Re: [PHP-DEV] [VOTE] Add simplified password hashing API

2012-09-12 Thread Scott MacVicar
Concerns about the RFC after talking with someone (Alok) on our security team at work. There is no requirement for them to be cryptographically secure. What stops the salt from being cryptographically secure? I think it should be a goal or we should state what parts aren't cryptographically

Re: [PHP-DEV] [DRAFT] RFC - array_column() function

2012-06-22 Thread Scott MacVicar
Hey Ben, On 22 Jun 2012, at 08:52, Ben Ramsey wrote: On 6/22/12 5:32 AM, Léo Peltier wrote: Hi, Shouldn't this be called 'array_pluck'? This is the name people usually use when implementing it in PHP (see array_pluck( vs array_column( in Google) or in other languages/libs (see

[PHP-DEV] Enforcing final in traits

2012-05-04 Thread Scott MacVicar
This caused a few bugs for us / confusion. The final keyword is accepted inside a trait but it the class also defines a method without the final keyword this takes precedence. Two solutions: Enforce final when a trait defines -

Re: [PHP-DEV] Running mhash tests

2011-09-14 Thread Scott MacVicar
On 14 Sep 2011, at 13:26, Pierre Joye wrote: hi, On Wed, Sep 14, 2011 at 9:58 PM, Alexey Shein con...@gmail.com wrote: Should we delete these tests (and, maybe deprecate/move to pecl the extension itself)? I don't think we should, they are here to make sure that the emulation layer

Re: [PHP-DEV] Running mhash tests

2011-09-14 Thread Scott MacVicar
On 14 Sep 2011, at 13:46, Alexey Shein wrote: 2011/9/15 Pierre Joye pierre@gmail.com: hi, On Wed, Sep 14, 2011 at 9:58 PM, Alexey Shein con...@gmail.com wrote: Should we delete these tests (and, maybe deprecate/move to pecl the extension itself)? I don't think we should, they are

Re: [PHP-DEV] 5.3.7 is breaking SSL

2011-08-23 Thread Scott MacVicar
On Aug 17, 2011, at 5:50 PM, Reindl Harald wrote: well i guess it is the change below this results in connections in hanging around and after a hughe timeout filling my mailbox with cron-mails: mysqlnd 5.0.8-dev - 20102224 - $Revision: 310735 $ without ssl_set() all works fine but

Re: [PHP-DEV] 5.3.7pl1

2011-08-20 Thread Scott MacVicar
On 19 Aug 2011, at 16:16, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! Looks like 5.3.7 shipped with broken crypt() (see bug# 55439 and http://svn.php.net/viewvc/?view=revisionamp;revision=315218) - and I think it's a serious problem since this means everybody's md5 passwords will stop

Re: [PHP-DEV] Coverity Scan

2011-08-08 Thread Scott MacVicar
On 6 Aug 2011, at 20:07, Rasmus Lerdorf wrote: Coverity has run a new scan of trunk and there are a lot of valid issues. You have probably noticed that I have started to fix some of them, but there are 500+ to go, so I could use some help. The following people already have Coverity accounts:

Re: [PHP-DEV] Re: json_encode option for not escaping unnecessary character

2011-08-04 Thread Scott MacVicar
Never got the email, will look today at it. Doesn't quite match our coding standards from the first glance. S On 4 Aug 2011, at 09:17, Александ Москалёвir...@irker.net wrote: I write to omar (ext author) and scottmac (bug owner) and not received a reply from they. Can someone else check

[PHP-DEV] Subverting OpenSSL library function with Windows alternatives

2011-07-19 Thread Scott MacVicar
Just noticed a commit from Pierre last week http://svn.php.net/viewvc?view=revisionrevision=313112 which changed OpenSSL to use a special Windows API call for gathering random data. I've reverted this change so we can discuss this further. I disagree with advertising a library function and

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-07-19 Thread Scott MacVicar
a standard set of random functions instead of this, as you well know. Now it is too late and we have to live with this function. While the set of random will surely come at some point too. On Wed, Jul 20, 2011 at 1:04 AM, Scott MacVicar sc...@macvicar.net wrote: Why isn't this fixed upstream

Re: [PHP-DEV] sockets broken in 5.4 on Mac OS X

2011-07-10 Thread Scott MacVicar
On Jul 10, 2011, at 4:21 PM, Stas Malyshev wrote: Hi! I was now building 5.4 on Mac with sockets enabled and got this: /Users/smalyshev/php-5.4/ext/sockets/multicast.c: In function ‘php_if_index_to_addr4’: /Users/smalyshev/php-5.4/ext/sockets/multicast.c:426: error: ‘struct ifreq’ has

Re: [PHP-DEV] sockets broken in 5.4 on Mac OS X

2011-07-10 Thread Scott MacVicar
On Jul 10, 2011, at 4:46 PM, Stas Malyshev wrote: Hi! On 7/10/11 4:23 PM, Scott MacVicar wrote: The code for this looks really convoluted, I'm thinking we should back out this multicast option for now. It's basically not going to work on OSX the way its implemented from what I can tell

[PHP-DEV] Migration of SVN commit access to SSL

2011-06-14 Thread Scott MacVicar
A few minutes ago I forced all commit access for svn.php.net to be over SSL, if you try to commit over regular HTTP you'll get a 403 error. Migrating from http to https is a single command. See: https://wiki.php.net/vcs/https-svn - Scott -- PHP Internals - PHP Runtime Development Mailing List

Re: [PHP-DEV] Bundling modern extensions

2011-06-05 Thread Scott MacVicar
Can't bundle geoip with the database due to the license on it. Would make it a pretty useless extension to have in that case. S On 5 Jun 2011, at 11:39, Olivier Hill olivier.h...@gmail.com wrote: Could you open a bug for GeoIP? Being aware of bugs helps more than bitching around. Thanks

Re: [PHP-DEV] Bundling modern extensions

2011-06-04 Thread Scott MacVicar
On Jun 4, 2011, at 4:57 PM, Stas Malyshev wrote: Hi! In parallel I'd also see if there are any key extensions which we think are mainstream, stable and well maintained enough to be included. For example, http comes to mind. Maybe also oauth? It's getting popular and widely used. OAuth

Re: [PHP-DEV] DOMNode::getAttribute()

2011-06-03 Thread Scott MacVicar
On Jun 3, 2011, at 1:38 PM, Matt Pelmear wrote: Hello, I discovered today that the DOMNode::getAttribute() function (which is undocumented on the php site) returns an empty string if the requested attribute doesn't exist in the node. From the source: if (value == NULL) {

Re: [PHP-DEV] INF behavior

2011-05-26 Thread Scott MacVicar
On 26 May 2011, at 20:03, Philip Olson phi...@roshambo.org wrote: Hello geeks, A geek is needed to clarify PHP bug #45712. This is an edge case but the test (bug45712.phpt) contains code similar to the following: ?php $inf = pow(0, -2); var_dump($inf); // float(INF)

Re: [PHP-DEV] embedded libmagic (from file)

2011-03-21 Thread Scott MacVicar
I have a diff sitting that I did yesterday that upgrades us to the latest libmagic, it supports the new magic file format and updates that bundle. But that's all. I'm also against allowing the non-php version. Yes it's a fork but unfortunately it's for the best. - Scott On 21 March 2011 10:12,

Re: [PHP-DEV] Allowing PHP to recognize a variant of Apache (bug #54084)

2011-03-17 Thread Scott MacVicar
Go for it :) On 17 March 2011 18:34, Christopher Jones christopher.jo...@oracle.comwrote: Does anyone have issues with a small version check change to the build system so that PHP installs cleanly on a variant of Apache? This would improve PHP install usability by allowing it to just work.

Re: [PHP-DEV] PHP development environment

2011-01-14 Thread Scott MacVicar
This is the wrong mailing list, this is about development of the PHP runtime and not towards development using PHP. - Scott On Jan 14, 2011, at 5:56 PM, Dallas Gutauckis wrote: Depending on the duration of development, I either use nano for short edits, or zend studio for a large project.

Re: [PHP-DEV] RFC - MACRO

2010-12-22 Thread Scott MacVicar
I really dislike this, what about resolving orders, then people will want undef, then ifdef with conditions. The language doesn't need to introduce anything that makes it more complex to use. - Scott On 22 Dec 2010, at 11:55, Mathias Grimm mathiasgr...@gmail.com wrote: I Just want a simple

Re: [PHP-DEV] Re: PHP Performance in Apache: Multi-Process vs Multi-Threaded

2010-12-16 Thread Scott MacVicar
On Dec 16, 2010, at 12:28 AM, jvlad wrote: No. Php if we talk about php with all its extensions is not threadsafe at all. Many of the extensions allocate static data and inherently non-thread-safe. PHP is, if compiled with ZTS/TSRM, thread-safe. Some libraries used by some extensions

Re: [PHP-DEV] GPU Acceleration

2010-11-12 Thread Scott MacVicar
Do you have a patch for this? The only thing stopping it is no one had written it. - Scott On Nov 12, 2010, at 3:23 PM, Kenan Sulayman wrote: Hello out there! I just asked myself, just like that: Why shouldn't it be possible to create a php-work flow which allows the immediate

Re: [PHP-DEV] GPU Acceleration

2010-11-12 Thread Scott MacVicar
On Nov 12, 2010, at 4:09 PM, Stefan Marr wrote: Hi: On 12 Nov 2010, at 16:35, Scott MacVicar wrote: Do you have a patch for this? The only thing stopping it is no one had written it. So, I'd thank you for *constructive* answers. *sigh* He was asking for constructive answers. What's

Re: [PHP-DEV] rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2010-10-29 Thread Scott MacVicar
On Oct 29, 2010, at 6:17 PM, admin wrote: On 10/29/2010 08:11 PM, William A. Rowe Jr. wrote: On 10/29/2010 7:47 PM, admin wrote: WTF is T_PAAMAYIM_NEKUDOTAYIM? This has to be THE most asked question by new php developers when they come across it. Can we please change the token name

Re: [PHP-DEV] Annoucing PHP 5.4 Alpha 1

2010-08-10 Thread Scott MacVicar
On Aug 10, 2010, at 3:11 PM, Johannes Schlüter wrote: On Wed, 2010-08-11 at 00:03 +0200, Kalle Sommer Nielsen wrote: type hinting For the record: I consider the current implementation as (one of) the biggest mistakes in the last ten years. johannes I'm happy to see a more strict

Re: [PHP-DEV] PKCS#11 support

2010-07-20 Thread Scott MacVicar
On Jul 20, 2010, at 12:51 AM, Paul van Brouwershaven wrote: Hi Scott, Op 20-7-2010 0:28, Scott MacVicar schreef: It can be released on the PECL site but I doubt it would go in the default distribution. Why not including this in the default distribution? It would be great to have PKCS

Re: [PHP-DEV] PKCS#11 support

2010-07-19 Thread Scott MacVicar
It can be released on the PECL site but I doubt it would go in the default distribution. - Scott On 19 Jul 2010, at 14:49, Tomasz Wyderka wyderk...@googlemail.com wrote: Hi, I'm planning to write PKCS#11 extension for PHP using OpenSC library. PKCS#11 is a software API for accessing

Re: [PHP-DEV] SVN Account Request: stealth35

2010-07-09 Thread Scott MacVicar
You don't need an SVN account to start helping improve PHP. Patch can be mailed to the list or the other appropriate list for review first. - Scott On Jul 9, 2010, at 8:34 AM, stealth35 wrote: Improve php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit:

Re: [PHP-DEV] Single-line comment problem

2010-07-08 Thread Scott MacVicar
Yeah because /* */ has a clear end where // and # doesn't. - S On 8 Jul 2010, at 12:50, jvlad d...@yandex.ru wrote: Parsing ends with ? regardless if its a comment or not but its not context sensitive. It can't understand that its within a string. - S Not exactly, it's only // comment

Re: [PHP-DEV] Single-line comment problem

2010-07-07 Thread Scott MacVicar
The scanner is looking for \r \n % if ASP tags are enabled or ? before it marks the end of the comment. Take the following ?php echo 'PHP'; // echo $moo; ? I am HTML, hear me roar! Parsing ends with ? regardless if its a comment or not but its not context sensitive. It can't understand that

Re: [PHP-DEV] SVN Account Request: kevinrr3

2010-07-04 Thread Scott MacVicar
This is for access to the PHP language repository. You don't need an account to use PHP. Scott On 4 Jul 2010, at 14:00, Kevin Raap kev...@live.nl wrote: Programming with partner without destroying each others code -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] SVN Account Request: johnyp

2010-06-28 Thread Scott MacVicar
What code? You only need a SVN account if you have something to contribute to the PHP runtime. - Scott On Jun 28, 2010, at 8:03 AM, johny pukhramba, wrote: Maintaining my code for group of people working together on the same latest code. -- PHP Internals - PHP Runtime Development

Re: [PHP-DEV] APC in trunk

2010-06-21 Thread Scott MacVicar
On Jun 20, 2010, at 10:06 PM, Rasmus Lerdorf wrote: On 6/20/10 7:55 PM, Scott MacVicar wrote: On Jun 20, 2010, at 11:21 AM, Ilia Alshanetsky wrote: I for one think it is a really good idea, there is no compelling reason not to include APC, I would even go as far as say we should enable

Re: [PHP-DEV] APC in trunk

2010-06-20 Thread Scott MacVicar
On Jun 20, 2010, at 11:21 AM, Ilia Alshanetsky wrote: I for one think it is a really good idea, there is no compelling reason not to include APC, I would even go as far as say we should enable it by default. +1 We'd need to get http://wiki.php.net/rfc/zendsignals committed before we even

Re: [PHP-DEV] Remove sqlite2 from trunk

2010-06-18 Thread Scott MacVicar
On Jun 18, 2010, at 10:50 AM, Jonathan Bond-Caron wrote: On Wed Jun 16 07:04 AM, Ilia Alshanetsky wrote: drop the Sqlite2 extensions from Trunk as they are superseded by the Sqlite3 extensions. The sqlite2 library is no longer maintainer and the migration path from version 2 to 3 is very

Re: [PHP-DEV] What gruntwork needs to be done

2010-04-06 Thread Scott MacVicar
On Apr 6, 2010, at 10:34 AM, Rasmus Lerdorf wrote: On 04/06/2010 10:08 AM, Justin Dearing wrote: So pending review an acceptance by Dmitry, I've written my first patch for PHP. While there is a good chance I will need to make further revisions to the test or code, I don't know what that is.

Re: [PHP-DEV] What gruntwork needs to be done

2010-04-06 Thread Scott MacVicar
On Apr 6, 2010, at 10:54 AM, Rasmus Lerdorf wrote: On 04/06/2010 10:47 AM, Scott MacVicar wrote: On Apr 6, 2010, at 10:34 AM, Rasmus Lerdorf wrote: On 04/06/2010 10:08 AM, Justin Dearing wrote: So pending review an acceptance by Dmitry, I've written my first patch for PHP. While

Re: [PHP-DEV] SVN Account Request: ariva

2010-03-12 Thread Scott MacVicar
You contribute some patches first to internals and after that's been done a few times we give out an SVN account. Scott On 12 Mar 2010, at 19:01, Arunas Ivanauskas arunas.ivanaus...@gmail.com wrote: Fixing bugs, developing the PHP runtime, can contribute ~10h/w -- PHP Internals - PHP

Re: [PHP-DEV] Re: svn: /php/php-src/branches/PHP_5_3/ README.NEW-OUTPUT-API Zend/zend_highlight.c Zend/zend_indent.c ext/iconv/iconv.c ext/session/session.c ext/soap/soap.c ext/standard/basic_functi

2010-03-11 Thread Scott MacVicar
On Mar 11, 2010, at 10:22 AM, Jani Taskinen wrote: On 03/11/2010 04:41 PM, Lukas Kahwe Smith wrote: @jani: committing to a stable branch because you are getting a new laptop is not really a convincing argument. :) Losing the one with the changes in it is. Doing patches will only cause

Re: [PHP-DEV] Unserialize is broken

2010-03-01 Thread Scott MacVicar
Java has a transient keyword to skip serialising a property and I have a patch against 5.3 on http://whisky.macvicar.net/patches/ It might make it in to 5.4/6/next once I get some more free time. Scott On 1 Mar 2010, at 02:10, Jordi Boggiano j.boggi...@seld.be wrote: On 01.03.2010 10:31,

Re: [PHP-DEV] Re: [DOC-BUGS] #50634 [Opn-Asn]: 'Core' introduced in 5.3.1

2010-01-04 Thread Scott MacVicar
On Mon, Jan 4, 2010 at 12:49 PM, Richard Quadling rquadl...@googlemail.com wrote: I can see that the key went from internal to mhash at V5.3.0 and from mhash to Core at V5.3.1 on Windows. Is this also true for non-windows please? http://bugs.php.net/bug.php?id=50634 says Windows or linux,

Re: [PHP-DEV] A patch for bug 44331

2009-12-09 Thread Scott MacVicar
The JSON API is exported and can't change it as it breaks the ABI. I know the memcached extension uses this. I'll look into adding something similar this week, thanks for the patch. S On 9 Dec 2009, at 21:54, Florian Anderiasch wrote: bug_44331.patch -- PHP Internals - PHP Runtime

Re: [PHP-DEV] A patch for bug 44331

2009-12-09 Thread Scott MacVicar
Ignore me, it's fine and I'll apply it soon. S On 9 Dec 2009, at 21:58, Scott MacVicar wrote: The JSON API is exported and can't change it as it breaks the ABI. I know the memcached extension uses this. I'll look into adding something similar this week, thanks for the patch. S On 9

Re: [PHP-DEV] No core file being created

2009-11-10 Thread Scott MacVicar
On 10 Nov 2009, at 13:55, Mark Skilbeck wrote: I'm trying to debug a segfault that's occuring in an extension I'm developing (phpgksu - PHP wrapper for libgksu2). On the PHP site it says that if I have PHP configured with --enable-debug (which I do) then whenever PHP crashes a core file

Re: [PHP-DEV] typo found in ext/standard/string.c, inside function nl2br, php 5.3.0 svn trunk

2009-11-06 Thread Scott MacVicar
On 6 Nov 2009, at 03:18, daqing wrote: hi, all: I just found a typo today when I read the source code of function nl2br, here is what 'svn diff' produce against the php 5.3.0 svn trunk: Index: ext/standard/string.c === ---

Re: [PHP-DEV] Seg fault when using active_symbol_table called from userspace function.

2009-11-01 Thread Scott MacVicar
On 1 Nov 2009, at 21:09, Mark Skilbeck markskilb...@gmail.com wrote: Can you explain to me why the following causes a segfault: [code] PHP_FUNCTION(sample_var_a_exists) { if (!zend_hash_exists(EG(active_symbol_table), a, sizeof(a))) { RETURN_BOOL(0); } RETURN_BOOL(1); } [/code]

Re: [PHP-DEV] Seg fault when using active_symbol_table called from userspace function.

2009-11-01 Thread Scott MacVicar
On 1 Nov 2009, at 21:41, Mark Skilbeck wrote: Scott MacVicar wrote: On 1 Nov 2009, at 21:09, Mark Skilbeck markskilb...@gmail.com wrote: [snip] There is no symbol table as there are no variables. You should check if it's NULL before using zend_hash_exists. Scott Hi, Scott. I'm having

Re: [PHP-DEV] Secure SVN access

2009-09-03 Thread Scott MacVicar
On 3 Sep 2009, at 13:48, techtonik wrote: Greeetings to php-core developers, Am I right that there is no https:// and svn+ssh:// access to svn.php.net repositories? If that's the case - how do you feel about sniffing developer's passwords? We use Digest authentication so while they are

Re: [PHP-DEV] Can't use embeded sapi

2009-08-09 Thread Scott MacVicar
On 9 Aug 2009, at 22:52, Farley Knight wrote: On Mon, Jul 13, 2009 at 7:17 PM, Paul Biggarpaul.big...@gmail.com wrote: Hi Thomas, On Mon, Jul 13, 2009 at 9:15 PM, Thomas Kochtho...@koch.ro wrote: gcc -c -I/usr/local/include/php/ -I/usr/local/include/php/main - I/usr/local/include/php/Zend

Re: [PHP-DEV] fopen_wrappers.c DOCUMENT_ROOT .htaccess error

2009-08-03 Thread Scott MacVicar
On 4 Aug 2009, at 00:08, dan...@zoltak.com wrote: Quoting Jani Taskinen jani.taski...@sci.fi: Yes. You shouldn't really do it like that. Unpack it in separate directory. And build outside the sources: # tar zxfv php5.2-x.tar.gz # mkdir php_5_2 # cd php_5_2 # ../php5.2-x/configure

Re: [PHP-DEV] fopen_wrappers.c DOCUMENT_ROOT .htaccess error

2009-08-03 Thread Scott MacVicar
On 4 Aug 2009, at 03:14, dan...@zoltak.com wrote: Quoting Jani Taskinen jani.taski...@sci.fi: Yes. You shouldn't really do it like that. Unpack it in separate directory. And build outside the sources: # tar zxfv php5.2-x.tar.gz # mkdir php_5_2 # cd php_5_2 # ../php5.2-x/configure

Re: [PHP-DEV] fopen_wrappers.c DOCUMENT_ROOT .htaccess error

2009-08-03 Thread Scott MacVicar
On 4 Aug 2009, at 04:49, dan...@zoltak.com wrote: Quoting Scott MacVicar sc...@macvicar.net: 1. Is it safe to lookup the DOCUMENT_ROOT in fopen_wrappers. If not is there an alternative? Not at the point the function is being executed on a fresh child start PHP hasn't always been fully

Re: [PHP-DEV] fopen_wrappers.c DOCUMENT_ROOT .htaccess error

2009-08-03 Thread Scott MacVicar
On 4 Aug 2009, at 05:36, dan...@zoltak.com wrote: Quoting dan...@zoltak.com: Quoting Scott MacVicar sc...@macvicar.net: [snip] Do you know the first version it stopped working? 5.2.7 - 5.2.10 is about 15 months worth of bug fixes. Narrowing it down to a particular version would help

Re: [PHP-DEV] $_SERVER keys in PHP 6

2009-07-25 Thread Scott MacVicar
On 26 Jul 2009, at 01:25, Greg Beaver wrote: Hi, In PHP 6, is there a reason all of the keys in $_SERVER are binary except for PHP_SELF, which is unicode? The ones that come from the SAPI the end up binary, the ones added internally by PHP end up with unicode keys because we can guarantee

Re: [PHP-DEV] post 5.3.0 development

2009-06-26 Thread Scott MacVicar
On 26 Jun 2009, at 16:26, Lukas Kahwe Smith wrote: Aloha, So the last fix is just being prepared for a commit and so we will be tagging 5.3.0 soon. We would like to up hold the commit freeze until 5.3.0 is announced next Tuesday. This freeze that you guys have implemented is

Re: [PHP-DEV] post 5.3.0 development

2009-06-26 Thread Scott MacVicar
On 26 Jun 2009, at 19:59, Lukas Kahwe Smith wrote: On 26.06.2009, at 20:26, Pierre Joye pierre@gmail.com wrote: On Fri, Jun 26, 2009 at 7:30 PM, Scott MacVicarsc...@macvicar.net wrote: On 26 Jun 2009, at 16:26, Lukas Kahwe Smith wrote: Aloha, So the last fix is just being prepared for

Re: [PHP-DEV] post 5.3.0 development

2009-06-26 Thread Scott MacVicar
I *completely* agree with making sure 5.3.0 is stable and stopping extra things sneaking their way in. I just don't like the way that it is being done. If the release is tagged and built, then why continue with the freeze? Why not open it up for bug fixes towards 5.3.1? If the reason

Re: [PHP-DEV] post 5.3.0 development

2009-06-26 Thread Scott MacVicar
You have an assignment instead of a comparison there. Scott On 27 Jun 2009, at 00:52, Ilia Alshanetsky wrote: curl.txt -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Do you need different OS/platform to test on? Let me know

2009-06-26 Thread Scott MacVicar
On 26 Jun 2009, at 23:29, Hannes Magnusson wrote: Hi all Is there *anyone* who needs anything to be able to debug bug reports, run sanitychecks, developing.. or whatever? We really need to improve our architecture/platform/os testing, even if its just make all compile checks. On

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] Do you need different OS/platform to test on? Let me know

2009-06-26 Thread Scott MacVicar
On 27 Jun 2009, at 03:30, Mark Karpeles wrote: Hi, Le samedi 27 juin 2009 à 02:24 +0100, Scott MacVicar a écrit : I think we should look at getting buildbot setup and deployed to as many machines as humanly possible. It would at least give us a heads up when we've written something

Re: [PHP-DEV] Patch for bug #48575

2009-06-18 Thread Scott MacVicar
Gwynne Raskind wrote: On Jun 18, 2009, at 10:46 AM, Gwynne Raskind wrote: Here is a nice simple patch for #48575 which rips out the mach-o/dyld.h functionality in Zend (as suggested by the original reporter and the Apple comment). According to my testing this not only doesn't break anything,

[PHP-DEV] PHP Bug 48215

2009-06-17 Thread Scott MacVicar
Hey, Bug 48215 was a BC break from the previous 5.2 behaviour, it stemmed from a change for bug #39127. class a { function a($arg='') { echo $arg; } } class b extends a {} $b = new b; $b-b('foo'); $b-__construct('foo'); This prints out an error in 5.3 which is fine, the unexpected change

Re: [PHP-DEV] seems 5.3RC3 is too unstable

2009-06-16 Thread Scott MacVicar
On 17 Jun 2009, at 00:03, jvlad wrote: Hi All, Did anybody experiece troubles compiling php 5.3RC under FreeBSD 6.2/ amd64, NetBSD 3.1/x86, and OpenBSD 4.1/x86? Under these platforms gcc hangs in php-5.3.0RC3/ext/fileinfo/libmagic/apprentice.c. Disabling fileinfo produces further errors

Re: [PHP-DEV] PHP 5.2.10

2009-05-15 Thread Scott MacVicar
Giovanni Giacobbi wrote: On Thu, May 14, 2009 at 10:04:36PM +0200, Pierre Joye wrote: hi Ilia, On Thu, May 14, 2009 at 8:54 PM, Andrei Zmievski and...@gravitonic.com wrote: Jani Taskinen wrote: It's still new stuff. And we need more things in 5.3/6 to make them more interesting to general

Re: [PHP-DEV] Re: [PATCH] Scanner diet with fixes, etc.

2009-04-30 Thread Scott MacVicar
[^] is a special case to write a portable match any character in re2c. Scott Dmitry Stogov wrote: Hi Matt, Does this patch fix EOF handling issues related to mmap()? (e.g. parsing of files with size 4096, 8192, ...). Now we have two dirty fixes to handle them correctly. The patch is

[PHP-DEV] Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS

2009-04-27 Thread Scott MacVicar
On 27 Apr 2009, at 19:35, Jani Taskinen wrote: Scott MacVicar kirjoitti: scottmacMon Apr 27 18:20:19 2009 UTC Modified files: (Branch: PHP_5_3) /php-src NEWS Log: BFN [snip] crashes). (Dmitry) - Fixed bug #47699 (autoload and late static binding

Re: [PHP-DEV] GCC 4.4.0

2009-04-24 Thread Scott MacVicar
Sebastian Bergmann wrote: I experimented a bit with GCC 4.4.0 recently and found out that when compiled with it and -O2, PHP_5_3 segfaults. -O0 and -O1 are fine. PHP_5_2 and GCC 4.4.0 is fine at -O2. 64-bit machine? There is a known issue with 4.3.0 on 64-bit amd. Scott -- PHP

Re: [PHP-DEV] GCC 4.4.0

2009-04-24 Thread Scott MacVicar
Sebastian Bergmann wrote: Scott MacVicar schrieb: 64-bit machine? Nope: s...@ubuntu ~ % uname -a Linux ubuntu 2.6.28-11-generic #42-Ubuntu SMP Fri Apr 17 01:57:59 UTC 2009 i686 GNU/Linux s...@ubuntu ~ % /usr/local/gcc/bin/gcc -v Using built-in specs. Target: i686

Re: [PHP-DEV] Like 2 Invole in Google Open source program

2009-04-20 Thread Scott MacVicar
On 20 Apr 2009, at 19:34, Jaya Prakash jpawa...@gmail.com wrote: Hello, I saw that google open source program in php.net. I like to invole in it. *Name*: Jayaprakash.G *Proposal*:Working as a Web Developer *Short Description*: Work on web applications. *Full Description*: I worked on 3

Re: [PHP-DEV] Update to Zend Highlighter

2009-04-02 Thread Scott MacVicar
David Coallier wrote: 2009/4/2 Kalle Sommer Nielsen ka...@php.net: 2009/4/2 Kalle Sommer Nielsen ka...@php.net: Hi Justin Attached a patch instead, hopefully this will work ;) I really do like this idea :) Let's just commit it. Hold your horses, lets not commit things hastily. I'm not

Re: [PHP-DEV] Re: Focus on HEAD

2009-03-27 Thread Scott MacVicar
David Coallier wrote: 2009/3/27 Hannes Magnusson hannes.magnus...@gmail.com: 2009/3/27 Felipe Pena felipe...@gmail.com: Hello, just to inform, I've commited (yesterday) the patch removing the UG(unicode) checks, etc across all source (except mysql exts). As the patch has 492K, looks as no

[PHP-DEV] GSoC 2009

2009-03-19 Thread Scott MacVicar
Hi All, Just a quick note to say that PHP was accepted as an organisation for GSoC 2009. We have until the 23rd of March to try and liaise with any potential students we have available and work on our ideas list that we might suggest. Our ideas list at http://wiki.php.net/gsoc/2009 has a few

Re: [PHP-DEV] Patch and test cases too for

2009-03-17 Thread Scott MacVicar
On 11 Mar 2009, at 19:25, Christopher Östlund wrote: I think this behavior is a bit odd too: php -r echo json_encode(array(0='test')); // [test] php -r echo json_encode(array(1='test')); // {1:test} The reason for this is encoding looks to see if the array is sequentially numbered from 0

Re: [PHP-DEV] 5.3 items

2009-03-09 Thread Scott MacVicar
Hey Brian, On 9 Mar 2009, at 20:42, shire wrote: Hey Lukas, Just a heads up that I should have a fix for this soonish, just running some more tests to make sure everything works as expected (I assume nobody else has started work on this): 9. tokenizer misses last single-line comment

Re: [PHP-DEV] Patch and test cases too for

2009-03-02 Thread Scott MacVicar
Richard Quadling wrote: Hi. Regarding http://bugs.php.net/bug.php?id=47493, I've supplied a patch to the unit tests too. Any chance this could get committed to 5.2+ I'm too convinced of the parameter name and I don't think its something that should be added to 5.2.9 since its a feature.

Re: [PHP-DEV] Patch and test cases too for

2009-03-02 Thread Scott MacVicar
Richard Quadling wrote: 2009/3/2 Scott MacVicar sc...@macvicar.net: Richard Quadling wrote: Hi. Regarding http://bugs.php.net/bug.php?id=47493, I've supplied a patch to the unit tests too. Any chance this could get committed to 5.2+ I'm too convinced of the parameter name and I don't

Re: [PHP-DEV] phar update

2009-02-26 Thread Scott MacVicar
Igor Feghali wrote: While trying to perform phar testing on the system previously mentioned by me, I couldn't manage to get php5.3-200902261130 to compile with IBM CC. First 3 lines of error: /tmp/php5.3-200902261130/ext/pcre/pcrelib/pcre_internal.h, line 976.3: 1506-046 (S) Syntax error.

Re: [PHP-DEV] Re: towards the next 5.3 release

2009-02-03 Thread Scott MacVicar
Greg Beaver wrote: Lukas Kahwe Smith wrote: Aloha, So Johannes and I have chatted about what needs to happen before we can go to RC1. If there are no bigger issues the next version will indeed be RC1. Release sometime in the second half of February. No specific date has been set as of yet.

Re: [PHP-DEV] GSoC 2009

2009-01-26 Thread Scott MacVicar
Jani Taskinen wrote: See: http://cvs.php.net/viewvc.cgi/pear/Bugtracker/ That's the pear bug tracker modified for all pear/pecl/php bugs I worked on about 1.5years ago. :) It has that roadmap thing.. The one Barry worked on for GSoC 2008 is at http://cvs.php.net/viewvc.cgi/bugtracker I've

Re: [PHP-DEV] GSoC 2009

2009-01-25 Thread Scott MacVicar
On 25 Jan 2009, at 16:12, David Zülke wrote: Am 25.01.2009 um 14:29 schrieb Lukas Kahwe Smith: On 24.01.2009, at 17:40, Ilia Alshanetsky wrote: I think our bug current tracker is pretty good and most importantly makes it easy to report and update bugs which is conducive to more issues

Re: [PHP-DEV] GSoC 2009

2009-01-25 Thread Scott MacVicar
On 25 Jan 2009, at 15:22, Lukas Kahwe Smith wrote: On 25.01.2009, at 16:17, Graham Kelly wrote: Lastly, I really think all the PHP GSoC projects should be hosted in PHP's CVS under a central location (maybe something like /repository/gsoc/2009/projectname/). It was very hard at times to

[PHP-DEV] GSoC 2009

2009-01-21 Thread Scott MacVicar
Hi Everybody, It's almost that time again where we rush at the last minute to organise something for the Google Summer of Code, so in the interest of being prepared I'm thinking it's time to start collecting ideas for potential students. I've updated a few of the Wiki pages with some

[PHP-DEV] Re: cvs: php-src(PHP_5_3) /ext/date/tests date_default_timezone_get_error.phpt date_default_timezone_set_error.phpt date_default_timezone_set_variation1.phpt date_sun_info_error.phpt date_su

2009-01-13 Thread Scott MacVicar
Hi Andy, All these tests are broken in an environment that defines a TZ variable, you need to use date_default_timezone_set() Can you fix these please. Scott andy wharmby wrote: wharmby Tue Jan 13 13:38:20 2009 UTC Added files: (Branch: PHP_5_3)

Re: [PHP-DEV] status update for beta1

2009-01-12 Thread Scott MacVicar
Lukas Kahwe Smith wrote: Hello all, Just wanted to get a status update on the work going on: - Eric and Nathan are working on new php.ini files and I guess they will soon post their proposals to the list - @Steph: have you begun work on the Upgrading Guide? I would really like to have

Re: [PHP-DEV] dns_get_record for OSX

2009-01-07 Thread Scott MacVicar
Hi Kalle, Kalle Sommer Nielsen wrote: Hi Scott 2009/1/7 Scott MacVicar sc...@macvicar.net: I went to look at the bug Pierre mention earlier and noticed that dns_get_record isn't implemented on OS X, this looks to be down to the fact that it has a bind 8 BC layer that we use by default

Re: [PHP-DEV] christmas decorations..

2009-01-07 Thread Scott MacVicar
This isn't something for internals, use php-webmaster Scott Nathan Rixham wrote: I just threw the christmas tree out, came online and noticed that the decorations are still up on the php.net site; any idea when they're coming down? ho-ho-ho etc -- PHP Internals - PHP Runtime

[PHP-DEV] dns_get_record for OSX

2009-01-06 Thread Scott MacVicar
I went to look at the bug Pierre mention earlier and noticed that dns_get_record isn't implemented on OS X, this looks to be down to the fact that it has a bind 8 BC layer that we use by default for some reason. I tried to make it use the bind 9 interface but it wasn't a simple task as

Re: [PHP-DEV] Tip for 5.3: exceptions in __toString and __autoload

2008-12-25 Thread Scott MacVicar
On 26 Dec 2008, at 01:46, David Grudl wrote: This code throws *Fatal error*: Method test::__toString() must not throw an exception class Test1 { public function __toString() { throw new Exception; } } The same problem causes throwing exceptions in function __autoload. I think

Re: [PHP-DEV] 2008 is 1s longer than normal.

2008-12-18 Thread Scott MacVicar
Richard Quadling wrote: Hi. With 2008 having a leap-second, does PHP handle this? In looking at http://en.wikipedia.org/wiki/Leap_second, there have been quite a few leap seconds - 34 since Jan 1st 1972. So, if PHP isn't making any changes does this mean PHP time is 34 seconds behind

Re: [PHP-DEV] json_encode()

2008-12-17 Thread Scott MacVicar
Richard Quadling wrote: 2008/12/16 Robin Burchell virot...@viroteck.net: Settings which change behaviour like that aren't really all that fun for third party/portable applications developers, e.g. forum software and the likes. magic_quotes_gpc and others are good examples of this. Going back

Re: [PHP-DEV] json_encode()

2008-12-16 Thread Scott MacVicar
troels knak-nielsen wrote: On Tue, Dec 16, 2008 at 12:57 PM, Scott MacVicar sc...@macvicar.net wrote: For now I'll be leaving it as is and adding a JSON_STRICT_ENCODE parameter to the options flag. So you can use json_encode($var, JSON_STRICT_ENCODE); I'm really not a fan of named

Re: [PHP-DEV] json_encode()

2008-12-16 Thread Scott MacVicar
Richard Quadling wrote: 2008/12/15 mike mike...@gmail.com: On Mon, Dec 15, 2008 at 9:50 AM, Rasmus Lerdorf ras...@lerdorf.com wrote: 1. Document the fact that if you want to strictly conform to the JSON spec and be sure your json_encode output will work in various JSON parsers, you have

Re: [PHP-DEV] Re: Removing basic types from our JSON parser

2008-12-13 Thread Scott MacVicar
RFC: A JSON parser MUST accept all texts that conform to the JSON grammar. A JSON parser MAY accept non-JSON forms or extensions. On 13-Dec-08, at 1:05 PM, Lukas Kahwe Smith wrote: On 13.12.2008, at 18:59, Ilia Alshanetsky wrote: On 12-Dec-08, at 10:50 PM, Scott MacVicar wrote: Hi

[PHP-DEV] Removing basic types from our JSON parser

2008-12-12 Thread Scott MacVicar
Hi All, Basic types were added to our JSON decoder to PHP 5.2.1, this allows one to use json_encode / json_decode on any of our scalar types. Omar correctly identified #38680 as not a bug but it appears that Ilia added support for this anyway violating the RFC [1]. Maybe there was a

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Scott MacVicar
On 8 Dec 2008, at 16:35, Philip Olson [EMAIL PROTECTED] wrote: On 8 Dec 2008, at 08:18, Hannes Magnusson wrote: On Mon, Dec 8, 2008 at 16:57, Pierre Joye [EMAIL PROTECTED] wrote: On Mon, Dec 8, 2008 at 4:47 PM, Johannes Schlüter [EMAIL PROTECTED] net wrote: When dropping magic_quotes the

Re: [PHP-DEV] About dropping magic_quotes in 5.3 (was: Re: [PHP-DEV] Re: PHP 5.2.7 + magic_quotes_gpc broken)

2008-12-08 Thread Scott MacVicar
Steph Fox wrote: Hi Scott, Agreed, going from on by default to removed just feels odd. I'd disable it by default in 5.3 and lets start throwing a strict error if the configuration enables it. Why do we have E_DEPRECATED if we're not going to use it? That's the one I meant, no idea why

  1   2   3   >