[jira] [Commented] (FLINK-10065) InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611683#comment-16611683 ] ASF GitHub Bot commented on FLINK-10065: klion26 commented on issue #6498: [FLIN

[jira] [Commented] (FLINK-10322) Unused instance variable MetricRegistry in ResourceManager

2018-09-12 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611699#comment-16611699 ] 陈梓立 commented on FLINK-10322: - Maybe we could expand {{MetricRegistry}} so that get metrics

[jira] [Comment Edited] (FLINK-10322) Unused instance variable MetricRegistry in ResourceManager

2018-09-12 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611699#comment-16611699 ] 陈梓立 edited comment on FLINK-10322 at 9/12/18 7:30 AM: -- Maybe we cou

[jira] [Commented] (FLINK-10322) Unused instance variable MetricRegistry in ResourceManager

2018-09-12 Thread Shimin Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611714#comment-16611714 ] Shimin Yang commented on FLINK-10322: - Hi [~Tison], do you have any suggestion about

[jira] [Commented] (FLINK-10256) Port legacy jobmanager test to FILP-6

2018-09-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611736#comment-16611736 ] Till Rohrmann commented on FLINK-10256: --- Sorry for the late reply [~Tison]. Curren

[GitHub] SokolovMS commented on a change in pull request #6672: [FLINK-9523] [table] Add Kafka examples for Flink Table/SQL API

2018-09-12 Thread GitBox
SokolovMS commented on a change in pull request #6672: [FLINK-9523] [table] Add Kafka examples for Flink Table/SQL API URL: https://github.com/apache/flink/pull/6672#discussion_r216943099 ## File path: flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/example

[jira] [Commented] (FLINK-9523) Add Kafka examples for Flink Table/SQL API

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611763#comment-16611763 ] ASF GitHub Bot commented on FLINK-9523: --- SokolovMS commented on a change in pull re

[GitHub] Clarkkkkk commented on issue #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway…

2018-09-12 Thread GitBox
Clark commented on issue #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway… URL: https://github.com/apache/flink/pull/6680#issuecomment-420563206 Hi @TisonKun , I am not sure if it fails the execution too eagerly? I think the too problem that many RPC request

[jira] [Commented] (FLINK-10319) Avoid requestPartitionState from JM but always try retrigger

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611764#comment-16611764 ] ASF GitHub Bot commented on FLINK-10319: Clark commented on issue #6680: [FL

[GitHub] SokolovMS commented on a change in pull request #6672: [FLINK-9523] [table] Add Kafka examples for Flink Table/SQL API

2018-09-12 Thread GitBox
SokolovMS commented on a change in pull request #6672: [FLINK-9523] [table] Add Kafka examples for Flink Table/SQL API URL: https://github.com/apache/flink/pull/6672#discussion_r216642798 ## File path: flink-examples/flink-examples-table/src/main/java/org/apache/flink/table/example

[jira] [Commented] (FLINK-9523) Add Kafka examples for Flink Table/SQL API

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611782#comment-16611782 ] ASF GitHub Bot commented on FLINK-9523: --- SokolovMS commented on a change in pull re

[GitHub] TisonKun commented on issue #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway…

2018-09-12 Thread GitBox
TisonKun commented on issue #6680: [FLINK-10319] [runtime] Avoid requestPartitionState from JM but alway… URL: https://github.com/apache/flink/pull/6680#issuecomment-420570943 @Clark thanks for your advice, I would take it into consider. At first I will change the JIRA title poin

[jira] [Commented] (FLINK-10319) Avoid requestPartitionState from JM but always try retrigger

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611788#comment-16611788 ] ASF GitHub Bot commented on FLINK-10319: TisonKun commented on issue #6680: [FLI

[jira] [Updated] (FLINK-10319) Too many requestPartitionState would crash JM

2018-09-12 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 陈梓立 updated FLINK-10319: Summary: Too many requestPartitionState would crash JM (was: Avoid requestPartitionState from JM but always try r

[jira] [Commented] (FLINK-10322) Unused instance variable MetricRegistry in ResourceManager

2018-09-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611807#comment-16611807 ] Gary Yao commented on FLINK-10322: -- The instance variable should be used to resolve FLI

[jira] [Comment Edited] (FLINK-10322) Unused instance variable MetricRegistry in ResourceManager

2018-09-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611807#comment-16611807 ] Gary Yao edited comment on FLINK-10322 at 9/12/18 9:20 AM: --- Th

[jira] [Closed] (FLINK-10322) Unused instance variable MetricRegistry in ResourceManager

2018-09-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao closed FLINK-10322. Resolution: Duplicate > Unused instance variable MetricRegistry in ResourceManager > -

[GitHub] TisonKun commented on issue #6680: [FLINK-10319] [runtime] Too many requestPartitionState would crash JM

2018-09-12 Thread GitBox
TisonKun commented on issue #6680: [FLINK-10319] [runtime] Too many requestPartitionState would crash JM URL: https://github.com/apache/flink/pull/6680#issuecomment-420577451 @Clark why do you think it fails the execution eagerly? Former, Task would ask for JM to check the producer sta

[jira] [Commented] (FLINK-10319) Too many requestPartitionState would crash JM

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611816#comment-16611816 ] ASF GitHub Bot commented on FLINK-10319: TisonKun commented on issue #6680: [FLI

[GitHub] TisonKun edited a comment on issue #6680: [FLINK-10319] [runtime] Too many requestPartitionState would crash JM

2018-09-12 Thread GitBox
TisonKun edited a comment on issue #6680: [FLINK-10319] [runtime] Too many requestPartitionState would crash JM URL: https://github.com/apache/flink/pull/6680#issuecomment-420577451 @Clark why do you think it fails the execution eagerly? Former, Task would ask for JM to check the produ

[jira] [Commented] (FLINK-10319) Too many requestPartitionState would crash JM

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611824#comment-16611824 ] ASF GitHub Bot commented on FLINK-10319: TisonKun edited a comment on issue #668

[jira] [Commented] (FLINK-10257) Incorrect CHAR type support in Flink SQL and Table API

2018-09-12 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611840#comment-16611840 ] Piotr Nowojski commented on FLINK-10257: Just for the reference: Julian Hyde fro

[jira] [Created] (FLINK-10323) A single backslash cannot be successfully parsed in Java Table API

2018-09-12 Thread Xingcan Cui (JIRA)
Xingcan Cui created FLINK-10323: --- Summary: A single backslash cannot be successfully parsed in Java Table API Key: FLINK-10323 URL: https://issues.apache.org/jira/browse/FLINK-10323 Project: Flink

[GitHub] xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r216953610 ## File path: docs/dev/table/functions.md ## @@ -2866,6 +2890,18 @@ STRING.repeat(I

[GitHub] xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r216951006 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/func

[GitHub] xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r216952966 ## File path: docs/dev/table/functions.md ## @@ -2638,6 +2650,18 @@ STRING.repeat(I

[GitHub] xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r216952714 ## File path: docs/dev/table/functions.md ## @@ -2413,6 +2413,18 @@ REPEAT(string,

[GitHub] xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r216951784 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sq

[GitHub] xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r216953495 ## File path: docs/dev/table/functions.md ## @@ -2638,6 +2650,18 @@ STRING.repeat(I

[GitHub] xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r216953272 ## File path: docs/dev/table/functions.md ## @@ -2866,6 +2890,18 @@ STRING.repeat(I

[GitHub] xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r216954057 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/ex

[GitHub] xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r216955992 ## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/

[GitHub] xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
xccui commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r216954625 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611846#comment-16611846 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on a change in pull reques

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611854#comment-16611854 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on a change in pull reques

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611855#comment-16611855 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on a change in pull reques

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611852#comment-16611852 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on a change in pull reques

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611853#comment-16611853 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on a change in pull reques

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611848#comment-16611848 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on a change in pull reques

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611847#comment-16611847 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on a change in pull reques

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611849#comment-16611849 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on a change in pull reques

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611851#comment-16611851 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on a change in pull reques

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611850#comment-16611850 ] ASF GitHub Bot commented on FLINK-9991: --- xccui commented on a change in pull reques

[jira] [Created] (FLINK-10324) Replace ZooKeeperStateHandleStore#getAllSortedByNameAndLock by getAllAndLock

2018-09-12 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-10324: - Summary: Replace ZooKeeperStateHandleStore#getAllSortedByNameAndLock by getAllAndLock Key: FLINK-10324 URL: https://issues.apache.org/jira/browse/FLINK-10324 Projec

[GitHub] tillrohrmann opened a new pull request #6681: [FLINK-10324] Replace ZooKeeperStateHandleStore#getAllSortedByNameAndLock by getAllAndLock

2018-09-12 Thread GitBox
tillrohrmann opened a new pull request #6681: [FLINK-10324] Replace ZooKeeperStateHandleStore#getAllSortedByNameAndLock by getAllAndLock URL: https://github.com/apache/flink/pull/6681 ## What is the purpose of the change In order to reduce code duplication this commit replaces ZooKe

[jira] [Closed] (FLINK-10323) A single backslash cannot be successfully parsed in Java Table API

2018-09-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-10323. Resolution: Duplicate Duplicate of FLINK-10281. > A single backslash cannot be successfully parse

[jira] [Commented] (FLINK-10324) Replace ZooKeeperStateHandleStore#getAllSortedByNameAndLock by getAllAndLock

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611865#comment-16611865 ] ASF GitHub Bot commented on FLINK-10324: tillrohrmann opened a new pull request

[jira] [Updated] (FLINK-10324) Replace ZooKeeperStateHandleStore#getAllSortedByNameAndLock by getAllAndLock

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10324: --- Labels: pull-request-available (was: ) > Replace ZooKeeperStateHandleStore#getAllSortedByNa

[jira] [Commented] (FLINK-10323) A single backslash cannot be successfully parsed in Java Table API

2018-09-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611867#comment-16611867 ] Timo Walther commented on FLINK-10323: -- [~xccui] does my PR also solve your issue?

[jira] [Commented] (FLINK-10323) A single backslash cannot be successfully parsed in Java Table API

2018-09-12 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611878#comment-16611878 ] Xingcan Cui commented on FLINK-10323: - Thanks for your reminder [~twalthr]. I'll che

[jira] [Commented] (FLINK-10320) Introduce JobMaster schedule micro-benchmark

2018-09-12 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611879#comment-16611879 ] Piotr Nowojski commented on FLINK-10320: [~Tison] thanks for the proposal. Is th

[jira] [Commented] (FLINK-10323) A single backslash cannot be successfully parsed in Java Table API

2018-09-12 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611894#comment-16611894 ] Xingcan Cui commented on FLINK-10323: - Yes, it seems to have been fixed and we even

[GitHub] dawidwys commented on issue #6671: [FLINK-10281] [table] Fix string literal parsing in Table & SQL API and SQL Client

2018-09-12 Thread GitBox
dawidwys commented on issue #6671: [FLINK-10281] [table] Fix string literal parsing in Table & SQL API and SQL Client URL: https://github.com/apache/flink/pull/6671#issuecomment-420601057 I've had another look after the new changes and I am ok with them as well. One slight comment if it is

[jira] [Commented] (FLINK-10281) Table function parse regular expression contains backslash failed

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611902#comment-16611902 ] ASF GitHub Bot commented on FLINK-10281: dawidwys commented on issue #6671: [FLI

[jira] [Commented] (FLINK-10257) Incorrect CHAR type support in Flink SQL and Table API

2018-09-12 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611913#comment-16611913 ] Fabian Hueske commented on FLINK-10257: --- Thanks for looking into this and driving

[GitHub] StephanEwen commented on issue #6643: [FLINK-10275] StreamTask support object reuse

2018-09-12 Thread GitBox
StephanEwen commented on issue #6643: [FLINK-10275] StreamTask support object reuse URL: https://github.com/apache/flink/pull/6643#issuecomment-420611044 I think we need to find consensus on FLIP-21 before going for this. Currently, object reuse in streaming means to have "no copy on chain

[jira] [Commented] (FLINK-10275) StreamTask support object reuse

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611931#comment-16611931 ] ASF GitHub Bot commented on FLINK-10275: StephanEwen commented on issue #6643: [

[GitHub] twalthr opened a new pull request #6682: [FLINK-10269] [connectors] Fix Elasticsearch 6 UpdateRequest binary incompatibility

2018-09-12 Thread GitBox
twalthr opened a new pull request #6682: [FLINK-10269] [connectors] Fix Elasticsearch 6 UpdateRequest binary incompatibility URL: https://github.com/apache/flink/pull/6682 ## What is the purpose of the change This commit fixes the binary incompatibility for UpdateRequests in Elastic

[jira] [Commented] (FLINK-10269) Elasticsearch 6 UpdateRequest fail because of binary incompatibility

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611937#comment-16611937 ] ASF GitHub Bot commented on FLINK-10269: twalthr opened a new pull request #6682

[jira] [Updated] (FLINK-10269) Elasticsearch 6 UpdateRequest fail because of binary incompatibility

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10269: --- Labels: pull-request-available (was: ) > Elasticsearch 6 UpdateRequest fail because of bina

[GitHub] dawidwys commented on a change in pull request #6611: [FLINK-3875] [connectors] Add an upsert table sink factory for Elasticsearch

2018-09-12 Thread GitBox
dawidwys commented on a change in pull request #6611: [FLINK-3875] [connectors] Add an upsert table sink factory for Elasticsearch URL: https://github.com/apache/flink/pull/6611#discussion_r216992838 ## File path: docs/dev/table/connect.md ## @@ -583,6 +584,104 @@ Make sur

[jira] [Commented] (FLINK-3875) Add a TableSink for Elasticsearch

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611944#comment-16611944 ] ASF GitHub Bot commented on FLINK-3875: --- dawidwys commented on a change in pull req

[GitHub] twalthr commented on issue #6671: [FLINK-10281] [table] Fix string literal parsing in Table & SQL API and SQL Client

2018-09-12 Thread GitBox
twalthr commented on issue #6671: [FLINK-10281] [table] Fix string literal parsing in Table & SQL API and SQL Client URL: https://github.com/apache/flink/pull/6671#issuecomment-420616795 Thank you @dawidwys. I will improve the commits and merge this. ---

[jira] [Commented] (FLINK-10281) Table function parse regular expression contains backslash failed

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611965#comment-16611965 ] ASF GitHub Bot commented on FLINK-10281: twalthr commented on issue #6671: [FLIN

[jira] [Commented] (FLINK-10322) Unused instance variable MetricRegistry in ResourceManager

2018-09-12 Thread Shimin Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612017#comment-16612017 ] Shimin Yang commented on FLINK-10322: - Cool. > Unused instance variable MetricRegis

[GitHub] yanghua commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
yanghua commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r217002865 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/fu

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612023#comment-16612023 ] ASF GitHub Bot commented on FLINK-9991: --- yanghua commented on a change in pull requ

[GitHub] yanghua commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
yanghua commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r217003980 ## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expression

[GitHub] yanghua commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread GitBox
yanghua commented on a change in pull request #6450: [FLINK-9991] [table] Add regexp_replace supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6450#discussion_r217003980 ## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expression

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612029#comment-16612029 ] ASF GitHub Bot commented on FLINK-9991: --- yanghua commented on a change in pull requ

[jira] [Commented] (FLINK-9991) Add regexp_replace supported in TableAPI and SQL

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612030#comment-16612030 ] ASF GitHub Bot commented on FLINK-9991: --- yanghua commented on a change in pull requ

[GitHub] isunjin closed pull request #6657: [FLINK-10205] [JobManager] Batch Job: InputSplit Fault tolerant for DataSource…

2018-09-12 Thread GitBox
isunjin closed pull request #6657: [FLINK-10205] [JobManager] Batch Job: InputSplit Fault tolerant for DataSource… URL: https://github.com/apache/flink/pull/6657 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sak

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612045#comment-16612045 ] ASF GitHub Bot commented on FLINK-10205: isunjin closed pull request #6657:

[jira] [Updated] (FLINK-10325) [State TTL] Refactor TtlListState to use only loops, no java stream API for performance

2018-09-12 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Zagrebin updated FLINK-10325: Fix Version/s: 1.7.0 > [State TTL] Refactor TtlListState to use only loops, no java stream

[jira] [Created] (FLINK-10325) [State TTL] Refactor TtlListState to use only loops, no java stream API for performance

2018-09-12 Thread Andrey Zagrebin (JIRA)
Andrey Zagrebin created FLINK-10325: --- Summary: [State TTL] Refactor TtlListState to use only loops, no java stream API for performance Key: FLINK-10325 URL: https://issues.apache.org/jira/browse/FLINK-10325

[jira] [Assigned] (FLINK-10325) [State TTL] Refactor TtlListState to use only loops, no java stream API for performance

2018-09-12 Thread Andrey Zagrebin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrey Zagrebin reassigned FLINK-10325: --- Assignee: Andrey Zagrebin > [State TTL] Refactor TtlListState to use only loops, no

[GitHub] azagrebin opened a new pull request #6683: [FLINK-10325] [State TTL] Refactor TtlListState to use only loops, no java stream API for performance

2018-09-12 Thread GitBox
azagrebin opened a new pull request #6683: [FLINK-10325] [State TTL] Refactor TtlListState to use only loops, no java stream API for performance URL: https://github.com/apache/flink/pull/6683 ## What is the purpose of the change Refactor TtlListState to use only loops instead of java

[jira] [Commented] (FLINK-10325) [State TTL] Refactor TtlListState to use only loops, no java stream API for performance

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612056#comment-16612056 ] ASF GitHub Bot commented on FLINK-10325: azagrebin opened a new pull request #66

[jira] [Updated] (FLINK-10325) [State TTL] Refactor TtlListState to use only loops, no java stream API for performance

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10325: --- Labels: pull-request-available (was: ) > [State TTL] Refactor TtlListState to use only loop

[GitHub] isunjin opened a new pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource…

2018-09-12 Thread GitBox
isunjin opened a new pull request #6684: [FLINK-10205] Batch Job: InputSplit Fault tolerant for DataSource… URL: https://github.com/apache/flink/pull/6684 ## What is the purpose of the change Today DataSource Task pull InputSplits from JobManager to achieve better perf

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612093#comment-16612093 ] ASF GitHub Bot commented on FLINK-10205: isunjin opened a new pull request #6684

[jira] [Commented] (FLINK-10290) Conversion error in StreamScan and BatchScan

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612120#comment-16612120 ] ASF GitHub Bot commented on FLINK-10290: jrthe42 commented on issue #: [FLIN

[GitHub] jrthe42 commented on issue #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan

2018-09-12 Thread GitBox
jrthe42 commented on issue #: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan URL: https://github.com/apache/flink/pull/#issuecomment-420644775 Could you please review this PR? @twalthr @fhueske @xccui

[GitHub] TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse

2018-09-12 Thread GitBox
TisonKun commented on issue #6643: [FLINK-10275] StreamTask support object reuse URL: https://github.com/apache/flink/pull/6643#issuecomment-420644895 @StephanEwen you're right. After raising the exception mentioned above I communicate with our batch team, who pointing me to FLIP-21. So thi

[jira] [Commented] (FLINK-10275) StreamTask support object reuse

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612121#comment-16612121 ] ASF GitHub Bot commented on FLINK-10275: TisonKun commented on issue #6643: [FLI

[GitHub] GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-12 Thread GitBox
GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#discussion_r217043254 ## File path: flink-core/src/main/java/org/apache/flink/util/function/FunctionWithThrowable.jav

[jira] [Commented] (FLINK-10255) Standby Dispatcher locks submitted JobGraphs

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612172#comment-16612172 ] ASF GitHub Bot commented on FLINK-10255: GJL commented on a change in pull reque

[jira] [Updated] (FLINK-10281) Table function parse regular expression contains backslash failed

2018-09-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-10281: - Description: for example,  regular expression matches text ("\w") or number ("\d") : {code:java}

[jira] [Updated] (FLINK-10281) Fix string literal escaping throughout Table & SQL API

2018-09-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-10281: - Summary: Fix string literal escaping throughout Table & SQL API (was: Table function parse regu

[GitHub] GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-12 Thread GitBox
GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#discussion_r217043254 ## File path: flink-core/src/main/java/org/apache/flink/util/function/FunctionWithThrowable.jav

[GitHub] GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-12 Thread GitBox
GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#discussion_r217043254 ## File path: flink-core/src/main/java/org/apache/flink/util/function/FunctionWithThrowable.jav

[jira] [Commented] (FLINK-10255) Standby Dispatcher locks submitted JobGraphs

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612186#comment-16612186 ] ASF GitHub Bot commented on FLINK-10255: GJL commented on a change in pull reque

[jira] [Commented] (FLINK-10255) Standby Dispatcher locks submitted JobGraphs

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612185#comment-16612185 ] ASF GitHub Bot commented on FLINK-10255: GJL commented on a change in pull reque

[jira] [Created] (FLINK-10326) Simplify ZooKeeperSubmittedJobGraphStore constructor

2018-09-12 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-10326: - Summary: Simplify ZooKeeperSubmittedJobGraphStore constructor Key: FLINK-10326 URL: https://issues.apache.org/jira/browse/FLINK-10326 Project: Flink Issue

[jira] [Assigned] (FLINK-10326) Simplify ZooKeeperSubmittedJobGraphStore constructor

2018-09-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-10326: - Assignee: Till Rohrmann > Simplify ZooKeeperSubmittedJobGraphStore constructor > --

[jira] [Updated] (FLINK-10326) Simplify ZooKeeperSubmittedJobGraphStore constructor

2018-09-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-10326: -- Description: The {{ZooKeeperSubmittedJobGraphStore}} does a lot of initialization logic in its

[GitHub] GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-12 Thread GitBox
GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#discussion_r217045367 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java

[GitHub] GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-12 Thread GitBox
GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#discussion_r217046190 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java

[GitHub] GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader

2018-09-12 Thread GitBox
GJL commented on a change in pull request #6678: [FLINK-10255] Only react to onAddedJobGraph signal when being leader URL: https://github.com/apache/flink/pull/6678#discussion_r217044938 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/TestingDispatcher

[jira] [Commented] (FLINK-10255) Standby Dispatcher locks submitted JobGraphs

2018-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612197#comment-16612197 ] ASF GitHub Bot commented on FLINK-10255: GJL commented on a change in pull reque

  1   2   3   >