[jira] (FLINK-33722) MATCH_RECOGNIZE in batch mode ignores events order

2023-12-06 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-33722 ] Grzegorz Kołakowski deleted comment on FLINK-33722: - was (Author: grzegorz.kolakowski): Please assign me to the task. > MATCH_RECOGNIZE in batch mode ignores events order >

[jira] [Closed] (FLINK-33765) Flink SQL to support COLLECT_LIST

2023-12-06 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-33765. -- Resolution: Duplicate > Flink SQL to support COLLECT_LIST > -

[jira] [Commented] (FLINK-33765) Flink SQL to support COLLECT_LIST

2023-12-06 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794070#comment-17794070 ] Martijn Visser commented on FLINK-33765: [~zhenzhongxu] Please take a look at FLINK-21949 - We

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
schulzp commented on code in PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#discussion_r1418511130 ## flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/DefaultBulkResponseInspectorTest.java: ## @@ -0,0

Re: [PR] [FLINK-33726][sql-client] print time cost for streaming queries [flink]

2023-12-06 Thread via GitHub
JingGe merged PR #23868: URL: https://github.com/apache/flink/pull/23868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-06 Thread via GitHub
MartijnVisser commented on PR #23887: URL: https://github.com/apache/flink/pull/23887#issuecomment-1844815550 @tweise Was this a bug? If so, we should change the type of ticket. Don't forget to add 1.18.1 as a fix version then as well. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
schulzp commented on code in PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#discussion_r1418486556 ## flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/DefaultBulkResponseInspectorTest.java: ## @@ -0,0

[jira] [Commented] (FLINK-33717) Cleanup the usage of deprecated StreamTableEnvironment#fromDataStream

2023-12-06 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794045#comment-17794045 ] Jacky Lau commented on FLINK-33717: --- hi [~qingyue] could i take it? > Cleanup the usage of deprecated

[jira] [Commented] (FLINK-33719) Cleanup the usage of deprecated StreamTableEnvironment#toRetractStream

2023-12-06 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794044#comment-17794044 ] Jacky Lau commented on FLINK-33719: --- hi [~qingyue] could i take it? > Cleanup the usage of deprecated

[jira] [Commented] (FLINK-33716) Cleanup the usage of deprecated StreamTableEnvironment#createTemporaryView

2023-12-06 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794043#comment-17794043 ] Jacky Lau commented on FLINK-33716: --- hi [~qingyue] can i take it? > Cleanup the usage of deprecated

[jira] [Resolved] (FLINK-33266) Support plan cache for DQL in SQL Gateway

2023-12-06 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33266. Fix Version/s: 1.19.0 Resolution: Implemented Fixed via

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-06 Thread via GitHub
libenchao closed pull request #23849: [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway URL: https://github.com/apache/flink/pull/23849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-06 Thread via GitHub
bvarghese1 commented on code in PR #23681: URL: https://github.com/apache/flink/pull/23681#discussion_r1418421435 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -109,7 +109,8 @@ public

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-06 Thread via GitHub
bvarghese1 commented on code in PR #23681: URL: https://github.com/apache/flink/pull/23681#discussion_r1418421096 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java: ## @@ -109,7 +109,8 @@ public

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-06 Thread via GitHub
bvarghese1 commented on code in PR #23681: URL: https://github.com/apache/flink/pull/23681#discussion_r1418420396 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/GroupAggregateTestPrograms.java: ## @@ -0,0 +1,367 @@ +/* + *

Re: [PR] [FLINK-24150][k8s] Support to configure cpu resource request and limit in pod template [flink]

2023-12-06 Thread via GitHub
Sucran commented on PR #23872: URL: https://github.com/apache/flink/pull/23872#issuecomment-1844612780 so let me close this pr? @gyfora Thanks to Gyula again, [FLINK-33548](https://issues.apache.org/jira/browse/FLINK-33548) let's work on FLINK-33548. -- This is an automated message from

Re: [PR] [FLINK-33480] Implement restore tests for GroupAggregate node [flink]

2023-12-06 Thread via GitHub
bvarghese1 commented on code in PR #23681: URL: https://github.com/apache/flink/pull/23681#discussion_r1418419627 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -133,6 +134,12 @@ public Builder

Re: [PR] [FLINK-24150][k8s] Support to configure cpu resource request and limit in pod template [flink]

2023-12-06 Thread via GitHub
Sucran closed pull request #23872: [FLINK-24150][k8s] Support to configure cpu resource request and limit in pod template URL: https://github.com/apache/flink/pull/23872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-32894] Use 3.3.0 for maven-shade-plugin to support Java 17 [flink-connector-shared-utils]

2023-12-06 Thread via GitHub
PatrickRen commented on PR #20: URL: https://github.com/apache/flink-connector-shared-utils/pull/20#issuecomment-1844516188 @snuyanzin @echauchot Thanks for the review! I bumped the version to 3.5.1 as suggested. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-06 Thread via GitHub
1996fanrui commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1418378993 ## flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategyTest.java: ## @@ -73,14 +75,14 @@ void

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-06 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793998#comment-17793998 ] Feifan Wang commented on FLINK-33734: - Thanks to [~Zakelly] , [~pnowojski] and [~fanrui]  for

[jira] [Assigned] (FLINK-33768) Support dynamic source parallelism inference for batch jobs

2023-12-06 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-33768: --- Assignee: xingbe > Support dynamic source parallelism inference for batch jobs >

Re: [PR] [FLINK-32198][runtime] Enforce single maxExceptions query parameter [flink]

2023-12-06 Thread via GitHub
pgaref commented on PR #22663: URL: https://github.com/apache/flink/pull/22663#issuecomment-1844115554 Hey @zentol -- are we currently allowing changes as part of Flink 2.0? Would it make sense pushing this fix? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-06 Thread via GitHub
1996fanrui commented on code in PR #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1418224880 ## docs/content/docs/custom-resource/reference.md: ## @@ -125,6 +125,7 @@ This page serves as a full reference for FlinkDeployment custom resource

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
reswqa commented on code in PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#discussion_r1418211399 ## flink-connector-elasticsearch-base/src/test/java/org/apache/flink/connector/elasticsearch/sink/DefaultBulkResponseInspectorTest.java: ## @@ -0,0

[jira] [Updated] (FLINK-33768) Support dynamic source parallelism inference for batch jobs

2023-12-06 Thread xingbe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xingbe updated FLINK-33768: --- Description: Currently, for JobVertices without parallelism configured, the AdaptiveBatchScheduler

[jira] [Created] (FLINK-33768) Support dynamic source parallelism inference for batch jobs

2023-12-06 Thread xingbe (Jira)
xingbe created FLINK-33768: -- Summary: Support dynamic source parallelism inference for batch jobs Key: FLINK-33768 URL: https://issues.apache.org/jira/browse/FLINK-33768 Project: Flink Issue Type:

Re: [PR] [FLINK-33676] Implement RestoreTests for WindowAggregate [flink]

2023-12-06 Thread via GitHub
jnh5y commented on PR #23886: URL: https://github.com/apache/flink/pull/23886#issuecomment-1843982550 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33676] Implement RestoreTests for WindowAggregate [flink]

2023-12-06 Thread via GitHub
jnh5y commented on PR #23886: URL: https://github.com/apache/flink/pull/23886#issuecomment-1843846962 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-33767) Implement restore tests for TemporalJoin node

2023-12-06 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33767: -- Summary: Implement restore tests for TemporalJoin node Key: FLINK-33767 URL: https://issues.apache.org/jira/browse/FLINK-33767 Project: Flink Issue Type:

[jira] [Created] (FLINK-33766) Support MockEnvironment in BroadcastOperatorTestHarness

2023-12-06 Thread Koala Lam (Jira)
Koala Lam created FLINK-33766: - Summary: Support MockEnvironment in BroadcastOperatorTestHarness Key: FLINK-33766 URL: https://issues.apache.org/jira/browse/FLINK-33766 Project: Flink Issue

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-06 Thread via GitHub
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1843773243 > Will we adjust them in the pr of removing Hive connector from flink repo? yep, usually it's happening either with while removal of connector from main repo or together

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-06 Thread via GitHub
snuyanzin commented on code in PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#discussion_r1418033313 ## flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java: ## @@ -0,0 +1,1000 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]

2023-12-06 Thread via GitHub
snuyanzin commented on code in PR #23885: URL: https://github.com/apache/flink/pull/23885#discussion_r1417994612 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/EnvironmentTest.java: ## @@ -66,7 +66,7 @@ void testPassingExecutionParameters() {

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-06 Thread via GitHub
flinkbot commented on PR #23887: URL: https://github.com/apache/flink/pull/23887#issuecomment-1843686785 ## CI report: * a7c97714166fa29046b174a0d014f9f1bdb69843 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-06 Thread via GitHub
tweise opened a new pull request, #23887: URL: https://github.com/apache/flink/pull/23887 backport #18304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-33676] Implement RestoreTests for WindowAggregate [flink]

2023-12-06 Thread via GitHub
flinkbot commented on PR #23886: URL: https://github.com/apache/flink/pull/23886#issuecomment-1843664236 ## CI report: * f27ee1c63097be9187fa4a47466c2fc10f4e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Resolved] (FLINK-25565) Write and Read Parquet INT64 Timestamp

2023-12-06 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise resolved FLINK-25565. -- Fix Version/s: 1.19.0 Resolution: Fixed > Write and Read Parquet INT64 Timestamp >

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-06 Thread via GitHub
tweise merged PR #18304: URL: https://github.com/apache/flink/pull/18304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-06 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1843660558 Also verified with my application. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-33676) Implement restore tests for WindowAggregate node

2023-12-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33676: --- Labels: pull-request-available (was: ) > Implement restore tests for WindowAggregate node

[PR] [FLINK-33676] Implement RestoreTests for WindowAggregate [flink]

2023-12-06 Thread via GitHub
jnh5y opened a new pull request, #23886: URL: https://github.com/apache/flink/pull/23886 ## What is the purpose of the change Implement restore tests for WindowAggregate node. ## Verifying this change This change added tests and can be verified as follows: * Added

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-06 Thread via GitHub
rkhachatryan commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1417918412 ## docs/content/docs/deployment/config.md: ## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-06 Thread via GitHub
rkhachatryan commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1417895747 ## flink-metrics/flink-metrics-slf4j/src/main/java/org/apache/flink/traces/slf4j/Slf4jTraceReporter.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33726][sql-client] print time cost for streaming queries [flink]

2023-12-06 Thread via GitHub
JingGe commented on code in PR #23868: URL: https://github.com/apache/flink/pull/23868#discussion_r1417918470 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java: ## @@ -114,6 +108,30 @@ public void displayResults() throws

Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]

2023-12-06 Thread via GitHub
JingGe commented on code in PR #23885: URL: https://github.com/apache/flink/pull/23885#discussion_r1417905005 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/EnvironmentTest.java: ## @@ -66,7 +66,7 @@ void testPassingExecutionParameters() {

[jira] [Updated] (FLINK-33765) Flink SQL to support COLLECT_LIST

2023-12-06 Thread Zhenzhong Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenzhong Xu updated FLINK-33765: - Summary: Flink SQL to support COLLECT_LIST (was: Flink SQL to support COLLECTLIST) > Flink

[jira] [Updated] (FLINK-33765) Flink SQL to support COLLECT_LIST

2023-12-06 Thread Zhenzhong Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenzhong Xu updated FLINK-33765: - Description: Flink SQL currently supports COLLECT, which returns a multiset, however, given

[jira] [Created] (FLINK-33765) Flink SQL to support COLLECTLIST

2023-12-06 Thread Zhenzhong Xu (Jira)
Zhenzhong Xu created FLINK-33765: Summary: Flink SQL to support COLLECTLIST Key: FLINK-33765 URL: https://issues.apache.org/jira/browse/FLINK-33765 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-33757] Implement restore tests for Rank node [flink]

2023-12-06 Thread via GitHub
jnh5y commented on PR #23878: URL: https://github.com/apache/flink/pull/23878#issuecomment-1843578408 Lemme know if you want me to clean up any of the git history. The merge from master was resolving conflicts in the GitHub UI. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33757] Implement restore tests for Rank node [flink]

2023-12-06 Thread via GitHub
jnh5y commented on code in PR #23878: URL: https://github.com/apache/flink/pull/23878#discussion_r1417894843 ## flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-rank_1/rank-test/plan/rank-test.json: ## @@ -81,19 +52,20 @@ }, "orderBy" : {

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-12-06 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793866#comment-17793866 ] Kevin Tseng commented on FLINK-33545: - Hi Mason, Kafka Producer only throw exception in following

Re: [PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]

2023-12-06 Thread via GitHub
flinkbot commented on PR #23885: URL: https://github.com/apache/flink/pull/23885#issuecomment-1843366916 ## CI report: * 19810b57dd41666d22a91399d41be0bc0c4794d6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-33718) Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream

2023-12-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33718: --- Assignee: Sergey Nuyanzin > Cleanup the usage of deprecated

[PR] [FLINK-33718][table] Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream [flink]

2023-12-06 Thread via GitHub
snuyanzin opened a new pull request, #23885: URL: https://github.com/apache/flink/pull/23885 ## What is the purpose of the change The PR is about to replace deprecated `StreamTableEnvironment#toAppendStream` with `StreamTableEnvironment#toDataStream` as mentioned in javadoc

[jira] [Updated] (FLINK-33718) Cleanup the usage of deprecated StreamTableEnvironment#toAppendStream

2023-12-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33718: --- Labels: pull-request-available (was: ) > Cleanup the usage of deprecated

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
schulzp commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1843307919 @afedulov, fixed the test (and extended it) @reta, I added a `FailureHandler` with a default implementation that resembles the current fail-on-any-failure

Re: [PR] [FLINK-33645] Taskmanager env vars in config not given to taskmanager [flink-kubernetes-operator]

2023-12-06 Thread via GitHub
tagarr commented on PR #722: URL: https://github.com/apache/flink-kubernetes-operator/pull/722#issuecomment-1843281986 Fixed checkstyle errors (apologies, could have sworn a ran a build before creating the PR) -- This is an automated message from the Apache Git Service. To respond to

[PR] [FLINK-33763] Support savepoint redeployment through a nonce [flink-kubernetes-operator]

2023-12-06 Thread via GitHub
gyfora opened a new pull request, #724: URL: https://github.com/apache/flink-kubernetes-operator/pull/724 ## What is the purpose of the change A common request is to support a streamlined, user friendly way of redeploying from a target savepoint. Previously this was only possible

[jira] [Updated] (FLINK-33763) Support manual savepoint redeploy for jobs and deployments

2023-12-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33763: --- Labels: pull-request-available (was: ) > Support manual savepoint redeploy for jobs and

Re: [PR] [FLINK-33758] Implement restore tests for TemporalSort node [flink]

2023-12-06 Thread via GitHub
jnh5y commented on code in PR #23879: URL: https://github.com/apache/flink/pull/23879#discussion_r1417587636 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TemporalSortTestPrograms.java: ## @@ -0,0 +1,103 @@ +/* + *

Re: [PR] [FLINK-33758] Implement restore tests for TemporalSort node [flink]

2023-12-06 Thread via GitHub
dawidwys commented on code in PR #23879: URL: https://github.com/apache/flink/pull/23879#discussion_r1417576522 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TemporalSortTestPrograms.java: ## @@ -0,0 +1,103 @@ +/* + *

[jira] [Commented] (FLINK-33710) Autoscaler redeploys pipeline for a NOOP parallelism change

2023-12-06 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793800#comment-17793800 ] Maximilian Michels commented on FLINK-33710: Additional fix via

Re: [PR] [FLINK-33710] Prevent triggering cluster upgrades for permutations of the same overrides [flink-kubernetes-operator]

2023-12-06 Thread via GitHub
mxm merged PR #721: URL: https://github.com/apache/flink-kubernetes-operator/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33758] Implement restore tests for TemporalSort node [flink]

2023-12-06 Thread via GitHub
jnh5y commented on code in PR #23879: URL: https://github.com/apache/flink/pull/23879#discussion_r1417554937 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TemporalSortTestPrograms.java: ## @@ -0,0 +1,103 @@ +/* + *

Re: [PR] [FLINK-33754] Serialize QueryOperations into SQL string [flink]

2023-12-06 Thread via GitHub
flinkbot commented on PR #23884: URL: https://github.com/apache/flink/pull/23884#issuecomment-1843138896 ## CI report: * 33d967570f5b86867dc026358dbff280e09da779 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
schulzp commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1843137406 @afedulov, sure, I'll implement it with plain java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Closed] (FLINK-33599) Run restore tests with RocksDB state backend

2023-12-06 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33599. Resolution: Implemented Implemented in 43fec308b3298ed2aad639b94140c9a2173c10cd > Run

Re: [PR] [FLINK-33599] Run restore tests with RocksDB state backend [flink]

2023-12-06 Thread via GitHub
dawidwys merged PR #23883: URL: https://github.com/apache/flink/pull/23883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-12-06 Thread via GitHub
tagarr commented on PR #712: URL: https://github.com/apache/flink-kubernetes-operator/pull/712#issuecomment-1843133539 @gyfora @gaborgsomogyi made required changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Closed] (FLINK-33753) ContinuousFileReaderOperator consume records as mini batch

2023-12-06 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prabhu Joseph closed FLINK-33753. - Resolution: Not A Problem > ContinuousFileReaderOperator consume records as mini batch >

[jira] [Updated] (FLINK-33754) Serialize QueryOperations into SQL

2023-12-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33754: --- Labels: pull-request-available (was: ) > Serialize QueryOperations into SQL >

[PR] [FLINK-33754] Serialize QueryOperations into SQL string [flink]

2023-12-06 Thread via GitHub
dawidwys opened a new pull request, #23884: URL: https://github.com/apache/flink/pull/23884 ## What is the purpose of the change Serialize `QueryOperations` into its SQL equivalents. ## Verifying this change Added tests in `QueryOperationSqlSerializationTest`

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-06 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1417523981 ## docs/layouts/shortcodes/generated/akka_configuration.html: ## @@ -98,6 +80,24 @@ Duration Timeout used for the lookup of the JobManager.

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
afedulov commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1843121034 @schulzp thanks! We try to avoid Mockito usage, unless it is not possible because because of external dependencies that required concrete classes rather than

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-06 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1417516719 ## docs/content/docs/ops/traces.md: ## @@ -0,0 +1,126 @@ +--- +title: "Metrics" +weight: 6 +type: docs +aliases: + - /ops/traces.html + - /apis/traces.html + -

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-06 Thread via GitHub
pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1417512998 ## docs/content/docs/ops/traces.md: ## @@ -0,0 +1,126 @@ +--- +title: "Metrics" +weight: 6 +type: docs +aliases: + - /ops/traces.html + - /apis/traces.html + -

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-06 Thread via GitHub
pnowojski commented on PR #23845: URL: https://github.com/apache/flink/pull/23845#issuecomment-1843111206 > Should we also update the Chinese version (with the same content in English)? Yes, it was my implicit plan to first review the English version and after  it, copy paste the

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
reta commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1843109798 > I assume there shared code to be reused and that is more about API consistency? There is no shared code (I think you meant that) and indeed, it is more about API

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
schulzp commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1843099110 @reta, sure, so I'll rename my interfaces to match those from opensearch and add the factory to the opensearch sink builder afterwards. I assume there shared code to

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-06 Thread via GitHub
1996fanrui commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1417491069 ## flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategyTest.java: ## @@ -73,14 +75,14 @@ void

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-06 Thread via GitHub
1996fanrui commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1417489771 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/RestartBackoffTimeStrategyFactoryLoader.java: ## @@ -116,7 +116,9 @@ private static

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-06 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793770#comment-17793770 ] Rui Fan commented on FLINK-33734: - Thanks [~Feifan Wang]  creating this  Jira, and thanks  [~pnowojski] 

[jira] [Created] (FLINK-33764) Incorporate GC / Heap metrics in autoscaler decisions

2023-12-06 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-33764: -- Summary: Incorporate GC / Heap metrics in autoscaler decisions Key: FLINK-33764 URL: https://issues.apache.org/jira/browse/FLINK-33764 Project: Flink Issue

Re: [PR] [FLINK-33757] Implement restore tests for Rank node [flink]

2023-12-06 Thread via GitHub
dawidwys commented on code in PR #23878: URL: https://github.com/apache/flink/pull/23878#discussion_r1417478356 ## flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-rank_1/rank-test/plan/rank-test.json: ## @@ -81,19 +52,20 @@ }, "orderBy" :

Re: [PR] [FLINK-33758] Implement restore tests for TemporalSort node [flink]

2023-12-06 Thread via GitHub
dawidwys commented on code in PR #23879: URL: https://github.com/apache/flink/pull/23879#discussion_r1417474823 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TemporalSortTestPrograms.java: ## @@ -0,0 +1,103 @@ +/* + *

[jira] [Assigned] (FLINK-33763) Support manual savepoint redeploy for jobs and deployments

2023-12-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-33763: -- Assignee: Gyula Fora > Support manual savepoint redeploy for jobs and deployments >

[jira] [Created] (FLINK-33763) Support manual savepoint redeploy for jobs and deployments

2023-12-06 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-33763: -- Summary: Support manual savepoint redeploy for jobs and deployments Key: FLINK-33763 URL: https://issues.apache.org/jira/browse/FLINK-33763 Project: Flink Issue

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
reta commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1843053300 > @reta, I checked out that the opensearch failure handler. That achieves the same in regard of error handling. However, it does not allow capturing additional metrics.

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
schulzp commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1843046355 @afedulov, thanks! I added a test that makes sure the inspector is passed to the `ElasticsearchWriter`. @reswqa, I looked into the pipeline failed pipelines:

Re: [PR] [FLINK-32895][Scheduler] Introduce the max attempts for Exponential Delay Restart Strategy [flink]

2023-12-06 Thread via GitHub
qinf commented on code in PR #23247: URL: https://github.com/apache/flink/pull/23247#discussion_r1417423381 ## flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategyTest.java: ## @@ -36,35 +36,37 @@ class

Re: [PR] [FLINK-33757] Implement restore tests for Rank node [flink]

2023-12-06 Thread via GitHub
jnh5y commented on code in PR #23878: URL: https://github.com/apache/flink/pull/23878#discussion_r1417448524 ## flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-rank_1/rank-test/plan/rank-test.json: ## @@ -81,19 +52,20 @@ }, "orderBy" : {

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-06 Thread via GitHub
rkhachatryan commented on PR #23845: URL: https://github.com/apache/flink/pull/23845#issuecomment-1843011650 One more thing, all the documentation changes only affect the English version. Should we also update the Chinese version (with the same content in English)? -- This is an

Re: [PR] [FLINK-33708][FLINK-33709] Introduce TraceReporter and use it to create checkpointing traces [flink]

2023-12-06 Thread via GitHub
rkhachatryan commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1417402466 ## docs/content/docs/ops/traces.md: ## @@ -0,0 +1,126 @@ +--- +title: "Metrics" +weight: 6 +type: docs +aliases: + - /ops/traces.html + - /apis/traces.html + -

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-06 Thread via GitHub
reta commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1842971156 @schulzp there was a similar change introduced into `flink-connector-opensearch`, I believe we could backport it to the Elasticsearch connector to have a similar model of

Re: [PR] [FLINK-33758] Implement restore tests for TemporalSort node [flink]

2023-12-06 Thread via GitHub
jnh5y commented on code in PR #23879: URL: https://github.com/apache/flink/pull/23879#discussion_r1417390527 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TemporalSortTestPrograms.java: ## @@ -0,0 +1,103 @@ +/* + *

[PR] Add Java client library update process to the Upgrade page [flink-kubernetes-operator]

2023-12-06 Thread via GitHub
mxm opened a new pull request, #723: URL: https://github.com/apache/flink-kubernetes-operator/pull/723 Update the docs regarding Java client library upgrades. I'm curious to hear your opinion on this one. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33559] Externalize Kafka Python connector code [flink-connector-kafka]

2023-12-06 Thread via GitHub
pvary commented on code in PR #69: URL: https://github.com/apache/flink-connector-kafka/pull/69#discussion_r1417327078 ## flink-python/setup.py: ## @@ -0,0 +1,158 @@ + +# Licensed to the Apache

[jira] [Comment Edited] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793706#comment-17793706 ] Piotr Nowojski edited comment on FLINK-33734 at 12/6/23 1:16 PM: - That's

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793706#comment-17793706 ] Piotr Nowojski commented on FLINK-33734: That's a good question [~Zakelly]. Apart of that:

  1   2   >