nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403014630
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/CatalogTestBase.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403012486
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/CatalogTestBase.java:
##
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403012159
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java:
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403010787
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBase.java:
##
@@ -0,0 +1,287 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1403010020
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestHelperBase.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
amogh-jahagirdar commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1403010409
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalR
nastra commented on code in PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#discussion_r1403006302
##
core/src/main/java/org/apache/iceberg/UpdateSnapshotReferencesOperation.java:
##
@@ -106,40 +106,42 @@ public UpdateSnapshotReferencesOperation
replaceBranch(String
nastra commented on code in PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#discussion_r1403004798
##
core/src/test/java/org/apache/iceberg/TestSnapshotManager.java:
##
@@ -427,6 +427,26 @@ public void testReplaceBranchNonExistingSourceFails() {
.hasMessage("
cgpoh commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1402840153
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/MiniFlinkClusterResource.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
jia-zhengwei commented on issue #8508:
URL: https://github.com/apache/iceberg/issues/8508#issuecomment-1823787054
> Got it. It seems that the document
https://iceberg.apache.org/docs/latest/spark-ddl/#alter-table--set-identifier-fields
will give users the misconception that Spark can use` I
zhangbutao commented on issue #8508:
URL: https://github.com/apache/iceberg/issues/8508#issuecomment-1823767653
Got it. It seems that the document
https://iceberg.apache.org/docs/latest/spark-ddl/#alter-table--set-identifier-fields
will give users the misconception that Spark can use` IDENT
ConeyLiu commented on issue #8508:
URL: https://github.com/apache/iceberg/issues/8508#issuecomment-1823763813
Yes, `IDENTIFIER FIELDS` is mostly used in equality delete files. Right now
only Flink has implemented the MOR with equality delete files.
--
This is an automated message from the
nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1402866684
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
met
nk1506 commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1402866684
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
met
liurenjie1024 commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1402858796
##
crates/iceberg/src/spec/values.rs:
##
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
baiyangtx commented on issue #8508:
URL: https://github.com/apache/iceberg/issues/8508#issuecomment-1823738673
`IDENTIFIER FIELDS` only work for Flink Streaming upsert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
zhangbutao commented on issue #8508:
URL: https://github.com/apache/iceberg/issues/8508#issuecomment-1823737591
> You should use `MERGE INTO` to upsert in Spark.
https://iceberg.apache.org/docs/latest/spark-writes/#merge-into
Hi @ConeyLiu , IMHO, `MERGE INTO` has nothing to do with `I
amogh-jahagirdar commented on code in PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402854044
##
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##
@@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) {
ManageSnapshots r
ConeyLiu commented on issue #8508:
URL: https://github.com/apache/iceberg/issues/8508#issuecomment-1823735875
You should use `MERGE INTO` to upsert in Spark.
https://iceberg.apache.org/docs/latest/spark-writes/#merge-into
--
This is an automated message from the Apache Git Service.
To res
amogh-jahagirdar commented on code in PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402845199
##
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##
@@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) {
ManageSnapshots r
amogh-jahagirdar commented on code in PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402845199
##
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##
@@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) {
ManageSnapshots r
cgpoh commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1402840153
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/MiniFlinkClusterResource.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
rakesh-das08 commented on code in PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402838230
##
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##
@@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) {
ManageSnapshots repla
github-actions[bot] closed issue #7452: Prohibit rewrites of equality deletes
across sequence numbers
URL: https://github.com/apache/iceberg/issues/7452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on issue #7452:
URL: https://github.com/apache/iceberg/issues/7452#issuecomment-1823681788
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] commented on issue #7554:
URL: https://github.com/apache/iceberg/issues/7554#issuecomment-1823681773
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #7554: How to ensure the data is not repeated
when using spark to write to the iceberg table
URL: https://github.com/apache/iceberg/issues/7554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on issue #7594:
URL: https://github.com/apache/iceberg/issues/7594#issuecomment-1823681742
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
github-actions[bot] closed issue #7594: planFiles with ParallelIterator OOM(Out
of memory)
URL: https://github.com/apache/iceberg/issues/7594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Fokko merged PR #160:
URL: https://github.com/apache/iceberg-python/pull/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko merged PR #155:
URL: https://github.com/apache/iceberg-python/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
Fokko merged PR #157:
URL: https://github.com/apache/iceberg-python/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.
dependabot[bot] opened a new pull request, #160:
URL: https://github.com/apache/iceberg-python/pull/160
Bumps
[mkdocs-material-extensions](https://github.com/facelessuser/mkdocs-material-extensions)
from 1.3 to 1.3.1.
Release notes
Sourced from https://github.com/facelessuser/mkdo
dependabot[bot] closed pull request #152: Build: Bump pydantic from 2.4.2 to
2.5.1
URL: https://github.com/apache/iceberg-python/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #152:
URL: https://github.com/apache/iceberg-python/pull/152#issuecomment-1823611322
Superseded by #159.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
dependabot[bot] opened a new pull request, #159:
URL: https://github.com/apache/iceberg-python/pull/159
Bumps [pydantic](https://github.com/pydantic/pydantic) from 2.4.2 to 2.5.2.
Release notes
Sourced from https://github.com/pydantic/pydantic/releases";>pydantic's
releases.
cccs-jc commented on PR #8980:
URL: https://github.com/apache/iceberg/pull/8980#issuecomment-1823493615
> @cccs-jc i would recommend to make the changes 1 spark version at a time
and then create back-port pr, i am not sure what is the preferred though but
checking it 1 version at a time hel
valerio-leap commented on issue #8863:
URL: https://github.com/apache/iceberg/issues/8863#issuecomment-1823493018
Any idea how to overcome this issue if upgrading is not an option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
cccs-jc commented on code in PR #8980:
URL: https://github.com/apache/iceberg/pull/8980#discussion_r1402704727
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##
@@ -392,8 +392,15 @@ public Offset latestOffset(Offset startOffset, Rea
AntonOvsyannikov opened a new issue, #9135:
URL: https://github.com/apache/iceberg/issues/9135
### Query engine
spark 3.5.0 with odbc hive thrift server
### Question
Hello,
I am not sure it's real bug or it's thrift server issue, or we are doing
something complet
cccs-jc commented on code in PR #8980:
URL: https://github.com/apache/iceberg/pull/8980#discussion_r1402703648
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##
@@ -406,6 +413,30 @@ public Offset latestOffset(Offset startOffset, Rea
amogh-jahagirdar commented on code in PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402641790
##
api/src/main/java/org/apache/iceberg/ManageSnapshots.java:
##
@@ -163,26 +163,26 @@ default ManageSnapshots createBranch(String name) {
ManageSnapshots r
amogh-jahagirdar commented on code in PR #8854:
URL: https://github.com/apache/iceberg/pull/8854#discussion_r1402640731
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/FastForwardBranchProcedure.java:
##
@@ -77,9 +77,9 @@ public InternalRow[] call(InternalR
amogh-jahagirdar commented on code in PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#discussion_r1402637674
##
core/src/test/java/org/apache/iceberg/TestSnapshotManager.java:
##
@@ -427,6 +427,26 @@ public void testReplaceBranchNonExistingSourceFails() {
.ha
amogh-jahagirdar commented on PR #9134:
URL: https://github.com/apache/iceberg/pull/9134#issuecomment-1823395448
cc @rakesh-das08 This stems from our discussion on
https://github.com/apache/iceberg/pull/8854#discussion_r1361985873
--
This is an automated message from the Apache Git Servi
amogh-jahagirdar opened a new pull request, #9134:
URL: https://github.com/apache/iceberg/pull/9134
This change fixes some very confusing naming from my original implementation
of the fastForward/replaceBranch APIs.
Prior to this change, the APIs had the following naming:
```
rdblue commented on code in PR #9125:
URL: https://github.com/apache/iceberg/pull/9125#discussion_r1402521562
##
format/spec.md:
##
@@ -305,6 +305,10 @@ The source column, selected by id, must be a primitive
type and cannot be contai
Partition specs capture the transform fro
tomtongue commented on PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1823273318
Add the following classes that basically cover JUnit5 and AssertJ styles.
Each class has a lot of inheritants so that new classes are created for now.
@nastra
--
This is an automate
rdblue commented on code in PR #9125:
URL: https://github.com/apache/iceberg/pull/9125#discussion_r1402519684
##
format/spec.md:
##
@@ -607,6 +611,8 @@ Notes:
1. An alternative, *strict projection*, creates a partition predicate that
will match a file if all of the rows in t
rdblue commented on code in PR #9125:
URL: https://github.com/apache/iceberg/pull/9125#discussion_r1402518409
##
format/spec.md:
##
@@ -607,6 +611,8 @@ Notes:
1. An alternative, *strict projection*, creates a partition predicate that
will match a file if all of the rows in t
rdblue commented on code in PR #9131:
URL: https://github.com/apache/iceberg/pull/9131#discussion_r1402479551
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java:
##
@@ -425,16 +426,35 @@ public void
testSnapshotSelectionByBranchWithSche
rdblue commented on code in PR #9131:
URL: https://github.com/apache/iceberg/pull/9131#discussion_r1402477101
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestSnapshotSelection.java:
##
@@ -425,16 +426,35 @@ public void
testSnapshotSelectionByBranchWithSche
stevenzwu commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1402429495
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##
@@ -429,6 +444,30 @@ public Builder setAll(Map properties) {
return t
rdblue commented on issue #9072:
URL: https://github.com/apache/iceberg/issues/9072#issuecomment-1823151897
Yeah, it looks like the issue is that the REST catalog will create
properties that can't be handled when the underlying catalog is a Hadoop
catalog.
--
This is an automated message
ajantha-bhat commented on issue #9133:
URL: https://github.com/apache/iceberg/issues/9133#issuecomment-1823148668
Related issue: https://github.com/apache/iceberg/issues/4159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ajantha-bhat commented on issue #9132:
URL: https://github.com/apache/iceberg/issues/9132#issuecomment-1823145815
Related issue: https://github.com/apache/iceberg/issues/8258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nastra commented on issue #9026:
URL: https://github.com/apache/iceberg/issues/9026#issuecomment-1823100622
@cccs-eric I took another look at this. When describing the schema of a
branch, then that output should always show the schema of the current table
itself and not the schema of the cu
pvary commented on code in PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#discussion_r1402326168
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/MiniFlinkClusterResource.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
adutra commented on PR #8857:
URL: https://github.com/apache/iceberg/pull/8857#issuecomment-1823031640
I took the time to investigate what it would take to use the client-side
classes consistently. My final opinion is that it's not a good solution, for
the below reasons:
* Client-sid
Fokko commented on PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1822991443
Thanks @fqaiser94 for the PR, and @liurenjie1024 & @Xuanwo for the review 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Fokko merged PR #94:
URL: https://github.com/apache/iceberg-rust/pull/94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
Fokko closed issue #90: Substitue in memory data struct's timestamp type for
DataTime rather i64 to simplify usage.
URL: https://github.com/apache/iceberg-rust/issues/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
nastra opened a new pull request, #9131:
URL: https://github.com/apache/iceberg/pull/9131
When retrieving the schema for branch we should always return the table
schema instead of the snapshot schema. This is because the table schema is the
schema that will be used when the branch will be c
snazy commented on PR #8065:
URL: https://github.com/apache/iceberg/pull/8065#issuecomment-1822721081
Ping for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
tomtongue commented on PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1822698391
Thank you! I'm working on changes. Let me do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
zhongyujiang commented on issue #9130:
URL: https://github.com/apache/iceberg/issues/9130#issuecomment-1822694319
Since NaNs are not permitted as lower or upper bounds in Iceberg, should we
convert Spark's `col > x` filter to Iceberg's `col > x OR col is NaN` if `col`
is `float` or `double`
zhongyujiang opened a new issue, #9130:
URL: https://github.com/apache/iceberg/issues/9130
### Apache Iceberg version
1.4.2 (latest release)
### Query engine
Spark
### Please describe the bug 🐞
I found that when there are NaN values in the columns, the resul
mobley-trent commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1401933787
##
crates/iceberg/src/spec/values.rs:
##
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
PrabhuJoseph commented on code in PR #9046:
URL: https://github.com/apache/iceberg/pull/9046#discussion_r1401936374
##
docs/flink-writes.md:
##
@@ -69,7 +69,7 @@ Iceberg supports `UPSERT` based on the primary key when
writing data into v2 tab
```sql
CREATE TABLE `hive_catal
mobley-trent commented on code in PR #103:
URL: https://github.com/apache/iceberg-rust/pull/103#discussion_r1401933787
##
crates/iceberg/src/spec/values.rs:
##
@@ -554,13 +554,14 @@ impl From<&Literal> for JsonValue {
PrimitiveLiteral::Decimal(_) => todo!(),
lyohar commented on PR #7914:
URL: https://github.com/apache/iceberg/pull/7914#issuecomment-1822629812
Got similar issue in 1.4.2, spark 3.5
My iceberg catalogue in Spark is configured via
org.apache.iceberg.aws.s3.S3FileIO filesystem. I store files using s3 prefix;
Hovewer, when
ajantha-bhat commented on PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#issuecomment-1822627656
@snazy: I have addressed most of the comments and replied the reason for
unhandled comments.
Please take a look again. Thanks.
--
This is an automated message from the Apache
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401930877
##
nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java:
##
@@ -62,7 +62,7 @@ public Reference getReference() {
public void checkMutable()
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401930448
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -540,4 +617,72 @@ public void close() {
api.close();
}
}
+
+ publ
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401929783
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -378,27 +400,72 @@ public void renameTable(TableIdentifier from,
TableIdentifier
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401929044
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -170,11 +184,12 @@ private TableIdentifier
toIdentifier(EntriesResponse.Entry en
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401929044
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -170,11 +184,12 @@ private TableIdentifier
toIdentifier(EntriesResponse.Entry en
cgpoh commented on PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#issuecomment-1822599964
@pvary will do. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
nastra commented on PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#issuecomment-1822596157
@tomtongue I think we first need to have a JUnit5 equivalent of
`SparkTestBase` and `SparkTestBaseWithCatalog` before we can migrate
`SparkCatalogTestBase`
--
This is an automated messa
nastra commented on code in PR #9129:
URL: https://github.com/apache/iceberg/pull/9129#discussion_r1401906293
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/SparkCatalogTestBaseForJU5.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401896252
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -540,4 +630,72 @@ public void close() {
api.close();
}
}
+
+ publ
nastra commented on PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#issuecomment-1822571206
> Btw, should I squash the commits together or you will do that when merging
the pr?
commits will be squashed when the PR is getting merged, so it's up to you if
you want to squash
nastra commented on code in PR #9048:
URL: https://github.com/apache/iceberg/pull/9048#discussion_r1401887508
##
build.gradle:
##
@@ -948,6 +948,48 @@ project(':iceberg-snowflake') {
}
}
+project(':iceberg-tencentcloud') {
+ test {
+useJUnitPlatform()
+ }
+
+ depend
nastra commented on code in PR #9048:
URL: https://github.com/apache/iceberg/pull/9048#discussion_r1401886198
##
build.gradle:
##
@@ -948,6 +948,48 @@ project(':iceberg-snowflake') {
}
}
+project(':iceberg-tencentcloud') {
+ test {
+useJUnitPlatform()
+ }
+
+ depend
ajantha-bhat commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1401883956
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieViewOperations.java:
##
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
nastra commented on code in PR #9048:
URL: https://github.com/apache/iceberg/pull/9048#discussion_r1401883707
##
build.gradle:
##
@@ -948,6 +948,48 @@ project(':iceberg-snowflake') {
}
}
+project(':iceberg-tencentcloud') {
+ test {
+useJUnitPlatform()
+ }
+
+ depend
nastra commented on code in PR #9048:
URL: https://github.com/apache/iceberg/pull/9048#discussion_r1401825158
##
tencent/src/test/java/org/apache/iceberg/tencentcloud/cos/TestCosClientFactories.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
pvary commented on code in PR #9011:
URL: https://github.com/apache/iceberg/pull/9011#discussion_r1401876287
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##
@@ -207,11 +195,15 @@ protected void doCommit(TableMetadata base, TableMetadata
meta
pvary commented on PR #9120:
URL: https://github.com/apache/iceberg/pull/9120#issuecomment-1822550315
@cgpoh: Please run `./gradlew spotlessApply` before pushing the changes to
fix splotless errors and minimally `./gradlew build -x test -x javadoc -x
integrationTest` to catch checkstyle err
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1401866044
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,451 @@
+/*
+ * Licensed to the Apache Softw
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1401857507
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,434 @@
+/*
+ * Licensed to the Apache Softw
lisirrx commented on PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#issuecomment-1822488153
> just a few small things to fix, but overall this LGTM.
>
> I also checked how the env variables are being used and they are not set
by our CI. They were introduced by #3687, so pi
nastra commented on code in PR #9048:
URL: https://github.com/apache/iceberg/pull/9048#discussion_r1401806041
##
tencent/src/test/java/org/apache/iceberg/tencentcloud/cos/TestCosFileIO.java:
##
@@ -0,0 +1,166 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1401803993
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,434 @@
+/*
+ * Licensed to the Apache Softw
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1401800615
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,434 @@
+/*
+ * Licensed to the Apache Softw
nastra commented on code in PR #9122:
URL: https://github.com/apache/iceberg/pull/9122#discussion_r1401773295
##
aliyun/src/test/java/org/apache/iceberg/aliyun/TestAliyunClientFactories.java:
##
@@ -22,43 +22,45 @@
import java.util.Map;
import org.apache.iceberg.relocated.com.
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1401797073
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,434 @@
+/*
+ * Licensed to the Apache Softw
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1401790452
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##
@@ -0,0 +1,434 @@
+/*
+ * Licensed to the Apache Softw
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1401785416
##
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailoverWithWatermarkExtractor.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apac
pvary commented on code in PR #8553:
URL: https://github.com/apache/iceberg/pull/8553#discussion_r1401784310
##
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/reader/ColumnStatsWatermarkExtractor.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software
1 - 100 of 117 matches
Mail list logo
