[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424435#comment-17424435
]
Uwe Schindler commented on LUCENE-10143:
I merged the pull request. I think thi
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424433#comment-17424433
]
ASF subversion and git services commented on LUCENE-10143:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424426#comment-17424426
]
Robert Muir commented on LUCENE-10143:
--
I opened LUCENE-10148 to improve the docum
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424387#comment-17424387
]
Robert Muir commented on LUCENE-10143:
--
I don't think we should make these interfa
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424334#comment-17424334
]
Uwe Schindler commented on LUCENE-10143:
I think we were all a bit overreacting
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424332#comment-17424332
]
Uwe Schindler commented on LUCENE-10143:
Hi,
I opened a new pull request to fix
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424121#comment-17424121
]
Robert Muir commented on LUCENE-10143:
--
I also think the DataInput vs IndexInput c
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424107#comment-17424107
]
Uwe Schindler commented on LUCENE-10143:
bq. One issue: Lots of DataInput/Outpu
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424104#comment-17424104
]
Robert Muir commented on LUCENE-10143:
--
I didn't mean it that way, I mean look at
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424103#comment-17424103
]
Uwe Schindler commented on LUCENE-10143:
qb. ByteBuffersDataInput (also used by
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424099#comment-17424099
]
Uwe Schindler commented on LUCENE-10143:
bq. In general, I'm gonna say the "inc
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424075#comment-17424075
]
Robert Muir commented on LUCENE-10143:
--
In general, I'm gonna say the "incomplete
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424068#comment-17424068
]
Robert Muir commented on LUCENE-10143:
--
And none of those issues above are caused
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424063#comment-17424063
]
Robert Muir commented on LUCENE-10143:
--
{quote}
The issue here is more specific to
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424062#comment-17424062
]
Uwe Schindler commented on LUCENE-10143:
Maybe we can use project Lombok to aut
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424053#comment-17424053
]
Uwe Schindler commented on LUCENE-10143:
Hi,
maybe we can use ECJ, not sure. E
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424040#comment-17424040
]
Uwe Schindler commented on LUCENE-10143:
bq. +1 to reopen the PR and merge as-i
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424039#comment-17424039
]
Uwe Schindler commented on LUCENE-10143:
My alternate proposal would be to add
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424037#comment-17424037
]
Uwe Schindler commented on LUCENE-10143:
Hi,
in general I am fine with the PR,
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424025#comment-17424025
]
Adrien Grand commented on LUCENE-10143:
---
+1 to reopen the PR and merge as-is
> R
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423897#comment-17423897
]
Dawid Weiss commented on LUCENE-10143:
--
Sounds reasonable to me.
> RateLimitedInd
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423890#comment-17423890
]
Robert Muir commented on LUCENE-10143:
--
I really think we need to devise a differe
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423786#comment-17423786
]
Dawid Weiss commented on LUCENE-10143:
--
If the experience is similar to java's Buf
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423783#comment-17423783
]
Adrien Grand commented on LUCENE-10143:
---
I was thinking of either adding an inter
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423773#comment-17423773
]
Dawid Weiss commented on LUCENE-10143:
--
How would you know when it's flushed thoug
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423697#comment-17423697
]
Adrien Grand commented on LUCENE-10143:
---
I wonder how much overhead RateLimitedIn
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423588#comment-17423588
]
Robert Muir commented on LUCENE-10143:
--
I have a prototype like this. will make a
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423586#comment-17423586
]
Uwe Schindler commented on LUCENE-10143:
I am fine with adding abstract, but on
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423580#comment-17423580
]
Dawid Weiss commented on LUCENE-10143:
--
If these methods are so crucial for perfor
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423579#comment-17423579
]
Robert Muir commented on LUCENE-10143:
--
Why not just make it abstract, forcing the
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423576#comment-17423576
]
Uwe Schindler commented on LUCENE-10143:
+1 for the fix.
It is not a one liner
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423575#comment-17423575
]
Robert Muir commented on LUCENE-10143:
--
if we want to do it, we could also move th
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423574#comment-17423574
]
Robert Muir commented on LUCENE-10143:
--
I made DataInput.readInt/readShort/readLon
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423571#comment-17423571
]
Robert Muir commented on LUCENE-10143:
--
That's the solution. Especially since it i
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423565#comment-17423565
]
Adrien Grand commented on LUCENE-10143:
---
bq. I wish we could statically check tha
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423564#comment-17423564
]
Adrien Grand commented on LUCENE-10143:
---
I found this by looking at nightly profi
[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423561#comment-17423561
]
Michael McCandless commented on LUCENE-10143:
-
Whoa, great catch! I wish w
37 matches
Mail list logo
