Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114861465
--- Diff: libminifi/include/core/FlowConfiguration.h ---
@@ -55,8 +56,9 @@ class FlowConfiguration : public CoreComponent {
* Constructor tha
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114864639
--- Diff: libminifi/include/EventDrivenSchedulingAgent.h ---
@@ -38,8 +38,8 @@ class EventDrivenSchedulingAgent : public
ThreadedSchedulingAgent {
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114863373
--- Diff: libminifi/include/FlowController.h ---
@@ -64,8 +64,9 @@ class FlowController : public core::CoreComponent {
/**
* Flow cont
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114861428
--- Diff: libminifi/include/core/ConfigurationFactory.h ---
@@ -30,25 +30,29 @@ namespace core {
template
typename std::enable_if::va
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114861939
--- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
@@ -41,10 +42,12 @@ namespace core {
class YamlConfiguration : public FlowConfigur
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114860818
--- Diff: libminifi/include/FlowController.h ---
@@ -64,8 +64,9 @@ class FlowController : public core::CoreComponent {
/**
* Flow cont
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114792714
--- Diff: libminifi/src/io/ClientSocket.cpp ---
@@ -39,7 +40,7 @@ namespace io {
char *Socket::HOSTNAME =
const_cast(Socket::getMyHostNam
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114792218
--- Diff: libminifi/include/core/Processor.h ---
@@ -243,7 +244,7 @@ class Processor : public Connectable, public
ConfigurableComponent,
std:
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91#discussion_r114793189
--- Diff: libminifi/src/io/tls/TLSSocket.cpp ---
@@ -31,14 +32,11 @@ namespace nifi {
namespace minifi {
namespace io {
-std::ato
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91
MINIFI-258 - Removing Configure, StreamFactory, TLSContext singletons
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the
11 matches
Mail list logo
