[GitHub] [solr] dsmiley commented on a change in pull request #560: SOLR-15951: Local packages

2022-01-25 Thread GitBox
dsmiley commented on a change in pull request #560: URL: https://github.com/apache/solr/pull/560#discussion_r792307699 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageLoader.java ## @@ -56,9 +52,12 @@ public class PackageLoader implements Closeable { private sta

[GitHub] [solr] dsmiley commented on pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-25 Thread GitBox
dsmiley commented on pull request #529: URL: https://github.com/apache/solr/pull/529#issuecomment-1021848332 I was chatting with Mike about splitting this vs not. It's fine to not split this, and instead edit the PR title to refer to the parent issue about Filter disappearing. I'll handl

[jira] [Commented] (SOLR-15951) Local packages

2022-01-25 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482225#comment-17482225 ] Noble Paul commented on SOLR-15951: --- [~dsmiley] That sounds like a good idea. I have

[GitHub] [solr] dsmiley commented on pull request #559: SOLR-15715: coordinator role

2022-01-25 Thread GitBox
dsmiley commented on pull request #559: URL: https://github.com/apache/solr/pull/559#issuecomment-1021842200 > use `!` rather than `== false`, no? Using `== false` is especially prevalent in Lucene and it's a deliberate choice; I prefer it as well. It reads in a more obvious way. T

[GitHub] [solr] dsmiley commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-25 Thread GitBox
dsmiley commented on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1021837229 When doing any non-trivial change to dependencies (as was done here), I strongly recommend reading what Dawid wrote: `help/dependencies.txt`. In particular, I find this useful:

[jira] [Commented] (SOLR-15918) Many NodeExistsExceptions when uploading a configset

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482217#comment-17482217 ] ASF subversion and git services commented on SOLR-15918: Commit f

[jira] [Created] (SOLR-15955) Update Jetty dependency to 10

2022-01-25 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-15955: - Summary: Update Jetty dependency to 10 Key: SOLR-15955 URL: https://issues.apache.org/jira/browse/SOLR-15955 Project: Solr Issue Type: Task S

[jira] [Updated] (SOLR-15918) Many NodeExistsExceptions when uploading a configset

2022-01-25 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated SOLR-15918: - Fix Version/s: 9.1 > Many NodeExistsExceptions when uploading a configset > -

[jira] [Commented] (SOLR-15918) Many NodeExistsExceptions when uploading a configset

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482213#comment-17482213 ] ASF subversion and git services commented on SOLR-15918: Commit 0

[GitHub] [solr] madrob merged pull request #554: SOLR-15918 Avoid repetitive creating parent znodes

2022-01-25 Thread GitBox
madrob merged pull request #554: URL: https://github.com/apache/solr/pull/554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[jira] [Commented] (SOLR-15715) Dedicated query aggregator nodes in the solr cluster.

2022-01-25 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482198#comment-17482198 ] Mike Drob commented on SOLR-15715: -- Copying a comment I made on the PR because I think i

[GitHub] [solr] madrob commented on a change in pull request #559: SOLR-15715: coordinator role

2022-01-25 Thread GitBox
madrob commented on a change in pull request #559: URL: https://github.com/apache/solr/pull/559#discussion_r792283834 ## File path: solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java ## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [solr] dsmiley commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
dsmiley commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792281270 ## File path: solr/core/src/java/org/apache/solr/update/UpdateHandler.java ## @@ -115,12 +115,9 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog) {

[GitHub] [solr] dsmiley commented on a change in pull request #557: SOLR-15914 Make it super simple to add a contrib module to shared classpath

2022-01-25 Thread GitBox
dsmiley commented on a change in pull request #557: URL: https://github.com/apache/solr/pull/557#discussion_r792280103 ## File path: solr/core/src/java/org/apache/solr/util/ModuleUtils.java ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] madrob commented on a change in pull request #559: SOLR-15715: coordinator role

2022-01-25 Thread GitBox
madrob commented on a change in pull request #559: URL: https://github.com/apache/solr/pull/559#discussion_r792278895 ## File path: solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[jira] [Commented] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-01-25 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482175#comment-17482175 ] Mike Drob commented on SOLR-15556: -- I addressed a few of the TODOs that we talked about

[jira] [Comment Edited] (SOLR-15755) Parse collection, shard, core, replica info from newSearcher events in postlogs tool

2022-01-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482141#comment-17482141 ] Joel Bernstein edited comment on SOLR-15755 at 1/25/22, 11:36 PM: -

[jira] [Commented] (SOLR-15755) Parse collection, shard, core, replica info from newSearcher events in postlogs tool

2022-01-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482141#comment-17482141 ] Joel Bernstein commented on SOLR-15755: --- Latest patch fixes a bug in the postlogs s

[jira] [Updated] (SOLR-15755) Parse collection, shard, core, replica info from newSearcher events in postlogs tool

2022-01-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15755: -- Fix Version/s: 9.0 > Parse collection, shard, core, replica info from newSearcher events in >

[jira] [Updated] (SOLR-15755) Parse collection, shard, core, replica info from newSearcher events in postlogs tool

2022-01-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15755: -- Attachment: SOLR-15755-1.patch > Parse collection, shard, core, replica info from newSearcher e

[GitHub] [solr] madrob commented on pull request #554: SOLR-15918 Avoid repetitive creating parent znodes

2022-01-25 Thread GitBox
madrob commented on pull request #554: URL: https://github.com/apache/solr/pull/554#issuecomment-1021658751 I don't have anything measured, the benefit is reduced reqs to zookeeper. 9.1 is fine -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (SOLR-15605) Duplicate jars copied in prometheus-exporter

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482121#comment-17482121 ] ASF subversion and git services commented on SOLR-15605: Commit 8

[jira] [Resolved] (SOLR-15605) Duplicate jars copied in prometheus-exporter

2022-01-25 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-15605. --- Resolution: Fixed > Duplicate jars copied in prometheus-exporter > --

[jira] [Assigned] (SOLR-15954) Move the Prometheus Exporter out from under modules/

2022-01-25 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman reassigned SOLR-15954: - Assignee: Houston Putman > Move the Prometheus Exporter out from under modules/ > --

[jira] [Comment Edited] (SOLR-15755) Parse collection, shard, core info from newSearcher events in postlogs tool

2022-01-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482120#comment-17482120 ] Joel Bernstein edited comment on SOLR-15755 at 1/25/22, 9:50 PM: --

[jira] [Updated] (SOLR-15755) Parse collection, shard, core, replica info from newSearcher events in postlogs tool

2022-01-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15755: -- Summary: Parse collection, shard, core, replica info from newSearcher events in postlogs tool

[jira] [Commented] (SOLR-15755) Parse collection, shard, core info from newSearcher events in postlogs tool

2022-01-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482120#comment-17482120 ] Joel Bernstein commented on SOLR-15755: --- The patch adds collection_s, shard_s, core

[GitHub] [solr] janhoy commented on pull request #554: SOLR-15918 Avoid repetitive creating parent znodes

2022-01-25 Thread GitBox
janhoy commented on pull request #554: URL: https://github.com/apache/solr/pull/554#issuecomment-1021640558 What would be the benefit of getting this in 9.0? Have you measured a performance benefit? mid there is no clear benefit or bug fix perhaps this can wait until 9.1? -- This

[jira] [Assigned] (SOLR-15755) Parse collection, shard, core info from newSearcher events in postlogs tool

2022-01-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein reassigned SOLR-15755: - Assignee: Joel Bernstein > Parse collection, shard, core info from newSearcher events in

[jira] [Commented] (SOLR-15605) Duplicate jars copied in prometheus-exporter

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482118#comment-17482118 ] ASF subversion and git services commented on SOLR-15605: Commit 1

[jira] [Commented] (SOLR-15605) Duplicate jars copied in prometheus-exporter

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482119#comment-17482119 ] ASF subversion and git services commented on SOLR-15605: Commit a

[jira] [Updated] (SOLR-15755) Parse collection, shard, core info from newSearcher events in postlogs tool

2022-01-25 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15755: -- Attachment: SOLR-15755.patch > Parse collection, shard, core info from newSearcher events in po

[GitHub] [solr] madrob edited a comment on pull request #565: SOLR-15745: Move public v2 "core-admin" APIs to annotation framework

2022-01-25 Thread GitBox
madrob edited a comment on pull request #565: URL: https://github.com/apache/solr/pull/565#issuecomment-1021636009 Put the new ones inside, leave the old ones? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [solr] madrob commented on pull request #565: SOLR-15745: Move public v2 "core-admin" APIs to annotation framework

2022-01-25 Thread GitBox
madrob commented on pull request #565: URL: https://github.com/apache/solr/pull/565#issuecomment-1021636009 Put the new ones inside, leave them old ones? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [solr] HoustonPutman merged pull request #563: SOLR-15605: Fix duplicate jars in prometheus-exporter

2022-01-25 Thread GitBox
HoustonPutman merged pull request #563: URL: https://github.com/apache/solr/pull/563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [solr] janhoy commented on pull request #564: SOLR-15954: Move the Prometheus Exporter from modules

2022-01-25 Thread GitBox
janhoy commented on pull request #564: URL: https://github.com/apache/solr/pull/564#issuecomment-1021634425 Great. Did not check the new refguide link, makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792131153 ## File path: solr/contrib/hdfs/src/java/org/apache/solr/update/HdfsUpdateLog.java ## @@ -44,9 +44,7 @@ /** * @lucene.experimental Review comm

[GitHub] [solr] risdenk commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
risdenk commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792131123 ## File path: solr/contrib/hdfs/src/java/org/apache/solr/update/HdfsUpdateLog.java ## @@ -44,9 +44,7 @@ /** * @lucene.experimental Review comment:

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792131065 ## File path: solr/contrib/hdfs/src/java/org/apache/solr/store/hdfs/HdfsFileWriter.java ## @@ -30,9 +30,7 @@ /** * @lucene.experimental Revie

[GitHub] [solr] risdenk commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
risdenk commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792131051 ## File path: solr/contrib/hdfs/src/java/org/apache/solr/store/hdfs/HdfsFileWriter.java ## @@ -30,9 +30,7 @@ /** * @lucene.experimental Review comment:

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792130767 ## File path: solr/contrib/hdfs/src/java/org/apache/solr/store/hdfs/HdfsFileWriter.java ## @@ -30,9 +30,7 @@ /** * @lucene.experimental Revie

[GitHub] [solr] risdenk commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
risdenk commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792130743 ## File path: solr/contrib/hdfs/src/java/org/apache/solr/store/hdfs/HdfsFileWriter.java ## @@ -30,9 +30,7 @@ /** * @lucene.experimental Review comment:

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792127392 ## File path: solr/contrib/hdfs/src/java/org/apache/solr/core/backup/repository/HdfsBackupRepository.java ## @@ -46,10 +46,6 @@ import org.slf4j.L

[GitHub] [solr] risdenk commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
risdenk commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792127370 ## File path: solr/contrib/hdfs/src/java/org/apache/solr/core/backup/repository/HdfsBackupRepository.java ## @@ -46,10 +46,6 @@ import org.slf4j.Logger; imp

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792126971 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/api/collections/AbstractCollectionsAPIDistributedZkTestBase.java ## @@ -0,0 +1,645

[GitHub] [solr] risdenk commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
risdenk commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792126945 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/api/collections/AbstractCollectionsAPIDistributedZkTestBase.java ## @@ -0,0 +1,645 @@ +/* + *

[jira] [Commented] (SOLR-14595) json.facet subfacet 'sort:"index asc", refine:true' can return diff results using method:enum

2022-01-25 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482106#comment-17482106 ] Michael Gibney commented on SOLR-14595: --- Pending further feedback, I plan to commit

[jira] [Resolved] (SOLR-9376) RawValueTransformerFactory ([json] & [xml]) don't work in SolrCloud

2022-01-25 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney resolved SOLR-9376. -- Resolution: Fixed > RawValueTransformerFactory ([json] & [xml]) don't work in SolrCloud > --

[jira] [Commented] (SOLR-9376) RawValueTransformerFactory ([json] & [xml]) don't work in SolrCloud

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482099#comment-17482099 ] ASF subversion and git services commented on SOLR-9376: --- Commit

[GitHub] [solr] gerlowskija closed pull request #72: SOLR-15090: Update developer licensing README

2022-01-25 Thread GitBox
gerlowskija closed pull request #72: URL: https://github.com/apache/solr/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (SOLR-9376) RawValueTransformerFactory ([json] & [xml]) don't work in SolrCloud

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482092#comment-17482092 ] ASF subversion and git services commented on SOLR-9376: --- Commit 0897

[GitHub] [solr] warperwolf commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
warperwolf commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792077208 ## File path: solr/contrib/README.md ## @@ -0,0 +1,31 @@ +Apache Solr HDFS Contrib module Review comment: Fixed (https://github.com/apache/solr/pul

[GitHub] [solr] warperwolf commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-25 Thread GitBox
warperwolf commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r792076791 ## File path: solr/contrib/hdfs/.gitignore ## @@ -0,0 +1,2 @@ +# IDEA project file +hdfs.iml Review comment: Done (https://github.com/apache/solr/p

[GitHub] [solr] madrob commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-25 Thread GitBox
madrob commented on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1021553232 @risdenk I get several failures when trying to build this - jar license errors, and then also this one which is pretty weird from `ecjLint`: ``` import javax.xml.str

[GitHub] [solr] madrob commented on a change in pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-25 Thread GitBox
madrob commented on a change in pull request #553: URL: https://github.com/apache/solr/pull/553#discussion_r792068327 ## File path: solr/test-framework/src/java/org/apache/solr/util/BadHdfsThreadsFilter.java ## @@ -41,6 +41,10 @@ public boolean reject(Thread t) { return

[jira] [Commented] (SOLR-9376) RawValueTransformerFactory ([json] & [xml]) don't work in SolrCloud

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482071#comment-17482071 ] ASF subversion and git services commented on SOLR-9376: --- Commit 6ff8

[GitHub] [solr] magibney merged pull request #513: SOLR-9376: [xml] and [json] RawValue DocTransformers should work in cloud mode

2022-01-25 Thread GitBox
magibney merged pull request #513: URL: https://github.com/apache/solr/pull/513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Updated] (SOLR-15045) 2x latency of synchronous commits due to serial execution on local and distributed leaders

2022-01-25 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney updated SOLR-15045: -- Fix Version/s: main (10.0) > 2x latency of synchronous commits due to serial execution on local

[jira] [Assigned] (SOLR-15045) 2x latency of synchronous commits due to serial execution on local and distributed leaders

2022-01-25 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney reassigned SOLR-15045: - Assignee: Michael Gibney > 2x latency of synchronous commits due to serial execution on

[jira] [Commented] (SOLR-15045) 2x latency of synchronous commits due to serial execution on local and distributed leaders

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482054#comment-17482054 ] ASF subversion and git services commented on SOLR-15045: Commit d

[GitHub] [solr] magibney merged pull request #545: SOLR-15045: DistributedZkUpdateProcessor should issue commits to local shards and remote shards in parallel

2022-01-25 Thread GitBox
magibney merged pull request #545: URL: https://github.com/apache/solr/pull/545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [solr] gerlowskija commented on pull request #565: SOLR-15745: Move public v2 "core-admin" APIs to annotation framework

2022-01-25 Thread GitBox
gerlowskija commented on pull request #565: URL: https://github.com/apache/solr/pull/565#issuecomment-1021504830 > There are 430 results for "Indexes", and honestly, the more I think on it, I think that while "Indices" may be grammatically correct, "Indexes" is really the word we use! At a

[jira] [Commented] (SOLR-14595) json.facet subfacet 'sort:"index asc", refine:true' can return diff results using method:enum

2022-01-25 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482048#comment-17482048 ] Michael Gibney commented on SOLR-14595: --- Thanks, Hoss. I'm happy to remove the expl

[jira] [Updated] (SOLR-15912) Update Guava to 31.0.1

2022-01-25 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-15912: Fix Version/s: (was: 9.0) > Update Guava to 31.0.1 > -- > >

[GitHub] [solr-operator] HoustonPutman commented on issue #399: Random Loss of Credentials

2022-01-25 Thread GitBox
HoustonPutman commented on issue #399: URL: https://github.com/apache/solr-operator/issues/399#issuecomment-1021467149 Then I don't think there would be any issue from the solr-operator beyond the ephemeral storage for ZK... Update this ticket when you've tried that out. -- This i

[GitHub] [solr-operator] nickumia-reisys commented on issue #399: Random Loss of Credentials

2022-01-25 Thread GitBox
nickumia-reisys commented on issue #399: URL: https://github.com/apache/solr-operator/issues/399#issuecomment-1021462700 > What do you mean by refreshed. I'm assuming you created a new authentication keypair and deleted the old one using your terraform scripts? Yes, using the terrafo

[GitHub] [solr] risdenk commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-25 Thread GitBox
risdenk commented on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1021461272 @madrob think I addressed your concerns. Removed copy of `HttpServer2` since not needed anymore, updated `package-info.java` and fixed comment. @janhoy still working on `Do yo

[GitHub] [solr] risdenk commented on a change in pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-25 Thread GitBox
risdenk commented on a change in pull request #553: URL: https://github.com/apache/solr/pull/553#discussion_r791983469 ## File path: solr/test-framework/src/java/org/apache/solr/util/BadHdfsThreadsFilter.java ## @@ -41,6 +41,10 @@ public boolean reject(Thread t) { retur

[jira] [Resolved] (SOLR-15953) investigate LTRThreadModule.preClose code

2022-01-25 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-15953. Fix Version/s: 9.0 main (10.0) Resolution: Fixed > invest

[jira] [Commented] (SOLR-15953) investigate LTRThreadModule.preClose code

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481991#comment-17481991 ] ASF subversion and git services commented on SOLR-15953: Commit 6

[jira] [Commented] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-01-25 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481988#comment-17481988 ] Mike Drob commented on SOLR-15556: -- The RAT check fails too. I looked into it a little

[jira] [Commented] (SOLR-15953) investigate LTRThreadModule.preClose code

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481989#comment-17481989 ] ASF subversion and git services commented on SOLR-15953: Commit 6

[GitHub] [solr-operator] HoustonPutman commented on issue #399: Random Loss of Credentials

2022-01-25 Thread GitBox
HoustonPutman commented on issue #399: URL: https://github.com/apache/solr-operator/issues/399#issuecomment-1021438197 > Also, since the zookeepers have ephemeral storage too, would the `security.json` with the credentials possibly be lost on replace/restarts? 🤔 That is certainly pos

[jira] [Commented] (SOLR-15953) investigate LTRThreadModule.preClose code

2022-01-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481985#comment-17481985 ] ASF subversion and git services commented on SOLR-15953: Commit 9

[GitHub] [solr] cpoerschke merged pull request #562: SOLR-15953: remove unused LTRThreadModule.preClose CloseHook logic

2022-01-25 Thread GitBox
cpoerschke merged pull request #562: URL: https://github.com/apache/solr/pull/562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr] cpoerschke commented on pull request #493: Update copyright years in solr/NOTICE.txt file.

2022-01-25 Thread GitBox
cpoerschke commented on pull request #493: URL: https://github.com/apache/solr/pull/493#issuecomment-1021431136 @janhoy is it okay to merge and backport this to branch_9_0 also? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [solr-operator] HoustonPutman opened a new issue #401: Track the incompatibilities introduced in Solr 9

2022-01-25 Thread GitBox
HoustonPutman opened a new issue #401: URL: https://github.com/apache/solr-operator/issues/401 This is a running list and will be updated overtime. - Solr modules have moved from contrib/ to modules/ (SOLR-15917) - This may not be an issue. We can double-add the modules in an old

[GitHub] [solr] epugh commented on a change in pull request #565: SOLR-15745: Move public v2 "core-admin" APIs to annotation framework

2022-01-25 Thread GitBox
epugh commented on a change in pull request #565: URL: https://github.com/apache/solr/pull/565#discussion_r791754028 ## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ## @@ -48,18 +45,21 @@ import org.apache.solr.response.SolrQueryResponse; import org.a

[GitHub] [solr] madrob commented on pull request #565: SOLR-15745: Move public v2 "core-admin" APIs to annotation framework

2022-01-25 Thread GitBox
madrob commented on pull request #565: URL: https://github.com/apache/solr/pull/565#issuecomment-1021356353 Would it make sense to move the Payload classes into the API classes? I think that's the only place they are used? -- This is an automated message from the Apache Git Service. To r

[GitHub] [solr] cpoerschke commented on pull request #562: SOLR-15953: remove unused LTRThreadModule.preClose CloseHook logic

2022-01-25 Thread GitBox
cpoerschke commented on pull request #562: URL: https://github.com/apache/solr/pull/562#issuecomment-1020383355 ``` - public final class LTRThreadModule implements CloseHook, NamedListInitializedPlugin + public final class LTRThreadModule implements NamedListInitializedPlugin ```

[GitHub] [solr] HoustonPutman commented on a change in pull request #560: SOLR-15951: Local packages

2022-01-25 Thread GitBox
HoustonPutman commented on a change in pull request #560: URL: https://github.com/apache/solr/pull/560#discussion_r791131452 ## File path: solr/core/src/test/org/apache/solr/pkg/TestPackages.java ## @@ -61,6 +61,7 @@ import org.junit.Before; import org.junit.Test; +import j

[GitHub] [solr] madrob commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-25 Thread GitBox
madrob commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r791040364 ## File path: solr/core/src/java/org/apache/solr/search/BitDocSet.java ## @@ -311,72 +307,8 @@ public long cost() { }; } - @Override - public Filter

[GitHub] [solr] gerlowskija commented on a change in pull request #565: SOLR-15745: Move public v2 "core-admin" APIs to annotation framework

2022-01-25 Thread GitBox
gerlowskija commented on a change in pull request #565: URL: https://github.com/apache/solr/pull/565#discussion_r791886377 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/SplitCorePayload.java ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Soft

[GitHub] [solr] gerlowskija commented on pull request #565: SOLR-15745: Move public v2 "core-admin" APIs to annotation framework

2022-01-25 Thread GitBox
gerlowskija commented on pull request #565: URL: https://github.com/apache/solr/pull/565#issuecomment-1021285346 > why not fix "indexes" spelling now? Two "soft" reasons: 1. It's hard to imagine anyone caring about "indexes" in particular, but in theory I could imagine someone

[GitHub] [solr-operator] hrvolapeter commented on issue #393: GKE Autopilot constant re-deployment of pods

2022-01-25 Thread GitBox
hrvolapeter commented on issue #393: URL: https://github.com/apache/solr-operator/issues/393#issuecomment-1020441408 Hi @HoustonPutman thanks for taking a look. I'm not using VerticalPodAutoscaler at least not knowingly, however the autopilot changing resources is based on [this](ht

[jira] [Commented] (SOLR-15951) Local packages

2022-01-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481959#comment-17481959 ] David Smiley commented on SOLR-15951: - Would it be possible for a "local package" to

[GitHub] [solr] madrob merged pull request #544: SOLR-15919 Another pass as moving File to Path

2022-01-25 Thread GitBox
madrob merged pull request #544: URL: https://github.com/apache/solr/pull/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] epugh commented on pull request #565: SOLR-15745: Move public v2 "core-admin" APIs to annotation framework

2022-01-25 Thread GitBox
epugh commented on pull request #565: URL: https://github.com/apache/solr/pull/565#issuecomment-1021220555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [solr] HoustonPutman commented on pull request #564: SOLR-15954: Move the Prometheus Exporter from modules

2022-01-25 Thread GitBox
HoustonPutman commented on pull request #564: URL: https://github.com/apache/solr/pull/564#issuecomment-1021322512 > I was going to builda Docker image from the binary distro to test the exporter from docker, but looking in docker/ folder in binary distro, there is no description on how to

[jira] [Commented] (SOLR-15501) GCSBackupRepository - allow bucket connection without credentials

2022-01-25 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481957#comment-17481957 ] Jason Gerlowski commented on SOLR-15501: I went to backport the fix for this issu

[GitHub] [solr] epugh closed pull request #565: SOLR-15745: Move public v2 "core-admin" APIs to annotation framework

2022-01-25 Thread GitBox
epugh closed pull request #565: URL: https://github.com/apache/solr/pull/565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@so

[GitHub] [solr] HoustonPutman commented on a change in pull request #557: SOLR-15914 Make it super simple to add a contrib module to shared classpath

2022-01-25 Thread GitBox
HoustonPutman commented on a change in pull request #557: URL: https://github.com/apache/solr/pull/557#discussion_r791859891 ## File path: solr/CHANGES.txt ## @@ -564,7 +566,7 @@ Bug Fixes * SOLR-15944: The Tagger's JSON response format now always uses an object/map to repres

[GitHub] [solr-operator] nickumia-reisys commented on issue #399: Random Loss of Credentials

2022-01-25 Thread GitBox
nickumia-reisys commented on issue #399: URL: https://github.com/apache/solr-operator/issues/399#issuecomment-1021277255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [solr] dsmiley commented on a change in pull request #560: SOLR-15951: Local packages

2022-01-25 Thread GitBox
dsmiley commented on a change in pull request #560: URL: https://github.com/apache/solr/pull/560#discussion_r791227809 ## File path: solr/core/src/test/org/apache/solr/pkg/TestLocalPackages.java ## @@ -0,0 +1,101 @@ +package org.apache.solr.pkg; + +import java.io.File; +import

[GitHub] [solr] madrob commented on pull request #554: SOLR-15918 Avoid repetitive creating parent znodes

2022-01-25 Thread GitBox
madrob commented on pull request #554: URL: https://github.com/apache/solr/pull/554#issuecomment-1021380232 @janhoy I would like to include this in 9.0 I feel it is safe to commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [solr] alessandrobenedetti merged pull request #476: SOLR-15880: K Nearest Neighbors Search

2022-01-25 Thread GitBox
alessandrobenedetti merged pull request #476: URL: https://github.com/apache/solr/pull/476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [solr] madrob commented on a change in pull request #559: SOLR-15715: coordinator role

2022-01-25 Thread GitBox
madrob commented on a change in pull request #559: URL: https://github.com/apache/solr/pull/559#discussion_r791157908 ## File path: solr/core/src/java/org/apache/solr/request/SolrQueryRequest.java ## @@ -153,6 +156,21 @@ default Tracer getTracer() { default Span getSpan() {

[GitHub] [solr-operator] gerlowskija closed issue #391: Make .spec.backupRepositories[].gcs.gcsCredentialSecret optional

2022-01-25 Thread GitBox
gerlowskija closed issue #391: URL: https://github.com/apache/solr-operator/issues/391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-25 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r791125848 ## File path: solr/core/src/java/org/apache/solr/search/BitDocSet.java ## @@ -311,72 +307,8 @@ public long cost() { }; } - @Override - public Filte

[GitHub] [solr] Caa52 commented on pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-25 Thread GitBox
Caa52 commented on pull request #529: URL: https://github.com/apache/solr/pull/529#issuecomment-1020417262 I rebased and force pushed the latest commit to due to recent changes in `CHANGES.txt` renaming `contrib` to `module` -- This is an automated message from the Apache Git Service. To

  1   2   >