Re: Jakarta James Nightly Build

2002-08-18 Thread Stephen McConnell
Paul Hammant wrote: > Stephen, > >>> To more knowledgeable heads than I, >>> >>> Noel and I have been looking at the nightly build process and are a >>> little disturbed by the fact that: >>> >>> i) It is failing >>> ii) It is failing without notifying james-dev >>> >> >> This explains a lot.

RE: NNTP auth issues

2002-08-18 Thread Noel J. Bergman
Paul, FYI, the NNTP code is not a Mailet. :-) It is one of these: public class AuthServiceImpl extends AbstractLogEnabled implements AuthService, Composable, Configurable and acquired by the NNTPHandler like this: auth = (AuthService)componentManager.lookup("org.apache.james.nntpserver

Re: NNTP auth issues

2002-08-18 Thread Paul Hammant
Noel, Jason, >Shouldn't be any different. Did you make any progress on this? > >You might want to ask Paul Hammant to take a look at it. For example, I >don't know what the relationship is between the .xinfo files and things like >the assembly file, but the .xinfo for the nntp server doesn't h

Re: Jakarta James Nightly Build

2002-08-18 Thread Paul Hammant
Stephen, >> To more knowledgeable heads than I, >> >> Noel and I have been looking at the nightly build process and are a >> little disturbed by the fact that: >> >> i) It is failing >> ii) It is failing without notifying james-dev >> > > This explains a lot. With no notification of failures, th

Re: Jakarta James Nightly Build

2002-08-18 Thread Paul Hammant
Peter, >To more knowledgeable heads than I, > >Noel and I have been looking at the nightly build process and are a >little disturbed by the fact that: > >i) It is failing >ii) It is failing without notifying james-dev > >See the nightly build report here: > >http://jakarta.apache.org/builds/gump/

RE: Jakarta James Nightly Build

2002-08-18 Thread Noel J. Bergman
> This explains a lot. With no notification of failures, the Avalon > Community have been moving along in ignorant bliss (relative to the > James Commnity). There are Avalon developers here on this mailing list aware of what is going on. Some months ago, Paul Hammant kindly offered to keep Jame

Re: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Tetsuya Kitahata
On Mon, 19 Aug 2002 00:46:55 -0400 "Noel J. Bergman" <[EMAIL PROTECTED]> wrote: > And, of course, this has nothing to do with end user documentation, > such as telling a user how to install and deploy James. You know, > little things like how to setup a mailing list (have fun reading the > docs

Re: First pass Token Counter mailet for ANTI SPAM mailet

2002-08-18 Thread Stephen McConnell
Chris Means wrote: >Hi, > >This is my first attempt at developing a mailet...so if I've made a mistake >about how best to implement this...or if I've just done something dumb in my >code (cos I'm no Java guru either) please let me know. > >I'm following through with a posting I saw on /. regard

Re: NNTP auth issues

2002-08-18 Thread Stephen McConnell
Noel J. Bergman wrote: >Shouldn't be any different. Did you make any progress on this? > >You might want to ask Paul Hammant to take a look at it. For example, I >don't know what the relationship is between the .xinfo files and things like >the assembly file, but the .xinfo for the nntp serve

RE: NNTP auth issues

2002-08-18 Thread Noel J. Bergman
Shouldn't be any different. Did you make any progress on this? You might want to ask Paul Hammant to take a look at it. For example, I don't know what the relationship is between the .xinfo files and things like the assembly file, but the .xinfo for the nntp server doesn't have an entry for the

Re: Jakarta James Nightly Build

2002-08-18 Thread Stephen McConnell
Peter M. Goldstein wrote: >To more knowledgeable heads than I, > >Noel and I have been looking at the nightly build process and are a >little disturbed by the fact that: > >i) It is failing >ii) It is failing without notifying james-dev > This explains a lot. With no notification of failures,

RE: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Noel J. Bergman
> Undocumented non-quality code is NOT pragmatic... in fact: > http://www.pragmaticprogrammer.com/cgi-local/pragprog?FailureHowTo I like how you imply that the James is undocumented and non-quality just because an effort is being made to improve the quality and consistency of the comments. James

config.xml : RE: First pass Token Counter mailet for ANTI SPAM mailet

2002-08-18 Thread Chris Means
I forgot to add sample configuration necessary in config.xml: notSpam db://maildb/filter_goodwords filter_statistics/goodmessages -Chris > -Original Message- > From: Chris Means [ma

First pass Token Counter mailet for ANTI SPAM mailet

2002-08-18 Thread Chris Means
Hi, This is my first attempt at developing a mailet...so if I've made a mistake about how best to implement this...or if I've just done something dumb in my code (cos I'm no Java guru either) please let me know. I'm following through with a posting I saw on /. regarding using word occurance stat

Re: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Tetsuya Kitahata
Hi, Andy and all. On Sun, 18 Aug 2002 23:21:42 -0400 "Andrew C. Oliver" <[EMAIL PROTECTED]> wrote: > To be honest Tetsuya, it makes me scared to use it. Javadoc to me is so > basic and takes so little time, to actually argue against it... To me > this is the same as an argument to write var

Re: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Serge Knystautas
Andrew, If you feel there's something glaringly wrong that should be improved, patches are always greatly welcome. For my money, the only thing that should hold up a release is a volunteer saying they will fix something but won't have it ready until date X. Beyond that, changelogs go out with a

Re: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Andrew C. Oliver
To be honest Tetsuya, it makes me scared to use it. Javadoc to me is so basic and takes so little time, to actually argue against it... To me this is the same as an argument to write variables a1, a2, a3... Its code quality. This is an active argument for poor code quality and I can't belie

Re: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Andrew C. Oliver
> > No, I'm pragmatic and you just don't like it. This isn't about some ivory > tower notion of what makes good code. This is about lots of James users who > are stuck using buggy code and bad documention while we sit here using the > good stuff and arguing over when to deliver it to them. > >

Re: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Tetsuya Kitahata
On Sun, 18 Aug 2002 20:40:35 -0400 "Noel J. Bergman" <[EMAIL PROTECTED]> wrote: > Everyone is agreeing that the documentation is necessary. But javadocs for > developers is not a reason to hold end users hostage. I love this sentence, "But javadocs for developers is not a reason to hold end us

RE: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Noel J. Bergman
> I totally disagree with just about everything Noel said except for the > end. > As long as everyone understands that documentation is as important as > code and that poorly documented code is just pure rat dung. > Code complete, means docs too. That may be your philosophy, and it might even b

Jakarta James Nightly Build

2002-08-18 Thread Peter M. Goldstein
To more knowledgeable heads than I, Noel and I have been looking at the nightly build process and are a little disturbed by the fact that: i) It is failing ii) It is failing without notifying james-dev See the nightly build report here: http://jakarta.apache.org/builds/gump/latest/jakarta-jam

Re: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Andrew C. Oliver
I totally disagree with just about everything Noel said except for the end. Development builds "milestone builds" or whatever, should not be delayed for quality concerns. It just can't be blessed as a release. As long as everyone understands that documentation is as important as code and tha

RE: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Noel J. Bergman
Peter, I agree with almost all of your points. The only ones that I disagree with are: > observation of the changelog indicates, leaving javadoc out vs. > adding javadoc has not made the development any faster. I disagree, in a way that you'll like. I think that accurate javadocs facilitates

RE: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Noel J. Bergman
Vincent Keunen wrote: > > First, I must say that I agree with 2 comments from Noel: > > > Internal Documentation > > > Absolutely necessary. But NOT to hold up the 2.1 release. We can continue > > > to upgrade the web site with new documentation, and any serious developer > > > should be working f

DO NOT REPLY [Bug 11808] New: - 8bitmime capabilities missing

2002-08-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_b

RE: address-literal addressing not working

2002-08-18 Thread Noel J. Bergman
> > How about we make it an optional behavior with a config param? > Ok, a fine compromise, if we add (and document) a section > equivalent to with an autodetect element/parameter, as for > servernames that should allow simple situations to be detected, complex > situations to override it, and

RE: [PATCH] james-config.xml/james.java

2002-08-18 Thread Noel J. Bergman
Danny, I'll be happy to make that change. What attribute name for MailetContext.getAttribute() would you like for me to use? Constants.HELLO_NAME? By "root of the config", do you mean an child element of the section? Do you want this to be an element or an attribute, e.g.,

RE: [PATCH] james-config.xml/james.java

2002-08-18 Thread Danny Angus
I like the servername attribute for remote delivery, I believe that we should actually add it at the root of config, and make it available to all mailets as a parameter in the context, to be added to the mailet API in time. see my other mail regarding ipaddresses. d. > -Original Message-

RE: address-literal addressing not working

2002-08-18 Thread Danny Angus
> I concur with you about the difficulty of matching all the IP addresses. > That should be much easier once we migrate to Java 1.4 (using the > NetworkAddress class), but for now it's definitely a problem for complex > IP setups. However for simple IP setups I think this change would make > life

[PATCH] james-config.xml/james.java

2002-08-18 Thread Noel J. Bergman
This adds the addIPAddresses patch to James.java, along with a corresponding commented entry in the configuration file. The code also changes the Vector to a HashSet to (a) improve lookup performance with lots of domains, and (b) eliminate duplicate IP addresses. As submitted in a separate patch

RE: address-literal addressing not working

2002-08-18 Thread Noel J. Bergman
I'm submitting a patch for it, with embedded comments about future directions for change. Support for address literals is controlled by a new "addIPAddresses" attribute on the element, so that anyone who doesn't want to use it can just turn it off. --- Noel -Original Message- F

cvs commit: jakarta-james/src/java/org/apache/james/transport/mailets Redirect.java

2002-08-18 Thread pgoldstein
pgoldstein2002/08/18 12:19:32 Modified:src/java/org/apache/james/transport/mailets Redirect.java Log: Missed a redundant passthrough on last checkin Revision ChangesPath 1.10 +0 -1 jakarta-james/src/java/org/apache/james/transport/mailets/Redirect.java In

cvs commit: jakarta-james build.xml

2002-08-18 Thread pgoldstein
pgoldstein2002/08/18 12:17:27 Modified:.build.xml Log: Removed tabs from build.xml Revision ChangesPath 1.103 +21 -21jakarta-james/build.xml Index: build.xml === RCS file: /home/cvs/

RE: address-literal addressing not working

2002-08-18 Thread Peter M. Goldstein
Danny, > Medium :) > > Because to do it right you'd need to make sure you could match all the IP > addresses a machine is accepting, and in both forms (with and without []) > I don't think it is such simple matter to correctly identify all the > addresses, whereas it is common practice to confi

RE: cvs commit: jakarta-james build.bat

2002-08-18 Thread Danny Angus
tricky call, the linefeed standard has more to do with the apache repository systems than the intended audience, but I guess there won't be many complaints. d. > -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] > Sent: 18 August 2002 18:43 > To: [EMAIL PROTECTED] >

RE: address-literal addressing not working

2002-08-18 Thread Danny Angus
Medium :) Because to do it right you'd need to make sure you could match all the IP addresses a machine is accepting, and in both forms (with and without []) I don't think it is such simple matter to correctly identify all the addresses, whereas it is common practice to configure server daemons w

cvs commit: jakarta-james/src/java/org/apache/james/transport/mailets Redirect.java

2002-08-18 Thread pgoldstein
pgoldstein2002/08/18 11:19:54 Modified:src/java/org/apache/james/transport/mailets Redirect.java Log: Removed redundant pass-through, added xml:space preserve to internal docs. Reformatted some of the Javadoc comments for consistency. Thanks to Noel Bergman Revision Change

Re: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Andrew C. Oliver
Well said Peter. If your on Advogoto I'd love to upgrade you. -Andy PS... very offtopic Furthermore de-emphasizing documentation is one of my key beefs with XP. While I hate 300 page specs, I hate 0 page ones too. Peter M. Goldstein wrote: > Vincent, > > I'm not offended, although I disagree

cvs commit: jakarta-james build.bat

2002-08-18 Thread pgoldstein
pgoldstein2002/08/18 10:42:45 Modified:.build.bat Log: Changing build.bat to a DOS style linefeed file. It's a Windows only file, and the build changes it to this linefeed style on first run. Revision ChangesPath 1.6 +18 -18jakarta-james/build.bat

RE: address-literal addressing not working

2002-08-18 Thread Peter M. Goldstein
Danny et al, I'm leaning towards Noel's reading of this. How strong are your objections? I don't want to commit anything before we have a consensus. --Peter > -Original Message- > From: Noel J. Bergman [mailto:[EMAIL PROTECTED]] > Sent: Saturday, August 17, 2002 3:47 PM > To: James D

RE: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Peter M. Goldstein
Vincent, I'm not offended, although I disagree almost entirely with your points. :) Basically I feel that on distributed, volunteer projects extensive and appropriate documentation is even more important than on projects being done by a full-time, localized development team. And I feel that it

Re: about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Andrew C. Oliver
Vincent Keunen wrote: > Thanks Peter, for your message that makes things move forward. I'm > adding some comments about the specific item of javadocs. First, I must > say that I agree with 2 comments from Noel: > >> Internal Documentation >> Absolutely necessary. But NOT to hold up the 2.1 re

about javadocs (was: Re: FW: What do we need to release 2.1?)

2002-08-18 Thread Vincent Keunen
Thanks Peter, for your message that makes things move forward. I'm adding some comments about the specific item of javadocs. First, I must say that I agree with 2 comments from Noel: > Internal Documentation > Absolutely necessary. But NOT to hold up the 2.1 release. We can continue > to upgr

Re: IMAP LIST command

2002-08-18 Thread Vincent Keunen
Andrew C. Oliver wrote: >(oops I sent this to the wrong newsgroup) > >Hi Jamesers(jamesies?) -- > >In my quest to get my mailserver up and running I've stumbled upon >james nicethanks. > >However, it looks like its a few parsecs short of an imap server and I >find that kind of thing

cvs commit: jakarta-james/src/java/org/apache/james/transport/mailets Forward.java

2002-08-18 Thread pgoldstein
pgoldstein2002/08/18 01:55:33 Modified:src/java/org/apache/james/transport/mailets Forward.java Log: Check for valid sender address before forwarding. Thanks to Noel Bergman for the patch Revision ChangesPath 1.4 +20 -2 jakarta-james/src/java/org/apache/j

cvs commit: jakarta-james/src/conf sqlResources.xml

2002-08-18 Thread pgoldstein
pgoldstein2002/08/18 00:57:34 Modified:src/conf sqlResources.xml Log: Removed tabs Adjusted column lengths to match RFCs. Thanks to Noel Bergman for the patch Revision ChangesPath 1.12 +81 -83jakarta-james/src/conf/sqlResources.xml Index: sqlResource

Re: cvs commit: jakarta-james/src/java/org/apache/james/pop3serverPOP3Handler.java

2002-08-18 Thread Stephen McConnell
Now I can sync my local repository. Thanks. Steve. [EMAIL PROTECTED] wrote: > Index: JamesSpoolManager.java > === > RCS file: >/home/cvs/jakarta-james/src/java/org/apache/james/transport/JamesSpoolManager.java,v > retrieving

cvs commit: jakarta-james/src/java/org/apache/james BaseConnectionHandler.java Constants.java James.java Main.java

2002-08-18 Thread pgoldstein
pgoldstein2002/08/18 00:32:38 Modified:src/java/org/apache/james BaseConnectionHandler.java Constants.java James.java Main.java Log: Added comments. Fixed a minor threading bug. Removed a few unused and undocumented constants. Revision ChangesPa

cvs commit: jakarta-james/src/java/org/apache/james/nntpserver/repository ArticleIDRepository.java NNTPRepositoryImpl.java NNTPSpooler.java

2002-08-18 Thread pgoldstein
pgoldstein2002/08/18 00:30:18 Modified:src/java/org/apache/james/nntpserver ArticleWriter.java AuthService.java AuthServiceImpl.java LISTGroup.java NNTPHandler.java NNTPServer.java src/java/org/apache/james/nntpserver/reposi

cvs commit: jakarta-james/src/java/org/apache/james/pop3server POP3Handler.java

2002-08-18 Thread pgoldstein
pgoldstein2002/08/18 00:27:51 Modified:src/java/org/apache/james/transport JamesSpoolManager.java src/java/org/apache/james/transport/mailets RemoteDelivery.java src/java/org/apache/james/pop3server POP3Handler.java Log: Added nu

cvs commit: jakarta-james/src/java/org/apache/james/mailrepository package.html AvalonMailRepository.java AvalonSpoolRepository.java JDBCMailRepository.java MimeMessageAvalonSource.java MimeMessageJDBCSource.java

2002-08-18 Thread pgoldstein
pgoldstein2002/08/18 00:23:55 Modified:src/java/org/apache/james/mailrepository AvalonMailRepository.java AvalonSpoolRepository.java JDBCMailRepository.java MimeMessageAvalonSource.java MimeM