[
https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Busch reassigned LUCENE-1851:
-
Assignee: Michael Busch (was: Luis Alves)
> 'ant javacc' in root project should also pr
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Busch resolved LUCENE-1852.
---
Resolution: Fixed
Committed revision 807499.
> Fix remaining localization test failures in
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747254#action_12747254
]
Robert Muir commented on LUCENE-1852:
-
i will mention under some of these locales, bac
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747253#action_12747253
]
Michael Busch commented on LUCENE-1852:
---
great work and testing!
I'll commit shortl
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Busch reassigned LUCENE-1852:
-
Assignee: Michael Busch (was: Luis Alves)
> Fix remaining localization test failures in
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747251#action_12747251
]
Robert Muir commented on LUCENE-1852:
-
in my opinion the issue should be resolved.
I
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747250#action_12747250
]
Michael Busch commented on LUCENE-1852:
---
Shall I commit this one too?
> Fix remaini
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Busch resolved LUCENE-1836.
---
Resolution: Fixed
Committed revision 807494.
(with the missing "abstract")
> Flexible Quer
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747245#action_12747245
]
Robert Muir commented on LUCENE-1852:
-
Uwe, no.
But i only tested under the followin
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747243#action_12747243
]
Uwe Schindler commented on LUCENE-1852:
---
Looks good.
Robert, did you find any other
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747240#action_12747240
]
Uwe Schindler commented on LUCENE-1836:
---
OK! If you also have the missing "abstract"
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Busch reassigned LUCENE-1836:
-
Assignee: Michael Busch (was: Luis Alves)
> Flexible QueryParser fails with local diffe
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747239#action_12747239
]
Michael Busch commented on LUCENE-1836:
---
I just reviewed the patch and was going to
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1836:
--
Attachment: LUCENE-1836.patch
Here the patch again with the missing "abstract".
I could also
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747206#action_12747206
]
Shai Erera commented on LUCENE-1849:
bq. I think we should simply do nothing
+1. So m
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1847:
Attachment: LUCENE-1847.patch
Okay, I'm still awake, so one more:
Removed some white space to cle
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747193#action_12747193
]
Robert Muir commented on LUCENE-1852:
-
Luis, thanks for the review. yes this one needs
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747191#action_12747191
]
Luis Alves commented on LUCENE-1852:
I reviewed the code, all changes look good to me.
See http://hudson.zones.apache.org/hudson/job/Lucene-trunk/928/changes
Changes:
[uschindler] Sorry for the last commit, this is the better solution. As the
offset attribute was normally already added before in the indexing process, the
addAttribute is at no cost. And the additional if-clause is
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1847:
Attachment: LUCENE-1847.patch
Okay, adds a cache and puts it on Similarity -
This will let user q
[
https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747174#action_12747174
]
Luis Alves commented on LUCENE-1851:
Hi Paul,
I found some time to write a patch for
[
https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747173#action_12747173
]
Luis Alves commented on LUCENE-1851:
changes:
- fixed jjdoc - removed StandardTokeniz
[
https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luis Alves updated LUCENE-1851:
---
Attachment: LUCENE-1851.patch
> 'ant javacc' in root project should also properly create contrib/sur
[
https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luis Alves updated LUCENE-1851:
---
Lucene Fields: [New, Patch Available] (was: [New])
> 'ant javacc' in root project should also prope
[
https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luis Alves updated LUCENE-1851:
---
Affects Version/s: (was: 3.1)
2.9
Fix Version/s: (was: 3.1)
[
https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luis Alves reassigned LUCENE-1851:
--
Assignee: Luis Alves (was: Paul Elschot)
> 'ant javacc' in root project should also properly
[
https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luis Alves updated LUCENE-1851:
---
Attachment: (was: LUCENE-1851.patch)
> 'ant javacc' in root project should also properly create
[
https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luis Alves updated LUCENE-1851:
---
Attachment: LUCENE-1851.patch
> 'ant javacc' in root project should also properly create contrib/sur
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luis Alves reassigned LUCENE-1852:
--
Assignee: Luis Alves
> Fix remaining localization test failures in lucene
> --
[
https://issues.apache.org/jira/browse/LUCENE-1851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747146#action_12747146
]
Luis Alves commented on LUCENE-1851:
Paul do you have time to create a patch file?
I'l
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747140#action_12747140
]
Luis Alves commented on LUCENE-1836:
{quote}
the test superclass should be abstract, e
[
https://issues.apache.org/jira/browse/LUCENE-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747122#action_12747122
]
Michael Busch commented on LUCENE-1760:
---
Thanks for taking this, Mark. Let me know i
[
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-1852:
Attachment: LUCENE-1852.patch
all remaining locale-dependent test failures in core/contrib to my k
Mark Miller wrote:
> bq. Though we have 9 2.9 issues now...
>
> Right - we are kind of contingent on that - most look near done though,
> and some are documentation.
In fact, the number 9 is very misleading:
LUCENE-1798FieldCacheSanityChecker called directly by FieldCache.get*
looks about d
I don't look at it as just the week really. We got to 0 issues last
week, and these new issues have all really been cleanup and and bug
fixes. We have been in quasi feature freeze really. A lot of the issues
that are being addressed would have made sense to address over the
normal feature freeze. I
bq. Though we have 9 2.9 issues now...
Right - we are kind of contingent on that - most look near done though,
and some are documentation. I'd be happy to plow mindless work into
anything someone doesn't think they can finish soon if thats an issue.
bq. At the end of the freeze you'd create the r
Hmm, I wondering if one week is rather short considering the amount of
new features we have in 2.9 and the frequency of new issues coming in at
the moment...
Michael
On 8/24/09 2:20 PM, Michael McCandless wrote:
I like freezing for 1 week starting Wed. We should fix the javadocs&
any bugs d
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747083#action_12747083
]
Mark Miller commented on LUCENE-1847:
-
of course. right where it belongs :) Darn brain
I like freezing for 1 week starting Wed. We should fix the javadocs &
any bugs during this time. Though we have 9 2.9 issues now...
At the end of the freeze you'd create the release candidate(s)?
Mike
On Mon, Aug 24, 2009 at 9:51 AM, Mark Miller wrote:
> I know there is still some discussion a
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747080#action_12747080
]
Michael McCandless commented on LUCENE-1847:
You could cache it on the Similar
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747079#action_12747079
]
Mark Miller commented on LUCENE-1847:
-
Hmm - it would have to be a static cache - that
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747075#action_12747075
]
Tim Smith commented on LUCENE-1849:
---
bq. I think we should simply do nothing. This is an
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747074#action_12747074
]
Mark Miller commented on LUCENE-1847:
-
I'm wondering if we should cache the isMethodOv
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747067#action_12747067
]
Michael McCandless commented on LUCENE-1849:
I think we should simply do nothi
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747063#action_12747063
]
Michael McCandless commented on LUCENE-1847:
Looks good!
> PhraseQuery/TermQu
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1847:
Attachment: LUCENE-1847.patch
Okay, one final version I hope:
fixed javadoc spelling of explanati
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747054#action_12747054
]
Uwe Schindler edited comment on LUCENE-1849 at 8/24/09 1:41 PM:
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747059#action_12747059
]
Tim Smith commented on LUCENE-1849:
---
I guess the question is: what variations do we prov
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747054#action_12747054
]
Uwe Schindler commented on LUCENE-1849:
---
There should also be not only the variation
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747051#action_12747051
]
Tim Smith commented on LUCENE-1849:
---
i was just proposing AbstractCollector to consolida
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747050#action_12747050
]
Shai Erera commented on LUCENE-1849:
If we want to help people impl Collector, then le
Fix remaining localization test failures in lucene
--
Key: LUCENE-1852
URL: https://issues.apache.org/jira/browse/LUCENE-1852
Project: Lucene - Java
Issue Type: Bug
Reporter: Robert
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747046#action_12747046
]
Tim Smith commented on LUCENE-1849:
---
bq. we force them to think a little bit and then do
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747042#action_12747042
]
Shai Erera commented on LUCENE-1849:
But if we encourage people to extend AbstractColl
On Mon, Aug 24, 2009 at 10:15:20PM +0300, Shai Erera wrote:
> I think it all boils down to this jar drop-in ability.
Expecting jar drop-in compatibility for bugfix releases is 100% reasonable.
Expecting something close to jar drop-in compatibility for minor releases
seems pretty reasonable, too.
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747039#action_12747039
]
Tim Smith commented on LUCENE-1849:
---
bq. I think this will get pretty messy and complica
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747036#action_12747036
]
Michael McCandless commented on LUCENE-1847:
New patch has explaination in the
'ant javacc' in root project should also properly create contrib/surround Java
files
Key: LUCENE-1851
URL: https://issues.apache.org/jira/browse/LUCENE-1851
Project:
[
https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747033#action_12747033
]
Paul Elschot commented on LUCENE-1829:
--
Ok, see LUCENE-1851
> 'ant javacc' in root p
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747029#action_12747029
]
Shai Erera commented on LUCENE-1849:
How would this flag reduce any "code bloat" in su
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747028#action_12747028
]
Tim Smith commented on LUCENE-1849:
---
will do
> Add OutOfOrderCollector and InOrderColle
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747026#action_12747026
]
Michael McCandless commented on LUCENE-1849:
bq. protected instead please,
O
I don't mean to stir the ocean again, but I think it all boils down to this
jar drop-in ability. If someone plans to upgrade to 2.9 by just dropping in
a jar, then I'd like to hear of that someone who succeeded. 2.9 already
contains back-compat breaks. So that someone must be using Lucene is such a
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747021#action_12747021
]
Tim Smith commented on LUCENE-1849:
---
bq. Or just make it package private? This flag is o
This is tricky (and even now I wrote this email twice). It is all about
mating a Scorer and Collector together:
* Any out-of-order Scorer can be fed into an acceptsOutOfOrder Collector.
* Any in-order Scorer can be fed into either accepts=true/false Collector.
Therefore, when Weight is *queried*
[
https://issues.apache.org/jira/browse/LUCENE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747018#action_12747018
]
Luis Alves commented on LUCENE-1829:
{quote}
Would it still be possible to also treat
On Mon, Aug 24, 2009 at 01:46:35PM -0400, Michael McCandless wrote:
> Right, that is and has been the "plan" for 2.9/3.0/3.1 for quite some time.
>
> We are now discussing whether to change the plan, but so far it looks
> likely we'll just stick with it...
It seems like breaking the promise woul
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1847:
Attachment: LUCENE-1847.patch
add test case for TermQuery explain over multisearcher.
fixed spell
On Mon, Aug 24, 2009 at 1:32 PM, Jason
Rutherglen wrote:
> I don't like to chime in about these things because I don't
> really care too much, but it seemed like (for the last several
> months), 2.9 was going to be on Java 1.4, then 3.0 would include
> deprectations (maybe bug fixes). Then 3.1 was
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746971#action_12746971
]
Michael McCandless commented on LUCENE-1849:
bq. I like the idea of this flag
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746968#action_12746968
]
Michael McCandless commented on LUCENE-1847:
Looks good!
Your isMethodOverrid
> * Do we label the next release 2.9 or 3.0?
> * After that next release, do we do a "fast turnaround"
release or a > more normal "take your time and do real work"
release?
I don't like to chime in about these things because I don't
really care too much, but it seemed like (for the last several
mo
Update overview example code
Key: LUCENE-1850
URL: https://issues.apache.org/jira/browse/LUCENE-1850
Project: Lucene - Java
Issue Type: Task
Components: Examples, Javadocs
Reporter: Erik Hat
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746957#action_12746957
]
Uwe Schindler commented on LUCENE-1836:
---
the test superclass should be abstract, eve
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1836:
--
Attachment: LUCENE-1836.patch
I modified the patch a little bit to only test locale-related te
Mark Miller wrote:
>>
>>*
>>* @param docsScoredInOrder
>>* specifies if documents will be scored in doc ID order by the
>>* query. If you're not sure in advance, you can do the
>> following:
>>*
>>* boolean docsScoredInOrder =
>> !q.weigh
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746947#action_12746947
]
Uwe Schindler commented on LUCENE-1836:
---
Should I assign to this issue and commit th
[
https://issues.apache.org/jira/browse/LUCENE-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller reassigned LUCENE-1760:
---
Assignee: (was: Michael Busch)
> TokenStream API javadoc improvements
>
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1847:
Attachment: LUCENE-1847.patch
Okay, almost there. This one fixes SpanWeight as well and checks for
On Mon, Aug 24, 2009 at 11:44:17AM -0400, Michael McCandless wrote:
> Separately, we can think about having 3.1 be a "real" release, not
> just a "fast turnaround" release.
All problems flow from this "fast turnaround release" constraint.
If you had the freedom to make the kind of API changes pe
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746932#action_12746932
]
Robert Muir commented on LUCENE-1836:
-
Uwe, ok. after this LocalizedTestCase is added,
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746928#action_12746928
]
Tim Smith commented on LUCENE-1849:
---
I like the idea of this flag being private final an
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746926#action_12746926
]
Uwe Schindler commented on LUCENE-1849:
---
How about making acceptsDocsOutOfOrder() n
I was suggesting that 3.0 is simply a "name change" of 2.9, because of
the big number of new features.
Meaning, we then drop deprecated APIs, add generics, change defaults,
etc., in 3.1.
Separately, we can think about having 3.1 be a "real" release, not
just a "fast turnaround" release.
But this
I can just pop it in - thanks a lot. I like the little example myself.
It says a lot I think.
Shai Erera wrote:
> I guess we can add something like this:
>
>*
>* @param docsScoredInOrder
>* specifies if documents will be scored in doc ID order by the
>* query. If
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1847:
Summary: PhraseQuery/TermQuery/SpanQuery use IndexReader specific stats in
their explains (was: P
I guess we can add something like this:
*
* @param docsScoredInOrder
* specifies if documents will be scored in doc ID order by the
* query. If you're not sure in advance, you can do the
following:
*
* boolean docsScoredInOrder =
!q.weight(sea
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746920#action_12746920
]
Tim Smith commented on LUCENE-1849:
---
People tend to always reformat single line function
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746919#action_12746919
]
Mark Miller commented on LUCENE-1847:
-
bq. Can we name it IDFExplain instead of IdfExp
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746918#action_12746918
]
Uwe Schindler commented on LUCENE-1836:
---
The general contract in lucene should be th
[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746914#action_12746914
]
Michael McCandless commented on LUCENE-1847:
Patch looks good. Can we name it
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746912#action_12746912
]
Shai Erera commented on LUCENE-1849:
bq. (and bloats amount of required code by about
+1
Other files in the index also do this, eg SegmentInfos.CURRENT_FORMAT.
Mike
On Mon, Aug 24, 2009 at 10:33 AM, Grant Ingersoll wrote:
> In the Term Dictionary Section, it says:
>
> TIVersion names the version of the format
> of this file and is -2 in Lucene 1.4.
>
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746907#action_12746907
]
Tim Smith commented on LUCENE-1849:
---
They would be convenience classes for people implem
Thanks Shai. That all makes sense to me.
bq. Perhaps we should add to the javadocs something like "you can call
query.weight().scoresDocsOutOfOrder to instantiate the optimal TFC/TSDC"?
I guess this is all I would argue for as well - basically a bit more
informative javadoc for scoreOutOfOrder:
[
https://issues.apache.org/jira/browse/LUCENE-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Ingersoll updated LUCENE-1848:
Attachment: LUCENE-1848.patch
Looks like changes are only needed in fileformats.xml. Patc
[
https://issues.apache.org/jira/browse/LUCENE-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746904#action_12746904
]
Shai Erera commented on LUCENE-1849:
But then what will classes like TopFieldCollector
[
https://issues.apache.org/jira/browse/LUCENE-1836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746897#action_12746897
]
Robert Muir edited comment on LUCENE-1836 at 8/24/09 7:53 AM:
--
I think we've had a similar discussion on this issue (as part of the JIRA
issue), and the reason for not defaulting to anything was back-compat.
For example, we know that not tracking doc scores is better when you simply
sort by a field. But we can't have a default that says "don't track doc
score
We do still mark the collector methods as lower level API - so I guess
my expert/non expert argument is pretty worthless :)
I just don't like that the collectors require so much more internal
knowledge to use than the previous versions - and just for optimization.
The param list can be very simple
1 - 100 of 153 matches
Mail list logo
