Re: Build failed in Hudson: Lucene-trunk #1157

2010-04-15 Thread Shai Erera
DB jars again ... I think this one is a false alarm. Shai On Fri, Apr 16, 2010 at 5:14 AM, Apache Hudson Server < hud...@hudson.zones.apache.org> wrote: > See > > Changes: > > [mikemccand] speed up TestStressIndexing2 > >

[jira] Created: (LUCENE-2397) SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened

2010-04-15 Thread Shai Erera (JIRA)
Type: Improvement Components: Index Reporter: Shai Erera Assignee: Shai Erera Priority: Minor Fix For: 3.1 SDP throws NPE if no commits occurred and snapshot() was called. I will replace it w/ throwing IllegalStateException. I'll also

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
don't know how much control we have on that ... Shai On Fri, Apr 16, 2010 at 12:21 AM, DM Smith wrote: > > On Apr 15, 2010, at 4:50 PM, Shai Erera wrote: > > > Robert ... I'm sorry but changes to Analyzers don't *force* people to > reindex. They can simply choose

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
> > On Thu, Apr 15, 2010 at 4:50 PM, Shai Erera wrote: > >> Robert ... I'm sorry but changes to Analyzers don't *force* people to >> reindex. They can simply choose not to use the latest version. They can >> choose not to upgrade a Unicode version. They can copy

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
hen. Shai On Thu, Apr 15, 2010 at 11:33 PM, Robert Muir wrote: > > > On Thu, Apr 15, 2010 at 4:21 PM, Shai Erera wrote: > >> Actually, I'd like to know if people like Robert (basically those who have >> no problem to reindex and don't understand the fuss around

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
hat changes, we provide a migration tool for the latest index format version. Simple as that. The rest, we can 'see what happens' ... Shai On Thu, Apr 15, 2010 at 11:29 PM, Grant Ingersoll wrote: > > On Apr 15, 2010, at 4:21 PM, Shai Erera wrote: > > > +1 on the Analyzers a

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
+1 on the Analyzers as well. Earwin, I think I don't mind if we introduce migrate() elsewhere rather than on IW. What I meant to say is that if we stick w/ index format back-compat and ongoing migration, then such a method would be useful on IW for customers to call to ensure they're on the latest

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
The reason Earwin why online migration is faster is because when u finally need to *fully* migrate your index, most chances are that most of the segments are already on the newer format. Offline migration will just keep the application idle for some amount of time until ALL segments are migrated.

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
I seriously don't understand the fuss around index format back compat. How many times is this changed such that it is too much to ask to keep X support X-1? I prefer to have ongoing segment merging but can live w/ a manual converter tool. Thing is - I'll probably not be able to develop one myself

[jira] Commented: (LUCENE-2396) remove version from contrib/analyzers.

2010-04-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857396#action_12857396 ] Shai Erera commented on LUCENE-2396: Static? Weren't you against that!?

[jira] Commented: (LUCENE-2396) remove version from contrib/analyzers.

2010-04-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857388#action_12857388 ] Shai Erera commented on LUCENE-2396: Robert I think this is great! Can we move

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
; crucial >> >>> from my point of view. >> >>> I don't care what this way is: calling optimize() with newer lucene or >> >>> running some tool that takes 5 days, it's ok with me. >> >>> Just don't put me through full reinde

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
ata anymore. > >> It's not my data, i just receive it from clients, and provide a search > >> interface. > >> It took years to build those indexes, rebuilding is not an option, and > >> staying with old lucene forever just sucks. > >> > &g

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
provide a search > interface. > > It took years to build those indexes, rebuilding is not an option, and > staying with old lucene forever just sucks. > > Danil. > > On Thu, Apr 15, 2010 at 14:57, Robert Muir wrote: > >> >> >> On Thu, Apr 15, 2010 at 7:52

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
learly has no affect on index structure and content. We can even let go of index runtime changes for all I care. But I simply don't think we can let go of index structure back-support. Shai On Thu, Apr 15, 2010 at 1:12 PM, Michael McCandless < luc...@mikemccandless.com> wrote: > 2010/4

Re: SnapshotDeletionPolicy throws NPE if no commit happened

2010-04-15 Thread Shai Erera
, Apr 15, 2010 at 10:26 AM, Earwin Burrfoot wrote: > >> We should just let IW create a null commit on an empty directory, like >> it always did ;) >> Then a whole class of such problems disappears. >> >> On Thu, Apr 15, 2010 at 11:16, Shai Erera wrote: >> >

Re: Proposal about Version API "relaxation"

2010-04-15 Thread Shai Erera
released after 4.0 if bugs are found and fixed, or > if people ask to backport some (minor?) features, and some dev has > time for this. > > The question of what to call major release in X.Y.Z scheme - X or Y, > is there, but immaterial :) I think it's okay to settle with X

Re: SnapshotDeletionPolicy throws NPE if no commit happened

2010-04-15 Thread Shai Erera
ust let IW create a null commit on an empty directory, like > it always did ;) > Then a whole class of such problems disappears. > > On Thu, Apr 15, 2010 at 11:16, Shai Erera wrote: > > SDP throws NPE if the index includes no commits, but snapshot() is > called. > > Th

SnapshotDeletionPolicy throws NPE if no commit happened

2010-04-15 Thread Shai Erera
SDP throws NPE if the index includes no commits, but snapshot() is called. This is an extreme case, but can happen if one takes snapshots (for backup purposes for example) in a separate code segment than indexing, and does not know if commit was called or not. I think we should throw an IllegalSta

Re: TestCodecs running time

2010-04-14 Thread Shai Erera
> > I think it's fine to reduce the number of iterations -- just make sure > there's no seed to newRandom() so the distributing testing is > "effective". > > Mike > > On Fri, Apr 9, 2010 at 12:43 AM, Shai Erera wrote: > > Hi > > > > I&

Re: Proposal about Version API "relaxation"

2010-04-14 Thread Shai Erera
Mark Miller wrote: > I don't read what you wrote and what Mike wrote as even close to the same. > > - Mark > > http://www.lucidimagination.com (mobile) > > On Apr 15, 2010, at 12:05 AM, Shai Erera wrote: > > Ahh ... a dream finally comes true ... what a great way to start a day :).

Re: Proposal about Version API "relaxation"

2010-04-14 Thread Shai Erera
Also, we will still need to maintain the Backwards section in CHANGES (or move it to API Changes), to help people upgrade from release to release. Just pointing that out as well. Shai On Thu, Apr 15, 2010 at 7:05 AM, Shai Erera wrote: > Ahh ... a dream finally comes true ... what a great

Re: Proposal about Version API "relaxation"

2010-04-14 Thread Shai Erera
Ahh ... a dream finally comes true ... what a great way to start a day :). +1 !!! I have some questions/comments though: * Index back compat should be maintained between major releases, like it is today, STRUCTURE-wise. So apps get a chance to incrementally upgrade their segments when they move f

[jira] Commented: (LUCENE-2159) Tool to expand the index for perf/stress testing.

2010-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856917#action_12856917 ] Shai Erera commented on LUCENE-2159: bq. There is an excellent section on it in

[jira] Commented: (LUCENE-2159) Tool to expand the index for perf/stress testing.

2010-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856911#action_12856911 ] Shai Erera commented on LUCENE-2159: Which is fine - I think this would be a

[jira] Commented: (LUCENE-2159) Tool to expand the index for perf/stress testing.

2010-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856877#action_12856877 ] Shai Erera commented on LUCENE-2159: bq. I understand having a general perform

[jira] Commented: (LUCENE-2159) Tool to expand the index for perf/stress testing.

2010-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856845#action_12856845 ] Shai Erera commented on LUCENE-2159: This looks like a nice tool. But all it doe

[jira] Resolved: (LUCENE-2316) Define clear semantics for Directory.fileLength

2010-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-2316. Lucene Fields: [New, Patch Available] (was: [New]) Assignee: Shai Erera

Re: Proposal about Version API "relaxation"

2010-04-13 Thread Shai Erera
single > value for the entire library but rather feature by feature. I don't see how > a global setter can help. > > -- DM > > > On 04/13/2010 11:27 AM, Shai Erera wrote: > >> Hi >> >> I'd like to propose a relaxation on the Version API. Uwe, please re

[jira] Commented: (LUCENE-2316) Define clear semantics for Directory.fileLength

2010-04-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856531#action_12856531 ] Shai Erera commented on LUCENE-2316: That's a fairly trivial patch, therefo

Re: Proposal about Version API "relaxation"

2010-04-13 Thread Shai Erera
y on sysprops or statics. > > > > Uwe > > > > - > > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: u...@thetaphi.de > > > > *From:* Shai Erera [mailto:ser...@gmail.com] > *Sent:* Tuesday,

Re: Proposal about Version API "relaxation"

2010-04-13 Thread Shai Erera
Well the no-arg ctor will be using Version.getDefault() which will throw an exception if not set, and delegate the call to the Version-aware ctor. On Tuesday, April 13, 2010, Robert Muir wrote: > On Tue, Apr 13, 2010 at 11:27 AM, Shai Erera wrote: > > > I was thinking that we can ad

[jira] Updated: (LUCENE-2316) Define clear semantics for Directory.fileLength

2010-04-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2316: --- Attachment: LUCENE-2316.patch Patch clarifies the contract, fixes the directories to adhere to it

Proposal about Version API "relaxation"

2010-04-13 Thread Shai Erera
Hi I'd like to propose a relaxation on the Version API. Uwe, please read the entire email before you reply :). I was thinking, following a question on the user list, that the Version-based API may not be very intuitive to users, especially those who don't care about versioning, as well as very in

[jira] Resolved: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-2386. Resolution: Fixed Committed revision 933613. (take #2) > IndexWriter commits unnecessarily

[jira] Updated: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2386: --- Attachment: LUCENE-2386.patch Patch includes the proposed test in TestIndexWriter. I think this is

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856063#action_12856063 ] Shai Erera commented on LUCENE-2386: So just call "new IW()", the

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855924#action_12855924 ] Shai Erera commented on LUCENE-2386: I don't think that people need to w

[jira] Commented: (LUCENE-2392) Enable flexible scoring

2010-04-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855913#action_12855913 ] Shai Erera commented on LUCENE-2392: I'd like to withdraw my request from

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855892#action_12855892 ] Shai Erera commented on LUCENE-2386: bq. what is the proper way (after this fix

Re: [jira] Commented: (LUCENE-2392) Enable flexible scoring

2010-04-12 Thread Shai Erera
your own random statistics and shove them > into the index (this would be messy like how to get access to the aggregates > you need anyway) is something different entirely, best left to research > systems. > > You can't even do that with Terrier now. > > On Mo

[jira] Commented: (LUCENE-2373) Change StandardTermsDictWriter to work with streaming and append-only filesystems

2010-04-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855877#action_12855877 ] Shai Erera commented on LUCENE-2373: I'd rather not count on file lengt

[jira] Commented: (LUCENE-2392) Enable flexible scoring

2010-04-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855875#action_12855875 ] Shai Erera commented on LUCENE-2392: Mike - it'll also be great if we can

[jira] Commented: (LUCENE-2316) Define clear semantics for Directory.fileLength

2010-04-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855873#action_12855873 ] Shai Erera commented on LUCENE-2316: Well ... dir.fileLength is also use

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855870#action_12855870 ] Shai Erera commented on LUCENE-2386: I'm not sure if we're arguing

[jira] Updated: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2386: --- Attachment: LUCENE-2386.patch Patch w/ proposed fixes. All tests pass, including Solr&#

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855767#action_12855767 ] Shai Erera commented on LUCENE-2386: About IndexReader.listCommits ... the java

[jira] Updated: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2386: --- Attachment: LUCENE-2386.patch Fixes IndexFileDeleter, adds a proper test to TestIndexWriter

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855727#action_12855727 ] Shai Erera commented on LUCENE-2386: Committed revision 932917 for the re

[jira] Reopened: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera reopened LUCENE-2386: As I indicated in an email, Solr tests failed (sorry for not running them before). After some

Re: svn commit: r932873 - /lucene/dev/trunk/lucene/src/java/org/apache/lucene/index/IndexNotFoundException.java

2010-04-11 Thread Shai Erera
Sorry about that ... On Sun, Apr 11, 2010 at 3:10 PM, wrote: > Author: uschindler > Date: Sun Apr 11 12:10:57 2010 > New Revision: 932873 > > URL: http://svn.apache.org/viewvc?rev=932873&view=rev > Log: > add missing license header > > Modified: > > > lucene/dev/trunk/lucene/src/java/org/apach

[jira] Commented: (LUCENE-1709) Parallelize Tests

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855713#action_12855713 ] Shai Erera commented on LUCENE-1709: Committed revision 932878 with the follo

[jira] Resolved: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-2386. Lucene Fields: [New, Patch Available] (was: [New]) Resolution: Fixed Committed revision

[jira] Updated: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2386: --- Attachment: LUCENE-2386.patch Patch updated to latest rev. + the proposed name change

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855457#action_12855457 ] Shai Erera commented on LUCENE-2386: Ok sounds good. Is there a preferred package

[jira] Updated: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2386: --- Attachment: LUCENE-2386.patch Patch fixes all tests as well as changes to IndexWriter

[jira] Commented: (LUCENE-1879) Parallel incremental indexing

2010-04-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855379#action_12855379 ] Shai Erera commented on LUCENE-1879: I have found such version ... and it fails

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855369#action_12855369 ] Shai Erera commented on LUCENE-2386: I already did that ... just didn't

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855344#action_12855344 ] Shai Erera commented on LUCENE-2386: Ok I've added the following to DirReade

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855277#action_12855277 ] Shai Erera commented on LUCENE-2386: Apparently, there are more tests that

Re: Controlling the maximum size of a segment during indexing

2010-04-08 Thread Shai Erera
I'm not sure .. but did you set the RAMBufferSizeMB on IWC? Doesn't look like it, and the default is 16 MB, which can explain why it doesn't flush before that. Shai On Fri, Apr 9, 2010 at 8:01 AM, Lance Norskog wrote: > Here is a Java unit test that uses the LogByteSizeMergePolicy to > control

TestCodecs running time

2010-04-08 Thread Shai Erera
Hi I've noticed that TestCodecs takes an insanely long time to run on my machine - between 35-40 seconds. Is that expected? The reason why it runs so long, seems to be that its threads make (each) 4000 iterations ... is that really required to ensure correctness? Shai

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855265#action_12855265 ] Shai Erera commented on LUCENE-2386: bq. Maybe change testImmediateDiskFull to

[jira] Updated: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2386: --- Attachment: LUCENE-2386.patch First stab at this. Patch still missing CHANGES entry, and I haven&#

[jira] Resolved: (LUCENE-2385) Move NoDeletionPolicy from benchmark to core

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-2385. Resolution: Fixed Committed revision 932129. > Move NoDeletionPolicy from benchmark to c

[jira] Commented: (LUCENE-2385) Move NoDeletionPolicy from benchmark to core

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855155#action_12855155 ] Shai Erera commented on LUCENE-2385: Forgot to mention that the only move I made

[jira] Updated: (LUCENE-2385) Move NoDeletionPolicy from benchmark to core

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2385: --- Attachment: LUCENE-2385.patch Is it better now? > Move NoDeletionPolicy from benchmark to c

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855148#action_12855148 ] Shai Erera commented on LUCENE-2386: Looking at IFD again, I think a boolean ctor

[jira] Commented: (LUCENE-2385) Move NoDeletionPolicy from benchmark to core

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855140#action_12855140 ] Shai Erera commented on LUCENE-2385: I did that first, but then remembered that

[jira] Commented: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855131#action_12855131 ] Shai Erera commented on LUCENE-2386: Took a look at IndexFileDeleter, and locate

[jira] Updated: (LUCENE-2385) Move NoDeletionPolicy from benchmark to core

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2385: --- Attachment: LUCENE-2385.patch Move NoDeletionPolicy to core, adds javadocs + TestNoDeletionPolicy

[jira] Created: (LUCENE-2386) IndexWriter commits unnecessarily on fresh Directory

2010-04-08 Thread Shai Erera (JIRA)
: Index Reporter: Shai Erera Assignee: Shai Erera Fix For: 3.1 I've noticed IndexWriter's ctor commits a first commit (empty one) if a fresh Directory is passed, w/ OpenMode.CREATE or CREATE_OR_APPEND. This seems unnecessarily, and kind of brin

[jira] Created: (LUCENE-2385) Move NoDeletionPolicy from benchmark to core

2010-04-08 Thread Shai Erera (JIRA)
/benchmark, Index Reporter: Shai Erera Assignee: Shai Erera Priority: Trivial Fix For: 3.1 As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.

[jira] Commented: (LUCENE-1709) Parallelize Tests

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855020#action_12855020 ] Shai Erera commented on LUCENE-1709: Robert, I will commit the patch, seems goo

[jira] Commented: (LUCENE-1482) Replace infoSteram by a logging framework (SLF4J)

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854920#action_12854920 ] Shai Erera commented on LUCENE-1482: I still think that calling isDebugEnable

[jira] Commented: (LUCENE-2074) Use a separate JFlex generated Unicode 4 by Java 5 compatible StandardTokenizer

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854887#action_12854887 ] Shai Erera commented on LUCENE-2074: bq. I plan to commit this soon! That

[jira] Commented: (LUCENE-2074) Use a separate JFlex generated Unicode 4 by Java 5 compatible StandardTokenizer

2010-04-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854885#action_12854885 ] Shai Erera commented on LUCENE-2074: Uwe, must this be coupled with that issue?

Move NoDeletionPolicy to core

2010-04-08 Thread Shai Erera
Hi I've noticed benchmark has a NoDeletionPolicy class and I was wondering if we can move it to core. I might want to use it for the parallel index stuff, but I think it'll also fit nicely in core, together with the other No* classes. In addition, this class should be made a singleton. If moving

[jira] Commented: (LUCENE-2353) Config incorrectly handles Windows absolute pathnames

2010-04-07 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854588#action_12854588 ] Shai Erera commented on LUCENE-2353: Actually, we've reopened LUCENE-1709

[jira] Resolved: (LUCENE-2377) Enable the use of NoMergePolicy and NoMergeScheduler by Benchmark

2010-04-07 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-2377. Resolution: Fixed Committed revision 931502. > Enable the use of NoMergePolicy

[jira] Updated: (LUCENE-1709) Parallelize Tests

2010-04-07 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-1709: --- Attachment: LUCENE-1709-2.patch Since I had the changes on my local env. I thought it's be

[jira] Updated: (LUCENE-2377) Enable the use of NoMergePolicy and NoMergeScheduler by Benchmark

2010-04-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2377: --- Attachment: LUCENE-2377.patch Patch includes both fix to CreateIndexTask as well as relevant tests

[jira] Created: (LUCENE-2377) Enable the use of NoMergePolicy and NoMergeScheduler by Benchmark

2010-04-06 Thread Shai Erera (JIRA)
: Improvement Components: contrib/benchmark Reporter: Shai Erera Assignee: Shai Erera Priority: Minor Fix For: 3.1 Benchmark allows one to set the MP and MS to use, by defining the class name and then use reflection to instantiate them

[jira] Commented: (LUCENE-1709) Parallelize Tests

2010-04-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854348#action_12854348 ] Shai Erera commented on LUCENE-1709: One more thing - change benchmark tests to

Re: Getting fsync out of the loop

2010-04-06 Thread Shai Erera
Earwin - do you have some numbers to share on the running time of the indexing application? You've mentioned that if you take out fsync into a BG thread, the running time improves, but I'm curious to know by how much. Shai On Wed, Apr 7, 2010 at 2:26 AM, Earwin Burrfoot wrote: > > Running out o

Re: Getting fsync out of the loop

2010-04-06 Thread Shai Erera
How often is fsync called? If it's just during calls to commit, then is that that expensive? I mean, how often do you call commit? If that's that expensive (do you have some numbers to share) then I think that's be a neat idea. Though "losing a few minutes worth of updates" may sometimes be unreco

Re: Landing the flex branch

2010-04-03 Thread Shai Erera
bq. Try a merge back: This would let flex appear as a single commit to trunk, so the history of trunk would be preserved. +1 for that - I think the history of trunk is important to preserve. And there is also a way to ask for flex's history so everybody win? Shai On Thursday, April 1, 2010, Uwe

Re: Parallel tests in Benchmark

2010-04-03 Thread Shai Erera
uir wrote: > On Thu, Apr 1, 2010 at 12:03 AM, Shai Erera wrote: > > > Hi > > I'd like to summarize a discussion I had w/ Robert and Mike last night on > IRC, about the parallelism of tasks in Benchmark: > > For some reason, ever since parallel tasks were introduced,

Re: Welcome Uwe Schindler to the Lucene PMC

2010-04-01 Thread Shai Erera
Congratulations Uwe ! Shai On Thursday, April 1, 2010, Earwin Burrfoot wrote: > Generics SpecOps made it to the top and are gonna rule us from the > shadows :)  Congrats! > > On Thu, Apr 1, 2010 at 16:37, Robert Muir wrote: >> Congrats Uwe! >> >> On Thu, Apr 1, 2010 at 7:05 AM, Grant Ingersoll

Re: Build failed in Hudson: Lucene-trunk #1144

2010-03-31 Thread Shai Erera
Looks like the DB tests failed due to a connection problem. I was wondering yesterday why aren't the required libs checked in to SVN? We can periodically update them, if necessary (e.g. if they fix a bug). We checked in a lot of things already, including the backwards code, so what are 2 more jar

Parallel tests in Benchmark

2010-03-31 Thread Shai Erera
Hi I'd like to summarize a discussion I had w/ Robert and Mike last night on IRC, about the parallelism of tasks in Benchmark: For some reason, ever since parallel tasks were introduced, when I run 'ant test' from the contrib/benchmark folder (or the root), the tests just hang at some point, afte

[jira] Resolved: (LUCENE-2353) Config incorrectly handles Windows absolute pathnames

2010-03-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-2353. Resolution: Fixed Committed revision 929520. > Config incorrectly handles Windows absol

[jira] Commented: (LUCENE-2310) Reduce Fieldable, AbstractField and Field complexity

2010-03-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851842#action_12851842 ] Shai Erera commented on LUCENE-2310: Right Earwin - agreed. I'd like to su

[jira] Commented: (LUCENE-2353) Config incorrectly handles Windows absolute pathnames

2010-03-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851836#action_12851836 ] Shai Erera commented on LUCENE-2353: Unless there are objections, I plan to co

[jira] Assigned: (LUCENE-2353) Config incorrectly handles Windows absolute pathnames

2010-03-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera reassigned LUCENE-2353: -- Assignee: Shai Erera > Config incorrectly handles Windows absolute pathna

[jira] Commented: (LUCENE-2310) Reduce Fieldable, AbstractField and Field complexity

2010-03-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851829#action_12851829 ] Shai Erera commented on LUCENE-2310: +1 for this simplification. Can we just nam

[jira] Updated: (LUCENE-2353) Config incorrectly handles Windows absolute pathnames

2010-03-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2353: --- Attachment: LUCENE-2353.patch Updated to also match 'c:/temp' like paths, which are als

[jira] Commented: (LUCENE-2353) Config incorrectly handles Windows absolute pathnames

2010-03-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850644#action_12850644 ] Shai Erera commented on LUCENE-2353: I don't have an account yet, so I cann

[jira] Updated: (LUCENE-2353) Config incorrectly handles Windows absolute pathnames

2010-03-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-2353: --- Attachment: LUCENE-2353.patch The fix is only relevant to get(String, String) and not to all other

[jira] Created: (LUCENE-2353) Config incorrectly handles Windows absolute pathnames

2010-03-27 Thread Shai Erera (JIRA)
: contrib/benchmark Reporter: Shai Erera Fix For: 3.1 I have no idea how no one ran into this so far, but I tried to execute an .alg file which used ReutersContentSource and referenced both docs.dir and work.dir as Windows absolute pathnames (e.g. d:\something

  1   2   3   4   5   6   7   8   9   10   >