On Thu, 11 Jul 2024 20:55:29 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change, the relative link to the
> stylesheet isn't needed as it wasn't used anyway in the generated HTML. The
> correct link to the stylesheet is already in the generated HTML.
>
> This is the
Please review this backport of #20129 to JDK 23, fixing the documentation
Javadoc generates for the default object method implementations in user records
about the comparison behavior for `float` and `double` values.
-
Commit messages:
- Backport
On Wed, 10 Jul 2024 23:24:43 GMT, Chen Liang wrote:
> Fixes to Javadoc's default documentation on record classes, that all
> primitives are compared as if with their wrapper classes' `compare` method by
> default.
This pull request has now been integrated.
Changeset: b3ef2a60
Author
On Wed, 3 Jul 2024 14:17:14 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change? It removes some lines that
> are no longer necessary and sets the ARIA role as global.
> Thanks in advance.
Thank you for your consistent improvement fixes!
-
PR Comment:
Please review this build-only change that fixes the link to the SVG sealed
graph by the `@sealedGraph` javadoc taglet. This affects JDK 23 ea
documentation (as shown in #20122) and thus is backported.
-
Commit messages:
- Backport d06d79c80980644df511cded0eb8bc0309d878d3
Changes:
On Wed, 10 Jul 2024 18:57:22 GMT, Chen Liang wrote:
> Fixes the link to the generated sealed graph svg generated by the sealed
> graph taglet.
>
> Affected interfaces includes
> [`ClassFile.Option`](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8325369-nested-sealed-svg/api
On Wed, 10 Jul 2024 21:47:52 GMT, Jonathan Gibbons wrote:
>> Fixes the link to the generated sealed graph svg generated by the sealed
>> graph taglet.
>>
>> Affected interfaces includes
>>
On Thu, 11 Jul 2024 15:08:34 GMT, Pavel Rappo wrote:
>> Please review this jdk24 bug, which we intend to backport to jdk23 before
>> RDP2, which is a week away. This is a simple fix, but it disturbs multiple
>> tests.
>>
>> Here's a tip for reviewing. Sometimes a snippet id in a test ends up
On Thu, 11 Jul 2024 14:07:39 GMT, Pavel Rappo wrote:
> Please review this jdk24 bug, which we intend to backport to jdk23 before
> RDP2, which is a week away. This is a simple fix, but it disturbs multiple
> tests.
>
> Here's a tip for reviewing. Sometimes a snippet id in a test ends up with
Fixes to Javadoc's default documentation on record classes, that all primitives
are compared as if with their wrapper classes' `compare` method by default.
-
Commit messages:
- Fix tests
- only link tags get escaped
- tests
- corresponding
- 8336036: Record equals Javadoc is
Fixes the link to the generated sealed graph svg generated by the sealed graph
taglet.
Affected interfaces includes `ClassFile.Option`, `AnnotationValue.OfConstant`,
a few nested interfaces in `Signature`, and `TypeAnnotaton.TargetInfo`.
-
Commit messages:
- 8325369:
On Thu, 4 Jul 2024 22:32:19 GMT, Archie Cobbs wrote:
> The standard Javadoc doclet has a long-standing bug (since 2006, old enough
> to vote :) whereby constructor type parameters are simply omitted from the
> output. This results in confusing documentation that look like this:
>
> public
On Wed, 3 Jul 2024 14:17:14 GMT, Nizar Benalla wrote:
> Can I please get a review for this small change? It removes some lines that
> are no longer necessary and sets the Aria role as global.
> Thanks in advance.
All these removed keys are already marked global.
-
Marked as
On Mon, 1 Jul 2024 13:33:28 GMT, Pavel Rappo wrote:
> Please review this bugfix to the way the language of a snippet is determined
> and processed.
>
> The language of a snippet affects the form of snippet markup and enables
> external syntax highlighting, such as that provided by prism.js.
On Wed, 19 Jun 2024 09:59:26 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in
On Fri, 14 Jun 2024 19:00:41 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in
On Tue, 11 Jun 2024 12:45:10 GMT, Pavel Rappo wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove classpath exception
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line
> 556:
>
On Tue, 11 Jun 2024 11:37:27 GMT, Nizar Benalla wrote:
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
> to the generated docs.
> Thanks in
On Fri, 31 May 2024 10:01:17 GMT, Hannes Wallnöfer wrote:
>> Please review a simple patch to exclude preview visitor classes meant to
>> support future preview features from the Preview API page.
>>
>> The test adds an sample element annotated with the new
>>
On Thu, 23 May 2024 13:59:19 GMT, Hannes Wallnöfer wrote:
>> Please review a simple patch to exclude preview visitor classes meant to
>> support future preview features from the Preview API page.
>>
>> The test adds an sample element annotated with the new
>>
On Wed, 22 May 2024 08:39:12 GMT, Hannes Wallnöfer wrote:
> Please review a simple patch to exclude preview visitor classes meant to
> support future preview features from the Preview API page.
>
> The test adds an sample element annotated with the new
>
On Sun, 12 May 2024 08:36:44 GMT, Chen Liang wrote:
> Some tests are not migrated to the ClassFile API in previous migrations.
>
> - Some are simple oversights that didn't remove usages of
> com.sun.tools.classfile;
> - The CallerSensitive ones used an old utility, replaced
On Sun, 12 May 2024 08:36:44 GMT, Chen Liang wrote:
> Some tests are not migrated to the ClassFile API in previous migrations.
>
> - Some are simple oversights that didn't remove usages of
> com.sun.tools.classfile;
> - The CallerSensitive ones used an old utility, replaced
On Fri, 17 May 2024 06:03:00 GMT, Adam Sotona wrote:
>> Some tests are not migrated to the ClassFile API in previous migrations.
>>
>> - Some are simple oversights that didn't remove usages of
>> com.sun.tools.classfile;
>> - The CallerSensitive ones used an old utility, replaced by CF
On Fri, 17 May 2024 06:07:47 GMT, Adam Sotona wrote:
>> Some tests are not migrated to the ClassFile API in previous migrations.
>>
>> - Some are simple oversights that didn't remove usages of
>> com.sun.tools.classfile;
>> - The CallerSensitive ones used an old utility, replaced by CF
On Wed, 15 May 2024 21:04:36 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Wed, 15 May 2024 21:04:36 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Wed, 15 May 2024 21:04:36 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Thu, 16 May 2024 10:56:26 GMT, Hannes Wallnöfer wrote:
> Please review a change to improve the layout of definition lists used to
> display block tags:
>
> - Add indentation to the `` elements used for block tag details
> - Set the margin of lists within block tag details so they do not
Some tests are not migrated to the ClassFile API in previous migrations.
- Some are simple oversights that didn't remove usages of
com.sun.tools.classfile;
- The CallerSensitive ones used an old utility, replaced by CF API-based new
code;
- many in javac are because the files are compiled
On Thu, 4 Apr 2024 14:53:09 GMT, Pavel Rappo wrote:
>> That's actually a sign of relief that the same elements will have the same
>> id with the same input source code
>
> Reading your reply, I think that one of us is likely confused. Your question
> to which I replied "no" was this:
>
>>
On Thu, 4 Apr 2024 12:28:13 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlIds.java
>> line 571:
>>
>>> 569: var list = Stream.concat(Stream.concat(ctors.stream(),
>>> methods.stream()), otherMethods.stream())
>>> 570:
On Thu, 4 Apr 2024 11:41:37 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlIds.java
>> line 562:
>>
>>> 560: && e.getKind() != ElementKind.METHOD)
>>> 561: throw new
>>>
On Wed, 3 Apr 2024 18:14:39 GMT, Pavel Rappo wrote:
>> Creating a link to a constructor or a method or comparing constructors or
>> methods __does not__ factor in type parameters. When constructors or methods
>> are overloaded and differ only in type parameters -- a situation which is
>>
On Wed, 27 Mar 2024 17:19:35 GMT, Pavel Rappo wrote:
> Creating a link to a constructor or a method or comparing constructors or
> methods __does not__ factor in type parameters. When constructors or methods
> are overloaded and differ only in type parameters -- a situation which is
> absent
On Tue, 12 Mar 2024 03:33:38 GMT, Chen Liang wrote:
> Please review this patch that fixes placement of type annotations on array
> types in Javadoc output. This oversight seems to have existed since JDK 8 but
> was never noticed or reported.
This pull request has now been i
On Tue, 12 Mar 2024 03:33:38 GMT, Chen Liang wrote:
> Please review this patch that fixes placement of type annotations on array
> types in Javadoc output. This oversight seems to have existed since JDK 8 but
> was never noticed or reported.
Now fixed merge conflict and added a
> Please review this patch that fixes placement of type annotations on array
> types in Javadoc output. This oversight seems to have existed since JDK 8 but
> was never noticed or reported.
Chen Liang has updated the pull request with a new target base due to a merge
or a rebase.
On Sun, 10 Mar 2024 20:19:44 GMT, Chen Liang wrote:
> Please review this patch that fixes the issue where type annotations on
> primitive types are not linked.
>
> Tested with file
> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>
> import java.lang.anno
On Mon, 11 Mar 2024 13:57:23 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>
Please review this patch that fixes placement of type annotations on array
types in Javadoc output. This oversight seems to have existed since JDK 8 but
was never noticed or reported.
-
Commit messages:
- Fix whitespace
- Make sure varargs work too
- Fix bugs, add tests, fix
On Mon, 11 Mar 2024 13:31:06 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>
On Mon, 11 Mar 2024 13:45:19 GMT, Guoxiong Li wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unused methods
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/for
ses the annotations to become
> `@Anno(1) String @Anno(3) [] @Anno(2) []` in the output files; this bug also
> affects output class files so I assume this is a bug within javac's tree
> building. (Intersting, the buggy javadoc output was copied wholesale in the
> original `TestTypeAnno
On Mon, 11 Mar 2024 06:36:49 GMT, Guoxiong Li wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unused methods
>
> test/langtools/jdk/javadoc/doclet/testTypeAnnotations/typeannos
nno(2) []` in the output files; this bug also affects
> output class files so I assume this is a bug within javac's tree building.
> (Intersting, the buggy javadoc output was copied wholesale in the original
> `TestTypeAnnotations` output for `array2Deep` cases, but no one paid
>
On Mon, 11 Mar 2024 06:35:27 GMT, Guoxiong Li wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
On Sun, 10 Mar 2024 20:19:44 GMT, Chen Liang wrote:
> Please review this patch that fixes the issue where type annotations on
> primitive types are not linked.
>
> Tested with file
> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>
> import java.lang.anno
Please review this patch that fixes the issue where type annotations on
primitive types are not linked.
Tested with file https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
import java.lang.annotation.*;
public class ArrayAnno {
@Retention(RetentionPolicy.RUNTIME)
On Sun, 14 Jan 2024 01:00:36 GMT, Chen Liang wrote:
> Currently in the javadoc tool, the generated class use page does not track
> the occurrences of a class in the type arguments of the extends or implements
> list, where they can appear. (See more details on the JBS issue) Fo
On Fri, 23 Feb 2024 05:33:07 GMT, Chen Liang wrote:
>> Currently in the javadoc tool, the generated class use page does not track
>> the occurrences of a class in the type arguments of the extends or
>> implements list, where they can appear. (See more details on the JBS issu
o describe the missing usage scenarios.
>
> A preview of the new use page with the 2 new categories, generated based on
> the example above, can be found here:
> https://cr.openjdk.org/~liach/8323698-javadocuse/doc/class-use/One.html
Chen Liang has updated the pull request with a
On Thu, 22 Feb 2024 13:26:34 GMT, Pavel Rappo wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight addi
o describe the missing usage scenarios.
>
> A preview of the new use page with the 2 new categories, generated based on
> the example above, can be found here:
> https://cr.openjdk.org/~liach/8323698-javadocuse/doc/class-use/One.html
Chen Liang has updated the pull request incrementa
On Thu, 22 Feb 2024 04:53:20 GMT, Chen Liang wrote:
>> Currently in the javadoc tool, the generated class use page does not track
>> the occurrences of a class in the type arguments of the extends or
>> implements list, where they can appear. (See more details on the JBS issu
o describe the missing usage scenarios.
>
> A preview of the new use page with the 2 new categories, generated based on
> the example above, can be found here:
> https://cr.openjdk.org/~liach/8323698-javadocuse/doc/class-use/One.html
Chen Liang has updated the pull request with a
On Tue, 30 Jan 2024 04:16:54 GMT, Chen Liang wrote:
>> Currently in the javadoc tool, the generated class use page does not track
>> the occurrences of a class in the type arguments of the extends or
>> implements list, where they can appear. (See more details on the JBS issu
o describe the missing usage scenarios.
>
> A preview of the new use page with the 2 new categories, generated based on
> the example above, can be found here:
> https://cr.openjdk.org/~liach/8323698-javadocuse/doc/class-use/One.html
Chen Liang has updated the pull request with a
o describe the missing usage scenarios.
>
> A preview of the new use page with the 2 new categories, generated based on
> the example above, can be found here:
> https://cr.openjdk.org/~liach/8323698-javadocuse/doc/class-use/One.html
Chen Liang has updated the pull request in
o describe the missing usage scenarios.
>
> A preview of the new use page with the 2 new categories, generated based on
> the example above, can be found here:
> https://cr.openjdk.org/~liach/8323698-javadocuse/doc/class-use/One.html
Chen Liang has updated the pull request with a
On Mon, 22 Jan 2024 14:41:05 GMT, Hannes Wallnöfer wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
Currently in the javadoc tool, the generated class use page does not track the
occurrences of a class in the type arguments of the extends or implements list,
where they can appear. (See more details on the JBS issue) For example:
public class One {}
import java.util.*;
public class Two
On Wed, 8 Nov 2023 15:45:56 GMT, Konrad Windszus wrote:
> I know, but for memory consumption reasons everyone should prefer just
> passing an InputStream. Is the memory consumption with
> `ClassFile.of().parse(Path)` any better (i.e. are you using a
> `java.io.RandomAccessFile` or
On Wed, 8 Nov 2023 14:32:52 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Wed, 8 Nov 2023 13:31:32 GMT, Konrad Windszus wrote:
> I would appreciate a hint in the javadocs why `Classfile.of` requires a byte
> array and cannot deal with inputstreams (iiuc this is due to the lazy reading
> which requires adjusting the offset back and forth potentially)
You can
On Fri, 20 Oct 2023 17:22:10 GMT, Chen Liang wrote:
> This fixes the links to nested classes like `ValueLayout.OfLong` in the
> rendered sealed class hierarchy graph.
>
> A similar problem with nested classes exist for `@sealedGraph` on them, where
> their graphs will be gener
This fixes the links to nested classes like `ValueLayout.OfLong` in the
rendered sealed class hierarchy graph.
A similar problem with nested classes exist for `@sealedGraph` on them, where
their graphs will be generated to a wrong directory and the graph link broken,
as seen in
On Tue, 26 Sep 2023 12:32:37 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files changed
> are
On Mon, 5 Jun 2023 10:47:59 GMT, Pavel Rappo wrote:
> Although its name might suggest otherwise,
> java.util.ConcurrentModificationException (CME) is not necessarily thrown in
> multithreaded context. For example, a map might throw CME if it detects
> modification in a midst of an operation
On Tue, 9 May 2023 04:11:03 GMT, Chen Liang wrote:
> `@sealedGraph` had a mechanism to render non-sealed classes differently, but
> it's useless because the graph nodes are not bordered. This patch converts
> the non-sealed classes to be rendered in italics instead.
>
On Fri, 12 May 2023 22:07:12 GMT, Jonathan Gibbons wrote:
>> `@sealedGraph` had a mechanism to render non-sealed classes differently, but
>> it's useless because the graph nodes are not bordered. This patch converts
>> the non-sealed classes to be rendered in italics instead.
>>
>> An example
On Mon, 15 May 2023 06:46:28 GMT, Per Minborg wrote:
>> `@sealedGraph` had a mechanism to render non-sealed classes differently, but
>> it's useless because the graph nodes are not bordered. This patch converts
>> the non-sealed classes to be rendered in italics instead.
>>
>> An example of
ierarchy except
> `DynamicConstantDesc`:
> JDK 20:
> 
>
> This patch:
> `.
>>
>> While the change primarily targets
80 matches
Mail list logo
