hg: jigsaw/jake/jdk: 8136790: @argfile does not work after -addmods or -modulepath

Changeset: cc51fbfc6390 Author:mchung Date: 2015-09-18 17:39 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/cc51fbfc6390 8136790: @argfile does not work after -addmods or -modulepath Reviewed-by: henryjen ! src/java.base/share/native/libjli/args.c

Re-examine ClassLoader.getPackage(s) methods

In Jake, we fixed several long-standing issues about ClassLoader::getPackage(s) and ClassLoader::definePackage method. 4302423: class loaders should support "local" creation of Package objects 4841786: (cl) flaw in ClassLoader getPackage/definePackage API 4302406 Package sealing and

hg: jigsaw/jake/jdk: 8136802: Creation of a logger with a resource bundle contained in the same named module fails

Changeset: 3862c75182ad Author:mchung Date: 2015-09-21 13:27 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3862c75182ad 8136802: Creation of a logger with a resource bundle contained in the same named module fails Contributed-by: daniel.fu...@oracle.com !

hg: jigsaw/jake/jdk: 8136433: Intermittent NPE in ResourceBundle

Changeset: a4ab00fa0f96 Author:okutsu Date: 2015-09-24 16:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a4ab00fa0f96 8136433: Intermittent NPE in ResourceBundle Reviewed-by: naoto, mchung ! src/java.base/share/classes/sun/util/resources/Bundles.java !

Re: Is there really a jdk.proxy1 module?

> On Dec 8, 2015, at 7:10 AM, Stephane Epardaud wrote: > > On 08/12/15 16:07, Peter Levart wrote: >> >> >> Do you really have to addRead() ? Visibility of of classes >> (Class.forName()) should only depend on class loader delegation. >> Enumerating members, when you already

Re: CFV: New Jigsaw Committer: Jan Lahoda

Vote: yes Mandy

Re: Is there really a jdk.proxy1 module?

> On Dec 8, 2015, at 2:05 PM, Peter Levart wrote: > > Hi Mandy, > > I don't think such special-casing for proxy classes is warranted and would > just complicate security-sensitive code. That was definitely a concern. Good point. Existing code should use

Re: [9] RFR:8130360: Add tests to verify 3rd party security providers if they are in signed/unsigned modular JARs

Some high-level comment: 1. I suggest to rename JigsawSecurityUtils.java to SecurityUtils.java. The Jigsaw prefix is not needed. 2. SecurityProviderModularTest does the setup and launch the test with a set of different settings. I suggest to convert it to TestNG and you can reference the

hg: jigsaw/jake/nashorn: 25 new changesets

Changeset: 752ca580b176 Author:attila Date: 2015-11-09 14:03 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/752ca580b176 8141541: Simplify Nashorn's Context class loader handling Reviewed-by: hannesw, sundar !

hg: jigsaw/jake/jaxws: 3 new changesets

Changeset: e8d15c61400c Author:lana Date: 2015-11-19 09:36 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/e8d15c61400c Added tag jdk9-b93 for changeset 5e94fbbb7032 ! .hgtags Changeset: 3e03ddaaac65 Author:lana Date: 2015-11-29 11:00 -0800 URL:

hg: jigsaw/jake/jdk: 101 new changesets

Changeset: 612588a68bd3 Author:psandoz Date: 2015-11-09 09:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/612588a68bd3 8141630: Specification of Collections.synchronized* need to state traversal constraints Reviewed-by: psandoz Contributed-by: Tagir Valeev

hg: jigsaw/jake/corba: 7 new changesets

Changeset: e7ddf972e152 Author:chegar Date: 2015-11-11 11:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/e7ddf972e152 8140606: Update library code to use internal Unsafe Reviewed-by: alanb, mchung, psandoz, weijun !

hg: jigsaw/jake/nashorn: 16 new changesets

Changeset: aac8413d3bb7 Author:hannesw Date: 2015-11-23 15:26 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/aac8413d3bb7 8141407: Wrong evaluation of a != a when a = NaN Reviewed-by: sundar, attila !

hg: jigsaw/jake/jdk: 125 new changesets

94838afd5e5b Author:mchung Date: 2015-11-23 12:44 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/94838afd5e5b 8140450: Implement JEP 259: Stack-Walking API Reviewed-by: coleenp, dfuchs, bchristi, psandoz, sspitsyn Contributed-by: Mandy Chung <mandy.ch...@oracle.com>

hg: jigsaw/jake/langtools: 13 new changesets

Changeset: 73adc11fd50f Author:sadayapalam Date: 2015-11-26 07:44 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/73adc11fd50f 8143647: Javac compiles method reference that allows results in an IllegalAccessError Summary: Lambda implementation method synthesized by

hg: jigsaw/jake/hotspot: Missing closing bracket breaks hotspot build

Changeset: df521234d197 Author:mchung Date: 2015-12-11 15:37 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/df521234d197 Missing closing bracket breaks hotspot build ! src/share/vm/classfile/systemDictionaryShared.hpp

hg: jigsaw/jake/jaxp: 6 new changesets

Changeset: e2fbfb7ed78a Author:joehw Date: 2015-11-30 16:17 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/e2fbfb7ed78a 8142463: Xml schema validation failing after Xerces update; maxOccurs ignored Reviewed-by: lancea !

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: 4ffdfd9c1c81 Author:redestad Date: 2015-12-15 16:36 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4ffdfd9c1c81 InstalledModuleFinderPlugin could avoid emitting duplicate sets ! src/java.base/share/classes/java/lang/module/ModuleDescriptor.java !

hg: jigsaw/jake: Fixup jdk.hotspot.agent workaround

Changeset: 90ba04818266 Author:mchung Date: 2015-12-11 16:24 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/90ba04818266 Fixup jdk.hotspot.agent workaround ! make/CompileJavaModules.gmk

hg: jigsaw/jake/jdk: Update definePackage @throws IAE javadoc and builtin loader to handle IAE case

Changeset: ec4fb763dbce Author:mchung Date: 2015-12-17 12:10 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/ec4fb763dbce Update definePackage @throws IAE javadoc and builtin loader to handle IAE case ! src/java.base/share/classes/java/lang/ClassLoader.java !

hg: jigsaw/jake/hotspot: 8142333: Build failure in debugInfoRec.cpp with SS12u4

Changeset: 5ef7fe2c05cc Author:never Date: 2015-11-30 15:21 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/5ef7fe2c05cc 8142333: Build failure in debugInfoRec.cpp with SS12u4 Reviewed-by: coleenp, dholmes, erikj, kvn ! src/share/vm/code/debugInfoRec.cpp

hg: jigsaw/jake/jdk: Declares services used by java.xml.ws module

Changeset: 289db8c48808 Author:mchung Date: 2015-12-14 12:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/289db8c48808 Declares services used by java.xml.ws module ! test/ProblemList.jake.txt

hg: jigsaw/jake/jaxws: Declares services used by java.xml.ws module

Changeset: bb6d39011cba Author:mchung Date: 2015-12-14 12:04 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/bb6d39011cba Declares services used by java.xml.ws module ! src/java.xml.ws/share/classes/module-info.java

hg: jigsaw/jake/jdk: Problem list Bug8141243.java test

Changeset: 53670f1d82e2 Author:mchung Date: 2015-12-14 13:09 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/53670f1d82e2 Problem list Bug8141243.java test ! test/ProblemList.jake.txt

hg: jigsaw/jake/jdk: Separate BasicImageReader::getNativeMap to avoid eager loading of libjimage

Changeset: 549e0f5168ff Author:mchung Date: 2016-01-06 15:15 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/549e0f5168ff Separate BasicImageReader::getNativeMap to avoid eager loading of libjimage ! make/mapfiles/libjimage/mapfile-vers !

hg: jigsaw/jake/jdk: 8144801: Class.forName(Module, String) throws unspecified SecurityException

Changeset: 5012fe22f082 Author:mchung Date: 2016-01-05 13:54 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5012fe22f082 8144801: Class.forName(Module,String) throws unspecified SecurityException ! src/java.base/share/classes/java/lang/Class.java !

hg: jigsaw/jake/jdk: Modules without the ConcealedPackages attribute can be linked but may not run

Changeset: 54a365a71c28 Author:mchung Date: 2016-01-08 18:48 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/54a365a71c28 Modules without the ConcealedPackages attribute can be linked but may not run !

hg: jigsaw/jake/jdk: 8139430: Refactor test library to decrease module dependencies of tests

Changeset: 45cb94eef0ec Author:shurailine Date: 2015-11-23 11:49 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/45cb94eef0ec 8139430: Refactor test library to decrease module dependencies of tests Reviewed-by: mchung, alanb !

Re: Apple internal api's

com.apple.eawt is in java.desktop module. Try this: java -XaddExports:java.desktop/com.apple.eawt=ALL-UNNAMED Mandy > On Nov 24, 2015, at 5:52 PM, Michael Hall wrote: > > I know these are being addressed as part of JEP 272 [1], but for now. > I have a shell script that

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

> On Nov 23, 2015, at 7:40 AM, Alan Bateman wrote: > > > > On 23/11/2015 15:27, Attila Szegedi wrote: >> Folks, >> >> I integrated the changes Mandy suggested; please review these (build >> related) changes: >> jdk9 top level: >>

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

> On Nov 23, 2015, at 8:42 AM, Alan Bateman wrote: > > We need to do a bit of clean-up in Images.gmk to make things clearer as this > MAIN vs. PROVIDER topic has caused confusion on a few cases. If we can keep > the lists separate to the list of modules for the

hg: jigsaw/jake/jdk: 2 new changesets

Changeset: e6921b23f45b Author:mchung Date: 2015-11-19 14:03 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e6921b23f45b ClassLoader::loadLocalClass should call findClass only if not loaded ! src/java.base/share/classes/java/lang/ClassLoader.java Changeset:

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

and we will fix it when the changeset propagates to jake. Mandy > On Nov 19, 2015, at 7:00 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > I reviewed the top repo change. > > modules.xml looks fine. > > jdk.dynalink should be in MAIN_MODULES

Re: About 8056174: New APIs for jar signing

This looks okay. We will push this fix once we pull down your changeset to jake. One question: is “altsignerpath” and “altsigner” properties are only for the existing jarsigner -altsigner option to work? Is it the plan to deprecate this -altsigner option? Mandy > On Nov 19, 2015, at 4:40

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

I reviewed the top repo change. modules.xml looks fine. jdk.dynalink should be in MAIN_MODULES since it has exported APIs. jdk.scripting.nashorn should be moved too. They are not sole service providers. Since you are on this file, can you move jdk.scripting.nashorn to MAIN_MODULES as

Re: RFR: 8139430

not used anywhere currently, I assume re-throwing the > InterruptedException is a better choice. > > http://cr.openjdk.java.net/~shurailine/8139430/webrev.07/test/lib/testlibrary/jdk/testlibrary/management/ThreadMXBeanTool.java.html > > Shura > >> On Nov 16, 2015, at

hg: jigsaw/jake/jdk: Extend module-info.class with ConcealedPackages attribute at jlink time

Changeset: d41cf6570154 Author:mchung Date: 2016-01-11 19:30 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d41cf6570154 Extend module-info.class with ConcealedPackages attribute at jlink time ! src/java.base/share/classes/java/lang/module/InstalledModuleFinder.java !

Re: Review Request: JDK-8155955: packager needs to determine the root modules to create JRE image

> On Jun 4, 2016, at 10:01 AM, Alan Bateman wrote: > > On 04/06/2016 17:01, Kevin Rushforth wrote: > >> What the packager needs is a means at runtime to get the same set of JRE >> modules that an application in the unnamed module reads by default. If there >> is a

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

unchers created by jlink, > this one need a -J like option, not a JNI invoked piece of C. > > cheers, > Rémi > > - Mail original - >> De: "Mandy Chung" <mandy.ch...@oracle.com> >> À: "Remi Forax" <fo...@univ-mlv.fr> >>

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

"-Djdk.module.path” 204 #define MODULE_UPGRADE_PATH_PROPERTY "-Djdk.module.upgrade.path" It may be good to consider having #define for all module property names and used consistently. Mandy > On Jun 3, 2016, at 11:47 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > Webrev:

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 8, 2016, at 10:30 AM, Dmitry Dmitriev > wrote: > > Hello Mandy, > > As I understand all these options are tested by following tests: > jdk/test/tools/launcher/modules. I.e. no additional tests are required for > moving these options to the VM(except 2

Re: RFR 8158855: Fix remaining module dependences in java/lang

Hi Shura, test/java/lang/Class/GetModuleTest.java This can use java.base/jdk.internal.misc.Unsafe instead. Other @modules looks okay. Regarding the executeTestJava change, if you drop the VM options, this test will only exercise the default launcher setting. The hotspot nightlies depend

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

Adding jigsaw-dev where the code review is posted. See [1] for Coleen’s review comment. > On Jun 8, 2016, at 4:53 PM, David Holmes wrote: > > On 9/06/2016 8:37 AM, Coleen Phillimore wrote: >> >> >> I have to ask why Hotspot convention was violated with this new

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 8, 2016, at 3:37 PM, Coleen Phillimore > wrote: > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.01/jdk/src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java.udiff.html > > + /** > + * Gets and remove the named system

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

> On Jun 12, 2016, at 11:33 AM, Alan Bateman wrote: > > > > On 12/06/2016 13:44, Wang Weijun wrote: >> I was about to send out a new webrev (CCC just approved) but noticed a >> behavior change. >> >> Although "-addprovider SUN" is useless it still worked when I

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

> On Jun 10, 2016, at 12:08 AM, Masayoshi Okutsu > wrote: > > (re-sending to include jigsaw-dev) > > Hi, > > Please review fixes for 8158272 and 8158468. The test had several problems. > > : > Webrev: >

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 10, 2016, at 12:53 PM, Alan Bateman wrote: > > On 10/06/2016 17:38, Daniel D. Daugherty wrote: > >> >> I just re-read this... >> >> A space in the VM option? As in '-addmods'? That's a >> completely new idea for VM options processing and one that we took >>

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 10, 2016, at 7:18 AM, Coleen Phillimore > wrote: > >> Just to put more context on this patch. We are cleaning up the command line >> option handling and trying to get things more consistent. It will take a >> number of steps. One of the patches to

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> On Jun 4, 2016, at 12:05 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > >> On 04/06/2016 07:47, Mandy Chung wrote: >> >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.00/ > There's an update to java.lang.Sy

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

> Hi Mandy, > did you think about using -J for specifying either VM options or module > options (the user really don't care) for custom launchers like we use -J to > specify VM option to javac ? > > cheers, > Rémi > > - Mail original - >> De: "Mandy

Re: 8156143: Module.getResourceAsStream throws unspecified SecurityException with module in custom Layer

> On May 25, 2016, at 2:40 AM, Alan Bateman wrote: > > This is minor mismatch between javadoc + implementation when > getResourceAsStream is called on a module in a custom Layer and access is > denied by the security manager. It's a one line fix, this is mostly just a

Re: 8150668: Layer.defineModulesXXX with a Configuration containing java.base throws undocumented exception

> On May 25, 2016, at 4:09 AM, Alan Bateman wrote: > > > This is another small fix where the Layer javadoc doesn't make it clear that > there can only be one "java.base" module in the VM. The enforcement has been > there but it wasn't specified and there weren't

Re: 8156142: ModuleReader instances don't always throw NPE for passed null args

> On May 25, 2016, at 4:49 AM, Alan Bateman wrote: > > > Another trivial patch, this time it's the ModuleReader for the system modules > is missing a null check so that it doesn't throw the expected NPE. The patch > is to mostly just expand test coverage. >

Re: creating proxies for interfaces with default methods

> On May 25, 2016, at 1:12 PM, Jochen Theodorou wrote: > >>> Dynamic proxies and invocation handlers won't do the job, as they do not >>> provide an implementation of the interface I can call the default method >>> on. >> >> Is this a general limitation of j.l.r.Proxy? At

Re: Review Request JDK-8136930 Examine implications for custom launchers, equivalent of java -X options in particular

Harold has incorporated feedback from David, Coleen, Lois and others and updated webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8136930/webrev.02/ The only change compared to webrev.01 is in hotspot arguments.{cpp,hpp} and a new ModuleOptionsTest.java. I see concerns from Coleen on

Re: RFR JDK-8159206 - All jlink tests failing

> On Jun 10, 2016, at 12:20 PM, Jim Laskey (Oracle) > wrote: > > http://cr.openjdk.java.net/~jlaskey/8159206/webrev/index.html > https://bugs.openjdk.java.net/browse/JDK-8159206 >

Re: RFR: 8159334: ModuleDescriptor retains overlapping sets for all and concealed packages

> On Jun 13, 2016, at 4:38 AM, Claes Redestad wrote: > > Hi, > > afraid I found some subtle bugs with some tests I forgot to check earlier: > > http://cr.openjdk.java.net/~redestad/8159334/webrev.02/ This looks fine. It’d be good if you verify with -testset core

Re: RFR: 8158272 & 8158468 (tools/jlink/plugins/IncludeLocalesPluginTest.java bug fixes)

> On Jun 12, 2016, at 11:10 PM, Masayoshi Okutsu <masayoshi.oku...@oracle.com> > wrote: > > On 6/11/2016 5:53 AM, Mandy Chung wrote: >>> On Jun 10, 2016, at 12:08 AM, Masayoshi Okutsu >>> <masayoshi.oku...@oracle.com> wrote: >>>

Re: RFR JDK-8159206 - All jlink tests failing

I reviewed http://cr.openjdk.java.net/~jlaskey/8159206/webrev Looks much cleaner. Thanks for the update 342 StringSharingPlugin(String[] patterns) throws IOException { 343 this(ResourceFilter.includeFilter(Arrays.asList(patterns))); 344 } Looks like it’s not used except the

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

I agree JSObject.getWindow(Applet) should have forRemoval=true, as I raised in awt-dev thread. The confusion there was when the API marked forRemoval=true in JDK 9 and when it should really be removed. Mandy > On Jun 13, 2016, at 12:53 PM, Philip Race wrote: > >

Re: RFR of JDK-8158149: test bug for SystemModuleFinder when fast path is supported

>> On 30/05/2016 12:48, Hamlin Li wrote: >>> Would you mind to review the following patch? >>> >>> bug: https://bugs.openjdk.java.net/browse/JDK-8158149 >>> >>> webrev: http://cr.openjdk.java.net/~mli/8158149/webrev.00/ >>> >>> >>> The system property to disable fast path should be >>>

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

gt;>> >>> I highly doubt this will work in an OSGi-Env like Eclipse (which the 99%) >>> use case for SWT useage. >>> >>> The SWT jar is not on the application classpath so how should a module >>> (named or unnamed) find the SWT classes? >>>

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

> On May 25, 2016, at 3:38 PM, Kevin Rushforth > wrote: > > Please review the following: > > https://bugs.openjdk.java.net/browse/JDK-8131888 > http://cr.openjdk.java.net/~kcr/8131888/webrev.00/ > > This adds support for the javafx.embed.swt package back into the

Re: [9] review request: 8131888: Deliver javafx.swt as a modular jar in JDK 9

> On May 27, 2016, at 1:30 AM, Tom Schindl wrote: > > Do you have an example how to construct such a Layer? // path is the path to javafx-swt.jar ModuleFinder finder = ModuleFinder.of(path); Configuration cf = Layer.boot() .configuration()

Re: RFR of JDK-8158194: Rename the directory "InstalledModuleDescriptors" and any reference to "installed" to "system" in the tests

> On May 31, 2016, at 5:58 PM, Hamlin Li wrote: > > Typo. > webrev: http://cr.openjdk.java.net/~mli/8158194/webrev.00 > Thanks for doing this. I think you mean webrev.01 that shows hg rename properly and that looks good. Nit: src/m1/p1/Main.java 40 // check

Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

> On Jun 21, 2016, at 9:53 PM, Naoto Sato wrote: > > Modified line 243-246 to avoid generating a new List instance with > Collectors.toList(): > > http://cr.openjdk.java.net/~naoto/8159781/webrev.03/ +1 Mandy

Re: Review Request: JDK-8155955: packager needs to determine the root modules to create JRE image

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8155955/webrev.02 With further discussion with Chris Bensen and others, we agree that the packager would require the presence of the packaged module of jdk.packager to be present matching the runtime version of the image being created. The

Re: RFR 8158855: Fix remaining module dependences in java/lang

> On Jun 14, 2016, at 3:53 PM, Alexandre (Shura) Iline > wrote: > > Hi. > > After some offline conversations it was decided to leave the tests which > depend on absence of “-limitmods” in VM options for later. I have created a > separate bug ti track that: >

Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

> On Jun 17, 2016, at 3:29 PM, Naoto Sato wrote: > > Decided to fix this separately from the other include locales issues. Here is > the bug and the proposed fix: > > https://bugs.openjdk.java.net/browse/JDK-8159781 > http://cr.openjdk.java.net/~naoto/8159781/webrev.00/

Re: [9] RFR: 8159781: jlink --include-locales fails with java.util.regex.PatternSyntaxException

the current way. >> >> I will modify the "regex:" prepending as you suggested. >> >> Naoto >> >> On 6/17/16 3:50 PM, Mandy Chung wrote: >>> >>>> On Jun 17, 2016, at 3:29 PM, Naoto Sato <naoto.s...@oracle.com

Re: RFR 8158855: Fix remaining module dependences in java/lang

> On Jun 14, 2016, at 4:00 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > >> On Jun 14, 2016, at 3:53 PM, Alexandre (Shura) Iline >> <alexandre.il...@oracle.com> wrote: >> >> Hi. >> >> After some offline conversations it w

Re: 8159248: ModuleFinder.of spec + 8158456: ModuleDescriptor.read does not verify dependence on java.base

> On Jun 16, 2016, at 8:33 AM, Alan Bateman wrote: > > I need a Reviewer for a patch is to address two conformance issues. > > One is that the ModuleFinder.of(Path...) javadoc doesn't make it clear that > an exception is thrown when a module descriptor cannot be

Re: RFR: 8154399, 8159096, export packages containing standard javadoc doclet

> On Jun 16, 2016, at 7:28 PM, Jonathan Gibbons > wrote: > > Please review this simple fix for two related aspects of the same problem: > > Export the "standard doclet" used by javadoc, such that it is possible to > derive alternative doclets, either by

Re: Review Request: JDK-8155955: packager needs to determine the root modules to create JRE image

> On Jun 18, 2016, at 7:45 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 15/06/2016 19:49, Mandy Chung wrote: > >> With further discussion with Chris Bensen and others, we agree that the >> packager would require the presence of the packaged module of

hg: jigsaw/jake/jdk: Create new HashSet for packages only if it's different than concealed packages

Changeset: 9c0ea8bde546 Author:mchung Date: 2016-01-13 15:58 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9c0ea8bde546 Create new HashSet for packages only if it's different than concealed packages to tune startup performance. Contributed-by: claes.redes...@oracle.com,

hg: jigsaw/jake: Fix the location of image files for jdk.hotspot.agent

Changeset: c806e24af9fb Author:mchung Date: 2016-01-13 17:40 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/c806e24af9fb Fix the location of image files for jdk.hotspot.agent ! make/CompileJavaModules.gmk

Re: trying jigsaw-ea-95 jlink

Sebastian, Martin, Thanks for reporting the issue. This issue has been fixed and available in the Jigsaw EA build [1]. JDK-8145775: Modules without the ConcealedPackages attribute can be linked but may not run Please let me know if you run into any other issue. Mandy [1]

hg: jigsaw/jake/jdk: Minor cleanup on Class.forName

Changeset: 129618f8a89b Author:mchung Date: 2016-01-14 10:53 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/129618f8a89b Minor cleanup on Class.forName ! src/java.base/share/classes/java/lang/Class.java

Re: RFR 8160346: JLinkTest.java should compute exact number of plugins from jdk.jlink module [ was Re: RFR 8153238: Improve test/tools/jlink/JLinkTest.java not to hard code the number of plugins]

> On Jun 27, 2016, at 4:19 AM, Sundararajan Athijegannathan > wrote: > > Sorry I had that test change already. I've filed another bug to track > your suggestions. > > Please review http://cr.openjdk.java.net/~sundar/8160346/webrev.00/ for >

Re: Review request: JDK-8159596 Add java --dry-run

Paul > > On Mon, Jun 27, 2016 at 10:48 AM, Raymond Gallardo > <raymond.galla...@oracle.com> wrote: > Hi Mandy, > > Does this enhancement need to be doc'd? If so, could you add a subtask > (component = docs)? > > Thanks, > --Raymond > > On 24/06/2016 9:49

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

I’m including security-dev which would be a better list to review this test fix. Valerie, Does this test have to be order-sensitive? I think this test would be cleaner to make it order-insensitive and simply test the security provider initialization. See my comments below. > On Jun 27,

Re: No jrt-fs.jar in JRE?

> On Jun 24, 2016, at 10:07 PM, Jayaprakash Arthanareeswaran > wrote: > > My experiment to use the jrt-fs.jar from the JDK to load the system classes > in JRE failed. May be I am not > doing something right. Is that even supposed to work if I done the right > way? You

hg: jigsaw/jake/jdk: Exclude indy string concat tests until it's enabled

Changeset: 54d2387b00d7 Author:mchung Date: 2016-02-05 15:12 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/54d2387b00d7 Exclude indy string concat tests until it's enabled ! test/ProblemList.jake.txt

hg: jigsaw/jake/jdk: Define Package objects lazily as it's not always needed

Changeset: 7a54c4b00471 Author:mchung Date: 2016-02-08 12:44 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/7a54c4b00471 Define Package objects lazily as it's not always needed ! src/java.base/share/classes/java/lang/Class.java !

Re: RFR 8149391: Fix module dependencies in java/util

> On Feb 8, 2016, at 11:43 AM, Alexandre (Shura) Iline > wrote: > > Hi. > > Could you please take a look on additional module dependencies to be added > for tests in java/util. There is more work to do for :jdk_core test group, > which is to come separately. > >

hg: jigsaw/jake/jdk: Cache Version in jdk.internal.module.Builder, allowing us to cheaply ensure we only create one Version for a JRE/JDK image.

Changeset: aff1c58b616e Author:redestad Date: 2016-02-10 17:12 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/aff1c58b616e Cache Version in jdk.internal.module.Builder, allowing us to cheaply ensure we only create one Version for a JRE/JDK image. !

hg: jigsaw/jake/hotspot: Fix up JvmtiExport function signature

Changeset: b59ef60e72fc Author:sspitsyn Date: 2016-02-08 14:53 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/b59ef60e72fc Fix up JvmtiExport function signature ! src/share/vm/prims/jvmtiExport.hpp

hg: jigsaw/jake/jdk: jlink test should check if jmods are present

Changeset: 00023ccfa6da Author:mchung Date: 2016-02-05 18:41 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/00023ccfa6da jlink test should check if jmods are present ! test/jdk/jigsaw/tools/jlink/plugins/InstalledModuleDescriptors/UserModuleTest.java

Re: RFR 8149391: Fix module dependencies in java/util

> On Feb 8, 2016, at 3:36 PM, Alexandre (Shura) Iline > <alexandre.il...@oracle.com> wrote: > >> >> On Feb 8, 2016, at 1:23 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> >>> On Feb 8, 2016, at 11:43 AM, Alexandre (Shura) Ilin

hg: jigsaw/jake/jdk: Change InstalledModules::modules() returns an array for startup perf

Changeset: 3016d4219a82 Author:redestad Date: 2016-02-05 21:56 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3016d4219a82 Change InstalledModules::modules() returns an array for startup perf ! src/java.base/share/classes/java/lang/module/InstalledModuleFinder.java !

hg: jigsaw/jake: Add jlinkdocs target

Changeset: 761cfe56e340 Author:mchung Date: 2016-01-27 11:27 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/761cfe56e340 Add jlinkdocs target ! make/Javadoc.gmk

hg: jigsaw/jake: javadoc for jlink should be in docs/jdk output directory

Changeset: 620b8baa844b Author:mchung Date: 2016-01-27 12:04 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/620b8baa844b javadoc for jlink should be in docs/jdk output directory ! make/Javadoc.gmk

hg: jigsaw/jake/jdk: Follow-up jlink/jimage test fix for bootmodules.jimage rename

Changeset: 1741c2f65330 Author:mchung Date: 2016-01-29 12:18 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1741c2f65330 Follow-up jlink/jimage test fix for bootmodules.jimage rename ! test/jdk/jigsaw/tools/jimage/JImageTest.java !

hg: jigsaw/jake/langtools: Update jdeps to work with modules

Changeset: 091d9535ceb9 Author:mchung Date: 2016-02-26 00:13 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/091d9535ceb9 Update jdeps to work with modules ! make/CompileInterim.gmk ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Analyzer.java !

hg: jigsaw/jake/jdk: 8150664: Split "provides" lines in module-info.java get ignored

Changeset: d8e638c47144 Author:mchung Date: 2016-02-29 16:40 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d8e638c47144 8150664: Split "provides" lines in module-info.java get ignored ! make/src/classes/build/tools/jigsaw/GenGraphs.java !

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

> On Feb 21, 2016, at 1:45 AM, Wang Weijun <weijun.w...@oracle.com> wrote: > > >> On Feb 20, 2016, at 4:01 AM, Mandy Chung <mandy.ch...@oracle.com> wrote: >> >> >>> On Feb 19, 2016, at 2:47 AM, Wang Weijun <weijun.w...@oracle.com>

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

> On Feb 22, 2016, at 5:55 PM, Wang Weijun wrote: > 303 // A provider in module can also be use class name 304 if (p.getClass().getName().equals(provClass)) { ProviderConfig::getProvider doesn’t compare the classname. I

hg: jigsaw/jake/jdk: Exclude JImageTest.java test on windows

Changeset: 1ec154620ca2 Author:mchung Date: 2016-02-26 11:45 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1ec154620ca2 Exclude JImageTest.java test on windows ! test/ProblemList.jake.txt

Re: RFR 8130302: jarsigner and keytool -providerClass needs be re-examined for modules

> On Feb 22, 2016, at 7:28 PM, Wang Weijun wrote: > > Webrev updated at http://cr.openjdk.java.net/~weijun/8130302/webrev.03/. > > -provider and loadProviderByName() are useless for jdk9/dev, and > loadProviderByClass() only uses reflection. > I reviewed the provider

Re: 8148147: Sync up @modules from jigsaw/jake

> On Jan 25, 2016, at 6:12 AM, Alan Bateman wrote: > > > The tests in JDK 9 were updated some time ago to add @modules. Some tests > were missed at the time, new tests have been added, tests have changed and as > expected, the @modules values have started to bit rot.

<    1   2   3   4   5   6   7   8   9   10   >