feyman2016 closed pull request #10593:
URL: https://github.com/apache/kafka/pull/10593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
jsancio commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619882084
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, boolean
feyman2016 commented on pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#issuecomment-826304130
@jsancio Could you please help to review? Thanks!
Locally verified, all the failed tests should not be related. See failed
tests in
https://ci-builds.apache.org/job/Kafka/
mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r619875764
##
File path: docs/streams/upgrade-guide.html
##
@@ -93,6 +95,12 @@ Upgrade Guide and API Changes
Streams API changes in 3.0.0
+
+ The
chia7712 commented on pull request #9627:
URL: https://github.com/apache/kafka/pull/9627#issuecomment-826320025
@showuon thanks for this patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
feyman2016 commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r619793709
##
File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchBuilder.java
##
@@ -96,7 +96,7 @@ public BatchBuilder(
}
/**
- *
ijuma commented on a change in pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#discussion_r619888968
##
File path: build.gradle
##
@@ -1491,13 +1491,14 @@ project(':streams') {
}
tasks.create(name: "copyDependantLibs", type: Copy) {
-from (confi
ijuma commented on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-826400303
@dejan2609 can you please rebase on trunk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
vitojeng opened a new pull request #10597:
URL: https://github.com/apache/kafka/pull/10597
follow-up #8200
KAFKA-5876's PR break into multiple parts, this PR is part 3 - apply
StreamsNotStartedException
### Committer Checklist (excluded from commit message)
- [ ] Verify des
vitojeng commented on pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#issuecomment-826589358
@ableegoldman Please take a look.
BTW, I encounter a
[ClassDataAbstractionCoupling](https://checkstyle.org/config_metrics.html#ClassDataAbstractionCoupling)
check style
dengziming opened a new pull request #10598:
URL: https://github.com/apache/kafka/pull/10598
*More detailed description of your change*
![image](https://user-images.githubusercontent.com/26023240/116053055-d569d280-a6ac-11eb-84d1-3b6d8760214e.png)
1. The argument description "The topi
vitojeng edited a comment on pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#issuecomment-826589358
@ableegoldman Please take a look.
BTW, I encounter a
[ClassDataAbstractionCoupling](https://checkstyle.org/config_metrics.html#ClassDataAbstractionCoupling)
check
feyman2016 commented on pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#issuecomment-826653099
@jsancio I updated the PR, and the failed tests should be unrelated, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
feyman2016 edited a comment on pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#issuecomment-826653099
@jsancio Thanks for the review! I updated the PR, and the failed tests
should be unrelated, thanks!
--
This is an automated message from the Apache Git Service.
To r
bruto1 edited a comment on pull request #10590:
URL: https://github.com/apache/kafka/pull/10590#issuecomment-826126350
I guess failing tests are par for the course here
pls review! @chia7712 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
jsancio commented on a change in pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#discussion_r620232416
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -2268,6 +2269,20 @@ private Long append(int epoch, List records, boolean
rondagostino commented on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-826903361
@cmccabe Thanks for taking a look. I agree in principle with your statement
that `KafkaRaftServer` should know nothing about ZooKeeper or AclAuthorizer.
My reasoning for
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620437193
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/AbstractMetadataMessageSerde.java
##
@@ -19,52 +19,
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620438317
##
File path:
raft/src/main/java/org/apache/kafka/raft/metadata/AbstractMetadataRecordSerde.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Softw
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620438864
##
File path:
raft/src/main/java/org/apache/kafka/raft/metadata/AbstractMetadataRecordSerde.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Softw
junrao commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620449297
##
File path:
raft/src/main/java/org/apache/kafka/raft/metadata/AbstractMetadataRecordSerde.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Softwa
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620449322
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Softwar
junrao commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620455106
##
File path:
raft/src/main/java/org/apache/kafka/raft/metadata/AbstractMetadataRecordSerde.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Softwa
Jason Gustafson created KAFKA-12716:
---
Summary: Admin API for aborting transactions
Key: KAFKA-12716
URL: https://issues.apache.org/jira/browse/KAFKA-12716
Project: Kafka
Issue Type: Sub-tas
[
https://issues.apache.org/jira/browse/KAFKA-12716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson reassigned KAFKA-12716:
---
Assignee: Jason Gustafson
> Admin API for aborting transactions
> -
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620457633
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs, boo
satishd commented on pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#issuecomment-826988567
Thanks @junrao for the review. Addressed them with the inline replies, and
with the commit
https://github.com/apache/kafka/pull/10271/commits/265b72692f590ab5760776f2b5176066c0
satishd commented on pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#issuecomment-826991751
@junrao: I will have a followup PR for moving `RecordSerde`,
`AbstractApiMessageSerde`, `BytesApiMessageSerde` into clients modules as I
discussed earlier.
--
This is an au
mjsax commented on a change in pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#discussion_r620479940
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
##
@@ -402,6 +402,11 @@ public void shouldReturnKeysWith
lct45 commented on pull request #10519:
URL: https://github.com/apache/kafka/pull/10519#issuecomment-826998105
bumping - @mjsax @ableegoldman @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mjsax commented on pull request #10548:
URL: https://github.com/apache/kafka/pull/10548#issuecomment-826998394
To avoid checkstyle and test issues, and reduce review turn-around time, I
would recommend to run unit tests and checkstyle locally before pushing update:
`./gradlew clean stream:
[
https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ming Liu updated KAFKA-12713:
-
Summary: Report "REAL" follower/consumer fetch latency (was: Report "REAL"
broker/consumer fetch latenc
junrao commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620461362
##
File path:
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadata.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apac
[
https://issues.apache.org/jira/browse/KAFKA-5540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-5540:
-
Summary: Deprecate internal converter configs (was: Deprecate and remove
internal converter conf
[
https://issues.apache.org/jira/browse/KAFKA-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332630#comment-17332630
]
Philip Bourke commented on KAFKA-8147:
--
I'm looking to implement this fix but it see
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620449322
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Softwar
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620457633
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs, boo
[
https://issues.apache.org/jira/browse/KAFKA-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332630#comment-17332630
]
Philip Bourke edited comment on KAFKA-8147 at 4/26/21, 5:34 PM:
---
rondagostino commented on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-827032633
> It might be helpful to move the znode setup code into KafkaZkClient
@cmccabe One possibility is that the first time we connect to ZooKeeper we
connect without the c
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620529858
##
File path:
raft/src/main/java/org/apache/kafka/raft/metadata/AbstractMetadataRecordSerde.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Softw
rondagostino commented on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-827040926
> we need to start forwarding the ACL operations to the controller
We forward the Create/Remove operations to the controller, BUT this patch
actually short-circuits t
rondagostino edited a comment on pull request #10550:
URL: https://github.com/apache/kafka/pull/10550#issuecomment-827040926
> we need to start forwarding the ACL operations to the controller
We forward the Create/Remove operations to the controller, but this patch
actually short-cir
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620531430
##
File path:
raft/src/main/java/org/apache/kafka/raft/metadata/AbstractMetadataRecordSerde.java
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Softw
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620531772
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataSerdeTest.java
##
@@ -0,0 +1,113 @@
+/*
+ * Lice
satishd commented on a change in pull request #10271:
URL: https://github.com/apache/kafka/pull/10271#discussion_r620541346
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java
##
@@ -0,0 +1,103 @@
+/
Chris Egerton created KAFKA-12717:
-
Summary: Remove internal converter config properties
Key: KAFKA-12717
URL: https://issues.apache.org/jira/browse/KAFKA-12717
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-12717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-12717:
--
Labels: needs-kip (was: )
> Remove internal converter config properties
> ---
ableegoldman merged pull request #10519:
URL: https://github.com/apache/kafka/pull/10519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
ableegoldman commented on pull request #10519:
URL: https://github.com/apache/kafka/pull/10519#issuecomment-827060742
Merged to trunk. Thanks for the PR @ketulgupta1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-12344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-12344.
Fix Version/s: 3.0.0
Resolution: Fixed
> Support SlidingWindows in
dejan2609 commented on a change in pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#discussion_r620558374
##
File path: build.gradle
##
@@ -1491,13 +1491,14 @@ project(':streams') {
}
tasks.create(name: "copyDependantLibs", type: Copy) {
-from (c
dejan2609 commented on pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#issuecomment-827067268
@ijuma branch is rebased onto trunk (I can also squash all commits into one).
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
[
https://issues.apache.org/jira/browse/KAFKA-9861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332683#comment-17332683
]
Israel Ekpo commented on KAFKA-9861:
I am resuming work on this task in a few weeks.
dejan2609 commented on a change in pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#discussion_r620580912
##
File path: build.gradle
##
@@ -1491,13 +1491,14 @@ project(':streams') {
}
tasks.create(name: "copyDependantLibs", type: Copy) {
-from (c
dejan2609 commented on a change in pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#discussion_r620594758
##
File path: build.gradle
##
@@ -1491,13 +1491,14 @@ project(':streams') {
}
tasks.create(name: "copyDependantLibs", type: Copy) {
-from (c
jolshan commented on pull request #10598:
URL: https://github.com/apache/kafka/pull/10598#issuecomment-827098023
Looks like "topic ID" was language used in in kafka 9+ years ago. 😮 But
good to clarify now since we have a topic ID for topics now.
--
This is an automated message from the
dejan2609 commented on a change in pull request #10466:
URL: https://github.com/apache/kafka/pull/10466#discussion_r620603149
##
File path: build.gradle
##
@@ -1491,13 +1491,14 @@ project(':streams') {
}
tasks.create(name: "copyDependantLibs", type: Copy) {
-from (c
jolshan commented on a change in pull request #10590:
URL: https://github.com/apache/kafka/pull/10590#discussion_r620608169
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java
##
@@ -34,10 +34,9 @@
* @param key The key to partition on (
[
https://issues.apache.org/jira/browse/KAFKA-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332711#comment-17332711
]
A. Sophie Blee-Goldman commented on KAFKA-8147:
---
[~philbour] that would be
JoelWee commented on pull request #8923:
URL: https://github.com/apache/kafka/pull/8923#issuecomment-827122994
Hi @ableegoldman, have rebased now :). The failing tests are
RaftClusterTests which don't seem related to the changes here?
--
This is an automated message from the Apache Git S
hachikuji opened a new pull request #10599:
URL: https://github.com/apache/kafka/pull/10599
This patch adds the Admin API to abort transactions from KIP-664:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-664%3A+Provide+tooling+to+detect+and+abort+hanging+transactions.
The `WriteTxn
ableegoldman commented on a change in pull request #8923:
URL: https://github.com/apache/kafka/pull/8923#discussion_r620645865
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ResetIntegrationTest.java
##
@@ -151,6 +151,22 @@ public void
shouldNotAllow
Matthias J. Sax created KAFKA-12718:
---
Summary: SessionWindows are closed too early
Key: KAFKA-12718
URL: https://issues.apache.org/jira/browse/KAFKA-12718
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12718:
Fix Version/s: 3.0.0
> SessionWindows are closed too early
> -
[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12718:
Labels: beginner easy-fix newbie (was: )
> SessionWindows are closed too early
>
ableegoldman commented on a change in pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#discussion_r620653928
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1524,6 +1527,12 @@ public void cleanUp() {
*
hachikuji commented on a change in pull request #9441:
URL: https://github.com/apache/kafka/pull/9441#discussion_r620695517
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -905,19 +908,35 @@ class GroupCoordinator(val brokerId: Int,
*
junrao merged pull request #10592:
URL: https://github.com/apache/kafka/pull/10592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
hachikuji commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r620708379
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -1876,12 +1836,12 @@ private void appendBatch(
}
private l
junrao commented on a change in pull request #10534:
URL: https://github.com/apache/kafka/pull/10534#discussion_r620704283
##
File path: core/src/main/scala/kafka/log/LogSegment.scala
##
@@ -162,15 +162,43 @@ class LogSegment private[log] (val log: FileRecords,
// append
ableegoldman commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620716670
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache So
ableegoldman commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620720140
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs
ableegoldman commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620720140
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs
ableegoldman commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r620722055
##
File path: docs/streams/upgrade-guide.html
##
@@ -93,6 +95,12 @@ Upgrade Guide and API Changes
Streams API changes in 3.0.0
+
+
hachikuji commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r620722131
##
File path:
raft/src/test/java/org/apache/kafka/raft/internals/BatchAccumulatorTest.java
##
@@ -65,6 +66,34 @@
);
}
+@Test
+p
ableegoldman commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r620725616
##
File path: docs/streams/upgrade-guide.html
##
@@ -93,6 +95,12 @@ Upgrade Guide and API Changes
Streams API changes in 3.0.0
+
+
ableegoldman commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r620726308
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -603,7 +606,7 @@ boolean runLoop() {
ableegoldman commented on pull request #10542:
URL: https://github.com/apache/kafka/pull/10542#issuecomment-827215366
Hey @vamossagar12 , I think we're good to go on the update you proposed to
this KIP. Take a look at the other feedback I left and just ping me when the PR
is ready for revi
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r620734462
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -194,14 +196,50 @@ private void completeCurrentBatch() {
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r620734980
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -194,14 +196,50 @@ private void completeCurrentBatch() {
[
https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331590#comment-17331590
]
Ming Liu edited comment on KAFKA-12713 at 4/27/21, 12:17 AM:
-
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r620734980
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java
##
@@ -194,14 +196,50 @@ private void completeCurrentBatch() {
ncliang commented on pull request #10475:
URL: https://github.com/apache/kafka/pull/10475#issuecomment-827234589
Ping @mageshn @gharris1727 , the failed tests don't seem to be related to
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ableegoldman commented on a change in pull request #10554:
URL: https://github.com/apache/kafka/pull/10554#discussion_r620794381
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -121,6 +125,21 @@ public void setup(
ableegoldman commented on pull request #10554:
URL: https://github.com/apache/kafka/pull/10554#issuecomment-827263009
Thanks for the PR, I think this is step forward since just processing some
data at all may have caught that cache bug a while back. But I wonder if we can
take it a step fu
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs, boo
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs, boo
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs, boo
ableegoldman commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620804518
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs, boo
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs, boo
yeralin commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java
##
@@ -77,21 +87,39 @@ public void configure(Map configs, boo
[
https://issues.apache.org/jira/browse/KAFKA-12713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331590#comment-17331590
]
Ming Liu edited comment on KAFKA-12713 at 4/27/21, 3:25 AM:
bruto1 commented on a change in pull request #10590:
URL: https://github.com/apache/kafka/pull/10590#discussion_r620829421
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java
##
@@ -34,10 +34,9 @@
* @param key The key to partition on (o
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r620833566
##
File path:
raft/src/test/java/org/apache/kafka/raft/internals/BatchAccumulatorTest.java
##
@@ -65,6 +66,34 @@
);
}
+@Test
+p
dielhennr commented on a change in pull request #10480:
URL: https://github.com/apache/kafka/pull/10480#discussion_r620833566
##
File path:
raft/src/test/java/org/apache/kafka/raft/internals/BatchAccumulatorTest.java
##
@@ -65,6 +66,34 @@
);
}
+@Test
+p
vitojeng commented on pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#issuecomment-827296663
> LGTM, just some suggestions for the wording. Can we add a note to the
section in the upgrade-guide that you added for the last exception?
Sure, will do. Thank for your
ableegoldman commented on pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#issuecomment-827302955
>It is a bit strange for me if use StreamsNotStartedException to replace
IllegalStateException in the validateIsRunningOrRebalancing()
Isn't that what we're doing wit
vitojeng commented on pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#issuecomment-827317919
@ableegoldman
Got it, thank you for the explanation. :)
I am fine with this change. Let me apply StreamsNotStartedException to
`validateIsRunningOrRebalancing()` in this
vitojeng edited a comment on pull request #10597:
URL: https://github.com/apache/kafka/pull/10597#issuecomment-827317919
@ableegoldman
Got it, thank you for the explanation. :)
I am fine with this change. Let me apply `StreamsNotStartedException` to
`validateIsRunningOrRebalancing()`
1 - 100 of 101 matches
Mail list logo