[GitHub] [kafka] showuon commented on pull request #11681: KAFKA-8785: fix request timeout by waiting for brokers up at the begining

2022-02-07 Thread GitBox
showuon commented on pull request #11681: URL: https://github.com/apache/kafka/pull/11681#issuecomment-1032313755 @dajac , [KAFKA-13653](https://issues.apache.org/jira/browse/KAFKA-13653) is created for the improvement to proactively discover alive brokers from bootstrap server lists when

[jira] [Updated] (KAFKA-13653) Proactively discover alive brokers from bootstrap server lists when all nodes are down

2022-02-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13653: -- Description: Currently, client metadata update has 2 situations: # partition leader change # metadat

[jira] [Created] (KAFKA-13653) Proactively discover alive brokers from bootstrap server lists when all nodes are down

2022-02-07 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13653: - Summary: Proactively discover alive brokers from bootstrap server lists when all nodes are down Key: KAFKA-13653 URL: https://issues.apache.org/jira/browse/KAFKA-13653 Proj

[GitHub] [kafka] dengziming commented on a change in pull request #11667: MINOR; Enable Kraft in ApiVersionTest

2022-02-07 Thread GitBox
dengziming commented on a change in pull request #11667: URL: https://github.com/apache/kafka/pull/11667#discussion_r801337197 ## File path: core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala ## @@ -17,41 +17,35 @@ package kafka.server -import kafka.test.{C

[GitHub] [kafka] showuon commented on a change in pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-02-07 Thread GitBox
showuon commented on a change in pull request #11722: URL: https://github.com/apache/kafka/pull/11722#discussion_r801293429 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -578,41 +594,46 @@ private boolean shouldSt

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: Use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-07 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r801255679 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value, B

[GitHub] [kafka] showuon commented on a change in pull request #11688: KAFKA-13435; Static membership protocol should let the leader skip assignment (KIP-814)

2022-02-07 Thread GitBox
showuon commented on a change in pull request #11688: URL: https://github.com/apache/kafka/pull/11688#discussion_r801269210 ## File path: core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala ## @@ -1791,4 +1793,33 @@ class PlaintextConsumerTest extends BaseCons

[GitHub] [kafka] twmb commented on a change in pull request #11721: KAFKA-13629: Use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-07 Thread GitBox
twmb commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r801276342 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value, ByteBu

[GitHub] [kafka] guozhangwang commented on pull request #11705: KAFKA-9847: add config to set default store type

2022-02-07 Thread GitBox
guozhangwang commented on pull request #11705: URL: https://github.com/apache/kafka/pull/11705#issuecomment-1032215108 Thanks @showuon , making a pass soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] jasonk000 commented on a change in pull request #11722: KAFKA-13630: reduce amount of time that producer network thread holds batch queue lock

2022-02-07 Thread GitBox
jasonk000 commented on a change in pull request #11722: URL: https://github.com/apache/kafka/pull/11722#discussion_r801259547 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -578,41 +594,46 @@ private boolean should

[GitHub] [kafka] jasonk000 commented on a change in pull request #11721: KAFKA-13629: Use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-07 Thread GitBox
jasonk000 commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r801255679 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value, B

[jira] [Updated] (KAFKA-13639) NotEnoughReplicasException for __consumer_offsets topic due to out of order offset

2022-02-07 Thread Wenqing Luo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenqing Luo updated KAFKA-13639: Attachment: image.png > NotEnoughReplicasException for __consumer_offsets topic due to out of orde

[jira] [Updated] (KAFKA-13639) NotEnoughReplicasException for __consumer_offsets topic due to out of order offset

2022-02-07 Thread Wenqing Luo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenqing Luo updated KAFKA-13639: Attachment: (was: image.png) > NotEnoughReplicasException for __consumer_offsets topic due to

[GitHub] [kafka] showuon commented on pull request #10367: KAFKA-12495: allow consecutive revoke in incremental cooperative assignor in connector

2022-02-07 Thread GitBox
showuon commented on pull request #10367: URL: https://github.com/apache/kafka/pull/10367#issuecomment-1032172509 @kkonstantine , call for review and comments. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Commented] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-02-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488571#comment-17488571 ] Luke Chen commented on KAFKA-12495: --- [~kkonstantine] , there are some users faced this

[GitHub] [kafka] showuon commented on a change in pull request #11737: MINOR: Fix 3.1 upgrade notes for idempotence bug

2022-02-07 Thread GitBox
showuon commented on a change in pull request #11737: URL: https://github.com/apache/kafka/pull/11737#discussion_r801230532 ## File path: docs/upgrade.html ## @@ -19,56 +19,6 @@

[jira] [Created] (KAFKA-13652) encrypt the passwords in kafka jaas conf file

2022-02-07 Thread Sunil (Jira)
Sunil created KAFKA-13652: - Summary: encrypt the passwords in kafka jaas conf file Key: KAFKA-13652 URL: https://issues.apache.org/jira/browse/KAFKA-13652 Project: Kafka Issue Type: Test Co

[GitHub] [kafka] mjsax closed pull request #10897: MINOR: Reduced severity for "skipping records" falling out of time windows

2022-02-07 Thread GitBox
mjsax closed pull request #10897: URL: https://github.com/apache/kafka/pull/10897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] mjsax commented on pull request #10897: MINOR: Reduced severity for "skipping records" falling out of time windows

2022-02-07 Thread GitBox
mjsax commented on pull request #10897: URL: https://github.com/apache/kafka/pull/10897#issuecomment-1032151335 Thanks for getting back. Closing this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Updated] (KAFKA-13492) IQ Parity: queries for key/value store range and scan

2022-02-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13492: Fix Version/s: 3.2.0 > IQ Parity: queries for key/value store range and scan > ---

[jira] [Updated] (KAFKA-8410) Strengthen the types of Processors, at least in the DSL, maybe in the PAPI as well

2022-02-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-8410: --- Description: KIP-478: [https://cwiki.apache.org/confluence/display/KAFKA/KIP-478+-+Strongly+

[jira] [Updated] (KAFKA-8410) Strengthen the types of Processors, at least in the DSL, maybe in the PAPI as well

2022-02-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-8410: --- Labels: kip tech-debt (was: tech-debt) > Strengthen the types of Processors, at least in the

[GitHub] [kafka] hachikuji commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
hachikuji commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801214042 ## File path: metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Resolved] (KAFKA-8410) Strengthen the types of Processors, at least in the DSL, maybe in the PAPI as well

2022-02-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-8410. Resolution: Fixed This feature (KIP–478: [https://cwiki.apache.org/confluence/display/KAFK

[jira] [Updated] (KAFKA-8410) Strengthen the types of Processors, at least in the DSL, maybe in the PAPI as well

2022-02-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-8410: --- Fix Version/s: 2.7.0 > Strengthen the types of Processors, at least in the DSL, maybe in the

[jira] [Updated] (KAFKA-13651) StandardAuthorizer should implement all the required log4j stuff

2022-02-07 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13651: - Labels: kip-500 kip-801 (was: ) > StandardAuthorizer should implement all the required log4j st

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801176180 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[jira] [Created] (KAFKA-13651) StandardAuthorizer should implement all the required log4j stuff

2022-02-07 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13651: Summary: StandardAuthorizer should implement all the required log4j stuff Key: KAFKA-13651 URL: https://issues.apache.org/jira/browse/KAFKA-13651 Project: Kafka

[jira] [Updated] (KAFKA-13646) Implement KIP-801: KRaft authorizer

2022-02-07 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13646: - Labels: kip-500 kip-801 (was: kip-500) > Implement KIP-801: KRaft authorizer >

[jira] [Updated] (KAFKA-13649) StandardAuthorizer should not finish loading until it reads up to the high water mark

2022-02-07 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13649: - Labels: kip-500 kip-801 (was: kip-500) > StandardAuthorizer should not finish loading until it

[jira] [Updated] (KAFKA-13650) Add StandardAuthorizer JMH benchmark

2022-02-07 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13650: - Labels: kip-500 kip-801 (was: kip-500) > Add StandardAuthorizer JMH benchmark > ---

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801175105 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala ## @@ -209,6 +212,33 @@ class BrokerMetadataPublisher(conf: KafkaCo

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801174494 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAcl.java ## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801174122 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3366,7 +3366,7 @@ class KafkaApis(val requestChannel: RequestChannel, }) }

[GitHub] [kafka] hachikuji commented on a change in pull request #11616: MINOR: update the description in Kraft example properties file

2022-02-07 Thread GitBox
hachikuji commented on a change in pull request #11616: URL: https://github.com/apache/kafka/pull/11616#discussion_r801162756 ## File path: config/kraft/broker.properties ## @@ -31,22 +31,24 @@ controller.quorum.voters=1@localhost:9093 # Socket Se

[jira] [Created] (KAFKA-13650) Add StandardAuthorizer JMH benchmark

2022-02-07 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13650: Summary: Add StandardAuthorizer JMH benchmark Key: KAFKA-13650 URL: https://issues.apache.org/jira/browse/KAFKA-13650 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801172349 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java ## @@ -0,0 +1,430 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801170612 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[jira] [Updated] (KAFKA-13649) StandardAuthorizer should not finish loading until it reads up to the high water mark

2022-02-07 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-13649: - Labels: kip-500 (was: ) > StandardAuthorizer should not finish loading until it reads up to the

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801167657 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801167657 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801167657 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801167657 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[jira] [Created] (KAFKA-13649) StandardAuthorizer should not finish loading until it reads up to the high water mark

2022-02-07 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13649: Summary: StandardAuthorizer should not finish loading until it reads up to the high water mark Key: KAFKA-13649 URL: https://issues.apache.org/jira/browse/KAFKA-13649

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801166256 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizer.java ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Sof

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801164871 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801162104 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801161757 ## File path: metadata/src/main/java/org/apache/kafka/metadata/authorizer/ClusterMetadataAuthorizer.java ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801160455 ## File path: metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801160275 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -2106,32 +2106,65 @@ object TestUtils extends Logging { s"There still are

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801159039 ## File path: core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala ## @@ -254,11 +254,23 @@ abstract class KafkaServerTestHarness exte

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801159039 ## File path: core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala ## @@ -254,11 +254,23 @@ abstract class KafkaServerTestHarness exte

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801159039 ## File path: core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala ## @@ -254,11 +254,23 @@ abstract class KafkaServerTestHarness exte

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801158397 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -321,7 +340,11 @@ class AuthorizerIntegrationTest extends B

[GitHub] [kafka] twmb commented on a change in pull request #11721: KAFKA-13629: Use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-07 Thread GitBox
twmb commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r801157664 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value, ByteBu

[GitHub] [kafka] hachikuji commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
hachikuji commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801157654 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -173,8 +174,12 @@ class ControllerServer( setMetrics(new QuorumCon

[GitHub] [kafka] twmb commented on a change in pull request #11721: KAFKA-13629: Use faster algorithm for ByteUtils sizeOfXxx algorithm

2022-02-07 Thread GitBox
twmb commented on a change in pull request #11721: URL: https://github.com/apache/kafka/pull/11721#discussion_r801157664 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java ## @@ -386,18 +386,39 @@ public static void writeDouble(double value, ByteBu

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801155285 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -147,7 +150,12 @@ class AuthorizerIntegrationTest extends B

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801155285 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -147,7 +150,12 @@ class AuthorizerIntegrationTest extends B

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801154386 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala ## @@ -209,6 +212,33 @@ class BrokerMetadataPublisher(conf: KafkaCo

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801154386 ## File path: core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala ## @@ -209,6 +212,33 @@ class BrokerMetadataPublisher(conf: KafkaCo

[GitHub] [kafka] hachikuji commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
hachikuji commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801154082 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3366,7 +3366,7 @@ class KafkaApis(val requestChannel: RequestChannel, }) }

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801150649 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -173,8 +174,12 @@ class ControllerServer( setMetrics(new QuorumContr

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801150649 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -173,8 +174,12 @@ class ControllerServer( setMetrics(new QuorumContr

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801150649 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -173,8 +174,12 @@ class ControllerServer( setMetrics(new QuorumContr

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801150649 ## File path: core/src/main/scala/kafka/server/ControllerServer.scala ## @@ -173,8 +174,12 @@ class ControllerServer( setMetrics(new QuorumContr

[GitHub] [kafka] cmccabe commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
cmccabe commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r801149465 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -689,7 +689,7 @@ class ControllerApis(val requestChannel: RequestChannel, def

[GitHub] [kafka] ijuma merged pull request #11306: MINOR: Update library dependencies (Q1 2022)

2022-02-07 Thread GitBox
ijuma merged pull request #11306: URL: https://github.com/apache/kafka/pull/11306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Assigned] (KAFKA-12879) Compatibility break in Admin.listOffsets()

2022-02-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-12879: - Assignee: Philip Nee (was: Kirk True) > Compatibility break in Admin.listOffsets() > -

[GitHub] [kafka] hachikuji commented on a change in pull request #11649: KAFKA-13646: Implement KIP-801: KRaft authorizer

2022-02-07 Thread GitBox
hachikuji commented on a change in pull request #11649: URL: https://github.com/apache/kafka/pull/11649#discussion_r800941876 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -689,7 +689,7 @@ class ControllerApis(val requestChannel: RequestChannel, d

[jira] [Created] (KAFKA-13648) KRaft ClusterInstance does not allow for deferred start

2022-02-07 Thread David Arthur (Jira)
David Arthur created KAFKA-13648: Summary: KRaft ClusterInstance does not allow for deferred start Key: KAFKA-13648 URL: https://issues.apache.org/jira/browse/KAFKA-13648 Project: Kafka Issue

[jira] [Commented] (KAFKA-13647) RocksDb metrics 'number-open-files' is not correct

2022-02-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488400#comment-17488400 ] Bruno Cadonna commented on KAFKA-13647: --- [~guozhang] Nice catch! > RocksDb metric

[jira] [Commented] (KAFKA-13647) RocksDb metrics 'number-open-files' is not correct

2022-02-07 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488332#comment-17488332 ] Guozhang Wang commented on KAFKA-13647: --- TLDR: I think the `NO_FILE_OPENS` statist

[GitHub] [kafka] hachikuji commented on a change in pull request #11667: MINOR; Enable Kraft in ApiVersionTest

2022-02-07 Thread GitBox
hachikuji commented on a change in pull request #11667: URL: https://github.com/apache/kafka/pull/11667#discussion_r800933651 ## File path: core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala ## @@ -17,41 +17,35 @@ package kafka.server -import kafka.test.{Cl

[GitHub] [kafka] hachikuji opened a new pull request #11737: MINOR: Fix 3.1 upgrade notes for idempotence bug

2022-02-07 Thread GitBox
hachikuji opened a new pull request #11737: URL: https://github.com/apache/kafka/pull/11737 I accidentally pulled in the 3.2 notes into the 3.1 branch after cherry-picking https://github.com/apache/kafka/pull/11691. ### Committer Checklist (excluded from commit message) - [ ] Ver

[GitHub] [kafka] guozhangwang commented on pull request #10525: KAFKA-7572: Producer should not send requests with negative partition id

2022-02-07 Thread GitBox
guozhangwang commented on pull request #10525: URL: https://github.com/apache/kafka/pull/10525#issuecomment-1031749531 Merged to trunk, thanks @predatorray for the patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] guozhangwang merged pull request #10525: KAFKA-7572: Producer should not send requests with negative partition id

2022-02-07 Thread GitBox
guozhangwang merged pull request #10525: URL: https://github.com/apache/kafka/pull/10525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] mimaison commented on a change in pull request #11672: KAFKA-13577: Replace easymock with mockito in kafka:core - part 1

2022-02-07 Thread GitBox
mimaison commented on a change in pull request #11672: URL: https://github.com/apache/kafka/pull/11672#discussion_r800884869 ## File path: core/src/test/scala/kafka/common/InterBrokerSendThreadTest.scala ## @@ -134,36 +139,45 @@ class InterBrokerSendThreadTest { val clie

[GitHub] [kafka] tombentley commented on a change in pull request #11672: KAFKA-13577: Replace easymock with mockito in kafka:core - part 1

2022-02-07 Thread GitBox
tombentley commented on a change in pull request #11672: URL: https://github.com/apache/kafka/pull/11672#discussion_r800800519 ## File path: core/src/test/scala/kafka/common/InterBrokerSendThreadTest.scala ## @@ -134,36 +139,45 @@ class InterBrokerSendThreadTest { val cl

[GitHub] [kafka] predatorray commented on a change in pull request #10525: KAFKA-7572: Producer should not send requests with negative partition id

2022-02-07 Thread GitBox
predatorray commented on a change in pull request #10525: URL: https://github.com/apache/kafka/pull/10525#discussion_r800756743 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -1305,10 +1305,16 @@ private ClusterResourceListeners

[jira] [Commented] (KAFKA-13647) RocksDb metrics 'number-open-files' is not correct

2022-02-07 Thread Sylvain Le Gouellec (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488169#comment-17488169 ] Sylvain Le Gouellec commented on KAFKA-13647: - Hi [~cadonna] -, First thanks

[jira] [Updated] (KAFKA-13647) RocksDb metrics 'number-open-files' is not correct

2022-02-07 Thread Sylvain Le Gouellec (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Le Gouellec updated KAFKA-13647: Attachment: image-2022-02-07-16-06-25-304.png > RocksDb metrics 'number-open-files

[jira] [Updated] (KAFKA-13647) RocksDb metrics 'number-open-files' is not correct

2022-02-07 Thread Sylvain Le Gouellec (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Le Gouellec updated KAFKA-13647: Attachment: image-2022-02-07-16-06-53-164.png > RocksDb metrics 'number-open-files

[jira] [Updated] (KAFKA-13647) RocksDb metrics 'number-open-files' is not correct

2022-02-07 Thread Sylvain Le Gouellec (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvain Le Gouellec updated KAFKA-13647: Attachment: image-2022-02-07-16-06-39-821.png > RocksDb metrics 'number-open-files

[GitHub] [kafka] ijuma merged pull request #11736: MINOR: Use CRC32 from standard library and remove custom implementation

2022-02-07 Thread GitBox
ijuma merged pull request #11736: URL: https://github.com/apache/kafka/pull/11736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dengziming commented on a change in pull request #11667: MINOR; Enable Kraft in ApiVersionTest

2022-02-07 Thread GitBox
dengziming commented on a change in pull request #11667: URL: https://github.com/apache/kafka/pull/11667#discussion_r800700262 ## File path: core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala ## @@ -17,41 +17,35 @@ package kafka.server -import kafka.test.{C

[GitHub] [kafka] hgeraldino closed pull request #11515: KIP-795 Make AbstractCoordinator part of the public API

2022-02-07 Thread GitBox
hgeraldino closed pull request #11515: URL: https://github.com/apache/kafka/pull/11515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubs

[GitHub] [kafka] dengziming commented on a change in pull request #11209: KAFKA-12465: Logic about inconsistent cluster id

2022-02-07 Thread GitBox
dengziming commented on a change in pull request #11209: URL: https://github.com/apache/kafka/pull/11209#discussion_r800655163 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientSnapshotTest.java ## @@ -1535,6 +1535,46 @@ public void testFetchSnapshotReques

[GitHub] [kafka] dengziming commented on a change in pull request #11209: KAFKA-12465: Logic about inconsistent cluster id

2022-02-07 Thread GitBox
dengziming commented on a change in pull request #11209: URL: https://github.com/apache/kafka/pull/11209#discussion_r800646883 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftUtil.java ## @@ -159,4 +161,18 @@ static boolean hasValidTopicPartition(DescribeQuorumReque

[jira] [Updated] (KAFKA-13599) Upgrade RocksDB to 6.27.3

2022-02-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13599: -- Labels: (was: streams) > Upgrade RocksDB to 6.27.3 > - > >

[jira] [Commented] (KAFKA-13647) RocksDb metrics 'number-open-files' is not correct

2022-02-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488076#comment-17488076 ] Bruno Cadonna commented on KAFKA-13647: --- [~LGouellec] Thank you for the report! F

[jira] [Commented] (KAFKA-13638) Slow KTable update when forwarding multiple values from transformer

2022-02-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488071#comment-17488071 ] Bruno Cadonna commented on KAFKA-13638: --- [~Lejon] I put the following code around

[jira] [Created] (KAFKA-13647) RocksDb metrics 'number-open-files' is not correct

2022-02-07 Thread Sylvain Le Gouellec (Jira)
Sylvain Le Gouellec created KAFKA-13647: --- Summary: RocksDb metrics 'number-open-files' is not correct Key: KAFKA-13647 URL: https://issues.apache.org/jira/browse/KAFKA-13647 Project: Kafka

[GitHub] [kafka] Gerrrr commented on pull request #11447: KAFKA-13024

2022-02-07 Thread GitBox
Ge commented on pull request #11447: URL: https://github.com/apache/kafka/pull/11447#issuecomment-1031269712 > My rationale is that, we do some optimizations at the end of the building phase which may move some repartition up in the topology etc, which would effectively change the topo

[jira] [Updated] (KAFKA-13599) Upgrade RocksDB to 6.27.3

2022-02-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13599: -- Fix Version/s: 3.2.0 > Upgrade RocksDB to 6.27.3 > - > >

[jira] [Updated] (KAFKA-13599) Upgrade RocksDB to 6.27.3

2022-02-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13599: -- Labels: streams (was: ) > Upgrade RocksDB to 6.27.3 > - > >

[jira] [Commented] (KAFKA-13641) Kafka Streams Scala: Add `Option` to `ValueJoiner` parameters

2022-02-07 Thread Mohammad Yousuf Minhaj Zia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487976#comment-17487976 ] Mohammad Yousuf Minhaj Zia commented on KAFKA-13641: To be clear I d

[GitHub] [kafka] showuon commented on a change in pull request #11584: MINOR: improve logging

2022-02-07 Thread GitBox
showuon commented on a change in pull request #11584: URL: https://github.com/apache/kafka/pull/11584#discussion_r800428095 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1516,4 +1527,20 @@ RebalanceProtocol getP

[GitHub] [kafka] ableegoldman commented on a change in pull request #11584: MINOR: improve logging

2022-02-07 Thread GitBox
ableegoldman commented on a change in pull request #11584: URL: https://github.com/apache/kafka/pull/11584#discussion_r800368829 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1516,4 +1527,20 @@ RebalanceProtocol

[jira] [Commented] (KAFKA-9837) New RPC for notifying controller of failed replica

2022-02-07 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17487938#comment-17487938 ] dengziming commented on KAFKA-9837: --- Thank you [~cmccabe] , your concern make sense to

  1   2   >