pprovenzano commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140947822
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -128,6 +152,108 @@ object StorageTool extends Logging {
.getOrElse(defaultValue)
}
+ def ge
pprovenzano commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140945073
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -214,6 +340,24 @@ object StorageTool extends Logging {
}
}
+ def buildBootstrapMetadata(metad
pprovenzano commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r114092
##
core/src/test/scala/integration/kafka/server/ScramServerStartupTest.scala:
##
@@ -1,65 +0,0 @@
-/**
Review Comment:
I moved it to SaslScramSslEndToEndAuthori
pprovenzano commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140938158
##
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramMechanism.java:
##
@@ -23,13 +23,15 @@
public enum ScramMechanism {
-SCRAM_S
[
https://issues.apache.org/jira/browse/KAFKA-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya reassigned KAFKA-14814:
--
Assignee: Yash Mayya
> Skip restart of connectors when redundant resume request is made
> ---
satishd commented on code in PR #13362:
URL: https://github.com/apache/kafka/pull/13362#discussion_r1140880048
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -107,4 +110,13 @@ private RemoteLogMetadat
satishd commented on code in PR #13362:
URL: https://github.com/apache/kafka/pull/13362#discussion_r1140880048
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -107,4 +110,13 @@ private RemoteLogMetadat
cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140835694
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -128,6 +152,108 @@ object StorageTool extends Logging {
.getOrElse(defaultValue)
}
+ def getUse
cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140833054
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -214,6 +340,24 @@ object StorageTool extends Logging {
}
}
+ def buildBootstrapMetadata(metadataV
cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140832364
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -53,12 +61,23 @@ object StorageTool extends Logging {
throw new TerseFailure(s"Must specify a v
cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140832034
##
core/src/test/scala/integration/kafka/server/ScramServerStartupTest.scala:
##
@@ -1,65 +0,0 @@
-/**
Review Comment:
Why did you delete this test? Can you add an
cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140831327
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java:
##
@@ -73,7 +73,7 @@ public static Optional
recordToMetadataVersion(ApiMessage re
cmccabe commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1140829757
##
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramMechanism.java:
##
@@ -23,13 +23,15 @@
public enum ScramMechanism {
-SCRAM_SHA_2
imcdo commented on code in PR #13415:
URL: https://github.com/apache/kafka/pull/13415#discussion_r1140725883
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -97,7 +98,11 @@ public HttpResponse httpRequest(String url, String
method,
imcdo commented on code in PR #13415:
URL: https://github.com/apache/kafka/pull/13415#discussion_r1140725883
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -97,7 +98,11 @@ public HttpResponse httpRequest(String url, String
method,
jolshan commented on PR #13391:
URL: https://github.com/apache/kafka/pull/13391#issuecomment-1474405568
TODO:
* config for the feature
* request handling optimizations
* confirm compatibility --> we may need Ibp
--
This is an automated message from the Apache Git Service.
To respo
philipnee commented on PR #13380:
URL: https://github.com/apache/kafka/pull/13380#issuecomment-1474404071
Hey @guozhangwang - I think i've addressed most of your questions except
merging the request classes. It is a bit difficult right now as we sometimes
need to access the fields before `
guozhangwang commented on PR #13380:
URL: https://github.com/apache/kafka/pull/13380#issuecomment-1474361224
@philipnee let me know when it's ready for another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
guozhangwang commented on code in PR #13380:
URL: https://github.com/apache/kafka/pull/13380#discussion_r1140667236
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -235,4 +373,105 @@ public void ack(final long currentTimeMs)
jolshan commented on code in PR #13415:
URL: https://github.com/apache/kafka/pull/13415#discussion_r1140662378
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -97,7 +98,11 @@ public HttpResponse httpRequest(String url, String
metho
vcrfxia commented on code in PR #13409:
URL: https://github.com/apache/kafka/pull/13409#discussion_r1140636734
##
streams/src/main/java/org/apache/kafka/streams/state/VersionedKeyValueStore.java:
##
@@ -59,12 +59,15 @@
* Delete the value associated with this key from the s
C0urante commented on PR #13415:
URL: https://github.com/apache/kafka/pull/13415#issuecomment-1474253239
cc @imcdo @gharris1727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
C0urante opened a new pull request, #13415:
URL: https://github.com/apache/kafka/pull/13415
[Jira](https://issues.apache.org/jira/browse/KAFKA-14816)
This fixes a regression introduced in
https://github.com/apache/kafka/pull/12828, which caused workers to start
unconditionally loadin
philipnee commented on code in PR #13380:
URL: https://github.com/apache/kafka/pull/13380#discussion_r1140532145
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -149,6 +185,29 @@ Queue stagedCommits() {
return this.s
philipnee commented on code in PR #13380:
URL: https://github.com/apache/kafka/pull/13380#discussion_r1140528394
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -235,4 +373,105 @@ public void ack(final long currentTimeMs) {
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14816:
--
Summary: Connect loading SSL configs when contacting non-HTTPS URLs (was:
Connect Http Client
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14816:
--
Affects Version/s: 3.4.0
> Connect Http Client loading SSL configs when contacting non-HTTPS U
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-14816:
-
Assignee: Chris Egerton
> Connect Http Client loading SSL configs when contacting non-H
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14816:
--
Fix Version/s: 3.5.0
3.4.1
> Connect Http Client loading SSL configs when c
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14816:
--
Priority: Blocker (was: Trivial)
> Connect Http Client loading SSL configs when contacting no
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14816:
--
Description:
Due to changes made here: [https://github.com/apache/kafka/pull/12828]
Connect no
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14816:
--
Description:
Due to changes made here: [https://github.com/apache/kafka/pull/12828]
Connect no
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701915#comment-17701915
]
Chris Egerton commented on KAFKA-14816:
---
Thanks [~imcdo] for filing this. I believ
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14816:
--
Description:
Due to changes made here: [https://github.com/apache/kafka/pull/12828]
Connect no
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14816:
--
Summary: Connect Http Client loading SSL configs when contacting non-HTTPS
URLs (was: Connect
garyparrot commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1474093045
Sure thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
philipnee commented on code in PR #13380:
URL: https://github.com/apache/kafka/pull/13380#discussion_r1140442417
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -149,6 +185,29 @@ Queue stagedCommits() {
return this.s
philipnee commented on code in PR #13380:
URL: https://github.com/apache/kafka/pull/13380#discussion_r1140429707
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -116,12 +114,21 @@ private void maybeAutoCommit(final long curre
[
https://issues.apache.org/jira/browse/KAFKA-14585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Muralidhar Basani reassigned KAFKA-14585:
-
Assignee: Muralidhar Basani
> Move StorageTool to tools
> -
[
https://issues.apache.org/jira/browse/KAFKA-14585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701874#comment-17701874
]
Muralidhar Basani commented on KAFKA-14585:
---
Great, thanks.
> Move StorageToo
[
https://issues.apache.org/jira/browse/KAFKA-14585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701871#comment-17701871
]
Mickael Maison commented on KAFKA-14585:
Sure
> Move StorageTool to tools
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701869#comment-17701869
]
Muralidhar Basani commented on KAFKA-14585:
---
Hi [~mimaison] , can I pick this
mimaison commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1140384184
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConfig.java:
##
@@ -162,6 +174,15 @@ Duration syncTopicConfigsInterval() {
}
chia7712 commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1474011607
linked to stale PR (#4995)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
chia7712 commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1473999823
@garyparrot could you rebase PR to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
tinaselenge commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1140316021
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConfig.java:
##
@@ -162,6 +174,15 @@ Duration syncTopicConfigsInterval() {
}
tinaselenge commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1140303773
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java:
##
@@ -40,11 +44,13 @@ public class DefaultConfigPropertyFilter im
tinaselenge commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1140303773
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java:
##
@@ -40,11 +44,13 @@ public class DefaultConfigPropertyFilter im
[
https://issues.apache.org/jira/browse/KAFKA-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-13900.
-
Resolution: Fixed
> Support Java 9 direct ByteBuffer Checksum methods
>
[
https://issues.apache.org/jira/browse/KAFKA-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701788#comment-17701788
]
Ismael Juma commented on KAFKA-13900:
-
Thanks for the heads up, fixed.
> Support Ja
[
https://issues.apache.org/jira/browse/KAFKA-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-13900:
Fix Version/s: 3.4.0
> Support Java 9 direct ByteBuffer Checksum methods
> ---
mumrah merged PR #13413:
URL: https://github.com/apache/kafka/pull/13413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah closed pull request #13414: MINOR Fix combined-mode config test
URL: https://github.com/apache/kafka/pull/13414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
mumrah commented on PR #13414:
URL: https://github.com/apache/kafka/pull/13414#issuecomment-1473900489
Closing in favor of #13413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
mumrah opened a new pull request, #13414:
URL: https://github.com/apache/kafka/pull/13414
Fixes a config test for KRaft combined mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
tinaselenge commented on code in PR #13373:
URL: https://github.com/apache/kafka/pull/13373#discussion_r1140270243
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##
@@ -539,11 +596,20 @@ Map describeTopicConfigs(Set
topics)
}
Christian created KAFKA-14818:
-
Summary: Support non default file systems
Key: KAFKA-14818
URL: https://issues.apache.org/jira/browse/KAFKA-14818
Project: Kafka
Issue Type: Improvement
ZhenChun Pan created KAFKA-14817:
Summary: LogCleaner mark some partitions of __consumer_offsets as
uncleanable
Key: KAFKA-14817
URL: https://issues.apache.org/jira/browse/KAFKA-14817
Project: Kafka
lucasbru commented on PR #13318:
URL: https://github.com/apache/kafka/pull/13318#issuecomment-1473643588
Yeah, these seem to be unrelated. I restarted the job:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5562/consoleText
We have two failures:
test_id:
chia7712 opened a new pull request, #13413:
URL: https://github.com/apache/kafka/pull/13413
related to #13390
```
Gradle Test Run :core:test > Gradle Test Executor 25 > KafkaTest >
testIsKRaftCombinedMode() FAILED
java.lang.IllegalArgumentException: requirement failed:
cont
[
https://issues.apache.org/jira/browse/KAFKA-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701625#comment-17701625
]
Keith Wall commented on KAFKA-13900:
This Jira was landed in 3.4,
[https://github.c
garyparrot commented on PR #13398:
URL: https://github.com/apache/kafka/pull/13398#issuecomment-1473504714
@chia7712 Thanks for your opinion. Indeed this issue should be treated as a
bug (The contribution guide has addressed this, sorry I am not familiar with
the rules here).
I find
[
https://issues.apache.org/jira/browse/KAFKA-14483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701581#comment-17701581
]
Muralidhar Basani commented on KAFKA-14483:
---
Hi [~ijuma], can I pick this up
hudeqi closed pull request #13399: MINOR: Fix low bound in AdminClientConfig
and DistributedConfig
URL: https://github.com/apache/kafka/pull/13399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on code in PR #13410:
URL: https://github.com/apache/kafka/pull/13410#discussion_r1139870081
##
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##
@@ -200,6 +190,37 @@ static Properties readProps(List producerProps,
String producerConfig,
hudeqi commented on PR #13404:
URL: https://github.com/apache/kafka/pull/13404#issuecomment-1473316465
Do you have any suggestions here? @showuon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hudeqi commented on code in PR #13403:
URL: https://github.com/apache/kafka/pull/13403#discussion_r1139890939
##
core/src/main/scala/kafka/admin/TopicCommand.scala:
##
Review Comment:
Ok, I probably have deleted some useless code, please help to review again,
thank you!
chia7712 opened a new pull request, #13411:
URL: https://github.com/apache/kafka/pull/13411
#13172 rewrite `DelegationTokenCommand` by java and the package was changed
from `kafka.admin` to `org.apache.kafka.tools`.
### Committer Checklist (excluded from commit message)
- [ ] Verif
68 matches
Mail list logo
