[GitHub] [kafka] mjsax commented on a diff in pull request #13449: KAFKA-14491: [22/N] Add test for manual upgrade to versioned store

mjsax commented on code in PR #13449: URL: https://github.com/apache/kafka/pull/13449#discussion_r1150050550 ## streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java: ## @@ -361,6 +365,91 @@ public void shouldCreateGlobalTable()

[GitHub] [kafka] mjsax commented on a diff in pull request #13444: KAFKA-14491: [21/N] Docs updates for versioned state stores

mjsax commented on code in PR #13444: URL: https://github.com/apache/kafka/pull/13444#discussion_r1150042983 ## docs/streams/developer-guide/processor-api.html: ## @@ -261,11 +262,13 @@ space. RocksDB settings can

[GitHub] [kafka] mjsax commented on a diff in pull request #13442: KAFKA-14491: [20/N] Add public-facing methods for versioned stores

mjsax commented on code in PR #13442: URL: https://github.com/apache/kafka/pull/13442#discussion_r1150036447 ## streams/src/main/java/org/apache/kafka/streams/state/Stores.java: ## @@ -110,6 +116,73 @@ public static KeyValueBytesStoreSupplier

[GitHub] [kafka] mjsax commented on a diff in pull request #13431: KAFKA-14491: [19/N] Combine versioned store RocksDB instances into one

mjsax commented on code in PR #13431: URL: https://github.com/apache/kafka/pull/13431#discussion_r1150018327 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegment.java: ## @@ -176,7 +184,7 @@ public synchronized KeyValueIterator range(final

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1150022881 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java: ## @@ -61,73 +83,250 @@ public void setup() { } @Test

[GitHub] [kafka] jeqo commented on pull request #13445: [KAFKA-14843] fix(connect): include base connector config to return

jeqo commented on PR #13445: URL: https://github.com/apache/kafka/pull/13445#issuecomment-1486212417 Thank you all for your feedback. It's looking good! Let's see what CI says :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] C0urante commented on pull request #11046: KAFKA-12980: Return empty record batch from Consumer::poll when position advances due to aborted transactions

C0urante commented on PR #11046: URL: https://github.com/apache/kafka/pull/11046#issuecomment-1486198234 @nbali this PR was merged over two years ago and I've lost almost all of the context around it. If you are seeing problems because of the changes made here, please file a Jira ticket

[GitHub] [kafka] mjsax commented on a diff in pull request #13364: KAFKA-14491: [16/N] Add recovery logic for store inconsistency due to failed write

mjsax commented on code in PR #13364: URL: https://github.com/apache/kafka/pull/13364#discussion_r1149989283 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java: ## @@ -341,8 +345,10 @@ public void

[GitHub] [kafka] nbali commented on pull request #11046: KAFKA-12980: Return empty record batch from Consumer::poll when position advances due to aborted transactions

nbali commented on PR #11046: URL: https://github.com/apache/kafka/pull/11046#issuecomment-1486190276 @C0urante FYI this has a functionality loss. If you `KafkaConsumer.poll(Duration)` you are unable to tell anymore if it returns empty if it was a timeout - so most likely the topic is

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1150002299 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -22,19 +22,37 @@ import java.nio.file.{Files, Paths} import kafka.server.{BrokerMetadataCheckpoint,

[GitHub] [kafka] chia7712 commented on pull request #13326: KAFKA-14774 the removed listeners should not be reconfigurable

chia7712 commented on PR #13326: URL: https://github.com/apache/kafka/pull/13326#issuecomment-1486165359 > I think we should back-port this to 3.4 branch. WDYT? Will copy that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hudeqi commented on a diff in pull request #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector

hudeqi commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1149996731 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnectorTest.java: ## @@ -123,13 +127,21 @@ public void testFindConsumerGroups() throws

[GitHub] [kafka] hudeqi commented on a diff in pull request #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector

hudeqi commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1149973082 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnectorTest.java: ## @@ -123,13 +127,21 @@ public void testFindConsumerGroups() throws

[GitHub] [kafka] hudeqi commented on a diff in pull request #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector

hudeqi commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1149959295 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -178,6 +178,7 @@ private List sourceRecordsForGroup(String group)

[GitHub] [kafka] hudeqi commented on a diff in pull request #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector

hudeqi commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1149959006 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -178,6 +178,7 @@ private List sourceRecordsForGroup(String group)

[GitHub] [kafka] showuon commented on pull request #13326: KAFKA-14774 the removed listeners should not be reconfigurable

showuon commented on PR #13326: URL: https://github.com/apache/kafka/pull/13326#issuecomment-1486105014 Nice find @chia7712 , I think we should back-port this to 3.4 branch. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hudeqi commented on a diff in pull request #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector

hudeqi commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1149948611 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -150,10 +156,30 @@ private void loadInitialConsumerGroups()

[GitHub] [kafka] hudeqi commented on a diff in pull request #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector

hudeqi commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1149948271 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -150,10 +156,30 @@ private void loadInitialConsumerGroups()

[GitHub] [kafka] hudeqi commented on a diff in pull request #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector

hudeqi commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1149947295 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -150,10 +156,30 @@ private void loadInitialConsumerGroups()

[GitHub] [kafka] hudeqi commented on a diff in pull request #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector

hudeqi commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1149945098 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -150,10 +156,30 @@ private void loadInitialConsumerGroups()

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1149903116 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] jolshan opened a new pull request, #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jolshan opened a new pull request, #13463: URL: https://github.com/apache/kafka/pull/13463 Refactors the interbroker send thread to be a concrete class that can handle multiple InterBrokerRequestManagers. This is an intermediate step before completing

[jira] [Updated] (KAFKA-14843) Connector plugins config endpoint does not include Common configs

[ https://issues.apache.org/jira/browse/KAFKA-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14843: -- Affects Version/s: 3.3.2 3.3.1 3.2.3

[GitHub] [kafka] C0urante commented on a diff in pull request #13445: [KAFKA-14843] fix(connect): include base connector config to return

C0urante commented on code in PR #13445: URL: https://github.com/apache/kafka/pull/13445#discussion_r1149888198 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java: ## @@ -943,35 +943,45 @@ public void

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

gharris1727 commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1149859768 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void

[jira] [Commented] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705734#comment-17705734 ] Guozhang Wang commented on KAFKA-14639: --- As for the fix.. it's quite tough, since the ultimate and

[jira] [Updated] (KAFKA-14843) Connector plugins config endpoint does not include Common configs

[ https://issues.apache.org/jira/browse/KAFKA-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14843: -- Description: Connector plugins GET config endpoint introduced in

[jira] [Commented] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705731#comment-17705731 ] Guozhang Wang commented on KAFKA-14639: --- I looked at both JIRA tickets and I believe the root

[GitHub] [kafka] C0urante commented on a diff in pull request #13446: KAFKA-14837:Avoid the rebalance caused by the addition and deletion of irrelevant groups for MirrorCheckPointConnector

C0urante commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1149871568 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -150,10 +156,30 @@ private void loadInitialConsumerGroups()

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1149874897 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -22,19 +22,37 @@ import java.nio.file.{Files, Paths} import kafka.server.{BrokerMetadataCheckpoint,

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1149874897 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -22,19 +22,37 @@ import java.nio.file.{Files, Paths} import kafka.server.{BrokerMetadataCheckpoint,

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1149876669 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -128,6 +152,108 @@ object StorageTool extends Logging { .getOrElse(defaultValue) } + def

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

artemlivshits commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1149873099 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1149874897 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -22,19 +22,37 @@ import java.nio.file.{Files, Paths} import kafka.server.{BrokerMetadataCheckpoint,

[GitHub] [kafka] cmccabe merged pull request #13368: KAFKA-14796 Migrate ACLs from AclAuthorizor to KRaft

cmccabe merged PR #13368: URL: https://github.com/apache/kafka/pull/13368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

C0urante commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1149857584 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -514,6 +543,41 @@ private void updateTopicConfigs(Map topicConfigs)

[GitHub] [kafka] C0urante commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

C0urante commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1149844764 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/IdentityReplicationIntegrationTest.java: ## @@ -41,12 +41,12 @@ import

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1149847782 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] cmccabe opened a new pull request, #13462: KAFKA-14857: Fix some MetadataLoader bugs

cmccabe opened a new pull request, #13462: URL: https://github.com/apache/kafka/pull/13462 The MetadataLoader is not supposed to publish metadata updates until we have loaded up to the high water mark. Previously, this logic was broken, and we published updates immediately. This PR fixes

[GitHub] [kafka] C0urante commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

C0urante commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1149844200 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/IdentityReplicationIntegrationTest.java: ## @@ -41,12 +41,12 @@ import

[jira] [Created] (KAFKA-14857) Fix some MetadataLoader bugs

Colin McCabe created KAFKA-14857: Summary: Fix some MetadataLoader bugs Key: KAFKA-14857 URL: https://issues.apache.org/jira/browse/KAFKA-14857 Project: Kafka Issue Type: Bug

[GitHub] [kafka] C0urante commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

C0urante commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1149843748 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -96,6 +99,7 @@ public class MirrorSourceConnector extends

[GitHub] [kafka] C0urante commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

C0urante commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1149842964 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/DefaultConfigPropertyFilter.java: ## @@ -30,6 +30,9 @@ public class DefaultConfigPropertyFilter

[GitHub] [kafka] C0urante commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

C0urante commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1149841456 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/ConfigPropertyFilter.java: ## @@ -25,8 +25,19 @@ @InterfaceStability.Evolving public interface

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

gharris1727 commented on code in PR #13433: URL: https://github.com/apache/kafka/pull/13433#discussion_r1149838302 ## connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java: ## @@ -289,29 +291,202 @@ public ConnectSchema schema() { @Override public

[GitHub] [kafka] C0urante commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

C0urante commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1149838213 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -540,10 +601,13 @@ Map describeTopicConfigs(Set topics)

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

artemlivshits commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1149838206 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] C0urante commented on a diff in pull request #13434: KAFKA-14785: Connect offset read REST API

C0urante commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1149828648 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaOffsetBackingStore.java: ## @@ -343,12 +336,38 @@ public Future set(final Map values, final

[jira] [Commented] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705689#comment-17705689 ] Philip Nee commented on KAFKA-14757: Hi [~sanand] - I'm not sure what's behavior of the

[jira] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

[ https://issues.apache.org/jira/browse/KAFKA-14757 ] Philip Nee deleted comment on KAFKA-14757: was (Author: JIRAUSER283568): Hey [~sanand] - I'm unfamiliar with ConsumerAwareRebalanceListener, but do you know if it revokes the partitions

[jira] [Commented] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17705687#comment-17705687 ] Philip Nee commented on KAFKA-14757: Hey [~sanand] - I'm unfamiliar with

[GitHub] [kafka] C0urante commented on a diff in pull request #13434: KAFKA-14785: Connect offset read REST API

C0urante commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1149813420 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -866,4 +867,19 @@ public List connectorPluginConfig(String pluginName) {

[jira] [Created] (KAFKA-14856) Next gen group coordinator dynamic configs should be forward compatible

Jeff Kim created KAFKA-14856: Summary: Next gen group coordinator dynamic configs should be forward compatible Key: KAFKA-14856 URL: https://issues.apache.org/jira/browse/KAFKA-14856 Project: Kafka

[GitHub] [kafka] anatasiavela commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

anatasiavela commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1485869027 @mimaison I've marked the JIRA as resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] C0urante commented on a diff in pull request #13424: KAFKA-14783 (KIP-875): New STOPPED state for connectors

C0urante commented on code in PR #13424: URL: https://github.com/apache/kafka/pull/13424#discussion_r1149778430 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1090,6 +1090,40 @@ public void putConnectorConfig(final

[GitHub] [kafka] C0urante commented on a diff in pull request #13424: KAFKA-14783 (KIP-875): New STOPPED state for connectors

C0urante commented on code in PR #13424: URL: https://github.com/apache/kafka/pull/13424#discussion_r1149776904 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -237,6 +237,17 @@ private synchronized void

[GitHub] [kafka] C0urante commented on a diff in pull request #13424: KAFKA-14783 (KIP-875): New STOPPED state for connectors

C0urante commented on code in PR #13424: URL: https://github.com/apache/kafka/pull/13424#discussion_r1149773408 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -325,6 +325,181 @@ public void

[jira] [Created] (KAFKA-14855) Harden integration testing logic for asserting that a connector is deleted

Chris Egerton created KAFKA-14855: - Summary: Harden integration testing logic for asserting that a connector is deleted Key: KAFKA-14855 URL: https://issues.apache.org/jira/browse/KAFKA-14855

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1149500829 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -25,17 +25,37 @@ import org.apache.kafka.common.utils.Utils; import

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13445: [KAFKA-14843] fix(connect): include base connector config to return

gharris1727 commented on code in PR #13445: URL: https://github.com/apache/kafka/pull/13445#discussion_r1149755190 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -856,11 +867,8 @@ public List connectorPluginConfig(String

[jira] [Assigned] (KAFKA-14746) Throwing in Connector.taskConfigs generates a lot of logs

[ https://issues.apache.org/jira/browse/KAFKA-14746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Spacrocket reassigned KAFKA-14746: -- Assignee: Spacrocket > Throwing in Connector.taskConfigs generates a lot of logs >

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149655641 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[GitHub] [kafka] jeqo commented on a diff in pull request #13445: [KAFKA-14843] fix(connect): include base connector config to return

jeqo commented on code in PR #13445: URL: https://github.com/apache/kafka/pull/13445#discussion_r1149677176 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -856,11 +867,8 @@ public List connectorPluginConfig(String pluginName) {

[GitHub] [kafka] jeqo commented on pull request #13445: [KAFKA-14843] fix(connect): include base connector config to return

jeqo commented on PR #13445: URL: https://github.com/apache/kafka/pull/13445#issuecomment-1485705474 Sure, thanks @gharris1727! let me know how it looks now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149666320 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149659044 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149659044 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149658306 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

gharris1727 commented on code in PR #13433: URL: https://github.com/apache/kafka/pull/13433#discussion_r1149656291 ## connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java: ## @@ -289,29 +291,202 @@ public ConnectSchema schema() { @Override public

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149655641 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149650468 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149648624 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13445: [KAFKA-14843] fix(connect): include base connector config to return

gharris1727 commented on code in PR #13445: URL: https://github.com/apache/kafka/pull/13445#discussion_r1149638851 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -836,10 +836,19 @@ public List connectorPluginConfig(String

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149647453 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149644261 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java: ## @@ -37,29 +39,28 @@ public class AssignmentMemberSpec {

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1149630814 ## checkstyle/suppressions.xml: ## @@ -320,6 +320,14 @@ + + +

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1149586417 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,173 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Created] (KAFKA-14854) Refactor inter broker send thread to handle all interbroker requests on one thread

Justine Olshan created KAFKA-14854: -- Summary: Refactor inter broker send thread to handle all interbroker requests on one thread Key: KAFKA-14854 URL: https://issues.apache.org/jira/browse/KAFKA-14854

[GitHub] [kafka] chia7712 opened a new pull request, #13460: KAFKA-14853 the serializer/deserialize which extends ClusterResourceL…

chia7712 opened a new pull request, #13460: URL: https://github.com/apache/kafka/pull/13460 https://issues.apache.org/jira/browse/KAFKA-14853 I noticed this issue when reviewing #13452. We use the incorrect reference of serializer/deserializer ### Committer Checklist

[jira] [Updated] (KAFKA-14853) the serializer/deserialize which extends ClusterResourceListener is not added to Metadata

[ https://issues.apache.org/jira/browse/KAFKA-14853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-14853: --- Summary: the serializer/deserialize which extends ClusterResourceListener is not added to

[jira] [Created] (KAFKA-14853) the serializer/deserialize which extends ClusterResourceListener is never called

Chia-Ping Tsai created KAFKA-14853: -- Summary: the serializer/deserialize which extends ClusterResourceListener is never called Key: KAFKA-14853 URL: https://issues.apache.org/jira/browse/KAFKA-14853

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

CalvinConfluent commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1149550057 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1159,16 +1171,20 @@ private Errors validateAlterPartitionData(

[GitHub] [kafka] guozhangwang merged pull request #13452: KAFKA-14848: KafkaConsumer incorrectly passes locally-scoped deserializers to FetchConfig

guozhangwang merged PR #13452: URL: https://github.com/apache/kafka/pull/13452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #13452: KAFKA-14848: KafkaConsumer incorrectly passes locally-scoped deserializers to FetchConfig

guozhangwang commented on PR #13452: URL: https://github.com/apache/kafka/pull/13452#issuecomment-1485490464 LGTM. Merging to trunk to unblock @rayokota and SR, please feel free to address @chia7712 's comments in a follow-up PR. -- This is an automated message from the Apache Git

[GitHub] [kafka] tinaselenge opened a new pull request, #13459: KAFKA-14592: Move FeatureCommand to tools

tinaselenge opened a new pull request, #13459: URL: https://github.com/apache/kafka/pull/13459 ``` === tests $./bin/kafka-features.sh --bootstrap-server localhost:9092 --command-config test describe Feature: metadata.version SupportedMinVersion: 3.0-IV1

[GitHub] [kafka] junrao commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

junrao commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1149498020 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1159,16 +1171,20 @@ private Errors validateAlterPartitionData(

[GitHub] [kafka] C0urante commented on a diff in pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

C0urante commented on code in PR #13433: URL: https://github.com/apache/kafka/pull/13433#discussion_r1149494051 ## connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java: ## @@ -289,29 +291,202 @@ public ConnectSchema schema() { @Override public

[GitHub] [kafka] urbandan commented on a diff in pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

urbandan commented on code in PR #13433: URL: https://github.com/apache/kafka/pull/13433#discussion_r1149488176 ## connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java: ## @@ -289,29 +291,202 @@ public ConnectSchema schema() { @Override public

[GitHub] [kafka] urbandan commented on a diff in pull request #13433: KAFKA-12694, KAFKA-3910: Add cyclic schema support, fix default struct values

urbandan commented on code in PR #13433: URL: https://github.com/apache/kafka/pull/13433#discussion_r1149465857 ## connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java: ## @@ -289,29 +291,202 @@ public ConnectSchema schema() { @Override public

[GitHub] [kafka] urbandan commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

urbandan commented on PR #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-1485386852 Thanks a lot @C0urante, will review that one! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] C0urante commented on pull request #13458: KAFKA-14838: Add flow/connector/task/role information to MM2 Kafka cl…

C0urante commented on PR #13458: URL: https://github.com/apache/kafka/pull/13458#issuecomment-1485288081 Hey @urbandan, it's looking like this week is going to be pretty busy for me so I may not be able to take a look immediately. I can try to take a look next week if this still hasn't

[GitHub] [kafka] C0urante commented on a diff in pull request #12637: KAFKA-14226: [connect:transform] Introduce support for nested structures

C0urante commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r1149375240 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java: ## @@ -0,0 +1,585 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] C0urante commented on pull request #12637: KAFKA-14226: [connect:transform] Introduce support for nested structures

C0urante commented on PR #12637: URL: https://github.com/apache/kafka/pull/12637#issuecomment-1485252002 I'm also wondering about the spec for V2 field syntax. The KIP states that "if the backticks are in a wrapping position (opening or closing a field name), then need to be escaped with

[GitHub] [kafka] C0urante commented on pull request #12637: KAFKA-14226: [connect:transform] Introduce support for nested structures

C0urante commented on PR #12637: URL: https://github.com/apache/kafka/pull/12637#issuecomment-1485251519 I'm also wondering about the spec for V2 field syntax. The KIP states that "if the backticks are in a wrapping position (opening or closing a field name), then need to be escaped with

[GitHub] [kafka] pprovenzano commented on pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on PR #13374: URL: https://github.com/apache/kafka/pull/13374#issuecomment-1485244811 > This seems to have broken `FeatureCommandUnitTest.testHandleDowngrade` because of changes to storage tool. > This seems to have broken

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1149285314 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1699,7 +1705,8 @@ public void

[jira] [Updated] (KAFKA-14652) Improve MM2 logging by adding the flow information to the context

[ https://issues.apache.org/jira/browse/KAFKA-14652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-14652: - Description: MirrorMaker2 runs multiple Connect worker instances in a single process. In

[GitHub] [kafka] urbandan commented on pull request #13458: KAFKA-14838: Add flow/connector/task/role information to MM2 Kafka cl…

urbandan commented on PR #13458: URL: https://github.com/apache/kafka/pull/13458#issuecomment-1485136651 @viktorsomogyi @C0urante @mimaison You had some changes/review in this part of the code lately, could you please review? -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] urbandan opened a new pull request, #13458: KAFKA-14838: Add flow/connector/task/role information to MM2 Kafka cl…

urbandan opened a new pull request, #13458: URL: https://github.com/apache/kafka/pull/13458 …ient.id configs *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[jira] [Assigned] (KAFKA-14852) Propagate Topic Ids to the Group Coordinator for Offset Fetch

[ https://issues.apache.org/jira/browse/KAFKA-14852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez reassigned KAFKA-14852: - Assignee: Alexandre Dupriez > Propagate Topic Ids to the Group Coordinator for

  1   2   >