[jira] [Created] (KAFKA-15821) Active topics for deleted connectors are not reset in standalone mode

2023-11-13 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15821: - Summary: Active topics for deleted connectors are not reset in standalone mode Key: KAFKA-15821 URL: https://issues.apache.org/jira/browse/KAFKA-15821 Project:

[jira] [Updated] (KAFKA-15802) Trying to access uncopied segments metadata on listOffsets

2023-11-13 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15802: --- Fix Version/s: 3.7.0 3.6.1 > Trying to access uncopied segments metadata

Re: [PR] KAFKA-15802: validate remote segment state before fetching index [kafka]

2023-11-13 Thread via GitHub
satishd commented on code in PR #14727: URL: https://github.com/apache/kafka/pull/14727#discussion_r1392031838 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -133,6 +134,10 @@ public class RemoteLogManager implements Closeable { private static final

Re: [PR] KAFKA-15174: Ensure CommitAsync propagate the exception to the user [kafka]

2023-11-13 Thread via GitHub
philipnee commented on PR #14680: URL: https://github.com/apache/kafka/pull/14680#issuecomment-1809546161 Hi @lucasbru - Thanks for your feedback, the PR was updated. Would you have time to go over the comments again? Thanks! -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-15681: Add support of client-metrics in kafka-configs.sh (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on PR #14632: URL: https://github.com/apache/kafka/pull/14632#issuecomment-1809524348 There are different tests failing from previous runs and none related to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (KAFKA-15820) Add a metric to track the number of partitions under min ISR

2023-11-13 Thread Calvin Liu (Jira)
Calvin Liu created KAFKA-15820: -- Summary: Add a metric to track the number of partitions under min ISR Key: KAFKA-15820 URL: https://issues.apache.org/jira/browse/KAFKA-15820 Project: Kafka

Re: [PR] MINOR: Reduce MM2 integration test flakiness due to missing dummy offset commits [kafka]

2023-11-13 Thread via GitHub
github-actions[bot] commented on PR #13911: URL: https://github.com/apache/kafka/pull/13911#issuecomment-1809490953 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15574; [1/N]: Client state machine updates [kafka]

2023-11-13 Thread via GitHub
kirktrue commented on code in PR #14690: URL: https://github.com/apache/kafka/pull/14690#discussion_r1391862343 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -1093,6 +1099,10 @@ private void subscribeInternal(Collection

Re: [PR] KAFKA-15448: Streams Standby Update Listener (KIP-988) [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391891296 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -70,6 +71,7 @@ import static

Re: [PR] KAFKA-13152: Kip 770 buffer size fix [kafka]

2023-11-13 Thread via GitHub
sean-rossignol commented on PR #13283: URL: https://github.com/apache/kafka/pull/13283#issuecomment-1809404175 Hey, anyway I could help unblock this pr @vamossagar12 ? We have an internal kstreams app with a wildcard consumer and one bottleneck we're hitting is as the number of

Re: [PR] KAFKA-15448: Streams Standby Update Listener (KIP-988) [kafka]

2023-11-13 Thread via GitHub
eduwercamacaro commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391877914 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -70,6 +71,7 @@ import static

[PR] KAFKA-15816: Fix leaked sockets in core tests [kafka]

2023-11-13 Thread via GitHub
gharris1727 opened a new pull request, #14754: URL: https://github.com/apache/kafka/pull/14754 These tests leak sockets due to various typos. Additionally, many tests leaked sockets because MiniKdc stops asynchronously, leaving sockets open at the end of the test which are eventually

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391815838 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -580,6 +583,17 @@ public void setGlobalStateRestoreListener(final StateRestoreListener

[jira] [Updated] (KAFKA-15819) KafkaServer leaks KafkaRaftManager when ZK migration enabled

2023-11-13 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15819: Priority: Minor (was: Major) > KafkaServer leaks KafkaRaftManager when ZK migration enabled >

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391848915 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -1012,6 +1022,8 @@ private void prepareChangelogs(final Map

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391818555 ## streams/src/main/java/org/apache/kafka/streams/processor/StandbyUpdateListener.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391822284 ## streams/src/main/java/org/apache/kafka/streams/processor/StandbyUpdateListener.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391818555 ## streams/src/main/java/org/apache/kafka/streams/processor/StandbyUpdateListener.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15311: Fix docs about reverting to ZooKeeper mode during KRaft migration [kafka]

2023-11-13 Thread via GitHub
cmccabe merged PR #14682: URL: https://github.com/apache/kafka/pull/14682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] MINOR Re-add action queue parameter removed from appendRecords [kafka]

2023-11-13 Thread via GitHub
jolshan opened a new pull request, #14753: URL: https://github.com/apache/kafka/pull/14753 In 91fa196930ece7342f38a5404…dfc09cf607916eb, I accidentally removed the action queue paramater that was added in 7d147cf2413e5d361422728e5c9306574658c78d I don't think this broke anything

Re: [PR] MINOR: WakeupTrigger cleanup [kafka]

2023-11-13 Thread via GitHub
kirktrue commented on PR #14752: URL: https://github.com/apache/kafka/pull/14752#issuecomment-1809303495 @philipnee Would you tag this with `ctr` and review? This is a low priority clean up. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
ableegoldman commented on PR #14735: URL: https://github.com/apache/kafka/pull/14735#issuecomment-1809299774 I'll take a look! In the meantime, can you format the PR title with the ticket number? I thought we had a guide on this somewhere but I can't find it mentioned anywhere  Anyways,

[PR] MINOR: WakeupTrigger cleanup [kafka]

2023-11-13 Thread via GitHub
kirktrue opened a new pull request, #14752: URL: https://github.com/apache/kafka/pull/14752 Added comments, made package-visible, and removed inner interface and classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-15277: Design & implement support for internal Consumer delegates [kafka]

2023-11-13 Thread via GitHub
kirktrue closed pull request #14670: KAFKA-15277: Design & implement support for internal Consumer delegates URL: https://github.com/apache/kafka/pull/14670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-15802: validate remote segment state before fetching index [kafka]

2023-11-13 Thread via GitHub
jeqo commented on code in PR #14727: URL: https://github.com/apache/kafka/pull/14727#discussion_r1391798949 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -988,30 +997,33 @@ void cleanupExpiredRemoteLogSegments() throws RemoteStorageException, ExecutionE

Re: [PR] KAFKA-15802: validate remote segment state before fetching index [kafka]

2023-11-13 Thread via GitHub
jeqo commented on code in PR #14727: URL: https://github.com/apache/kafka/pull/14727#discussion_r1391797997 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -133,6 +134,10 @@ public class RemoteLogManager implements Closeable { private static final

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
cmccabe commented on code in PR #14369: URL: https://github.com/apache/kafka/pull/14369#discussion_r1391783416 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -277,6 +279,24 @@ class BrokerServer( time ) + if (config.logDirs.size > 1) {

[PR] KAFKA-15819: Fix leaked KafkaRaftManager in ZK mode during migration [kafka]

2023-11-13 Thread via GitHub
gharris1727 opened a new pull request, #14751: URL: https://github.com/apache/kafka/pull/14751 The other call sites for KafkaRaftManager (SharedServer, TestRaftServer, MetadataShell) appear to shutdown the KafkaRaftManager when shutting down themselves. The call-site in ZK-mode KafkaServer

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
cmccabe commented on code in PR #14369: URL: https://github.com/apache/kafka/pull/14369#discussion_r1391782832 ## core/src/main/java/kafka/server/AssignmentsManager.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
cmccabe commented on code in PR #14369: URL: https://github.com/apache/kafka/pull/14369#discussion_r1391781726 ## core/src/main/java/kafka/server/AssignmentsManager.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
cmccabe commented on code in PR #14369: URL: https://github.com/apache/kafka/pull/14369#discussion_r1391780510 ## core/src/main/java/kafka/server/AssignmentsManager.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Created] (KAFKA-15819) KafkaServer leaks KafkaRaftManager when ZK migration enabled

2023-11-13 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15819: --- Summary: KafkaServer leaks KafkaRaftManager when ZK migration enabled Key: KAFKA-15819 URL: https://issues.apache.org/jira/browse/KAFKA-15819 Project: Kafka

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
cmccabe commented on code in PR #14369: URL: https://github.com/apache/kafka/pull/14369#discussion_r1391779074 ## core/src/main/java/kafka/server/AssignmentsManager.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Updated] (KAFKA-15818) Implement max poll internval

2023-11-13 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15818: --- Description: The consumer needs to be polled at a candance lower than MAX_POLL_INTERVAL_MAX

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
cmccabe commented on PR #14369: URL: https://github.com/apache/kafka/pull/14369#issuecomment-1809242988 I don't know if we want to do this in this PR, but one thing I would suggest for ReplicaManager is to use the `FaultHandler` paradigm we have in the `QuorumController` code.

[jira] [Updated] (KAFKA-15818) Implement max poll internval

2023-11-13 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15818: --- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Implement max poll internval >

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
cmccabe commented on PR #14369: URL: https://github.com/apache/kafka/pull/14369#issuecomment-1809239029 I don't have a good place to put this comment (github only lets me comment on changed lines) but there is a problem with this code: ``` private class

[jira] [Created] (KAFKA-15818) Implement max poll internval

2023-11-13 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15818: -- Summary: Implement max poll internval Key: KAFKA-15818 URL: https://issues.apache.org/jira/browse/KAFKA-15818 Project: Kafka Issue Type: Task

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
cmccabe commented on code in PR #14369: URL: https://github.com/apache/kafka/pull/14369#discussion_r1391771537 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -2323,15 +2326,56 @@ class ReplicaManager(val config: KafkaConfig, }

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
cmccabe commented on code in PR #14369: URL: https://github.com/apache/kafka/pull/14369#discussion_r1391770284 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -269,7 +270,9 @@ class ReplicaManager(val config: KafkaConfig,

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
cmccabe commented on code in PR #14369: URL: https://github.com/apache/kafka/pull/14369#discussion_r1391763417 ## clients/src/main/java/org/apache/kafka/common/requests/AssignReplicasToDirsRequest.java: ## @@ -27,6 +27,8 @@ public class AssignReplicasToDirsRequest extends

Re: [PR] KAFKA-15663, KAFKA-15794: telemetry reporter and request handling (KIP-714) [kafka]

2023-11-13 Thread via GitHub
AndrewJSchofield commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1391738283 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,914 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Created] (KAFKA-15817) Avoid reconnecting to the same IP address if multiple addresses are available

2023-11-13 Thread Bob Barrett (Jira)
Bob Barrett created KAFKA-15817: --- Summary: Avoid reconnecting to the same IP address if multiple addresses are available Key: KAFKA-15817 URL: https://issues.apache.org/jira/browse/KAFKA-15817 Project:

[jira] [Assigned] (KAFKA-15817) Avoid reconnecting to the same IP address if multiple addresses are available

2023-11-13 Thread Bob Barrett (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bob Barrett reassigned KAFKA-15817: --- Assignee: Bob Barrett > Avoid reconnecting to the same IP address if multiple addresses

Re: [PR] KAFKA-15555: Ensure wakeups are handled correctly in poll() [kafka]

2023-11-13 Thread via GitHub
philipnee commented on PR #14746: URL: https://github.com/apache/kafka/pull/14746#issuecomment-1809158196 Another point I want to make here is that the wakeup call also wakes-up the blocking client. I wonder if we also need to do that to the network thread - @kirktrue -- This is an

Re: [PR] KAFKA-15555: Ensure wakeups are handled correctly in poll() [kafka]

2023-11-13 Thread via GitHub
philipnee commented on PR #14746: URL: https://github.com/apache/kafka/pull/14746#issuecomment-1809152957 Hi @cadonna - Thank you for putting time into this PR. Based on my understanding this PR does 2 things: if wakeup() is invoked before calling poll(), the consumer will return

Re: [PR] KAFKA-15663, KAFKA-15794: telemetry reporter and request handling (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on PR #14724: URL: https://github.com/apache/kafka/pull/14724#issuecomment-1809112163 > Hi @apoorvmittal10 - I left some questions while making the first pass of the PR. They are all aesthetics. Will follow up with more questions. Thanks! Thanks @philipnee ,

Re: [PR] KAFKA-15663, KAFKA-15794: telemetry reporter and request handling (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1391701379 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,922 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15663, KAFKA-15794: telemetry reporter and request handling (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1391700892 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: telemetry reporter and request handling (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1391699676 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: telemetry reporter and request handling (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1391699120 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,922 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15663, KAFKA-15794: telemetry reporter and request handling (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1391698780 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,922 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15663, KAFKA-15794: telemetry reporter and request handling (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1391698419 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,922 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15663, KAFKA-15794: telemetry reporter and request handling (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1391698213 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryUtils.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Resolved] (KAFKA-15532) ZkWriteBehindLag should not be reported by inactive controllers

2023-11-13 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-15532. -- Resolution: Fixed > ZkWriteBehindLag should not be reported by inactive controllers >

[jira] [Assigned] (KAFKA-15532) ZkWriteBehindLag should not be reported by inactive controllers

2023-11-13 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-15532: Assignee: David Arthur > ZkWriteBehindLag should not be reported by inactive controllers

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on PR #14699: URL: https://github.com/apache/kafka/pull/14699#issuecomment-1809013650 > @apoorvmittal10 : Thanks for the PR. Made a pass of non-testing files. Left a few comments. Thanks a lot for the review @junrao . I have addressed the comments and have a

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391660088 ## core/src/main/java/kafka/metrics/ClientMetricsReceiverPlugin.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391659830 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable { public

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391659127 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable { public

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391658586 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable { public

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391658438 ## core/src/main/java/kafka/metrics/ClientMetricsInstance.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391656533 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable { public

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391656238 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable { public

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391654569 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -16,12 +16,48 @@ */ package kafka.server; +import java.util.Collections; Review

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391652781 ## clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java: ## @@ -71,6 +73,31 @@ public PushTelemetryRequestData data() {

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391651232 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable { public

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391650483 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable { public

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391648051 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Updated] (KAFKA-15813) Improve implementation of client instance cache

2023-11-13 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-15813: -- Summary: Improve implementation of client instance cache (was: Improve implementation of

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391640685 ## core/src/main/java/kafka/metrics/ClientMetricsInstanceMetadata.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391639061 ## core/src/main/java/kafka/metrics/ClientMetricsConfigs.java: ## @@ -80,6 +82,11 @@ public class ClientMetricsConfigs { public static final String

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391636101 ## clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java: ## @@ -71,6 +73,31 @@ public PushTelemetryRequestData data() {

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
apoorvmittal10 commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391634085 ## clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java: ## @@ -71,6 +73,31 @@ public PushTelemetryRequestData data() {

Re: [PR] KAFKA-15756: Migrate existing integration tests to run old protocol in new coordinator [kafka]

2023-11-13 Thread via GitHub
dongnuo123 commented on code in PR #14675: URL: https://github.com/apache/kafka/pull/14675#discussion_r1391629976 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -29,7 +29,7 @@ import org.junit.jupiter.params.provider.ValueSource class

Re: [PR] KAFKA-15277: Design & implement support for internal Consumer delegates [kafka]

2023-11-13 Thread via GitHub
kirktrue commented on PR #14670: URL: https://github.com/apache/kafka/pull/14670#issuecomment-1808930992 > re-triggered a build as the last one did not look good. I only just now updated my branch to include the revert commits, so I wouldn't necessarily expect that test run to

[jira] [Updated] (KAFKA-15816) Typos in tests leak network sockets

2023-11-13 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15816: Description: There are a few tests which leak network sockets due to small typos in the tests

[PR] KAFKA-15816: Fix leaked sockets in clients tests [kafka]

2023-11-13 Thread via GitHub
gharris1727 opened a new pull request, #14750: URL: https://github.com/apache/kafka/pull/14750 These tests leak network sockets unnecessarily, and should instead properly close the resources they instantiate. I found these via some tests which are not merge-able, as they rely on

[jira] [Created] (KAFKA-15816) Typos in tests leak network sockets

2023-11-13 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15816: --- Summary: Typos in tests leak network sockets Key: KAFKA-15816 URL: https://issues.apache.org/jira/browse/KAFKA-15816 Project: Kafka Issue Type: Bug

[PR] KIP-1001: Add CurrentControllerId metric [kafka]

2023-11-13 Thread via GitHub
cmccabe opened a new pull request, #14749: URL: https://github.com/apache/kafka/pull/14749 As discussed on KIP-1001 (not yet approved) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (KAFKA-15815) JsonRestServer leaks sockets via HttpURLConnection when keep-alive enabled

2023-11-13 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15815: --- Summary: JsonRestServer leaks sockets via HttpURLConnection when keep-alive enabled Key: KAFKA-15815 URL: https://issues.apache.org/jira/browse/KAFKA-15815 Project:

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
junrao commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391496243 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-15778 & KAFKA-15779: Implement metrics manager (KIP-714) [kafka]

2023-11-13 Thread via GitHub
junrao commented on code in PR #14699: URL: https://github.com/apache/kafka/pull/14699#discussion_r1391490591 ## core/src/main/java/kafka/server/ClientMetricsManager.java: ## @@ -34,13 +70,348 @@ public class ClientMetricsManager implements Closeable { public static

[PR] KAFKA-15814 Patched the SASL/GSSAPI server construction [kafka]

2023-11-13 Thread via GitHub
piotrsmolinski opened a new pull request, #14748: URL: https://github.com/apache/kafka/pull/14748 The patch fixes how the SASL/GSSAPI server is created in Kafka brokers. As described in the JIRA ticket, Kafka forces client JAAS configuration for both client and server side. This

[jira] [Commented] (KAFKA-15481) Concurrency bug in RemoteIndexCache leads to IOException

2023-11-13 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785597#comment-17785597 ] Divij Vaidya commented on KAFKA-15481: -- Yes, it has lots of merge conflicts because of another

Re: [PR] KAFKA-15802: validate remote segment state before fetching index [kafka]

2023-11-13 Thread via GitHub
divijvaidya commented on code in PR #14727: URL: https://github.com/apache/kafka/pull/14727#discussion_r1391297279 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -988,30 +997,33 @@ void cleanupExpiredRemoteLogSegments() throws RemoteStorageException,

Re: [PR] MINOR: Fix ClusterConnectionStatesTest.testSingleIP [kafka]

2023-11-13 Thread via GitHub
jolshan commented on PR #14741: URL: https://github.com/apache/kafka/pull/14741#issuecomment-1808642447 Shall we backport this to 3.6 as well? Maybe not a huge deal, but I see it causing some issues there too. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] cherrypick KAFKA-15780: Wait for consistent KRaft metadata when creating or deleting topics [kafka]

2023-11-13 Thread via GitHub
jolshan merged PR #14713: URL: https://github.com/apache/kafka/pull/14713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15277: Design & implement support for internal Consumer delegates [kafka]

2023-11-13 Thread via GitHub
dajac commented on PR #14670: URL: https://github.com/apache/kafka/pull/14670#issuecomment-1808636945 re-triggered a build as the last one did not look good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15357: Aggregate and propagate assignments [kafka]

2023-11-13 Thread via GitHub
pprovenzano commented on PR #14369: URL: https://github.com/apache/kafka/pull/14369#issuecomment-1808630427 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (KAFKA-15814) SASL Kerberos authentication cannot be used with load balanced bootstrap

2023-11-13 Thread Piotr Smolinski (Jira)
Piotr Smolinski created KAFKA-15814: --- Summary: SASL Kerberos authentication cannot be used with load balanced bootstrap Key: KAFKA-15814 URL: https://issues.apache.org/jira/browse/KAFKA-15814

[jira] [Commented] (KAFKA-15481) Concurrency bug in RemoteIndexCache leads to IOException

2023-11-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785578#comment-17785578 ] Mickael Maison commented on KAFKA-15481: [~divijvaidya] Is there an issue that's preventing the

Re: [PR] KAFKA-15774: refactor windowed stores to use StoreFactory [kafka]

2023-11-13 Thread via GitHub
agavra commented on PR #14708: URL: https://github.com/apache/kafka/pull/14708#issuecomment-1808460098 Ah same! Apologies, I made the same mistake. Will remember next time to look over the individual JDKs. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (KAFKA-15513) KRaft cluster fails with SCRAM authentication enabled for control-plane

2023-11-13 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785540#comment-17785540 ] Proven Provenzano commented on KAFKA-15513: --- SCRAM between controllers will need work as we

Re: [PR] KIP-988 [kafka]

2023-11-13 Thread via GitHub
eduwercamacaro commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1391293607 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -70,6 +71,7 @@ import static

[jira] [Updated] (KAFKA-15420) Kafka Tiered Storage V1

2023-11-13 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15420: - Affects Version/s: 3.6.0 > Kafka Tiered Storage V1 > --- > >

[jira] [Commented] (KAFKA-15605) Topics marked for deletion in ZK are incorrectly migrated to KRaft

2023-11-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785526#comment-17785526 ] Ismael Juma commented on KAFKA-15605: - The PR was merged, can this be closed [~davidarthur] ? >

[jira] [Commented] (KAFKA-15552) Duplicate Producer ID blocks during ZK migration

2023-11-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785522#comment-17785522 ] Ismael Juma commented on KAFKA-15552: - [~showuon] Can this be closed then? > Duplicate Producer ID

[PR] Revert "Revert "KAFKA-15661: KIP-951: Server side changes (#14444)" [kafka]

2023-11-13 Thread via GitHub
chb2ab opened a new pull request, #14747: URL: https://github.com/apache/kafka/pull/14747 Investigating `org.apache.kafka.tiered.storage.integration.ReassignReplicaShrinkTest` failure This reverts commit a98bd7d65fb5a3a188ff524db7619dc7fe4257fa. *More detailed description of

[jira] [Commented] (KAFKA-13627) Topology changes shouldn't require a full reset of local state

2023-11-13 Thread Nicholas Telford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785518#comment-17785518 ] Nicholas Telford commented on KAFKA-13627: -- Hi, I've temporarily parked KIP-816 to focus on

  1   2   >